Re: [libvirt] [PATCH v2 04/14] libxl: support backend domain setting for disk and net devices

2013-06-14 Thread Jim Fehlig
Marek Marczykowski-Górecki wrote: > This implement handling of parameter introduced in > previous patch. > > Lookup on domain name (to get domain ID) requires libxlDriverPrivate > object, so it must be passed down to libxlMakeDisk and libxlMakeNet from > top level callers. > > Changes in v2: > -

[libvirt] [libvirt-php PATCH 2/2] Add optional flags parameter to domain_create

2013-06-14 Thread Tiziano Müller
Instead of adding another function libvirt_domain_create_with_flags simply add an optional argument to libvirt_domain_create which defaults to VIR_DOMAIN_NONE and call virDomainCreateWithFlags internally instead. --- src/libvirt-php.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-)

[libvirt] [libvirt-php PATCH 1/2] Add wrappers for virDomainGetBlockJobInfo and virDomainBlockPull.

2013-06-14 Thread Tiziano Müller
From: Tiziano Müller --- src/libvirt-php.c | 83 ++- src/libvirt-php.h | 2 ++ 2 files changed, 84 insertions(+), 1 deletion(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index 0b8345a..834eff8 100644 --- a/src/libvirt-php.c +++ b/src

[libvirt] [libvirt-php PATCH 0/2] Block job wrappers and possibility to start VM in paused state

2013-06-14 Thread Tiziano Müller
Following are two patches extending the PHP wrapper a bit: * first patch adds wrappers for virDomainGetBlockJobInfo and virDomainBlockPull * second patch makes it possible to start a VM in paused state to start a Qemu-process for the virDomainBlockPull if no VM is running Best, Tiziano Tiziano

[libvirt] [PATCH] Add optional serial id for USB devices in hostdev

2013-06-14 Thread david . waring
From: David Waring This patch adds the ability to include a serial element in a hostdev/source to select a device with a particular serial number. Patch for bugzilla #914883. This allows specific USB devices to attached to guests when there may be more than one of the same USB device attached to

Re: [libvirt] [PATCH V2] Expose all CPU features in host definition

2013-06-14 Thread Don Dugger
On Fri, Jun 14, 2013 at 03:06:52PM +0200, Jiri Denemark wrote: > Hi Don, > > I'm sorry for the delay... NP. > > On Fri, May 31, 2013 at 13:04:17 -0600, Don Dugger wrote: > > On Thu, May 30, 2013 at 01:48:32PM +0200, Jiri Denemark wrote: > > > On Tue, May 28, 2013 at 16:11:57 -0600, Don Dugger w

Re: [libvirt] [PATCH v2 03/14] conf: support backend domain name in disk and network devices

2013-06-14 Thread Jim Fehlig
Marek Marczykowski-Górecki wrote: > At least Xen supports backend drivers in another domain (aka "driver > domain"). This patch introduces XML config option for such setting as > 'domain' element with 'name' attribute. Verification its content is left > for the driver. > > In the future some option

Re: [libvirt] [PATCH v2 02/14] libxl: populate xenstore memory entries at startup, handle dom0_mem

2013-06-14 Thread Jim Fehlig
Marek Marczykowski-Górecki wrote: > libxl uses some xenstore entries for hints in memory management > (especially when starting new domain). This includes dom0 memory limit > and Xen free memory margin, based on current system state. Entries are > created at first function usage, so force such call

Re: [libvirt] [PATCH 4/7] storage: add support for creating qcow2 images with extensions

2013-06-14 Thread Martin Kletzander
On 06/10/2013 02:10 PM, Ján Tomko wrote: > Add -o compat= and -o lazy_refcounts options for qemu-img. > --- > src/storage/storage_backend.c | 36 > +++-- > tests/storagevolxml2argvdata/qcow2-1.1.argv | 1 + > tests/storagevolxml2argvdata/qcow2-lazy.argv

Re: [libvirt] [PATCH 3/7] conf: add features to volume target XML

2013-06-14 Thread Martin Kletzander
On 06/10/2013 02:10 PM, Ján Tomko wrote: > Add and elements to volume target XML. > > is a string which for qcow2 represents the QEMU version > it should be compatible with. Valid values are 0.10 and 1.1. > 1.1 is implicit if the element is present, otherwise > qemu-img default is used. 0.10 c

Re: [libvirt] [PATCH v4 1/3] Make virNetDevSetupControl() public.

2013-06-14 Thread Michal Privoznik
On 13.06.2013 08:26, Roman Bogorodskiy wrote: > This method is useful not only in virnetdev.c. > --- > src/libvirt_private.syms | 1 + > src/util/virnetdev.c | 15 +-- > src/util/virnetdev.h | 14 +- > 3 files changed, 27 insertions(+), 3 deletions(-) > > diff --g

Re: [libvirt] [PATCH v4 0/3] BSD implementation of virNetDevTapCreate() and virNetDevTapDelete()

2013-06-14 Thread Michal Privoznik
On 13.06.2013 08:26, Roman Bogorodskiy wrote: > Changes from v3: > > * Include linux/if.h header fix so it won't lost why Eric is on vacation > * Fix struct virIfreq definition in case when HAVE_STRUCT_IFREQ is not >defined (thanks to Laine Stump for noticing that) > > Roman Bogorodskiy (3)

[libvirt] [PATCH] Add ability to attach USB devices to guests using vendor, product and serial id.

2013-06-14 Thread david . waring
From: David Waring --- docs/formatdomain.html.in | 21 +++- src/conf/domain_conf.c | 18 +++-- src/conf/domain_conf.h | 1 + src/conf/node_device_conf.c | 5 + src/conf/node_device_conf.h | 1 + src/lxc/lxc_hostdev.c | 5 +++-- src/qemu/qemu_

Re: [libvirt] [PATCH V2] Expose all CPU features in host definition

2013-06-14 Thread Jiri Denemark
Hi Don, I'm sorry for the delay... On Fri, May 31, 2013 at 13:04:17 -0600, Don Dugger wrote: > On Thu, May 30, 2013 at 01:48:32PM +0200, Jiri Denemark wrote: > > On Tue, May 28, 2013 at 16:11:57 -0600, Don Dugger wrote: > > > The virConnectGetCapabilities API describes the host capabilities > > >

[libvirt] [RFC] conf: Order of AddImplicitControllers and DomainDefPostParse

2013-06-14 Thread Viktor Mihajlovski
Implicit controllers may be dependent on device definitions altered in a post-parse callback. E.g., if a console device is defined without the target type, the type will be set in QEMU's callback. In the case of s390, this is virtio, which requires an implicit virtio-serial controller. By moving t

[libvirt] KVM Forum 2013 Call for Participation

2013-06-14 Thread KVM-Forum-2013-PC
= KVM Forum 2013: Call For Participation October 21-23, 2013 - Edinburgh International Conference Centre - Edinburgh, UK (All submissions must be received before midnight July 21, 2013)

[libvirt] VM waiting to start long time

2013-06-14 Thread Cuongds
Hi all, I'm have problem with my ovirt. Yesterday, my ovirt nodes (4 nodes) still working fine but today i cannot start vm on one of ovirt nodes (node 2), other node are fine. The status holding "waiting to start" when i try start vm (new or old vm has same result) Log vdsm as below: Many attemp

Re: [libvirt] [PATCH v2] udev: fix crash in libudev logging

2013-06-14 Thread Ján Tomko
On 06/14/2013 11:18 AM, Michal Privoznik wrote: > On 14.06.2013 10:53, Guannan Ren wrote: >> On 06/13/2013 09:56 PM, Ján Tomko wrote: >>> +virBuffer buf = VIR_BUFFER_INITIALIZER; >>> +const char *format = NULL; >>> + >>> +virBufferAdd(&buf, fmt, -1); >>> +virBufferTrim(&buf, "\n", -

Re: [libvirt] [PATCH 0/2] Don't always fail migrations on I/O errors

2013-06-14 Thread Michal Privoznik
On 12.06.2013 16:11, Peter Krempa wrote: > Recently I've added code that aborts migration in case of I/O error. This may > not be desirable as qemu does actually support such migration. This series > adds > a flag that enables this option that will be now disabled by default. > > Peter Krempa (2)

[libvirt] [PATCH v7 1/6] libvirt: Define domain crash event types

2013-06-14 Thread Chen Fan
This patch introduces domain crashed types and crashed reasons which will be used while guest panicked. --- examples/domain-events/events-c/event-test.c | 10 ++ include/libvirt/libvirt.h.in | 16 src/conf/domain_conf.c | 12 --

[libvirt] [PATCH v7 2/6] qemu: Refactor the processwatchdogEvent code that can make the driver workpool more generalized

2013-06-14 Thread Chen Fan
--- src/qemu/qemu_domain.h | 10 ++-- src/qemu/qemu_driver.c | 65 +++-- src/qemu/qemu_process.c | 13 +- 3 files changed, 56 insertions(+), 32 deletions(-) diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h index f241296..aedb66

[libvirt] [PATCH v7 5/6] qemu: Implement 'oncrash' coredump events when guest panicked

2013-06-14 Thread Chen Fan
Add doDumpCoreToAutoPath to implement 'coredump-destroy' and 'coredump-restart' events of the 'on_crash' in the XML when domain crashed. --- src/qemu/qemu_driver.c | 65 ++ 1 file changed, 65 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/q

[libvirt] [PATCH v7 0/6] libvirt supports Guest Panicked

2013-06-14 Thread Chen Fan
Changes: v6-v7: implement the rename-restart behavior. v5-v6: Refactor the patches, and fix the incorrect indentation and name. v4-v5: 1. fix the incorrect indentation and explanation (of some reasons). v3-v4: 1. Supports the dumpcore options of the oncrash element in the XML.

[libvirt] [PATCH v7 6/6] qemu: Implement oncrash 'rename-resart' event when guest panicked

2013-06-14 Thread Chen Fan
Implements 'rename-restart' behavior of the 'on_crash' in the XML when domain crashed. --- src/qemu/qemu_driver.c | 67 ++ 1 file changed, 67 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index eefe7a2..a166468 100644 --

[libvirt] [PATCH v7 4/6] qemu: Implement 'oncrash' events when guest panicked

2013-06-14 Thread Chen Fan
Add monitor callback API domainGuestPanic, that implements 'destroy', 'restart' and 'preserve' events of the 'on_crash' in the XML when domain crashed. --- src/qemu/qemu_domain.h | 1 + src/qemu/qemu_driver.c | 92 src/qemu/qemu_monitor.c

[libvirt] [PATCH v7 3/6] qemu: Need to use qemuProcessShutdownOrReboot(), so we defined it at qemu_process.h

2013-06-14 Thread Chen Fan
--- src/qemu/qemu_process.c | 2 +- src/qemu/qemu_process.h | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 7a1535e..163bd96 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -611,7 +611,7 @@ cleanup

Re: [libvirt] [PATCH] LXC: s/chroot/chdir in lxcContainerPivotRoot()

2013-06-14 Thread Michal Privoznik
On 14.06.2013 08:57, Richard Weinberger wrote: > ...fixes a trivial copy&paste error. > > Signed-off-by: Richard Weinberger > --- > src/lxc/lxc_container.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c > index 7531

Re: [libvirt] [PATCH 5/7] conf: split out snapshot disk XML formatting

2013-06-14 Thread Martin Kletzander
On 06/10/2013 02:10 PM, Ján Tomko wrote: > Just to reduce the indentation levels. Remove the unneeded > NULL check for disk->file, as virBufferEscapeString doesn't > print anything with NULL arguments. > --- > src/conf/snapshot_conf.c | 53 > ++-- > 1 f

Re: [libvirt] [PATCH v2] udev: fix crash in libudev logging

2013-06-14 Thread Michal Privoznik
On 14.06.2013 10:53, Guannan Ren wrote: > On 06/13/2013 09:56 PM, Ján Tomko wrote: >> Call virLogVMessage instead of virLogMessage, since libudev >> called us with a va_list object, not a list of arguments. >> >> Honor message priority and strip the trailing newline. >> >> https://bugzilla.redhat.c

Re: [libvirt] [PATCH v2] udev: fix crash in libudev logging

2013-06-14 Thread Guannan Ren
On 06/13/2013 09:56 PM, Ján Tomko wrote: Call virLogVMessage instead of virLogMessage, since libudev called us with a va_list object, not a list of arguments. Honor message priority and strip the trailing newline. https://bugzilla.redhat.com/show_bug.cgi?id=969152 --- v1: https://www.redhat.com

Re: [libvirt] [PATCH] remote: Fix client crash when URI path is empty when using ssh

2013-06-14 Thread Peter Krempa
On 06/14/13 10:48, Peter Krempa wrote: The parsed path in the URI may be NULL resulting into: $ virsh -c qemu+ssh:// list Segmentation fault (core dumped) Introduced by 22d81ceb46ea4b83ad817c29b2b04df27a09c671 --- src/remote/remote_driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [libvirt] [PATCH] LXC: Check container init path after pivot_root()

2013-06-14 Thread Gao feng
On 06/14/2013 03:26 PM, Gao feng wrote: > On 06/14/2013 02:53 PM, Richard Weinberger wrote: >> Currently we check the path before changing the root directory. >> This cannot work. Do the check after pivot_root() such that >> we check for the patch within the correct root. >> > > Ok, I know why...

[libvirt] [PATCH] remote: Fix client crash when URI path is empty when using ssh

2013-06-14 Thread Peter Krempa
The parsed path in the URI may be NULL resulting into: $ virsh -c qemu+ssh:// list Segmentation fault (core dumped) Introduced by 22d81ceb46ea4b83ad817c29b2b04df27a09c671 --- src/remote/remote_driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/remote/remote_

Re: [libvirt] [PATCH] LXC: Ensure the init task of container comes from container

2013-06-14 Thread Gao feng
On 06/14/2013 02:54 PM, Richard Weinberger wrote: > Am 14.06.2013 07:54, schrieb Gao feng: >> Richard found libvirt_lxc execs the lxc init programs within >> the wrong rootfs context, we should run this init task from >> the rootfs of container. >> >> So chroot to the root directory of container, M

Re: [libvirt] [PATCH] LXC: Check container init path after pivot_root()

2013-06-14 Thread Gao feng
On 06/14/2013 02:53 PM, Richard Weinberger wrote: > Currently we check the path before changing the root directory. > This cannot work. Do the check after pivot_root() such that > we check for the patch within the correct root. > Ok, I know why... This bug is introduced by my patchset, I'm tryin

[libvirt] [PATCH] LXC: s/chroot/chdir in lxcContainerPivotRoot()

2013-06-14 Thread Richard Weinberger
...fixes a trivial copy&paste error. Signed-off-by: Richard Weinberger --- src/lxc/lxc_container.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index 7531fea..c4056c3 100644 --- a/src/lxc/lxc_container.c +++ b/src/lxc/l