Re: [libvirt] [PATCH] libxl: Allow libxl to set NIC devid

2013-06-21 Thread Jiri Denemark
On Thu, Jun 20, 2013 at 11:47:18 -0600, Jim Fehlig wrote: libxl contains logic to determine an appropriate devid for new devices that do not specify one in their configuration. For all device types except NICs, the libxl driver allows libxl to determine devid. Do the same for NICs. ---

Re: [libvirt] [PATCH] conf: Requires either uuid or usage of secret

2013-06-21 Thread Jiri Denemark
On Thu, Jun 20, 2013 at 18:27:04 +0800, Osier Yang wrote: As the RNG schema for disk auth secret implies, it requires either uuid or secret: s/secret/usage/ This requirement also matches documentation. ACK Jirka -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH] qemu: Make probing for commands declarative

2013-06-21 Thread Jiri Denemark
On Wed, Jun 19, 2013 at 10:32:11 +0200, Jano Tomko wrote: On 06/19/2013 10:05 AM, Jiri Denemark wrote: --- src/qemu/qemu_capabilities.c | 53 ++-- 1 file changed, 21 insertions(+), 32 deletions(-) ACK Thanks, pushed. Jirka -- libvir-list

Re: [libvirt] [PATCH] qemu: Make probing for events declarative

2013-06-21 Thread Jiri Denemark
On Wed, Jun 19, 2013 at 10:32:10 +0200, Jano Tomko wrote: On 06/19/2013 10:05 AM, Jiri Denemark wrote: --- src/qemu/qemu_capabilities.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) ACK Pushed, thanks. Jirka -- libvir-list mailing list

Re: [libvirt] [PATCH] conf: Requires either uuid or usage of secret

2013-06-21 Thread Jiri Denemark
On Fri, Jun 21, 2013 at 09:13:58 +0200, Jiri Denemark wrote: On Thu, Jun 20, 2013 at 18:27:04 +0800, Osier Yang wrote: As the RNG schema for disk auth secret implies, it requires either uuid or secret: s/secret/usage/ This requirement also matches documentation. ACK Fixed and

Re: [libvirt] [PATCH] snapshot: fix snapshot-delete option check error

2013-06-21 Thread Ján Tomko
On 06/12/2013 11:27 AM, Guannan Ren wrote: For descendant of a snapshot, we need to check if they are external for both flag VIR_DOMAIN_SNAPSHOT_DELETE_CHILDREN and VIR_DOMAIN_SNAPSHOT_DELETE_CHILDREN_ONLY For the snapshot itself, only check it if VIR_DOMAIN_SNAPSHOT_DELETE_CHILDREN is given.

Re: [libvirt] [PATCH v2 1/8] domain_conf: Introduce chardev hotplug helpers

2013-06-21 Thread Martin Kletzander
On 06/06/2013 02:29 PM, Michal Privoznik wrote: For now, only these three helpers are needed: virDomainChrFind - to find a duplicate chardev within VM def virDomainChrInsert - wrapper for inserting a new chardev into VM def virDomainChrRemove - wrapper for removing chardev from VM def There

[libvirt] Introduction of virDomainDefPtr resulted in deadlock in xenUnifiedDomainGetXMLDesc

2013-06-21 Thread Stefan Bader
The problem is the mutex lock on xenUnifiedPrivatePtr which is held around xenDomainUsedCpus. xenUnifiedDomainGetXMLDesc ... xenUnifiedLock(priv); cpus = xenDomainUsedCpus(dom); xenUnifiedUnlock(priv); ... Unfortunately the introduction of virDomainDefPtr added the following call paths

Re: [libvirt] [PATCH 1/2] BSD: implement virNetDevBridgeCreate() and virNetDevBridgeDelete()

2013-06-21 Thread Jiri Denemark
On Wed, Jun 19, 2013 at 20:47:30 +0400, Roman Bogorodskiy wrote: Implementation uses SIOCIFCREATE2 and SIOCIFDESTROY ioctls. Also, drop static virNetDevSetupControl() as we have public one avialable now. --- src/util/virnetdevbridge.c | 91 -- 1

Re: [libvirt] [PATCH 00/19] Fine grained access control for libvirt APIs

2013-06-21 Thread Michal Privoznik
On 19.06.2013 19:00, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com This is a repost of http://www.redhat.com/archives/libvir-list/2012-May/msg00090.html Most of the early patches in that series are now merged. What is left is the actual access control work.

Re: [libvirt] [PATCH 02/19] Set conn-driver before running driver connectOpen method

2013-06-21 Thread Michal Privoznik
On 19.06.2013 19:00, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The access control checks in the 'connectOpen' driver method will require 'conn-driver' to be non-NULL. Set this before running the 'connectOpen' method and NULL-ify it again on failure.

Re: [libvirt] [PATCH 01/19] Define basic internal API for access control

2013-06-21 Thread Michal Privoznik
On 19.06.2013 19:00, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com This patch introduces the virAccessManagerPtr class as the interface between virtualization drivers and the access control drivers. The viraccessperm.h file defines the various permissions that will

Re: [libvirt] [PATCH 07/19] Auto-generate helpers for checking access control rules

2013-06-21 Thread Michal Privoznik
On 19.06.2013 19:00, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Extend the 'gendispatch.pl' script to be able to generate three new types of file. - 'aclheader' - defines signatures of helper APIs for doing authorization checks. There is one helper API for

Re: [libvirt] [PATCH 19/19] Add validation that all APIs contain ACL checks

2013-06-21 Thread Michal Privoznik
On 19.06.2013 19:01, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Add a script which parses the driver API code and validates that every API registered in a virNNNDriverPtr table contains an ACL check matching the API name. Signed-off-by: Daniel P. Berrange

Re: [libvirt] [PATCH 03/19] Setup default access control manager in libvirtd

2013-06-21 Thread Michal Privoznik
On 19.06.2013 19:00, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Add a new 'access_drivers' config parameter to the libvirtd.conf configuration file. This allows admins to setup the default access control drivers to use for API authorization. The same driver is to

Re: [libvirt] configuring a disconnected interface

2013-06-21 Thread Daniel P. Berrange
On Thu, Jun 20, 2013 at 12:42:14PM -0400, Laine Stump wrote: To summarize all that: 1) I think we can just use an omission of the source to indicate that an interface shouldn't be connected to anything, both for type='bridge' and type='network'. I think that it pretty dangerous. There are

Re: [libvirt] configuring a disconnected interface

2013-06-21 Thread Daniel P. Berrange
On Thu, Jun 20, 2013 at 02:42:31PM +0300, Dan Kenigsberg wrote: Hi List, Like most of us, I've bought my actual computer with an Ethernet interface card, that I can connect to a wall jack at will. It's quite easy to disconnect the Ethernet cable from the wall, as well. I would like to

Re: [libvirt] [PATCH v4] qemu: add hv_vapic and hv_spinlocks support

2013-06-21 Thread Jiri Denemark
On Tue, Jun 18, 2013 at 16:59:30 +0200, Jano Tomko wrote: Add new CPU flags for HyperV: hv_vapic for virtual APIC support hv_spinlocks for spinlock support XML: features hyperv vapic state='on'/ spinlocks state='on'0x/spinlocks /hyperv /features I think it's mostly

Re: [libvirt] [PATCH] snapshot: fix snapshot-delete option check error

2013-06-21 Thread Guannan Ren
On 06/21/2013 04:13 PM, Ján Tomko wrote: On 06/12/2013 11:27 AM, Guannan Ren wrote: For descendant of a snapshot, we need to check if they are external for both flag VIR_DOMAIN_SNAPSHOT_DELETE_CHILDREN and VIR_DOMAIN_SNAPSHOT_DELETE_CHILDREN_ONLY For the snapshot itself, only check it if

Re: [libvirt] [PATCH 1/5] snapshot: define new API virDomainSnapshotDeleteByName

2013-06-21 Thread Ján Tomko
On 06/13/2013 02:55 PM, Guannan Ren wrote: This is to delete a snapshot object atomically, the API accepts argments: domain object, snapshot name and flags. Add a new flag VIR_DOMAIN_SNAPSHOT_DELETE_CURRENT, others are same. include/libvirt/libvirt.h.in: Declare virDomainSnapshotDeleteByName

Re: [libvirt] [PATCH v2 2/8] qemu: Implement chardev hotplug on config level

2013-06-21 Thread Martin Kletzander
On 06/06/2013 02:29 PM, Michal Privoznik wrote: There are two levels on which a device may be hotplugged: config and live. The config level requires just an insert or remove from internal domain definition structure, which is what this patch exactly does. There is currently no implementation

[libvirt] [PATCH v5 2/2] qemu: add hv_vapic and hv_spinlocks support

2013-06-21 Thread Ján Tomko
XML: features hyperv vapic state='on'/ spinlocks state='on' retries='4096'/ /hyperv /features results in the following QEMU command line: qemu -cpu cpu_model,hv_vapic,hv_spinlocks=0x https://bugzilla.redhat.com/show_bug.cgi?id=784836 --- src/qemu/qemu_command.c

[libvirt] [PATCH v5 0/2] Add new HyperV features

2013-06-21 Thread Ján Tomko
v1: https://www.redhat.com/archives/libvir-list/2013-May/msg00173.html v2: https://www.redhat.com/archives/libvir-list/2013-May/msg00184.html uses virStringSplit instead of strsep added a missing break to virDomainDefParseXML v3:

[libvirt] [PATCH v5 1/2] conf: add vapic and spinlocks to hyperv features

2013-06-21 Thread Ján Tomko
Add new CPU features for HyperV: vapic for virtual APIC support spinlocks for setting spinlock support features hyperv vapic state='on'/ spinlocks state='on' retries='4096'/ /hyperv /features https://bugzilla.redhat.com/show_bug.cgi?id=784836 --- docs/formatdomain.html.in | 17

Re: [libvirt] [PATCH v5 1/2] conf: add vapic and spinlocks to hyperv features

2013-06-21 Thread Jiri Denemark
On Fri, Jun 21, 2013 at 12:41:53 +0200, Jano Tomko wrote: Add new CPU features for HyperV: vapic for virtual APIC support spinlocks for setting spinlock support features hyperv vapic state='on'/ spinlocks state='on' retries='4096'/ /hyperv /features

Re: [libvirt] [PATCH v5 2/2] qemu: add hv_vapic and hv_spinlocks support

2013-06-21 Thread Jiri Denemark
On Fri, Jun 21, 2013 at 12:41:54 +0200, Jano Tomko wrote: XML: features hyperv vapic state='on'/ spinlocks state='on' retries='4096'/ /hyperv /features results in the following QEMU command line: qemu -cpu cpu_model,hv_vapic,hv_spinlocks=0x I believe the above XML will

Re: [libvirt] [PATCH v5 2/2] qemu: add hv_vapic and hv_spinlocks support

2013-06-21 Thread Ján Tomko
On 06/21/2013 01:18 PM, Jiri Denemark wrote: On Fri, Jun 21, 2013 at 12:41:54 +0200, Jano Tomko wrote: XML: features hyperv vapic state='on'/ spinlocks state='on' retries='4096'/ /hyperv /features results in the following QEMU command line: qemu -cpu

Re: [libvirt] [PATCH v5 3/5] storage: add support for creating qcow2 images with extensions

2013-06-21 Thread Ján Tomko
On 06/20/2013 02:00 PM, Martin Kletzander wrote: On 06/19/2013 05:24 PM, Ján Tomko wrote: Add -o compat= and -o lazy_refcounts options for qemu-img. --- src/storage/storage_backend.c | 62 ++--- tests/storagevolxml2argvdata/qcow2-1.1.argv | 1 +

Re: [libvirt] [PATCH v5 0/2] Add new HyperV features

2013-06-21 Thread Paolo Bonzini
Il 21/06/2013 12:41, Ján Tomko ha scritto: v1: https://www.redhat.com/archives/libvir-list/2013-May/msg00173.html v2: https://www.redhat.com/archives/libvir-list/2013-May/msg00184.html uses virStringSplit instead of strsep added a missing break to virDomainDefParseXML v3:

Re: [libvirt] [PATCH v5 0/2] Add new HyperV features

2013-06-21 Thread Daniel P. Berrange
On Fri, Jun 21, 2013 at 03:51:37PM +0200, Paolo Bonzini wrote: Il 21/06/2013 12:41, Ján Tomko ha scritto: v1: https://www.redhat.com/archives/libvir-list/2013-May/msg00173.html v2: https://www.redhat.com/archives/libvir-list/2013-May/msg00184.html uses virStringSplit instead of

Re: [libvirt] [PATCH v5 0/2] Add new HyperV features

2013-06-21 Thread Paolo Bonzini
Il 21/06/2013 15:56, Daniel P. Berrange ha scritto: On Fri, Jun 21, 2013 at 03:51:37PM +0200, Paolo Bonzini wrote: Il 21/06/2013 12:41, Ján Tomko ha scritto: v1: https://www.redhat.com/archives/libvir-list/2013-May/msg00173.html v2:

Re: [libvirt] [PATCH v5 0/2] Add new HyperV features

2013-06-21 Thread Ján Tomko
On 06/21/2013 04:03 PM, Paolo Bonzini wrote: Il 21/06/2013 15:56, Daniel P. Berrange ha scritto: On Fri, Jun 21, 2013 at 03:51:37PM +0200, Paolo Bonzini wrote: Il 21/06/2013 12:41, Ján Tomko ha scritto: Ján Tomko (2): conf: add vapic and spinlocks to hyperv features qemu: add hv_vapic

[libvirt] NBD server for libvirt domains using virDomainBlockPeek

2013-06-21 Thread Richard W.M. Jones
This might be of interest to developers on this list. I've written an NBD server which can serve libvirt guest disks. It uses the virDomainBlockPeek API and so is necessarily read-only. https://github.com/libguestfs/nbdkit https://github.com/libguestfs/nbdkit/tree/master/plugins/libvirt

Re: [libvirt] Investigate VM via Libvirt API

2013-06-21 Thread Richard W.M. Jones
On Thu, Jun 20, 2013 at 01:42:06PM +0300, Yaniv Hadad wrote: Hi All, I am Java developer that want to start working with Libvirt API. My first target is to investigate Host + all his instances. (CPU,Storage,Network,State,Name..etc.) Can some one give me good code example or article for

Re: [libvirt] [PATCH v5 0/2] Add new HyperV features

2013-06-21 Thread Paolo Bonzini
Il 21/06/2013 16:26, Ján Tomko ha scritto: It accepts both hv_spinlocks and hv-spinlocks (with only the latter spelling being greppable) since commit 72ac2e876ddc6158f5b6d5f758d4e38c436010ed [2] Author: Igor Mammedov imamm...@redhat.com AuthorDate: 2013-04-26 18:04:32 +0200 Commit:

Re: [libvirt] libvirt: xen error

2013-06-21 Thread Dario Faggioli
On dom, 2013-06-16 at 22:09 +0530, varun bhatnagar wrote: Hi, Hi, I am trying to install xen and provide libvrit support to it but while installing at some point of time it tries to connect to GIT repository and creates a clone but I am behind firewall and it is getting timed out :(

Re: [libvirt] [libvirt-users] Not able to open Xen Connection using libvirt

2013-06-21 Thread Dario Faggioli
On mer, 2013-06-19 at 21:33 +0530, varun bhatnagar wrote: Is this system booted with xen kernel? xen virtualization required special kernel it doesn't work with standard kernel. Well, that is not true, and it's even been a while now! :-P Fact is the Xen architecture requires

Re: [libvirt] [libvirt-users] Not able to open Xen Connection using libvirt

2013-06-21 Thread Dario Faggioli
On mer, 2013-06-19 at 21:33 +0530, varun bhatnagar wrote: No it was not booted with xen kernel. Actually I tried booting it with xen kernel but I am getting a message saying Error No 15 : File not found. What is your bootloader and how is it configured? I tried editing the grub entry and

Re: [libvirt] [PATCH 3/6] qemu: Translate the iscsi pool/volume disk source

2013-06-21 Thread John Ferlan
On 06/18/2013 04:36 AM, Osier Yang wrote: The difference with already supported pool types (dir, fs, block) is: there are two modes for iscsi pool (or network pools in future), one can specify it either to use the volume target path (the path showed up on host) with mode='host', or to use the

Re: [libvirt] [PATCH 5/6] conf: Ignore the volume type disk if its mode is uri

2013-06-21 Thread John Ferlan
On 06/18/2013 04:36 AM, Osier Yang wrote: virDomainDiskDefForeachPath is not only used by the security setting helpers, also used by cgroup setting helpers, so this is to ignore the volume type disk with mode=uri for cgroup setting. --- src/conf/domain_conf.c | 5 - 1 file changed, 4

Re: [libvirt] [PATCH 4/6] security: Ignore to manage the volume type disk if its mode is uri

2013-06-21 Thread John Ferlan
On 06/18/2013 04:36 AM, Osier Yang wrote: It's straightforward to not manage security labels for remote URI like iscsi://example.org:6000/iqn.1992-01.com.example/1. --- src/security/security_apparmor.c | 10 -- src/security/security_dac.c | 10 --

Re: [libvirt] [PATCH 6/6] qemu: Translate the volume type disk source before cgroup setting

2013-06-21 Thread John Ferlan
On 06/18/2013 04:36 AM, Osier Yang wrote: The translation must be done before both of cgroup and security setting, otherwise since the disk source is not translated yet, it might be skipped on cgroup and security setting. --- src/qemu/qemu_process.c | 13 - 1 file changed, 8

Re: [libvirt] [PATCH 4/6] security: Ignore to manage the volume type disk if its mode is uri

2013-06-21 Thread Daniel P. Berrange
On Tue, Jun 18, 2013 at 04:36:40PM +0800, Osier Yang wrote: It's straightforward to not manage security labels for remote URI like iscsi://example.org:6000/iqn.1992-01.com.example/1. --- src/security/security_apparmor.c | 10 -- src/security/security_dac.c | 10 --

Re: [libvirt] [PATCH] libxl: Allow libxl to set NIC devid

2013-06-21 Thread Jim Fehlig
Jiri Denemark wrote: On Thu, Jun 20, 2013 at 11:47:18 -0600, Jim Fehlig wrote: libxl contains logic to determine an appropriate devid for new devices that do not specify one in their configuration. For all device types except NICs, the libxl driver allows libxl to determine devid. Do the

Re: [libvirt] [PATCH 0/2] Implement virConnectGetSysinfo in libxl and xen drivers

2013-06-21 Thread Jim Fehlig
Jim Fehlig wrote: While discussing a recent libxl patch, we realized virConnectGetSysinfo was never implemented in the libxl and legacy xen drivers. This small series provides an implementation for these drivers. I'll need to update the version to 1.1.0, but otherwise any comment on this

Re: [libvirt] [PATCH 1/2] BSD: implement virNetDevBridgeCreate() and virNetDevBridgeDelete()

2013-06-21 Thread Roman Bogorodskiy
Jiri Denemark wrote: On Wed, Jun 19, 2013 at 20:47:30 +0400, Roman Bogorodskiy wrote: Implementation uses SIOCIFCREATE2 and SIOCIFDESTROY ioctls. Also, drop static virNetDevSetupControl() as we have public one avialable now. --- src/util/virnetdevbridge.c | 91

Re: [libvirt] [PATCH 0/2] Implement virConnectGetSysinfo in libxl and xen drivers

2013-06-21 Thread Daniel P. Berrange
On Fri, Jun 21, 2013 at 10:40:31AM -0600, Jim Fehlig wrote: Jim Fehlig wrote: While discussing a recent libxl patch, we realized virConnectGetSysinfo was never implemented in the libxl and legacy xen drivers. This small series provides an implementation for these drivers. I'll need

[libvirt] [PATCH 0/2] Fix a pair of network-related crashes

2013-06-21 Thread Ján Tomko
Ján Tomko (2): netdev: accept NULL in virNetDevSetupControl bridge: don't crash on bandwidth unplug with no bandwidth src/network/bridge_driver.c | 5 + src/util/virnetdev.c| 14 -- 2 files changed, 13 insertions(+), 6 deletions(-) -- 1.8.1.5 -- libvir-list

[libvirt] [PATCH 1/2] netdev: accept NULL in virNetDevSetupControl

2013-06-21 Thread Ján Tomko
Commit b9c6b073 dropped the version of virNetDevSetupControl that didn't check for NULL arguments, but we call it like that in virNetDevBridgeDelete. --- src/util/virnetdev.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/util/virnetdev.c

[libvirt] [PATCH 2/2] bridge: don't crash on bandwidth unplug with no bandwidth

2013-06-21 Thread Ján Tomko
If networkUnplugBandwidth is called on a network which has no bandwidth defined, print a warning instead of crashing. This can happen when destroying a domain with bandwith if bandwidth was removed from the network after the domain was started. https://bugzilla.redhat.com/show_bug.cgi?id=975359

Re: [libvirt] [PATCH 1/2] BSD: implement virNetDevBridgeCreate() and virNetDevBridgeDelete()

2013-06-21 Thread John Ferlan
On 06/19/2013 12:47 PM, Roman Bogorodskiy wrote: Implementation uses SIOCIFCREATE2 and SIOCIFDESTROY ioctls. Also, drop static virNetDevSetupControl() as we have public one avialable now. Dropping the static/local virNetDevSetupControlFull() and virNetDevSetupControl() seems to have triggered

Re: [libvirt] [PATCH 1/2] BSD: implement virNetDevBridgeCreate() and virNetDevBridgeDelete()

2013-06-21 Thread Ján Tomko
On 06/21/2013 07:37 PM, John Ferlan wrote: On 06/19/2013 12:47 PM, Roman Bogorodskiy wrote: Implementation uses SIOCIFCREATE2 and SIOCIFDESTROY ioctls. Also, drop static virNetDevSetupControl() as we have public one avialable now. Dropping the static/local virNetDevSetupControlFull() and

Re: [libvirt] [PATCH 1/2] netdev: accept NULL in virNetDevSetupControl

2013-06-21 Thread Ján Tomko
On 06/21/2013 07:30 PM, Ján Tomko wrote: Commit b9c6b073 dropped the version of virNetDevSetupControl that didn't check for NULL arguments, but we call it like that in virNetDevBridgeDelete. --- src/util/virnetdev.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-)

Re: [libvirt] [PATCH 1/2] netdev: accept NULL in virNetDevSetupControl

2013-06-21 Thread John Ferlan
On 06/21/2013 01:45 PM, Ján Tomko wrote: On 06/21/2013 07:30 PM, Ján Tomko wrote: Commit b9c6b073 dropped the version of virNetDevSetupControl that didn't check for NULL arguments, but we call it like that in virNetDevBridgeDelete. --- src/util/virnetdev.c | 14 -- 1 file

Re: [libvirt] [PATCH 0/2] Implement virConnectGetSysinfo in libxl and xen drivers

2013-06-21 Thread Jim Fehlig
Daniel P. Berrange wrote: On Fri, Jun 21, 2013 at 10:40:31AM -0600, Jim Fehlig wrote: Jim Fehlig wrote: While discussing a recent libxl patch, we realized virConnectGetSysinfo was never implemented in the libxl and legacy xen drivers. This small series provides an implementation

Re: [libvirt] [PATCH 1/2] netdev: accept NULL in virNetDevSetupControl

2013-06-21 Thread Ján Tomko
On 06/21/2013 07:57 PM, John Ferlan wrote: On 06/21/2013 01:45 PM, Ján Tomko wrote: On 06/21/2013 07:30 PM, Ján Tomko wrote: Commit b9c6b073 dropped the version of virNetDevSetupControl that didn't check for NULL arguments, but we call it like that in virNetDevBridgeDelete. ---

Re: [libvirt] [PATCH v5 3/5] storage: add support for creating qcow2 images with extensions

2013-06-21 Thread John Ferlan
On 06/19/2013 11:24 AM, Ján Tomko wrote: Add -o compat= and -o lazy_refcounts options for qemu-img. --- src/storage/storage_backend.c | 62 ++--- tests/storagevolxml2argvdata/qcow2-1.1.argv | 1 + tests/storagevolxml2argvdata/qcow2-lazy.argv|

Re: [libvirt] [PATCH 2/2] bridge: don't crash on bandwidth unplug with no bandwidth

2013-06-21 Thread John Ferlan
On 06/21/2013 01:30 PM, Ján Tomko wrote: If networkUnplugBandwidth is called on a network which has no bandwidth defined, print a warning instead of crashing. This can happen when destroying a domain with bandwith if s/bandwith/bandwidth bandwidth was removed from the network after the

[libvirt] [PATCH 1/2] libxl: Fix disk format error message

2013-06-21 Thread Jim Fehlig
Specifying an unsupported disk format with the tap driver resulted in a less than helpful error message error: Failed to start domain test-hvm error: internal error libxenlight does not support disk driver qed Change the message to state that the qed format is not supported by the tap driver,

[libvirt] [PATCH 2/2] libxl: support qdisk backend

2013-06-21 Thread Jim Fehlig
libxl supports the LIBXL_DISK_BACKEND_QDISK disk backend, where qemu is used to provide the disk backend. This patch simply maps the existing driver name='qemu'/ to LIBXL_DISK_BACKEND_QDISK. --- src/libxl/libxl_conf.c | 25 + 1 files changed, 25 insertions(+), 0

[libvirt] [PATCH 0/2] libxl: Add support for qdisk disk backend

2013-06-21 Thread Jim Fehlig
An update of https://www.redhat.com/archives/libvir-list/2013-April/msg02104.html This small patch series adds support for qdisk backend type in libxl. A qdisk uses the block drivers in qemu to serve as a block backend, verses blktap or blkbk. While testing the second patch, I noticed a