Re: [libvirt] [PATCH 2/2] bridge: don't crash on bandwidth unplug with no bandwidth

2013-06-27 Thread Michal Privoznik
On 21.06.2013 19:30, Ján Tomko wrote: If networkUnplugBandwidth is called on a network which has no bandwidth defined, print a warning instead of crashing. This can happen when destroying a domain with bandwith if bandwidth was removed from the network after the domain was started.

[libvirt] [PATCH] LXC: blkio: allow to setup weight_device

2013-06-27 Thread Gao feng
libivrt lxc can only set generic weight for container, This patch allows user to setup per device blkio weigh for container. Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- src/lxc/lxc_cgroup.c | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git

Re: [libvirt] [PATCH 1/5] snapshot: define new API virDomainSnapshotDeleteByName

2013-06-27 Thread Guannan Ren
On 06/21/2013 05:55 PM, Ján Tomko wrote: On 06/13/2013 02:55 PM, Guannan Ren wrote: This is to delete a snapshot object atomically, the API accepts argments: domain object, snapshot name and flags. Add a new flag VIR_DOMAIN_SNAPSHOT_DELETE_CURRENT, others are same.

Re: [libvirt] [PATCH 2/2] bridge: don't crash on bandwidth unplug with no bandwidth

2013-06-27 Thread Michal Privoznik
On 27.06.2013 11:56, Ján Tomko wrote: On 06/27/2013 09:54 AM, Michal Privoznik wrote: On 21.06.2013 19:30, Ján Tomko wrote: If networkUnplugBandwidth is called on a network which has no bandwidth defined, print a warning instead of crashing. This can happen when destroying a domain with

Re: [libvirt] [PATCH 2/2] bridge: don't crash on bandwidth unplug with no bandwidth

2013-06-27 Thread Ján Tomko
On 06/27/2013 12:11 PM, Michal Privoznik wrote: On 27.06.2013 11:56, Ján Tomko wrote: On 06/27/2013 09:54 AM, Michal Privoznik wrote: On 21.06.2013 19:30, Ján Tomko wrote: If networkUnplugBandwidth is called on a network which has no bandwidth defined, print a warning instead of crashing.

[libvirt] [PATCH] add support for libssh2 password from auth file

2013-06-27 Thread David Maciejak
Hi, I was discussing with Daniel about the best way to pass the ssh password when using such kind of uri: 'xen+libssh2:// root@192.168.0.10?sshauth=password' As it seems passing the password in the uri is not a good option, maybe we can grab it from auth conf ? it seems it's not the case as now

[libvirt] [PATCH] add symbol ) in virsh nodedev-detach help

2013-06-27 Thread xuzhang
--- tools/virsh-nodedev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-nodedev.c b/tools/virsh-nodedev.c index da93b8e..49546a2 100644 --- a/tools/virsh-nodedev.c +++ b/tools/virsh-nodedev.c @@ -605,7 +605,7 @@ static const vshCmdOptDef opts_node_device_detach[]

[libvirt] [PATCH] add symbol ) in virsh nodedev-detach help

2013-06-27 Thread xuzhang
--- tools/virsh-nodedev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-nodedev.c b/tools/virsh-nodedev.c index da93b8e..49546a2 100644 --- a/tools/virsh-nodedev.c +++ b/tools/virsh-nodedev.c @@ -605,7 +605,7 @@ static const vshCmdOptDef opts_node_device_detach[]

[libvirt] virsh can create vHBA, but returen error msg Node device not found

2013-06-27 Thread Dennis Chen
Hi, I am using the libvirt 1.0.6 with the patch applied: http://libvirt.org/git/?p=libvirt.git;a=commitdiff;h=371c155 The problem I encountered is, with virsh comand 'nodedev-create /home/kvm/vHBA.xml', the vHBA can be generated as expected on the host, but error msg will show in the virsh

Re: [libvirt] [PATCH] Make logical pools independent on target path

2013-06-27 Thread Martin Kletzander
On 06/03/2013 06:22 PM, Osier Yang wrote: On 03/06/13 23:05, Martin Kletzander wrote: When using logical pools, we had to trust the target-pth provided. s/pth/path/, This parameter, however, can be completely ommited and we can get the correct path using 'lvdisplay' command. Resolves:

[libvirt] Restore original security labels

2013-06-27 Thread Michal Privoznik
Dear list, it's been a while since I've tried to get the patches in [1]. However, it turned out that we need completely different approach. Now I'd like to revisit that decision. The problem is: libvirt sets various security labels (DAC, selinux) in order for a file to be readable by a qemu

Re: [libvirt] [PATCH] add symbol ) in virsh nodedev-detach help

2013-06-27 Thread Michal Privoznik
On 27.06.2013 13:21, xuzhang wrote: --- tools/virsh-nodedev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-nodedev.c b/tools/virsh-nodedev.c index da93b8e..49546a2 100644 --- a/tools/virsh-nodedev.c +++ b/tools/virsh-nodedev.c @@ -605,7 +605,7 @@ static

[libvirt] [PATCH] build: Fix VPATH build for access/*

2013-06-27 Thread Viktor Mihajlovski
VPATH build failed for the generated access driver files. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- src/Makefile.am | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index e6b1927..4cf999d

Re: [libvirt] [PATCH V2] Expose all CPU features in host definition

2013-06-27 Thread Don Dugger
On Mon, Jun 17, 2013 at 10:27:36AM +0200, Jiri Denemark wrote: On Fri, Jun 14, 2013 at 12:32:35 -0600, Don Dugger wrote: On Fri, Jun 14, 2013 at 03:06:52PM +0200, Jiri Denemark wrote: I was just trying to say that it doesn't provide anything more than it's supported by the host CPU, which

[libvirt] Candidate release 2 for libvirt-1.1.0

2013-06-27 Thread Daniel Veillard
I have just tagged the release candidate 2 in git and sent a tarball to the usual place (rpms are coming): ftp://libvirt.org/libvirt/ This includes the end of the patch set from Laine, and hopefully it won't require too many other patches. I tried it and it doesn't look obviously broken to

[libvirt] Entering freeze for libvirt-1.1.0

2013-06-27 Thread Daniel Veillard
Since Dan pushed the fine grained ACL control patches, this release really ought to be 1.1.0, I just tagged it in git and pushed tarball and rpms to the server: ftp://libvirt.org/libvirt/ I know that Laine has still a patch set to push, now it seems they all got ACK'ed so better get them

[libvirt] [PATCH 2/8] Add access control filtering of network objects

2013-06-27 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Ensure that all APIs which list network objects filter them against the access control system. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/conf/network_conf.c | 12 ++- src/conf/network_conf.h | 13

[libvirt] [PATCH 5/8] Add access control filtering of secret objects

2013-06-27 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Ensure that all APIs which list secret objects filter them against the access control system. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/secret/secret_driver.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-)

[libvirt] [PATCH 1/8] Add access control filtering of domain objects

2013-06-27 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Ensure that all APIs which list domain objects filter them against the access control system. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/conf/domain_conf.c | 91 +++-

[libvirt] [PATCH 0/8] Filtering of object lists via ACLs

2013-06-27 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The current ACL checks validate access to the object being passed in to the API calls. There are a few APIs (all the virConnectList* / virConnectNum* ones) which are used to get lists of objects in the first place. Currently you could find out that

[libvirt] [PATCH 6/8] Add access control filtering of nwfilter objects

2013-06-27 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Ensure that all APIs which list nwfilter objects filter them against the access control system. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/nwfilter/nwfilter_driver.c | 39 +++ 1 file changed, 27

[libvirt] [PATCH 4/8] Add access control filtering of storage objects

2013-06-27 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Ensure that all APIs which list storage objects filter them against the access control system. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/conf/storage_conf.c | 12 + src/conf/storage_conf.h | 11 +---

[libvirt] [PATCH 7/8] Add access control filtering of interface objects

2013-06-27 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Ensure that all APIs which list interface objects filter them against the access control system. This makes the APIs for listing names and counting devices slightly less efficient, since we can't use the direct netcf APIs for these tasks. Instead we

[libvirt] [PATCH 3/8] Add access control filtering of node device objects

2013-06-27 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Ensure that all APIs which list node device objects filter them against the access control system. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/conf/node_device_conf.c | 12 +++- src/conf/node_device_conf.h

[libvirt] [PATCH 8/8] Extend the ACL test case to validate filter rule checks

2013-06-27 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The 'check-aclrules' test case validates that there are ACL checks in each method. This extends it so that it can also validate that methods which return info about lists of objects, will filter their returned info throw an ACL check. Signed-off-by:

Re: [libvirt] Restore original security labels

2013-06-27 Thread Daniel P. Berrange
On Thu, Jun 27, 2013 at 05:31:04PM +0200, Michal Privoznik wrote: Dear list, it's been a while since I've tried to get the patches in [1]. However, it turned out that we need completely different approach. Now I'd like to revisit that decision. The problem is: libvirt sets various

Re: [libvirt] [PATCH 2/4] conf: refactor virSecurityLabelDefParseXML

2013-06-27 Thread Daniel P. Berrange
On Wed, Jun 26, 2013 at 03:01:48PM +0200, Peter Krempa wrote: Simplification of the code without functional impact. --- src/conf/domain_conf.c | 72 ++ 1 file changed, 32 insertions(+), 40 deletions(-) diff --git a/src/conf/domain_conf.c

Re: [libvirt] [PATCH 1/4] qemu: Improve info message and remove a variable in qemuDomainManagedSave

2013-06-27 Thread Daniel P. Berrange
On Wed, Jun 26, 2013 at 03:01:47PM +0200, Peter Krempa wrote: Mention the domain name that is being saved and remove the unneeded variable that only stores a constant. --- src/qemu/qemu_driver.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git

Re: [libvirt] [PATCH 3/4] security: Introduce method for labeling file descriptors of created files

2013-06-27 Thread Daniel P. Berrange
On Wed, Jun 26, 2013 at 03:01:49PM +0200, Peter Krempa wrote: The method labels the file descriptor even if dynamic labeling/relabeling is turned off. This is needed for files created by libvirt and then passed along to qemu as a FD. --- src/libvirt_private.syms| 1 +

[libvirt] [PATCH]Fix vPort Manage of FC vHBA creation

2013-06-27 Thread Dennis Chen
When create a virtual FC HBA with virsh/libvirt API, an error message will be returned:error: Node device not found, also the 'nodedev-dumpxml' shows wrong information of wwpn wwnn for the new created device. Signed-off-by:xsc...@tnsoft.com.cn --- src/util/virutil.c |4 ++-- 1 file

[libvirt] [PATCH] Allow RO connections to interface udev backend

2013-06-27 Thread Doug Goldstein
The udev based interface backend did not allow querying data over a read-only connection which is different than how the netcf backend operates. This brings the behavior inline with the default, netcf backend. --- src/interface/interface_backend_udev.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [libvirt] Candidate release 2 for libvirt-1.1.0

2013-06-27 Thread Doug Goldstein
On Thu, Jun 27, 2013 at 11:01 AM, Daniel Veillard veill...@redhat.comwrote: I have just tagged the release candidate 2 in git and sent a tarball to the usual place (rpms are coming): ftp://libvirt.org/libvirt/ This includes the end of the patch set from Laine, and hopefully it won't