Re: [libvirt] qemu64 - not valid cpu with 'Intel Westmere Family'

Il 03/07/2013 18:28, Dan Kenigsberg ha scritto: On Wed, Jul 03, 2013 at 04:51:30PM +0200, Sandro Bonazzola wrote: Il 03/07/2013 16:40, Sandro Bonazzola ha scritto: Hi, I'm trying to run latest vdsm master on RHEL-6.4. I've built the rpms against livirt-1.10 I'm creating a VM using cpu

Re: [libvirt] attach-device error: XML error: unknown device type

On 07/04/2013 02:34 AM, Chris Evich wrote: On 07/03/2013 09:46 AM, Daniel P. Berrange wrote: On Wed, Jul 03, 2013 at 09:44:46AM -0400, Chris Evich wrote: Hi, On Fedora 18 (libvirt 0.10.2.6-1) I'm trying to add a new serial device to a KVM VM with: virsh attach-device foobar /tmp/serial.xml

Re: [libvirt] configuring a disconnected interface

On Wed, Jul 03, 2013 at 10:43:22AM -0400, Laine Stump wrote: On 07/03/2013 05:27 AM, Daniel P. Berrange wrote: On Wed, Jul 03, 2013 at 09:39:57AM +0300, Dan Kenigsberg wrote: On Tue, Jul 02, 2013 at 05:32:20PM -0400, Laine Stump wrote: On 07/02/2013 04:07 PM, Dan Kenigsberg wrote: On Mon,

Re: [libvirt] attach-device error: XML error: unknown device type

On 03.07.2013 20:34, Chris Evich wrote: On 07/03/2013 09:46 AM, Daniel P. Berrange wrote: On Wed, Jul 03, 2013 at 09:44:46AM -0400, Chris Evich wrote: Hi, On Fedora 18 (libvirt 0.10.2.6-1) I'm trying to add a new serial device to a KVM VM with: virsh attach-device foobar /tmp/serial.xml

Re: [libvirt] best way to provide disk storage for vm without shared storage system

On Wed, Jul 03, 2013 at 05:31:44PM +0400, Vasiliy Tolstov wrote: Now i provide ext4 fs for qcow2 images (raid1 with two sata disks). Now i don't need live migration (but may need it in feature). What is the best way to provide disks to vm in case of performance, ability to create backups (i

Re: [libvirt] [libvirt-users] libvirt virtio_net - host.freeze@reset.domain

On 03.07.2013 13:43, Daniel P. Berrange wrote: On Tue, Jul 02, 2013 at 01:25:21PM +0200, poma wrote: Hello people, libvirtd (libvirt) 1.0.5.2 virsh 1.0.5.2 virt-manager 0.10.0 Host: Linux localhost 3.9.8-300.fc19.x86_64 #1 SMP Thu Jun 27 19:24:23 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux

Re: [libvirt] [PATCH] build: honor autogen.sh --no-git

On Wed, Jul 03, 2013 at 03:07:51PM -0600, Eric Blake wrote: Based on a report by Chandrashekar Shastri, at https://bugzilla.redhat.com/show_bug.cgi?id=979360 On systems where git cannot access the outside world, a developer can instead arrange to get a copy of gnulib at the right commit via

[libvirt] [PATCH] Fix build with clang

Partially revert cdd703f's revert of c163410, as linking with clang with --param=ssp-buffer-size=4 still fails with: argument unused during compilation. --- This is technically a build-breaker fix, but I haven't pushed it yet, to prevent reverting a revert of a revert.

Re: [libvirt] [PATCH] Fix build with clang

On Thu, Jul 04, 2013 at 11:48:22AM +0200, Ján Tomko wrote: Partially revert cdd703f's revert of c163410, as linking with clang with --param=ssp-buffer-size=4 still fails with: argument unused during compilation. --- This is technically a build-breaker fix, but I haven't pushed it yet, to

Re: [libvirt] [PATCH] Fix build with clang

On 07/04/2013 12:08 PM, Daniel P. Berrange wrote: On Thu, Jul 04, 2013 at 11:48:22AM +0200, Ján Tomko wrote: Partially revert cdd703f's revert of c163410, as linking with clang with --param=ssp-buffer-size=4 still fails with: argument unused during compilation. --- This is technically a

[libvirt] [PATCH] add checking index for pci-bridge controller

hi all, There is a bug here https://bugzilla.redhat.com/show_bug.cgi?id=981261 about controller configuration. For the pci-bridge controller, if index less than zero, there is no alert for it, and libvirt will pass this value to qemu-kvm. But qemu-kvm will report the argument error, like:

[libvirt] [PATCH] conf: don't check hyperv spinlock retries if disabled

hyperv spinlocks state='off'/ /hyperv results in: error: XML error: missing HyperV spinlock retry count Don't require retries when state is off and use virXPathUInt instead of virXPathString to simplify parsing. https://bugzilla.redhat.com/show_bug.cgi?id=784836#c19 ---

[libvirt] [PATCH] add console support in libxl

this patch introduce the console api in libxl driver for both pv and hvm guest. and import and update the libxlMakeChrdevStr function which was deleted in commit dfa1e1dd. Signed-off-by: Bamvor Jian Zhang bjzh...@suse.com --- src/libxl/libxl_conf.c | 97 ++

[libvirt] [PATCH v1 00/37] Remove virReportOOMError from almost everywhere

Make VIR_ALLOC, virAsprintf and friend to report OOM error and subsequently adapt the code. Patches available at: git://gitorious.org/~zippy2/libvirt/michal-staging.git branch oom1 Michal Privoznik (37): viralloc: Report OOM error on failure Introduce OOM reporting to virAsprintf

[libvirt] [PATCH v1 05/37] Adapt to VIR_ALLOC and virAsprintf in src/access/*

--- src/access/viraccessdriverpolkit.c | 4 +--- src/access/viraccessdriverstack.c | 4 +--- src/access/viraccessmanager.c | 4 +--- 3 files changed, 3 insertions(+), 9 deletions(-) diff --git a/src/access/viraccessdriverpolkit.c b/src/access/viraccessdriverpolkit.c index 6e503ba..4c76e64

[libvirt] [PATCH v1 25/37] Adapt to VIR_ALLOC and virAsprintf in src/storage/*

--- src/storage/storage_backend.c | 35 ++--- src/storage/storage_backend_disk.c | 17 +++- src/storage/storage_backend_fs.c | 31 ++ src/storage/storage_backend_iscsi.c| 27 +--

[libvirt] [PATCH v1 13/37] Adapt to VIR_ALLOC and virAsprintf in src/lxc/*

--- src/lxc/lxc_cgroup.c | 4 +-- src/lxc/lxc_conf.c | 5 +-- src/lxc/lxc_container.c | 77 ++-- src/lxc/lxc_controller.c | 50 +++--- src/lxc/lxc_driver.c | 92

[libvirt] [PATCH v1 09/37] Adapt to VIR_ALLOC and virAsprintf in src/hyperv/*

--- src/hyperv/hyperv_driver.c | 21 ++--- src/hyperv/hyperv_util.c | 4 +--- src/hyperv/hyperv_wmi.c| 8 ++-- 3 files changed, 9 insertions(+), 24 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index dd8d018..389a151 100644 ---

[libvirt] [PATCH v1 11/37] Adapt to VIR_ALLOC and virAsprintf in src/libxl/*

--- src/libxl/libxl_conf.c | 18 +- src/libxl/libxl_driver.c | 46 +++--- 2 files changed, 16 insertions(+), 48 deletions(-) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index e170357..1b27b6f 100644 ---

[libvirt] [PATCH v1 10/37] Adapt to VIR_ALLOC and virAsprintf in src/interface/*

--- src/interface/interface_backend_netcf.c | 19 --- src/interface/interface_backend_udev.c | 33 + 2 files changed, 13 insertions(+), 39 deletions(-) diff --git a/src/interface/interface_backend_netcf.c b/src/interface/interface_backend_netcf.c

[libvirt] [PATCH v1 19/37] Adapt to VIR_ALLOC and virAsprintf in src/phyp/*

--- src/phyp/phyp_driver.c | 95 +- 1 file changed, 24 insertions(+), 71 deletions(-) diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c index cae3b59..c515f3e 100644 --- a/src/phyp/phyp_driver.c +++ b/src/phyp/phyp_driver.c @@ -110,10

[libvirt] [PATCH v1 02/37] Introduce OOM reporting to virAsprintf

Actually, I'm turning this function into a macro as filename, function name and line number needs to be passed. The new function virAsprintfInternal is introduced with the extended set of arguments. --- cfg.mk| 2 +- src/conf/domain_audit.c | 36

[libvirt] [PATCH v1 30/37] Adapt to VIR_ALLOC and virAsprintf in src/vmware/*

--- src/vmware/vmware_conf.c | 33 +++-- src/vmware/vmware_driver.c | 4 +--- 2 files changed, 8 insertions(+), 29 deletions(-) diff --git a/src/vmware/vmware_conf.c b/src/vmware/vmware_conf.c index 9d3d37e..b6d20ea 100644 --- a/src/vmware/vmware_conf.c +++

[libvirt] [PATCH v1 27/37] Adapt to VIR_ALLOC and virAsprintf in src/uml/*

--- src/uml/uml_conf.c | 28 +++- src/uml/uml_driver.c | 36 +--- 2 files changed, 16 insertions(+), 48 deletions(-) diff --git a/src/uml/uml_conf.c b/src/uml/uml_conf.c index 38dcfbb..e9d3ddb 100644 --- a/src/uml/uml_conf.c +++

[libvirt] [PATCH v1 07/37] Adapt to VIR_ALLOC and virAsprintf in src/cpu/*

--- src/cpu/cpu.c | 4 +-- src/cpu/cpu_arm.c | 6 +--- src/cpu/cpu_generic.c | 12 +++ src/cpu/cpu_powerpc.c | 20 +++- src/cpu/cpu_s390.c| 4 +-- src/cpu/cpu_x86.c | 86 +++ 6 files changed, 44 insertions(+), 88

[libvirt] [PATCH v1 33/37] Adapt to VIR_ALLOC and virAsprintf in src/xenapi/*

--- src/xenapi/xenapi_driver.c | 29 - src/xenapi/xenapi_utils.c | 11 --- 2 files changed, 12 insertions(+), 28 deletions(-) diff --git a/src/xenapi/xenapi_driver.c b/src/xenapi/xenapi_driver.c index cc8da49..869ec76 100644 --- a/src/xenapi/xenapi_driver.c

[libvirt] [PATCH v1 12/37] Adapt to VIR_ALLOC and virAsprintf in src/locking/*

--- src/locking/lock_daemon.c | 33 + src/locking/lock_daemon_config.c | 8 ++-- src/locking/lock_driver_lockd.c | 23 ++- src/locking/lock_driver_sanlock.c | 28 +++- src/locking/lock_manager.c|

[libvirt] [PATCH v1 04/37] Adapt to VIR_ALLOC and virAsprintf in daemon/*

--- daemon/libvirtd-config.c | 12 +-- daemon/libvirtd.c| 24 ++--- daemon/remote.c | 234 --- daemon/stream.c | 4 +- 4 files changed, 70 insertions(+), 204 deletions(-) diff --git a/daemon/libvirtd-config.c

[libvirt] [PATCH v1 15/37] Adapt to VIR_ALLOC and virAsprintf in src/network/*

--- src/network/bridge_driver.c | 138 +--- 1 file changed, 40 insertions(+), 98 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index d7e90ac..6fae832 100644 --- a/src/network/bridge_driver.c +++

[libvirt] [PATCH v1 16/37] Adapt to VIR_ALLOC and virAsprintf in src/nwfilter/*

--- src/nwfilter/nwfilter_dhcpsnoop.c | 29 +-- src/nwfilter/nwfilter_driver.c| 13 ++--- src/nwfilter/nwfilter_ebiptables_driver.c | 46 ++- src/nwfilter/nwfilter_gentech_driver.c| 24

[libvirt] [PATCH v1 36/37] Adapt to VIR_ALLOC and virAsprintf in tests/*

--- tests/commandtest.c | 8 ++-- tests/libvirtdconftest.c | 4 +--- tests/qemumonitortestutils.c | 17 + tests/securityselinuxlabeltest.c | 21 + tests/securityselinuxtest.c | 8 +++- tests/virnetmessagetest.c|

[libvirt] [PATCH v1 24/37] Adapt to VIR_ALLOC and virAsprintf in src/security/*

--- src/security/security_apparmor.c | 25 ++-- src/security/security_dac.c | 12 +++- src/security/security_manager.c | 8 ++-- src/security/security_selinux.c | 41 src/security/security_stack.c| 8 ++-- 5

[libvirt] [PATCH v1 34/37] Adapt to VIR_ALLOC and virAsprintf in src/xenxs/*

--- src/xenxs/xen_sxpr.c | 112 src/xenxs/xen_xm.c | 204 ++- 2 files changed, 135 insertions(+), 181 deletions(-) diff --git a/src/xenxs/xen_sxpr.c b/src/xenxs/xen_sxpr.c index 394b814..13f9f32 100644 ---

[libvirt] [PATCH v1 23/37] Adapt to VIR_ALLOC and virAsprintf in src/secret/*

--- src/secret/secret_driver.c | 49 -- 1 file changed, 12 insertions(+), 37 deletions(-) diff --git a/src/secret/secret_driver.c b/src/secret/secret_driver.c index 71b3fe7..dc8714d 100644 --- a/src/secret/secret_driver.c +++

[libvirt] [PATCH v1 18/37] Adapt to VIR_ALLOC and virAsprintf in src/parallels/*

--- src/parallels/parallels_driver.c | 65 +++ src/parallels/parallels_network.c | 24 --- src/parallels/parallels_storage.c | 50 +- src/parallels/parallels_utils.c | 4 +-- 4 files changed, 46 insertions(+), 97

[libvirt] [PATCH v1 03/37] Adapt to VIR_ALLOC and virAsprintf in docs/

--- HACKING | 20 +--- docs/hacking.html.in | 20 +--- 2 files changed, 10 insertions(+), 30 deletions(-) diff --git a/HACKING b/HACKING index a310faa..26dc0d0 100644 --- a/HACKING +++ b/HACKING @@ -535,10 +535,8 @@ routines, use the macros from

[libvirt] [PATCH v1 35/37] Adapt to VIR_ALLOC and virAsprintf in src/*

--- src/fdstream.c | 4 +--- src/libvirt.c | 21 ++--- src/nodeinfo.c | 58 ++ 3 files changed, 21 insertions(+), 62 deletions(-) diff --git a/src/fdstream.c b/src/fdstream.c index d5e5aaf..30f1729 100644 ---

[libvirt] [PATCH v1 22/37] Adapt to VIR_ALLOC and virAsprintf in src/rpc/*

--- src/rpc/gendispatch.pl| 8 ++-- src/rpc/virnetclient.c| 26 -- src/rpc/virnetclientprogram.c | 12 +++- src/rpc/virnetclientstream.c | 4 +--- src/rpc/virnetmessage.c | 24 ++-- src/rpc/virnetserver.c| 23

[libvirt] [PATCH v1 08/37] Adapt to VIR_ALLOC and virAsprintf in src/esx/*

--- src/esx/esx_driver.c| 62 - src/esx/esx_network_driver.c| 16 ++-- src/esx/esx_storage_backend_iscsi.c | 4 +- src/esx/esx_storage_backend_vmfs.c | 78 + src/esx/esx_util.c | 4 +-

[libvirt] [PATCH v1 37/37] Adapt to VIR_ALLOC and virAsprintf in tools/*

--- tools/console.c | 6 +- tools/virsh-domain-monitor.c | 4 +--- tools/virsh-domain.c | 28 tools/virsh.c| 1 - 4 files changed, 10 insertions(+), 29 deletions(-) diff --git a/tools/console.c b/tools/console.c index

[libvirt] [PATCH v1 26/37] Adapt to VIR_ALLOC and virAsprintf in src/test/*

--- src/test/test_driver.c | 91 -- 1 file changed, 28 insertions(+), 63 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 80a84d5..a5dbdc3 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -170,18

[libvirt] [PATCH v1 21/37] Adapt to VIR_ALLOC and virAsprintf in src/remote/*

--- src/remote/remote_driver.c | 107 - 1 file changed, 27 insertions(+), 80 deletions(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index 7f3e833..c2f1132 100644 --- a/src/remote/remote_driver.c +++

[libvirt] [PATCH v1 17/37] Adapt to VIR_ALLOC and virAsprintf in src/openvz/*

--- src/openvz/openvz_conf.c | 42 -- src/openvz/openvz_driver.c | 10 +++--- 2 files changed, 19 insertions(+), 33 deletions(-) diff --git a/src/openvz/openvz_conf.c b/src/openvz/openvz_conf.c index 90b4483..93f2377 100644 ---

[libvirt] [PATCH v1 31/37] Adapt to VIR_ALLOC and virAsprintf in src/vmx/*

--- src/vmx/vmx.c | 92 +++ 1 file changed, 23 insertions(+), 69 deletions(-) diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c index 5464d13..64bf4be 100644 --- a/src/vmx/vmx.c +++ b/src/vmx/vmx.c @@ -553,10 +553,8 @@ virVMXEscapeHex(const char

[libvirt] [PATCH v1 32/37] Adapt to VIR_ALLOC and virAsprintf in src/xen/*

--- src/xen/block_stats.c| 8 ++-- src/xen/xen_driver.c | 42 +++--- src/xen/xen_hypervisor.c | 17 ++--- src/xen/xen_inotify.c| 4 +--- src/xen/xend_internal.c | 38 ++ src/xen/xm_internal.c

[libvirt] [PATCH v1 14/37] Adapt to VIR_ALLOC and virAsprintf in src/node_device/*

--- src/node_device/node_device_driver.c | 4 +--- src/node_device/node_device_udev.c | 18 -- 2 files changed, 5 insertions(+), 17 deletions(-) diff --git a/src/node_device/node_device_driver.c b/src/node_device/node_device_driver.c index 1f7e0fd..bbad113 100644 ---

[libvirt] [PATCH v1 29/37] Adapt to VIR_ALLOC and virAsprintf in src/vbox/*

--- src/vbox/vbox_MSCOMGlue.c | 8 +-- src/vbox/vbox_XPCOMCGlue.c | 4 +- src/vbox/vbox_tmpl.c | 126 +++-- 3 files changed, 32 insertions(+), 106 deletions(-) diff --git a/src/vbox/vbox_MSCOMGlue.c b/src/vbox/vbox_MSCOMGlue.c index

[libvirt] [PATCH] Unlock the storage volume object after looking it up

Introduced by c930410. https://bugzilla.redhat.com/show_bug.cgi?id=980676 --- src/storage/storage_driver.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index 02f7b69..d15b3d4 100644 ---

Re: [libvirt] [PATCH] Unlock the storage volume object after looking it up

On 07/04/13 14:53, Ján Tomko wrote: Introduced by c930410. https://bugzilla.redhat.com/show_bug.cgi?id=980676 --- src/storage/storage_driver.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) The control flow is really tricky in those functions. ACK. PEter --

Re: [libvirt] [PATCH] Unlock the storage volume object after looking it up

On 07/04/2013 03:05 PM, Peter Krempa wrote: On 07/04/13 14:53, Ján Tomko wrote: Introduced by c930410. https://bugzilla.redhat.com/show_bug.cgi?id=980676 --- src/storage/storage_driver.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) The control flow is really

Re: [libvirt] [PATCH v1 01/37] viralloc: Report OOM error on failure

On 07/04/13 14:06, Michal Privoznik wrote: Similarly to VIR_STRDUP, we want the OOM error to be reported in VIR_ALLOC and friends. --- po/POTFILES.in | 1 + python/libvirt-override.c | 102 +-- src/conf/domain_conf.c | 9 +-

Re: [libvirt] [PATCH v1 02/37] Introduce OOM reporting to virAsprintf

On 07/04/13 14:06, Michal Privoznik wrote: Actually, I'm turning this function into a macro as filename, function name and line number needs to be passed. The new function virAsprintfInternal is introduced with the extended set of arguments. --- cfg.mk| 2 +-

Re: [libvirt] [PATCH v1 03/37] Adapt to VIR_ALLOC and virAsprintf in docs/

On 07/04/13 14:06, Michal Privoznik wrote: --- HACKING | 20 +--- docs/hacking.html.in | 20 +--- 2 files changed, 10 insertions(+), 30 deletions(-) ACK. Peter -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH] conf: don't check hyperv spinlock retries if disabled

On Thu, Jul 04, 2013 at 13:40:42 +0200, Jano Tomko wrote: hyperv spinlocks state='off'/ /hyperv results in: error: XML error: missing HyperV spinlock retry count Don't require retries when state is off and use virXPathUInt instead of virXPathString to simplify parsing.

Re: [libvirt] [PATCH v1 04/37] Adapt to VIR_ALLOC and virAsprintf in daemon/*

On 07/04/13 14:06, Michal Privoznik wrote: --- daemon/libvirtd-config.c | 12 +-- daemon/libvirtd.c| 24 ++--- daemon/remote.c | 234 --- daemon/stream.c | 4 +- 4 files changed, 70 insertions(+), 204 deletions(-)

Re: [libvirt] [PATCH v1 05/37] Adapt to VIR_ALLOC and virAsprintf in src/access/*

On 07/04/13 14:06, Michal Privoznik wrote: --- src/access/viraccessdriverpolkit.c | 4 +--- src/access/viraccessdriverstack.c | 4 +--- src/access/viraccessmanager.c | 4 +--- 3 files changed, 3 insertions(+), 9 deletions(-) ACK. Peter -- libvir-list mailing list

[libvirt] [PATCH] Fix NULL dereference caused by ACL filtering of domains

Caused by 763973607ddace04562da1a1e545ab6692d5175f. --- src/libxl/libxl_driver.c | 3 ++- src/qemu/qemu_driver.c | 6 -- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 1bae3d6..ededbbc 100644 ---

Re: [libvirt] [PATCH] Fix NULL dereference caused by ACL filtering of domains

On Thu, Jul 04, 2013 at 05:02:00PM +0200, Jiri Denemark wrote: Caused by 763973607ddace04562da1a1e545ab6692d5175f. --- src/libxl/libxl_driver.c | 3 ++- src/qemu/qemu_driver.c | 6 -- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/libxl/libxl_driver.c

Re: [libvirt] [PATCH] Fix NULL dereference caused by ACL filtering of domains

On Thu, Jul 04, 2013 at 16:19:15 +0100, Daniel Berrange wrote: On Thu, Jul 04, 2013 at 05:02:00PM +0200, Jiri Denemark wrote: Caused by 763973607ddace04562da1a1e545ab6692d5175f. --- src/libxl/libxl_driver.c | 3 ++- src/qemu/qemu_driver.c | 6 -- 2 files changed, 6 insertions(+),

Re: [libvirt] [PATCH 1/4] libxl: implement NUMA capabilities reporting

On lun, 2013-07-01 at 16:47 -0600, Jim Fehlig wrote: On 06/28/2013 08:32 AM, Dario Faggioli wrote: Starting from Xen 4.2, libxl has all the bits and pieces are in s/are in/in/ Uups! Will fix, thanks. diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index e170357..2a9bcf0

[libvirt] [PATCH] Split up platfrom specifics from bridge driver

This is a second step for making bridge_driver more portable. This one splits up bridge driver into platform specific and general parts. Platform specifc parts are mostly firewalling stuff. So the support for new platforms should be added by implementing bridge_driver_$platform.c However, you

Re: [libvirt] [PATCH] conf: don't check hyperv spinlock retries if disabled

On 07/04/2013 04:41 PM, Jiri Denemark wrote: On Thu, Jul 04, 2013 at 13:40:42 +0200, Jano Tomko wrote: hyperv spinlocks state='off'/ /hyperv results in: error: XML error: missing HyperV spinlock retry count Don't require retries when state is off and use virXPathUInt instead of

Re: [libvirt] [PATCH 2/4] libxl: implement per NUMA node free memory reporting

On lun, 2013-07-01 at 17:27 -0600, Jim Fehlig wrote: Yeah, rather straight forward patch, which looks good on my non-NUMA machine as well # virsh freecell --all 0:7287216 KiB Total:7287216 KiB # virsh freecell --cellno 0 0: 7287216 KiB ACK and

Re: [libvirt] [PATCH 0/4] libxl: implement some chuncks of the NUMA interface

On lun, 2013-07-01 at 15:27 -0600, Eric Blake wrote: On 07/01/2013 03:20 PM, Jim Fehlig wrote: What I'm really not sure about is patch 03, which is something I need if I want patch 04 to function properly. Basically it is about advertising that the libxl driver supports

Re: [libvirt] [PATCH 4/4] libxl: implement virDomainGetNumaParameters

On mar, 2013-07-02 at 14:22 -0600, Jim Fehlig wrote: On 06/28/2013 08:33 AM, Dario Faggioli wrote: diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 53af609..9bd6d99 100644 +/* NUMA node affinity information is available through libxl + * starting from Xen 4.3. */

[libvirt] [PATCH] Paused domain should remain paused after migration

https://bugzilla.redhat.com/show_bug.cgi?id=981139 If a domain is paused before migration starts, we need to tell that to the destination libvirtd to prevent it from resuming the domain at the end of migration. This regression was introduced by commit 5379bb0. --- src/libvirt.c | 22

[libvirt] [PATCH] Don't spam logs with port 0 must be in range errors

Whenever virPortAllocatorRelease is called with port == 0, it complains that the port is not in an allowed range, which is expectable as the port was never allocated. Let's make virPortAllocatorRelease ignore 0 ports in a similar way free() ignores NULL pointers. --- src/qemu/qemu_migration.c |

[libvirt] [PATCH] qemu: Release correct websocket port

--- src/qemu/qemu_process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index df0ac72..114e885 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -4222,7 +4222,7 @@ retry: } if

Re: [libvirt] LXC: autostart feature does set all interfaces to state up.

Hi, Am 03.07.2013 12:04, schrieb Gao feng: Hi, On 07/01/2013 03:45 PM, Richard Weinberger wrote: Hi! If you have multiple LXC containers with networking and the autostart feature enabled libvirtd fails to up some veth interfaces on the host side. Most of the time only the first veth

[libvirt] [PATCH v2 3/3] libxl: implement virDomainGetNumaParameters

Although, having it depending on Xen = 4.3 (by using the proper libxl feature flag). Xen currently implements a NUMA placement policy which is basically the same as the 'interleaved' policy of `numactl', although it can be applied on a subset of the available nodes. We therefore hardcode

[libvirt] [PATCH v2 2/3] libxl: advertise the support for VIR_TYPED_PARAM_STRING

domainGetNumaParameters has a string typed parameter, hence it is necessary for the libxl driver to support this. This change implements the connectSupportsFeature hook for the libxl driver, advertising that VIR_DRV_FEATURE_TYPED_PARAM_STRING is supported. Signed-off-by: Dario Faggioli

[libvirt] [PATCH v2 1/3] libxl: implement NUMA capabilities reporting

Starting from Xen 4.2, libxl has all the bits and pieces in place for retrieving an adequate amount of information about the host NUMA topology. It is therefore possible, after a bit of shuffling, to arrange those information in the way libvirt wants to present them to the outside world.

Re: [libvirt] [PATCH 0/4] libxl: implement some chuncks of the NUMA interface

On lun, 2013-07-01 at 15:20 -0600, Jim Fehlig wrote: On 06/28/2013 08:32 AM, Dario Faggioli wrote: Hi Jim, Everyone, First patch series, so maybe a small introduction is required: I'm Dario and I work for Citrix on improving the NUMA support of Xen. Welcome Dario! Hey! :-)

[libvirt] [PATCH v2 0/3] libxl: implement some chuncks of the NUMA interface

Hi everyone, This is take 2 of the series about introducing (some) NUMA support for the libxl driver. What was patch 2 in v1 has been already applied and so it's no longer part of the series. I think I addressed all the comments raised during v1 review (more details in the individual

Re: [libvirt] LXC: autostart feature does set all interfaces to state up.

On 07/05/2013 04:45 AM, Richard Weinberger wrote: Hi, Am 03.07.2013 12:04, schrieb Gao feng: Hi, On 07/01/2013 03:45 PM, Richard Weinberger wrote: Hi! If you have multiple LXC containers with networking and the autostart feature enabled libvirtd fails to up some veth interfaces on the

Re: [libvirt] [PATCH V2] Expose all CPU features in host definition

On Mon, Jul 01, 2013 at 09:43:58AM -0600, Don Dugger wrote: On Mon, Jul 01, 2013 at 09:44:52AM +0100, Daniel P. Berrange wrote: On Fri, Jun 28, 2013 at 02:26:02PM -0600, Don Dugger wrote: On Fri, Jun 28, 2013 at 09:03:55PM +0100, Daniel P. Berrange wrote: On Fri, Jun 28, 2013 at

Re: [libvirt] [PATCH v1 01/37] viralloc: Report OOM error on failure

On 07/04/2013 08:06 AM, Michal Privoznik wrote: virInsertElementsN(void *ptrptr, size_t size, size_t at, size_t *countptr, size_t add, void *newelems, - bool clearOriginal, bool inPlace) + bool clearOriginal, bool