Re: [libvirt] [PATCH 1/6] Introduce new domain create APIs to pass pre-opened FDs to LXC

2013-07-12 Thread Daniel Veillard
On Fri, Jul 12, 2013 at 04:38:27PM +0100, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > With container based virt, it is useful to be able to pass > pre-opened file descriptors to the container init process. > This allows for containers to be auto-activated from incoming > socket con

[libvirt] deadlock in function storageVolLookupByKey and storageVolLookupByPath

2013-07-12 Thread Caizhifeng
root@cvknode-141:~/libvirt1.1.0# diff storage_driver.c storage_driver-new.c 1364c1364,1365 < if (virStorageVolLookupByKeyEnsureACL(conn, driver->pools.objs[i]->def, vol) < 0) --- > if (virStorageVolLookupByKeyEnsureACL(conn, > driver->pools.objs[i]->def, vol) < 0)

[libvirt] [PATCH v3 3/3] libxl: implement virDomainGetNumaParameters

2013-07-12 Thread Dario Faggioli
Although, having it depending on Xen >= 4.3 (by using the proper libxl feature flag). Xen currently implements a NUMA placement policy which is basically the same as the 'interleaved' policy of `numactl', although it can be applied on a subset of the available nodes. We therefore hardcode "interle

[libvirt] [PATCH v3 1/3] libxl: implement NUMA capabilities reporting

2013-07-12 Thread Dario Faggioli
Starting from Xen 4.2, libxl has all the bits and pieces in place for retrieving an adequate amount of information about the host NUMA topology. It is therefore possible, after a bit of shuffling, to arrange those information in the way libvirt wants to present them to the outside world. Therefore

[libvirt] [PATCH v3 2/3] libxl: advertise the support for VIR_TYPED_PARAM_STRING

2013-07-12 Thread Dario Faggioli
domainGetNumaParameters has a string typed parameter, hence it is necessary for the libxl driver to support this. This change implements the connectSupportsFeature hook for the libxl driver, advertising that VIR_DRV_FEATURE_TYPED_PARAM_STRING is supported. Signed-off-by: Dario Faggioli Cc: Eric

[libvirt] [PATCH v3 0/3] libxl: implement some chuncks of the NUMA interface

2013-07-12 Thread Dario Faggioli
Hi everyone again, 3rd round for the initial NUMA support in the libxl driver. I think I addressed all the comments that have been raised during v2 review (more details in the signle changelogs). Let me know if there's more. Thanks and Regards, Dario --- Dario Faggioli (3): libxl: implem

[libvirt] [PATCH] security_dac: compute supplemental groups before fork

2013-07-12 Thread Eric Blake
Commit 75c1256 states that virGetGroupList must not be called between fork and exec, then commit ee777e99 promptly violated that for lxc's use of virSecurityManagerSetProcessLabel. Hoist the supplemental group detection to the time that the security manager is created. Qemu is safe, as it uses vi

[libvirt] Call for Proposals: 2013 Linux Plumbers Virtualization Microconference

2013-07-12 Thread Alex Williamson
The Call for Proposals for the 2013 Linux Plumbers Virtualization Microconference is now open. This uconf is being held as part of Linux Plumbers Conference in New Orleans, Louisiana, USA September 18-20th and is co-located with LinuxCon North America. For more information see: http://www.linux

[libvirt] Reminder: KVM Forum 2013 Call for Participation

2013-07-12 Thread KVM-Forum-2013-PC
Reminder, the KVM Forum CFP closes in less than 2 weeks. Also, thanks to generous support from our sponsors early registrants get an awesome discount! = KVM Forum 2013: Call For Participation October 21-23, 2013 - Edinburgh Internati

Re: [libvirt] [PATCH] python: return dictionay without value in case of no blockjob

2013-07-12 Thread Michal Privoznik
On 17.05.2013 08:30, Guannan Ren wrote: > s/dictionay/dictionary/ in $SUBJ > Currently, when there is no blockjob, dom.blockJobInfo('vda') > still reports error because it didn't distinguish return value 0 from -1. s/didn't/doesn't/ > libvirt.libvirtError: virDomainGetBlockJobInfo() failed > >

[libvirt] [PATCH] lxc: hoist supplemental group detection before clone

2013-07-12 Thread Eric Blake
Commit 75c1256 states that virGetGroupList must not be called between fork and exec, then commit ee777e99 promptly violated that for lxc. Hoist the group detection to occur before clone. * src/lxc/lxc_container.c (__lxc_child_argv): Add members. (lxcContainerSetID): Adjust signature. (lxcContaine

[libvirt] [PATCH v5 2/5] domain_conf: Auto fill chardev port

2013-07-12 Thread Michal Privoznik
Now that we have callbacks, we should auto fill in omitted pieces of information. It's important for chardev hotplug to fill in the correct /{serial,parallel,console,channel}/target/@port if no value has been provided by user. --- src/conf/domain_conf.c | 46 +++

[libvirt] [PATCH v5 4/5] qemu: Implement chardev hotplug on live level

2013-07-12 Thread Michal Privoznik
Since previous patches has prepared everything for us, we may now implement live hotplug of a character device. --- src/qemu/qemu_command.c | 38 +- src/qemu/qemu_driver.c | 26 ++-- src/qemu/qemu_hotplug.c | 103 src/qemu

[libvirt] [PATCH v5 3/5] qemu: Implement chardev hotplug on config level

2013-07-12 Thread Michal Privoznik
There are two levels on which a device may be hotplugged: config and live. The config level requires just an insert or remove from internal domain definition structure, which is exactly what this patch does. There is currently no implementation for a chardev update action, as there's not much to be

[libvirt] [PATCH v5 0/5] Chardev hotplug

2013-07-12 Thread Michal Privoznik
I've pushed all ACKed patches from previous rounds. So now just the rest. Michal Privoznik (5): qemuBuildChrDeviceCommandLine: Don't leak devstr domain_conf: Auto fill chardev port qemu: Implement chardev hotplug on config level qemu: Implement chardev hotplug on live level qemuhotplugte

[libvirt] [PATCH v5 5/5] qemuhotplugtest: Introduce test for chardev hotplug

2013-07-12 Thread Michal Privoznik
The test is currently testing just device update function. However, chardev hotplug is implemented just for device attach and detach. This fact means, the test needs to be rewritten (the majority of the code is still shared). Moreover, we are now able to pass VM among multiple test runs. So for ins

[libvirt] [PATCH v5 1/5] qemuBuildChrDeviceCommandLine: Don't leak devstr

2013-07-12 Thread Michal Privoznik
It's caller's responsibility to free return value of qemuBuildChrDeviceStr(). --- src/qemu/qemu_command.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 0e517f2..d6ef9cd 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c

[libvirt] ANNOUNCE: libvirt 1.0.5.4 maintenance release

2013-07-12 Thread Cole Robinson
libvirt 1.0.5.4 maintenance release is now available. This is libvirt 1.0.5 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-1.0.5.4.tar.gz Changes in this version: * qemu: fix

Re: [libvirt] [PATCH v3 03/10] Add qemuMonitorJSONSetObjectProperty() method for QMP qom-set command

2013-07-12 Thread Eric Blake
On 07/12/2013 10:34 AM, John Ferlan wrote: > On 07/12/2013 11:57 AM, Eric Blake wrote: >> On 07/12/2013 06:35 AM, Daniel P. Berrange wrote: >>> On Thu, Jul 11, 2013 at 07:55:53PM -0400, John Ferlan wrote: Add a new qemuMonitorJSONSetObjectProperty() method to support invocation of the 'qo

Re: [libvirt] [PATCH v3 03/10] Add qemuMonitorJSONSetObjectProperty() method for QMP qom-set command

2013-07-12 Thread John Ferlan
On 07/12/2013 11:57 AM, Eric Blake wrote: > On 07/12/2013 06:35 AM, Daniel P. Berrange wrote: >> On Thu, Jul 11, 2013 at 07:55:53PM -0400, John Ferlan wrote: >>> Add a new qemuMonitorJSONSetObjectProperty() method to support invocation >>> of the 'qom-set' JSON monitor command with a provided path,

Re: [libvirt] [PATCH v2] qemu: don't use deprecated -no-kvm-pit-reinjection

2013-07-12 Thread Eric Blake
On 07/12/2013 10:00 AM, Eric Blake wrote: >> >> That shouldn't happen I think. For any runing guest, we have recorded >> the original capabilities in the domain status XML file. So any caps >> we detect against QEMU binaries upon restart will only impact newly >> started guests. > > I seem to reca

Re: [libvirt] [PATCH v2] qemu: don't use deprecated -no-kvm-pit-reinjection

2013-07-12 Thread Eric Blake
On 07/12/2013 09:53 AM, Daniel P. Berrange wrote: >>> if (qemuCaps->arch == VIR_ARCH_X86_64 || >>> qemuCaps->arch == VIR_ARCH_I686) { >>> virQEMUCapsSet(qemuCaps, QEMU_CAPS_PCI_MULTIBUS); >>> virQEMUCapsSet(qemuCaps, QEMU_CAPS_NO_ACPI); >>> -virQEMUCapsSet(q

Re: [libvirt] [PATCH v3 03/10] Add qemuMonitorJSONSetObjectProperty() method for QMP qom-set command

2013-07-12 Thread Eric Blake
On 07/12/2013 06:35 AM, Daniel P. Berrange wrote: > On Thu, Jul 11, 2013 at 07:55:53PM -0400, John Ferlan wrote: >> Add a new qemuMonitorJSONSetObjectProperty() method to support invocation >> of the 'qom-set' JSON monitor command with a provided path, property, and >> expected data type to set. >>

Re: [libvirt] [PATCH v2] qemu: don't use deprecated -no-kvm-pit-reinjection

2013-07-12 Thread Daniel P. Berrange
On Fri, Jul 12, 2013 at 09:47:57AM -0600, Eric Blake wrote: > On 07/12/2013 08:54 AM, Ján Tomko wrote: > > Since qemu-kvm 1.1 [1] (since 1.3. in upstream QEMU [2]) > > '-no-kvm-pit-reinjection' has been deprecated. > > Use -device kvm-pit,lost_tick_policy=discard instead. > > > > https://bugzilla.

Re: [libvirt] [PATCH] conf: reject pci-root controllers with non-zero indexes

2013-07-12 Thread Eric Blake
On 07/12/2013 07:08 AM, Ján Tomko wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=981261 > --- > src/conf/domain_conf.c | 7 +++ > 1 file changed, 7 insertions(+) ACK > > diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c > index 5f0366e..602c9a6 100644 > --- a/src/conf/domai

Re: [libvirt] [PATCH v3 01/10] Add qemuMonitorJSONGetObjectListPaths() method for QMP qom-list command

2013-07-12 Thread Eric Blake
On 07/12/2013 06:34 AM, Daniel P. Berrange wrote: > On Thu, Jul 11, 2013 at 07:55:51PM -0400, John Ferlan wrote: >> Add a new qemuMonitorJSONGetObjectListPaths() method to support invocation >> of the 'qom-list' JSON monitor command with a provided path. >> >> The returned list of paired data field

Re: [libvirt] [PATCH v2] qemu: don't use deprecated -no-kvm-pit-reinjection

2013-07-12 Thread Eric Blake
On 07/12/2013 08:54 AM, Ján Tomko wrote: > Since qemu-kvm 1.1 [1] (since 1.3. in upstream QEMU [2]) > '-no-kvm-pit-reinjection' has been deprecated. > Use -device kvm-pit,lost_tick_policy=discard instead. > > https://bugzilla.redhat.com/show_bug.cgi?id=978719 > > [1] http://git.kernel.org/cgit/vi

Re: [libvirt] [PATCH] add console support in libxl

2013-07-12 Thread Jim Fehlig
On 07/04/2013 05:58 AM, Bamvor Jian Zhang wrote: this patch introduce the console api in libxl driver for both pv and hvm guest. and import and update the libxlMakeChrdevStr function which was deleted in commit dfa1e1dd. Signed-off-by: Bamvor Jian Zhang --- src/libxl/libxl_conf.c | 97 +++

[libvirt] [PATCH 6/6] Merge virCommandPreserveFD / virCommandTransferFD

2013-07-12 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Merge the virCommandPreserveFD / virCommandTransferFD methods into a single virCommandPasFD method, and use a new VIR_COMMAND_PASS_FD_CLOSE_PARENT to indicate their difference in behaviour Signed-off-by: Daniel P. Berrange --- src/fdstream.c | 3 +- src/l

[libvirt] [PATCH 3/6] Fix impl of virDomainCreateWithFlags remote client helper

2013-07-12 Thread Daniel P. Berrange
From: "Daniel P. Berrange" In the following commit: commit 03d813bbcd7b4a18360105500672b84d985dd889 Author: Marek Marczykowski Date: Thu May 23 02:01:30 2013 +0200 remote: fix dom->id after virDomainCreateWithFlags The virDomainCreateWithFlags remote client helper was made to invo

[libvirt] [PATCH 5/6] Enable FD passing when starting guests with virsh

2013-07-12 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Add a "--pass-fds N,M,..." arg to the virsh start/create methods. This allows pre-opened file descriptors from the shell to be passed on into the guest Signed-off-by: Daniel P. Berrange --- tools/virsh-domain.c | 82 +--

[libvirt] [PATCH 1/6] Introduce new domain create APIs to pass pre-opened FDs to LXC

2013-07-12 Thread Daniel P. Berrange
From: "Daniel P. Berrange" With container based virt, it is useful to be able to pass pre-opened file descriptors to the container init process. This allows for containers to be auto-activated from incoming socket connections, passing the active socket into the container. To do this, introduce a

[libvirt] [PATCH 2/6] Introduce remote protocol support for virDomainCreate{XML}WithFiles

2013-07-12 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Since they make use of file descriptor passing, the remote protocol methods for virDomainCreate{XML}WithFiles must be written by hand. Signed-off-by: Daniel P. Berrange --- daemon/remote.c | 104 +++ src/remote/rem

[libvirt] [PATCH 0/6] Enable fd passing / socket activation with LXC guest

2013-07-12 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Systemd has a concept of socket activation whereby systemd will listen on a TCP socket in the host. When a client arrives on the socket, systemd will run a service, passing it the pre-opened TCP server socket. The service can then accept the client connection. This pat

[libvirt] [PATCH 4/6] LXC: Wire up the virDomainCreate{XML}WithFiles methods

2013-07-12 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Wire up the new virDomainCreate{XML}WithFiles methods in the LXC driver, so that FDs get passed down to the init process. The lxc_container code needs to do a little dance in order to renumber the file descriptors it receives into linear order, starting from STDERR_FIL

Re: [libvirt] Notes on configuring Open vSwitch, Linux bridge and Libvirt

2013-07-12 Thread Kashyap Chamarthy
On 07/12/2013 06:30 PM, Daniel Veillard wrote: > On Fri, Jul 12, 2013 at 05:51:14PM +0530, Kashyap Chamarthy wrote: >> Heya Laine, >> >> Here's some quick notes to associate libvirt guests to Open vSwitch. >> >> Configure Open vSwitch >> -- >> >> Now that a regular Linux bridge

Re: [libvirt] [PATCH v4 7/9] qemu: Introduce qemuBuildChrDeviceStr

2013-07-12 Thread John Ferlan
On 07/10/2013 01:02 PM, Michal Privoznik wrote: > The function being introduced is responsible for creating command > line argument for '-device' for given character device. Based on > the chardev type, it calls appropriate qemuBuild.*ChrDeviceStr(), > e.g. qemuBuildSerialChrDeviceStr() for serial

[libvirt] [RFC PATCH] qemu: Shorten SCSI hostdev alias to avoid QEMU failure

2013-07-12 Thread Viktor Mihajlovski
The alias for hostdevs of type SCSI can be too long for QEMU if larger LUNs are encountered. Here's a real life example: this results in a too long drive id, resulting in QEMU yelling Property 'scsi-generic.drive' can't find value 'drive-hostdev-

[libvirt] [PATCH v2] qemu: don't use deprecated -no-kvm-pit-reinjection

2013-07-12 Thread Ján Tomko
Since qemu-kvm 1.1 [1] (since 1.3. in upstream QEMU [2]) '-no-kvm-pit-reinjection' has been deprecated. Use -device kvm-pit,lost_tick_policy=discard instead. https://bugzilla.redhat.com/show_bug.cgi?id=978719 [1] http://git.kernel.org/cgit/virt/kvm/qemu-kvm.git/commit/?id=4e4fa39 [2] http://git.q

Re: [libvirt] Notes on configuring Open vSwitch, Linux bridge and Libvirt

2013-07-12 Thread Kashyap Chamarthy
[...] >> it appears that OpenStack uses Linux bridge in conjunction with an OVS >> bridge: >> >> There are four distinct type of virtual networking devices: TAP >> devices, veth pairs, Linux bridges, and Open vSwitch bridgesFor an >> ethernet frame to travel from eth0 of virtual machi

Re: [libvirt] [PATCH v3 06/10] Add capability to fetch balloon stats

2013-07-12 Thread John Ferlan
On 07/12/2013 08:42 AM, Daniel P. Berrange wrote: > On Thu, Jul 11, 2013 at 07:55:56PM -0400, John Ferlan wrote: >> This patch will add the qemuMonitorJSONGetMemoryStats() to execute a >> "guest-stats" on the balloonpath using "get-qom" replacing the former >> mechanism which looked through the "qu

Re: [libvirt] [PATCH v3 05/10] Determine whether to start balloon memory stats gathering.

2013-07-12 Thread John Ferlan
On 07/12/2013 08:39 AM, Daniel P. Berrange wrote: > On Thu, Jul 11, 2013 at 07:55:55PM -0400, John Ferlan wrote: >> At vm startup and attach attempt to set the balloon driver statistics >> collection period based on the value found in the domain xml file. This >> is not done at reconnect since it's

Re: [libvirt] [PATCH v3 10/10] Allow balloon driver collection to be adjusted dynamically

2013-07-12 Thread John Ferlan
On 07/12/2013 08:45 AM, Daniel P. Berrange wrote: > On Thu, Jul 11, 2013 at 07:56:00PM -0400, John Ferlan wrote: <...snip...> >> index 5fbd32c..4cbf105 100644 >> --- a/tools/virsh-domain-monitor.c >> +++ b/tools/virsh-domain-monitor.c >> @@ -314,6 +314,23 @@ static const vshCmdOptDef opts_dommems

Re: [libvirt] [PATCH v3 04/10] Add 'period' for Memballoon statistics gathering capability

2013-07-12 Thread John Ferlan
On 07/12/2013 08:35 AM, Daniel P. Berrange wrote: > ps, forgot to mention last time that you need to add a test case > for this new XML - or just add the XML to 1. Copied qemuxml2argv-balloon-device.xml to qemuxml2argv-balloon-device-period.xml, adding 2. Copied qemuxml2argv-balloon-device.arg

Re: [libvirt] Notes on configuring Open vSwitch, Linux bridge and Libvirt

2013-07-12 Thread Daniel P. Berrange
On Fri, Jul 12, 2013 at 07:05:00PM +0530, Kashyap Chamarthy wrote: > On 07/12/2013 06:32 PM, Daniel P. Berrange wrote: > > On Fri, Jul 12, 2013 at 05:51:14PM +0530, Kashyap Chamarthy wrote: > >> Heya Laine, > >> > >> Here's some quick notes to associate libvirt guests to Open vSwitch. > >> > >> Con

Re: [libvirt] ANNOUNCE: libvirt 1.0.5.3 maintenance release

2013-07-12 Thread Cole Robinson
On 07/12/2013 03:45 AM, Ján Tomko wrote: > On 07/12/2013 12:32 AM, Cole Robinson wrote: >> libvirt 1.0.5.3 maintenance release is now available. This is >> libvirt 1.0.5 with additional bugfixes that have accumulated >> upstream since the initial release. >> >> This release can be downloaded at: >>

Re: [libvirt] Notes on configuring Open vSwitch, Linux bridge and Libvirt

2013-07-12 Thread Kashyap Chamarthy
On 07/12/2013 06:32 PM, Daniel P. Berrange wrote: > On Fri, Jul 12, 2013 at 05:51:14PM +0530, Kashyap Chamarthy wrote: >> Heya Laine, >> >> Here's some quick notes to associate libvirt guests to Open vSwitch. >> >> Configure Open vSwitch >> -- >> >> Now that a regular Linux brid

Re: [libvirt] [PATCH v3 05/10] Determine whether to start balloon memory stats gathering.

2013-07-12 Thread Daniel P. Berrange
On Fri, Jul 12, 2013 at 09:15:40AM -0400, John Ferlan wrote: > On 07/12/2013 08:39 AM, Daniel P. Berrange wrote: > > On Thu, Jul 11, 2013 at 07:55:55PM -0400, John Ferlan wrote: > >> At vm startup and attach attempt to set the balloon driver statistics > >> collection period based on the value foun

Re: [libvirt] [PATCH v3 05/10] Determine whether to start balloon memory stats gathering.

2013-07-12 Thread John Ferlan
On 07/12/2013 08:39 AM, Daniel P. Berrange wrote: > On Thu, Jul 11, 2013 at 07:55:55PM -0400, John Ferlan wrote: >> At vm startup and attach attempt to set the balloon driver statistics >> collection period based on the value found in the domain xml file. This >> is not done at reconnect since it's

[libvirt] [PATCH] conf: reject pci-root controllers with non-zero indexes

2013-07-12 Thread Ján Tomko
https://bugzilla.redhat.com/show_bug.cgi?id=981261 --- src/conf/domain_conf.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 5f0366e..602c9a6 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -5668,6 +5668,13 @@ vi

Re: [libvirt] [PATCH] domain controller index check

2013-07-12 Thread Ján Tomko
On 07/09/2013 06:13 AM, Jincheng Miao wrote: > The index of the controller should not be limited in [zero, INT_MAX]. > So use virStrToLong_ui() and check the limit of the controller > index in virDomainControllerDefParseXML(). > --- > src/conf/domain_conf.c | 6 +++--- > src/conf/domain_conf.h |

Re: [libvirt] Notes on configuring Open vSwitch, Linux bridge and Libvirt

2013-07-12 Thread Daniel P. Berrange
On Fri, Jul 12, 2013 at 05:51:14PM +0530, Kashyap Chamarthy wrote: > Heya Laine, > > Here's some quick notes to associate libvirt guests to Open vSwitch. > > Configure Open vSwitch > -- > > Now that a regular Linux bridge is configured, let's try to configure an > OVS brdige

Re: [libvirt] Notes on configuring Open vSwitch, Linux bridge and Libvirt

2013-07-12 Thread Daniel Veillard
On Fri, Jul 12, 2013 at 05:51:14PM +0530, Kashyap Chamarthy wrote: > Heya Laine, > > Here's some quick notes to associate libvirt guests to Open vSwitch. > > Configure Open vSwitch > -- > > Now that a regular Linux bridge is configured, let's try to configure an > OVS brdige

Re: [libvirt] Notes on configuring Open vSwitch, Linux bridge and Libvirt

2013-07-12 Thread Kashyap Chamarthy
On 07/12/2013 05:51 PM, Kashyap Chamarthy wrote: > Heya Laine, > > Here's some quick notes to associate libvirt guests to Open vSwitch. > > Configure Open vSwitch > -- > > Now that a regular Linux bridge is configured, let's try to configure an > OVS brdige and get IP address

Re: [libvirt] [PATCH v3 10/10] Allow balloon driver collection to be adjusted dynamically

2013-07-12 Thread Daniel P. Berrange
On Thu, Jul 11, 2013 at 07:56:00PM -0400, John Ferlan wrote: > Use the virDomainSetMemoryStatsPeriodFlags() to pass a period defined by > usage of a new --period option in order to set the collection period for the > balloon driver. This may enable or disable the collection based on the value. > >

Re: [libvirt] [PATCH v3 07/10] Add new public API virDomainSetMemoryStatsPeriodFlags

2013-07-12 Thread Daniel P. Berrange
On Thu, Jul 11, 2013 at 07:55:57PM -0400, John Ferlan wrote: > Add new API in order to set the balloon memory driver statistics collection > period in order to allow dynamic period adjustment for the virsh dommemstats > to > display balloon stats data > --- > include/libvirt/libvirt.h.in | 3 +++

Re: [libvirt] [PATCH v3 09/10] Implement the virDomainSetMemoryStatsPeriodFlags for QEMU driver

2013-07-12 Thread Daniel P. Berrange
On Thu, Jul 11, 2013 at 07:55:59PM -0400, John Ferlan wrote: > Implement the new API that will handle setting the balloon driver statistics > collection period in order to enable or disable the collection dynamically. > --- > src/qemu/qemu_driver.c | 65 > +

Re: [libvirt] [PATCH v3 06/10] Add capability to fetch balloon stats

2013-07-12 Thread Daniel P. Berrange
On Thu, Jul 11, 2013 at 07:55:56PM -0400, John Ferlan wrote: > This patch will add the qemuMonitorJSONGetMemoryStats() to execute a > "guest-stats" on the balloonpath using "get-qom" replacing the former > mechanism which looked through the "query-ballon" returned data for > the fields. The "query

Re: [libvirt] [PATCH v3 08/10] Specify remote protocol for virDomainSetMemoryStatsPeriodFlags

2013-07-12 Thread Daniel P. Berrange
On Thu, Jul 11, 2013 at 07:55:58PM -0400, John Ferlan wrote: > Wire up the remote protocol > --- > src/remote/remote_driver.c | 1 + > src/remote/remote_protocol.x | 15 ++- > src/remote_protocol-structs | 6 ++ > 3 files changed, 21 insertions(+), 1 deletion(-) ACK Daniel

Re: [libvirt] [PATCH v3 05/10] Determine whether to start balloon memory stats gathering.

2013-07-12 Thread Daniel P. Berrange
On Thu, Jul 11, 2013 at 07:55:55PM -0400, John Ferlan wrote: > At vm startup and attach attempt to set the balloon driver statistics > collection period based on the value found in the domain xml file. This > is not done at reconnect since it's possible that a collection period > was set on the liv

Re: [libvirt] [PATCH v3 04/10] Add 'period' for Memballoon statistics gathering capability

2013-07-12 Thread Daniel P. Berrange
On Thu, Jul 11, 2013 at 07:55:54PM -0400, John Ferlan wrote: > Add a period in seconds to allow/enable statistics gathering from the > Balloon driver for 'virsh dommemstat '. > --- > docs/formatdomain.html.in | 10 ++ > docs/schemas/domaincommon.rng | 7 +++ > src/conf/domain_conf

Re: [libvirt] [PATCH v3 03/10] Add qemuMonitorJSONSetObjectProperty() method for QMP qom-set command

2013-07-12 Thread Daniel P. Berrange
On Thu, Jul 11, 2013 at 07:55:53PM -0400, John Ferlan wrote: > Add a new qemuMonitorJSONSetObjectProperty() method to support invocation > of the 'qom-set' JSON monitor command with a provided path, property, and > expected data type to set. > > The test code uses the same "/machine/i440fx" proper

Re: [libvirt] [PATCH v3 01/10] Add qemuMonitorJSONGetObjectListPaths() method for QMP qom-list command

2013-07-12 Thread Daniel P. Berrange
On Thu, Jul 11, 2013 at 07:55:51PM -0400, John Ferlan wrote: > Add a new qemuMonitorJSONGetObjectListPaths() method to support invocation > of the 'qom-list' JSON monitor command with a provided path. > > The returned list of paired data fields of "name" and "type" that can > be used to peruse QOM

Re: [libvirt] [PATCH v3 02/10] Add qemuMonitorJSONGetObjectProperty() method for QMP qom-get command

2013-07-12 Thread Daniel P. Berrange
On Thu, Jul 11, 2013 at 07:55:52PM -0400, John Ferlan wrote: > Add a new qemuMonitorJSONGetObjectProperty() method to support invocation > of the 'qom-get' JSON monitor command with a provided path, property, and > expected data type return. The qemuMonitorJSONObjectProperty is similar to > virType

Re: [libvirt] [PATCH] virsh: Mention --driver in man page for nodedev-detach

2013-07-12 Thread Peter Krempa
On 07/12/13 13:57, Laine Stump wrote: On 07/12/2013 05:40 AM, Peter Krempa wrote: Commit d923f6c8 introduced the --driver option but didn't document it in the man page. The docs are borrowed from the public API documentation. --- tools/virsh.pod | 8 +++- 1 file changed, 7 insertions(+),

[libvirt] Notes on configuring Open vSwitch, Linux bridge and Libvirt

2013-07-12 Thread Kashyap Chamarthy
Heya Laine, Here's some quick notes to associate libvirt guests to Open vSwitch. Configure Open vSwitch -- Now that a regular Linux bridge is configured, let's try to configure an OVS brdige and get IP addresses from that space: Create an Open vSwitch bridge device called 'o

Re: [libvirt] [PATCH] Fix crash when multiple event callbacks were registered

2013-07-12 Thread Daniel Veillard
On Wed, Jul 10, 2013 at 08:11:14AM -0600, Eric Blake wrote: > On 07/10/2013 05:02 AM, Daniel P. Berrange wrote: > > On Wed, Jul 10, 2013 at 12:59:48PM +0200, Ján Tomko wrote: > >> CVE-2013-2230 > > > > This should be in the subject line so it is more visible. > > Oh well, it was pushed without th

Re: [libvirt] [PATCH] virsh: Mention --driver in man page for nodedev-detach

2013-07-12 Thread Laine Stump
On 07/12/2013 05:40 AM, Peter Krempa wrote: > Commit d923f6c8 introduced the --driver option but didn't document it in > the man page. The docs are borrowed from the public API documentation. > --- > tools/virsh.pod | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) ACK. Sorry for the

Re: [libvirt] [java] Build Sources with plain Maven

2013-07-12 Thread philipp . haussleiter
Hi Daniel, hi all The main change is an updated POM File: > > http://maven.apache.org/POM/4.0.0"; > xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; > xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 > http://maven.apache.org/maven-v4_0_0.xsd";> > 4.0.0 > org.libvirt >

Re: [libvirt] [PATCH] Add a couple of debug statements to LXC driver

2013-07-12 Thread Gao feng
On 07/12/2013 06:06 PM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > When failing to start a container due to inaccessible root > filesystem path, we did not log any meaningful error. Add a > few debug statements to assist diagnosis > > Pushed under trivial rule > > Signed-off-by:

[libvirt] [PATCH] Add a couple of debug statements to LXC driver

2013-07-12 Thread Daniel P. Berrange
From: "Daniel P. Berrange" When failing to start a container due to inaccessible root filesystem path, we did not log any meaningful error. Add a few debug statements to assist diagnosis Pushed under trivial rule Signed-off-by: Daniel P. Berrange --- src/lxc/lxc_container.c | 8 +++- 1 fi

[libvirt] [PATCH] virsh: Mention --driver in man page for nodedev-detach

2013-07-12 Thread Peter Krempa
Commit d923f6c8 introduced the --driver option but didn't document it in the man page. The docs are borrowed from the public API documentation. --- tools/virsh.pod | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 94fe897..51644d9 10

Re: [libvirt] [java] Build Sources with plain Maven

2013-07-12 Thread Daniel P. Berrange
On Thu, Jul 11, 2013 at 11:37:19PM +0200, philipp.hausslei...@yahoo.de wrote: > Hi all, > > i recently tried to use the libvirt-java Bindings. Since the Build with > autobuild / ant / maven seems a little bit odd to me, i started with porting > the Build to plain maven. > > The only hard depen

Re: [libvirt] invoking qemu with -readconfig

2013-07-12 Thread Daniel P. Berrange
On Thu, Jul 11, 2013 at 12:56:31PM -0600, Jim Fehlig wrote: > Hi All, > > I was recently asked about the possibility of libvirt creating a config > file and then invoking qemu with '-readconfig ' instead of passing > all arguments on the command line. The primary reason for this request > is a mo

Re: [libvirt] [PATCH] storage: silently ignore missing files on pool refresh

2013-07-12 Thread Ján Tomko
On 07/10/2013 06:07 PM, Daniel P. Berrange wrote: > On Wed, Jul 10, 2013 at 05:00:59PM +0200, Michal Privoznik wrote: >> On 10.07.2013 16:57, Ján Tomko wrote: >>> From: Wei Zhou >>> >>> Make virStorageBackendVolOpenCheckMode return -2 instead of >>> -1 if volume file is missing. >>> >>> https://bu

Re: [libvirt] [PATCH 1/3] virAuth: Don't require virConnectPtr to retrieve authentication creds

2013-07-12 Thread Peter Krempa
On 07/11/13 18:10, Daniel P. Berrange wrote: On Wed, Jul 10, 2013 at 08:42:03AM +0200, Peter Krempa wrote: Previously a connection object was required to retrieve the auth credentials. This patch adds the option to call the retrieval functions only using the connection URI or path to the configu

Re: [libvirt] ANNOUNCE: libvirt 1.0.5.3 maintenance release

2013-07-12 Thread Ján Tomko
On 07/12/2013 12:32 AM, Cole Robinson wrote: > libvirt 1.0.5.3 maintenance release is now available. This is > libvirt 1.0.5 with additional bugfixes that have accumulated > upstream since the initial release. > > This release can be downloaded at: > > http://libvirt.org/sources/stable_updates/li

Re: [libvirt] [PATCH] nodeinfo: Don't fail on non-contiguous NUMA topologies

2013-07-12 Thread Peter Krempa
On 07/11/13 18:08, Daniel P. Berrange wrote: On Thu, Jul 11, 2013 at 04:09:47PM +0200, Peter Krempa wrote: From: hejia hejia nodeGetFreeMemory and nodeGetCellsFreeMemory assumed that the NUMA nodes are contiguous and starting from 0. Unfortunately there are machines that don't match this assum