On ven, 2013-08-09 at 18:24 -0600, Jim Fehlig wrote:
I should have tested this change on a system with libxl, but not booted
to Xen. libxl would have then complained, and I would have seen the
crash. Lesson learned...
Ups! I was wondering how that could happen, since I tested this too and
Hi,
do not know since when but i recently realized that the 'virsh list' command
shows me the first dom (the one with id 1) twice in the output List, e.g.
virsh # list
Id Name Status
--
1 essirlaufend
1 essir
On 08/02/13 23:47, Eric Blake wrote:
The logic set up in previous patch for exposing VIR_TEST_EXPENSIVE
to individual tests is as follows:
make check VIR_TEST_EXPENSIVE=0 = getenv(VIR_TEST_EXPENSIVE) sees 0
make check VIR_TEST_EXPENSIVE=1 = getenv(VIR_TEST_EXPENSIVE) sees 1
make check
On 08/02/13 23:08, Eric Blake wrote:
The gnulib testsuite is relatively stable - the only times it is
likely to have a test change from pass to fail is on a gnulib
submodule update or a major system change (such as moving from
Fedora 18 to 19, or other large change to libc). While it is an
Somehow I managed to leave this monstrosity in.
Introduced by 800b51d.
---
Pushed as trivial.
docs/formatdomain.html.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index dd22b6d..83d551a 100644
---
QEMU commit 3984890 introduced the pci-hole64-size property,
to i440FX-pcihost and q35-pcihost with a default setting of 2 GB.
Translate pcihole64 size='x'/ to:
-global q35-pcihost.pci-hole64-size=x for q35 machines and
-global i440FX-pcihost.pci-hole64-size=x for i440FX-based machines.
Error
features
pcihole64 size='0'/
/features
It can be used to adjust (or disable) the size of the 64-bit
PCI hole. The size attribute is in gigabytes, since it would
get rounded up to nearest GB by QEMU anyway.
Disabling it will be needed for guests that crash with the
64-bit PCI hole (like Windows
https://bugzilla.redhat.com/show_bug.cgi?id=990418
Ján Tomko (2):
Add pcihole64 element to domain features
Build QEMU command line for pcihole64
docs/formatdomain.html.in | 8 +
docs/schemas/domaincommon.rng | 7
On Mon, Aug 12, 2013 at 03:08:39PM +0200, Ján Tomko wrote:
QEMU commit 3984890 introduced the pci-hole64-size property,
to i440FX-pcihost and q35-pcihost with a default setting of 2 GB.
Translate pcihole64 size='x'/ to:
-global q35-pcihost.pci-hole64-size=x for q35 machines and
-global
On 08/02/13 23:13, Eric Blake wrote:
On 08/01/2013 07:24 AM, Peter Krempa wrote:
Excercise the arbitrary command passthrough API.
s/Excercise/Exercise/
---
tests/qemuagenttest.c | 45 +
1 file changed, 45 insertions(+)
ACK.
Pushed.
When undefining a domain with storage when the volume isn't managed by
libvirt the name and path strings weren't freed properly.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=996050
---
tools/virsh-domain.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/tools/virsh-domain.c
On 08/12/2013 03:11 AM, Stefan Scheglmann wrote:
Hi,
do not know since when but i recently realized that the 'virsh list' command
shows me the first dom (the one with id 1) twice in the output List, e.g.
virsh # list
Id Name Status
--
On 08/12/2013 05:54 AM, Peter Krempa wrote:
On 08/02/13 23:47, Eric Blake wrote:
The logic set up in previous patch for exposing VIR_TEST_EXPENSIVE
to individual tests is as follows:
+++ b/tests/testutils.c
@@ -66,6 +66,7 @@
static unsigned int testDebug = -1;
static unsigned int
Has anybody had a chance to review this patch?
On Fri, Aug 02, 2013 at 01:08:19PM -0600, n0ano wrote:
Currently the virConnectBaselineCPU API does not expose the CPU features
that are part of the CPU's model. This patch adds a new flag,
VIR_CONNECT_BASELINE_CPU_EXPAND_FEATURES, that causes
From: Daniel P. Berrange berra...@redhat.com
Add to the docs/drvlxc.html.in documentation to describe how to
configure systemd to auto-activate a container when a client
connects to a socket
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
docs/drvlxc.html.in | 119
On 08/12/2013 08:13 AM, Peter Krempa wrote:
When undefining a domain with storage when the volume isn't managed by
libvirt the name and path strings weren't freed properly.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=996050
---
tools/virsh-domain.c | 6 ++
1 file changed, 6
On 08/12/2013 04:13 PM, Peter Krempa wrote:
When undefining a domain with storage when the volume isn't managed by
libvirt the name and path strings weren't freed properly.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=996050
---
tools/virsh-domain.c | 6 ++
1 file changed, 6
On 08/12/2013 09:03 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Add to the docs/drvlxc.html.in documentation to describe how to
configure systemd to auto-activate a container when a client
connects to a socket
Signed-off-by: Daniel P. Berrange
On 08/12/2013 06:36 AM, Peter Krempa wrote:
On 08/02/13 23:08, Eric Blake wrote:
The gnulib testsuite is relatively stable - the only times it is
likely to have a test change from pass to fail is on a gnulib
submodule update or a major system change (such as moving from
Fedora 18 to 19, or
On 08/09/2013 10:20 PM, Doug Goldstein wrote:
I can ACK this by visual code inspection. I haven't explicitly tested
this patch but its a cleaned up version of the patch we previously
discussed it. If you need me to test it, I can do that tonight.
I'd feel better with an explicit test; we're
On 08/10/2013 01:43 AM, Guido Günther wrote:
qemuDomainAttachVirtioDiskDevice passes NULL as domainDef which is later
referenced in qemuDomainAttachVirtioDiskDevice:
This was found by libvirtt-tck:
http://honk.sigxcpu.org:8001/job/libvirt-tck-debian-wheezy-qemu-session/1311/console
On 08/11/2013 06:04 AM, Roman Bogorodskiy wrote:
- Introduce VIR_CGROUP_SUPPORTED conditional
- Convert virCgroupKill* to use it
- Convert virCgroupIsolateMount() to use it
---
src/util/vircgroup.c | 59
1 file changed, 32
Hi,
Today I was trying to start a node using libvirt on ESX (esxi-5.1)
hypervisor and I got the following error message:
*virsh # define /local/myNode/esxdomain.xml*
*Domain testNode defined from /local/myNode/esxdomain.xml*
*virsh # start testNode*
*error: Failed to start domain testNode*
On 08/09/2013 10:54 PM, Eric Blake wrote:
I attempted 'virsh blockcopy $dom vda $path --wait --verbose', then
hit Ctrl-C; I was a bit surprised to see this error message:
Block Copy: [ 3 %]error: failed to query job for disk vda
when I had been expecting:
Block Copy: [ 3 %]
Copy
On 08/02/13 23:34, Eric Blake wrote:
On 08/01/2013 07:24 AM, Peter Krempa wrote:
When the test-lib for shell tests was introduced it did think of
expensive tests although this option was never used.
More historically accurate: the shell script was lifted verbatim from
GNU coreutils, back in
On 08/12/2013 10:50 AM, Ján Tomko wrote:
On 08/09/2013 10:54 PM, Eric Blake wrote:
I attempted 'virsh blockcopy $dom vda $path --wait --verbose', then
hit Ctrl-C; I was a bit surprised to see this error message:
Block Copy: [ 3 %]error: failed to query job for disk vda
when I had been
On 08/11/2013 06:04 AM, Roman Bogorodskiy wrote:
- Convert virCgroupGet* to VIR_CGROUP_SUPPORTED
- Convert virCgroup(Get|Set)FreezerState to VIR_CGROUP_SUPPORTED
- Convert virCgroupRemoveRecursively to VIR_CGROUP_SUPPORTED
---
src/util/vircgroup.c | 363
On Mon, Aug 12, 2013 at 10:09:47AM -0600, Eric Blake wrote:
On 08/10/2013 01:43 AM, Guido Günther wrote:
qemuDomainAttachVirtioDiskDevice passes NULL as domainDef which is later
referenced in qemuDomainAttachVirtioDiskDevice:
This was found by libvirtt-tck:
On 08/11/2013 06:04 AM, Roman Bogorodskiy wrote:
Continue converting to VIR_CGROUP_SUPPORTED
---
src/util/vircgroup.c | 378
+++
1 file changed, 202 insertions(+), 176 deletions(-)
-if (STRNEQ(tmp, name)
-STRNEQ(tmp,
to fix the kFreeBSD build.
The network parameter is unused in networkCheckRouteCollision:
http://honk.sigxcpu.org:8001/job/libvirt-build-debian-jessie-kfreebsd64/
---
src/network/bridge_driver_nop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
otherwise we fail like:
CCLD virdbustest
/usr/bin/ld: virdbustest-virdbustest.o: undefined reference to symbol
'dbus_message_unref'
/lib/x86_64-linux-gnu/libdbus-1.so.3: error adding symbols: DSO missing
from command line
collect2: error: ld returned 1 exit status
Found by:
On 08/12/2013 01:08 PM, Guido Günther wrote:
to fix the kFreeBSD build.
The network parameter is unused in networkCheckRouteCollision:
http://honk.sigxcpu.org:8001/job/libvirt-build-debian-jessie-kfreebsd64/
---
src/network/bridge_driver_nop.c | 2 +-
1 file changed, 1 insertion(+),
On 08/12/2013 01:14 PM, Guido Günther wrote:
otherwise we fail like:
CCLD virdbustest
/usr/bin/ld: virdbustest-virdbustest.o: undefined reference to symbol
'dbus_message_unref'
/lib/x86_64-linux-gnu/libdbus-1.so.3: error adding symbols: DSO missing
from command line
On Mon, Aug 12, 2013 at 01:19:18PM -0600, Eric Blake wrote:
On 08/12/2013 01:08 PM, Guido Günther wrote:
to fix the kFreeBSD build.
The network parameter is unused in networkCheckRouteCollision:
http://honk.sigxcpu.org:8001/job/libvirt-build-debian-jessie-kfreebsd64/
---
On 08/11/2013 06:04 AM, Roman Bogorodskiy wrote:
Complete moving to VIR_CGROUP_SUPPORTED
---
src/util/vircgroup.c | 497
---
1 file changed, 272 insertions(+), 225 deletions(-)
This one felt a bit big...
-#if defined HAVE_MNTENT_H
On 08/11/2013 06:04 AM, Roman Bogorodskiy wrote:
Complete the refactoring by adding missing stubs so it compiles on
platform without cgroup support.
---
src/util/vircgroup.c | 311
++-
1 file changed, 306 insertions(+), 5 deletions(-)
ACK.
otherwise having a strict --no-copy-dt-needed-entries fails in several
places like:
otherwise we fail like:
CCLD virdbustest
/usr/bin/ld: virdbustest-virdbustest.o: undefined reference to symbol
'dbus_message_unref'
/lib/x86_64-linux-gnu/libdbus-1.so.3: error adding symbols: DSO
Cleanup the libxl capabilities code to be a bit more extensible,
splitting out the creation of host and guest capabilities. This
should make it easier to implement additional capabilities in the
future, such as NUMA topology reporting.
---
Although I can't see how changes here would affect other
On 08/12/2013 02:13 PM, Guido Günther wrote:
otherwise having a strict --no-copy-dt-needed-entries fails in several
places like:
otherwise we fail like:
CCLD virdbustest
/usr/bin/ld: virdbustest-virdbustest.o: undefined reference to symbol
'dbus_message_unref'
On Mon, Aug 12, 2013 at 01:21:08PM -0600, Eric Blake wrote:
On 08/12/2013 01:14 PM, Guido Günther wrote:
otherwise we fail like:
CCLD virdbustest
/usr/bin/ld: virdbustest-virdbustest.o: undefined reference to symbol
'dbus_message_unref'
Dario Faggioli wrote:
Starting from Xen 4.2, libxl has all the bits and pieces in place
for retrieving an adequate amount of information about the host
NUMA topology. It is therefore possible, after a bit of shuffling,
to arrange those information in the way libvirt wants to present
them to
On 08/05/2013 10:39 AM, Jim Fehlig wrote:
Commit 632180d1 introduced memory corruption in xenDaemonListDefinedDomains
by starting to populate the names array at index -1, causing all sorts
of havoc in libvirtd such as aborts like the following
*** Error in `/usr/sbin/libvirtd': double free
Hi Eric,
On Mon, Aug 12, 2013 at 02:15:50PM -0600, Eric Blake wrote:
On 08/12/2013 02:13 PM, Guido Günther wrote:
otherwise having a strict --no-copy-dt-needed-entries fails in several
places like:
otherwise we fail like:
CCLD virdbustest
/usr/bin/ld:
Reposting to show how I touched up the series. By doing a
bit more shuffling and splitting of the patches, I was able
to come up with a series that was easier to review. My
lead-in patches are really just pulling parts of Roman's
patches out into earlier commits, so that the remainder
of Roman's
Make future patches smaller by matching a sane header listing in
the first place. No semantic change.
* src/util/vircgroup.h: Move free next to new, and controller
functions next to each other.
* src/util/vircgroup.c (virCgroupFree, virCgroupHasController)
(virCgroupPathOfController,
From: Roman Bogorodskiy bogorods...@gmail.com
Complete moving to VIR_CGROUP_SUPPORTED
Signed-off-by: Eric Blake ebl...@redhat.com
---
src/util/vircgroup.c | 226 ++-
1 file changed, 114 insertions(+), 112 deletions(-)
diff --git
Format all functions with two blank lines between, and return type
on separate line from function name. Also break some lines longer
than 80 columns. This makes the subsequent macro refactoring
less noisy.
* src/util/vircgroup.c: Match prevailing style.
Signed-off-by: Eric Blake
Avoid a forward declaration of a static function.
* src/util/vircgroup.c (virCgroupPartitionNeedsEscaping)
(virCgroupParticionEscape): Move up.
Signed-off-by: Eric Blake ebl...@redhat.com
---
src/util/vircgroup.c | 176 +--
1 file changed, 87
From: Roman Bogorodskiy bogorods...@gmail.com
Complete the refactoring by adding missing stubs so it compiles on
platform without cgroup support.
Signed-off-by: Eric Blake ebl...@redhat.com
---
src/util/vircgroup.c | 324 +++
1 file changed, 324
From: Roman Bogorodskiy bogorods...@gmail.com
Continue converting to VIR_CGROUP_SUPPORTED
Signed-off-by: Eric Blake ebl...@redhat.com
---
src/util/vircgroup.c | 57 +++-
1 file changed, 43 insertions(+), 14 deletions(-)
diff --git
From: Roman Bogorodskiy bogorods...@gmail.com
- Convert virCgroupGet* to VIR_CGROUP_SUPPORTED
- Convert virCgroup(Get|Set)FreezerState to VIR_CGROUP_SUPPORTED
Signed-off-by: Eric Blake ebl...@redhat.com
---
src/util/vircgroup.c | 263 ++-
1 file
From: Roman Bogorodskiy bogorods...@gmail.com
- Introduce VIR_CGROUP_SUPPORTED conditional
- Convert virCgroupKill* to use it
- Convert virCgroupIsolateMount() to use it
- Convert virCgroupRemoveRecursively to VIR_CGROUP_SUPPORTED
Signed-off-by: Eric Blake ebl...@redhat.com
---
On 08/09/2013 03:23 AM, Daniel P. Berrange wrote:
Anyway, why I'm saying this is that one more filename should be renamed
in order to avoid a race (which I was unable to reproduce, though).
I have reproduced the race.
ACK, yes this is also needed ontop of my patch.
I went ahead and
Commit ab92ae333 added a cool feature, but didn't document it.
* docs/hacking.html.in: Document debugging a subset of tests.
* HACKING: Regenerate.
Signed-off-by: Eric Blake ebl...@redhat.com
---
Pushing under the trivial rule, as I found myself wanting to
use this during development today.
From: Li Zhang zhlci...@linux.vnet.ibm.com
Power7+ and Power8 are supported in QEMU, so it needs to define CPUs
in libvirt to support them.
Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com
---
src/cpu/cpu_map.xml | 11 +++
1 file changed, 11 insertions(+)
diff --git
https://bugzilla.redhat.com/show_bug.cgi?id=924153
Commit 904e05a2 (v0.9.9) added a per-disk seclabel element with
an attribute relabel='no' in order to try and minimize the
impact of shutdown delays when an NFS server disappears. The idea
was that if a disk is on NFS and can't be labeled in the
The Linux build revealed another missing direkt link target, this time
against selinux libs:
http://honk.sigxcpu.org:8001/view/libvirt/job/libvirt-build-debian-sid-amd64/9/console
---
Sorry for missing this in the previous patch.
-- GUido
tests/Makefile.am | 4 ++--
1 file changed, 2
57 matches
Mail list logo
