Re: [libvirt] [PATCH] network: permit upstream forwarding of unqualified DNS names

2013-08-14 Thread Martin Kletzander
On 08/14/2013 01:08 AM, Laine Stump wrote: This resolves the issue that prompted the filing of https://bugzilla.redhat.com/show_bug.cgi?id=928638 (although the request there is for something much larger and more general than this patch). commit f3868259ca0517212e439a65c9060868f673b6c9

Re: [libvirt] [PATCH 1/5] domifaddr: Implement the public API

2013-08-14 Thread Osier Yang
On 24/07/13 19:07, nehaljwani wrote: Define an new API virDomainInterfacesAddresses, which returns the address information of a running domain's interfaces(s). If no interface name is specified, it returns the information of all interfaces, otherwise it only returns the information of the

Re: [libvirt] [PATCH 2/5] domifaddr: Implement the remote protocol

2013-08-14 Thread Osier Yang
On 24/07/13 19:07, nehaljwani wrote: Implement RPC calls for virDomainInterfacesAddresses daemon/remote.c * Define remoteSerializeDomainInterfacePtr, remoteDispatchDomainInterfacesAddresses src/remote/remote_driver.c * Define remoteDomainInterfacesAddresses

Re: [libvirt] [PATCH 00/17] Add tests for disk hotplug

2013-08-14 Thread Jiri Denemark
On Thu, Aug 01, 2013 at 21:28:09 +0200, Jiri Denemark wrote: This series adds tests for hotplugging all supported disk types. Jiri Denemark (17): qemu: Typedef monitor callbacks qemu: Avoid using global qemu_driver in event handlers qemu: Move qemuDomainAttachDeviceDiskLive to

Re: [libvirt] [PATCH 3/5] domifaddr: Implement the API for qemu

2013-08-14 Thread Osier Yang
On 24/07/13 19:07, nehaljwani wrote: By querying the qemu guest agent with the QMP command guest-network-get-interfaces and converting the received JSON output to structured objects. src/qemu/qemu_agent.h: * Define qemuAgentGetInterfaces src/qemu/qemu_agent.c: * Implement

Re: [libvirt] [PATCH 4/5] domifaddr: Add virsh support

2013-08-14 Thread Osier Yang
On 24/07/13 19:07, nehaljwani wrote: Use virDomainInterfacesAddresses in virsh tools/virsh-domain-monitor.c * Introduce new command : domifaddr Example Usage: domifaddr domain-name interface-name (optional) As a habit, we indicate the optional optinon of command like: domifaddr

Re: [libvirt] [PATCH 5/5] domifaddr: Expose python binding

2013-08-14 Thread Osier Yang
On 24/07/13 19:07, nehaljwani wrote: Expose virDomainInterfacesAddresses to python binding examples/python/Makefile.am: * Add new file domipaddrs.py examples/python/README: * Add documentation for the python example python/libvirt-override-api.xml: * Add new symbol for

Re: [libvirt] [PATCH] Address missed feedback from review of virt-login-shell

2013-08-14 Thread Ruben Kerkhof
On Wed, Aug 14, 2013 at 1:35 AM, Eric Blake ebl...@redhat.com wrote: Pushed the fix in your name, along with another line with the same problem (unable chdir(%s), and wrapping some long lines: From 11cdc424d30b15c6780d546a2f0d8ff93ce291b6 Mon Sep 17 00:00:00 2001 From: Ruben Kerkhof

Re: [libvirt] [PATCH][Ruby] support: virNetworkUpdate

2013-08-14 Thread Chris Lalancette
On Tue, Aug 13, 2013 at 10:19 AM, Hiroshi Miura miur...@linux.com wrote: Hi Chris, On 2013年08月13日 09:55, Chris Lalancette wrote: Thanks for the patch, that is great! I've now applied it to the main ruby-libvirt repository. Let me know if you have any problems with it. Looks good. No

[libvirt] [PATCH] cgroup: Don't fail to start a VM when DBus isn't compiled in or running

2013-08-14 Thread Peter Krempa
The systemd code to create cgroups has fallback means built in, but fails to engage them if a host isn't running DBus or libvirtd is compiled without DBus (yes, you still don't need to run DBus). This patch changes the return value in case DBus isn't available to so that the fallback code can be

[libvirt] Using magic ELF notes to export info about QEMU monitor commands

2013-08-14 Thread Daniel P. Berrange
On another mailing list some folks were discussing how to determine what list of QEMU monitor commands a particular libvirt was written to be able to use. Rich Jones mentioned a thing they are doing in libguestfs using magic ELF notes: My only suggestion is that we could put the strings into a

[libvirt] [PATCH] virtio-rng: Remove double space in error message

2013-08-14 Thread Peter Krempa
--- Pushed under the trivial rule. src/qemu/qemu_command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index b811e1d..8b628d6 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -5909,7 +5909,7 @@

Re: [libvirt] [PATCHv3 2/4] add pci passthrough to libxl driver

2013-08-14 Thread Jim Fehlig
cy...@suse.com wrote: From: Chunyan Liu cy...@suse.com Add pci passthrough to libxl driver, support attach-device, detach-device and start a vm with pci hostdev specified. Signed-off-by: Chunyan Liu cy...@suse.com --- src/libxl/libxl_conf.c | 65 src/libxl/libxl_conf.h

[libvirt] Libvirt Sandbox mini-website

2013-08-14 Thread Daniel P. Berrange
While we've been working on it for a little while, we've never really had any content on libvirt.org focusing on the libvirt sandbox toolkit. To address this content gap, I've started a small website to provide useful info around their design, technology usage. http://sandbox.libvirt.org/

Re: [libvirt] [PATCHv3 4/4] change lxc driver to use hostdev common library

2013-08-14 Thread Jim Fehlig
cy...@suse.com wrote: From: Chunyan Liu cy...@suse.com Change lxc driver to use hostdev common library instead of its own APIs in lxc_hostdev.[ch] Signed-off-by: Chunyan Liu cy...@suse.com --- po/POTFILES.in|1 - src/Makefile.am |1 - src/lxc/lxc_conf.h|4 -

[libvirt] [PATCHv2 2/5] domifaddr: Implement the remote protocol

2013-08-14 Thread nehaljwani
Implement RPC calls for virDomainInterfacesAddresses daemon/remote.c * Define remoteSerializeDomainInterfacePtr, remoteDispatchDomainInterfacesAddresses src/remote/remote_driver.c * Define remoteDomainInterfacesAddresses src/remote/remote_protocol.x * New RPC procedure:

[libvirt] [PATCHv2 0/5] Introduce API to query IP addresses for given domain

2013-08-14 Thread nehaljwani
This feature has been requested for a very long time. Since qemu guest agent gives us reliable results, now the wait is over. The RFC was first proposed by Michal Privoznik: http://www.mail-archive.com/libvir-list@redhat.com/msg51857.html A patch was submitted, using structs:

[libvirt] [PATCHv2 1/5] domifaddr: Implement the public API

2013-08-14 Thread nehaljwani
Define a new API virDomainInterfacesAddresses, which returns the address information of a running domain's interfaces(s). If no interface name is specified, it returns the information of all interfaces, otherwise it only returns the information of the specificed interface. The address information

[libvirt] [PATCHv2 5/5] domifaddr: Expose python binding

2013-08-14 Thread nehaljwani
Expose virDomainInterfacesAddresses to python binding examples/python/Makefile.am: * Add new file domipaddrs.py examples/python/README: * Add documentation for the python example python/libvirt-override-api.xml: * Add new symbol for virDomainInterfacesAddresses python/libvirt-override.c:

[libvirt] [PATCHv2 4/5] domifaddr: Add virsh support

2013-08-14 Thread nehaljwani
Use virDomainInterfacesAddresses in virsh tools/virsh-domain-monitor.c * Introduce new command : domifaddr Example Usage: domifaddr domain [interface] tools/virsh.pod * Document new command --- tools/virsh-domain-monitor.c | 102 +++

[libvirt] [PATCHv2 3/5] domifaddr: Implement the API for qemu

2013-08-14 Thread nehaljwani
By querying the qemu guest agent with the QMP command guest-network-get-interfaces and converting the received JSON output to structured objects. src/qemu/qemu_agent.h: * Define qemuAgentGetInterfaces src/qemu/qemu_agent.c: * Implement qemuAgentGetInterface src/qemu/qemu_driver.c: * New

[libvirt] [PATCH] libxl: remove unnecessary curly braces

2013-08-14 Thread Jim Fehlig
As per HACKING, remove some unneeded curly braces in the libxl driver. --- Noticed the unneeded braces while reviewing Chunyan's hostdev passthrough series. Not sure if this qualifies as trivial enough to just push, but best for a quick review anyhow to ensure I didn't botch something.

[libvirt] [PATCH] examples: support crash events in event-test.py

2013-08-14 Thread Giuseppe Scrivano
commit 14e7e0ae8db9843aea80245a3d9e6cf5f2ef720d adds the support for crash events. Solves: https://bugzilla.redhat.com/show_bug.cgi?id=994317 Signed-off-by: Giuseppe Scrivano gscri...@redhat.com --- examples/domain-events/events-python/event-test.py | 6 -- 1 file changed, 4 insertions(+),

Re: [libvirt] [PATCH] libxl: remove unnecessary curly braces

2013-08-14 Thread Eric Blake
On 08/14/2013 03:41 PM, Jim Fehlig wrote: As per HACKING, remove some unneeded curly braces in the libxl driver. --- Noticed the unneeded braces while reviewing Chunyan's hostdev passthrough series. Not sure if this qualifies as trivial enough to just push, but best for a quick review

Re: [libvirt] [PATCH] examples: support crash events in event-test.py

2013-08-14 Thread Eric Blake
On 08/14/2013 03:06 PM, Giuseppe Scrivano wrote: commit 14e7e0ae8db9843aea80245a3d9e6cf5f2ef720d adds the support for crash events. Solves: https://bugzilla.redhat.com/show_bug.cgi?id=994317 Signed-off-by: Giuseppe Scrivano gscri...@redhat.com ---

Re: [libvirt] [PATCH] libxl: remove unnecessary curly braces

2013-08-14 Thread Jim Fehlig
Eric Blake wrote: On 08/14/2013 03:41 PM, Jim Fehlig wrote: As per HACKING, remove some unneeded curly braces in the libxl driver. --- Noticed the unneeded braces while reviewing Chunyan's hostdev passthrough series. Not sure if this qualifies as trivial enough to just push, but best

[libvirt] [PATCH 1/2] maint: avoid bootstrap warning

2013-08-14 Thread Eric Blake
I noticed that in a fresh checkout, autogen.sh included the following: autoreconf: running: automake --add-missing --copy --force-missing gnulib/tests/Makefile.am:28: TESTS was already defined in condition TRUE, which includes condition WITH_EXPENSIVE_TESTS ... gnulib/tests/gnulib.mk:28: ...

[libvirt] [PATCH 0/2] gnulib update

2013-08-14 Thread Eric Blake
I'll probably push this in another 24 hours if I don't get a review (I'm not pushing it now, because I want to test it on a few more machines first...). Eric Blake (2): maint: avoid bootstrap warning maint: update gnulib submodule .gnulib| 2 +- bootstrap | 35

[libvirt] [PATCH 2/2] maint: update gnulib submodule

2013-08-14 Thread Eric Blake
Gnulib recently patched gcc warning detection so that it does not treat things like -Wno-unused-command-line-argument as supported in gcc (treating it as supported merely resulted in extra verbosity when an actual compile error occurred). It has also improved bootstrap to work with less hassle on

[libvirt] Xen Developers Summit 2013, CfP (24-25 October, Edinburgh)

2013-08-14 Thread Dario Faggioli
== Call for Proposals == We are pleased to announce that the Call for Proposals (CFP) for the first Xen Project Developer Summit is now open! The event is being held in Edinburgh, UK from October 24-25. All submissions need to be submitted by 11:55pm (BST) on August 30th. The Xen Project

Re: [libvirt] [PATCH] libxl: refactor capabilities code

2013-08-14 Thread Dario Faggioli
On lun, 2013-08-12 at 14:15 -0600, Jim Fehlig wrote: Cleanup the libxl capabilities code to be a bit more extensible, splitting out the creation of host and guest capabilities. This should make it easier to implement additional capabilities in the future, such as NUMA topology reporting. Ok,

Re: [libvirt] [PATCH v4 2/2] libxl: implement NUMA capabilities reporting

2013-08-14 Thread Dario Faggioli
On lun, 2013-08-12 at 14:25 -0600, Jim Fehlig wrote: diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index 827dfdd..2c84191 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -161,6 +161,107 @@ libxlBuildCapabilities(virArch hostarch, } static

Re: [libvirt] [PATCHv2 1/5] domifaddr: Implement the public API

2013-08-14 Thread Osier Yang
On 15/08/13 04:54, nehaljwani wrote: Define a new API virDomainInterfacesAddresses, which returns the address information of a running domain's interfaces(s). If no interface name is specified, it returns the information of all interfaces, otherwise it only returns the information of the

Re: [libvirt] [PATCHv2 2/5] domifaddr: Implement the remote protocol

2013-08-14 Thread Osier Yang
On 15/08/13 04:54, nehaljwani wrote: Implement RPC calls for virDomainInterfacesAddresses daemon/remote.c * Define remoteSerializeDomainInterfacePtr, remoteDispatchDomainInterfacesAddresses src/remote/remote_driver.c * Define remoteDomainInterfacesAddresses

Re: [libvirt] [PATCHv2 3/5] domifaddr: Implement the API for qemu

2013-08-14 Thread Osier Yang
On 15/08/13 04:54, nehaljwani wrote: By querying the qemu guest agent with the QMP command guest-network-get-interfaces and converting the received JSON output to structured objects. src/qemu/qemu_agent.h: * Define qemuAgentGetInterfaces src/qemu/qemu_agent.c: * Implement

Re: [libvirt] [PATCHv2 4/5] domifaddr: Add virsh support

2013-08-14 Thread Osier Yang
On 15/08/13 04:54, nehaljwani wrote: Use virDomainInterfacesAddresses in virsh tools/virsh-domain-monitor.c * Introduce new command : domifaddr Example Usage: domifaddr domain [interface] tools/virsh.pod * Document new command --- tools/virsh-domain-monitor.c | 102

Re: [libvirt] [PATCHv2 5/5] domifaddr: Expose python binding

2013-08-14 Thread Osier Yang
On 15/08/13 04:54, nehaljwani wrote: Expose virDomainInterfacesAddresses to python binding examples/python/Makefile.am: * Add new file domipaddrs.py examples/python/README: * Add documentation for the python example python/libvirt-override-api.xml: * Add new symbol for

[libvirt] [test-API][PATCH] Add display of cases result to log.xml

2013-08-14 Thread Hongming Zhang
The original log.xml only display the testrun result, the patch add display of case result to log.xml. modified: src/generator.py -Perserver case result list and pass it to log_generator class. modified: src/log.xsl -Read from xml and display case result modified: src/log_generator.py

Re: [libvirt] Please help confirm this upsream issue

2013-08-14 Thread Zhenfeng Wang
On 08/07/2013 03:41 AM, Daniel P. Berrange wrote: On Wed, Aug 07, 2013 at 02:34:56AM -0400, Zhenfeng Wang wrote: Hi I just try to verify the bug 828546 with the latest libvirt version on rhel7, and found an issue that the on_crash element on guest's xml didn't support the

Re: [libvirt] [test-API][PATCH] Add display of cases result to log.xml

2013-08-14 Thread hongming
Hi Guannan You can see the new test report from the following url. http://fileshare.englab.nay.redhat.com/pub/section3/libvirtauto/libvirt-test-API/log.xml Thanks Hongming On 08/15/2013 11:32 AM, Hongming Zhang wrote: The original log.xml only display the testrun result, the patch add

Re: [libvirt] [test-API][PATCH] Add display of cases result to log.xml

2013-08-14 Thread Guannan Ren
On 08/15/2013 01:47 PM, hongming wrote: Hi Guannan You can see the new test report from the following url. http://fileshare.englab.nay.redhat.com/pub/section3/libvirtauto/libvirt-test-API/log.xml Thanks Hongming Hi hongming, Patch looks good, ACK. Next time, please don't send