Hi hongming,
BTW, could we ignore module or function name in Test Procedure
section, because the module and entry function are the same name,
it's a deliberately design, but the Test Procedure looks like
a duplicate naming for others.
slice
network:define:define
On 08/15/2013 02:00 PM, Alex Jia wrote:
Hi hongming,
BTW, could we ignore module or function name in Test Procedure
section, because the module and entry function are the same name,
it's a deliberately design, but the Test Procedure looks like
a duplicate naming for others.
I agree with you.
Gren, I think it should be enough if we can know which test cases
is run, and should hide some details such as checkpoint and clean
function.
--
Regards,
Alex
- Original Message -
From: Guannan Ren g...@redhat.com
To: Alex Jia a...@redhat.com
Cc: hongming honzh...@redhat.com,
On 08/15/2013 02:31 PM, Alex Jia wrote:
Gren, I think it should be enough if we can know which test cases
is run, and should hide some details such as checkpoint and clean
function.
Okay, anyway, we have detailed log to check.
without the function name, the UI could become more concise.
--
On Tue, Aug 13, 2013 at 01:10:11PM -0400, Dan Walsh wrote:
This will allow us to run sandbox as the calling process, If I am
running a shell as staff_u:unconfined_r:unconfined_t:s0, and I
execute virt-sandbox -c lxc/// -- /bin/sh
/bin/sh will run as staff_u:unconfined_r:unconfined_t:s0
---
On Tue, Aug 13, 2013 at 01:10:12PM -0400, Dan Walsh wrote:
Do not attempt to fix the unit file of Generic Containers.
---
bin/virt-sandbox-service | 36 ++--
1 file changed, 18 insertions(+), 18 deletions(-)
I co-incidentally did exactly the same fix, so you
Hello,
In the recent months various new methods were added to libvirt-java
which we (Apache CloudStack) would like to use in our KVM code.
For example resizing storage volumes, right now we have to do this with
Bash scripting since although libvirt supports resizing volumes, the
current
On Thu, Aug 15, 2013 at 02:24:26AM +0530, nehaljwani wrote:
diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in
index 52ac95d..fa49e70 100644
--- a/include/libvirt/libvirt.h.in
+++ b/include/libvirt/libvirt.h.in
@@ -2044,6 +2044,38 @@ int
---
docs/formatnode.html.in | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/docs/formatnode.html.in b/docs/formatnode.html.in
index 5f57a5a..b424c96 100644
--- a/docs/formatnode.html.in
+++ b/docs/formatnode.html.in
@@ -136,11 +136,11 @@
dl
On 07/24/2013 10:05 PM, Seiji Aguchi wrote:
[Problem]
Currently, guest OS's messages can be logged to a local disk of host OS
by creating chadevs with options below.
s/chadevs/chardevs/
-chardev file,id=charserial0,path=log file's path -device
isa-serial,chardev=chardevserial0,id=serial0
On Thu, Aug 15, 2013 at 02:24:27AM +0530, nehaljwani wrote:
Implement RPC calls for virDomainInterfacesAddresses
daemon/remote.c
* Define remoteSerializeDomainInterfacePtr,
remoteDispatchDomainInterfacesAddresses
src/remote/remote_driver.c
* Define remoteDomainInterfacesAddresses
On Thu, Aug 15, 2013 at 02:24:28AM +0530, nehaljwani wrote:
By querying the qemu guest agent with the QMP command
guest-network-get-interfaces and converting the received
JSON output to structured objects.
src/qemu/qemu_agent.h:
* Define qemuAgentGetInterfaces
src/qemu/qemu_agent.c:
On Thu, Aug 15, 2013 at 02:24:29AM +0530, nehaljwani wrote:
Use virDomainInterfacesAddresses in virsh
tools/virsh-domain-monitor.c
* Introduce new command : domifaddr
Example Usage: domifaddr domain [interface]
It would be preferrable if the commit message showed the example
output
On 08/15/2013 11:36 AM, Xuesong Zhang wrote:
---
docs/formatnode.html.in | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
ACK
I've renamed the commit to:
docs: fix usb node device sub-element names
and pushed it.
Jan
--
libvir-list mailing list
libvir-list@redhat.com
From: Daniel P. Berrange berra...@redhat.com
Feedback from the polkit developers indicates that the
_detail_ attributes are a private implementation
detail. Our examples should be recommending use of the
action.lookup('XXX') method instead.
Signed-off-by: Daniel P. Berrange
13/08/13 16:15, Daniel P. Berrange wrote:
On Tue, Aug 13, 2013 at 01:52:33PM +0200, Fred A. Kemp wrote:
From: Fred A. Kemp ano...@riseup.net
Allow use of the usb-storage device only if the new capability flag
QEMU_CAPS_DEVICE_USB_STORAGE is set, which it is for qemu(-kvm)
versions =
On Thu, Aug 15, 2013 at 12:55:26PM +0200, anonym wrote:
13/08/13 16:15, Daniel P. Berrange wrote:
On Tue, Aug 13, 2013 at 01:52:33PM +0200, Fred A. Kemp wrote:
From: Fred A. Kemp ano...@riseup.net
Allow use of the usb-storage device only if the new capability flag
Let virDomainControllerDefParseXML use it without
a forward declaration.
---
src/conf/domain_conf.c | 105 +
1 file changed, 53 insertions(+), 52 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 7309877..4e24101
QEMU commit 3984890 introduced the pci-hole64-size property,
to i440FX-pcihost and q35-pcihost with a default setting of 2 GB.
Translate pcihole64xpcihole64/ to:
-global q35-pcihost.pci-hole64-size=x for q35 machines and
-global i440FX-pcihost.pci-hole64-size=x for i440FX-based machines.
Error
v3:
use pcihole64 sub-element of the root PCI controller
with 'unit' attribute, defaulting to KiB
v2:
https://www.redhat.com/archives/libvir-list/2013-August/msg00565.html
Use 'pcihole64' attribute of the root PCI controller
instead of pcihole64 element in domain features.
v1:
virDomainParseScaledValue requires it.
---
src/conf/domain_conf.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 4e24101..fece93a 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -5659,6 +5659,7
controller type='pci' index='0' model='pci-root'
pcihole64 unit='KiB'1048576/pcihole64
/controller
It can be used to adjust (or disable) the size of the 64-bit
PCI hole. The size attribute is in kilobytes (different unit
can be specified on input), but it gets rounded up to
the nearest GB by
On Wed, Aug 14, 2013 at 04:57:51AM +0530, Nehal J. Wani wrote:
On Wed, Aug 14, 2013 at 4:29 AM, Eric Blake ebl...@redhat.com wrote:
On 08/13/2013 04:48 PM, Eric Blake wrote:
virNetworkGetDHCPLeaseForMAC(virNetworkPtr network,
unsigned char *macaddr,
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 08/15/2013 04:48 AM, Daniel P. Berrange wrote:
On Tue, Aug 13, 2013 at 01:10:11PM -0400, Dan Walsh wrote:
This will allow us to run sandbox as the calling process, If I am
running a shell as staff_u:unconfined_r:unconfined_t:s0, and I execute
On Thu, Aug 15, 2013 at 07:43:01AM -0400, Daniel J Walsh wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 08/15/2013 04:48 AM, Daniel P. Berrange wrote:
On Tue, Aug 13, 2013 at 01:10:11PM -0400, Dan Walsh wrote:
This will allow us to run sandbox as the calling process, If I am
Do not attempt to fix the unit file of Generic Containers.
---
bin/virt-sandbox-service | 36 ++--
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/bin/virt-sandbox-service b/bin/virt-sandbox-service
index 03873c9..3e83c94 100755
---
This will allow us to run sandbox as the calling process, If I am
running a shell as staff_u:unconfined_r:unconfined_t:s0, and I
execute virt-sandbox -c lxc/// -- /bin/sh
/bin/sh will run as staff_u:unconfined_r:unconfined_t:s0
---
bin/virt-sandbox.c | 4
Since lots of people want to try out LXC with virt-sandbox, executing
-c lxc:/// is a pain, but users might not know about the varible or the
config file.
---
bin/virt-sandbox.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/bin/virt-sandbox.c b/bin/virt-sandbox.c
index
[sandbox PATCH 1/5] Add virt-sandbox -s inherit, to execute the
[sandbox PATCH 2/5] Unit files only exist in Systemd Containers.
[sandbox PATCH 3/5] -S is not supported by virt-sandbox
[sandbox PATCH 4/5] Fix SEE ALSO lines to be multi-line
[sandbox PATCH 5/5] virt-sandbox needs to mention
-S option has been removed from virt-sandbox, should be removed from man page.
---
bin/virt-sandbox.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/bin/virt-sandbox.c b/bin/virt-sandbox.c
index 14700d7..c21a8a6 100644
--- a/bin/virt-sandbox.c
+++ b/bin/virt-sandbox.c
@@ -269,8 +269,6 @@
---
bin/virt-sandbox-service.pod | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/bin/virt-sandbox-service.pod b/bin/virt-sandbox-service.pod
index 7752145..b879a46 100644
--- a/bin/virt-sandbox-service.pod
+++ b/bin/virt-sandbox-service.pod
@@ -54,7 +54,11 @@ supported
On Thu, Aug 15, 2013 at 08:04:41AM -0400, Dan Walsh wrote:
This will allow us to run sandbox as the calling process, If I am
running a shell as staff_u:unconfined_r:unconfined_t:s0, and I
execute virt-sandbox -c lxc/// -- /bin/sh
/bin/sh will run as staff_u:unconfined_r:unconfined_t:s0
---
On Thu, Aug 15, 2013 at 08:04:42AM -0400, Dan Walsh wrote:
Do not attempt to fix the unit file of Generic Containers.
---
bin/virt-sandbox-service | 36 ++--
1 file changed, 18 insertions(+), 18 deletions(-)
You'll find I've already committed the same fix when
On Thu, Aug 15, 2013 at 08:04:43AM -0400, Dan Walsh wrote:
-S option has been removed from virt-sandbox, should be removed from man page.
---
bin/virt-sandbox.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/bin/virt-sandbox.c b/bin/virt-sandbox.c
index 14700d7..c21a8a6 100644
---
On Thu, Aug 15, 2013 at 08:04:44AM -0400, Dan Walsh wrote:
---
bin/virt-sandbox-service.pod | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/bin/virt-sandbox-service.pod b/bin/virt-sandbox-service.pod
index 7752145..b879a46 100644
--- a/bin/virt-sandbox-service.pod
On Thu, Aug 15, 2013 at 08:04:45AM -0400, Dan Walsh wrote:
Since lots of people want to try out LXC with virt-sandbox, executing
-c lxc:/// is a pain, but users might not know about the varible or the
config file.
---
bin/virt-sandbox.c | 5 -
1 file changed, 4 insertions(+), 1
From: Daniel P. Berrange berra...@redhat.com
The fetch_list helper cleanup code iterates over the
elements in 'lst' array free'ing each one. This is dead
code, however, since the only way to get there is from
codepaths which do not populate 'lst' elements.
This fixes two coverity DEADCODE
On 08/15/2013 03:36 AM, Ján Tomko wrote:
+dev-source.data.file.path = strdup(/dev/null);
+
+if (!(dev-source.data.file.path)) {
+virReportOOMError();
+return -1;
+}
+
This can be reduced to:
if (VIR_STRDUP(dev-source.data.file.path,
On 08/15/2013 04:16 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Feedback from the polkit developers indicates that the
_detail_ attributes are a private implementation
detail. Our examples should be recommending use of the
action.lookup('XXX') method
This restores the error message when QMP probing is not used.
https://bugzilla.redhat.com/show_bug.cgi?id=991334
---
src/qemu/qemu_process.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 0dccac3..31de759 100644
On 08/15/2013 07:10 AM, Ján Tomko wrote:
This restores the error message when QMP probing is not used.
https://bugzilla.redhat.com/show_bug.cgi?id=991334
---
src/qemu/qemu_process.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
ACK.
+++ b/src/qemu/qemu_process.c
@@
On 08/15/2013 03:18 PM, Eric Blake wrote:
On 08/15/2013 07:10 AM, Ján Tomko wrote:
This restores the error message when QMP probing is not used.
https://bugzilla.redhat.com/show_bug.cgi?id=991334
---
src/qemu/qemu_process.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
Dario Faggioli wrote:
On lun, 2013-08-12 at 14:15 -0600, Jim Fehlig wrote:
Cleanup the libxl capabilities code to be a bit more extensible,
splitting out the creation of host and guest capabilities. This
should make it easier to implement additional capabilities in the
future, such as
Hi,
I was trying to add volume...I got one xml snippet and I modified it
according to my node configuration:
volume
nametestNode/cluster.vmdk /name
allocation0 /allocation
capacity unit='G'2capacity
/volume
Now when I executed virsh vol-create datastore1 /local/new_volume.xml one
error message
This series aims to fix all the issues coverity identified with
libvirt-sandbox. No critical issues found - just dead code, resource
leaks and some missing return checks and a minor crash in CLI tool
parsing.
--
libvir-list mailing list
libvir-list@redhat.com
From: Daniel P. Berrange berra...@redhat.com
Most calls to mkdir() in libvirt-sandbox-init-qemu had their
return value checked, but one was missed.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
libvirt-sandbox/libvirt-sandbox-init-qemu.c | 6 +-
1 file changed, 5 insertions(+),
From: Daniel P. Berrange berra...@redhat.com
Neither virt-sandbox or virt-sandbox-service man pages documented
the 'ram' filesystem mount syntax. Fix that, and also add new line
breaks in virt-sandbox-service man page.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
From: Daniel P. Berrange berra...@redhat.com
In libvirt-sandbox-init-qemu if open() returned -1 and errno
was set to EEXIST then close() would be called on a FD that
was -1. This fixes a coverity identified issue.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
From: Daniel P. Berrange berra...@redhat.com
The 'int fd' variable in gvir_sandbox_builder_machine_mkinitrd was
no longer used, causing a coverity warning about dead code.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
libvirt-sandbox/libvirt-sandbox-builder-machine.c | 3 ---
1 file
From: Daniel P. Berrange berra...@redhat.com
If the user specified '-m ram:/tmp' instead of '-m ram:/tmp=500M'
the code would reference a NULL pointer. Fix it to return an
error message instead. This fixes a coverity identified issue.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
From: Daniel P. Berrange berra...@redhat.com
If several error cases of the run_interactive method, the
sigpipe or host file descriptors could be leaked.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
libvirt-sandbox/libvirt-sandbox-init-common.c | 6 --
1 file changed, 4
From: Daniel P. Berrange berra...@redhat.com
The 'FILE *' handle used to read /proc/cmdline was not
closed in all codepaths. This caused coverity to identify
a resource leak.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
libvirt-sandbox/libvirt-sandbox-init-qemu.c | 3 ++-
1 file
From: Daniel P. Berrange berra...@redhat.com
The 'config' object in libvirt-sandbox-context-service.c
methods cannot be NULL, so checking 'if (config)' is
pointless code.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
libvirt-sandbox/libvirt-sandbox-context-service.c | 6 ++
1
From: Daniel P. Berrange berra...@redhat.com
The 'default' case somehow got placed on the wrong line,
leading to unreachable code.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
libvirt-sandbox/libvirt-sandbox-config-interactive.c | 3 +--
1 file changed, 1 insertion(+), 2
There is a potential leak of a newly created libxlDomainObjPrivate
when subsequent allocation of the object's chrdev field fails.
Unref the object on such an error so that it is properly disposed.
---
src/libxl/libxl_driver.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
On 08/15/2013 10:23 AM, Jim Fehlig wrote:
There is a potential leak of a newly created libxlDomainObjPrivate
when subsequent allocation of the object's chrdev field fails.
Unref the object on such an error so that it is properly disposed.
---
src/libxl/libxl_driver.c | 4 +++-
1 file
Eric Blake wrote:
On 08/15/2013 10:23 AM, Jim Fehlig wrote:
There is a potential leak of a newly created libxlDomainObjPrivate
when subsequent allocation of the object's chrdev field fails.
Unref the object on such an error so that it is properly disposed.
---
src/libxl/libxl_driver.c |
On 08/12/13 17:25, Ján Tomko wrote:
On 08/12/2013 04:13 PM, Peter Krempa wrote:
When undefining a domain with storage when the volume isn't managed by
libvirt the name and path strings weren't freed properly.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=996050
---
Jan,
Thank you for reviewing.
I will fix the patch in accordance with your comments.
Seiji
-Original Message-
From: Ján Tomko [mailto:jto...@redhat.com]
Sent: Thursday, August 15, 2013 5:36 AM
To: Seiji Aguchi
Cc: libvir-list@redhat.com
Subject: Re: [libvirt] [PATCH v3] xml:
Eric,
+dev-source.data.file.path = strdup(/dev/null);
+
+if (!(dev-source.data.file.path)) {
+virReportOOMError();
+return -1;
+}
+
This can be reduced to:
if (VIR_STRDUP(dev-source.data.file.path, /dev/null) 0)
return -1;
Rather than inlining gl_WARN_ADD loads of time, we can shave about
17k size off of the configure script by delaying it to a cleanup
shell loop.
* m4/virt-compile-warnings.m4 (LIBVIRT_COMPILE_WARNINGS): Track a
list of things to check, rather than inlining multiple checks.
Signed-off-by: Eric
On 08/14/2013 05:44 PM, Eric Blake wrote:
I'll probably push this in another 24 hours if I don't get a
review (I'm not pushing it now, because I want to test it on
a few more machines first...).
My testing passed on RHEL 5, RHEL 6, Fedora 19, and FreeBSD, which
covers a pretty wide range of
On 08/12/2013 02:15 PM, Jim Fehlig wrote:
Cleanup the libxl capabilities code to be a bit more extensible,
splitting out the creation of host and guest capabilities. This
should make it easier to implement additional capabilities in the
future, such as NUMA topology reporting.
---
* src/util/virnetdevvportprofile.c: Fix typo.
* src/conf/domain_conf.c: Likewise.
Signed-off-by: Eric Blake ebl...@redhat.com
---
Pushing under the trivial rule.
src/conf/domain_conf.c | 2 +-
src/util/virnetdevvportprofile.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
64 matches
Mail list logo
