Re: [libvirt] [PATCH] Test for object identity when checking for None in Python

2013-08-23 Thread Claudio Bley
At Fri, 23 Aug 2013 11:25:35 +0800, Guannan Ren wrote: On 08/22/2013 09:56 PM, Claudio Bley wrote: Consistently use is or is not to compare variables to None, because doing so is preferrable, as per PEP 8 (http://www.python.org/dev/peps/pep-0008/#programming-recommendations):

Re: [libvirt] [PATCH v3 0/4] Add support for adjusting the 64-bit PCI hole size

2013-08-23 Thread Ján Tomko
On 08/15/2013 01:30 PM, Ján Tomko wrote: v3: use pcihole64 sub-element of the root PCI controller with 'unit' attribute, defaulting to KiB v2: https://www.redhat.com/archives/libvir-list/2013-August/msg00565.html Use 'pcihole64' attribute of the root PCI controller instead of pcihole64

Re: [libvirt] [libvirt-users] virsh cpu-stats not working !!!

2013-08-23 Thread SHREE DUTH AWASTHI
Hi Again Eric, Sorry for spamming. Adding to the below mail. The cgroups are mounted at /dev as mentioned below # ls /dev/ | grep cgroup cgroup_cpu cgroup_cpuacct cgroup_cpuset cgroup_mem On a liter note, On 08/21/2013 03:55 AM, SHREE DUTH AWASTHI wrote: is coming by default while I try to

Re: [libvirt] [PATCH]LXC doc: Add warns if net namespace not enabled

2013-08-23 Thread Gao feng
On 08/23/2013 01:18 PM, Chen Hanxiao wrote: From: Chen Hanxiao chenhanx...@cn.fujitsu.com If we don't enable network namespace, we could shutdown host by executing command 'shutdown' inside container. This patch will add some warnings in LXC docs and give some advice to readers.

[libvirt] [PATCH] qemuBuildNicDevStr: Set vectors= on Multiqueue

2013-08-23 Thread Michal Privoznik
Yet another advice appeared on the Multiqueue wiki page: http://www.linux-kvm.org/page/Multiqueue#Enable_MQ_feature We should add vectors=N onto the qemu command line, where N = 2 * (number of queues) + 1. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/qemu/qemu_command.c | 13

Re: [libvirt] pvpanic plans?

2013-08-23 Thread Paolo Bonzini
Il 22/08/2013 22:39, Anthony Liguori ha scritto: On Thu, Aug 22, 2013 at 3:36 PM, Laszlo Ersek ler...@redhat.com wrote: On 08/22/13 22:09, Anthony Liguori wrote: The difference is that ACPI or platform devices in general are unexpected to be added. By definition it means that the motherboard

Re: [libvirt] [PATCH] python: simplify complicated conditional assignment

2013-08-23 Thread Claudio Bley
At Thu, 22 Aug 2013 09:55:08 +0200, Claudio Bley wrote: At Wed, 21 Aug 2013 10:24:16 -0600, Eric Blake wrote: On 08/21/2013 08:05 AM, Claudio Bley wrote: Signed-off-by: Claudio Bley cb...@av-test.de --- Just noticed this while reading the generated .py files. Might

Re: [libvirt] [PATCHv3 1/5] domifaddr: Implement the public API

2013-08-23 Thread Osier Yang
On 23/08/13 06:18, nehaljwani wrote: Define a new API virDomainInterfacesAddresses, which returns the address information of a running domain's interfaces(s). If no interface name is specified, it returns the information of all interfaces, otherwise it only returns the information of the

Re: [libvirt] [PATCHv3 1/5] domifaddr: Implement the public API

2013-08-23 Thread Osier Yang
On 23/08/13 17:52, Osier Yang wrote: On 23/08/13 06:18, nehaljwani wrote: Define a new API virDomainInterfacesAddresses, which returns the address information of a running domain's interfaces(s). If no interface name is specified, it returns the information of all interfaces, otherwise it only

Re: [libvirt] [PATCHv3 2/5] domifaddr: Implement the remote protocol

2013-08-23 Thread Osier Yang
On 23/08/13 06:18, nehaljwani wrote: Implement RPC calls for virDomainInterfacesAddresses daemon/remote.c * Define remoteSerializeDomainInterfacePtr, remoteDispatchDomainInterfacesAddresses src/remote/remote_driver.c * Define remoteDomainInterfacesAddresses

[libvirt] [PATCH] virsh: fix return value error of cpu-stats

2013-08-23 Thread Guannan Ren
virsh cpu-stats guest --start 0 --count 3 It outputs right but the return value is 1 rather than 0 echo $? 1 Found by running libvirt-autotest ./run -t libvirt --tests virsh_cpu_stats --- tools/virsh-domain.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git

Re: [libvirt] [PATCHv3 3/5] domifaddr: Implement the API for qemu

2013-08-23 Thread Osier Yang
On 23/08/13 06:18, nehaljwani wrote: By querying the qemu guest agent with the QMP command guest-network-get-interfaces and converting the received JSON output to structured objects. src/qemu/qemu_agent.h: * Define qemuAgentGetInterfaces src/qemu/qemu_agent.c: * Implement

[libvirt] [PATCHv2 1/2] qemu: Add capability flag for usb-storage

2013-08-23 Thread Fred A. Kemp
From: Fred A. Kemp ano...@riseup.net Allow use of the usb-storage device only if the new capability flag QEMU_CAPS_DEVICE_USB_STORAGE is set, which it is for qemu(-kvm) versions = 0.12.1.2-rhel62-beta. --- src/qemu/qemu_capabilities.c |2 ++ src/qemu/qemu_capabilities.h |1 +

[libvirt] [PATCHv2 0/2] Support setting the 'removable' flag for USB disks

2013-08-23 Thread Fred A. Kemp
From: Fred A. Kemp ano...@riseup.net The commit message of patch #2 explains the purpose of this patch set. A review would be greatly appreciated! Note that I've only added the new capability for usb-storage.removable to the qemu help tests of qemu(-kvm) version 1.2.0, since that's what I had

Re: [libvirt] [PATCHv3 4/5] domifaddr: Add virsh support

2013-08-23 Thread Osier Yang
On 23/08/13 06:18, nehaljwani wrote: Use virDomainInterfacesAddresses in virsh tools/virsh-domain-monitor.c * Introduce new command : domifaddr virsh # domifaddr f18 Name MAC address IP address --- lo

Re: [libvirt] [PATCHv3 5/5] domifaddr: Expose python binding

2013-08-23 Thread Osier Yang
On 23/08/13 06:18, nehaljwani wrote: Expose virDomainInterfacesAddresses to python binding examples/python/Makefile.am: * Add new file domipaddrs.py examples/python/README: * Add documentation for the python example python/libvirt-override-api.xml: * Add new symbol for

[libvirt] [PATCH] Always specify qcow2 compat level on qemu-img command line

2013-08-23 Thread Ján Tomko
qemu-img is going to switch the default for QCOW2 to QCOW2v3 (compat=1.1) [0] Extend the probing for qemu-img command line options to check if -o compat is supported. If the volume definition specifies the qcow2 format but no compat level and -o compat is supported, specify -o compat=0.10 to

Re: [libvirt] [Qemu-devel] [PATCH] kvm: warn if num cpus is greater than num recommended

2013-08-23 Thread Andrew Jones
- Original Message - Am 22.08.2013 18:12, schrieb Eduardo Habkost: On 22/08/2013, at 12:39, Andrew Jones drjo...@redhat.com wrote: The comment in kvm_max_vcpus() states that it's using the recommended procedure from the kernel API documentation to get the max number of

[libvirt] [PATCH] schema: Allow dots in device aliases

2013-08-23 Thread Jiri Denemark
Commit 01b88127 changed aliases for PCI controller devices to pcie.0 or pci.%u. Thus device aliases may now contain dots. --- docs/schemas/domaincommon.rng | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index

Re: [libvirt] [PATCH] schema: Allow dots in device aliases

2013-08-23 Thread Eric Blake
On 08/23/2013 07:11 AM, Jiri Denemark wrote: Commit 01b88127 changed aliases for PCI controller devices to pcie.0 or pci.%u. Thus device aliases may now contain dots. --- docs/schemas/domaincommon.rng | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ACK. diff --git

[libvirt] [PATCH v2] kvm: warn if num cpus is greater than num recommended

2013-08-23 Thread Andrew Jones
The comment in kvm_max_vcpus() states that it's using the recommended procedure from the kernel API documentation to get the max number of vcpus that kvm supports. It is, but by always returning the maximum number supported. The maximum number should only be used for development purposes. qemu

Re: [libvirt] [PATCHv3 4/5] domifaddr: Add virsh support

2013-08-23 Thread Doug Goldstein
On Thu, Aug 22, 2013 at 5:18 PM, nehaljwani nehaljw.k...@gmail.com wrote: Use virDomainInterfacesAddresses in virsh tools/virsh-domain-monitor.c * Introduce new command : domifaddr virsh # domifaddr f18 Name MAC address IP address

Re: [libvirt] [PATCHv3 4/5] domifaddr: Add virsh support

2013-08-23 Thread Nehal J Wani
On Fri, Aug 23, 2013 at 8:16 PM, Doug Goldstein car...@gentoo.org wrote: On Thu, Aug 22, 2013 at 5:18 PM, nehaljwani nehaljw.k...@gmail.com wrote: Use virDomainInterfacesAddresses in virsh tools/virsh-domain-monitor.c * Introduce new command : domifaddr virsh # domifaddr f18

Re: [libvirt] [PATCH] tests: skip schema validation tests if xmllint is missing

2013-08-23 Thread Eric Blake
On 08/22/2013 08:43 PM, Osier Yang wrote: On 23/08/13 04:08, Eric Blake wrote: On IRC, someone complained that a system without xmllint installed failed a number of tests. * tests/schematestutils.sh: Probe for xmllint. Signed-off-by: Eric Blake ebl...@redhat.com ---

Re: [libvirt] [PATCHv3 4/5] domifaddr: Add virsh support

2013-08-23 Thread Doug Goldstein
On Fri, Aug 23, 2013 at 10:45 AM, Nehal J Wani nehaljw.k...@gmail.comwrote: On Fri, Aug 23, 2013 at 8:16 PM, Doug Goldstein car...@gentoo.org wrote: On Thu, Aug 22, 2013 at 5:18 PM, nehaljwani nehaljw.k...@gmail.com wrote: Use virDomainInterfacesAddresses in virsh