Re: [libvirt] [PATCH 1/3] CPU: Implement guestData for PPC CPU driver

2013-09-02 Thread Li Zhang
On 2013年09月02日 12:08, Doug Goldstein wrote: On Thu, Aug 29, 2013 at 3:46 AM, Li Zhang zhlci...@gmail.com mailto:zhlci...@gmail.com wrote: From: Li Zhang zhlci...@linux.vnet.ibm.com mailto:zhlci...@linux.vnet.ibm.com On Power platform, Power7+ can support Power7 guest. It needs

[libvirt] Is it a problem that after virEventRegisterDefaultImpl we have handlers leaked

2013-09-02 Thread Wangyufei (A)
Hello, When I ran programme event-test compiled from event-test.c, I found a problem that, after virEventRegisterDefaultImpl I do virConnectOpenAuth and virConnectClose, there will be handlers of socket and pipe opened by virConnectOpenAuth leaked after virConnectClose. So I did some analysis,

[libvirt] [PATCH 4/5] qemu: refactor out function to build scsi device qemu commandline

2013-09-02 Thread Guannan Ren
--- src/qemu/qemu_command.c | 124 +++- 1 file changed, 48 insertions(+), 76 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index f38e98f..e46baaf 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@

[libvirt] [PATCH 0/5]qemu: add usb-bot scsi controller support

2013-09-02 Thread Guannan Ren
BZ:https://bugzilla.redhat.com/show_bug.cgi?id=917702 qemu patch:http://lists.gnu.org/archive/html/qemu-devel/2013-01/msg02200.html These patch aims to add usb-bot SCSI controller support for libvirt. As usb-storage libvirt already supported, usb-bot only supports one SCSI target with SCSI ID 0.

[libvirt] [PATCH 1/5] qemu: add usb-bot qemu cap flag

2013-09-02 Thread Guannan Ren
QEMU_CAPS_DEVICE_USB_BOT /* -device usb-bot */ --- src/qemu/qemu_capabilities.c | 3 +++ src/qemu/qemu_capabilities.h | 1 + 2 files changed, 4 insertions(+) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 7888e2d..6a775ee 100644 --- a/src/qemu/qemu_capabilities.c

[libvirt] [PATCH 5/5] tests: add xml2argv test for usb-bot scsi controller

2013-09-02 Thread Guannan Ren
--- .../qemuxml2argv-disk-scsi-usbbot.args | 10 +++ .../qemuxml2argv-disk-scsi-usbbot.xml | 33 ++ tests/qemuxml2argvtest.c | 3 ++ 3 files changed, 46 insertions(+) create mode 100644

[libvirt] [PATCH 2/5] qemu: add usb-bot model scsi controller support

2013-09-02 Thread Guannan Ren
usb-bot is SCSI HBA which support only one SCSI target with ID 0. we can create one or more SCSI devices connected to it with -device as its luns. For usb-bot the limit is 15 luns. The difference from other SCSI controllers is that usb-bot needs usb-bus support. That means usb-bot is required to

[libvirt] [PATCH 3/5] qemu: add usb-bot support from disks points of view

2013-09-02 Thread Guannan Ren
usb-bot only supports 16 luns(0~15) and they must be contiguous, (using lun 0 and 2 without 1 doesn't work). In this case qemu doesn't throw an error, we can not find the lun 2 in guests. So Adding a checking function in libvirt to prevent from this case. --- src/conf/domain_conf.c | 59

Re: [libvirt] [PATCHv5 1/5] domifaddr: Implement the public APIs

2013-09-02 Thread Nehal J Wani
On Sun, Sep 1, 2013 at 7:13 PM, Nehal J Wani nehaljw.k...@gmail.com wrote: Define a new API virDomainInterfaceAddresses, which returns the address information of a running domain's interfaces(s). If no interface name is specified, it returns the information of all interfaces, otherwise it only

Re: [libvirt] [PATCHv5 5/5] domifaddr: Expose python binding

2013-09-02 Thread Nehal J Wani
On Sun, Sep 1, 2013 at 7:13 PM, Nehal J Wani nehaljw.k...@gmail.com wrote: Expose virDomainInterfaceAddresses to python binding examples/python/Makefile.am: * Add new file domipaddrs.py examples/python/README: * Add documentation for the python example python/libvirt-override-api.xml:

Re: [libvirt] [PATCH 08/12] libxl: Use atomic ops for driver-nactive

2013-09-02 Thread Michal Privoznik
On 30.08.2013 23:46, Jim Fehlig wrote: Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_conf.h | 2 +- src/libxl/libxl_driver.c | 10 -- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/src/libxl/libxl_conf.h b/src/libxl/libxl_conf.h index

Re: [libvirt] [PATCH 06/12] libxl: User per-domain ctx in libxlDomainGetInfo

2013-09-02 Thread Michal Privoznik
On 30.08.2013 23:46, Jim Fehlig wrote: libxlDomainGetInfo() uses the driver-wide libxl ctx when it would be more appropriate to use the per-domain ctx associated with the domain. Switch to using the per-domain libxl ctx. Signed-off-by: Jim Fehlig jfeh...@suse.com ---

Re: [libvirt] [PATCH 07/12] libxl: Introduce libxlDriverConfig object

2013-09-02 Thread Michal Privoznik
On 30.08.2013 23:46, Jim Fehlig wrote: The libxlDriverPrivate struct contains an variety of data with varying access needs. Similar to the QEMU and LXC drivers, move all the static config data into a dedicated libxlDriverConfig object. The only locking requirement is to hold the driver lock

Re: [libvirt] [PATCH 11/12] libxl: Remove unnecessary driver locking

2013-09-02 Thread Michal Privoznik
On 30.08.2013 23:46, Jim Fehlig wrote: Now that most fields of libxlDriverPrivate struct are immutable or self-locking, there is no need to acquire the driver lock in much of the libxl driver. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_conf.c | 7 +-

Re: [libvirt] [PATCH 05/12] libxl: libxl: Use per-domain ctx in libxlMakeDomCreateInfo

2013-09-02 Thread Michal Privoznik
On 30.08.2013 23:46, Jim Fehlig wrote: libxlMakeDomCreateInfo() uses the driver-wide libxl ctx when it would be more appropriate to use the per-domain ctx associated with the domain. Switch to using the per-domain libxl ctx. Signed-off-by: Jim Fehlig jfeh...@suse.com ---

Re: [libvirt] [PATCH 10/12] libxl: Move driver lock/unlock to libxl_conf

2013-09-02 Thread Michal Privoznik
On 30.08.2013 23:46, Jim Fehlig wrote: Move the libxl driver lock/unlock functions from libxl_driver.c to libxl_conf.h so they can be used by other source files. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_conf.h | 12 src/libxl/libxl_driver.c | 12

Re: [libvirt] [PATCH 02/12] libxl: Introduce libxl_domain.[ch]

2013-09-02 Thread Michal Privoznik
On 30.08.2013 23:46, Jim Fehlig wrote: Create libxl_domain.[ch] and move all functions operating on libxlDomainObjPrivate to these files. This will be useful for future patches that e.g. add job support for libxlDomainObjPrivate. Signed-off-by: Jim Fehlig jfeh...@suse.com ---

Re: [libvirt] [PATCH 12/12] libxl: Add libxlDomObjFromDomain

2013-09-02 Thread Michal Privoznik
On 30.08.2013 23:46, Jim Fehlig wrote: Similar to the QEMU and LXC drivers, add a helper function to lookup a domain, and use it instead of much copy and paste. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_driver.c | 269 ++-

Re: [libvirt] [PATCH 04/12] libxl: Add libxl_version_info to libxlDriverPrivate

2013-09-02 Thread Michal Privoznik
On 30.08.2013 23:46, Jim Fehlig wrote: libxl version info is static data as far as the libxl driver is concerned, so retrieve this info when the driver is initialized and stash it in the libxlDriverPrivate object. Subsequently use the stashed info instead of repeatedly calling

Re: [libvirt] [PATCH 01/12] libxl: Move detection of autoballoon to libxl_conf

2013-09-02 Thread Michal Privoznik
On 30.08.2013 23:46, Jim Fehlig wrote: Detecting whether or not to autoballoon is configuration related, so move the code to libxl_conf. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_conf.c | 22 ++ src/libxl/libxl_conf.h | 3 +++

Re: [libvirt] [PATCH 03/12] libxl: Earlier detection of not running on Xen

2013-09-02 Thread Michal Privoznik
On 30.08.2013 23:46, Jim Fehlig wrote: Detect early on in libxl driver initialization if the driver should be loaded at all, avoiding needless initialization steps that only have to be undone later. While at it, move th s/th/the/ detection to a helper function to improve readability.

Re: [libvirt] [PATCH 09/12] libxl: Add comments to libxlDriverPrivate fields

2013-09-02 Thread Michal Privoznik
On 30.08.2013 23:46, Jim Fehlig wrote: Similar to the QEMU and LXC drivers, annotate the fields of libxlDriverPrivate struct to indicate the locking rules for their use. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_conf.h | 7 +++ 1 file changed, 7 insertions(+)

Re: [libvirt] [PATCH 01/12] libxl: Move detection of autoballoon to libxl_conf

2013-09-02 Thread Daniel P. Berrange
On Fri, Aug 30, 2013 at 03:46:47PM -0600, Jim Fehlig wrote: Detecting whether or not to autoballoon is configuration related, so move the code to libxl_conf. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_conf.c | 22 ++ src/libxl/libxl_conf.h | 3

Re: [libvirt] [PATCH 02/12] libxl: Introduce libxl_domain.[ch]

2013-09-02 Thread Daniel P. Berrange
On Fri, Aug 30, 2013 at 03:46:48PM -0600, Jim Fehlig wrote: Create libxl_domain.[ch] and move all functions operating on libxlDomainObjPrivate to these files. This will be useful for future patches that e.g. add job support for libxlDomainObjPrivate. Signed-off-by: Jim Fehlig

Re: [libvirt] [PATCH 03/12] libxl: Earlier detection of not running on Xen

2013-09-02 Thread Daniel P. Berrange
On Fri, Aug 30, 2013 at 03:46:49PM -0600, Jim Fehlig wrote: Detect early on in libxl driver initialization if the driver should be loaded at all, avoiding needless initialization steps that only have to be undone later. While at it, move th detection to a helper function to improve

Re: [libvirt] [PATCH 02/12] libxl: Introduce libxl_domain.[ch]

2013-09-02 Thread Daniel P. Berrange
On Mon, Sep 02, 2013 at 12:22:40PM +0100, Daniel P. Berrange wrote: On Fri, Aug 30, 2013 at 03:46:48PM -0600, Jim Fehlig wrote: Create libxl_domain.[ch] and move all functions operating on libxlDomainObjPrivate to these files. This will be useful for future patches that e.g. add job

Re: [libvirt] [PATCH 04/12] libxl: Add libxl_version_info to libxlDriverPrivate

2013-09-02 Thread Daniel P. Berrange
On Fri, Aug 30, 2013 at 03:46:50PM -0600, Jim Fehlig wrote: libxl version info is static data as far as the libxl driver is concerned, so retrieve this info when the driver is initialized and stash it in the libxlDriverPrivate object. Subsequently use the stashed info instead of repeatedly

Re: [libvirt] [PATCH 06/12] libxl: User per-domain ctx in libxlDomainGetInfo

2013-09-02 Thread Daniel P. Berrange
On Fri, Aug 30, 2013 at 03:46:52PM -0600, Jim Fehlig wrote: libxlDomainGetInfo() uses the driver-wide libxl ctx when it would be more appropriate to use the per-domain ctx associated with the domain. Switch to using the per-domain libxl ctx. Signed-off-by: Jim Fehlig jfeh...@suse.com ---

Re: [libvirt] [PATCH 05/12] libxl: libxl: Use per-domain ctx in libxlMakeDomCreateInfo

2013-09-02 Thread Daniel P. Berrange
On Fri, Aug 30, 2013 at 03:46:51PM -0600, Jim Fehlig wrote: libxlMakeDomCreateInfo() uses the driver-wide libxl ctx when it would be more appropriate to use the per-domain ctx associated with the domain. Switch to using the per-domain libxl ctx. Signed-off-by: Jim Fehlig jfeh...@suse.com

Re: [libvirt] [PATCH 07/12] libxl: Introduce libxlDriverConfig object

2013-09-02 Thread Daniel P. Berrange
On Fri, Aug 30, 2013 at 03:46:53PM -0600, Jim Fehlig wrote: The libxlDriverPrivate struct contains an variety of data with varying access needs. Similar to the QEMU and LXC drivers, move all the static config data into a dedicated libxlDriverConfig object. The only locking requirement is to

Re: [libvirt] [PATCH 09/12] libxl: Add comments to libxlDriverPrivate fields

2013-09-02 Thread Daniel P. Berrange
On Fri, Aug 30, 2013 at 03:46:55PM -0600, Jim Fehlig wrote: Similar to the QEMU and LXC drivers, annotate the fields of libxlDriverPrivate struct to indicate the locking rules for their use. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_conf.h | 7 +++ 1 file

Re: [libvirt] [PATCH 08/12] libxl: Use atomic ops for driver-nactive

2013-09-02 Thread Daniel P. Berrange
On Fri, Aug 30, 2013 at 03:46:54PM -0600, Jim Fehlig wrote: Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_conf.h | 2 +- src/libxl/libxl_driver.c | 10 -- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/src/libxl/libxl_conf.h

Re: [libvirt] [PATCH 10/12] libxl: Move driver lock/unlock to libxl_conf

2013-09-02 Thread Daniel P. Berrange
On Fri, Aug 30, 2013 at 03:46:56PM -0600, Jim Fehlig wrote: Move the libxl driver lock/unlock functions from libxl_driver.c to libxl_conf.h so they can be used by other source files. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_conf.h | 12

Re: [libvirt] [PATCH 11/12] libxl: Remove unnecessary driver locking

2013-09-02 Thread Daniel P. Berrange
On Fri, Aug 30, 2013 at 03:46:57PM -0600, Jim Fehlig wrote: Now that most fields of libxlDriverPrivate struct are immutable or self-locking, there is no need to acquire the driver lock in much of the libxl driver. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_conf.c |

Re: [libvirt] [PATCH 12/12] libxl: Add libxlDomObjFromDomain

2013-09-02 Thread Daniel P. Berrange
On Fri, Aug 30, 2013 at 03:46:58PM -0600, Jim Fehlig wrote: Similar to the QEMU and LXC drivers, add a helper function to lookup a domain, and use it instead of much copy and paste. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_driver.c | 269

Re: [libvirt] [PATCH] build: only create virt-login-shell for lxc builds

2013-09-02 Thread Daniel P. Berrange
On Fri, Aug 30, 2013 at 02:37:20PM -0600, Eric Blake wrote: I noticed from an ./autobuild.sh run that we were installing a virt-login-shell.exe binary when cross-building for mingw, even though such a binary is necessarily worthless since the code depends on lxc which is a Linux-only concept.

Re: [libvirt] [PATCH 2/2] Pass AM_LDFLAGS to driver modules too

2013-09-02 Thread Daniel P. Berrange
On Sun, Sep 01, 2013 at 11:31:01AM +0200, Guido Günther wrote: This gives us a RO got, otherwise Debian's lintian complains: W: libvirt-bin: hardening-no-relro usr/lib/libvirt/connection-driver/libvirt_driver_qemu.so W: libvirt-bin: hardening-no-relro

Re: [libvirt] [PATCHv5 1/5] domifaddr: Implement the public APIs

2013-09-02 Thread Daniel P. Berrange
On Sun, Sep 01, 2013 at 07:13:31PM +0530, Nehal J Wani wrote: Define a new API virDomainInterfaceAddresses, which returns the address information of a running domain's interfaces(s). If no interface name is specified, it returns the information of all interfaces, otherwise it only returns the

Re: [libvirt] [PATCH 1/2] Fix AM_LDFLAGS typo

2013-09-02 Thread Daniel P. Berrange
On Sun, Sep 01, 2013 at 11:30:46AM +0200, Guido Günther wrote: --- This should probably go into 1.1.2 src/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Makefile.am b/src/Makefile.am index 636bcbc..19dfb81 100644 --- a/src/Makefile.am +++

Re: [libvirt] [PATCHv5 2/5] domifaddr: Implement the remote protocol

2013-09-02 Thread Daniel P. Berrange
On Sun, Sep 01, 2013 at 07:13:32PM +0530, Nehal J Wani wrote: daemon/remote.c * Define remoteSerializeDomainInterface, remoteDispatchDomainInterfaceAddresses src/remote/remote_driver.c * Define remoteDomainInterfaceAddresses src/remote/remote_protocol.x * New RPC procedure:

[libvirt] [PATCH] storage: new backend: btrfs subvolumes

2013-09-02 Thread Oskari Saarenmaa
This commit adds a new storage pool driver, btrfs, which can be used to manage btrfs subvolumes on an existing btrfs filesystem. The driver can create new blank subvolumes and snapshots of existing subvolumes as well as delete existing subvolumes. The subvolumes created are automatically made

Re: [libvirt] [PATCHv5 3/5] domifaddr: Implement the API for qemu

2013-09-02 Thread Daniel P. Berrange
On Sun, Sep 01, 2013 at 07:13:33PM +0530, Nehal J Wani wrote: +int +qemuAgentGetInterfaces(qemuAgentPtr mon, + virDomainInterfacePtr **ifaces) +{ + +/* interface name is required to be presented */ +name = virJSONValueObjectGetString(tmp_iface, name);

[libvirt] [PATCH] Add forwarders attribute to dns / element.

2013-09-02 Thread Diego Woitasen
Useful to set custom forwarders instead of using the contents of /etc/resolv.conf. It helps me to setup dnsmasq as local nameserver to resolv VM domain names from domain 0, when domain option is used. Signed-off-by: Diego Woitasen diego.woita...@vhgroup.net --- src/conf/network_conf.c

Re: [libvirt] [PATCHv5 4/5] domifaddr: Add virsh support

2013-09-02 Thread Daniel P. Berrange
On Sun, Sep 01, 2013 at 07:13:34PM +0530, Nehal J Wani wrote: Use virDomainInterfaceAddresses in virsh tools/virsh-domain-monitor.c * Introduce new command : domifaddr Usage: domifaddr domain [interface] [full] 'full' shouldn't be a positional arg - it should just be a flag eg

Re: [libvirt] [PATCH] Add forwarders attribute to dns / element.

2013-09-02 Thread Daniel P. Berrange
On Mon, Sep 02, 2013 at 08:50:30AM -0300, Diego Woitasen wrote: Useful to set custom forwarders instead of using the contents of /etc/resolv.conf. It helps me to setup dnsmasq as local nameserver to resolv VM domain names from domain 0, when domain option is used. Signed-off-by: Diego

Re: [libvirt] [PATCH] Add forwarders attribute to dns / element.

2013-09-02 Thread Diego Woitasen
On Mon, Sep 2, 2013 at 8:54 AM, Daniel P. Berrange berra...@redhat.com wrote: On Mon, Sep 02, 2013 at 08:50:30AM -0300, Diego Woitasen wrote: Useful to set custom forwarders instead of using the contents of /etc/resolv.conf. It helps me to setup dnsmasq as local nameserver to resolv VM

Re: [libvirt] [PATCH] Add forwarders attribute to dns / element.

2013-09-02 Thread Daniel P. Berrange
On Mon, Sep 02, 2013 at 09:27:59AM -0300, Diego Woitasen wrote: On Mon, Sep 2, 2013 at 8:54 AM, Daniel P. Berrange berra...@redhat.com wrote: On Mon, Sep 02, 2013 at 08:50:30AM -0300, Diego Woitasen wrote: Useful to set custom forwarders instead of using the contents of /etc/resolv.conf.

Re: [libvirt] [PATCH v3 3/8] qemu: Don't add default memballoon device on ARM

2013-09-02 Thread Daniel P. Berrange
On Fri, Aug 30, 2013 at 12:41:31PM -0400, Cole Robinson wrote: And add test cases for a basic working ARM guest. --- docs/schemas/domaincommon.rng | 19 + src/qemu/qemu_domain.c | 4 ++- .../qemuxml2argv-arm-vexpressa9-nodevs.args

Re: [libvirt] [PATCH v3 4/8] qemu: Fix specifying char devs for ARM

2013-09-02 Thread Daniel P. Berrange
On Fri, Aug 30, 2013 at 12:41:32PM -0400, Cole Robinson wrote: QEMU ARM boards don't give us any way to explicitly wire in a -chardev, so use the old style -serial options. Unfortunately this isn't as simple as just turning off the CHARDEV flag for qemu-system-arm, as upcoming virtio support

Re: [libvirt] [PATCH v3 2/8] domain_conf: Add default memballoon in PostParse callbacks

2013-09-02 Thread Daniel P. Berrange
On Fri, Aug 30, 2013 at 12:41:30PM -0400, Cole Robinson wrote: This should be a no-op change for now. --- src/conf/domain_conf.c | 13 - src/qemu/qemu_domain.c | 10 ++ src/xen/xen_driver.c | 9 + 3 files changed, 19 insertions(+), 13 deletions(-) ACK

Re: [libvirt] [PATCH v3 6/8] domain_conf: Add disk bus=sd, wire it up for qemu

2013-09-02 Thread Daniel P. Berrange
On Fri, Aug 30, 2013 at 12:41:34PM -0400, Cole Robinson wrote: This corresponds to '-sd' and '-drive if=sd' on the qemu command line. Needed for many ARM boards which don't provide any other way to pass in storage. --- docs/formatdomain.html.in | 3 ++- docs/schemas/domaincommon.rng |

Re: [libvirt] [PATCH v3 5/8] qemu: Don't try to allocate PCI addresses for ARM

2013-09-02 Thread Daniel P. Berrange
On Fri, Aug 30, 2013 at 12:41:33PM -0400, Cole Robinson wrote: --- src/qemu/qemu_command.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) ACK Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org

Re: [libvirt] [PATCH v3 7/8] qemu: Fix networking for ARM guests

2013-09-02 Thread Daniel P. Berrange
On Fri, Aug 30, 2013 at 12:41:35PM -0400, Cole Robinson wrote: Similar to the chardev bit, ARM boards depend on the old style '-net nic' for actually instantiating net devices. But we can't block out -netdev altogether since it's needed for upcoming virtio support. And add tests for working

Re: [libvirt] [PATCH v3 8/8] qemu: Support virtio-mmio transport for virtio on ARM

2013-09-02 Thread Daniel P. Berrange
On Fri, Aug 30, 2013 at 12:41:36PM -0400, Cole Robinson wrote: Starting with qemu 1.6, the qemu-system-arm vexpress-a9 model has a hardcoded virtio-mmio transport which enables attaching all virtio devices. On the command line, we have to use virtio-XXX-device rather than virtio-XXX-pci,

Re: [libvirt] [PATCH 3/5] qemu: add usb-bot support from disks points of view

2013-09-02 Thread Daniel P. Berrange
On Mon, Sep 02, 2013 at 05:38:42PM +0800, Guannan Ren wrote: usb-bot only supports 16 luns(0~15) and they must be contiguous, (using lun 0 and 2 without 1 doesn't work). In this case qemu doesn't throw an error, we can not find the lun 2 in guests. So Adding a checking function in libvirt to

Re: [libvirt] [PATCHv2 0/2] Support setting the 'removable' flag for USB disks

2013-09-02 Thread Peter Krempa
On 08/28/13 15:41, Peter Krempa wrote: On 08/28/13 15:34, anonym wrote: 27/08/13 14:40, Peter Krempa wrote: On 08/23/13 12:38, Fred A. Kemp wrote: From: Fred A. Kemp ano...@riseup.net ... I'm very time constrained at the moment so I didn't have time to read the sources in detail, so the

[libvirt] [PATCH] qemu: Handle huge number of queues correctly

2013-09-02 Thread Michal Privoznik
Currently, kernel supports up to 8 queues for a multiqueue tap device. However, if user tries to enter a huge number (e.g. one million) the tap allocation fails, as expected. But what is not expected is the log full of warnings: warning : virFileClose:83 : Tried to close invalid fd 0 The

[libvirt] [PATCH] examples: Add script to parse topology from capabilities output

2013-09-02 Thread Peter Krempa
Add a demo script originally written by Amador Pahim to parse topology of the host from data provided in the capabilities XML. --- examples/python/topology.py | 45 + 1 file changed, 45 insertions(+) create mode 100755 examples/python/topology.py diff

[libvirt] [PATCH] Add forwarders attribute to dns / element.

2013-09-02 Thread Diego Woitasen
Useful to set custom forwarders instead of using the contents of /etc/resolv.conf. It helps me to setup dnsmasq as local nameserver to resolv VM domain names from domain 0, when domain option is used. Signed-off-by: Diego Woitasen diego.woita...@vhgroup.net --- docs/formatnetwork.html.in

Re: [libvirt] [PATCH 2/3] virsh: Remember terminal state when starting and add helpers

2013-09-02 Thread Michal Privoznik
On 29.08.2013 17:52, Peter Krempa wrote: This patch adds instrumentation to allow modification of config of the terminal in virsh and successful reset of the state afterwards. The added helpers allow to disable receiving of SIGINT when pressing the key sequence (Ctrl+C usualy). This normally

[libvirt] [PATCHv2 RESEND 2/5] virstring.h/c: Util method for making some find and replace in strings

2013-09-02 Thread Manuel VIVES
--- src/libvirt_private.syms |1 + src/util/virstring.c | 48 ++ src/util/virstring.h |2 ++ 3 files changed, 51 insertions(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index a6af540..b5f83c3 100644 ---

[libvirt] [PATCHv2 RESEND 4/5] vbox_tmpl.c: Patch for redefining snapshots

2013-09-02 Thread Manuel VIVES
The snapshots are saved in xml files, and then can be redefined --- src/vbox/vbox_tmpl.c | 848 +- 1 file changed, 840 insertions(+), 8 deletions(-) diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c index ded179f..2b07dec 100644 ---

[libvirt] [PATCHv2 RESEND 0/5] Handling of undefine and redefine snapshots with VirtualBox 4.2

2013-09-02 Thread Manuel VIVES
Hi, This is a serie of patches in order to support undefining and redefining snapshots with VirtualBox 4.2. The serie of patches is rather big, and adds among other things some utility functions unrelated to VirtualBox in patches 1 2. The code review could be done in several parts: e.g. patches

[libvirt] [PATCHv2 RESEND 3/5] vbox_tmpl.c: Better XML description for snapshots

2013-09-02 Thread Manuel VIVES
It will be needed for the futur patches because we will redefine snapshots --- src/conf/domain_conf.c | 20 ++- src/vbox/vbox_tmpl.c | 427 ++-- 2 files changed, 427 insertions(+), 20 deletions(-) diff --git a/src/conf/domain_conf.c

[libvirt] [PATCHv2 RESEND 5/5] vbox_tmpl.c: Add methods for undefining snapshots

2013-09-02 Thread Manuel VIVES
All the informations concerning snapshots (and snapshot disks) will be deleted from the vbox xml. But the differencing disks will be kept so you will be able to redefine the snapshots. --- src/vbox/vbox_tmpl.c | 387 ++ 1 file changed, 387

[libvirt] [PATCHv2 RESEND 1/5] viruuid.h/c: Util method for finding uuid patterns in some strings

2013-09-02 Thread Manuel VIVES
--- src/libvirt_private.syms |1 + src/util/viruuid.c | 79 ++ src/util/viruuid.h |1 + 3 files changed, 81 insertions(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 35f0f1b..a6af540 100644 ---

Re: [libvirt] [PATCH v3 8/8] qemu: Support virtio-mmio transport for virtio on ARM

2013-09-02 Thread Cole Robinson
On 09/02/2013 08:52 AM, Daniel P. Berrange wrote: On Fri, Aug 30, 2013 at 12:41:36PM -0400, Cole Robinson wrote: Starting with qemu 1.6, the qemu-system-arm vexpress-a9 model has a hardcoded virtio-mmio transport which enables attaching all virtio devices. On the command line, we have to use

[libvirt] How to add uplink in esx virtual switch using libvirt

2013-09-02 Thread varun bhatnagar
Hi, I have an ESXi server, on top of it I have created one VM whose IP address is 192.168.79.1. I want to connect to the VM on ESXi server from my host machine but I am not able to do it. I have created a network networkforSC and I have pasted my xml file content below but I am not able to add

Re: [libvirt] [PATCH 1/2] Fix AM_LDFLAGS typo

2013-09-02 Thread Guido Günther
On Mon, Sep 02, 2013 at 12:37:45PM +0100, Daniel P. Berrange wrote: On Sun, Sep 01, 2013 at 11:30:46AM +0200, Guido Günther wrote: --- This should probably go into 1.1.2 src/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Makefile.am

Re: [libvirt] [PATCH v3 0/8] Support qemu-system-arm vexpress-a9

2013-09-02 Thread Cole Robinson
On 08/30/2013 12:41 PM, Cole Robinson wrote: This series adds the bits needed to kick of a qemu-system-arm -machine vexpress-a9 guest. vexpress-a15 likely works as well but is untested. Patches 1-2 are related bugfixes/improvements. Patch 6 adds disk bus=sd, which is often the only way to

[libvirt] [PATCH] Drop ChangeLog generation

2013-09-02 Thread Cole Robinson
Fedora is perpetually low on space for its live cd, and a bug was filed asking libvirt to drop the rather large ChangeLog from the RPM: https://bugzilla.redhat.com/show_bug.cgi?id=977099 Really though, what's the point of a static ChangeLog these days? git has won, and is far more useful for

Re: [libvirt] [PATCHv3 4/4] VMX: Some serial ports are not actually connected

2013-09-02 Thread Doug Goldstein
On Thu, Aug 29, 2013 at 5:19 AM, Michal Privoznik mpriv...@redhat.comwrote: On 28.08.2013 23:53, Doug Goldstein wrote: Sometimes a serial port might not be actually wired to a device when the user does not have the VM powered on and we should not consider this a fatal error. ---

Re: [libvirt] [PATCH]LXC doc: Add warns if net namespace not enabled

2013-09-02 Thread Chen Hanxiao
Hi Any comments? Thanks -Original Message- From: Chen Hanxiao [mailto:chenhanx...@cn.fujitsu.com] Sent: Friday, August 23, 2013 1:18 PM To: libvir-list@redhat.com Cc: chenhanx...@cn.fujitsu.com Subject: [libvirt][PATCH]LXC doc: Add warns if net namespace not enabled

Re: [libvirt] [Qemu-devel] [PATCH 3/5] qemu: add usb-bot support from disks points of view

2013-09-02 Thread Guannan Ren
On 09/02/2013 08:57 PM, Daniel P. Berrange wrote: On Mon, Sep 02, 2013 at 05:38:42PM +0800, Guannan Ren wrote: usb-bot only supports 16 luns(0~15) and they must be contiguous, (using lun 0 and 2 without 1 doesn't work). In this case qemu doesn't throw an error, we can not find the lun 2 in

[libvirt] [PATCH] Docs: fix a typo in virt-login-shell.pod

2013-09-02 Thread Alex Jia
Signed-off-by: Alex Jia a...@redhat.com --- tools/virt-login-shell.pod |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/virt-login-shell.pod b/tools/virt-login-shell.pod index e27d500..bcd7855 100644 --- a/tools/virt-login-shell.pod +++ b/tools/virt-login-shell.pod

Re: [libvirt] Libvirt multi queue support

2013-09-02 Thread Naor Shlomo
Hi Michal First of all I want to let you know that I really appreciate your guidance. Second thing, after I successfully installed the kernel headers I was able to compile libvirt again, this time it let me start the Guest with queues='5' The Guest runs Kernel 3.9.7 but for some reason