Re: [libvirt] [PATCH] build: shut up automake warnings

2013-09-05 Thread Martin Kletzander
On Wed 04 Sep 2013 06:48:46 PM CEST, Eric Blake wrote: I'm tired of seeing screenfuls of messages like these when using automake 1.13 (Fedora 19): configure.ac:2121: warning: The 'AM_PROG_MKDIR_P' macro is deprecated, and its use is discouraged. configure.ac:2121: You should use the

Re: [libvirt] [PATCH] [RFC] docs: Add OpenStack into references

2013-09-05 Thread Martin Kletzander
On 09/04/2013 03:56 PM, Osier Yang wrote: On 04/09/13 20:50, Eric Blake wrote: On 09/04/2013 01:26 AM, Martin Kletzander wrote: diff --git a/docs/apps.html.in b/docs/apps.html.in index 46e5dca..9f22df8 100644 --- a/docs/apps.html.in +++ b/docs/apps.html.in @@ -244,6 +244,15 @@

Re: [libvirt] [PATCH] libxl: Unconditionally call virSysinfoRead() on driver init

2013-09-05 Thread Jim Fehlig
Eric Blake wrote: On 09/04/2013 05:07 PM, Jim Fehlig wrote: No need to check if priviledged when reading hostsysinfo, since that check was already done in libxlDriverShouldLoad(). The libxl driver fails to load if not priviledged. s/priviledged/privileged/ (twice)

Re: [libvirt] [PATCH] libxl: Check for regcomp failure

2013-09-05 Thread Michal Privoznik
On 04.09.2013 22:18, Eric Blake wrote: On 09/04/2013 02:03 PM, Jim Fehlig wrote: Yeah, good question. I found a few occurrences of regcomp() and friends throughout the sources and most seem to do regfree() even when regcomp() fails. The man page is not very clear, but the notes on regfree()

Re: [libvirt] [PATCH 6/n] spec: make client-only testing easier

2013-09-05 Thread Michal Privoznik
On 04.09.2013 23:08, Eric Blake wrote: Several recent patches cleaned up 'make rpm' for the situation when client_only is true; these were done by manual spec file editing (since it's relatively hard to come by a RHEL 5 s390 box). Make it easier to do in the future via a simpler command line

Re: [libvirt] [PATCH] conf: Don't deref NULL actual network in virDomainNetGetActualHostdev()

2013-09-05 Thread Peter Krempa
On 09/04/13 17:45, Eric Blake wrote: On 09/04/2013 09:37 AM, Peter Krempa wrote: In commit 991270db99690 I've used virDomainNetGetActualHostdev() to get the actual hostdev from a network when removing the network from the list to avoid leaving the hostdev in the list. I didn't notice that this

Re: [libvirt] [PATCH] [RFC] docs: Add OpenStack into references

2013-09-05 Thread Osier Yang
On 05/09/13 14:20, Martin Kletzander wrote: On 09/04/2013 03:56 PM, Osier Yang wrote: On 04/09/13 20:50, Eric Blake wrote: On 09/04/2013 01:26 AM, Martin Kletzander wrote: diff --git a/docs/apps.html.in b/docs/apps.html.in index 46e5dca..9f22df8 100644 --- a/docs/apps.html.in +++

Re: [libvirt] [PATCH v2 0/3] Improve PPC CPU driver

2013-09-05 Thread Li Zhang
ping ? On 2013年09月03日 14:28, Li Zhang wrote: From: Li Zhang zhlci...@linux.vnet.ibm.com Currently, PPC CPU driver doesn't support to parse guest data. It can't pass CPU parameters to Qemu command line. This patchset is to implement .guestData to support to parse guest CPU configuration and

Re: [libvirt] [PATCH 2/2] libxl: Compile regular expression where it is used

2013-09-05 Thread Michal Privoznik
On 05.09.2013 00:40, Jim Fehlig wrote: Jim Fehlig wrote: The regular expression used to determine guest capabilities was compiled in libxlCapsInitHost() but used in libxlCapsInitGuests(). Move compilation to libxlCapsInitGuests() where it is used, and free the compiled regex after use.

[libvirt] [PATCH] Add 'nat' element to 'forward' network schemas

2013-09-05 Thread Ján Tomko
Commits 905629f4 and 1716e7a6 have added support for specifying an IPv4 range and a port range to be used by NAT: forward mode='nat' nat address start='10.20.30.40' end='10.20.30.44'/ port start='6' end='65432'/ /nat /forward https://bugzilla.redhat.com/show_bug.cgi?id=1004364 ---

Re: [libvirt] [PATCH 0/3] Keep original file label

2013-09-05 Thread Michal Privoznik
On 28.08.2013 12:27, Michal Privoznik wrote: This is just a resurrection of my previous patchset. As of atomicity problem, I just realized there is none. The qemuProcessHook (which is responsible for locking the files) is called prior virSecurityManagerSetAllLabel (responsible for

Re: [libvirt] [PATCH] [RFC] docs: Add OpenStack into references

2013-09-05 Thread Daniel P. Berrange
On Thu, Sep 05, 2013 at 08:20:41AM +0200, Martin Kletzander wrote: On 09/04/2013 03:56 PM, Osier Yang wrote: On 04/09/13 20:50, Eric Blake wrote: On 09/04/2013 01:26 AM, Martin Kletzander wrote: diff --git a/docs/apps.html.in b/docs/apps.html.in index 46e5dca..9f22df8 100644 ---

Re: [libvirt] [PATCH] LXC: Don't mount securityfs when user namespace enabled

2013-09-05 Thread Daniel P. Berrange
On Wed, Sep 04, 2013 at 10:23:17AM +0800, Gao feng wrote: Right now, securityfs is disallowed to be mounted in un init user namespace, we should avoid to mount securityfs in the container which enables user namespace. Signed-off-by: Gao feng gaof...@cn.fujitsu.com ---

Re: [libvirt] [PATCH] domain_conf: Delete the USB controller check from the USB Device checklist on virDomainDeviceIsUSB

2013-09-05 Thread Michal Privoznik
On 05.09.2013 04:40, Liuji (Jeremy) wrote: When using virsh attach-device to attach a device, the virDomainDefCompatibleDevice function will check the compatibility. If the device is a USB device, but the VM don't have any USB controller, the execution of virsh attach-device will fails. It

Re: [libvirt] [PATCH] systemd: add debug message when virDBusCallMethod failed

2013-09-05 Thread Daniel P. Berrange
On Wed, Sep 04, 2013 at 10:58:23AM +0800, Gao feng wrote: Generate debug message when systemd doesn't support interface org.freedesktop.machine1.Manager. Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- src/util/virsystemd.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [libvirt] [PATCH v2 1/3] qemu: Remove CPU features functions calling for non-x86 platform.

2013-09-05 Thread Daniel P. Berrange
On Tue, Sep 03, 2013 at 02:28:23PM +0800, Li Zhang wrote: From: Li Zhang zhlci...@linux.vnet.ibm.com CPU features are not supported on non-x86 and hasFeatures will be NULL. This patch is to remove CPU features functions calling to avoid errors. Signed-off-by: Li Zhang

Re: [libvirt] [PATCH v2 2/3] cpu: Implement guestData and update for PPC

2013-09-05 Thread Daniel P. Berrange
On Tue, Sep 03, 2013 at 02:28:24PM +0800, Li Zhang wrote: From: Li Zhang zhlci...@linux.vnet.ibm.com On Power platform, Power7+ can support Power7 guest. It needs to define XML configuration to specify guest's CPU model. For exmaple: cpu match='exact' modelPOWER7_v2.1/model

Re: [libvirt] [PATCH v2 3/3] cpu: Add cpu test cases for PPC CPU driver.

2013-09-05 Thread Daniel P. Berrange
On Tue, Sep 03, 2013 at 02:28:25PM +0800, Li Zhang wrote: From: Li Zhang zhlci...@linux.vnet.ibm.com This patch is to add cpu test casses for PPC CPU driver. Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com --- tests/cputest.c | 9 +

Re: [libvirt] [PATCH V3] Use loop-control to allocate loop device.

2013-09-05 Thread Daniel P. Berrange
On Tue, Sep 03, 2013 at 11:45:51AM -0700, Ian Main wrote: This patch changes virFileLoopDeviceOpen() to use the new loop-control device to allocate a new loop device. If this behavior is unsupported we fall back to the previous method of searching /dev for a free device. With this patch you

Re: [libvirt] [PATCH] Add 'nat' element to 'forward' network schemas

2013-09-05 Thread Michal Privoznik
On 05.09.2013 11:24, Ján Tomko wrote: Commits 905629f4 and 1716e7a6 have added support for specifying an IPv4 range and a port range to be used by NAT: forward mode='nat' nat address start='10.20.30.40' end='10.20.30.44'/ port start='6' end='65432'/ /nat /forward

[libvirt] [PATCH v2 0/3] expose baselabel for each sec model/virt type

2013-09-05 Thread Giuseppe Scrivano
Now each security model can define its own base label, that describes the default security context used by libvirt to run an hypervisor process. This information is exposed to users trough the host capabilities XML. Giuseppe Scrivano (3): security: add new internal function

[libvirt] [PATCH v2 1/3] security: add new internal function virSecurityManagerGetBaseLabel

2013-09-05 Thread Giuseppe Scrivano
virSecurityManagerGetBaseLabel queries the default settings used by a security model. Signed-off-by: Giuseppe Scrivano gscri...@redhat.com --- src/libvirt_private.syms | 1 + src/security/security_apparmor.c | 7 +++ src/security/security_dac.c | 26 +-

[libvirt] [PATCH v2 3/3] capabilities: document and test baselabel

2013-09-05 Thread Giuseppe Scrivano
Signed-off-by: Giuseppe Scrivano gscri...@redhat.com --- docs/schemas/capability.rng | 8 tests/capabilityschemadata/caps-qemu-kvm.xml | 2 ++ tests/capabilityschemadata/caps-test3.xml| 2 ++ 3 files changed, 12 insertions(+) diff --git a/docs/schemas/capability.rng

[libvirt] [PATCH v2 2/3] capabilities: add baselabel per sec driver/virt type to secmodel

2013-09-05 Thread Giuseppe Scrivano
Expand the secmodel XML fragment of host with a sequence of baselabel's which describe the default security context used by libvirt with a specific security model and virtualization type: secmodel modelselinux/model doi0/doi baselabel type='kvm'system_u:system_r:svirt_t:s0/baselabel

[libvirt] [ libvirt ] [ PATCH ] Added support for ARMv7 Big Endian

2013-09-05 Thread yogesh tillu
Hi All, Could you please review below patch, I have successfully tested patch on ARM Versatile Express V2P Board. From: Yogesh Tillu tillu.yog...@gmail.com Date: Thu, 5 Sep 2013 17:07:55 +0530 Subject: [PATCH] [ PATCH ] Added Support for ARMv7 Big Endian Signed-off-by: Yogesh Tillu

[libvirt] [PATCH] Change 'shortforward' to bool.

2013-09-05 Thread Ján Tomko
--- Pushed as trivial. src/conf/network_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index d54f2aa..654919e 100644 --- a/src/conf/network_conf.c +++ b/src/conf/network_conf.c @@ -2552,7 +2552,7 @@

[libvirt] [PATCH] Fix a typo in network XML docs

2013-09-05 Thread Ján Tomko
--- Pushed as trivial. docs/formatnetwork.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatnetwork.html.in b/docs/formatnetwork.html.in index e1482db..36c381a 100644 --- a/docs/formatnetwork.html.in +++ b/docs/formatnetwork.html.in @@ -155,7 +155,7 @@

Re: [libvirt] [PATCH] Add 'nat' element to 'forward' network schemas

2013-09-05 Thread Ján Tomko
On 09/05/2013 01:43 PM, Michal Privoznik wrote: On 05.09.2013 11:24, Ján Tomko wrote: Commits 905629f4 and 1716e7a6 have added support for specifying an IPv4 range and a port range to be used by NAT: forward mode='nat' nat address start='10.20.30.40' end='10.20.30.44'/ port

Re: [libvirt] [PATCHv5 1/5] domifaddr: Implement the public APIs

2013-09-05 Thread Nehal J Wani
On Wed, Sep 4, 2013 at 8:05 PM, Osier Yang jy...@redhat.com wrote: On 04/09/13 03:13, Eric Blake wrote: On 09/03/2013 01:07 PM, Eric Blake wrote: On 09/01/2013 07:43 AM, Nehal J Wani wrote: Define a new API virDomainInterfaceAddresses, which returns the address information of a running

Re: [libvirt] [PATCH] systemd: add debug message when virDBusCallMethod failed

2013-09-05 Thread Peter Krempa
On 09/05/13 13:03, Daniel P. Berrange wrote: On Wed, Sep 04, 2013 at 10:58:23AM +0800, Gao feng wrote: Generate debug message when systemd doesn't support interface org.freedesktop.machine1.Manager. Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- src/util/virsystemd.c | 1 + 1 file

Re: [libvirt] [PATCHv5 1/5] domifaddr: Implement the public APIs

2013-09-05 Thread Daniel P. Berrange
On Tue, Sep 03, 2013 at 01:13:20PM -0600, Eric Blake wrote: On 09/03/2013 01:07 PM, Eric Blake wrote: On 09/01/2013 07:43 AM, Nehal J Wani wrote: Define a new API virDomainInterfaceAddresses, which returns the address information of a running domain's interfaces(s). If no interface name

Re: [libvirt] [PATCHv5 1/5] domifaddr: Implement the public APIs

2013-09-05 Thread Daniel P. Berrange
On Wed, Sep 04, 2013 at 10:35:34PM +0800, Osier Yang wrote: On 04/09/13 03:13, Eric Blake wrote: On 09/03/2013 01:07 PM, Eric Blake wrote: On 09/01/2013 07:43 AM, Nehal J Wani wrote: Define a new API virDomainInterfaceAddresses, which returns the address information of a running domain's

Re: [libvirt] [PATCH] systemd: add debug message when virDBusCallMethod failed

2013-09-05 Thread Daniel P. Berrange
On Thu, Sep 05, 2013 at 02:21:53PM +0200, Peter Krempa wrote: On 09/05/13 13:03, Daniel P. Berrange wrote: On Wed, Sep 04, 2013 at 10:58:23AM +0800, Gao feng wrote: Generate debug message when systemd doesn't support interface org.freedesktop.machine1.Manager. Signed-off-by: Gao feng

Re: [libvirt] [PATCH] libxl: Check for regcomp failure

2013-09-05 Thread Eric Blake
On 09/05/2013 01:49 AM, Michal Privoznik wrote: In glibc, regcomp assigns into preg, but is careful to undo any allocation on failure; it is also careful to make regfree() a no-op on an already-freed buffer (whether by calling regfree() twice in a row, or using it on preg after a failed

Re: [libvirt] [PATCH] build: shut up automake warnings

2013-09-05 Thread Eric Blake
On 09/05/2013 12:08 AM, Martin Kletzander wrote: On Wed 04 Sep 2013 06:48:46 PM CEST, Eric Blake wrote: I'm tired of seeing screenfuls of messages like these when using automake 1.13 (Fedora 19): configure.ac:2121: warning: The 'AM_PROG_MKDIR_P' macro is deprecated, and its use is

Re: [libvirt] [PATCH 6/n] spec: make client-only testing easier

2013-09-05 Thread Eric Blake
On 09/05/2013 01:51 AM, Michal Privoznik wrote: On 04.09.2013 23:08, Eric Blake wrote: Several recent patches cleaned up 'make rpm' for the situation when client_only is true; these were done by manual spec file editing (since it's relatively hard to come by a RHEL 5 s390 box). Make it

Re: [libvirt] [PATCH] storage: new backend: btrfs subvolumes

2013-09-05 Thread Daniel P. Berrange
On Mon, Sep 02, 2013 at 02:48:12PM +0300, Oskari Saarenmaa wrote: This commit adds a new storage pool driver, btrfs, which can be used to manage btrfs subvolumes on an existing btrfs filesystem. The driver can create new blank subvolumes and snapshots of existing subvolumes as well as delete

[libvirt] [PATCH] Add support for enabling SASL for SPICE guests

2013-09-05 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com QEMU has support for SASL auth for SPICE guests, but libvirt has no way to enable it. Following the example from VNC where it is globally enabled via qemu.conf Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/qemu/libvirtd_qemu.aug

Re: [libvirt] [PATCH 3/3] security_dac: Favour ACLs over chown()

2013-09-05 Thread Daniel P. Berrange
On Wed, Aug 28, 2013 at 12:27:40PM +0200, Michal Privoznik wrote: On filesystems supporting ACLs we don't need to do a chown but we can just set ACLs to gain access for qemu. However, since we are setting these on too low level, where we don't know if disk is just a read only or read write, we

Re: [libvirt] [PATCH] domain_conf: Delete the USB controller check from the USB Device checklist on virDomainDeviceIsUSB

2013-09-05 Thread Eric Blake
On 09/04/2013 08:40 PM, Liuji (Jeremy) wrote: When using virsh attach-device to attach a device, the virDomainDefCompatibleDevice function will check the compatibility. If the device is a USB device, but the VM don't have any USB controller, the execution of virsh attach-device will fails.

Re: [libvirt] [PATCH 2/2] libxl: Compile regular expression where it is used

2013-09-05 Thread Jim Fehlig
Michal Privoznik wrote: On 05.09.2013 00:40, Jim Fehlig wrote: Jim Fehlig wrote: The regular expression used to determine guest capabilities was compiled in libxlCapsInitHost() but used in libxlCapsInitGuests(). Move compilation to libxlCapsInitGuests() where it is used, and free

Re: [libvirt] virsh domstate output when kvm killed vs guest OS panic

2013-09-05 Thread Eric Blake
On 09/05/2013 12:47 PM, Chris Friesen wrote: Hi, If I kill a libvirt-managed kvm process with kill -9, running virsh domstate --reason name gives shut off (crashed) Looking at the code, that corresponds to VIR_DOMAIN_SHUTOFF/VIR_DOMAIN_SHUTOFF_CRASHED. The comment says that

[libvirt] virsh domstate output when kvm killed vs guest OS panic

2013-09-05 Thread Chris Friesen
Hi, If I kill a libvirt-managed kvm process with kill -9, running virsh domstate --reason name gives shut off (crashed) Looking at the code, that corresponds to VIR_DOMAIN_SHUTOFF/VIR_DOMAIN_SHUTOFF_CRASHED. The comment says that VIR_DOMAIN_SHUTOFF_CRASHED corresponds to domain crashed.

[libvirt] [PATCH 1/2] build: avoid obsolete AC_HELP_STRING

2013-09-05 Thread Eric Blake
Autoconf states that AC_HELP_STRING is obsolete, and that new programs should use AS_HELP_STRING. We also had instances of not properly quoting the macro usage, and not relying on autoconf's word-wrapping abilities to avoid long lines. I validated that this commit has no impact to the generated

[libvirt] [PATCH 2/2] build: fix regression in requiring yajl for new enough qemu

2013-09-05 Thread Eric Blake
Jonathan Leban reported an issue to me off-list about his build failing to use qemu because he failed to install yajl-devel. But I recalled specifically tweaking configure.ac to die in that situation (commits 350583c, ba9c38b). After a bit more head-scratching, we found the cause of the

[libvirt] [PATCH 0/2] fix configure to require yajl if qemu is new enough

2013-09-05 Thread Eric Blake
After yet another debug session on IRC about failure to use qemu because yajl-devel wasn't installed, I came up with these patches. The first is just preparation (no change to generated code); and with the second, I validated that uninstalling yajl-devel and then trying to configure once again

Re: [libvirt] [PATCH] domain_conf: Delete the USB controller check from the USB Device checklist on virDomainDeviceIsUSB

2013-09-05 Thread Liuji (Jeremy)
Sorry, I did not notice this discrepancy. I prefer the Liuji (Jeremy) form. Next time, I will change the name of S-o-B from Liu Ji to Liuji (Jeremy). Thanks. -Original Message- From: Eric Blake [mailto:ebl...@redhat.com] Sent: Thursday, September 05, 2013 10:08 PM To: Liuji (Jeremy)

Re: [libvirt] [PATCH] Docs: fix a typo in virt-login-shell.pod

2013-09-05 Thread Alex Jia
Thanks and pushed now. -- Regards, Alex - Original Message - From: Peter Krempa pkre...@redhat.com To: Alex Jia a...@redhat.com Cc: libvir-list@redhat.com Sent: Tuesday, September 3, 2013 3:35:43 PM Subject: Re: [libvirt] [PATCH] Docs: fix a typo in virt-login-shell.pod On

[libvirt] [PATCH] LXC:fix typo in lxc_container.c

2013-09-05 Thread Chen Hanxiao
From: Chen Hanxiao chenhanx...@cn.fujitsu.com fix typo in lxc_container.c Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com --- src/lxc/lxc_container.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index

[libvirt] [PATCH] qemu: Remove unnecessary variable assignment

2013-09-05 Thread Hongwei Bi
Remove unnecessary 'addrs = NULL' in qemuDomainAssignS390Addresses() and qemuDomainAssignPCIAddresses() due to the related Free function in label cleanup. --- src/qemu/qemu_command.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_command.c