[libvirt] [PATCH] LXC: Free variable vroot in lxcDomainDetachDeviceHostdevUSBLive()

2013-09-08 Thread Hongwei Bi
The variable vroot should be freed in label cleanup. --- src/lxc/lxc_driver.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index 9cb95ff..b587c22 100644 --- a/src/lxc/lxc_driver.c +++ b/src/lxc/lxc_driver.c @@ -3766,7 +3766,

[libvirt] [PATCH 1/1] cpu: Cleanup ppcCompute to avoid memory leak

2013-09-08 Thread Li Zhang
From: Li Zhang This patch is to Cleanup ppcCompute to avoid memory leak to make the code better. Signed-off-by: Li Zhang --- src/cpu/cpu_powerpc.c | 36 +++- 1 file changed, 19 insertions(+), 17 deletions(-) diff --git a/src/cpu/cpu_powerpc.c b/src/cpu/cpu_powe

Re: [libvirt] [PATCH] virBitmapFree: Change the function to a macro

2013-09-08 Thread Liuji (Jeremy)
> -Original Message- > From: Osier Yang [mailto:jy...@redhat.com] > Sent: Monday, September 09, 2013 10:46 AM > To: Liuji (Jeremy) > Cc: libvir-list@redhat.com; Jinbo (Justin); Luohao (brian); Haofeng > Subject: Re: [libvirt] [PATCH] virBitmapFree: Change the function to a macro > > On 06/

Re: [libvirt] [PATCH v2 2/3] cpu: Implement guestData and update for PPC

2013-09-08 Thread Li Zhang
On 2013年09月06日 19:32, John Ferlan wrote: On 09/03/2013 02:28 AM, Li Zhang wrote: From: Li Zhang On Power platform, Power7+ can support Power7 guest. It needs to define XML configuration to specify guest's CPU model. For exmaple: POWER7_v2.1 IBM Signed-off-by: Li Zhang ---

Re: [libvirt] [PATCH] virBitmapFree: Change the function to a macro

2013-09-08 Thread Osier Yang
On 06/09/13 18:30, Liuji (Jeremy) wrote: The parameter of virBitmapFree function is just a pointer, not a pointer of pointer. The second VIR_FREE on virBitmapFree only assign NULL to the formal parameter. After calling the virBitmapFree function, the actual parameter are still not NULL. There a

Re: [libvirt] [PATCH] virsh: move command maxvcpus from domain group to host group.

2013-09-08 Thread Osier Yang
On 09/09/13 10:14, yangdongsheng wrote: Since the maxvcpus command query the maximum number of virtual CPUs supported for a guest VM on this connection, it should be in virsh-host.c but not virsh-domain.c. Signed-off-by: yangdongsheng --- tools/virsh-domain.c | 44 ---

[libvirt] [PATCH] virsh: move command maxvcpus from domain group to host group.

2013-09-08 Thread yangdongsheng
Since the maxvcpus command query the maximum number of virtual CPUs supported for a guest VM on this connection, it should be in virsh-host.c but not virsh-domain.c. Signed-off-by: yangdongsheng --- tools/virsh-domain.c | 44 tools/virsh-host.c |

Re: [libvirt] [PATCH] virBitmapFree: Change the function to a macro

2013-09-08 Thread Liuji (Jeremy)
> -Original Message- > From: Daniel P. Berrange [mailto:berra...@redhat.com] > Sent: Friday, September 06, 2013 6:37 PM > To: Liuji (Jeremy) > Cc: libvir-list@redhat.com; Jinbo (Justin); Luohao (brian); Haofeng > Subject: Re: [libvirt] [PATCH] virBitmapFree: Change the function to a macro >

Re: [libvirt] [PATCH v3 0/8] Support qemu-system-arm vexpress-a9

2013-09-08 Thread Richard W.M. Jones
On Sun, Sep 08, 2013 at 10:15:05PM +0100, Richard W.M. Jones wrote: > On Fri, Aug 30, 2013 at 12:41:28PM -0400, Cole Robinson wrote: > > This series adds the bits needed to kick of a qemu-system-arm -machine > > vexpress-a9 guest. vexpress-a15 likely works as well but is untested. > > > > Patches

Re: [libvirt] [PATCH v3 0/8] Support qemu-system-arm vexpress-a9

2013-09-08 Thread Richard W.M. Jones
On Fri, Aug 30, 2013 at 12:41:28PM -0400, Cole Robinson wrote: > This series adds the bits needed to kick of a qemu-system-arm -machine > vexpress-a9 guest. vexpress-a15 likely works as well but is untested. > > Patches 1-2 are related bugfixes/improvements. Did patch 1/8 get eaten somewhere? I

Re: [libvirt] [PATCHv2] qemu: don't leak vm on failure

2013-09-08 Thread Osier Yang
On 07/09/13 01:55, Eric Blake wrote: Failure to attach to a domain during 'virsh qemu-attach' left the list of domains in an odd state: $ virsh qemu-attach 4176 error: An error occurred, but the cause is unknown $ virsh list --all IdName State ---

Re: [libvirt] [PATCH] Add support for enabling SASL for SPICE guests

2013-09-08 Thread Osier Yang
On 05/09/13 23:54, Daniel P. Berrange wrote: From: "Daniel P. Berrange" QEMU has support for SASL auth for SPICE guests, but libvirt has no way to enable it. Following the example from VNC where it is globally enabled via qemu.conf ACK -- libvir-list mailing list libvir-list@redhat.com htt

Re: [libvirt] [PATCHv6 1/5] domifaddr: Implement the public APIs

2013-09-08 Thread Osier Yang
[..] + * + * If 0 is passed as @flags, libvirt will choose the best way, and won't + * include agent in it. I'm thinking if we don't need to be so complicated, by defaulting to one of _LEASE or _SNOOP explicitly. That says (conclusion of all of above), I'm wondering if define the enu