The variable vroot should be freed in label cleanup.
---
src/lxc/lxc_driver.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c
index 9cb95ff..b587c22 100644
--- a/src/lxc/lxc_driver.c
+++ b/src/lxc/lxc_driver.c
@@ -3766,7
I tried this patchset and it works at least as far as being able to
get the libguestfs appliance up and running on ARM (with KVM) using
the libvirt backend. Virtio-scsi virtio-serial work.
Some issues however:
- Why is arch=armv7l? Why not just arm, or armv7hl?
- I had to force the
On 09/09/2013 08:05 AM, Hongwei Bi wrote:
The variable vroot should be freed in label cleanup.
---
src/lxc/lxc_driver.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
ACK, pushed.
Jan
--
libvir-list mailing list
libvir-list@redhat.com
ping...
-Original Message-
From: libvir-list-boun...@redhat.com
[mailto:libvir-list-boun...@redhat.com]
On Behalf Of Chen Hanxiao
Sent: Tuesday, September 03, 2013 10:04 AM
To: 'Daniel P. Berrange'
Cc: libvir-list@redhat.com
Subject: Re: [libvirt] [PATCH]LXC doc: Add warns if net
On Mon, Sep 09, 2013 at 09:09:56AM +0100, Richard W.M. Jones wrote:
I tried this patchset and it works at least as far as being able to
get the libguestfs appliance up and running on ARM (with KVM) using
the libvirt backend. Virtio-scsi virtio-serial work.
Some issues however:
- Why
On Thu, Sep 05, 2013 at 05:22:31PM +0530, yogesh tillu wrote:
Hi All,
Could you please review below patch, I have successfully tested patch on
ARM Versatile Express V2P Board.
From: Yogesh Tillu tillu.yog...@gmail.com
Date: Thu, 5 Sep 2013 17:07:55 +0530
Subject: [PATCH] [ PATCH ] Added
Sorry for inconvenience. I will send patch with git send-email next time.
Thanks,
Yogesh
On Mon, Sep 9, 2013 at 3:11 PM, Daniel P. Berrange berra...@redhat.comwrote:
On Thu, Sep 05, 2013 at 05:22:31PM +0530, yogesh tillu wrote:
Hi All,
Could you please review below patch, I have
[..]
Regardless of what the problem is..
Signed-off-by: Liuji (Jeremy) jeremy@huawei.com
---
src/util/virbitmap.c | 21 -
src/util/virbitmap.h | 21 -
2 files changed, 16 insertions(+), 26 deletions(-)
diff --git
On Mon, Sep 09, 2013 at 10:28:39AM +0100, Daniel P. Berrange wrote:
On Mon, Sep 09, 2013 at 09:09:56AM +0100, Richard W.M. Jones wrote:
I tried this patchset and it works at least as far as being able to
get the libguestfs appliance up and running on ARM (with KVM) using
the libvirt
On Mon, Sep 09, 2013 at 11:59:25AM +0100, Richard W.M. Jones wrote:
On Mon, Sep 09, 2013 at 10:28:39AM +0100, Daniel P. Berrange wrote:
On Mon, Sep 09, 2013 at 09:09:56AM +0100, Richard W.M. Jones wrote:
I tried this patchset and it works at least as far as being able to
get the
On 09/09/2013 05:57 AM, Liuji (Jeremy) wrote:
The virBitmapFree is:
void virBitmapFree(virBitmapPtr bitmap)
{
if (bitmap) {
VIR_FREE(bitmap-map);
VIR_FREE(bitmap);
}
}
Bitmap is a parameter (formal parameter).
On Mon, Sep 09, 2013 at 01:39:42AM +, Liuji (Jeremy) wrote:
-Original Message-
From: Daniel P. Berrange [mailto:berra...@redhat.com]
Sent: Friday, September 06, 2013 6:37 PM
To: Liuji (Jeremy)
Cc: libvir-list@redhat.com; Jinbo (Justin); Luohao (brian); Haofeng
Subject: Re:
On Mon, Sep 09, 2013 at 12:02:37PM +0100, Daniel P. Berrange wrote:
On Mon, Sep 09, 2013 at 11:59:25AM +0100, Richard W.M. Jones wrote:
- Hotplugging (adding a virtio-scsi disk) doesn't work on ARM:
could not attach disk to libvirt domain: internal error: SCSI controller 0
was missing
On 09/02/2013 06:05 PM, Manuel VIVES wrote:
---
src/libvirt_private.syms |1 +
src/util/viruuid.c | 79
++
src/util/viruuid.h |1 +
3 files changed, 81 insertions(+)
@@ -333,3 +337,78 @@ int virGetHostUUID(unsigned char
cc-ing libvir-list
On 09/09/2013 08:20 AM, Ján ONDREJ (SAL) wrote:
Hello,
in sanlock docs (https://fedorahosted.org/sanlock/) there is described,
how to use it. There is no mention about NFS. Can I use sanlock with LVM
(without NFS) with livbirt? It this feature implemented in libvirt for
On Mon, Sep 09, 2013 at 08:43:39AM -0400, Cole Robinson wrote:
cc-ing libvir-list
On 09/09/2013 08:20 AM, Ján ONDREJ (SAL) wrote:
Hello,
in sanlock docs (https://fedorahosted.org/sanlock/) there is described,
how to use it. There is no mention about NFS. Can I use sanlock with LVM
On 09/08/2013 08:29 AM, Osier Yang wrote:
On 07/09/13 01:55, Eric Blake wrote:
Failure to attach to a domain during 'virsh qemu-attach' left
the list of domains in an odd state:
$ virsh qemu-attach 4176
error: An error occurred, but the cause is unknown
* src/qemu/qemu_driver.c
From: Daniel P. Berrange berra...@redhat.com
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
libvirt-override.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/libvirt-override.c b/libvirt-override.c
index acd06a6..c2c1c18 100644
--- a/libvirt-override.c
+++
From: Daniel P. Berrange berra...@redhat.com
Remove use of all libvirt util header files. Reference generated
header files in build/ subdir.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
libvirt-lxc-override.c | 6 ++
libvirt-override.c | 9 ++---
From: Daniel P. Berrange berra...@redhat.com
The generated libvirt.py modules will be in the build/
directory, so santitytest.py must use that directory.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
sanitytest.py | 4
1 file changed, 4 insertions(+)
diff --git a/sanitytest.py
From: Daniel P. Berrange berra...@redhat.com
We are no longer using automake, so Makefile.am is obsolete
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
Makefile.am | 172
1 file changed, 172 deletions(-)
delete mode 100644
From: Daniel P. Berrange berra...@redhat.com
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
sanitytest.py | 0
1 file changed, 0 insertions(+), 0 deletions(-)
mode change 100644 = 100755 sanitytest.py
diff --git a/sanitytest.py b/sanitytest.py
old mode 100644
new mode 100755
--
From: Daniel P. Berrange berra...@redhat.com
This patch series demonstrates the minimum possible changes required
to split the python binding out into a separate GIT repository.
These patches do not apply to current GIT. Instead you have to first
create a new git repo, initializing based on the
From: Daniel P. Berrange berra...@redhat.com
We don't have access to the libvirt memory APIs to replace
VIR_FREE with free().
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
libvirt-lxc-override.c | 4 +-
libvirt-override.c | 228
Hello everyone,
I think there is a bug in the current implementation of function
libvirt_domain_change_vcpu().
When using this function (with second parameter = 2), I have the
following error :
Error setting maxvcpus=2: (domain_definition):8: Specification mandate
value for attribute curre
From: Daniel P. Berrange berra...@redhat.com
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
libvirt-override.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libvirt-override.c b/libvirt-override.c
index c2c1c18..0bf6512 100644
--- a/libvirt-override.c
+++
From: Daniel P. Berrange berra...@redhat.com
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
libvirt-override.c | 16
1 file changed, 16 insertions(+)
diff --git a/libvirt-override.c b/libvirt-override.c
index 246a15b..acd06a6 100644
--- a/libvirt-override.c
+++
From: Daniel P. Berrange berra...@redhat.com
The virDomainGetVcpuPinInfo python wrapper had a potential use of
uninitialized values
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
libvirt-override.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libvirt-override.c
From: Daniel P. Berrange berra...@redhat.com
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
libvirt-override.c | 106 ++---
1 file changed, 53 insertions(+), 53 deletions(-)
diff --git a/libvirt-override.c b/libvirt-override.c
index
On 09/09/2013 10:01 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
We're no longer using automake, so config.h files are not
required
Rather, it's the use of gnulib that required config.h. But I agree
that the bindings should be usable without having to rely on
From: Daniel P. Berrange berra...@redhat.com
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
libvirt-override.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libvirt-override.c b/libvirt-override.c
index a8cf71d..6df7db0 100644
--- a/libvirt-override.c
+++ b/libvirt-override.c
Automake 2.0 will enable subdir-objects by default; in preparation
for that change, automake 1.14 outputs LOADS of warnings:
daemon/Makefile.am:38: warning: source file '../src/remote/remote_protocol.c'
is in a subdirectory,
daemon/Makefile.am:38: but option 'subdir-objects' is disabled
We have been adding new .x files without keeping the list of
*-structs files up-to-date. This adds the support for the
recent additions.
In the process of testing this, I also noticed that Fedora 19's
use of dwarves-1.10 (providing pdwtags version 1.9) was producing
a single line on stderr but
If we use subdir-objects with automake, any reference to a
cross-directory .c file will result in automake creating
rules that track dependency in the cross directory. But this
presents a problem during 'make distclean' - if the cross
directory is cleaned up first, then the daemon directory will
Automake 1.14 is annoyingly loud about warning that the future
automake 2.0 will turn on subdir-objects by default. Since
automake 1.9 also supports subdir-objects, the best course of
action is to enable the feature. But we have to fix some
problems before doing so. Also, I noticed some issues
From: Daniel P. Berrange berra...@redhat.com
If the guest is configured with
filesystem type='mount'
source dir='/'/
target dir='/'/
readonly/
/filesystem
Then any submounts under / should also end up readonly. eg if
the user has /home on a separate volume, they'd
On 09/09/2013 10:01 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
We are no longer using automake, so Makefile.am is obsolete
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
Makefile.am | 172
On 09/09/2013 10:01 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The virDomainGetVcpuPinInfo python wrapper had a potential use of
uninitialized values
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
libvirt-override.c | 2 +-
1 file changed, 1
From: Daniel P. Berrange berra...@redhat.com
Change the generator.py to
- Take XML API file names on command line
- Generate data in build/ directory instead of cwd
---
generator.py | 69 ++--
1 file changed, 25 insertions(+), 44
On 09/09/2013 10:01 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
We don't have access to the libvirt memory APIs to replace
s/to replace/so replace/
VIR_FREE with free().
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
libvirt-lxc-override.c |
On Mon, Sep 09, 2013 at 11:06:46AM -0600, Eric Blake wrote:
On 09/09/2013 10:01 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
We are no longer using automake, so Makefile.am is obsolete
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
On 09/09/2013 10:01 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
This patch series demonstrates the minimum possible changes required
to split the python binding out into a separate GIT repository.
These patches do not apply to current GIT. Instead you have to
From: Daniel P. Berrange berra...@redhat.com
Remove ATTRIBUTE_NONNULL and ATTRIBUTE_UNUSED
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
libvirt-override.c | 281 ++---
1 file changed, 140 insertions(+), 141 deletions(-)
diff --git
On 09/05/2013 07:04 AM, Eric Blake wrote:
Unfortunately, 1.14 complains about subdir-objects way more than about
anything else and I still haven't found the way out of that one.
Ouch - rawhide is currently still stuck on 1.13.4 [so much for the
perception of rawhide being bleeding-edge];
From: Daniel P. Berrange berra...@redhat.com
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
libvirt-override.c | 4
1 file changed, 4 insertions(+)
diff --git a/libvirt-override.c b/libvirt-override.c
index 6df7db0..00d8e4d 100644
--- a/libvirt-override.c
+++
From: Daniel P. Berrange berra...@redhat.com
Replace VIR_FORCE_CLOSE with plain close()
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
libvirt-lxc-override.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libvirt-lxc-override.c b/libvirt-lxc-override.c
index
Trying to enable automake's subdir-objects option resulted in
the creation of literal directories such as src/$(srcdir)/remote/.
I traced this to the fact that we had used a literal $(srcdir)
in a location that later fed an automake *_SOURCES variable.
This has also been reported as an automake
From: Daniel P. Berrange berra...@redhat.com
We're no longer using automake, so config.h files are not
required
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
libvirt-lxc-override.c | 2 --
libvirt-override.c | 2 --
libvirt-qemu-override.c | 2 --
typewrappers.c | 2
On 09/09/13 19:24, Ján Tomko wrote:
On 09/09/2013 05:57 AM, Liuji (Jeremy) wrote:
The virBitmapFree is:
void virBitmapFree(virBitmapPtr bitmap)
{
if (bitmap) {
VIR_FREE(bitmap-map);
VIR_FREE(bitmap);
}
}
On 09/09/2013 09:30 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
If the guest is configured with
filesystem type='mount'
source dir='/'/
target dir='/'/
readonly/
/filesystem
Then any submounts under / should also end up
Hi Olivier,
this is not really a bug as it's intended. The
libvirt_domain_change_vcpus() is not the same as (yet unimplemented)
virDomainSetVcpus() API so it's not bug. I realize that naming could be
a little confusing so if you like, feel free to rename
libvirt_domain_change_vcpus() to
On 09/09/2013 10:01 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
sanitytest.py | 0
1 file changed, 0 insertions(+), 0 deletions(-)
mode change 100644 = 100755 sanitytest.py
I'd argue that this is a
On 09/09/2013 10:01 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
libvirt-override.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libvirt-override.c b/libvirt-override.c
index
Osier Yang pointed out that ever since commit 31cb030, the
signature of qemuDomainObjEndJob was changed to return a bool.
While comparison against 0 or 0 still gives the right results,
it looks fishy; we also had one place that was comparing 0
which is effectively dead code.
*
For some reason this does not build out of the box for me as I get
errors about 'setlocale()' being used without declaration. This patch
adds the appropriate header to the appropriate files.
Signed-off-by: Ian Main im...@redhat.com
---
bin/virt-sandbox-service-util.c | 1 +
On Mon, Sep 9, 2013 at 2:12 PM, Eric Blake ebl...@redhat.com wrote:
Osier Yang pointed out that ever since commit 31cb030, the
signature of qemuDomainObjEndJob was changed to return a bool.
While comparison against 0 or 0 still gives the right results,
it looks fishy; we also had one place
On Thu, Sep 05, 2013 at 12:33:44PM +0100, Daniel P. Berrange wrote:
On Tue, Sep 03, 2013 at 11:45:51AM -0700, Ian Main wrote:
This patch changes virFileLoopDeviceOpen() to use the new loop-control
device to allocate a new loop device. If this behavior is unsupported
we fall back to the
On 09/09/2013 10:01 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
libvirt-override.c | 106
++---
1 file changed, 53 insertions(+), 53 deletions(-)
Do
On 09/09/2013 10:01 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
libvirt-override.c | 2 ++
1 file changed, 2 insertions(+)
Again, if we had a common internal header, we could put this there,
instead
On 09/09/2013 06:51 PM, Michal Novotny wrote:
Hi Olivier,
this is not really a bug as it's intended. The
libvirt_domain_change_vcpus() is not the same as (yet unimplemented)
virDomainSetVcpus() API so it's not bug. I realize that naming could be
a little confusing so if you like, feel free
On 09/09/2013 10:01 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Create a setup.py for building libvirt python code and add
supporting files
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
.gitignore | 4 +
AUTHORS.in |
On 09/09/2013 01:56 AM, Li Zhang wrote:
From: Li Zhang zhlci...@linux.vnet.ibm.com
This patch is to Cleanup ppcCompute to avoid memory leak to make
the code better.
Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com
---
src/cpu/cpu_powerpc.c | 36 +++-
On 09/09/2013 10:01 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
libvirt-override.c | 16
1 file changed, 16 insertions(+)
Again, a candidate for sticking in a common internal header,
-Original Message-
From: Daniel P. Berrange [mailto:berra...@redhat.com]
Sent: Monday, September 09, 2013 7:26 PM
To: Liuji (Jeremy)
Cc: libvir-list@redhat.com; Jinbo (Justin); Luohao (brian); Haofeng
Subject: Re: [libvirt] [PATCH] virBitmapFree: Change the function to a macro
On
CD-ROMs and Floppies are allowed to have no source to imply they are
empty or disconnected. Since the LUN type is used for raw CD-ROM access
with QEMU (and VMWare in the future), it also needs to allow an empty
source when the raw CD-ROM device is disconnected from the domain.
---
A user came into #virt the other day and was trying to get libvirtd
to work with VMware Fusion 5, which is basically the Mac OS X version of
VMware Workstation. In helping him out I noticed a few limitations of our
VMX parser so I've added support through this patchset. I don't personally
have
A user was having an issue with this specific VMWare Fusion config and
he gave me permission to add it as part of our test suite to further
expand our VMX test coverage. Unfortunately our VMX parser and
generator does not support many features contained within and just
silently ignores fields it
VMWare Fusion 5 can set the CD-ROM's device name to be 'auto detect' when
using the physical drive via 'cdrom-raw' device type. VMWare will then
connect to first available host CD-ROM to the virtual machine upon start
up according to VMWare documentation. If no device is available, it
appears that
Currently the XML parser already allows the following syntax:
disk type='block' device='cdrom'
source startupPolicy='optional'/
target dev='hda' bus='ide'/
address type='drive' controller='0' bus='0' target='0' unit='0'/
/disk
But it did not support writing out the source entry
-Original Message-
From: Osier Yang [mailto:jy...@redhat.com]
Sent: Monday, September 09, 2013 6:15 PM
To: Liuji (Jeremy)
Cc: libvir-list@redhat.com; Jinbo (Justin); Luohao (brian); Haofeng
Subject: Re: [libvirt] [PATCH] virBitmapFree: Change the function to a macro
[..]
On 09/09/2013 11:30 PM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
If the guest is configured with
filesystem type='mount'
source dir='/'/
target dir='/'/
readonly/
/filesystem
Then any submounts under / should also end up
This patch introduces virDBusIsServiceEnabled, we can use
this method to get if the service is supported.
In one case, if org.freedesktop.machine1 is unavailable on
host, we should skip creating machine through systemd.
Signed-off-by: Gao feng gaof...@cn.fujitsu.com
---
src/util/virdbus.c|
72 matches
Mail list logo
