Re: [libvirt] [PATCH v3 2/7] cpu: add function to get the models for an arch

2013-09-14 Thread Giuseppe Scrivano
Eric Blake writes: > NACK, needs a v4; this is where we need to fix things to do the right > subdriver mapping. Quoting IRC: > > and I know which one to change > [15:30] jdenemareblake: cpu-models should work for both x86 and > x86_64 imho > [15:31] eblake yep - where the ma

[libvirt] [PATCH] build: make autobuild require rpm build deps

2013-09-14 Thread Eric Blake
I spent far too long on a new machine trying to figure out why ./autobuild.sh failed during the rpm build failure (complaining that libvirt_parthelper was supposed to be packaged but was not built), and finally traced it to a missing parted-devel installation. I don't know why we have --nodeps in

Re: [libvirt] [PATCH] Explicitly link libvirt_net_rpc against SELINUX_LIBS

2013-09-14 Thread Guido Günther
On Fri, Sep 13, 2013 at 11:53:16AM -0600, Eric Blake wrote: > On 09/13/2013 11:02 AM, Guido Günther wrote: > > Since virnetsocket conditionally uses selinux we need to link against it > > otherwise the build fails with: > > > > CCLD libvirtd > > /usr/bin/ld: ../src/.libs/libvirt-lxc.so: undefi