Raising this due to maven
On Fri, Sep 13, 2013 at 05:26:24PM +0800, Daniel Veillard wrote:
On Fri, Sep 13, 2013 at 11:13:53AM +0200, Wido den Hollander wrote:
[...]
Indeed that was the problem, I just commited the fix, thanks !
Hum, getting back on-list, I pushed everything
From: Li Zhang zhlci...@linux.vnet.ibm.com
PPC supports VFIO by assigning iommu groups to guests manually. It needs
the QEMU command line to support it. The command line is as the following:
-device spapr-pci-vfio-host-bridge,iommu=1,id=SOMEBUS,index=123
This patch will get the iommu group by
From: Li Zhang zhlci...@linux.vnet.ibm.com
To support VFIO for PPC, it is needed spapr-vfio-pci-host-bridge in
QEMU. This patch is to add one capability for it.
Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
2
Hi all,
In libvirt, it doesn't allow non-ACS switch to assign devices to guests.
Is this required for X86 to support PCI passthrough?
On my power machine, ACS capability can't be found. I think HW doesn't
support it.
I don't know whether this is a special situation, and I have to set
On 09/16/2013 07:58 AM, Daniel Veillard wrote:
Raising this due to maven
On Fri, Sep 13, 2013 at 05:26:24PM +0800, Daniel Veillard wrote:
On Fri, Sep 13, 2013 at 11:13:53AM +0200, Wido den Hollander wrote:
[...]
Indeed that was the problem, I just commited the fix, thanks !
On 09/13/13 17:36, Eric Blake wrote:
On 09/13/2013 08:19 AM, Peter Krempa wrote:
Explicitly state that some parts of the code may require virFileExists
to set or preserve a correct errno so that future modifications don't
break.
---
src/util/virfile.c | 6 ++
1 file changed, 6
On 09/13/13 17:31, Martin Kletzander wrote:
On 09/13/2013 04:19 PM, Peter Krempa wrote:
Semantics of the libvirt helper are more clear. This change also allows
to clean up some pieces of code.
---
[...]
diff --git a/src/storage/storage_backend_fs.c
b/src/storage/storage_backend_fs.c
The function existed in two identical instances in lxc and qemu. Move it
to vircgroup.c and simplify it. Refactor the callers too.
---
Notes:
Version 2:
- added a fallback implementation that doesn't spam logs with errors
src/libvirt_private.syms | 1 +
src/lxc/lxc_driver.c | 52
On Fri, Sep 13, 2013 at 03:45:58PM -0600, Eric Blake wrote:
On 09/13/2013 03:06 PM, Eric Blake wrote:
On 09/13/2013 02:58 PM, Eric Blake wrote:
On 09/11/2013 08:13 AM, Giuseppe Scrivano wrote:
I tweaked this some during my testing of NULL models; but don't think we
need to make virsh
On Sat, Sep 14, 2013 at 05:32:52AM -0600, Eric Blake wrote:
I spent far too long on a new machine trying to figure out why
./autobuild.sh failed during the rpm build failure (complaining
that libvirt_parthelper was supposed to be packaged but was not
built), and finally traced it to a missing
On Mon, Sep 16, 2013 at 11:19:13AM +0530, Nehal J Wani wrote:
+int
+virNetworkGetDHCPLeasesForMAC(virNetworkPtr network,
+ const char *mac,
+ virNetworkDHCPLeasesPtr **leases,
+ unsigned int flags)
+{
+
On Sun, Sep 15, 2013 at 01:05:15PM -0700, Andreea Hodea wrote:
My name is Andreea and I am a member of LiSA team. LiSA stands
for Linux Switching Appliance and offers a software switch that
switches packets at Layer 2 and Layer 3. It is an open source
project under development, you can find
On Mon, Sep 16, 2013 at 04:13:01PM +0800, Li Zhang wrote:
Hi all,
In libvirt, it doesn't allow non-ACS switch to assign devices to guests.
Is this required for X86 to support PCI passthrough?
On my power machine, ACS capability can't be found. I think HW
doesn't support it.
I don't know
External checkpoints have a bug in the implementation where they use the
normal definition instead of the migratable one. This causes errors
when the snapshot is being reverted using the workaround method via
qemuDomainRestoreFlags() with a custom XML. This issue was introduced
when commit
In the original implementation of external checkpoints I've mistakenly
used the live definition to be stored in the save image. The normal
approach is to use the migratable definition. This was discovered when
commit 07966f6a8b5ccb5bb4c716b25deb8ba2e572cc67 changed the behavior to
use a converted
The external snapshot code mistakenly used non-migratable XMLs
in the save image which caused problems with restoring them
via the workaround way of doing virDomainRestore().
This series adds workaround to add compatibility with older snapshots
and fixes the problem in the snapshot code.
On 09/10/13 12:15, Peter Krempa wrote:
This series adds the initialy omitted functionality of changing the metadata
element using the virDomain[Get|Set]Metadata API.
First few patches are cleanup of some code noticed during implementation of
the
other stuff.
Peter Krempa (14):
On Mon, Sep 9, 2013 at 8:48 PM, Doug Goldstein car...@cardoe.com wrote:
A user came into #virt the other day and was trying to get libvirtd
to work with VMware Fusion 5, which is basically the Mac OS X version of
VMware Workstation. In helping him out I noticed a few limitations of our
VMX
qemuMigrationEatCookie has flags to control if these should
be parsed, but it does not fill mig-flags. These cookies might
get leaked if these flags are not set by qemuMigrationBakeCookie.
42 (32 direct, 10 indirect) bytes in 1 blocks are definitely lost in
loss record 361 of 662
==123== by
1,003 bytes in 1 blocks are definitely lost in loss record 599 of 635
==404== by 0x50728A7: virBufferAddChar (virbuffer.c:185)
==404== by 0x50BC466: virSystemdEscapeName (virsystemd.c:67)
==404== by 0x50BC6B2: virSystemdMakeSliceName (virsystemd.c:108)
==404== by 0x50BC870: virSystemdCreateMachine
- Original Message -
From: Dan Kenigsberg dan...@redhat.com
To: Andrew Lau and...@andrewklau.com
Cc: libvir-list@redhat.com, users us...@ovirt.org
Sent: Sunday, September 15, 2013 3:47:03 PM
Subject: Re: [Users] Live Migration failed oVirt 3.3 Nightly
On Sun, Sep 15, 2013 at
On Sun, Sep 15, 2013 at 11:51 PM, Omer Frenkel ofren...@redhat.com wrote:
- Original Message -
From: Dan Kenigsberg dan...@redhat.com
To: Andrew Lau and...@andrewklau.com
Cc: libvir-list@redhat.com, users us...@ovirt.org
Sent: Sunday, September 15, 2013 3:47:03 PM
Subject:
On Mon, Sep 16, 2013 at 5:41 PM, Omer Frenkel ofren...@redhat.com wrote:
--
*From: *Andrew Lau and...@andrewklau.com
*To: *Omer Frenkel ofren...@redhat.com
*Cc: *Dan Kenigsberg dan...@redhat.com, libvir-list@redhat.com,
users us...@ovirt.org
*Sent: *Monday,
- Original Message -
From: Andrew Lau and...@andrewklau.com
To: Omer Frenkel ofren...@redhat.com
Cc: Dan Kenigsberg dan...@redhat.com, libvir-list@redhat.com, users
us...@ovirt.org
Sent: Monday, September 16, 2013 1:38:53 AM
Subject: Re: [Users] Live Migration failed oVirt 3.3
On Mon, 2013-09-16 at 11:02 +0100, Daniel P. Berrange wrote:
Looking at the website it seems that it requires custom kernel
branches, and the most recent kernel branch I see, with patches
from last 2 months, is based on the pretty old 2.6.32 release ?
The website also indicates the
On 09/15/2013 07:55 AM, Gianluca Cecchi wrote:
I'm using what stock f18 repo gives today:
[root@tekkaman ~]# rpm -q libvirt
libvirt-0.10.2.7-1.fc18.x86_64
Known bug: CVE-2013-4291. Downgrade to 0.10.2.6, or wait for 0.10.2.8
to be released.
--
Eric Blake eblake redhat com
On Mon, Sep 16, 2013 at 3:41 PM, Eric Blake wrote:
On 09/15/2013 07:55 AM, Gianluca Cecchi wrote:
I'm using what stock f18 repo gives today:
[root@tekkaman ~]# rpm -q libvirt
libvirt-0.10.2.7-1.fc18.x86_64
Known bug: CVE-2013-4291. Downgrade to 0.10.2.6, or wait for 0.10.2.8
to be
On 09/16/2013 07:27 AM, Ján Tomko wrote:
qemuMigrationEatCookie has flags to control if these should
be parsed, but it does not fill mig-flags. These cookies might
get leaked if these flags are not set by qemuMigrationBakeCookie.
42 (32 direct, 10 indirect) bytes in 1 blocks are definitely
On 09/16/2013 07:32 AM, Ján Tomko wrote:
1,003 bytes in 1 blocks are definitely lost in loss record 599 of 635
==404== by 0x50728A7: virBufferAddChar (virbuffer.c:185)
==404== by 0x50BC466: virSystemdEscapeName (virsystemd.c:67)
==404== by 0x50BC6B2: virSystemdMakeSliceName (virsystemd.c:108)
Hi,
This is a serie of patches in order to support undefining and redefining
snapshots with VirtualBox 4.2.
The serie of patches is rather big, and adds among other things some utility
functions unrelated to VirtualBox in patches 1 2.
The code review could be done in several parts: e.g. patches
It will be needed for the futur patches because we will
redefine snapshots
---
src/conf/domain_conf.c |2 +-
src/vbox/vbox_tmpl.c | 427 ++--
2 files changed, 417 insertions(+), 12 deletions(-)
diff --git a/src/conf/domain_conf.c
---
src/libvirt_private.syms |1 +
src/util/virstring.c | 48 ++
src/util/virstring.h |2 ++
3 files changed, 51 insertions(+)
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index a6af540..b5f83c3 100644
---
---
po/POTFILES.in |1 +
src/libvirt_private.syms |1 +
src/util/viruuid.c | 81 ++
src/util/viruuid.h |1 +
4 files changed, 84 insertions(+)
diff --git a/po/POTFILES.in b/po/POTFILES.in
index 2a0605b..029331b
All the informations concerning snapshots (and snapshot disks)
will be deleted from the vbox xml. But the differencing disks will be
kept so you will be able to redefine the snapshots.
---
src/vbox/vbox_tmpl.c | 387 ++
1 file changed, 387
The snapshots are saved in xml files, and then can be redefined
---
src/vbox/vbox_tmpl.c | 848 +-
1 file changed, 840 insertions(+), 8 deletions(-)
diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c
index ded179f..2b07dec 100644
---
On 09/16/2013 03:33 AM, Peter Krempa wrote:
The function existed in two identical instances in lxc and qemu. Move it
to vircgroup.c and simplify it. Refactor the callers too.
---
Notes:
Version 2:
- added a fallback implementation that doesn't spam logs with errors
On Fri, Sep 13, 2013 at 10:33:04AM -0600, Eric Blake wrote:
Bother those kernel developers. In the latest rawhide, kernel
and glibc have now been unified so that netinet/in.h and
linux/in6.h no longer clash; but linux/if_bridge.h is still
not self-contained. Because of the latest header
On 09/16/2013 03:48 AM, Daniel P. Berrange wrote:
On Sat, Sep 14, 2013 at 05:32:52AM -0600, Eric Blake wrote:
I spent far too long on a new machine trying to figure out why
./autobuild.sh failed during the rpm build failure (complaining
that libvirt_parthelper was supposed to be packaged but
On Mon, Sep 16, 2013 at 3:22 PM, Daniel P. Berrange berra...@redhat.com wrote:
On Mon, Sep 16, 2013 at 11:19:13AM +0530, Nehal J Wani wrote:
+int
+virNetworkGetDHCPLeasesForMAC(virNetworkPtr network,
+ const char *mac,
+
PFA: Diff
On Mon, Sep 16, 2013 at 8:44 PM, Nehal J Wani nehaljw.k...@gmail.com wrote:
On Mon, Sep 16, 2013 at 3:22 PM, Daniel P. Berrange berra...@redhat.com
wrote:
On Mon, Sep 16, 2013 at 11:19:13AM +0530, Nehal J Wani wrote:
+int
+virNetworkGetDHCPLeasesForMAC(virNetworkPtr network,
On Mon, Sep 16, 2013 at 08:45:09PM +0530, Nehal J Wani wrote:
PFA: Diff
On Mon, Sep 16, 2013 at 8:44 PM, Nehal J Wani nehaljw.k...@gmail.com wrote:
On Mon, Sep 16, 2013 at 3:22 PM, Daniel P. Berrange berra...@redhat.com
wrote:
On Mon, Sep 16, 2013 at 11:19:13AM +0530, Nehal J Wani
I spent far too long on a new machine trying to figure out why
./autobuild.sh failed due to an rpm build failure (complaining
that libvirt_parthelper was supposed to be packaged but was not
built), and finally traced it to a missing parted-devel
installation. I learned that --nodeps is in place
On 09/09/2013 07:48 PM, Doug Goldstein wrote:
Currently the XML parser already allows the following syntax:
disk type='block' device='cdrom'
source startupPolicy='optional'/
target dev='hda' bus='ide'/
address type='drive' controller='0' bus='0' target='0' unit='0'/
/disk
On 09/09/2013 07:48 PM, Doug Goldstein wrote:
VMWare Fusion 5 can set the CD-ROM's device name to be 'auto detect' when
using the physical drive via 'cdrom-raw' device type. VMWare will then
connect to first available host CD-ROM to the virtual machine upon start
up according to VMWare
From: Aline Manera alin...@br.ibm.com
The ftps protocol is another protocol supported by qemu/KVM while specifying
the cdrom ISO image.
The xml should be as following:
disk type='network' device='cdrom'
source protocol='ftps' name='/url/path'
host name='host.name' port='990'/
+static int
+remoteSerializeNetworkDHCPLeases(virNetworkDHCPLeasesPtr *leases,
+ int nleases,
+ remote_network_get_dhcp_leases_ret *ret)
+{
+size_t i;
+
+if (nleases REMOTE_NETWORK_DHCP_LEASES_MAX) {
+
On 09/09/2013 07:48 PM, Doug Goldstein wrote:
CD-ROMs and Floppies are allowed to have no source to imply they are
empty or disconnected. Since the LUN type is used for raw CD-ROM access
with QEMU (and VMWare in the future), it also needs to allow an empty
source when the raw CD-ROM device is
On 09/16/2013 04:26 PM, Eric Blake wrote:
On 09/16/2013 07:27 AM, Ján Tomko wrote:
qemuMigrationEatCookie has flags to control if these should
be parsed, but it does not fill mig-flags. These cookies might
get leaked if these flags are not set by qemuMigrationBakeCookie.
42 (32 direct, 10
On 09/09/2013 07:48 PM, Doug Goldstein wrote:
A user was having an issue with this specific VMWare Fusion config and
he gave me permission to add it as part of our test suite to further
expand our VMX test coverage. Unfortunately our VMX parser and
generator does not support many features
On Mon, Sep 16, 2013 at 09:40:32AM -0600, Eric Blake wrote:
I spent far too long on a new machine trying to figure out why
./autobuild.sh failed due to an rpm build failure (complaining
that libvirt_parthelper was supposed to be packaged but was not
built), and finally traced it to a missing
On 09/16/2013 09:56 AM, Daniel P. Berrange wrote:
On Mon, Sep 16, 2013 at 09:40:32AM -0600, Eric Blake wrote:
I spent far too long on a new machine trying to figure out why
./autobuild.sh failed due to an rpm build failure (complaining
that libvirt_parthelper was supposed to be packaged but
On Mon, Sep 16, 2013 at 11:31:27PM +0530, Nehal J Wani wrote:
+static int
+remoteSerializeNetworkDHCPLeases(virNetworkDHCPLeasesPtr *leases,
+ int nleases,
+ remote_network_get_dhcp_leases_ret *ret)
+{
+size_t i;
+
On 09/16/2013 12:01 PM, Nehal J Wani wrote:
+
+for (i = 0; i nleases; i++) {
+virNetworkDHCPLeasesPtr lease = leases[i];
+remote_network_dhcp_lease *lease_ret =
(ret-leases.leases_val[i]);
+error:
+for (i = 0; i nleases; i++) {
+remote_network_dhcp_lease
On 09/15/2013 11:49 PM, Nehal J Wani wrote:
By querying the driver for the path of the leases file for the given virtual
network and parsing it to retrieve info.
src/network/bridge_driver.c:
* Implement networkGetDHCPLeases
* Implement networkGetDHCPLeasesForMAC
* Implement
On 09/10/2013 04:15 AM, Peter Krempa wrote:
The function impelemnted common behavior that can be reused for other
s/impelemnted/implemented/
hypervisor drivers that use the virDomainObj data structures. Factor out
the core into a separate helper func.
---
src/conf/domain_conf.c | 55
On Mon, Sep 16, 2013 at 12:03 PM, Eric Blake ebl...@redhat.com wrote:
On 09/09/2013 07:48 PM, Doug Goldstein wrote:
Currently the XML parser already allows the following syntax:
disk type='block' device='cdrom'
source startupPolicy='optional'/
target dev='hda' bus='ide'/
On 09/16/2013 02:20 PM, Doug Goldstein wrote:
case VIR_DOMAIN_DISK_TYPE_BLOCK:
-virBufferEscapeString(buf, source dev='%s',
- def-src);
If def-src is NULL, this is a no-op, rather than printing def='(null)'.
Are you sure your
On 09/10/2013 04:15 AM, Peter Krempa wrote:
Line up the array so that the grid is visible.
---
Notes:
Not an useful change but it tripped my OCD while looking at the file.
tools/virsh-domain.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff
On 09/10/2013 04:15 AM, Peter Krempa wrote:
The function impelemnted common behavior that can be reused for other
s/impelemnted/implemented/
hypervisor drivers that use the virDomainObj data structures. Factor out
the core into a separate helper func.
---
src/conf/domain_conf.c | 85
On 09/10/2013 04:15 AM, Peter Krempa wrote:
---
src/libvirt_private.syms | 1 +
src/util/virxml.c| 33 +
src/util/virxml.h| 2 ++
3 files changed, 36 insertions(+)
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index
On Fri, Sep 13, 2013 at 2:51 AM, Daniel Veillard veill...@redhat.comwrote:
With a bit of delay, the release needed by Wido is finally available,
it is tagged in git and I have pushed tarball, jar and rpms to the FTP:
ftp://libvirt.org/libvirt/java/
Wido maybe you can push to Maven, I'm
On 09/10/2013 04:15 AM, Peter Krempa wrote:
---
tools/virsh-domain.c | 117
++-
1 file changed, 31 insertions(+), 86 deletions(-)
ACK; nice cleanup.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library
On 09/10/2013 04:15 AM, Peter Krempa wrote:
The code to set the metadata in a domain definition is common to live
and inactive domains. Factor it out into a common func.
---
src/conf/domain_conf.c | 113
+++--
1 file changed, 53 insertions(+), 60
On 09/15/2013 11:49 PM, Nehal J Wani wrote:
Use virNetworkGetDHCPLeases and virNetworkGetDHCPLeasesForMAC in virsh.
The new feature supports the follwing methods:
1. Retrieve leases info for a given virtual network
2. Retrieve leases info for given network interface
+
+static bool
On 09/10/2013 04:15 AM, Peter Krempa wrote:
The cmd variable is actually used so remove the attribute.
---
tools/virsh-domain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
ACK.
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 74feca1..f6bfad0 100644
---
On 09/16/13 16:28, Eric Blake wrote:
On 09/16/2013 03:33 AM, Peter Krempa wrote:
The function existed in two identical instances in lxc and qemu. Move it
to vircgroup.c and simplify it. Refactor the callers too.
---
Notes:
Version 2:
- added a fallback implementation that doesn't
On Mon, Sep 16, 2013 at 8:55 PM, Daniel P. Berrange berra...@redhat.com wrote:
On Mon, Sep 16, 2013 at 08:45:09PM +0530, Nehal J Wani wrote:
PFA: Diff
On Mon, Sep 16, 2013 at 8:44 PM, Nehal J Wani nehaljw.k...@gmail.com
wrote:
On Mon, Sep 16, 2013 at 3:22 PM, Daniel P. Berrange
From: Aline Manera alin...@br.ibm.com
The https protocol is also accepted by qemu/KVM when specifying the cdrom ISO
image.
The xml should be as following:
disk type='network' device='cdrom'
source protocol='https' name='/url/path'
host name='host.name' port='443'/
On 09/16/2013 08:31 AM, Daniel P. Berrange wrote:
On Fri, Sep 13, 2013 at 10:33:04AM -0600, Eric Blake wrote:
Bother those kernel developers. In the latest rawhide, kernel
and glibc have now been unified so that netinet/in.h and
linux/in6.h no longer clash; but linux/if_bridge.h is still
not
On 09/15/2013 11:49 PM, Nehal J Wani wrote:
Implement RPC calls for virNetworkGetDHCPLeases, virNetworkGetDHCPLeasesForMAC
A lot of my comments below are similar to what I did on Guiseppe's
patch; you may want to closely study:
From: Aline Manera alin...@br.ibm.com
qemu/KVM also supports https, ftps and tftp URL for cdrom definition.
With this patchset we will support all the protocols supported by qemu/KVM.
Aline Manera (3):
Add https protocol support for cdrom disk
Add ftps protocol support for cdrom disk
Add
On 09/16/2013 04:26 PM, Eric Blake wrote:
On 09/16/2013 07:32 AM, Ján Tomko wrote:
1,003 bytes in 1 blocks are definitely lost in loss record 599 of 635
==404== by 0x50728A7: virBufferAddChar (virbuffer.c:185)
==404== by 0x50BC466: virSystemdEscapeName (virsystemd.c:67)
==404== by 0x50BC6B2:
On 09/16/2013 06:36 AM, Peter Krempa wrote:
External checkpoints have a bug in the implementation where they use the
normal definition instead of the migratable one. This causes errors
when the snapshot is being reverted using the workaround method via
qemuDomainRestoreFlags() with a custom
On 09/16/2013 06:36 AM, Peter Krempa wrote:
In the original implementation of external checkpoints I've mistakenly
used the live definition to be stored in the save image. The normal
approach is to use the migratable definition. This was discovered when
commit
From: Aline Manera alin...@br.ibm.com
qemu/KVM also supports a tftp URL while specifying the cdrom ISO image.
The xml should be as following:
disk type='network' device='cdrom'
source protocol='tftp' name='/url/path'
host name='host.name' port='69'/
/source
/disk
On 09/15/2013 11:49 PM, Nehal J Wani wrote:
Introduce 3 new APIs, virNetworkGetDHCPLeases, virNetworkGetDHCPLeasesForMAC
and virNetworkDHCPLeaseFree.
+
+typedef struct _virNetworkDHCPLeases virNetworkDHCPLeases;
+typedef virNetworkDHCPLeases *virNetworkDHCPLeasesPtr;
+struct
Thank you Laine, for your prompt reply. Adding the dev list to broaden the
audience.
On Mon, Sep 16, 2013 at 9:21 AM, Laine Stump la...@laine.org wrote:
On 09/16/2013 07:32 AM, Ajith Antony wrote:
Hi, I'm not sure what the best way to pursue this is, but since it
appears you authored the
On Mon, Sep 16, 2013 at 03:19:32PM -0700, Jason Helfman wrote:
On Fri, Sep 13, 2013 at 2:51 AM, Daniel Veillard veill...@redhat.comwrote:
With a bit of delay, the release needed by Wido is finally available,
it is tagged in git and I have pushed tarball, jar and rpms to the FTP:
On 09/10/2013 04:15 AM, Peter Krempa wrote:
The metadata modification functions will support modification of the XML
metadata. Add a virsh command to allow using this approach.
---
tools/virsh-domain.c | 161
+++
1 file changed, 161
On 09/10/2013 04:15 AM, Peter Krempa wrote:
The virDomainGetMetadata function was designed to support also retrieval
of app specific metadata from the metadata element. This functionality
was never implemented originally.
---
+/**
+ * virXMLExtractNamespaceXML: extract a sub-namespace of a
On 09/10/2013 04:15 AM, Peter Krempa wrote:
The functionality wasn't originally implemented. This patch adds the
ability to modify domain's XML metadata using the API.
---
src/conf/domain_conf.c | 47 ++-
src/util/virxml.c | 32
On 09/10/2013 04:15 AM, Peter Krempa wrote:
virDomainSetMetadata when operating on the metadata element was
requesting the @key argument to be passed even if @metadata was NULL
used to delete the corresponding metadata element. This is not needed as
the key is only used when adding the element
On 09/10/2013 04:15 AM, Peter Krempa wrote:
---
src/lxc/lxc_driver.c | 70
1 file changed, 70 insertions(+)
ACK.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
On 09/10/2013 04:15 AM, Peter Krempa wrote:
---
src/test/test_driver.c | 68
++
1 file changed, 68 insertions(+)
ACK. Isn't shared code nice :)
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library
On 09/10/2013 04:15 AM, Peter Krempa wrote:
This test excercises the virDomain[Get|Set]Metadata API and tests it for
s/excercises/exercises/
regressions
---
tests/Makefile.am| 7 ++
tests/metadatatest.c | 245
+++
2 files changed,
85 matches
Mail list logo
