From: Chen Hanxiao chenhanx...@cn.fujitsu.com
free dst before lxcDomainAttachDeviceDiskLive return
Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com
---
src/lxc/lxc_driver.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c
index
On 09/25/2013 10:50 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The xenParseSxpr method sets def-nconsoles to 1 before allocating
the def-consoles array. If the allocation fails due to OOM the
cleanup code will thus crash accessing out of bounds.
On 26.09.2013 00:37, Jason Helfman wrote:
Libvirt no longer builds on FreeBSD 8.3. I had brought this up awhile
ago, but didn't have the resources to get the requested information. A
fellow committer was able to build, and send me an archive of the
complete build failure for analysis.
Here
On 24.09.2013 16:51, Panday Ritesh Sharma (rpanday) wrote:
Hi Team,
I have written below code to get the VM state at run time. I found,
though the VM is in shut-off state, when I use the function
virDomainGetInfo(); I get state as running. Could you please let me
know what wrong I am
On 09/26/2013 12:41 AM, Mihamina Rakotomandimby wrote:
Hi all,
Running Fedora 18 and the bundled libvirt and virt-tools. Desktop use.
As I like to access my guests with a hostname and not a numerical IP
address, I fix the IP addressing in the network configuration:
On 26.09.2013 05:50, varun bhatnagar wrote:
Hi,
Is it possible to attach a harddisk to an ESX node later after
creating/defining it?
If yes, can anyone tell me how to do it?
Regards,
Varun
Unfortunately, this piece of functionality is not implemented yet.
However, if you want to do a
Tweak some conditions and use correct typecasts in enums.
---
src/conf/domain_conf.c | 65 +-
1 file changed, 33 insertions(+), 32 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 0c8e9ad..52a4fb7 100644
---
Peter Krempa (2):
conf: Don't crash on invalid chardev source definition of RNGs and
other
conf: clean up virDomainChrSourceDefParseXML
src/conf/domain_conf.c | 68 +++---
.../qemuxml2argv-virtio-rng-egd-crash.xml | 27 +
Since commit 297c99a5 an invalid source definition XML of a character
device that is used as backend for RNG devices, smartcards and redirdevs
causes crash of the daemon when parsing such a definition.
The device types mentioned above are not a part of a regular character
device but are backends
On 2013年09月23日 17:47, Laine Stump wrote:
On 09/16/2013 03:42 AM, Li Zhang wrote:
From: Li Zhang zhlci...@linux.vnet.ibm.com
To support VFIO for PPC, it is needed spapr-vfio-pci-host-bridge in
QEMU. This patch is to add one capability for it.
Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com
This API returns the leases information stored in the DHCP leases
file of dnsmasq for a given virtual network. It contacts the
bridge network driver, which parses the leases file.
It supports two methods:
1. Return info for all network interfaces connected to a given
virtual network
2. Return
Implement RPC calls for virNetworkGetDHCPLeases, virNetworkGetDHCPLeasesForMAC
daemon/remote.c
* Define remoteSerializeNetworkDHCPLeases,
remoteDispatchNetworkGetDHCPLeases
* Define remoteDispatchNetworkGetDHCPLeasesForMAC
* Define helper function make_dhcp_lease
By querying the driver for the path of the leases file for the given virtual
network and parsing it to retrieve info.
src/network/bridge_driver.c:
* Implement networkGetDHCPLeases
* Implement networkGetDHCPLeasesForMAC
* Implement networkGetDHCPLeasesHelper
---
src/network/bridge_driver.c | 240
Introduce 3 new APIs, virNetworkGetDHCPLeases, virNetworkGetDHCPLeasesForMAC
and virNetworkDHCPLeaseFree.
* virNetworkGetDHCPLeases: returns the dhcp leases information for a given
virtual network.
For DHCPv4, the information includes:
- Expirytime
- MAC Address
- IPv4
Use virNetworkGetDHCPLeases and virNetworkGetDHCPLeasesForMAC in virsh.
The new feature supports the follwing methods:
1. Retrieve leases info for a given virtual network
2. Retrieve leases info for given network interface
tools/virsh-domain-monitor.c
* Introduce new command :
On Thu, Sep 26, 2013 at 02:01:52PM +0800, Chen Hanxiao wrote:
From: Chen Hanxiao chenhanx...@cn.fujitsu.com
free dst before lxcDomainAttachDeviceDiskLive return
Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com
---
src/lxc/lxc_driver.c | 1 +
1 file changed, 1 insertion(+)
diff
Since qemu-kvm 1.1 [1] (since 1.3. in upstream QEMU [2])
'-no-kvm-pit-reinjection' has been deprecated.
Use -global kvm-pit.lost_tick_policy=discard instead.
https://bugzilla.redhat.com/show_bug.cgi?id=978719
[1] http://git.kernel.org/cgit/virt/kvm/qemu-kvm.git/commit/?id=4e4fa39
[2]
On 23.09.2013 18:57, Eric Blake wrote:
On 09/23/2013 06:58 AM, Michal Privoznik wrote:
This test is there to ensure that our capabilities detection code isn't
broken somehow.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
.gitignore |1 +
---
docs/schemas/domaincommon.rng | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
index 5c5301d..6aee447 100644
--- a/docs/schemas/domaincommon.rng
+++ b/docs/schemas/domaincommon.rng
@@ -4119,17 +4119,17 @@
---
src/conf/domain_conf.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index b18f72e..192f3c3 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -11377,8 +11377,7 @@ virDomainDefParseXML(xmlDocPtr xml,
Version 2 incorporates changes based on review feedback from Jan and Doug.
Peter Krempa (5):
schema: Rename option to make it reusable
conf: Refactor storing and usage of feature flags
qemu: Add support for paravirtual spinlocks in the guest
conf: Clean up few error messages
qemu:
To allow a finer control for some future flags, refactor the code to
store them in an array instead of a bitmap.
---
Notes:
Version 2:
- extracted unrelated changes to separate patches
- added error on features that don't support state=off
- removed spurious comment
The linux kernel recently added support for paravirtual spinlock
handling to avoid performance regressions on overcomitted hosts. This
feature needs to be turned in the hypervisor so that the guest OS is
notified about the possible support.
This patch adds a new feature paravirt-spinlock to the
---
src/qemu/qemu_command.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 6a39321..c2ae29a 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -11123,7 +11123,7 @@ qemuParseCommandLine(virCapsPtr
On 26/09/2013, at 6:30 AM, Daniel Veillard wrote:
snip
I will probably make rc2 during the w.e. and depending on news push on
Tuesday next week or a bit later the final 1.1.3
Compiles ok on MacOS 10.7. virsh starts ok too.
One weirdness noted from inside virsh (not connected to a
-Original Message-
From: Daniel Veillard [mailto:veill...@redhat.com]
Sent: Thursday, September 26, 2013 4:42 PM
To: Chen Hanxiao
Cc: libvir-list@redhat.com
Subject: Re: [libvirt] [PATCH]LXC: free dst before
lxcDomainAttachDeviceDiskLive return
On Thu, Sep 26, 2013 at
On 26.09.2013 10:59, Justin Clift wrote:
On 26/09/2013, at 6:30 AM, Daniel Veillard wrote:
snip
I will probably make rc2 during the w.e. and depending on news push on
Tuesday next week or a bit later the final 1.1.3
Compiles ok on MacOS 10.7. virsh starts ok too.
One weirdness noted
This should resolve:
https://bugzilla.redhat.com/show_bug.cgi?id=1012085
libvirt previously recognized NFS, GFS2, OCFS2, and AFS filesystems as
shared, and thus eligible for exceptions to certain rules/actions
about chowning image files before handing them off to a guest. This
patch widens the
On 26/09/2013, at 10:05 AM, Michal Privoznik wrote:
On 26.09.2013 10:59, Justin Clift wrote:
On 26/09/2013, at 6:30 AM, Daniel Veillard wrote:
snip
I will probably make rc2 during the w.e. and depending on news push on
Tuesday next week or a bit later the final 1.1.3
Compiles ok on MacOS
On Thu, Sep 26, 2013 at 10:43:34AM +0100, Justin Clift wrote:
On 26/09/2013, at 10:05 AM, Michal Privoznik wrote:
On 26.09.2013 10:59, Justin Clift wrote:
On 26/09/2013, at 6:30 AM, Daniel Veillard wrote:
snip
I will probably make rc2 during the w.e. and depending on news push on
Yes, I am sure because other information pulled are correct. And the same way
we have used libvirt APIs to extract other informations at different places.
My question is if VM is in shut-off state does it mean running ? IF not, what
is the correct state for this VM. I am wondering why the state
On 26.09.2013 11:48, Panday Ritesh Sharma (rpanday) wrote:
Yes, I am sure because other information pulled are correct. And the same way
we have used libvirt APIs to extract other informations at different places.
My question is if VM is in shut-off state does it mean running ? IF not, what
The bug is that after shutting down an lxc full-distro container, start
always fails. It turns out that shutdown doesn't clean the machine on
the machined side. A workaround is to machinectl terminate the
container. A proper fix would be that machinectl tracks the state of the
init process and
On Thu, Sep 26, 2013 at 11:53:30AM +0200, Cédric Bosdonnat wrote:
The bug is that after shutting down an lxc full-distro container, start
always fails. It turns out that shutdown doesn't clean the machine on
the machined side. A workaround is to machinectl terminate the
container. A proper fix
On 26.09.2013 09:28, Peter Krempa wrote:
Peter Krempa (2):
conf: Don't crash on invalid chardev source definition of RNGs and
other
conf: clean up virDomainChrSourceDefParseXML
src/conf/domain_conf.c | 68
+++---
On Thu, Sep 26, 2013 at 01:30:53PM +0800, Daniel Veillard wrote:
I'm a day late from suggested schedule, but I have now tagged rc1 in
git and pushed the tarball and rpms to the usual place:
ftp://libvirt.org/libvirt/
My initial testing didn't revealed anything bad, but wider testing
so make check can work for the distributed tarballs too.
---
src/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index 4375ef7..4057eda 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -533,7 +533,7 @@ check-aclperms:
On Thu, Sep 26, 2013 at 01:39:26PM +0200, Guido Günther wrote:
so make check can work for the distributed tarballs too.
---
src/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index 4375ef7..4057eda 100644
---
On 09/26/13 13:31, Michal Privoznik wrote:
On 26.09.2013 09:28, Peter Krempa wrote:
Peter Krempa (2):
conf: Don't crash on invalid chardev source definition of RNGs and
other
conf: clean up virDomainChrSourceDefParseXML
src/conf/domain_conf.c | 68
On Thu, Sep 26, 2013 at 01:38:17PM +0200, Guido Günther wrote:
On Thu, Sep 26, 2013 at 01:30:53PM +0800, Daniel Veillard wrote:
I'm a day late from suggested schedule, but I have now tagged rc1 in
git and pushed the tarball and rpms to the usual place:
ftp://libvirt.org/libvirt/
On Thu, Sep 26, 2013 at 12:42:19PM +0100, Daniel P. Berrange wrote:
On Thu, Sep 26, 2013 at 01:39:26PM +0200, Guido Günther wrote:
so make check can work for the distributed tarballs too.
---
src/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Hey,
On Wed, Sep 25, 2013 at 09:31:52AM -0700, Jason Helfman wrote:
When compiling libvirt-glib with CLANG, I get the following error.
16 warnings generated.
CCLD libvirt-glib-1.0.la
GEN LibvirtGLib-1.0.gir
/usr/local/lib/libvirt.so: undefined reference to
On 09/26/2013 08:01 AM, Chen Hanxiao wrote:
From: Chen Hanxiao chenhanx...@cn.fujitsu.com
free dst before lxcDomainAttachDeviceDiskLive return
Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com
---
src/lxc/lxc_driver.c | 1 +
1 file changed, 1 insertion(+)
ACK and pushed.
Jan
--
On 09/24/2013 10:03 AM, Chen Hanxiao wrote:
From: Chen Hanxiao chenhanx...@cn.fujitsu.com
The return value of virDomainControllerFind =0 means that
the specific controller was found.
But some functions invoke it and treat 0 as not found.
This patch fix these incorrect invocation.
On Tue, Sep 24, 2013 at 01:04:14PM +0300, Gleb Natapov wrote:
On Tue, Sep 24, 2013 at 11:57:00AM +0200, Borislav Petkov wrote:
On Mon, September 23, 2013 6:28 pm, Eduardo Habkost wrote:
On Sun, Sep 22, 2013 at 04:44:50PM +0200, Borislav Petkov wrote:
From: Borislav Petkov b...@suse.de
On 09/26/2013 03:43 AM, Laine Stump wrote:
This should resolve:
https://bugzilla.redhat.com/show_bug.cgi?id=1012085
libvirt previously recognized NFS, GFS2, OCFS2, and AFS filesystems as
shared, and thus eligible for exceptions to certain rules/actions
about chowning image files before
The one we were using does not work properly with clang, causing
the build process to try to use -f/-W options that are not
supported by clang.
---
m4/warnings.m4 | 82 --
1 file changed, 62 insertions(+), 20 deletions(-)
diff --git
[actually adding coreutils]
On 09/26/2013 08:28 AM, Eric Blake wrote:
On 09/26/2013 03:43 AM, Laine Stump wrote:
This should resolve:
https://bugzilla.redhat.com/show_bug.cgi?id=1012085
libvirt previously recognized NFS, GFS2, OCFS2, and AFS filesystems as
shared, and thus eligible for
On 25.09.2013 21:15, Cole Robinson wrote:
Makes things more readable IMO
---
src/qemu/qemu_driver.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 346a8f9..0dc975b 100644
--- a/src/qemu/qemu_driver.c
On 25.09.2013 21:15, Cole Robinson wrote:
This is just stolen from qemu_driver.c with tweaks to fit the
test driver.
---
src/test/test_driver.c | 392
+
1 file changed, 392 insertions(+)
diff --git a/src/test/test_driver.c
On 25.09.2013 21:15, Cole Robinson wrote:
Similar to the runstate commit, allow a boolean test:transient/
element for setting domain persistence at driver startup.
---
v3:
Validate that transient is not specified with runstate=shutoff
src/test/test_driver.c | 16 +++-
1
On 25.09.2013 21:15, Cole Robinson wrote:
Also add a test:hasmanagedsave element to set this data when starting
the connection.
---
v3:
Mandate managedsave have runstate=shutoff
src/test/test_driver.c | 134
-
tests/virshtest.c |
On 25.09.2013 21:15, Cole Robinson wrote:
Again stolen from qemu_driver.c, but dropping all the unneeded bits.
This aims to copy all the current qemu validation checks since that's
the most commonly used real driver, but some of the checks are
completely artificial in the test driver.
This
On Thu, Sep 26, 2013 at 5:06 AM, Daniel Veillard veill...@redhat.comwrote:
On Thu, Sep 26, 2013 at 01:38:17PM +0200, Guido Günther wrote:
On Thu, Sep 26, 2013 at 01:30:53PM +0800, Daniel Veillard wrote:
I'm a day late from suggested schedule, but I have now tagged rc1 in
git and pushed
On 09/26/2013 03:33 PM, Eric Blake wrote:
[actually adding coreutils]
On 09/26/2013 08:28 AM, Eric Blake wrote:
On 09/26/2013 03:43 AM, Laine Stump wrote:
This should resolve:
https://bugzilla.redhat.com/show_bug.cgi?id=1012085
libvirt previously recognized NFS, GFS2, OCFS2, and AFS
On Thu, Sep 26, 2013 at 04:31:27PM +0200, Christophe Fergeau wrote:
The one we were using does not work properly with clang, causing
the build process to try to use -f/-W options that are not
supported by clang.
---
m4/warnings.m4 | 82
On Thu, Sep 26, 2013 at 04:53:07PM +0100, Daniel P. Berrange wrote:
On Thu, Sep 26, 2013 at 04:31:27PM +0200, Christophe Fergeau wrote:
The one we were using does not work properly with clang, causing
the build process to try to use -f/-W options that are not
supported by clang.
---
On Thu, Sep 26, 2013 at 7:33 AM, Eric Blake ebl...@redhat.com wrote:
[actually adding coreutils]
On 09/26/2013 08:28 AM, Eric Blake wrote:
On 09/26/2013 03:43 AM, Laine Stump wrote:
This should resolve:
https://bugzilla.redhat.com/show_bug.cgi?id=1012085
libvirt previously recognized
If a SCSI hostdev is included in an initial domain XML, without a
corresponding controller statement, one is created silently when the
guest is booted.
When hotplugging a SCSI hostdev, a presumption is that the controller
is already present in the domain either from the original XML, or via
an
Today, hotplug of a SCSI hostdev relies on the presence of an existing
SCSI controller, which can be defined in the initial domain XML. Hotplug
of a SCSI controller relies on the presence of a PCI bus, which does not
work in all environments.
These patches correct this behavior, in order to
For systems without a PCI bus, attaching a SCSI controller fails:
[root@ ~]# cat controller.xml
controller type='scsi' model='virtio-scsi' index='0' /
[root@ ~]# virsh attach-device guest01 controller.xml
error: Failed to attach device from controller.xml
error: XML
For attach/detach of controller devices, we rename the functions to
remove 'PCI' from their title. The actual separation of PCI-specific
operations will be handled in the next patch.
Signed-off-by: Eric Farman far...@linux.vnet.ibm.com
---
src/qemu/qemu_driver.c |4 ++--
Thanks a ton Michal for the reply. I tried your suggestion but a message
popped out when was trying to save the xml file which said: Editing of
already existing domain is not supported... :(
Why I want this is because the node which is getting created is creating
empty vmdk image and if I try to
On Thu, Sep 26, 2013 at 3:59 AM, Justin Clift jcl...@redhat.com wrote:
On 26/09/2013, at 6:30 AM, Daniel Veillard wrote:
snip
I will probably make rc2 during the w.e. and depending on news push on
Tuesday next week or a bit later the final 1.1.3
Compiles ok on MacOS 10.7. virsh starts ok
On Thu, Sep 26, 2013 at 4:43 AM, Justin Clift jcl...@redhat.com wrote:
On 26/09/2013, at 10:05 AM, Michal Privoznik wrote:
On 26.09.2013 10:59, Justin Clift wrote:
On 26/09/2013, at 6:30 AM, Daniel Veillard wrote:
snip
I will probably make rc2 during the w.e. and depending on news push on
On Thu, Sep 26, 2013 at 1:13 PM, Doug Goldstein car...@gentoo.org wrote:
On Thu, Sep 26, 2013 at 3:59 AM, Justin Clift jcl...@redhat.com wrote:
On 26/09/2013, at 6:30 AM, Daniel Veillard wrote:
snip
I will probably make rc2 during the w.e. and depending on news push on
Tuesday next week or a
On Thu, Sep 26, 2013 at 11:19:15AM -0300, Eduardo Habkost wrote:
Then we may have a problem: some CPU models already have movbe
included (e.g. Haswell), and patch 6/6 will make -cpu Haswell get
movbe enabled even if it is being emulated.
Huh? HSW has MOVBE so we won't #UD on it and MOVBE will
On Thu, Sep 26, 2013 at 08:55:24PM +0200, Borislav Petkov wrote:
On Thu, Sep 26, 2013 at 11:19:15AM -0300, Eduardo Habkost wrote:
Then we may have a problem: some CPU models already have movbe
included (e.g. Haswell), and patch 6/6 will make -cpu Haswell get
movbe enabled even if it is
On Thu, Sep 26, 2013 at 08:06:54PM +0800, Daniel Veillard wrote:
On Thu, Sep 26, 2013 at 01:38:17PM +0200, Guido Günther wrote:
On Thu, Sep 26, 2013 at 01:30:53PM +0800, Daniel Veillard wrote:
I'm a day late from suggested schedule, but I have now tagged rc1 in
git and pushed the
On Thu, Sep 26, 2013 at 04:20:59PM -0300, Eduardo Habkost wrote:
Please point me to the code that does this, because I don't see it on
patch 6/6.
@@ -1850,7 +1850,14 @@ static void filter_features_for_kvm(X86CPU *cpu)
wi-cpuid_ecx,
On 09/25/2013 11:30 PM, Daniel Veillard wrote:
I'm a day late from suggested schedule, but I have now tagged rc1 in
git and pushed the tarball and rpms to the usual place:
ftp://libvirt.org/libvirt/
My initial testing didn't revealed anything bad, but wider testing
is obviously
On Thu, Sep 26, 2013 at 8:20 AM, Ján Tomko jto...@redhat.com wrote:
On 09/26/2013 08:01 AM, Chen Hanxiao wrote:
From: Chen Hanxiao chenhanx...@cn.fujitsu.com
free dst before lxcDomainAttachDeviceDiskLive return
Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com
---
On 09/26/2013 03:06 PM, Doug Goldstein wrote:
On Thu, Sep 26, 2013 at 8:20 AM, Ján Tomko jto...@redhat.com wrote:
On 09/26/2013 08:01 AM, Chen Hanxiao wrote:
From: Chen Hanxiao chenhanx...@cn.fujitsu.com
free dst before lxcDomainAttachDeviceDiskLive return
Signed-off-by: Chen Hanxiao
Caused by commit 012c25e8 splitting out a convenience library.
CC libvirtd_conf_la-libvirtd-config.lo
In file included from ../src/rpc/virnetmessage.h:24:0,
from ../src/rpc/virnetserverprogram.h:27,
from ../src/rpc/virnetserver.h:32,
from
From: Chen Hanxiao chenhanx...@cn.fujitsu.com
LXC: fix a comment typo in lxc_controller.c
Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com
---
src/lxc/lxc_controller.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lxc/lxc_controller.c b/src/lxc/lxc_controller.c
75 matches
Mail list logo
