On 25.09.2013 21:15, Cole Robinson wrote:
---
src/conf/snapshot_conf.c | 150
+++
src/conf/snapshot_conf.h | 7 +++
src/libvirt_private.syms | 1 +
src/qemu/qemu_driver.c | 131 +
4 files changed,
On 25.09.2013 21:15, Cole Robinson wrote:
The user can pass it as a test:domainsnapshot subelement of a domain.
---
src/test/test_driver.c | 99
+-
1 file changed, 98 insertions(+), 1 deletion(-)
diff --git a/src/test/test_driver.c
On 25.09.2013 21:15, Cole Robinson wrote:
---
src/test/test_driver.c | 67
--
1 file changed, 43 insertions(+), 24 deletions(-)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 1b79b70..8a690fd 100644
---
From: WangYufei james.wangyu...@huawei.com
Date: Fri, 27 Sep 2013 11:53:57 +0800
Subject: [PATCH] qemu_migrate: Fix assign the same port when migrating
concurrently
When we migrate vms concurrently, there's a chance that libvirtd on destination
assign the same port for different migrations,
On 27.09.2013 07:43, Chen Hanxiao wrote:
From: Chen Hanxiao chenhanx...@cn.fujitsu.com
LXC: fix a comment typo in lxc_controller.c
Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com
---
src/lxc/lxc_controller.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On Thu, Sep 26, 2013 at 12:24 AM, Michal Privoznik mpriv...@redhat.comwrote:
On 26.09.2013 00:37, Jason Helfman wrote:
Libvirt no longer builds on FreeBSD 8.3. I had brought this up awhile
ago, but didn't have the resources to get the requested information. A
fellow committer was able to
The one we were using does not work properly with clang, causing
the build process to try to use -f/-W options that are not
supported by clang.
---
Pushed through
https://www.redhat.com/archives/libvir-list/2013-September/msg01600.html
m4/warnings.m4 | 82
---
Pushed under the trivial rule
libvirt-designer/libvirt-designer-main.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libvirt-designer/libvirt-designer-main.h
b/libvirt-designer/libvirt-designer-main.h
index 5e82f8a..9341754 100644
---
On 27.09.2013 08:49, Jason Helfman wrote:
On Thu, Sep 26, 2013 at 12:24 AM, Michal Privoznik mpriv...@redhat.com
mailto:mpriv...@redhat.com wrote:
On 26.09.2013 00 tel:26.09.2013%2000:37, Jason Helfman wrote:
Libvirt no longer builds on FreeBSD 8.3. I had brought this up awhile
On 27.09.2013 09:15, Christophe Fergeau wrote:
---
Pushed under the trivial rule
libvirt-designer/libvirt-designer-main.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libvirt-designer/libvirt-designer-main.h
b/libvirt-designer/libvirt-designer-main.h
index
Hello,
I found a problem that libvirtd on destination crash frequently while migrating
vms concurrently. For example, if I migrate 10 vms concurrently ceaselessly,
then after about 30 minutes the libvirtd on destination will crash. So I
analyzed and found two bugs during migration process.
https://bugzilla.redhat.com/show_bug.cgi?id=1012818
Commit 6d7d0b1869ed293e3208d11f375cecea0129dfc5 (in 1.1.2) added bounds
checking to virDomainGetJobStats. But even at that time the API was able
to return 20 parameters while the limit was set to 16.
Signed-off-by: Jiri Denemark
On Fri, Sep 27, 2013 at 06:28:50 +, Wangyufei (A) wrote:
From: WangYufei james.wangyu...@huawei.com
Date: Fri, 27 Sep 2013 11:53:57 +0800
Subject: [PATCH] qemu_migrate: Fix assign the same port when migrating
concurrently
When we migrate vms concurrently, there's a chance that libvirtd
2013/9/24 Doug Goldstein car...@cardoe.com:
Currently the VMware version check code only supports two types of
VMware backends, Workstation and Player. But in the near future we will
have an additional one so we need to support more. Additionally, we
discover and cache the path to the vmrun
2013/9/24 Doug Goldstein car...@cardoe.com:
Add support for VMware Fusion in the existing VMware driver. Connect
via the URI vmwarefusion:///session
---
change from v2:
* Re-add missing hunk that got rebased away in vmwareParseVersionStr()
change from v1:
* ifdef PATH for Apple machines
Yes, I get your point.
this_port = QEMUD_MIGRATION_FIRST_PORT + port++;
if (port == QEMUD_MIGRATION_NUM_PORTS)
port = 0;
the operations above should be atomic, otherwise, port may be bigger than
QEMUD_MIGRATION_NUM_PORTS and out of control at last. Right?
On 27.09.2013 11:36, Wangyufei (A) wrote:
Yes, I get your point.
this_port = QEMUD_MIGRATION_FIRST_PORT + port++;
if (port == QEMUD_MIGRATION_NUM_PORTS)
port = 0;
In fact this won't work either. What if this_port is already taken by
another app?
On Tue, Sep 24, 2013 at 11:24:30AM -0500, Doug Goldstein wrote:
Currently the VMware version check code only supports two types of
VMware backends, Workstation and Player. But in the near future we will
have an additional one so we need to support more. Additionally, we
discover and cache the
On 09/24/2013 06:24 PM, Doug Goldstein wrote:
+driver-type = -1;
+for (i = 0; i VMWARE_DRIVER_LAST; i++) {
+if (STREQ(tmp, vmwareDriverTypeToString(i)))
+driver-type = i;
+}
+
You can use virEnumFromString for this:
driver-type =
This should resolve:
https://bugzilla.redhat.com/show_bug.cgi?id=1012085
libvirt previously recognized NFS, GFS2, OCFS2, and AFS filesystems as
shared, and thus eligible for exceptions to certain rules/actions
about chowning image files before handing them off to a guest. This
patch widens the
On Fri, Sep 27, 2013 at 10:57:40AM +0200, Jiri Denemark wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1012818
Commit 6d7d0b1869ed293e3208d11f375cecea0129dfc5 (in 1.1.2) added bounds
checking to virDomainGetJobStats. But even at that time the API was able
to return 20 parameters while
On Fri, Sep 27, 2013 at 11:48:53 +0100, Daniel Berrange wrote:
On Fri, Sep 27, 2013 at 10:57:40AM +0200, Jiri Denemark wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1012818
Commit 6d7d0b1869ed293e3208d11f375cecea0129dfc5 (in 1.1.2) added bounds
checking to virDomainGetJobStats. But
Similar to commit 8f34f19.
* tests/Makefile.am (virnetserverclienttest_CFLAGS): Add XDR_CFLAGS.
Signed-off-by: Eric Blake ebl...@redhat.com
---
Pushing under the build-breaker rule.
tests/Makefile.am | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/Makefile.am b/tests/Makefile.am
On 09/27/2013 01:35 AM, Michal Privoznik wrote:
make[3]: Entering directory
`/home/zippy/work/tmp/a/libvirt-1.1.2/gnulib/lib'
CC allocator.lo
In file included from allocator.c:4:0:
./stdlib.h:76:8: error: redefinition of 'struct random_data'
struct random_data
^
In file
On 09/27/2013 04:38 AM, Laine Stump wrote:
This should resolve:
https://bugzilla.redhat.com/show_bug.cgi?id=1012085
libvirt previously recognized NFS, GFS2, OCFS2, and AFS filesystems as
shared, and thus eligible for exceptions to certain rules/actions
about chowning image files before
From: Chen Hanxiao chenhanx...@cn.fujitsu.com
Currently, if we don't explicitly add root fs for container,
libvirt will add one for us implicitly with / as src.
It would be not safe.
Unless user asked for it, we should not assume this.
Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com
---
On Fri, Sep 27, 2013 at 08:27:06PM +0800, Chen Hanxiao wrote:
From: Chen Hanxiao chenhanx...@cn.fujitsu.com
Currently, if we don't explicitly add root fs for container,
libvirt will add one for us implicitly with / as src.
It would be not safe.
Unless user asked for it, we should not assume
Removed superfluous/wrong srcdir prefix.
Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com
---
src/Makefile.am |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index 4057eda..09311b7 100644
--- a/src/Makefile.am
+++
On 09/26/2013 07:30 AM, Daniel Veillard wrote:
I'm a day late from suggested schedule, but I have now tagged rc1 in
git and pushed the tarball and rpms to the usual place:
ftp://libvirt.org/libvirt/
My initial testing didn't revealed anything bad, but wider testing
is obviously needed,
On 26/09/2013, at 7:16 PM, Doug Goldstein wrote:
On Thu, Sep 26, 2013 at 1:13 PM, Doug Goldstein car...@gentoo.org wrote:
snip
This was the error I brought up on the ML with the 1.1.2 release. I
still haven't had a chance to get to the bottom of it. The issue stems
from the fact that we're
On 09/27/2013 06:46 AM, Viktor Mihajlovski wrote:
Removed superfluous/wrong srcdir prefix.
Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com
---
src/Makefile.am |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
ACK. Will push shortly.
diff --git a/src/Makefile.am
On 09/26/2013 02:51 PM, Eric Blake wrote:
I suspect it is just a missing CFLAGS, since other Makefile.am manage to
include the appropriate -I/usr/lib/tirpc just fine, as needed for that
header.
I've gotten mostly past that, except that 'make -C src check' is trying
to build
Another build failure detected on cygwin, where lxc is not built.
The lxc_monitor_protocol.c file requires the use of $(XDR_CFLAGS),
but should only be built on platforms where WITH_LXC is true;
however, 'make -C src check' was unconditionally trying to build
the .o file (and with the wrong
https://bugzilla.redhat.com/show_bug.cgi?id=1011330 (case A)
While activeScsiHostdevs and webSocketPorts were allocated in
qemuStateInitialize, they were not freed in qemuStateCleanup.
Signed-off-by: Jiri Denemark jdene...@redhat.com
---
src/qemu/qemu_driver.c | 2 ++
1 file changed, 2
Jiri Denemark (2):
qemu: Don't leak reference to virQEMUDriverConfigPtr
qemu: Free all driver data in qemuStateCleanup
src/qemu/qemu_driver.c | 2 ++
src/qemu/qemu_process.c | 3 ++-
2 files changed, 4 insertions(+), 1 deletion(-)
--
1.8.3.2
--
libvir-list mailing list
https://bugzilla.redhat.com/show_bug.cgi?id=1011330 (case D)
qemuProcessStart created two references to virQEMUDriverConfigPtr before
calling fork():
cfg = virQEMUDriverGetConfig(driver);
...
hookData.cfg = virObjectRef(cfg);
However, the child only unreferenced hookData.cfg and the
On 09/27/2013 07:47 AM, Jiri Denemark wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1011330 (case A)
While activeScsiHostdevs and webSocketPorts were allocated in
qemuStateInitialize, they were not freed in qemuStateCleanup.
Signed-off-by: Jiri Denemark jdene...@redhat.com
---
On 09/27/2013 07:47 AM, Jiri Denemark wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1011330 (case D)
qemuProcessStart created two references to virQEMUDriverConfigPtr before
calling fork():
cfg = virQEMUDriverGetConfig(driver);
...
hookData.cfg = virObjectRef(cfg);
Btrfs provides a copy-on-write clone ioctl so let's try to use it instead
of copying files block by block. The ioctl is executed unconditionally if
it's available and we fall back to block copying if it fails, similarly to
cp --reflink=auto.
Signed-off-by: Oskari Saarenmaa o...@ohmu.fi
---
On Fri, Sep 27, 2013 at 05:02:53PM +0300, Oskari Saarenmaa wrote:
Btrfs provides a copy-on-write clone ioctl so let's try to use it instead
of copying files block by block. The ioctl is executed unconditionally if
it's available and we fall back to block copying if it fails, similarly to
cp
On Thu, Sep 26, 2013 at 10:32:06PM +0200, Borislav Petkov wrote:
On Thu, Sep 26, 2013 at 04:20:59PM -0300, Eduardo Habkost wrote:
Please point me to the code that does this, because I don't see it on
patch 6/6.
@@ -1850,7 +1850,14 @@ static void filter_features_for_kvm(X86CPU *cpu)
On some systems (linux, cygwin and freebsd) rpcgen generates files which
when compiling produces this warning:
remote/remote_protocol.c: In function 'xdr_remote_node_get_cpu_stats_ret':
remote/remote_protocol.c:530: warning: dereferencing type-punned pointer will
break strict-aliasing rules
On Fri, Sep 27, 2013 at 04:39:21PM +0200, Michal Privoznik wrote:
On some systems (linux, cygwin and freebsd) rpcgen generates files which
when compiling produces this warning:
remote/remote_protocol.c: In function 'xdr_remote_node_get_cpu_stats_ret':
remote/remote_protocol.c:530: warning:
Currently, we have functions to handle fc_host implemented just
for linux. On all other platforms an error is thrown. It makes no
sense to run the test on those platforms then.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
tests/fchosttest.c | 5 +
1 file changed, 5 insertions(+)
On some systems (linux, cygwin and gnukfreebsd) rpcgen generates files
which when compiling produces this warning:
remote/remote_protocol.c: In function 'xdr_remote_node_get_cpu_stats_ret':
remote/remote_protocol.c:530: warning: dereferencing type-punned pointer will
break strict-aliasing rules
On Fri, Sep 27, 2013 at 04:55:39PM +0200, Michal Privoznik wrote:
On some systems (linux, cygwin and gnukfreebsd) rpcgen generates files
which when compiling produces this warning:
remote/remote_protocol.c: In function 'xdr_remote_node_get_cpu_stats_ret':
remote/remote_protocol.c:530:
On 09/27/2013 08:51 AM, Michal Privoznik wrote:
Currently, we have functions to handle fc_host implemented just
for linux. On all other platforms an error is thrown. It makes no
sense to run the test on those platforms then.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
On Fri, Sep 27, 2013 at 09:19:12AM -0600, Eric Blake wrote:
On 09/27/2013 08:51 AM, Michal Privoznik wrote:
Currently, we have functions to handle fc_host implemented just
for linux. On all other platforms an error is thrown. It makes no
sense to run the test on those platforms then.
From: Daniel P. Berrange berra...@redhat.com
When a client disconnects from libvirtd, all event callbacks
must be removed. This involves running the public API
virConnectDomainEventDeregisterAny
This code does not run in normal API dispatch context, so no
identity was set. The result was that
On 09/27/2013 09:26 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
When a client disconnects from libvirtd, all event callbacks
must be removed. This involves running the public API
virConnectDomainEventDeregisterAny
This code does not run in normal API
The problem is described by [0] but its effect on libvirt is that
starting a container with a full distro running systemd after having
stopped it simply fails.
The container cleanup now calls the machined Terminate function to make
sure that everything is in order for the next run.
[0]:
On Fri, Sep 27, 2013 at 05:25:55PM +0200, Cédric Bosdonnat wrote:
The problem is described by [0] but its effect on libvirt is that
starting a container with a full distro running systemd after having
stopped it simply fails.
The container cleanup now calls the machined Terminate function to
On Thu, Sep 19, 2013 at 04:27:41PM -0600, Eric Blake wrote:
I'm tired of cryptic reports on IRC from people who build from
git, then type 'make install' and have it fail quite a ways down
the road because the documentation wasn't built. It's a feature
that documentation is not built during
On 09/27/2013 09:48 AM, Daniel P. Berrange wrote:
* cfg.mk: Let 'make install' and 'make dist' error much earlier if
we detect a build from git without doc toolchain.
Signed-off-by: Eric Blake ebl...@redhat.com
---
Can't we just make our existing rules fatal. I really don't see the point
On Wed, Sep 25, 2013 at 3:21 AM, Daniel P. Berrange berra...@redhat.com wrote:
On Tue, Sep 24, 2013 at 04:24:43PM -0500, Doug Goldstein wrote:
On Tue, Sep 24, 2013 at 11:03 AM, Daniel P. Berrange
berra...@redhat.com wrote:
From: Daniel P. Berrange berra...@redhat.com
If OOM occurs in
On Tue, Sep 24, 2013 at 11:44 AM, Doug Goldstein car...@cardoe.com wrote:
Ensure that the socket credentials we got back on BSD are valid before
using them.
---
src/rpc/virnetsocket.c | 12
1 file changed, 12 insertions(+)
diff --git a/src/rpc/virnetsocket.c
On Tue, Sep 24, 2013 at 11:44:56AM -0500, Doug Goldstein wrote:
The debug message said there was a timeout of 0 pending for -1 ms which
made me think this is where a hang was coming from but according to the
function comments this case means that there is no timeout pending so
make the debug
On Tue, Sep 24, 2013 at 11:44:54AM -0500, Doug Goldstein wrote:
Ensure that the socket credentials we got back on BSD are valid before
using them.
---
src/rpc/virnetsocket.c | 12
1 file changed, 12 insertions(+)
diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c
On Tue, Sep 24, 2013 at 11:44:55AM -0500, Doug Goldstein wrote:
While BSDs don't support process creation timestamp information via
PEERCRED for Unix sockets, we need to actually initialize the value
because it is used by the libvirt code.
---
src/rpc/virnetsocket.c | 4 +++-
1 file
When running 'make dist' on a system without policykit, we currently
fail. This is because $(srcdir)/access/org.libvirt.api.policy is in
EXTRA_DIST, however, the rule to generate the file is conditional
whether we build with polkit or not.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
On Fri, Sep 27, 2013 at 11:16 AM, Daniel P. Berrange
berra...@redhat.com wrote:
On Tue, Sep 24, 2013 at 11:44:54AM -0500, Doug Goldstein wrote:
Ensure that the socket credentials we got back on BSD are valid before
using them.
---
src/rpc/virnetsocket.c | 12
1 file changed, 12
Currently, we have functions to handle fc_host implemented just
for linux. On all other platforms an error is thrown. It makes no
sense to run the test on those platforms then.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
tests/Makefile.am | 10 +-
1 file changed, 9
On 09/27/2013 10:18 AM, Michal Privoznik wrote:
When running 'make dist' on a system without policykit, we currently
fail. This is because $(srcdir)/access/org.libvirt.api.policy is in
EXTRA_DIST, however, the rule to generate the file is conditional
whether we build with polkit or not.
On 09/27/2013 10:18 AM, Michal Privoznik wrote:
Currently, we have functions to handle fc_host implemented just
for linux. On all other platforms an error is thrown. It makes no
sense to run the test on those platforms then.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
On Fri, Sep 27, 2013 at 05:43:50PM +0200, Christophe Fergeau wrote:
Hey Martin,
Your reply wasn't sent to the mailing list, I'm assuming this was
unintentional.
Yes, sorry, that happened to me with 2 ACKs today :-(
On Fri, Sep 27, 2013 at 12:08:27PM +0200, Martin Kletzander wrote:
On
On Thu, Sep 26, 2013 at 10:59:04AM +0800, Hongwei Bi wrote:
Check return value of virStreamNew when called by
cmdVolUpload and cmdVolDownload.
---
tools/virsh-volume.c |8 ++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/tools/virsh-volume.c
On Fri, Sep 27, 2013 at 4:57 AM, Eric Blake ebl...@redhat.com wrote:
On 09/27/2013 01:35 AM, Michal Privoznik wrote:
make[3]: Entering directory
`/home/zippy/work/tmp/a/libvirt-1.1.2/gnulib/lib'
CC allocator.lo
In file included from allocator.c:4:0:
./stdlib.h:76:8: error:
On Thu, Sep 26, 2013 at 6:06 AM, Christophe Fergeau cferg...@redhat.comwrote:
Hey,
On Wed, Sep 25, 2013 at 09:31:52AM -0700, Jason Helfman wrote:
When compiling libvirt-glib with CLANG, I get the following error.
16 warnings generated.
CCLD libvirt-glib-1.0.la
GEN
On 09/24/2013 11:14 AM, Peter Krempa wrote:
...
src/qemu/qemu_process.c | 30 +++---
1 file changed, 19 insertions(+), 11 deletions(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 846cee6..2b9bfe3 100644
--- a/src/qemu/qemu_process.c
+++
---
tools/virsh-domain.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 8538125..fa012d1 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -4488,7 +4488,7 @@ cmdDump(vshControl *ctl, const vshCmd *cmd)
Another case missed by commits 716c7bb and 6973e02.
* src/Makefile.am (VIR_NET_RPC_GENERATED): Drop $(srcdir).
(libvirt_net_rpc_la_SOURCES): List generated files more compactly.
Signed-off-by: Eric Blake ebl...@redhat.com
---
Pushing under the trivial rule.
src/Makefile.am | 13 ++---
I tried to test ./configure --without-lxc --without-remote.
First, the build failed with some odd errors, such as an
inability to build xen, or link failures for virNetTLSInit.
But when you think about it, once there is no remote code,
all of libvirtd is useless, any stateful driver that depends
'make distcheck' fails from a directory configured --without-lxc:
GEN virt-login-shell.1
Can't write-open ../../tools/virt-login-shell.1: Permission denied at
/usr/bin/pod2man line 69.
* tools/Makefile.am (EXTRA_DIST): Ship pre-built man page.
Signed-off-by: Eric Blake ebl...@redhat.com
On 09/27/2013 09:24 PM, Eric Blake wrote:
'make distcheck' fails from a directory configured --without-lxc:
GEN virt-login-shell.1
Can't write-open ../../tools/virt-login-shell.1: Permission denied at
/usr/bin/pod2man line 69.
* tools/Makefile.am (EXTRA_DIST): Ship pre-built man
74 matches
Mail list logo
