Re: [libvirt] [PATCH] add migration APIs to libxl driver

2013-09-30 Thread Bamvor Jian Zhang
--- src/libxl/libxl_conf.h |4 + src/libxl/libxl_driver.c | 641 ++ src/libxl/libxl_driver.h |5 + 3 files changed, 650 insertions(+), 0 deletions(-) diff --git a/src/libxl/libxl_conf.h b/src/libxl/libxl_conf.h index

[libvirt] [PATCH] fix a ambiguous output of the command:'virsh vol-create-as'

2013-09-30 Thread Hongwei Bi
I created a storage volume(eg: test) from a storage pool(eg:vg10) using the following command:virsh vol-create-as --pool vg10 --name test --capacity 300M. When I re-executed the above command, the output was as the following: error: Failed to create vol test error: Storage volume not found:

[libvirt] Openvswitch support question

2013-09-30 Thread Vasiliy Tolstov
Hi all. I'm using vs witch and libvirt 1.2. I'm write vswitch controller and want to react on up/down port in virtual switch. All fork fine, but message sent to controller does not contain Mac address of added interface. Does this libvirt problem or this is only vswitch error? -- libvir-list

Re: [libvirt] qemu, numa: non-contiguous cpusets

2013-09-30 Thread Daniel P. Berrange
On Sun, Sep 29, 2013 at 05:10:44PM +0200, Borislav Petkov wrote: Btw, while I got your attention, on a not-really related topic: how do we feel about adding support for specifying a non-contiguous set of cpus for a numa node in qemu with the -numa option? I.e., like this, for example:

[libvirt] [PATCH]lxc: goto cleanup if lxcContainerBuildInitCmd returns NULL

2013-09-30 Thread Chen Hanxiao
From: Chen Hanxiao chenhanx...@cn.fujitsu.com We should goto cleanup directly if lxcContainerBuildInitCmd returns NULL, which would avoid lots of unnecessary works. Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com --- src/lxc/lxc_container.c | 5 - 1 file changed, 4 insertions(+), 1

Re: [libvirt] Openvswitch support question

2013-09-30 Thread Michal Privoznik
On 30.09.2013 10:08, Vasiliy Tolstov wrote: Hi all. I'm using vs witch and libvirt 1.2. I'm write vswitch controller and want to react on up/down port in virtual switch. All fork fine, but message sent to controller does not contain Mac address of added interface. Does this libvirt problem

Re: [libvirt] [PATCH]lxc: do cleanup when failed to bind fs as read-only

2013-09-30 Thread Daniel P. Berrange
On Sun, Sep 29, 2013 at 06:36:24PM +0800, Chen Hanxiao wrote: From: Chen Hanxiao chenhanx...@cn.fujitsu.com We forgot to 'goto cleanup' when lxcContainerMountFSTmpfs failed to bind fs as read-only. Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com --- src/lxc/lxc_container.c | 1 +

Re: [libvirt] [PATCH] storage: use btrfs file clone ioctl when possible

2013-09-30 Thread Daniel P. Berrange
On Mon, Sep 30, 2013 at 01:21:18AM +0300, Oskari Saarenmaa wrote: On Fri, Sep 27, 2013 at 03:19:06PM +0100, Daniel P. Berrange wrote: On Fri, Sep 27, 2013 at 05:02:53PM +0300, Oskari Saarenmaa wrote: Btrfs provides a copy-on-write clone ioctl so let's try to use it instead of copying

Re: [libvirt] [PATCH]lxc: goto cleanup if lxcContainerBuildInitCmd returns NULL

2013-09-30 Thread Daniel P. Berrange
On Mon, Sep 30, 2013 at 04:20:14PM +0800, Chen Hanxiao wrote: From: Chen Hanxiao chenhanx...@cn.fujitsu.com We should goto cleanup directly if lxcContainerBuildInitCmd returns NULL, which would avoid lots of unnecessary works. Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com ---

Re: [libvirt] Openvswitch support question

2013-09-30 Thread Vasiliy Tolstov
On Sep 30, 2013 12:32 PM, Michal Privoznik mpriv...@redhat.com wrote: On 30.09.2013 10:08, Vasiliy Tolstov wrote: Hi all. I'm using vs witch and libvirt 1.2. I'm write vswitch controller and want to react on up/down port in virtual switch. All fork fine, but message sent to controller

Re: [libvirt] qemu, numa: non-contiguous cpusets

2013-09-30 Thread Paolo Bonzini
Il 29/09/2013 17:10, Borislav Petkov ha scritto: Btw, while I got your attention, on a not-really related topic: how do we feel about adding support for specifying a non-contiguous set of cpus for a numa node in qemu with the -numa option? I.e., like this, for example:

[libvirt] [PATCH v2]lxc: do cleanup when failed to bind fs as read-only

2013-09-30 Thread Chen Hanxiao
From: Chen Hanxiao chenhanx...@cn.fujitsu.com We forgot to do cleanup when lxcContainerMountFSTmpfs failed to bind fs as read-only. v2: fix an indentation issue Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com --- src/lxc/lxc_container.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [libvirt] [PATCH]lxc: do cleanup when failed to bind fs as read-only

2013-09-30 Thread Chen Hanxiao
-Original Message- From: Daniel P. Berrange [mailto:berra...@redhat.com] Sent: Monday, September 30, 2013 4:45 PM To: Chen Hanxiao Cc: libvir-list@redhat.com Subject: Re: [libvirt] [PATCH]lxc: do cleanup when failed to bind fs as read-only On Sun, Sep 29, 2013 at 06:36:24PM

Re: [libvirt] [PATCH]lxc: goto cleanup if lxcContainerBuildInitCmd returns NULL

2013-09-30 Thread Chen Hanxiao
-Original Message- From: Daniel P. Berrange [mailto:berra...@redhat.com] Sent: Monday, September 30, 2013 4:51 PM To: Chen Hanxiao Cc: libvir-list@redhat.com Subject: Re: [libvirt] [PATCH]lxc: goto cleanup if lxcContainerBuildInitCmd returns NULL On Mon, Sep 30, 2013 at

[libvirt] [PATCH 1/2] python: Report nodeinfo's memory in KiB

2013-09-30 Thread Michal Privoznik
The python binding to virNodeGetInfo API has this awful bug. The amount of RAM the node has is reported in MiB instead of KiB as we have documented in the struct virNodeInfo description. The problem is, after we obtain the nodeinfo the amount is shifted left ten times (divided by 1024).

[libvirt] [PATCH 2/2] python: Document virNodeGetInfo bug

2013-09-30 Thread Michal Privoznik
The memory size in virNodeGetInfo python API binding is reported in MiB instead of KiB (like we have in C struct). However, there already might be applications out there relying on this inconsistence so we can't simply fix it. Document this sad fact as known bug. Signed-off-by: Michal Privoznik

[libvirt] [PATCH 0/2] Python virNodeGetInfo mess

2013-09-30 Thread Michal Privoznik
I'm proposing two contradictionary patches to fix the issue. Long story short, libvirt is mangling the memory size in pythong API binding where the size is reported in MiB instead of KiB: https://www.redhat.com/archives/libvirt-users/2013-September/msg00187.html Which approach do you like

Re: [libvirt] [PATCH 1/2] python: Report nodeinfo's memory in KiB

2013-09-30 Thread Daniel P. Berrange
On Mon, Sep 30, 2013 at 11:30:11AM +0200, Michal Privoznik wrote: The python binding to virNodeGetInfo API has this awful bug. The amount of RAM the node has is reported in MiB instead of KiB as we have documented in the struct virNodeInfo description. The problem is, after we obtain the

Re: [libvirt] [PATCH] genprotocol.pl: Fix code on FreeBSD too

2013-09-30 Thread Guido Günther
On Fri, Sep 27, 2013 at 04:39:21PM +0200, Michal Privoznik wrote: On some systems (linux, cygwin and freebsd) rpcgen generates files which when compiling produces this warning: remote/remote_protocol.c: In function 'xdr_remote_node_get_cpu_stats_ret': remote/remote_protocol.c:530: warning:

Re: [libvirt] [PATCH 2/2] python: Document virNodeGetInfo bug

2013-09-30 Thread Daniel P. Berrange
On Mon, Sep 30, 2013 at 11:30:12AM +0200, Michal Privoznik wrote: The memory size in virNodeGetInfo python API binding is reported in MiB instead of KiB (like we have in C struct). However, there already might be applications out there relying on this inconsistence so we can't simply fix it.

Re: [libvirt] [PATCH v2] genprotocol.pl: Fix code on FreeBSD too

2013-09-30 Thread Guido Günther
On Fri, Sep 27, 2013 at 04:55:39PM +0200, Michal Privoznik wrote: On some systems (linux, cygwin and gnukfreebsd) rpcgen generates files which when compiling produces this warning: remote/remote_protocol.c: In function 'xdr_remote_node_get_cpu_stats_ret': remote/remote_protocol.c:530:

Re: [libvirt] [PATCH 1/2] python: Report nodeinfo's memory in KiB

2013-09-30 Thread Michal Privoznik
On 30.09.2013 11:37, Daniel P. Berrange wrote: On Mon, Sep 30, 2013 at 11:30:11AM +0200, Michal Privoznik wrote: The python binding to virNodeGetInfo API has this awful bug. The amount of RAM the node has is reported in MiB instead of KiB as we have documented in the struct virNodeInfo

Re: [libvirt] [PATCH 2/2] python: Document virNodeGetInfo bug

2013-09-30 Thread Michal Privoznik
On 30.09.2013 11:38, Daniel P. Berrange wrote: On Mon, Sep 30, 2013 at 11:30:12AM +0200, Michal Privoznik wrote: The memory size in virNodeGetInfo python API binding is reported in MiB instead of KiB (like we have in C struct). However, there already might be applications out there relying on

Re: [libvirt] qemu, numa: non-contiguous cpusets

2013-09-30 Thread Borislav Petkov
On Mon, Sep 30, 2013 at 11:05:10AM +0200, Paolo Bonzini wrote: I think there are already patches on the list to do that, as part of the NUMA memory binding series from Wanlong Gao. Yeah: https://lists.gnu.org/archive/html/qemu-devel/2013-09/msg02833.html Although I don't see from it how the

[libvirt] [PATCH] qemu: process: Silence coverity warning when rewinding log file

2013-09-30 Thread Peter Krempa
The change in ef29de14c37d14abc546e90555a0093797facfdd that introduced better error logging from qemu introduced a warning from coverity about unused return value from lseek. Silence this warning and fix typo in the corresponding error message. Reported by: John Ferlan ---

[libvirt] [PATCH] virfile: safezero: align mmap offset to page size

2013-09-30 Thread Oskari Saarenmaa
mmap's offset must be aligned to page size or mapping will fail. mmap-based safezero is only used if posix_fallocate isn't available. Signed-off-by: Oskari Saarenmaa o...@ohmu.fi --- src/util/virfile.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git

[libvirt] [PATCH] libvirt: hostdev SCSI AdapterId retrieval fix

2013-09-30 Thread Boris Fiuczynski
Fixed the retrieval of the AdapterId from the AdapterName of the hostdev source so it does return an error instead of leaving the adapter_id uninitialized. Signed-off-by: Boris Fiuczynski fiu...@linux.vnet.ibm.com Reviewed-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com ---

Re: [libvirt] [PATCH] qemu: process: Silence coverity warning when rewinding log file

2013-09-30 Thread John Ferlan
On 09/30/2013 06:01 AM, Peter Krempa wrote: The change in ef29de14c37d14abc546e90555a0093797facfdd that introduced better error logging from qemu introduced a warning from coverity about unused return value from lseek. Silence this warning and fix typo in the corresponding error message.

Re: [libvirt] [PATCH] qemu: process: Silence coverity warning when rewinding log file

2013-09-30 Thread Peter Krempa
On 09/30/13 13:20, John Ferlan wrote: On 09/30/2013 06:01 AM, Peter Krempa wrote: The change in ef29de14c37d14abc546e90555a0093797facfdd that introduced better error logging from qemu introduced a warning from coverity about unused return value from lseek. Silence this warning and fix typo in

Re: [libvirt] [sandbox PATCH] virt-sandbox patch to launch containers with proper label

2013-09-30 Thread Daniel P. Berrange
On Wed, Sep 25, 2013 at 04:50:23PM -0400, Dan Walsh wrote: virt-sandbox should be launching containers based off the lxc_context file from selinux-policy. I changed the hard coded paths to match the latest fedora assigned labels. Fedora 20 SELinux Policy and beyond will have proper SELinux

Re: [libvirt] [PATCHv2 3/5] qemu: Add support for paravirtual spinlocks in the guest

2013-09-30 Thread Peter Krempa
On 09/26/13 10:59, Peter Krempa wrote: The linux kernel recently added support for paravirtual spinlock handling to avoid performance regressions on overcomitted hosts. This feature needs to be turned in the hypervisor so that the guest OS is notified about the possible support. This patch

Re: [libvirt] [PATCH v2 1/2] Introduce Libvirt Wireshark dissector

2013-09-30 Thread Yuto KAWAMURA
2013/9/20 Daniel P. Berrange berra...@redhat.com: On Thu, Sep 19, 2013 at 11:26:08PM +0900, Yuto KAWAMURA(kawamuray) wrote: diff --git a/tools/wireshark/src/moduleinfo.h b/tools/wireshark/src/moduleinfo.h new file mode 100644 index 000..9ab642c --- /dev/null +++

[libvirt] [PATCH v3 0/2] Libvirt Wireshark dissector

2013-09-30 Thread Yuto KAWAMURA(kawamuray)
From: Yuto KAWAMURA(kawamuray) kawamuray.dad...@gmail.com Changes from version2: * Remove moduleinfo.h * Stop accessing internal XDR struct and just use free() Introduce Wireshark dissector plugin which adds support to Wireshark for dissecting libvirt RPC protocol. This feature was presented by

[libvirt] [PATCH v3 2/2] Add sample output of Wireshark dissector

2013-09-30 Thread Yuto KAWAMURA(kawamuray)
From: Yuto KAWAMURA(kawamuray) kawamuray.dad...@gmail.com Add directory tools/wireshark/samples/ and libvirt-sample.pdml which is sample output of dissector. --- tools/wireshark/samples/libvirt-sample.pdml | 206 1 file changed, 206 insertions(+) create mode 100644

Re: [libvirt] qemu, numa: non-contiguous cpusets

2013-09-30 Thread Paolo Bonzini
Il 30/09/2013 11:49, Borislav Petkov ha scritto: Yeah: https://lists.gnu.org/archive/html/qemu-devel/2013-09/msg02833.html Although I don't see from it how the syntax for -cpus will look like from that QAPI magic except that it is an + '*cpus': ['uint16'], It's -numa

Re: [libvirt] [PATCH v2 1/2] Introduce Libvirt Wireshark dissector

2013-09-30 Thread Daniel P. Berrange
On Mon, Sep 30, 2013 at 09:12:35PM +0900, Yuto KAWAMURA wrote: 2013/9/20 Daniel P. Berrange berra...@redhat.com: On Thu, Sep 19, 2013 at 11:26:08PM +0900, Yuto KAWAMURA(kawamuray) wrote: diff --git a/tools/wireshark/src/moduleinfo.h b/tools/wireshark/src/moduleinfo.h new file mode 100644

Re: [libvirt] [sandbox PATCH] virt-sandbox patch to launch containers with proper label

2013-09-30 Thread Daniel J Walsh
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/30/2013 08:07 AM, Daniel P. Berrange wrote: On Wed, Sep 25, 2013 at 04:50:23PM -0400, Dan Walsh wrote: virt-sandbox should be launching containers based off the lxc_context file from selinux-policy. I changed the hard coded paths to match

Re: [libvirt] [sandbox PATCH] virt-sandbox patch to launch containers with proper label

2013-09-30 Thread Daniel P. Berrange
On Mon, Sep 30, 2013 at 08:39:35AM -0400, Daniel J Walsh wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/30/2013 08:07 AM, Daniel P. Berrange wrote: On Wed, Sep 25, 2013 at 04:50:23PM -0400, Dan Walsh wrote: virt-sandbox should be launching containers based off the lxc_context

Re: [libvirt] [PATCH v2] virsh-domain: Free dom before return false in cmdDump

2013-09-30 Thread Peter Krempa
On 09/28/13 00:02, Hongwei Bi wrote: --- tools/virsh-domain.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) ACK and will be pushed shortly. Peter signature.asc Description: OpenPGP digital signature -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH v2] virsh-volume: Add missing check when calling virStreamNew

2013-09-30 Thread Peter Krempa
On 09/29/13 11:24, Hongwei Bi wrote: Check return value of virStreamNew when called by cmdVolUpload and cmdVolDownload. --- tools/virsh-volume.c | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions(-) ACK will be pushed soon. Peter signature.asc Description:

Re: [libvirt] [PATCH] libvirt: hostdev SCSI AdapterId retrieval fix

2013-09-30 Thread Michal Privoznik
On 30.09.2013 13:20, Boris Fiuczynski wrote: Fixed the retrieval of the AdapterId from the AdapterName of the hostdev source so it does return an error instead of leaving the adapter_id uninitialized. Signed-off-by: Boris Fiuczynski fiu...@linux.vnet.ibm.com Reviewed-by: Viktor Mihajlovski

Re: [libvirt] [PATCH] qemu_migrate: Fix assign the same port when migrating concurrently

2013-09-30 Thread jdene...@redhat.com
On Mon, Sep 30, 2013 at 03:55:21 +, Wangyufei (A) wrote: From 6c2de34432db674072231ad66c9e8a0a600ede8a Mon Sep 17 00:00:00 2001 From: WangYufei james.wangyu...@huawei.com Date: Mon, 30 Sep 2013 11:48:43 +0800 Subject: [PATCH] qemu_migrate: Fix assign the same port when migrating

Re: [libvirt] [PATCH] virfile: safezero: align mmap offset to page size

2013-09-30 Thread Michal Privoznik
On 30.09.2013 13:01, Oskari Saarenmaa wrote: mmap's offset must be aligned to page size or mapping will fail. mmap-based safezero is only used if posix_fallocate isn't available. Signed-off-by: Oskari Saarenmaa o...@ohmu.fi --- src/util/virfile.c | 14 +++--- 1 file changed, 11

Re: [libvirt] [PATCH v3 1/2] Introduce Libvirt Wireshark dissector

2013-09-30 Thread Michal Privoznik
On 30.09.2013 14:15, Yuto KAWAMURA(kawamuray) wrote: From: Yuto KAWAMURA(kawamuray) kawamuray.dad...@gmail.com Introduce Wireshark dissector plugin which adds support to Wireshark for dissecting libvirt RPC protocol. Added following files to build Wireshark dissector from libvirt source

[libvirt] error: server response too large

2013-09-30 Thread Claudio Bley
Hi. When trying to do a screenshot of a remote domain connected via qemu+tcp (for testing purposes only), I receive this error: -- virsh -c qemu+tcp://dev/system Welcome to virsh, the virtualization interactive terminal. Type:

Re: [libvirt] [PATCH v2] virsh-volume: Add missing check when calling virStreamNew

2013-09-30 Thread Hongwei Bi
2013/9/30 Peter Krempa pkre...@redhat.com: On 09/29/13 11:24, Hongwei Bi wrote: Check return value of virStreamNew when called by cmdVolUpload and cmdVolDownload. --- tools/virsh-volume.c | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions(-) ACK will be pushed soon.

Re: [libvirt] [PATCH v2] virsh-domain: Free dom before return false in cmdDump

2013-09-30 Thread Hongwei Bi
2013/9/30 Peter Krempa pkre...@redhat.com: On 09/28/13 00:02, Hongwei Bi wrote: --- tools/virsh-domain.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) ACK and will be pushed shortly. Peter Pushed; Thanks. -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [PATCH] LXC: workaround machined uncleaned data with containers running systemd.

2013-09-30 Thread Cédric Bosdonnat
The problem is described by [0] but its effect on libvirt is that starting a container with a full distro running systemd after having stopped it simply fails. The container cleanup now calls the machined Terminate function to make sure that everything is in order for the next run. [0]:

Re: [libvirt] error: server response too large

2013-09-30 Thread Michal Privoznik
On 30.09.2013 17:02, Claudio Bley wrote: Hi. When trying to do a screenshot of a remote domain connected via qemu+tcp (for testing purposes only), I receive this error: -- virsh -c qemu+tcp://dev/system Welcome to virsh,

Re: [libvirt] error: server response too large

2013-09-30 Thread Daniel P. Berrange
On Mon, Sep 30, 2013 at 05:23:33PM +0200, Michal Privoznik wrote: On 30.09.2013 17:02, Claudio Bley wrote: Hi. When trying to do a screenshot of a remote domain connected via qemu+tcp (for testing purposes only), I receive this error:

Re: [libvirt] error: server response too large

2013-09-30 Thread Viktor Mihajlovski
On 09/30/2013 05:24 PM, Daniel P. Berrange wrote: 0.9.8-2ubuntu17.13. This works as expected. 0.9.8 still had a small buffer for RPC messages. It's since 0.9.13 release that we've switched to dynamically allocated buffer and hence could size up the limit for incoming data. Update the client

Re: [libvirt] [PATCH] LXC: workaround machined uncleaned data with containers running systemd.

2013-09-30 Thread Daniel P. Berrange
On Mon, Sep 30, 2013 at 04:46:29PM +0200, Cédric Bosdonnat wrote: The problem is described by [0] but its effect on libvirt is that starting a container with a full distro running systemd after having stopped it simply fails. The container cleanup now calls the machined Terminate function to

Re: [libvirt] struct random on FreeBSD [was: FreeBSD-8.3 build failure for amd64/i386, build archive included]

2013-09-30 Thread Jason Helfman
On Sat, Sep 28, 2013 at 4:36 PM, Eric Blake ebl...@redhat.com wrote: On 09/27/2013 01:01 PM, Jason Helfman wrote: On Fri, Sep 27, 2013 at 4:57 AM, Eric Blake ebl...@redhat.com wrote: On 09/27/2013 01:35 AM, Michal Privoznik wrote: make[3]: Entering directory

Re: [libvirt] [PATCH 1/6] kvm: Add KVM_GET_EMULATED_CPUID

2013-09-30 Thread Eduardo Habkost
On Sat, Sep 28, 2013 at 12:49:04PM +0200, Borislav Petkov wrote: On Fri, Sep 27, 2013 at 11:21:34AM -0300, Eduardo Habkost wrote: The problem here is that requested_features doesn't include just the explicit +flag flags, but any flag included in the CPU model definition. See the -cpu n270

Re: [libvirt] [PATCH 1/6] kvm: Add KVM_GET_EMULATED_CPUID

2013-09-30 Thread Borislav Petkov
On Mon, Sep 30, 2013 at 01:13:34PM -0300, Eduardo Habkost wrote: I have added it to my TODO-list. :-) Cool, thanks. Let me know if I can test stuff and help out somehow. Also, there's another aspect, while we're here: now that QEMU emulates MOVBE with TCG too, how do we specify on the

[libvirt] [PATCH] Fix max stream packet size for old clients

2013-09-30 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The libvirtd server pushes data out to clients. It does not know what protocol version the client might have, so must be conservative and use the old payload limits. ie send no more than 256kb of data per packet. Signed-off-by: Daniel P. Berrange

Re: [libvirt] [PATCH] Fix max stream packet size for old clients

2013-09-30 Thread Michal Privoznik
On 30.09.2013 18:29, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The libvirtd server pushes data out to clients. It does not know what protocol version the client might have, so must be conservative and use the old payload limits. ie send no more than 256kb of

[libvirt] [PATCH] storage: fix file allocation behavior in file cloning

2013-09-30 Thread Oskari Saarenmaa
Fixed the safezero call for allocating the rest of the file after cloning an existing volume; it used to always use a zero offset, causing it to only allocate the beginning of the file. Also modified file creation to try to use fallocate(2) to pre-allocate disk space before copying any data to

Re: [libvirt] struct random on FreeBSD [was: FreeBSD-8.3 build failure for amd64/i386, build archive included]

2013-09-30 Thread Paul Eggert
On 09/30/13 09:09, Jason Helfman wrote: http://redports.org/~jgh/20130930154500-61365-148605/libvirt-1.1.2.log http://redports.org/%7Ejgh/20130930154500-61365-148605/libvirt-1.1.2.log However the build still fails, but looks to be a more standard failure internal compiler error:

Re: [libvirt] struct random on FreeBSD [was: FreeBSD-8.3 build failure for amd64/i386, build archive included]

2013-09-30 Thread Eric Blake
On 09/30/2013 10:09 AM, Jason Helfman wrote: So, what has to be included prior to stdlib.h for the forward declaration of struct random_data in that header to no longer be an incomplete type? Can you grep your system headers and find what all mentions struct random_data? In looking

Re: [libvirt] [PATCH] tests: Introduce qemucapabilitiestest

2013-09-30 Thread Eric Blake
On 09/27/2013 04:25 AM, Michal Privoznik wrote: This test is there to ensure that our capabilities detection code isn't broken somehow. How to gather test data: Firstly, the data is split into two separate files. The former (with suffix .replies) contains all the qemu replies. This is

Re: [libvirt] struct random on FreeBSD [was: FreeBSD-8.3 build failure for amd64/i386, build archive included]

2013-09-30 Thread Jason Helfman
On Mon, Sep 30, 2013 at 11:50 AM, Eric Blake ebl...@redhat.com wrote: On 09/30/2013 10:09 AM, Jason Helfman wrote: So, what has to be included prior to stdlib.h for the forward declaration of struct random_data in that header to no longer be an incomplete type? Can you grep your system

Re: [libvirt] [PATCH v2]lxc: do cleanup when failed to bind fs as read-only

2013-09-30 Thread Eric Blake
On 09/30/2013 03:06 AM, Chen Hanxiao wrote: From: Chen Hanxiao chenhanx...@cn.fujitsu.com We forgot to do cleanup when lxcContainerMountFSTmpfs failed to bind fs as read-only. v2: fix an indentation issue Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com ---

Re: [libvirt] [PATCH v2]lxc: do cleanup when failed to bind fs as read-only

2013-09-30 Thread Eric Blake
On 09/30/2013 01:29 PM, Eric Blake wrote: On 09/30/2013 03:06 AM, Chen Hanxiao wrote: From: Chen Hanxiao chenhanx...@cn.fujitsu.com We forgot to do cleanup when lxcContainerMountFSTmpfs failed to bind fs as read-only. v2: fix an indentation issue Oh, and a side note. Patch changelogs,

[libvirt] [PATCH] VMware: Add Fusion version test

2013-09-30 Thread Doug Goldstein
This adds a test for the version string of VMware Fusion. --- Not sure how but this was dropped from my series adding VMware Fusion that was added prior to 1.1.3-rc2. This should be safe for 1.1.3 and probably encouraged --- tests/vmwareverdata/fusion-5.0.3.txt | 3 +++ tests/vmwarevertest.c

Re: [libvirt] [PATCH] VMware: Add Fusion version test

2013-09-30 Thread Eric Blake
On 09/30/2013 04:00 PM, Doug Goldstein wrote: This adds a test for the version string of VMware Fusion. --- Not sure how but this was dropped from my series adding VMware Fusion that was added prior to 1.1.3-rc2. This should be safe for 1.1.3 and probably encouraged Indeed - more testing

Re: [libvirt] Availability of release candidate 2 of libvirt-1.1.3

2013-09-30 Thread Jason Helfman
On Sun, Sep 29, 2013 at 4:16 AM, Daniel Veillard veill...@redhat.comwrote: As planned I tagged rc2 in git and pushed tarball and rpms to the usual place at: ftp://libvirt.org/libvirt/ seems to behave correctly on my limited testing, please give it a try too. i will try to push 1.1.3

Re: [libvirt] Availability of release candidate 2 of libvirt-1.1.3

2013-09-30 Thread Doug Goldstein
On Sun, Sep 29, 2013 at 6:16 AM, Daniel Veillard veill...@redhat.com wrote: As planned I tagged rc2 in git and pushed tarball and rpms to the usual place at: ftp://libvirt.org/libvirt/ seems to behave correctly on my limited testing, please give it a try too. i will try to push 1.1.3

Re: [libvirt] [PATCH] VMware: Add Fusion version test

2013-09-30 Thread Doug Goldstein
On Mon, Sep 30, 2013 at 5:29 PM, Eric Blake ebl...@redhat.com wrote: On 09/30/2013 04:00 PM, Doug Goldstein wrote: This adds a test for the version string of VMware Fusion. --- Not sure how but this was dropped from my series adding VMware Fusion that was added prior to 1.1.3-rc2. This should

Re: [libvirt] struct random on FreeBSD [was: FreeBSD-8.3 build failure for amd64/i386, build archive included]

2013-09-30 Thread Doug Goldstein
On Mon, Sep 30, 2013 at 2:27 PM, Jason Helfman j...@freebsd.org wrote: On Mon, Sep 30, 2013 at 11:50 AM, Eric Blake ebl...@redhat.com wrote: On 09/30/2013 10:09 AM, Jason Helfman wrote: So, what has to be included prior to stdlib.h for the forward declaration of struct random_data in that