Re: [libvirt] [PATCH 1/2]cgroup: introduce kernel version check function for cgroup

2013-10-09 Thread Chen Hanxiao
-Original Message- From: Eric Blake [mailto:ebl...@redhat.com] Sent: Wednesday, October 09, 2013 11:49 AM To: Chen Hanxiao Cc: libvir-list@redhat.com Subject: Re: [libvirt] [PATCH 1/2]cgroup: introduce kernel version check function for cgroup On 10/08/2013 02:38 AM, Chen

Re: [libvirt] [PATCH 2/2]blkio: change the minimum weight according to kernel version

2013-10-09 Thread Chen Hanxiao
-Original Message- From: Eric Blake [mailto:ebl...@redhat.com] Sent: Wednesday, October 09, 2013 11:52 AM To: Chen Hanxiao Cc: libvir-list@redhat.com Subject: Re: [libvirt] [PATCH 2/2]blkio: change the minimum weight according to kernel version On 10/08/2013 02:38 AM, Chen

[libvirt] [PATCH]cgroup: fix a comment typo in vircgroup.c

2013-10-09 Thread Chen Hanxiao
From: Chen Hanxiao chenhanx...@cn.fujitsu.com s/shoule/should Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com --- src/util/vircgroup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index e99caf5..91b8704 100644 ---

Re: [libvirt] [PATCH] storage: Use bool instead of int

2013-10-09 Thread Ján Tomko
On 10/08/2013 07:43 PM, Eric Blake wrote: On 10/08/2013 11:29 AM, Ján Tomko wrote: Commit 532fef3 added two-state 'need_alloc' and exposed 'want_sparse' which also only has two states. Change their type from int to bool. --- src/storage/storage_backend.c | 12 ++-- 1 file changed,

Re: [libvirt] [PATCH 00/15] fix misuse of 'const fooPtr'

2013-10-09 Thread Daniel P. Berrange
On Tue, Oct 08, 2013 at 11:24:57AM -0600, Eric Blake wrote: Mostly cleanup, but at least one bug fix (xen was instantiating a memballoon device too early, during the post-parse callback of the first device rather than after all devices were known). Spawned by the conversation here:

Re: [libvirt] [PATCH] maint: make syntax-check default to a no-op on maint branches

2013-10-09 Thread Daniel P. Berrange
On Tue, Oct 08, 2013 at 08:45:23PM -0600, Eric Blake wrote: Maintenance branches cherry-pick some, but not all patches, and sometimes in different order, which means that 'make syntax-check' is likely to fail for hard-to-predict reasons. Yet having a common workflow makes it easier to switch

Re: [libvirt] [PATCH] LXC: Fix the output units of ram filesystem size

2013-10-09 Thread Ján Tomko
On 10/08/2013 07:43 PM, Eric Blake wrote: On 10/08/2013 11:28 AM, Ján Tomko wrote: Commit 76b644c added support for adding RAM filesystems to LXC domains, with a syntax of: source usage='10' unit='MiB'/ where default unit would be KiB per documentation, however the XML parser treated sizes

Re: [libvirt] [PATCH] LXC: Fix the output units of ram filesystem size

2013-10-09 Thread Daniel P. Berrange
On Wed, Oct 09, 2013 at 11:40:35AM +0200, Ján Tomko wrote: On 10/08/2013 07:43 PM, Eric Blake wrote: On 10/08/2013 11:28 AM, Ján Tomko wrote: Commit 76b644c added support for adding RAM filesystems to LXC domains, with a syntax of: source usage='10' unit='MiB'/ where default unit would

Re: [libvirt] [PATCH v3]LXC: Helper function for checking permission of dir when userns enabled

2013-10-09 Thread Chen Hanxiao
ping? -Original Message- From: Chen Hanxiao [mailto:chenhanx...@cn.fujitsu.com] Sent: Tuesday, September 10, 2013 4:18 PM To: libvir-list@redhat.com Cc: chenhanx...@cn.fujitsu.com Subject: [libvirt][PATCH v3]LXC: Helper function for checking permission of dir when userns enabled

[libvirt] [PATCH 1/3] Migration: Introduce VIR_MIGRATE_PARAM_LISTEN_ADDRESS

2013-10-09 Thread Michal Privoznik
The parameter allows overriding default listen address for '-incoming' cmd line argument on destination. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- include/libvirt/libvirt.h.in | 10 ++ tools/virsh-domain.c | 11 +++ tools/virsh.pod | 10

[libvirt] [PATCH 0/3] qemu:Allow users specify -incoming listen address

2013-10-09 Thread Michal Privoznik
However, if user provides a wrong address, the libvirtd dies horribly: Core was generated by `/home/zippy/tmp/libvirt.git/daemon/.libs/libvirtd --listen'. Program terminated with signal 11, Segmentation fault. #0 0x7f5c3859a7fc in qemuProcessHandleMonitorEOF (mon=0x7f5c24001870,

[libvirt] [PATCH 3/3] qemu_conf: Introduce listen_address

2013-10-09 Thread Michal Privoznik
This configuration knob is there to override default listen address for -incoming for all qemu domains. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/qemu/libvirtd_qemu.aug | 3 +++ src/qemu/qemu.conf | 6 ++ src/qemu/qemu_conf.c | 2 ++

[libvirt] [PATCH 2/3] qemu: Implement support for VIR_MIGRATE_PARAM_LISTEN_ADDRESS

2013-10-09 Thread Michal Privoznik
Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/qemu/qemu_driver.c| 26 + src/qemu/qemu_migration.c | 98 +-- src/qemu/qemu_migration.h | 13 --- 3 files changed, 96 insertions(+), 41 deletions(-) diff --git

Re: [libvirt] [PATCH 3/3] qemu_conf: Introduce listen_address

2013-10-09 Thread Daniel P. Berrange
On Wed, Oct 09, 2013 at 01:02:15PM +0200, Michal Privoznik wrote: This configuration knob is there to override default listen address for -incoming for all qemu domains. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/qemu/libvirtd_qemu.aug | 3 +++ src/qemu/qemu.conf

Re: [libvirt] [PATCH 1/3] Migration: Introduce VIR_MIGRATE_PARAM_LISTEN_ADDRESS

2013-10-09 Thread Daniel P. Berrange
On Wed, Oct 09, 2013 at 01:02:13PM +0200, Michal Privoznik wrote: The parameter allows overriding default listen address for '-incoming' cmd line argument on destination. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- include/libvirt/libvirt.h.in | 10 ++

Re: [libvirt] [PATCH 2/3] qemu: Implement support for VIR_MIGRATE_PARAM_LISTEN_ADDRESS

2013-10-09 Thread Daniel P. Berrange
On Wed, Oct 09, 2013 at 01:02:14PM +0200, Michal Privoznik wrote: Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/qemu/qemu_driver.c| 26 + src/qemu/qemu_migration.c | 98 +-- src/qemu/qemu_migration.h | 13 --- 3

[libvirt] [PATCH]docs: exit if failed to generate html

2013-10-09 Thread Chen Hanxiao
From: Chen Hanxiao chenhanx...@cn.fujitsu.com If xhtml1 dtd not install, some html will not be generated. If we 'make install', it will succeed and message missing XHTML1 DTD will be hide inside a large amount of logs. So exit when this occurs. Signed-off-by: Chen Hanxiao

Re: [libvirt] [PATCHv2] Ignore thin pool LVM devices.

2013-10-09 Thread Cole Robinson
On 10/08/2013 11:51 PM, Dusty Mabe wrote: This should resolve: https://bugzilla.redhat.com/show_bug.cgi?id=924672 For BZ 924672 the problem stems from the fact that thin pool logical volume devices show up in /sbin/lvs output just like normal logical volumes do. Libvirt incorrectly

Re: [libvirt] [PATCHv4 1/3] qemu: hostdev: Fix function spacing and header formatting

2013-10-09 Thread Laine Stump
On 10/08/2013 06:46 PM, Peter Krempa wrote: --- Notes: New in this version. src/qemu/qemu_hostdev.c | 60 ++--- 1 file changed, 42 insertions(+), 18 deletions(-) diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c index

Re: [libvirt] [PATCH 00/15] fix misuse of 'const fooPtr'

2013-10-09 Thread Eric Blake
On 10/09/2013 03:27 AM, Daniel P. Berrange wrote: On Tue, Oct 08, 2013 at 11:24:57AM -0600, Eric Blake wrote: Mostly cleanup, but at least one bug fix (xen was instantiating a memballoon device too early, during the post-parse callback of the first device rather than after all devices were

Re: [libvirt] [PATCH] maint: make syntax-check default to a no-op on maint branches

2013-10-09 Thread Eric Blake
On 10/09/2013 03:32 AM, Daniel P. Berrange wrote: On Tue, Oct 08, 2013 at 08:45:23PM -0600, Eric Blake wrote: Maintenance branches cherry-pick some, but not all patches, and sometimes in different order, which means that 'make syntax-check' is likely to fail for hard-to-predict reasons. Yet

Re: [libvirt] [PATCHv4 2/3] qemu: hostdev: Add checks if PCI passthrough is availabe in the host

2013-10-09 Thread Laine Stump
On 10/08/2013 06:46 PM, Peter Krempa wrote: Add code to check availability of PCI passhthrough using VFIO and the legacy KVM passthrough and use it when starting VMs and hotplugging devices to live machine. --- Notes: Version 4: - moved this function so that it can be called from

Re: [libvirt] [PATCHv4 2/3] qemu: hostdev: Add checks if PCI passthrough is availabe in the host

2013-10-09 Thread Christophe Fergeau
If it's not pushed already, there's a typo in the subject: 'availabe' Christophe On Tue, Oct 08, 2013 at 05:46:57PM +0200, Peter Krempa wrote: Add code to check availability of PCI passhthrough using VFIO and the legacy KVM passthrough and use it when starting VMs and hotplugging devices to

Re: [libvirt] [PATCH] maint: make syntax-check default to a no-op on maint branches

2013-10-09 Thread Daniel P. Berrange
On Wed, Oct 09, 2013 at 06:53:00AM -0600, Eric Blake wrote: On 10/09/2013 03:32 AM, Daniel P. Berrange wrote: On Tue, Oct 08, 2013 at 08:45:23PM -0600, Eric Blake wrote: Maintenance branches cherry-pick some, but not all patches, and sometimes in different order, which means that 'make

[libvirt] [PATCHv2] LXC: Fix handling of RAM filesystem size units

2013-10-09 Thread Ján Tomko
Since 76b644c when the support for RAM filesystems was introduced, libvirt accepted the following XML: source usage='1024' unit='KiB'/ This was parsed correctly and internally stored in bytes, but it was formatted as (with an extra 's'): source usage='1024' units='KiB'/ When read again, this was

Re: [libvirt] [PATCHv2] LXC: Fix handling of RAM filesystem size units

2013-10-09 Thread Daniel P. Berrange
On Wed, Oct 09, 2013 at 03:15:36PM +0200, Ján Tomko wrote: Since 76b644c when the support for RAM filesystems was introduced, libvirt accepted the following XML: source usage='1024' unit='KiB'/ This was parsed correctly and internally stored in bytes, but it was formatted as (with an extra

[libvirt] [PATCHv2 2/4] virsocket: Introduce virSocketAddrIsWildcard

2013-10-09 Thread Michal Privoznik
This function takes exactly one argument: an address to check. It returns true, iff the address is an IPv4 or IPv6 address in numeric format, false if otherwise (e.g. for examplehost). Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/libvirt_private.syms | 1 +

[libvirt] [PATCHv2 0/4] qemu: Allow users specify -incoming listen address

2013-10-09 Thread Michal Privoznik
v2 for my previous attempt: https://www.redhat.com/archives/libvir-list/2013-October/msg00400.html diff to v1: -Check if listenAddress is a numeric IPv4 or IPv6 prior parsing it -enclose all IPv6 addresses in angle brackets 1/4 has been ACKed already Michal Privoznik (4): Migration:

[libvirt] [PATCHv2 4/4] qemu_conf: Introduce migration_address

2013-10-09 Thread Michal Privoznik
This configuration knob is there to override default listen address for -incoming for all qemu domains. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/qemu/libvirtd_qemu.aug | 3 +++ src/qemu/qemu.conf | 6 ++ src/qemu/qemu_conf.c | 2 ++

[libvirt] [PATCHv2 3/4] qemu: Implement support for VIR_MIGRATE_PARAM_LISTEN_ADDRESS

2013-10-09 Thread Michal Privoznik
Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/qemu/qemu_driver.c| 26 +++ src/qemu/qemu_migration.c | 113 +++--- src/qemu/qemu_migration.h | 13 -- 3 files changed, 103 insertions(+), 49 deletions(-) diff --git

[libvirt] [PATCHv2 1/4] Migration: Introduce VIR_MIGRATE_PARAM_LISTEN_ADDRESS

2013-10-09 Thread Michal Privoznik
The parameter allows overriding default listen address for '-incoming' cmd line argument on destination. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- ACKed already, I'm sending it just for a completeness-sake. include/libvirt/libvirt.h.in | 10 ++ tools/virsh-domain.c

Re: [libvirt] [PATCHv2] LXC: Fix handling of RAM filesystem size units

2013-10-09 Thread Eric Blake
On 10/09/2013 07:22 AM, Daniel P. Berrange wrote: be used with codetype='mount'/code. The codeusage/code attribute -is used with codetype='ram'/code to set the memory limit in KB. +is used with codetype='ram'/code to set the memory limit KiB, unless +units

Re: [libvirt] [Users] Migration issues with ovirt 3.3

2013-10-09 Thread Dan Kenigsberg
On Wed, Oct 09, 2013 at 02:42:22PM +0200, Gianluca Cecchi wrote: On Tue, Oct 8, 2013 at 10:40 AM, Dan Kenigsberg wrote: But migration still fails It seems like an unrelated failure. I do not know what's blocking migration traffic. Could you see if libvirtd.log and qemu logs at

Re: [libvirt] [PATCHv2] LXC: Fix handling of RAM filesystem size units

2013-10-09 Thread Daniel P. Berrange
On Wed, Oct 09, 2013 at 07:36:16AM -0600, Eric Blake wrote: On 10/09/2013 07:22 AM, Daniel P. Berrange wrote: be used with codetype='mount'/code. The codeusage/code attribute -is used with codetype='ram'/code to set the memory limit in KB. +is used with

Re: [libvirt] [PATCH]docs: exit if failed to generate html

2013-10-09 Thread Eric Blake
On 10/09/2013 05:27 AM, Chen Hanxiao wrote: From: Chen Hanxiao chenhanx...@cn.fujitsu.com If xhtml1 dtd not install, some html will not be generated. If we 'make install', it will succeed and message missing XHTML1 DTD will be hide inside a large amount of logs. So exit when this occurs.

Re: [libvirt] [PATCH 1/6] AArch64: Add AArch64 architecture to list of valid arches.

2013-10-09 Thread Cole Robinson
On 10/08/2013 09:49 AM, Pranavkumar Sawargaonkar wrote: Adding AArch64(ARMv8 64bit) to the current list of valid architectures. For now, AArch64 name would imply AArch64 LE mode only. In future, we might have separate names for AArch64 LE and BE. Signed-off-by: Anup Patel

Re: [libvirt] [PATCH 2/6] AArch64: CPU Support for AArch64 (ARMv8 64bit).

2013-10-09 Thread Cole Robinson
On 10/08/2013 09:49 AM, Pranavkumar Sawargaonkar wrote: Adding CPU encoder/decoder for AArch64. Signed-off-by: Anup Patel anup.pa...@linaro.org Signed-off-by: Pranavkumar Sawargaonkar pranavku...@linaro.org --- src/Makefile.am |1 + src/cpu/cpu.c |2 ++

Re: [libvirt] [PATCHv2] LXC: Fix handling of RAM filesystem size units

2013-10-09 Thread Eric Blake
On 10/09/2013 07:46 AM, Daniel P. Berrange wrote: Consistent output, as long as we accept exactly one of the two names on input, seems reasonable to me. Then again, if we released documentation of one particular spelling, it's better to preserve that spelling for back-compat, even if

Re: [libvirt] [PATCH 6/6] AArch64: Add qemu capabilities schemeta for test.

2013-10-09 Thread Cole Robinson
On 10/08/2013 09:49 AM, Pranavkumar Sawargaonkar wrote: Add qemu AArch64 capabilities schemeta in caps-qemu-kvm.xml. Signed-off-by: Anup Patel anup.pa...@linaro.org Signed-off-by: Pranavkumar Sawargaonkar pranavku...@linaro.org --- tests/capabilityschemadata/caps-qemu-kvm.xml | 11

Re: [libvirt] [PATCH 5/6] Add parsing of AArch64 qemu capabilities.

2013-10-09 Thread Cole Robinson
On 10/08/2013 09:49 AM, Pranavkumar Sawargaonkar wrote: Parse qemu capabilities AArch64 just like arm 32bit. Signed-off-by: Anup Patel anup.pa...@linaro.org Signed-off-by: Pranavkumar Sawargaonkar pranavku...@linaro.org --- src/qemu/qemu_capabilities.c |4 1 file changed, 4

Re: [libvirt] [PATCH 4/6] Implement minimal sysinfo for AArch64 platforms.

2013-10-09 Thread Cole Robinson
On 10/08/2013 09:49 AM, Pranavkumar Sawargaonkar wrote: Implement the bare minimal sysinfo for AArch64 platforms by reading the CPU models from /proc/cpuinfo. Signed-off-by: Anup Patel anup.pa...@linaro.org Signed-off-by: Pranavkumar Sawargaonkar pranavku...@linaro.org ---

Re: [libvirt] [PATCH 3/6] AArch64: Parse cputopology from /proc/cpuinfo.

2013-10-09 Thread Cole Robinson
On 10/08/2013 09:49 AM, Pranavkumar Sawargaonkar wrote: CPU parser for AArch64. Showing cputopology in arm64 linux is work-in-progress so for now all AArch64 cpus belong to same socket (like PPC). Also we parse BogoMIPS same like arm 32bit. Signed-off-by: Anup Patel anup.pa...@linaro.org

Re: [libvirt] [PATCHv4 3/3] qemu: Prefer VFIO for PCI device passthrough

2013-10-09 Thread Laine Stump
On 10/08/2013 06:46 PM, Peter Krempa wrote: Prefer using VFIO (if available) to the legacy KVM device passthrough. With this patch a PCI passthrough device without the driver configured will be started with VFIO if it's available on the host. If not legacy KVM passthrough is checked and error

Re: [libvirt] [PATCH 0/6] AArch64 support for libvirt.

2013-10-09 Thread Daniel P. Berrange
On Tue, Oct 08, 2013 at 07:19:05PM +0530, Pranavkumar Sawargaonkar wrote: This patchset extends libvirt for AArch64 (armv8a). All patches have been tested on APM X-Gene SoC and we are able to run libvirtd on APM X-Gene SOC and spawn VMs remotely using virsh and virt-manager. What is the

[libvirt] [PATCHv3] LXC: Fix handling of RAM filesystem size units

2013-10-09 Thread Ján Tomko
Since 76b644c when the support for RAM filesystems was introduced, libvirt accepted the following XML: source usage='1024' unit='KiB'/ This was parsed correctly and internally stored in bytes, but it was formatted as (with an extra 's'): source usage='1024' units='KiB'/ When read again, this was

Re: [libvirt] [PATCH 0/6] AArch64 support for libvirt.

2013-10-09 Thread Cole Robinson
On 10/09/2013 10:13 AM, Daniel P. Berrange wrote: On Tue, Oct 08, 2013 at 07:19:05PM +0530, Pranavkumar Sawargaonkar wrote: This patchset extends libvirt for AArch64 (armv8a). All patches have been tested on APM X-Gene SoC and we are able to run libvirtd on APM X-Gene SOC and spawn VMs

[libvirt] [PATCH] storage_backend: Fix issue with allocation of 0 length volume

2013-10-09 Thread John Ferlan
Commit id '532fef36' added a call to fallocate() and some error handling based on whether or not the function existed. This new call resulted in libvirt-cim/cimtest failures when attempting to create a volume with 0 (zero) allocation value. The failure is logged as: Oct 9 07:51:33 localhost

Re: [libvirt] [PATCH 2/6] AArch64: CPU Support for AArch64 (ARMv8 64bit).

2013-10-09 Thread Daniel P. Berrange
On Tue, Oct 08, 2013 at 07:19:07PM +0530, Pranavkumar Sawargaonkar wrote: Adding CPU encoder/decoder for AArch64. Signed-off-by: Anup Patel anup.pa...@linaro.org Signed-off-by: Pranavkumar Sawargaonkar pranavku...@linaro.org --- src/Makefile.am |1 + src/cpu/cpu.c |2

Re: [libvirt] [PATCH 3/6] AArch64: Parse cputopology from /proc/cpuinfo.

2013-10-09 Thread Daniel P. Berrange
On Tue, Oct 08, 2013 at 07:19:08PM +0530, Pranavkumar Sawargaonkar wrote: CPU parser for AArch64. Showing cputopology in arm64 linux is work-in-progress so for now all AArch64 cpus belong to same socket (like PPC). Also we parse BogoMIPS same like arm 32bit. Signed-off-by: Anup Patel

Re: [libvirt] [PATCH 4/6] Implement minimal sysinfo for AArch64 platforms.

2013-10-09 Thread Daniel P. Berrange
On Tue, Oct 08, 2013 at 07:19:09PM +0530, Pranavkumar Sawargaonkar wrote: Implement the bare minimal sysinfo for AArch64 platforms by reading the CPU models from /proc/cpuinfo. Signed-off-by: Anup Patel anup.pa...@linaro.org Signed-off-by: Pranavkumar Sawargaonkar pranavku...@linaro.org ---

Re: [libvirt] [PATCH 5/6] Add parsing of AArch64 qemu capabilities.

2013-10-09 Thread Daniel P. Berrange
On Tue, Oct 08, 2013 at 07:19:10PM +0530, Pranavkumar Sawargaonkar wrote: Parse qemu capabilities AArch64 just like arm 32bit. Signed-off-by: Anup Patel anup.pa...@linaro.org Signed-off-by: Pranavkumar Sawargaonkar pranavku...@linaro.org --- src/qemu/qemu_capabilities.c |4 1

Re: [libvirt] [Users] Migration issues with ovirt 3.3

2013-10-09 Thread Gianluca Cecchi
On Wed, Oct 9, 2013 at 3:43 PM, Dan Kenigsberg wrote: On Wed, Oct 09, 2013 at 02:42:22PM +0200, Gianluca Cecchi wrote: On Tue, Oct 8, 2013 at 10:40 AM, Dan Kenigsberg wrote: But migration still fails It seems like an unrelated failure. I do not know what's blocking migration

Re: [libvirt] [PATCH 6/6] AArch64: Add qemu capabilities schemeta for test.

2013-10-09 Thread Daniel P. Berrange
On Tue, Oct 08, 2013 at 07:19:11PM +0530, Pranavkumar Sawargaonkar wrote: Add qemu AArch64 capabilities schemeta in caps-qemu-kvm.xml. Signed-off-by: Anup Patel anup.pa...@linaro.org Signed-off-by: Pranavkumar Sawargaonkar pranavku...@linaro.org ---

Re: [libvirt] [PATCH] storage_backend: Fix issue with allocation of 0 length volume

2013-10-09 Thread Daniel P. Berrange
On Wed, Oct 09, 2013 at 10:17:19AM -0400, John Ferlan wrote: Commit id '532fef36' added a call to fallocate() and some error handling based on whether or not the function existed. This new call resulted in libvirt-cim/cimtest failures when attempting to create a volume with 0 (zero) allocation

Re: [libvirt] [PATCHv3] LXC: Fix handling of RAM filesystem size units

2013-10-09 Thread Eric Blake
On 10/09/2013 08:13 AM, Ján Tomko wrote: Since 76b644c when the support for RAM filesystems was introduced, libvirt accepted the following XML: source usage='1024' unit='KiB'/ This was parsed correctly and internally stored in bytes, but it was formatted as (with an extra 's'): source

Re: [libvirt] [PATCH 1/6] AArch64: Add AArch64 architecture to list of valid arches.

2013-10-09 Thread Daniel P. Berrange
On Tue, Oct 08, 2013 at 07:19:06PM +0530, Pranavkumar Sawargaonkar wrote: Adding AArch64(ARMv8 64bit) to the current list of valid architectures. For now, AArch64 name would imply AArch64 LE mode only. In future, we might have separate names for AArch64 LE and BE. Presumably the kernel has

Re: [libvirt] [PATCH 1/2] virFileFsType: get filesystem type of a given path

2013-10-09 Thread Michal Privoznik
On 10.09.2013 20:57, Oskari Saarenmaa wrote: This can be used by storage pools to figure out which actions are available on various paths (for example subvolumes when running on btrfs.) Signed-off-by: Oskari Saarenmaa o...@ohmu.fi --- src/libvirt_private.syms | 1 + src/util/virfile.c

Re: [libvirt] [PATCH 2/2] storage: btrfs subvolumes for directory pools

2013-10-09 Thread Michal Privoznik
On 10.09.2013 20:59, Oskari Saarenmaa wrote: This commit adds support for btrfs subvolumes as directory volumes. The directory storage pool can be used to manage btrfs subvolumes on an existing btrfs filesystem. The driver can create new blank subvolumes and snapshots of existing subvolumes

Re: [libvirt] [Users] Migration issues with ovirt 3.3

2013-10-09 Thread Dan Kenigsberg
On Wed, Oct 09, 2013 at 04:52:20PM +0200, Gianluca Cecchi wrote: On Wed, Oct 9, 2013 at 3:43 PM, Dan Kenigsberg wrote: On Wed, Oct 09, 2013 at 02:42:22PM +0200, Gianluca Cecchi wrote: On Tue, Oct 8, 2013 at 10:40 AM, Dan Kenigsberg wrote: But migration still fails It

Re: [libvirt] [PATCH]cgroup: fix a comment typo in vircgroup.c

2013-10-09 Thread Michal Privoznik
On 09.10.2013 09:09, Chen Hanxiao wrote: From: Chen Hanxiao chenhanx...@cn.fujitsu.com s/shoule/should Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com --- src/util/vircgroup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/vircgroup.c

Re: [libvirt] [PATCHv3] LXC: Fix handling of RAM filesystem size units

2013-10-09 Thread Ján Tomko
On 10/09/2013 04:58 PM, Eric Blake wrote: On 10/09/2013 08:13 AM, Ján Tomko wrote: Since 76b644c when the support for RAM filesystems was introduced, libvirt accepted the following XML: source usage='1024' unit='KiB'/ This was parsed correctly and internally stored in bytes, but it was

Re: [libvirt] [Users] Migration issues with ovirt 3.3

2013-10-09 Thread Daniel Berteaud
Le mercredi 09 octobre 2013 à 16:18 +0100, Dan Kenigsberg a écrit : Since libvirt has been using this port range first, would you open a bug on gluster to avoid it? Already done: https://bugzilla.redhat.com/show_bug.cgi?id=987555 (not using ovirt, but the problem is easy to trigger as soon

Re: [libvirt] [PATCH 2/2] storage: btrfs subvolumes for directory pools

2013-10-09 Thread Michal Privoznik
On 09.10.2013 17:15, Michal Privoznik wrote: On 10.09.2013 20:59, Oskari Saarenmaa wrote: This commit adds support for btrfs subvolumes as directory volumes. The directory storage pool can be used to manage btrfs subvolumes on an existing btrfs filesystem. The driver can create new blank

[libvirt] [PATCH 3/4] qemu: managedsave: Add support for compressing managed save images

2013-10-09 Thread Peter Krempa
The regular save image code has the support to compress images using a specified algorithm. This was not implemented for managed save although it shares most of the backend code. --- src/qemu/qemu.conf | 6 ++ src/qemu/qemu_conf.c | 2 ++ src/qemu/qemu_conf.h | 1 +

[libvirt] [PATCH 1/4] qemu: Fix coding style in qemuDomainSaveFlags()

2013-10-09 Thread Peter Krempa
Avoid mixed brace style in an if statement and fix formatting of error messages. --- src/qemu/qemu_driver.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index c71aecc..b9f340c 100644 ---

[libvirt] [PATCH 2/4] qemu: refactor qemuCompressProgramAvailable()

2013-10-09 Thread Peter Krempa
--- src/qemu/qemu_driver.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index b9f340c..cfdbb9a 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -3138,18 +3138,18 @@ cleanup: } /* Returns

Re: [libvirt] [PATCH 3/4] qemu: managedsave: Add support for compressing managed save images

2013-10-09 Thread Daniel P. Berrange
On Wed, Oct 09, 2013 at 06:31:31PM +0200, Peter Krempa wrote: The regular save image code has the support to compress images using a specified algorithm. This was not implemented for managed save although it shares most of the backend code. --- src/qemu/qemu.conf | 6 ++

Re: [libvirt] [PATCH 3/4] qemu: managedsave: Add support for compressing managed save images

2013-10-09 Thread Peter Krempa
On 10/09/13 18:33, Daniel P. Berrange wrote: On Wed, Oct 09, 2013 at 06:31:31PM +0200, Peter Krempa wrote: The regular save image code has the support to compress images using a specified algorithm. This was not implemented for managed save although it shares most of the backend code. ---

Re: [libvirt] [PATCH 4/4] qemu: snapshot: Add support for compressing external snapshot memory

2013-10-09 Thread Daniel P. Berrange
On Wed, Oct 09, 2013 at 06:31:32PM +0200, Peter Krempa wrote: The regular save image code has the support to compress images using a specified algorithm. This was not implemented for external checkpoints although it shares most of the backend code. Resolves:

Re: [libvirt] [PATCH 1/4] qemu: Fix coding style in qemuDomainSaveFlags()

2013-10-09 Thread Eric Blake
On 10/09/2013 10:31 AM, Peter Krempa wrote: Avoid mixed brace style in an if statement and fix formatting of error messages. --- src/qemu/qemu_driver.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) ACK. -- Eric Blake eblake redhat com+1-919-301-3266

Re: [libvirt] [PATCH 3/4] qemu: managedsave: Add support for compressing managed save images

2013-10-09 Thread Eric Blake
On 10/09/2013 10:33 AM, Daniel P. Berrange wrote: On Wed, Oct 09, 2013 at 06:31:31PM +0200, Peter Krempa wrote: The regular save image code has the support to compress images using a specified algorithm. This was not implemented for managed save although it shares most of the backend code.

[libvirt] [PATCH 4/4] qemu: snapshot: Add support for compressing external snapshot memory

2013-10-09 Thread Peter Krempa
The regular save image code has the support to compress images using a specified algorithm. This was not implemented for external checkpoints although it shares most of the backend code. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1017227 --- src/qemu/qemu.conf | 6 ++

[libvirt] [PATCH 0/4] Add support for compression of managedsave and external snapshot memory images

2013-10-09 Thread Peter Krempa
plus a few refactors. Peter Krempa (4): qemu: Fix coding style in qemuDomainSaveFlags() qemu: refactor qemuCompressProgramAvailable() qemu: managedsave: Add support for compressing managed save images qemu: snapshot: Add support for compressing external snapshot memory

Re: [libvirt] [RFC] net-dhcp-leases: virNetworkDHCPLeases struct design

2013-10-09 Thread Nehal J Wani
Since no one likes the idea of having a union, but we do want to support dhcpv6, following is the new design: struct _virNetworkDHCPLeases { char *interface;/* Network interface name (non-null) */ long long expirytime; /* Seconds since epoch (non-null) */ int

Re: [libvirt] [PATCH 0/6] AArch64 support for libvirt.

2013-10-09 Thread Anup Patel
On Wed, Oct 9, 2013 at 8:01 PM, Cole Robinson crobi...@redhat.com wrote: On 10/09/2013 10:13 AM, Daniel P. Berrange wrote: On Tue, Oct 08, 2013 at 07:19:05PM +0530, Pranavkumar Sawargaonkar wrote: This patchset extends libvirt for AArch64 (armv8a). All patches have been tested on APM X-Gene

Re: [libvirt] [PATCH 2/4] qemu: refactor qemuCompressProgramAvailable()

2013-10-09 Thread Eric Blake
On 10/09/2013 10:31 AM, Peter Krempa wrote: --- src/qemu/qemu_driver.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) ACK. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP

Re: [libvirt] [Users] Migration issues with ovirt 3.3

2013-10-09 Thread Gianluca Cecchi
On Wed, Oct 9, 2013 at 5:52 PM, Daniel Berteaud wrote: Le mercredi 09 octobre 2013 à 16:18 +0100, Dan Kenigsberg a écrit : Since libvirt has been using this port range first, would you open a bug on gluster to avoid it? Already done: https://bugzilla.redhat.com/show_bug.cgi?id=987555

[libvirt] [PATCH] esx: Fix floppy.fileName handling in the vmx file parser

2013-10-09 Thread Geoff Hickey
The vmx file parsing code was reporting errors when parsing floppy.fileName entries if the filename didn't end in .flp. There is no such restriction in ESX; even using the GUI to configure floppy filenames you can specify any arbitrary file with any extension. Fix by changing the vmx parsing code

Re: [libvirt] [PATCH]docs: exit if failed to generate html

2013-10-09 Thread Chen Hanxiao
-Original Message- From: Eric Blake [mailto:ebl...@redhat.com] Sent: Wednesday, October 09, 2013 9:51 PM To: Chen Hanxiao Cc: libvir-list@redhat.com Subject: Re: [libvirt] [PATCH]docs: exit if failed to generate html On 10/09/2013 05:27 AM, Chen Hanxiao wrote: From: Chen