[libvirt] QEMU GSoC featured on Google Open Source Blog

2013-10-11 Thread Stefan Hajnoczi
Stephanie Taylor at the Google Open Source Blog has helped us publish a post that features two projects from this year's Google Summer of Code: http://google-opensource.blogspot.de/2013/10/google-summer-of-code-veteran-orgs-qemu.html Mike and Osier contributed summaries of the "QEMU Integrated Co

Re: [libvirt] [BUG] libvirtd on destination crash frequently while migrating vms concurrently

2013-10-11 Thread Wangyufei (A)
Thanks a lot, I'll have a try. > -Original Message- > From: Michal Privoznik [mailto:mpriv...@redhat.com] > Sent: Friday, October 11, 2013 8:58 PM > To: Wangyufei (A) > Cc: libvir-list@redhat.com; jdene...@redhat.com; Wangrui (K) > Subject: Re: [libvirt] [BUG] libvirtd on destination crash

Re: [libvirt] [Users] Migration issues with ovirt 3.3

2013-10-11 Thread Dan Kenigsberg
On Thu, Oct 10, 2013 at 08:40:29AM +0200, Jiri Denemark wrote: > On Wed, Oct 09, 2013 at 16:18:25 +0100, Dan Kenigsberg wrote: > > On Wed, Oct 09, 2013 at 04:52:20PM +0200, Gianluca Cecchi wrote: > > > On Wed, Oct 9, 2013 at 3:43 PM, Dan Kenigsberg wrote: > > > > On Wed, Oct 09, 2013 at 02:42:22PM

Re: [libvirt] [PATCH 0/3] Improve LXC startup error reporting

2013-10-11 Thread Michal Privoznik
On 11.10.2013 18:53, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > LXC has long suffered from pretty poor error reporting of failures > at startup. This series addresses those problems. > > Daniel P. Berrange (3): > Fix exit status of lxc controller > Improve error reporting wit

[libvirt] [PATCH 0/3] Improve LXC startup error reporting

2013-10-11 Thread Daniel P. Berrange
From: "Daniel P. Berrange" LXC has long suffered from pretty poor error reporting of failures at startup. This series addresses those problems. Daniel P. Berrange (3): Fix exit status of lxc controller Improve error reporting with LXC controller Don't ignore all dbus connection errors sr

Re: [libvirt] [PATCH 1/3] Allow use of a private dbus bus connection

2013-10-11 Thread Eric Blake
On 10/11/2013 10:50 AM, Daniel P. Berrange wrote: > On Fri, Oct 11, 2013 at 10:36:37AM -0600, Eric Blake wrote: >> On 10/11/2013 09:19 AM, Daniel P. Berrange wrote: >>> From: "Daniel P. Berrange" >>> >>> The dbus_bus_get() function returns a shared bus connection that >>> all libraries in a proces

[libvirt] [PATCH 3/3] Don't ignore all dbus connection errors

2013-10-11 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Previous commit commit 7ada155cdf2bbfac16ce08f64abb455a940e2cf7 Author: Gao feng Date: Wed Sep 11 11:15:02 2013 +0800 DBus: introduce virDBusIsServiceEnabled Made the cgroups code fallback to non-systemd based setup when dbus is not running. It was too b

[libvirt] [PATCH 2/3] Improve error reporting with LXC controller

2013-10-11 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The LXC code would read the log file if an LXC guest failed to startup. There were a number of failure cases where the guest will not start and libvirtd never gets as far as looking at the log file. Fix this by replacing some earlier generic errors with messages from t

[libvirt] [PATCH 1/3] Fix exit status of lxc controller

2013-10-11 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The LXC controller main() method initialized 'rc' to 1 rather than '-1'. In the cleanup path it will print any error to stderr, if-and-only-if rc < 0. Hence the incorrect initialization caused errors to be lost. Signed-off-by: Daniel P. Berrange --- src/lxc/lxc_contr

Re: [libvirt] [PATCH 1/3] Allow use of a private dbus bus connection

2013-10-11 Thread Daniel P. Berrange
On Fri, Oct 11, 2013 at 10:36:37AM -0600, Eric Blake wrote: > On 10/11/2013 09:19 AM, Daniel P. Berrange wrote: > > From: "Daniel P. Berrange" > > > > The dbus_bus_get() function returns a shared bus connection that > > all libraries in a process can use. You are forbidden from calling > > close

Re: [libvirt] [PATCH 3/3] Make LXC controller use a private dbus connection & close it

2013-10-11 Thread Eric Blake
On 10/11/2013 09:19 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > The LXC controller uses dbus to talk to systemd to create > cgroups. This means that each LXC controller instance has > a dbus connection. The DBus daemon is limited to 256 > connections by default and we want to b

Re: [libvirt] [PATCH 2/3] Add a method for closing the dbus system bus connection

2013-10-11 Thread Eric Blake
On 10/11/2013 09:19 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > If the dbus system bus connection is marked as private, then > allow it to be closed. > > Signed-off-by: Daniel P. Berrange > --- > src/libvirt_private.syms | 1 + > src/util/virdbus.c | 12 >

Re: [libvirt] [PATCH 1/3] Allow use of a private dbus bus connection

2013-10-11 Thread Eric Blake
On 10/11/2013 09:19 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > The dbus_bus_get() function returns a shared bus connection that > all libraries in a process can use. You are forbidden from calling > close on this connection though, since you can never know if any > other code

Re: [libvirt] [PATCH] Fix flaw in detecting log format

2013-10-11 Thread Eric Blake
On 10/11/2013 10:14 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > The log message regex has been > > [0-9]{4}-[0-9]{2}-[0-9]{2} [0-9]{2}:[0-9]{2}:[0-9]{2}\.[0-9]{3}\+[0-9]{4}: > [0-9]+: debug|info|warning|error : > > > Which is clearly not what it should have done. This caus

[libvirt] [PATCH] Fix flaw in detecting log format

2013-10-11 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The log message regex has been [0-9]{4}-[0-9]{2}-[0-9]{2} [0-9]{2}:[0-9]{2}:[0-9]{2}\.[0-9]{3}\+[0-9]{4}: [0-9]+: debug|info|warning|error : The precedence of '|' is high though, so this is equivalent to matching [0-9]{4}-[0-9]{2}-[0-9]{2} [0-9]{2}:[0-9]{2}:[0-9]

[libvirt] [PATCH 2/3] Add a method for closing the dbus system bus connection

2013-10-11 Thread Daniel P. Berrange
From: "Daniel P. Berrange" If the dbus system bus connection is marked as private, then allow it to be closed. Signed-off-by: Daniel P. Berrange --- src/libvirt_private.syms | 1 + src/util/virdbus.c | 12 src/util/virdbus.h | 1 + 3 files changed, 14 insertions(+)

[libvirt] [PATCH 3/3] Make LXC controller use a private dbus connection & close it

2013-10-11 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The LXC controller uses dbus to talk to systemd to create cgroups. This means that each LXC controller instance has a dbus connection. The DBus daemon is limited to 256 connections by default and we want to be able to run many 1000 of containers. While the dbus limit c

[libvirt] [PATCH 0/3] Fix scalability of LXC containers

2013-10-11 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Since we switched to use systemd for creating cgroups we have a scalability problem with LXC out of the box. Only ~230 containers can be created before we hit the default dbus-daemon connection limit. This series makes libvirt_lxc close its dbus connection once the gues

[libvirt] [PATCH 1/3] Allow use of a private dbus bus connection

2013-10-11 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The dbus_bus_get() function returns a shared bus connection that all libraries in a process can use. You are forbidden from calling close on this connection though, since you can never know if any other code might be using it. Add an option to use private dbus bus conn

Re: [libvirt] [PATCH] nwfilter: fix a typo in nwfilter_gentech_driver.c

2013-10-11 Thread Eric Blake
On 10/11/2013 08:07 AM, Hongwei Bi wrote: > s/occcurred/occurred > > --- > src/nwfilter/nwfilter_gentech_driver.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) ACK and pushed. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org si

Re: [libvirt] [PATCH] rpc: Fix getsockopt on Snow Leopard and lower

2013-10-11 Thread Eric Blake
On 10/11/2013 08:06 AM, Doug Goldstein wrote: > Since 5a468b38b6 we use SOL_LOCAL for the 2nd argument of getsockopt() > however Lion added the define SOL_LOCAL set to 0, which is the value to > the 2nd argument of getsockopt() for Unix sockets on Mac OS X. So > instead of using the define just pas

[libvirt] [PATCH] nwfilter: fix a typo in nwfilter_gentech_driver.c

2013-10-11 Thread Hongwei Bi
s/occcurred/occurred --- src/nwfilter/nwfilter_gentech_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/nwfilter/nwfilter_gentech_driver.c b/src/nwfilter/nwfilter_gentech_driver.c index 5961165..16878a4 100644 --- a/src/nwfilter/nwfilter_gentech_driver.c +++ b/src

[libvirt] [PATCH] rpc: Fix getsockopt on Snow Leopard and lower

2013-10-11 Thread Doug Goldstein
Since 5a468b38b6 we use SOL_LOCAL for the 2nd argument of getsockopt() however Lion added the define SOL_LOCAL set to 0, which is the value to the 2nd argument of getsockopt() for Unix sockets on Mac OS X. So instead of using the define just pass 0 so we restore compatibility with Snow Leopard and

[libvirt] [PATCH 3/3]cgroup: leave cgroup value checking to kernel

2013-10-11 Thread Chen Hanxiao
From: Chen Hanxiao Values for cgroup may change in the future kernels. We should not hard-coded it. Leave this job to kernel, who will take care of them. Signed-off-by: Chen Hanxiao --- src/util/vircgroup.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/src/util/vircgroup.c

[libvirt] [PATCH 2/3]cgroup: show error when EINVAL caught

2013-10-11 Thread Chen Hanxiao
From: Chen Hanxiao When EINVAL caught, tell user that what values are invalid for what field. Signed-off-by: Chen Hanxiao --- src/util/vircgroup.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index e99caf5..a98bd63

[libvirt] [PATCH 0/3] leave cgroup value checking to kernel

2013-10-11 Thread Chen Hanxiao
From: Chen Hanxiao Since 2.6.39, kernel changed the minimum weight of device blkio while libvirt hard-coded the value range checking. So we should leave the job of checking to kernel. Chen Hanxiao (3): [libvirt]docs: change the minimum weight description for blkio [libvirt]cgroup: show error

[libvirt] [PATCH 1/3]docs: change the minimum weight description for blkio

2013-10-11 Thread Chen Hanxiao
From: Chen Hanxiao Since 2.6.39, kernel changed the minimum weight of device blkio. Update related docs. Signed-off-by: Gao feng Signed-off-by: Chen Hanxiao --- docs/formatdomain.html.in | 6 -- tools/virsh.pod | 11 ++- 2 files changed, 10 insertions(+), 7 deletions(-)

Re: [libvirt] [PATCH] qemu: Include listenAddress in debug prints

2013-10-11 Thread Eric Blake
On 10/11/2013 06:51 AM, Michal Privoznik wrote: > After my patches, some functions gained one more argument > (@listenAddress) which wasn't included in debug printing of > arguments they were called with. Functions in question are: > qemuMigrationPrepareDirect and qemuMigrationPerform. > > Signed-

Re: [libvirt] [BUG] libvirtd on destination crash frequently while migrating vms concurrently

2013-10-11 Thread Michal Privoznik
On 27.09.2013 09:55, Wangyufei (A) wrote: > Hello, > I found a problem that libvirtd on destination crash frequently while > migrating vms concurrently. For example, if I migrate 10 vms > concurrently ceaselessly, then after about 30 minutes the libvirtd on > destination will crash. So I analyzed a

[libvirt] [PATCH] qemu: Include listenAddress in debug prints

2013-10-11 Thread Michal Privoznik
After my patches, some functions gained one more argument (@listenAddress) which wasn't included in debug printing of arguments they were called with. Functions in question are: qemuMigrationPrepareDirect and qemuMigrationPerform. Signed-off-by: Michal Privoznik --- src/qemu/qemu_migration.c | 8

Re: [libvirt] [PATCH] Fix: helper function virCompareLimitUlong should return -1 when the latter parameter is 0

2013-10-11 Thread Eric Blake
On 10/11/2013 12:50 AM, m...@linux.vnet.ibm.com wrote: > From: Bing Bu Cao Long subject line. Look at 'git shortlog -30' to get a feel for how to write a concise summary. I retitled it: util: fix two virCompareLimitUlong bugs > > The helper function virCompareLimitUlong compare limit values,

Re: [libvirt] [RFC] net-dhcp-leases: virNetworkDHCPLeases struct design

2013-10-11 Thread Nehal J Wani
On Fri, Oct 11, 2013 at 1:49 AM, Nehal J Wani wrote: > On Fri, Oct 11, 2013 at 12:36 AM, Eric Blake wrote: >> On 10/08/2013 06:39 AM, Nehal J Wani wrote: >>> Continued from >>> https://www.redhat.com/archives/libvir-list/2013-October/msg00325.html >>> >> >>> Since no one likes the idea of having

Re: [libvirt] [PATCH v2] qemu_migration: Avoid crashing if domain dies too quickly

2013-10-11 Thread Eric Blake
On 10/11/2013 06:14 AM, Michal Privoznik wrote: > I've noticed a SIGSEGV-ing libvirtd on the destination when the qemu > died too quickly = in Prepare phase. What is happening here is: > > > 4) [Thread 3262] So the even loop starts triggering EOF: s/even/event/ > > The mon->vm is set in qemuM

[libvirt] [PATCH v2] qemu_migration: Avoid crashing if domain dies too quickly

2013-10-11 Thread Michal Privoznik
I've noticed a SIGSEGV-ing libvirtd on the destination when the qemu died too quickly = in Prepare phase. What is happening here is: 1) [Thread 3493] We are in qemuMigrationPrepareAny() and calling qemuProcessStart() which subsequently calls qemuProcessWaitForMonitor() and qemuConnectMonitor(). So

Re: [libvirt] [BUG] libvirtd on destination crash frequently while migrating vms concurrently

2013-10-11 Thread Michal Privoznik
On 27.09.2013 09:55, Wangyufei (A) wrote: > Hello, > I found a problem that libvirtd on destination crash frequently while > migrating vms concurrently. For example, if I migrate 10 vms > concurrently ceaselessly, then after about 30 minutes the libvirtd on > destination will crash. So I analyzed a

Re: [libvirt] [PATCH 2/2] VMware: Do version detection earlier

2013-10-11 Thread Ján Tomko
On 10/10/2013 08:44 PM, Doug Goldstein wrote: > Do VMware version detection earlier as future patches will need the > version information to populate capabilities correctly. > --- > src/vmware/vmware_driver.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > ACK to both Jan -- li

[libvirt] libvirt URI for "UNIX abstract namespace"?

2013-10-11 Thread Philipp Hahn
Hello, while trying to reproduce a performance problem I had to fake 95 hosts with 300 VMs. My idea was to setup 95 users with each one running a session libvirtd. When adding them to our management system I had was troubled with finding the right libvirt URI, as the default session UNIX socket