[libvirt] Schedule for next release

Assuming we want to release around the end of the month means we ought to enter freeze next week around the 24 or 25, but I know I will be very busy and have a hard time on those days. So potentially I will try to do the freeze on the Saturday 26 for a release around Nov 1st, but there is a slight

Re: [libvirt] [Users] vdsmd seg fault

On Fri, Oct 18, 2013 at 11:32:51AM -0700, Jason Brooks wrote: > > On Fri, 2013-10-18 at 14:16 +0300, Dan Kenigsberg wrote: > > On Thu, Oct 17, 2013 at 05:15:48PM -0400, Jason Brooks wrote: > > > > > > > > > - Original Message - > > > > From: "Dan Ferris" > > > > To: "" > > > > Sent: Tu

Re: [libvirt] [PATCH] qemu: Fix augeas support for migration ports

On Fri, Oct 18, 2013 at 18:31:27 +0200, Michal Privoznik wrote: > Commit e3ef20d7 allows user to configure migration ports range via > qemu.conf. However, it forgot to update augeas definition file and > even the test data was malicious. > > Signed-off-by: Michal Privoznik > --- > > Pushed under

Re: [libvirt] [PATCH] Fix a problem introduced by commit 99889012

On 10/18/2013 12:36 PM, Geoff Hickey wrote: > The meaning of one line of code was accidentally inverted. > --- > src/esx/esx_driver.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) ACK and pushed. > > diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c > index 5d8baa5..886d984 100

[libvirt] [PATCH] Fix a problem introduced by commit 99889012

The meaning of one line of code was accidentally inverted. --- src/esx/esx_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c index 5d8baa5..886d984 100644 --- a/src/esx/esx_driver.c +++ b/src/esx/esx_driver.c @@ -1003,7 +1003,7

Re: [libvirt] [RFC PATCHv2 0/2] gluster pools

On 10/18/2013 11:30 AM, Eric Blake wrote: > This addresses the review from RFCv1 for splitting the glfs checks > to be different from the storage backend checks: > https://www.redhat.com/archives/libvir-list/2013-October/msg00645.html > > I'm still just in RFC stage; wanting to make sure I have th

[libvirt] [RFC PATCHv2 2/2] storage: document gluster pool

Add support for a new , similar to RBD and Sheepdog. Terminology wise, a gluster volume forms a libvirt storage pool, within the gluster volume, individual files are treated as libvirt storage volumes. * docs/schemas/storagepool.rng (poolgluster): New pool type. * docs/formatstorage.html.in: Docu

[libvirt] [RFC PATCHv2 1/2] storage: initial support for linking with libglfs

We support gluster volumes in domain XML, so we also ought to support them as a storage pool. Besides, a future patch will want to take advantage of libgfapi to handle the case of a gluster device holding qcow2 rather than raw storage, and for that to work, we need a storage backend that can read

[libvirt] [RFC PATCHv2 0/2] gluster pools

This addresses the review from RFCv1 for splitting the glfs checks to be different from the storage backend checks: https://www.redhat.com/archives/libvir-list/2013-October/msg00645.html I'm still just in RFC stage; wanting to make sure I have the documentation correct for sample XML prior to actu

[libvirt] [PATCH] qemu: Fix augeas support for migration ports

Commit e3ef20d7 allows user to configure migration ports range via qemu.conf. However, it forgot to update augeas definition file and even the test data was malicious. Signed-off-by: Michal Privoznik --- Pushed under trivial and build breaker rules. src/qemu/libvirtd_qemu.aug | 2 ++ s

[libvirt] [PATCHv2 07/10] numa: Replace NUMA_MAX_N_CPUS macro with virNumaGetMaxCPUs()

--- src/nodeinfo.c | 9 ++--- src/util/virnuma.c | 24 +++- src/util/virnuma.h | 2 ++ 3 files changed, 27 insertions(+), 8 deletions(-) diff --git a/src/nodeinfo.c b/src/nodeinfo.c index c73eee4..4f0d412 100644 --- a/src/nodeinfo.c +++ b/src/nodeinfo.c @@ -1513,11 +

[libvirt] [PATCHv2 10/10] nodeinfo: Remove libnuma include

Now that all libnuma functions used by libvirt are wrapped in virNuma we can remove the dependancy from nodeinfo. --- src/nodeinfo.c | 26 -- 1 file changed, 26 deletions(-) diff --git a/src/nodeinfo.c b/src/nodeinfo.c index 7e75611..87edf67 100644 --- a/src/nodeinfo.c +++

[libvirt] [PATCHv2 04/10] numa: Introduce virNumaGetMaxNode and use it instead of numa_max_node

Avoid necessary checks for the numa library with this helper. --- src/libvirt_private.syms | 1 + src/nodeinfo.c | 37 ++--- src/util/virnuma.c | 37 + src/util/virnuma.h | 2 ++ 4 files changed, 62 inserti

[libvirt] [PATCHv2 08/10] caps: Fix function docs for virCapabilitiesAddHostNUMACell

--- src/conf/capabilities.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/conf/capabilities.c b/src/conf/capabilities.c index 1acc936..8d53370 100644 --- a/src/conf/capabilities.c +++ b/src/conf/capabilities.c @@ -263,6 +263,7 @@ virCapabilitiesAddHostMigrateTransport(virCapsPtr caps,

[libvirt] [PATCHv2 09/10] numa: Add wrapper of numa_node_to_cpus and use it

--- src/nodeinfo.c | 62 ++--- src/util/virnuma.c | 91 ++ src/util/virnuma.h | 2 ++ 3 files changed, 117 insertions(+), 38 deletions(-) diff --git a/src/nodeinfo.c b/src/nodeinfo.c index 4f0d412..7e75611 10

[libvirt] [PATCHv2 03/10] nodeinfo: Avoid forward declarations of static functions

linuxNodeGetCPUStats() and linuxNodeGetMemoryStats() are static and don't need a forward declaration. --- src/nodeinfo.c | 27 ++- 1 file changed, 10 insertions(+), 17 deletions(-) diff --git a/src/nodeinfo.c b/src/nodeinfo.c index d4bb792..803856b 100644 --- a/src/nodeinf

[libvirt] [PATCHv2 06/10] nodeinfo: Get rid of nodeGetCellMemory

The function was called in a single place only and was reporting errors that were later ignored. Use the virNumaGetNodeMemory helper to get the size of the memory in the NUMA node and remove the helper --- src/nodeinfo.c | 47 +++ 1 file changed, 3 inser

[libvirt] [PATCHv2 02/10] numa: Introduce virNumaIsAvailable and use it instead of numa_available

All functions from libnuma must be protected with ifdefs. Avoid this by using our own wrapper. --- src/libvirt_private.syms | 1 + src/nodeinfo.c | 13 + src/util/virnuma.c | 14 ++ src/util/virnuma.h | 2 ++ 4 files changed, 22 insertions(+), 8 dele

[libvirt] [PATCHv2 05/10] numa: Introduce virNumaGetNodeMemory and use it instead of numa_node_size64

--- src/libvirt_private.syms | 1 + src/nodeinfo.c | 21 +++--- src/util/virnuma.c | 55 src/util/virnuma.h | 3 +++ 4 files changed, 67 insertions(+), 13 deletions(-) diff --git a/src/libvirt_private.syms b/src/

[libvirt] [PATCHv2 01/10] nodeinfo: Rename linuxNodeInfoCPUPopulate and export it properly

Call it virNodeInfoLinuxPopulateCPU and use the header file to export it instead of extern definition in the test file. --- src/libvirt_linux.syms | 2 +- src/nodeinfo.c | 14 +- src/nodeinfo.h | 5 + tests/nodeinfotest.c | 6 +- 4 files changed, 12 inserti

[libvirt] [PATCHv2 00/10] Strip libnuma functions from nodeinfo.c

As a pre-requisite for doing unit tests for topology detection code the code in nodeinfo.c needs to be cleaned up. Peter Krempa (10): nodeinfo: Rename linuxNodeInfoCPUPopulate and export it properly numa: Introduce virNumaIsAvailable and use it instead of numa_available nodeinfo: Avoid

Re: [libvirt] [PATCH] qemu: Avoid assigning unavailable migration ports

On Thu, Oct 17, 2013 at 13:44:33 +0200, Jano Tomko wrote: > On 10/15/2013 02:42 PM, Jiri Denemark wrote: > > From: WangYufei > > > > https://bugzilla.redhat.com/show_bug.cgi?id=1019053 > > > > When we migrate vms concurrently, there's a chance that libvirtd on > > destination assigns the same po

Re: [libvirt] [PATCH] docs: Expand description of host-model CPU mode

On Fri, Oct 18, 2013 at 08:17:32 -0600, Eric Blake wrote: > On 10/18/2013 08:08 AM, Jiri Denemark wrote: > > host-model is a nice idea but it's current implementation make it > > useless on some hosts so it should be used with care. > > > > Signed-off-by: Jiri Denemark > > --- > > docs/formatdom

Re: [libvirt] [PATCH] qemu: Make migration port range configurable

On Thu, Oct 17, 2013 at 13:44:57 +0200, Jano Tomko wrote: > On 10/15/2013 03:27 PM, Jiri Denemark wrote: > > Signed-off-by: Jiri Denemark > > --- > > src/qemu/qemu.conf | 11 +++ > > src/qemu/qemu_conf.c | 21 + > > src/qemu/qemu_conf.h

Re: [libvirt] [PATCH] docs: Expand description of host-model CPU mode

On 10/18/2013 08:08 AM, Jiri Denemark wrote: > host-model is a nice idea but it's current implementation make it > useless on some hosts so it should be used with care. > > Signed-off-by: Jiri Denemark > --- > docs/formatdomain.html.in | 11 ++- > 1 file changed, 10 insertions(+), 1 dele

[libvirt] [PATCH] docs: Expand description of host-model CPU mode

host-model is a nice idea but it's current implementation make it useless on some hosts so it should be used with care. Signed-off-by: Jiri Denemark --- docs/formatdomain.html.in | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/docs/formatdomain.html.in b/docs/form

[libvirt] [PATCH] viralloc.h: Fix typo in VIR_APPEND_ELEMENT_COPY_QUIT

In fact, the suffix should be _QUIET not _QUIT to stress the fact, that no OOM error is reported on error. Signed-off-by: Michal Privoznik --- Pushed under trivial rule. src/util/viralloc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/viralloc.h b/src/util/viral

Re: [libvirt] [PATCH] remote:Fix the parameter passed to remoteDispatchConnectDomainEventDeregisterAny() should be eventID

On 10/17/2013 07:47 PM, Wangyufei (A) wrote: > Thanks for your reply. Rewiting is fine. > >>> >>> Signed-off-by: zhouyimin >> >> Thanks for the patch. However, we prefer to have the Signed-off-by use a >> legal name, rather than a login alias. Given your cc: line, is it okay if I >> rewrite th

[libvirt] [PATCH v4 3/3] capabilities: add baselabel per sec driver/virt type to secmodel

Expand the "secmodel" XML fragment of "host" with a sequence of baselabel's which describe the default security context used by libvirt with a specific security model and virtualization type: selinux 0 system_u:system_r:svirt_t:s0 system_u:system_r:svirt_tcg_t:s0 dac 0 107:107 1

[libvirt] [PATCH v4 2/3] security: add new internal function "virSecurityManagerGetBaseLabel"

virSecurityManagerGetBaseLabel queries the default settings used by a security model. Signed-off-by: Giuseppe Scrivano --- src/libvirt_private.syms | 1 + src/security/security_apparmor.c | 8 src/security/security_dac.c | 10 ++ src/security/security_driver.h |

[libvirt] [PATCH v4 1/3] security: use a single function to set DAC user and group

Merge the functions 'virSecurityDACSetUser' and 'virSecurityDACSetGroup' into 'virSecurityDACSetUserAndGroup'. Signed-off-by: Giuseppe Scrivano --- src/security/security_dac.c | 24 ++-- src/security/security_dac.h | 7 +++ src/security/security_manager.c | 6 ++

[libvirt] [PATCH v4 0/3] expose baselabel for each sec model/virt type

Now each security model can define its own base label, that describes the default security context used by libvirt to run an hypervisor process. This information is exposed to users trough the host capabilities XML. *v4 major changes - Refactor virSecurityDACSetUser and virSecurityDACSetGroup in

[libvirt] [PATCH] Avoid Coverity DEADCODE warning

Commit '922b7fda' resulted in two DEADCODE warnings from Coverity in remoteDispatchAuthPolkit and virAccessDriverPolkitFormatProcess. Commit '604ae657' modified the daemon.c code to remove the deadcode issue, but did not do so for viracessdriverpolkit.c. This just mimics the same changes Signed-of

[libvirt] [PATCH 3/3] qemu: fix removal of

This patch (and the two patches that precede it) resolve: https://bugzilla.redhat.com/show_bug.cgi?id=1005682 When libvirt was changed to delay the final cleanup of device removal until the qemu process had signaled it with a DEVICE_DELETED event for that device, the hostdev removal function (q

[libvirt] [PATCH 0/3] fix removal of

1/3 is a cleanup, but not strictly necessary to solve the current bug 2/3 is just code movement of an entire function to avoid a forward ref. 3/3 is what actually fixes the bug. This resolves https://bugzilla.redhat.com/show_bug.cgi?id=1005682 Laine Stump (3): qemu: simplify calling qemuDomainH

[libvirt] [PATCH 1/3] qemu: simplify calling qemuDomainHostdevNetConfigRestore

This function was called in three places, and in each the call was qualified by a slightly different conditional. In reality, this function should only be called for a hostdev if all of the following are true: 1) mode='subsystem' 2) type='pci' 3) there is a parent device definition which is

[libvirt] [PATCH 2/3] qemu: move qemuDomainRemoveNetDevice to avoid forward reference

pure code movement to setup for next patch. --- src/qemu/qemu_hotplug.c | 122 1 file changed, 61 insertions(+), 61 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index a6a1591..ddc80a1 100644 --- a/src/qemu/qemu_hotplu

[libvirt] [FWD: [Qemu-devel] KVM Forum 2013 presentations on Google+ (Hangouts on-air)]

FYI for those not able to visit KVM Forum this year, we're attempting to have presentations streaming via G+. No guarantees about success, since we're at mercy of the Hotel net connection, but if streaming fails we'll at least have recordings of all sessions to be uploaded afterwards. Keep an eye

[libvirt] [PATCH v4 2/2] Add sample output of Wireshark dissector

From: "Yuto KAWAMURA(kawamuray)" Add directory tools/wireshark/samples/ and libvirt-sample.pdml which is sample output of dissector. --- tools/wireshark/samples/libvirt-sample.pdml | 206 1 file changed, 206 insertions(+) create mode 100644 tools/wireshark/samples/l

[libvirt] [PATCH v4 0/2] Libvirt Wireshark Dissector

From: "Yuto KAWAMURA(kawamuray)" Changes from version 3: * Merge tools/wireshark/.gitignore into ROOT/.gitignore * Fix dissect_xdr_pointer() bug which pointed by Michal * Added -module option to libvirt_la_LDFLAGS respecting official build process Introduce Wireshark dissector plugin which adds

Re: [libvirt] [PATCH 0/4] Start cleaning up nodeinfo.c

On 10/17/13 18:45, Peter Krempa wrote: > Some parts of nodeinfo.c are a mess. This series is a start of cleanup > effort on that file that should result also into tests being written > to test the nodeinfo code as it was shown to be fragile. > > To avoid sending a huge series I will send it contin

[libvirt] [PATCHv3 RESEND 5/5] vbox_tmpl.c: Add methods for undefining snapshots

All the informations concerning snapshots (and snapshot disks) will be deleted from the vbox xml. But the differencing disks will be kept so you will be able to redefine the snapshots. --- src/vbox/vbox_tmpl.c | 387 ++ 1 file changed, 387 insertion

[libvirt] [PATCHv3 RESEND 1/5] viruuid.h/c: Util method for finding uuid patterns in some strings

--- po/POTFILES.in |1 + src/libvirt_private.syms |1 + src/util/viruuid.c | 81 ++ src/util/viruuid.h |1 + 4 files changed, 84 insertions(+) diff --git a/po/POTFILES.in b/po/POTFILES.in index 15afdec..451a6fc 100644

[libvirt] [PATCHv3 RESEND 4/5] vbox_tmpl.c: Patch for redefining snapshots

The snapshots are saved in xml files, and then can be redefined --- src/vbox/vbox_tmpl.c | 848 +- 1 file changed, 840 insertions(+), 8 deletions(-) diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c index ce070c6..b52695f 100644 --- a/src/vb

[libvirt] [PATCHv3 RESEND 2/5] virstring.h/c: Util method for making some find and replace in strings

--- src/libvirt_private.syms |1 + src/util/virstring.c | 48 ++ src/util/virstring.h |2 ++ 3 files changed, 51 insertions(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index c498ab6..77347ec 100644 --- a/src/lib

[libvirt] [PATCHv3 RESEND 3/5] vbox_tmpl.c: Better XML description for snapshots

It will be needed for the futur patches because we will redefine snapshots --- src/conf/domain_conf.c |2 +- src/vbox/vbox_tmpl.c | 427 ++-- 2 files changed, 417 insertions(+), 12 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domai

[libvirt] [PATCHv3 RESEND 0/5] Handling of undefine and redefine snapshots with VirtualBox 4.2

Hi, This is a serie of patches in order to support undefining and redefining snapshots with VirtualBox 4.2. The serie of patches is rather big, and adds among other things some utility functions unrelated to VirtualBox in patches 1 & 2. The code review could be done in several parts: e.g. patches

Re: [libvirt] [PATCH] qemuDomainCleanupRemove: s/memmove/VIR_DELETE_ELEMENT_INPLACE/

On 10/17/2013 04:33 PM, Michal Privoznik wrote: > The last argument of memmove is the amount of bytes to be moved. The > amount is in Bytes. We are moving some void pointers around. However, > since sizeof(void *) is not Byte on any architecture, we've got the > arithmetic wrong. My personal exper

Re: [libvirt] [PATCH v2] qemu_migration: Avoid crashing if domain dies too quickly

On 18.10.2013 09:22, Wangyufei (A) wrote: > > >> -Original Message- >> From: Michal Privoznik [mailto:mpriv...@redhat.com] >> Sent: Friday, October 18, 2013 2:37 PM >> To: Wangyufei (A) >> Cc: libvir-list@redhat.com; Wangrui (K) >> Subject: Re: [libvirt] [PATCH v2] qemu_migration: Avoid c

Re: [libvirt] [PATCH v2] qemu_migration: Avoid crashing if domain dies too quickly

> -Original Message- > From: Michal Privoznik [mailto:mpriv...@redhat.com] > Sent: Friday, October 18, 2013 2:37 PM > To: Wangyufei (A) > Cc: libvir-list@redhat.com; Wangrui (K) > Subject: Re: [libvirt] [PATCH v2] qemu_migration: Avoid crashing if domain > dies too quickly > > On 18.10.2