Signed-off-by: Gao feng
---
.gnulib | 2 +-
src/lxc/lxc_container.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/.gnulib b/.gnulib
index 8f74258..4a5ee89 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit 8f7425866463f994538584d1dd7211603b8
From: Chen Hanxiao
Signed-off-by: Chen Hanxiao
---
tools/virsh-domain.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 59e3d8d..84fbc90 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -297,11 +297,13 @@
From: Chen Hanxiao
If we need to exclude one parameters from another,
we could use this member to specify one.
With this flag, we could archive what Eric comment on:
https://www.redhat.com/archives/libvir-list/2013-October/msg00965.html
1. COMMAND or COMMAND --
Auto complete will NOT show optio
From: Chen Hanxiao
Chen Hanxiao (2):
[libvirt]virsh: introduce member excludeOption in vshCmdOptDef and
improve auto complete with it
[libvirt]virsh: set --shareable and --mode's new member: excludeOption
tools/virsh-domain.c | 6 --
tools/virsh.c| 34 +
The QEMU backend was disabled on Mac OS X without a reason in the code
and due to refactors its difficult to understand when/why it was
disabled. With QEMU being supported on Mac OS X there is no reason to
disable QEMU on this platform.
---
configure.ac | 6 +-
1 file changed, 1 insertion(+),
On Mon, Oct 28, 2013 at 1:05 PM, Doug Goldstein wrote:
> With Mac OS X 10.9, xdrproc_t is no longer defined as:
>
> typedef bool_t (*xdrproc_t) (XDR *, void *, ...);
This was the typedef from Linux accidentally so I've updated that as well.
>
> but instead as
>
> typedef bool-t (*xdrproc_t) (XDR
Since we haven't quite frozen yet, it's time to pick up some
fixes. I know at least cygwin benefits from this update.
* .gnulib: Update to latest, in part for cygwin compilation.
Signed-off-by: Eric Blake
---
Pushing under the gnulib rule.
* .gnulib 4a5ee89...8f74258 (33):
> Revert "error:
On Thu, Oct 24, 2013 at 10:16:50AM +0100, Michal Privoznik wrote:
> On 22.10.2013 23:50, Ian Main wrote:
> > I guess this must have been changed and the demo not updated. Fix the
> > demo so it uses the right value.
> >
> > Signed-off-by: Ian Main
> > ---
> > examples/config-demo.py | 2 +-
> >
With Mac OS X 10.9, xdrproc_t is no longer defined as:
typedef bool_t (*xdrproc_t) (XDR *, void *, ...);
but instead as
typedef bool-t (*xdrproc_t) (XDR *, void *, unsigned int);
The rationale explained in the header is that using a vararg is
incorrect and has a potential to change the ABI slig
On 10/28/2013 01:14 PM, Daniel P. Berrange wrote:
> On Mon, Oct 28, 2013 at 01:08:45PM -0400, Cole Robinson wrote:
>> On 10/28/2013 01:06 PM, Daniel P. Berrange wrote:
>>> On Mon, Oct 28, 2013 at 01:03:49PM -0400, Cole Robinson wrote:
On 10/28/2013 07:52 AM, Daniel P. Berrange wrote:
> Fro
On Mon, Oct 28, 2013 at 01:08:45PM -0400, Cole Robinson wrote:
> On 10/28/2013 01:06 PM, Daniel P. Berrange wrote:
> > On Mon, Oct 28, 2013 at 01:03:49PM -0400, Cole Robinson wrote:
> >> On 10/28/2013 07:52 AM, Daniel P. Berrange wrote:
> >>> From: "Daniel P. Berrange"
> >>>
> >>> The following se
On 10/28/2013 01:06 PM, Daniel P. Berrange wrote:
> On Mon, Oct 28, 2013 at 01:03:49PM -0400, Cole Robinson wrote:
>> On 10/28/2013 07:52 AM, Daniel P. Berrange wrote:
>>> From: "Daniel P. Berrange"
>>>
>>> The following sequence
>>>
>>> 1. Define a persistent QMEU guest
>>> 2. Start the QEMU gu
On Mon, Oct 28, 2013 at 01:03:49PM -0400, Cole Robinson wrote:
> On 10/28/2013 07:52 AM, Daniel P. Berrange wrote:
> > From: "Daniel P. Berrange"
> >
> > The following sequence
> >
> > 1. Define a persistent QMEU guest
> > 2. Start the QEMU guest
> > 3. Stop libvirtd
> > 4. Kill the QEMU pro
On 10/28/2013 07:52 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
>
> The following sequence
>
> 1. Define a persistent QMEU guest
> 2. Start the QEMU guest
> 3. Stop libvirtd
> 4. Kill the QEMU process
> 5. Start libvirtd
> 6. List persistent guets
>
> At the last step, the
On Mon, Oct 28, 2013 at 7:30 AM, Daniel P. Berrange wrote:
> On Fri, Oct 18, 2013 at 05:18:22PM -0400, Daniel Veillard wrote:
>> Assuming we want to release around the end of the month means we
>> ought to enter freeze next week around the 24 or 25, but I know I
>> will be very busy and have a ha
From: "Daniel P. Berrange"
The 'srcpath' variable is initialized from 'mnt->src' and never
changed thereafter. Some places continue to use 'mnt->src' and
others use 'srcpath'. Remove the pointless 'srcpath' variable
and use 'mnt->src' everywhere.
Signed-off-by: Daniel P. Berrange
---
src/lxc/l
From: "Daniel P. Berrange"
Currently the lxcBasicMounts array has separate entries for
most mounts, to reflect that we must do a separate mount
operation to make mounts read-only. Remove the duplicate
entries and instead set the MS_RDONLY flag against the main
entry. Then change lxcContainerMount
From: "Daniel P. Berrange"
The virLXCBasicMountInfo struct contains a 'char *opts'
field passed onto the mount() syscall. Every entry in the
list sets this to NULL though, so it can be removed to
simplify life.
Signed-off-by: Daniel P. Berrange
---
src/lxc/lxc_container.c | 29 ++--
From: "Daniel P. Berrange"
Currently the LXC container tries to skip selinux/securityfs
mounts if the directory does not exist in the filesystem,
or if SELinux is disabled.
The former check is flawed because the /sys/fs/selinux
or /sys/kernel/securityfs directories may exist in sysfs
even if the
From: "Daniel P. Berrange"
Add a function for efficiently checking if a path is a filesystem
mount point.
NB will not work for bind mounts, only true filesystem mounts.
Signed-off-by: Daniel P. Berrange
---
src/libvirt_private.syms | 1 +
src/util/virfile.c | 50 +++
From: "Daniel P. Berrange"
Update of
https://www.redhat.com/archives/libvir-list/2013-October/msg00270.html
Previously I just re-sent the one patch needing changes. This time I
am reposting the whole series after rebasing.
Daniel P. Berrange (6):
Add virFileIsMountPoint function
Remove u
From: "Daniel P. Berrange"
Some mounts must be skipped if running inside a user namespace,
since the kernel forbids their use. Instead of strcmp'ing the
filesystem type in the body of the loop, set an explicit flag
in the lxcBasicMounts table.
Signed-off-by: Daniel P. Berrange
---
src/lxc/lxc_
From: "Daniel P. Berrange"
Update of
https://www.redhat.com/archives/libvir-list/2013-October/msg00270.html
Previously I just re-sent the one patch needing changes. This time I
am reposting the whole series after rebasing.
Daniel P. Berrange (1):
Skip any files which are not mounted on the
From: "Daniel P. Berrange"
Currently the LXC container tries to skip selinux/securityfs
mounts if the directory does not exist in the filesystem,
or if SELinux is disabled.
The former check is flawed because the /sys/fs/selinux
or /sys/kernel/securityfs directories may exist in sysfs
even if the
On 10/28/2013 10:08 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
>
> virDomainObjListLoadAllConfigs sets dom->persistent after
> having released its lock on the domain object. This exposes
> a possible race condition.
>
> Signed-off-by: Daniel P. Berrange
> ---
> src/conf/domain_
On Mon, Oct 28, 2013 at 09:17:16AM -0400, John Ferlan wrote:
> On 10/28/2013 07:52 AM, Daniel P. Berrange wrote:
> > From: "Daniel P. Berrange"
> >
> > The following sequence
> >
> > 1. Define a persistent QMEU guest
>
> s/QMEU/QEMU
>
> > 2. Start the QEMU guest
> > 3. Stop libvirtd
> > 4.
From: "Daniel P. Berrange"
virDomainObjListLoadAllConfigs sets dom->persistent after
having released its lock on the domain object. This exposes
a possible race condition.
Signed-off-by: Daniel P. Berrange
---
src/conf/domain_conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -
On Mon, Oct 28, 2013 at 02:38:46PM +0100, Pavel Raiskup wrote:
> Allow adjust the number of commands to remember in the command
> history.
>
> * tools/virsh.c (vshReadlineInit): Read and sanity the
> VIRSH_HISTSIZE variable.
> (VIRSH_HISTSIZE_MAX): New constant.
> * tools/virsh.pod: Document VIRSH
ping
On Thu, Oct 24, 2013 at 11:01 AM, Nehal J Wani wrote:
> I tried writing the helper program, didn't send v5, since I have some doubts.
> The program works. Problems listed below.
>
> diff --git a/src/Makefile.am b/src/Makefile.am
> index 21b9caf..ef88132 100644
> --- a/src/Makefile.am
> +++ b
Allow adjust the number of commands to remember in the command
history.
* tools/virsh.c (vshReadlineInit): Read and sanity the
VIRSH_HISTSIZE variable.
(VIRSH_HISTSIZE_MAX): New constant.
* tools/virsh.pod: Document VIRSH_HISTSIZE variable.
---
tools/virsh.c | 17 -
tools/virsh.
On 10/28/2013 07:52 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
>
> The following sequence
>
> 1. Define a persistent QMEU guest
s/QMEU/QEMU
> 2. Start the QEMU guest
> 3. Stop libvirtd
> 4. Kill the QEMU process
> 5. Start libvirtd
> 6. List persistent guets
s/guets/gues
On Fri, Oct 18, 2013 at 05:18:22PM -0400, Daniel Veillard wrote:
> Assuming we want to release around the end of the month means we
> ought to enter freeze next week around the 24 or 25, but I know I
> will be very busy and have a hard time on those days. So potentially
> I will try to do the free
On Sun, Oct 27, 2013 at 10:17:29AM +0100, Pavel Raiskup wrote:
> Allow adjust the number of commands to remember in the command
> history.
>
> * tools/virsh.c (vshReadlineInit): Read and sanity the
> VIRSH_HISTSIZE variable.
> (VIRSH_HISTSIZE_MAX): New constant.
> * tools/virsh.pod: Document VIRSH
On Fri, Oct 18, 2013 at 05:05:50PM +0200, Peter Krempa wrote:
> Now that all libnuma functions used by libvirt are wrapped in virNuma we
> can remove the dependancy from nodeinfo.
> ---
> src/nodeinfo.c | 26 --
> 1 file changed, 26 deletions(-)
ACK
Daniel
--
|: http://b
On Fri, Oct 18, 2013 at 05:05:49PM +0200, Peter Krempa wrote:
> ---
> src/nodeinfo.c | 62 ++---
> src/util/virnuma.c | 91
> ++
> src/util/virnuma.h | 2 ++
> 3 files changed, 117 insertions(+), 38 deletions
On Fri, Oct 18, 2013 at 05:05:48PM +0200, Peter Krempa wrote:
> ---
> src/conf/capabilities.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/conf/capabilities.c b/src/conf/capabilities.c
> index 1acc936..8d53370 100644
> --- a/src/conf/capabilities.c
> +++ b/src/conf/capabilities.c
On Fri, Oct 18, 2013 at 05:05:47PM +0200, Peter Krempa wrote:
> ---
> src/nodeinfo.c | 9 ++---
> src/util/virnuma.c | 24 +++-
> src/util/virnuma.h | 2 ++
> 3 files changed, 27 insertions(+), 8 deletions(-)
ACK
Daniel
--
|: http://berrange.com -o-http://
On Fri, Oct 18, 2013 at 05:05:46PM +0200, Peter Krempa wrote:
> The function was called in a single place only and was reporting errors
> that were later ignored. Use the virNumaGetNodeMemory helper to get the
> size of the memory in the NUMA node and remove the helper
> ---
> src/nodeinfo.c | 47
On Fri, Oct 18, 2013 at 05:05:45PM +0200, Peter Krempa wrote:
> ---
> src/libvirt_private.syms | 1 +
> src/nodeinfo.c | 21 +++---
> src/util/virnuma.c | 55
>
> src/util/virnuma.h | 3 +++
> 4 files changed, 67
On Fri, Oct 18, 2013 at 05:05:44PM +0200, Peter Krempa wrote:
> Avoid necessary checks for the numa library with this helper.
> ---
> src/libvirt_private.syms | 1 +
> src/nodeinfo.c | 37 ++---
> src/util/virnuma.c | 37
On Fri, Oct 18, 2013 at 05:05:43PM +0200, Peter Krempa wrote:
> linuxNodeGetCPUStats() and linuxNodeGetMemoryStats() are static and
> don't need a forward declaration.
> ---
> src/nodeinfo.c | 27 ++-
> 1 file changed, 10 insertions(+), 17 deletions(-)
ACK
Daniel
--
|: h
On Fri, Oct 18, 2013 at 05:05:42PM +0200, Peter Krempa wrote:
> All functions from libnuma must be protected with ifdefs. Avoid this by
> using our own wrapper.
> ---
> src/libvirt_private.syms | 1 +
> src/nodeinfo.c | 13 +
> src/util/virnuma.c | 14 ++
>
On Fri, Oct 18, 2013 at 05:05:41PM +0200, Peter Krempa wrote:
> Call it virNodeInfoLinuxPopulateCPU and use the header file to export
> it instead of extern definition in the test file.
> ---
> src/libvirt_linux.syms | 2 +-
> src/nodeinfo.c | 14 +-
> src/nodeinfo.h |
Allow adjust the number of commands to remember in the command
history.
* tools/virsh.c (vshReadlineInit): Read and sanity the
VIRSH_HISTSIZE variable.
(VIRSH_HISTSIZE_MAX): New constant.
* tools/virsh.pod: Document VIRSH_HISTSIZE variable.
---
tools/virsh.c | 17 -
tools/virsh.
On Fri, Oct 18, 2013 at 02:13:21PM +0200, Giuseppe Scrivano wrote:
> Expand the "secmodel" XML fragment of "host" with a sequence of
> baselabel's which describe the default security context used by
> libvirt with a specific security model and virtualization type:
>
>
> selinux
> 0
> system
On Fri, Oct 18, 2013 at 02:13:20PM +0200, Giuseppe Scrivano wrote:
> virSecurityManagerGetBaseLabel queries the default settings used by
> a security model.
>
> Signed-off-by: Giuseppe Scrivano
> ---
> src/libvirt_private.syms | 1 +
> src/security/security_apparmor.c | 8
> s
On Fri, Oct 18, 2013 at 02:13:19PM +0200, Giuseppe Scrivano wrote:
> Merge the functions 'virSecurityDACSetUser' and
> 'virSecurityDACSetGroup' into 'virSecurityDACSetUserAndGroup'.
>
> Signed-off-by: Giuseppe Scrivano
> ---
> src/security/security_dac.c | 24 ++--
> src/
On Fri, Oct 18, 2013 at 03:00:22AM +, Wangyufei (A) wrote:
> Hello,
> I found a problem that:
> vm's status file may be left over in the path /var/run/libvirt/qemu under
> some situation, such as host reboot. When vm's status file is left over, some
> persistent but inactive vms will be l
From: "Daniel P. Berrange"
The following sequence
1. Define a persistent QMEU guest
2. Start the QEMU guest
3. Stop libvirtd
4. Kill the QEMU process
5. Start libvirtd
6. List persistent guets
At the last step, the previously running persistent guest
will be missing. This is because of a
On Mon, Oct 21, 2013 at 02:28:37PM +0100, Michal Privoznik wrote:
> On 16.10.2013 08:27, Chen Hanxiao wrote:
> > From: Chen Hanxiao
> >
> > Currently, lxcContainer[Send|Waitfor]Continue only tell
> > us 'fd', but we had to deal with the interaction between
> > lxc_[container|controller|process].
On Wed, Oct 16, 2013 at 12:08:34PM +0800, Chen Hanxiao wrote:
> From: Chen Hanxiao
>
> lxcContainerSetID is used for user namespace.
> If we don't enable user namespace, don't print debug log.
>
> Signed-off-by: Chen Hanxiao
> ---
> src/lxc/lxc_container.c | 14 --
> 1 file changed
The bus type IDE being enum Zero, the bus type on pseries system appears as IDE
for all the disk types. Pseries platform needs this to appear as SCSI instead
of IDE.
Signed-off-by: Shivaprasad G Bhat
---
src/qemu/qemu_domain.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/
52 matches
Mail list logo