On Thu, Nov 21, 2013 at 04:45:32PM -0700, Eric Blake wrote:
On 11/21/2013 10:56 AM, Christophe Fergeau wrote:
With some authentication mechanism (PLAIN for example), sasl_client_start()
can return SASL_OK, which translates to virNetSASLSessionClientStart()
returning VIR_NET_SASL_COMPLETE.
On Fri, Nov 22, 2013 at 10:54:01AM +0100, Christophe Fergeau wrote:
On Thu, Nov 21, 2013 at 04:45:32PM -0700, Eric Blake wrote:
On 11/21/2013 10:56 AM, Christophe Fergeau wrote:
With some authentication mechanism (PLAIN for example),
sasl_client_start()
can return SASL_OK, which
With some authentication mechanism (PLAIN for example), sasl_client_start()
can return SASL_OK, which translates to virNetSASLSessionClientStart()
returning VIR_NET_SASL_COMPLETE.
cyrus-sasl documentation is a bit vague as to what to do in such situation,
but upstream clarified this a bit in
clang doesn't support -pie option (as of clang 3.3):
clang: error: argument unused during compilation:
'-pie' [-Werror,-Wunused-command-line-argument]
We have to use -Wl,-pie instead.
(ref. https://bugs.ruby-lang.org/issues/5697)
The new code checks -pie first, and if it fails, checks
On Fri, Nov 22, 2013 at 06:01:44AM +0100, Martin Kletzander wrote:
There are few places where we know about port getting opened even
though it was not allocated on any virPortAllocator (or we know it was
reserved like this). We cannot notify the virPortAllocator that the
port is open because
On Fri, Nov 22, 2013 at 10:59:20AM +0100, Christophe Fergeau wrote:
With some authentication mechanism (PLAIN for example), sasl_client_start()
can return SASL_OK, which translates to virNetSASLSessionClientStart()
returning VIR_NET_SASL_COMPLETE.
cyrus-sasl documentation is a bit vague as to
Though trying to destroy a physical HBA doesn't make sense at all,
it's still a bit misleading with saying only works for HBA.
Signed-off-by: Osier Yang jy...@redhat.com
---
src/libvirt.c | 5 +++--
tools/virsh.pod | 6 +++---
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git
https://bugzilla.redhat.com/show_bug.cgi?id=1033614
As virt-login-shell is an SUID binary, we should restrict its usage to
just the users chosen by an administrator to use virt-login-shell as
their login shell. This can easily be done by making the binary
executable only by users from a new
On 11/21/2013 08:45 AM, Daniel P. Berrange wrote:
On Tue, Nov 19, 2013 at 04:43:12PM +0100, Cédric Bosdonnat wrote:
These changes are all about bringing events for network object like the
ones existing for domains. This feature is needed for virt-manager to
refresh its UI when networks are
On Fri, Nov 22, 2013 at 02:57:36PM +0100, Jiri Denemark wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1033614
As virt-login-shell is an SUID binary, we should restrict its usage to
just the users chosen by an administrator to use virt-login-shell as
their login shell. This can easily be
On Fri, Nov 22, 2013 at 14:00:06 +, Daniel Berrange wrote:
On Fri, Nov 22, 2013 at 02:57:36PM +0100, Jiri Denemark wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1033614
As virt-login-shell is an SUID binary, we should restrict its usage to
just the users chosen by an
From: Daniel P. Berrange berra...@redhat.com
This reverts commit 6b90d7428d72e92db292a9228c44701bfd5003c9.
The original problem was that libvirt_virConnectGetCPUModelNames
was listed twice in the exports table, once automatically from
the generator and once from the manual override. We merely
On Fri, Nov 22, 2013 at 10:24:17AM +, Daniel P. Berrange wrote:
On Fri, Nov 22, 2013 at 06:01:44AM +0100, Martin Kletzander wrote:
There are few places where we know about port getting opened even
though it was not allocated on any virPortAllocator (or we know it was
reserved like
On Tue, Nov 19, 2013 at 18:21:08 +0100, Jano Tomko wrote:
This nested job is canceled by the first ExitMonitor call (even though
it was not created by the corresponding EnterMonitor call), and
again in qemuMigrationPrepareAny if qemuProcessStart failed.
This can lead to a crash if the vm
On 11/21/2013 04:54 PM, Eric Blake wrote:
On 11/21/2013 01:15 PM, Cole Robinson wrote:
Restarting an active libvirt-guests.service is the equivalent of
doing:
/usr/libexec/libvirt-guests.sh stop
/usr/libexec/libvirt-guests.sh start
Which in a default configuration will managedsave every
On Fri, Nov 22, 2013 at 15:41:28 +0100, Martin Kletzander wrote:
On Fri, Nov 22, 2013 at 10:24:17AM +, Daniel P. Berrange wrote:
On Fri, Nov 22, 2013 at 06:01:44AM +0100, Martin Kletzander wrote:
There are few places where we know about port getting opened even
though it was not
On 11/22/2013 04:21 PM, Jiri Denemark wrote:
On Tue, Nov 19, 2013 at 18:21:08 +0100, Jano Tomko wrote:
This nested job is canceled by the first ExitMonitor call (even though
it was not created by the corresponding EnterMonitor call), and
again in qemuMigrationPrepareAny if qemuProcessStart
On 11/22/2013 07:34 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
This reverts commit 6b90d7428d72e92db292a9228c44701bfd5003c9.
The original problem was that libvirt_virConnectGetCPUModelNames
was listed twice in the exports table, once automatically from
the
From: Daniel P. Berrange berra...@redhat.com
This patch series is a followup to
https://www.redhat.com/archives/libvir-list/2013-November/msg00712.html
This series is what I consider ready to declare final, ready for the real
GIT repo split to be done.
Starting from libvirt GIT master as of
From: Daniel P. Berrange berra...@redhat.com
Import ATTRIBUTE_RETURN_CHECK, ATTRIBUTE_UNUSED
ATTRIBUTE_NONNULL macros
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
libvirt-utils.h | 52
1 file changed, 52 insertions(+)
diff
From: Daniel P. Berrange berra...@redhat.com
We're no longer using automake, so config.h files are not
required. Also remove of all libvirt internal util header
files. Reference generated header files in build/ subdir.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
From: Daniel P. Berrange berra...@redhat.com
We are no longer using automake, so Makefile.am is obsolete
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
Makefile.am | 173 ---
examples/Makefile.am | 21 ---
2 files changed,
From: Daniel P. Berrange berra...@redhat.com
Import the libvirt memory allocation functions, stripping the OOM
testing and error reporting pieces.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
libvirt-lxc-override.c | 1 +
libvirt-override.c | 106
From: Daniel P. Berrange berra...@redhat.com
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
libvirt-override.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libvirt-override.c b/libvirt-override.c
index e0df994..45c5652 100644
--- a/libvirt-override.c
+++
From: Doug Goldstein car...@cardoe.com
---
libvirt-override.c | 4
1 file changed, 4 insertions(+)
diff --git a/libvirt-override.c b/libvirt-override.c
index 45c5652..875329e 100644
--- a/libvirt-override.c
+++ b/libvirt-override.c
@@ -2543,6 +2543,7 @@ cleanup:
return py_retval;
}
From: Daniel P. Berrange berra...@redhat.com
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
libvirt-utils.h | 11 +++
1 file changed, 11 insertions(+)
diff --git a/libvirt-utils.h b/libvirt-utils.h
index c1223fd..961cc20 100644
--- a/libvirt-utils.h
+++ b/libvirt-utils.h
@@
From: Doug Goldstein car...@cardoe.com
Since we don't always want to build all the modules, and there might be
more modules added in the future but we want to retain backwards
compatibility with older libvirts, change generator.py to be called once
per module instead of with all modules at once.
From: Daniel P. Berrange berra...@redhat.com
The generated libvirt.py modules will be in the build/
directory, so santitytest.py must use that directory.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
sanitytest.py | 4
1 file changed, 4 insertions(+)
diff --git a/sanitytest.py
From: Daniel P. Berrange berra...@redhat.com
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
libvirt-override.c | 1 +
libvirt-utils.h| 15 +++
2 files changed, 16 insertions(+)
diff --git a/libvirt-override.c b/libvirt-override.c
index f459602..cb78e0d 100644
---
From: Doug Goldstein car...@cardoe.com
Add LIBVIR_CHECK_VERSION from libvirt upstream so that we can check the
version of the library we are compiling against and support a range of
libvirt versions. The macro was added to libvirt in 1.2.0 so we must
provide it if its not defined.
---
From: Daniel P. Berrange berra...@redhat.com
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
libvirt-override.c | 1 +
libvirt-utils.h| 27 +++
2 files changed, 28 insertions(+)
create mode 100644 libvirt-utils.h
diff --git a/libvirt-override.c
From: Doug Goldstein car...@cardoe.com
virTypedParamsClear() and virTypedParamsFree() were introduced in
libvirt 1.0.2. In an effort to keep the code clean bring these two
functions to libvirt-python if we're building against a version of
libvirt that's older than 1.0.2
---
libvirt-utils.c | 46
From: Daniel P. Berrange berra...@redhat.com
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
libvirt-utils.h | 4
1 file changed, 4 insertions(+)
diff --git a/libvirt-utils.h b/libvirt-utils.h
index bec7346..aed64e6 100644
--- a/libvirt-utils.h
+++ b/libvirt-utils.h
@@ -24,4
From: Doug Goldstein car...@cardoe.com
---
libvirt-override.c | 4
1 file changed, 4 insertions(+)
diff --git a/libvirt-override.c b/libvirt-override.c
index c439403..1894c97 100644
--- a/libvirt-override.c
+++ b/libvirt-override.c
@@ -3569,6 +3569,7 @@
From: Daniel P. Berrange berra...@redhat.com
---
libvirt-override.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/libvirt-override.c b/libvirt-override.c
index 49068ca..e14ca26 100644
--- a/libvirt-override.c
+++ b/libvirt-override.c
@@ -6185,6 +6185,8 @@
From: Daniel P. Berrange berra...@redhat.com
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
libvirt-qemu-override.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/libvirt-qemu-override.c b/libvirt-qemu-override.c
index 676e8bf..a8e8c09 100644
--- a/libvirt-qemu-override.c
From: Doug Goldstein car...@cardoe.com
---
libvirt-override.c | 4
1 file changed, 4 insertions(+)
diff --git a/libvirt-override.c b/libvirt-override.c
index 875329e..fd16916 100644
--- a/libvirt-override.c
+++ b/libvirt-override.c
@@ -2394,6 +2394,7 @@
From: Doug Goldstein car...@cardoe.com
---
libvirt-override.c | 4
1 file changed, 4 insertions(+)
diff --git a/libvirt-override.c b/libvirt-override.c
index fd16916..e3b781d 100644
--- a/libvirt-override.c
+++ b/libvirt-override.c
@@ -2648,6 +2648,7 @@ cleanup:
return py_retval;
}
From: Doug Goldstein car...@cardoe.com
The functions virDomainMigrate3 and virDomainMigrateToURI3 were not
added to libvirt until v1.1.0.
---
libvirt-override.c | 4
1 file changed, 4 insertions(+)
diff --git a/libvirt-override.c b/libvirt-override.c
index c345dfe..f4d799b 100644
---
From: Daniel P. Berrange berra...@redhat.com
---
libvirt-override.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/libvirt-override.c b/libvirt-override.c
index 5f392c0..761b6a6 100644
--- a/libvirt-override.c
+++ b/libvirt-override.c
@@ -6307,6 +6307,7 @@
From: Doug Goldstein car...@cardoe.com
When building against versions of libvirt prior to 1.0.2, we can not
provide wrappers for virTypedParams* APIs. In addition we don't need
to have the helper APIs until 1.1.0 when the first API we wrap starts
to use them.
---
libvirt-override.c | 5 -
1
From: Doug Goldstein car...@cardoe.com
---
libvirt-override.c | 24
1 file changed, 24 insertions(+)
diff --git a/libvirt-override.c b/libvirt-override.c
index 4b728ef..0311579 100644
--- a/libvirt-override.c
+++ b/libvirt-override.c
@@ -3024,6 +3024,7 @@
From: Daniel P. Berrange berra...@redhat.com
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
sanitytest.py | 0
1 file changed, 0 insertions(+), 0 deletions(-)
mode change 100644 = 100755 sanitytest.py
diff --git a/sanitytest.py b/sanitytest.py
old mode 100644
new mode 100755
--
From: Doug Goldstein car...@cardoe.com
virDomainCreateXMLWithFiles() and virDomainCreateWithFiles() were not
added to libvirt until 1.1.1
---
libvirt-override.c | 4
1 file changed, 4 insertions(+)
diff --git a/libvirt-override.c b/libvirt-override.c
index f4d799b..5f392c0 100644
---
From: Doug Goldstein car...@cardoe.com
---
libvirt-override.c | 4
1 file changed, 4 insertions(+)
diff --git a/libvirt-override.c b/libvirt-override.c
index e14ca26..4b728ef 100644
--- a/libvirt-override.c
+++ b/libvirt-override.c
@@ -1824,6 +1824,7 @@ cleanup:
}
+#if
From: Doug Goldstein car...@cardoe.com
---
libvirt-override.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/libvirt-override.c b/libvirt-override.c
index e3b781d..49068ca 100644
--- a/libvirt-override.c
+++ b/libvirt-override.c
@@ -6455,7 +6455,7 @@
From: Doug Goldstein car...@cardoe.com
Create an array of modules to be built to allow for flexibility to
enable or disable some modules in the future and allow for additional
modules to be added easily
---
setup.py | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff
From: Daniel P. Berrange berra...@redhat.com
Entries in the -overrides.xml files should only be recorded
if the API also exists in the main API XML file.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
generator.py | 15 +++
1 file changed, 15 insertions(+)
diff --git
From: Doug Goldstein car...@cardoe.com
---
libvirt-override.c | 4
1 file changed, 4 insertions(+)
diff --git a/libvirt-override.c b/libvirt-override.c
index 0311579..c439403 100644
--- a/libvirt-override.c
+++ b/libvirt-override.c
@@ -6960,6 +6960,7 @@ cleanup:
return py_retval;
}
From: Daniel P. Berrange berra...@redhat.com
---
libvirt-override.c | 4
1 file changed, 4 insertions(+)
diff --git a/libvirt-override.c b/libvirt-override.c
index 1894c97..1c9d506 100644
--- a/libvirt-override.c
+++ b/libvirt-override.c
@@ -6251,6 +6251,7 @@
From: Daniel P. Berrange berra...@redhat.com
Change the generator.py to
- Take XML API file names on command line
- Generate data in build/ directory instead of cwd
---
generator.py | 69 ++--
1 file changed, 25 insertions(+), 44
From: Daniel P. Berrange berra...@redhat.com
Create a setup.py for building libvirt python code and add
supporting files
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
.gitignore | 4 +
AUTHORS.in | 12 ++
COPYING| 339
From: Doug Goldstein car...@cardoe.com
The functions that the LXC module wraps did not appear until 1.0.2 so we
can't build the module unless we're building against 1.0.2 or newer.
---
setup.py | 34 +++---
1 file changed, 23 insertions(+), 11 deletions(-)
diff --git
From: Daniel P. Berrange berra...@redhat.com
Import the macro for safely closing file descriptors
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
libvirt-utils.c | 20
libvirt-utils.h | 7 +++
2 files changed, 27 insertions(+)
diff --git a/libvirt-utils.c
From: Doug Goldstein car...@cardoe.com
---
libvirt-override.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/libvirt-override.c b/libvirt-override.c
index 1c9d506..173510e 100644
--- a/libvirt-override.c
+++ b/libvirt-override.c
@@ -419,12 +419,14 @@ cleanup:
*/
From: Doug Goldstein car...@cardoe.com
---
libvirt-override.c | 4
1 file changed, 4 insertions(+)
diff --git a/libvirt-override.c b/libvirt-override.c
index 761b6a6..3ef81dd 100644
--- a/libvirt-override.c
+++ b/libvirt-override.c
@@ -2279,6 +2279,7 @@
From: Doug Goldstein car...@cardoe.com
---
libvirt-override.c | 4
1 file changed, 4 insertions(+)
diff --git a/libvirt-override.c b/libvirt-override.c
index e24700b..dc04152 100644
--- a/libvirt-override.c
+++ b/libvirt-override.c
@@ -6781,6 +6781,7 @@ libvirt_virDomainSendKey(PyObject
From: Daniel P. Berrange berra...@redhat.com
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
setup.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/setup.py b/setup.py
index bf32e2a..17b4722 100644
--- a/setup.py
+++ b/setup.py
@@ -17,7 +17,7 @@ import os.path
From: Doug Goldstein car...@cardoe.com
---
libvirt-override.c | 4
1 file changed, 4 insertions(+)
diff --git a/libvirt-override.c b/libvirt-override.c
index 173510e..e24700b 100644
--- a/libvirt-override.c
+++ b/libvirt-override.c
@@ -4555,6 +4555,7 @@ libvirt_virDomainGetJobInfo(PyObject
FYI in order to test this from a compilation pov I wrote a script which
downloaded every older libvirt release and did a client only build and
then built the python module against it.
I'm attaching the script I used for this
I built on Fedora 19 successfully back to 0.9.11 with this, though I
On Tue, Nov 19, 2013 at 11:21:06PM +0800, Daniel Veillard wrote:
On Tue, Nov 19, 2013 at 03:05:24PM +, Daniel P. Berrange wrote:
On Tue, Nov 19, 2013 at 01:13:04PM +0800, Daniel Veillard wrote:
On Mon, Nov 18, 2013 at 09:46:00PM -0600, Doug Goldstein wrote:
On Nov 18, 2013, at 8:09
virNetSASLSessionClientStep logs the data that is going to be passed to
sasl_client_step as input data. However, it tries to log it as a string,
while there is no guarantee that this data is going to be nul-terminated.
This leads to this valgrind log:
==20938== Invalid read of size 1
==20938==
Hey,
While running virsh through valgrind for some SASL tests, I triggered some
leaks/invalid reads, this patch series fixes these.
Christophe
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
The array of sasl_callback_t callbacks which is passed to sasl_client_new()
must be kept alive as long as the created sasl_conn_t object is alive as
cyrus-sasl uses this structure internally for things like logging, so
the memory used for callbacks must only be freed after sasl_dispose() has
been
The bus type IDE being enum Zero, the bus type on pseries system appears as IDE
for all the -hda/-cdrom and for disk drives with if=none type. Pseries
platform needs this to appear as SCSI instead of IDE. The ide being not
supported, the explicit requests for ide devices will return an error.
With some authentication mechanism (PLAIN for example), sasl_client_start()
can return SASL_OK, which translates to virNetSASLSessionClientStart()
returning VIR_NET_SASL_COMPLETE.
cyrus-sasl documentation is a bit vague as to what to do in such situation,
but upstream clarified this a bit in
Hi Cole,
Thanks for the comments.
On Fri, Nov 22, 2013 at 1:54 AM, Cole Robinson crobi...@redhat.com wrote:
On 11/21/2013 03:06 PM, Shivaprasad G Bhat wrote:
From: Shivaprasad G Bhat shivaprasadb...@gmail.com
The bus type IDE being enum Zero, the bus type on pseries system appears
as
On 11/22/2013 09:59 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The python binding now lives in
http://libvirt.org/git/libvirt-python.git
that repo also provides an RPM which is upgrade compatible
with the old libvirt-python sub-RPM.
Signed-off-by:
On Fri, Nov 22, 2013 at 10:57:00AM -0700, Eric Blake wrote:
On 11/22/2013 09:59 AM, Daniel P. Berrange wrote:
run.in |9 -
and this (hmm, do we need a ./run counterpart added to libvirt-python to
make it easy to import a built but uninstalled
On 11/22/2013 11:19 AM, Daniel P. Berrange wrote:
-/python/libvirt.py
-/python/libvirt_lxc.py
-/python/libvirt_qemu.py
Oddly enough, removing these lines will mean that someone with an
incremental tree that likes to switch branches between master and any
earlier branch (say v1.0.5-maint)
The RNG grammar did not allow arbitrary interleaving, which makes
it harder than necessary to create a new volume from handwritten XML.
(Compare also to commit caf516db for pools).
* docs/schemas/storagevol.rng: Support interleaving.
* tests/storagevolxml2xmlin/vol-file-backing.xml: Test it.
On 11/22/2013 12:45 PM, Eric Blake wrote:
The RNG grammar did not allow arbitrary interleaving, which makes
it harder than necessary to create a new volume from handwritten XML.
(Compare also to commit caf516db for pools).
* docs/schemas/storagevol.rng: Support interleaving.
*
The RNG grammar did not allow arbitrary interleaving, which makes
it harder than necessary to create a new volume from handwritten XML.
(Compare also to commit caf516db for pools).
* docs/schemas/storagevol.rng: Support interleaving.
* tests/storagevolxml2xmlin/vol-file-backing.xml: Test it.
On 11/22/2013 10:26 AM, Christophe Fergeau wrote:
With some authentication mechanism (PLAIN for example), sasl_client_start()
can return SASL_OK, which translates to virNetSASLSessionClientStart()
returning VIR_NET_SASL_COMPLETE.
cyrus-sasl documentation is a bit vague as to what to do in such
On 11/22/2013 10:00 AM, Christophe Fergeau wrote:
Hey,
While running virsh through valgrind for some SASL tests, I triggered some
leaks/invalid reads, this patch series fixes these.
ACK series.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library
Chunyan Liu wrote:
Add VIR_DOMAIN_HOSTDEV_PCI_BACKEND_XEN. For legacy xen, it will use pciback
as
stub driver.
Sorry for the long delay in helping review these patches. I finally have
some time to work on libvirt :).
With the pending release, this series will have to wait for the next
[Forwarding with Laszlo's permission - if ever you wonder whether your
work on libvirt makes a difference, it does!]
Original Message
Message-ID: 528fcf54.6060...@redhat.com
Date: Fri, 22 Nov 2013 22:40:36 +0100
From: Laszlo Ersek ler...@redhat.com
Subject: Re: [Qemu-devel]
On 11/22/2013 03:02 PM, Jim Fehlig wrote:
Chunyan Liu wrote:
Add hostdev passthrough common library so that it could be shared by all
drivers
and maintain a global hostdev state.
Hi Chunyan,
Looks like you addressed all of Daniel's comments from v5. One bug fix
and a few additional
I got annoyed at having to use both 'virsh vol-list $pool --details'
AND 'virsh vol-dumpxml $vol $pool' to learn if I had populated
the volume correctly. Since two-thirds of the data present in
virStorageVolGetInfo() already appears in virStorageVolGetXMLDesc(),
this just adds the remaining piece
In the 'directory' and 'netfs' storage pools, a user can see
both 'file' and 'dir' storage volume types, to know when they
can descend into a subdirectory. But in a network-based storage
pool, such as the upcoming 'gluster' pool, we use 'network'
instead of 'file', and did not have any
Actually put gfapi to use, by allowing the creation of a gluster
pool. Right now, all volumes are treated as raw and directories
are skipped; further patches will allow peering into files to
allow for qcow2 files and backing chains, and reporting proper
volume allocation. This implementation was
We support gluster volumes in domain XML, so we also ought to
support them as a storage pool. Besides, a future patch will
want to take advantage of libgfapi to handle the case of a
gluster device holding qcow2 rather than raw storage, and for
that to work, we need a storage backend that can read
With this patch, dangling and looping symlinks are silently
ignored, while links to files and directories are treated the
same as the underlying file or directory. This is the same
behavior as both 'directory' and 'netfs' pools.
* src/storage/storage_backend_gluster.c
v3: https://www.redhat.com/archives/libvir-list/2013-November/msg00348.html
Depends on:
https://www.redhat.com/archives/libvir-list/2013-November/msg00955.html
Changes since then, addressing review feedback:
- rebase to other improvements in the meantime
- New patches 4-7
- pool changed to
Add support for a new pool type='gluster', similar to
RBD and Sheepdog. Terminology wise, a gluster volume
forms a libvirt storage pool, within the gluster volume,
individual files are treated as libvirt storage volumes.
* docs/schemas/storagepool.rng (poolgluster): New pool type.
*
Putting together pieces from previous patches, it is now possible
for 'virsh vol-dumpxml --pool gluster volname' to report metadata
about a qcow2 file stored on gluster. The backing file is still
treated as raw; to fix that, more patches are needed to make the
storage backing chain analysis
We already had code for handling allocation different than
capacity for sparse files; we just had to wire it up to be
used when inspecting gluster images.
* src/storage/storage_backend.c
(virStorageBackendUpdateVolTargetInfoFD): Handle no fd.
* src/storage/storage_backend_gluster.c
87 matches
Mail list logo
