Re: [libvirt] [PATCH python] Add python3 to the automated build and RPM

2013-12-12 Thread Martin Kletzander
On Wed, Dec 11, 2013 at 04:31:46PM +, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com This updates autobuild.sh to test the python3 build process. The RPM specfile is changed to build a libvirt-python3 RPM on Fedora 18 Signed-off-by: Daniel P. Berrange

[libvirt] [test-API][PATCH] Add new cases for testing setSchedulerParametersFlags related API

2013-12-12 Thread Xuesong Zhang
--- cases/sched_params.conf | 120 +++ repos/domain/sched_params.py | 136 --- repos/domain/sched_params_flag.py | 148 ++ 3 files changed, 330 insertions(+), 74 deletions(-) create

Re: [libvirt] [test-API][PATCH] Add new cases for testing setSchedulerParametersFlags related API

2013-12-12 Thread Guannan Ren
On 2013年12月12日 16:29, Xuesong Zhang wrote: --- cases/sched_params.conf | 120 +++ repos/domain/sched_params.py | 136 --- repos/domain/sched_params_flag.py | 148 ++ 3 files

Re: [libvirt] [PATCH 0/2] Fix interface state transitions logic

2013-12-12 Thread Laine Stump
On 12/11/2013 11:16 AM, Michal Privoznik wrote: Right now it's possible to start an interface that is already running, or destroy an interface multiple times. Such state transitions are not allowed and we check for such cases explicitly in other areas like qemu driver. I recall that someone

Re: [libvirt] RFC: Changing version number at start of dev cycle instead of end

2013-12-12 Thread Laine Stump
On 12/11/2013 06:44 PM, Daniel P. Berrange wrote: The solution here is fairly simple. We should increase the version number in configure.ac at the *start* of each release cycle. This means that libvirt-python can use the next version number and things will 'just work'. I don't think this is a

Re: [libvirt] [PATCH] Read PCI class from sysfs class file instead of config space.

2013-12-12 Thread Laine Stump
On 12/11/2013 04:46 PM, Thadeu Lima de Souza Cascardo wrote: On Wed, Dec 11, 2013 at 04:30:48PM +0200, Laine Stump wrote: Aside from the above lack of error logging, as Michal suggested a test case would be very useful. I will work on that as well. I guess this should be a different commit,

Re: [libvirt] [PATCH python] Add python3 to the automated build and RPM

2013-12-12 Thread Daniel P. Berrange
On Wed, Dec 11, 2013 at 01:01:03PM -0700, Eric Blake wrote: On 12/11/2013 09:31 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com This updates autobuild.sh to test the python3 build process. The RPM specfile is changed to build a libvirt-python3 RPM on Fedora

Re: [libvirt] [PATCH python] Add python3 to the automated build and RPM

2013-12-12 Thread Daniel P. Berrange
On Thu, Dec 12, 2013 at 08:59:33AM +0100, Martin Kletzander wrote: On Wed, Dec 11, 2013 at 04:31:46PM +, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com This updates autobuild.sh to test the python3 build process. The RPM specfile is changed to build a

[libvirt] [PATCH python v2] Add python3 to the automated build and RPM

2013-12-12 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com This updates autobuild.sh to test the python3 build process. The RPM specfile is changed to build a libvirt-python3 RPM on Fedora 18 Signed-off-by: Daniel P. Berrange berra...@redhat.com --- autobuild.sh | 14 +

Re: [libvirt] Libvirt support for KVM/ARM on armv7l hardware

2013-12-12 Thread Daniel P. Berrange
On Mon, Dec 09, 2013 at 08:02:31PM +0800, 林佳緯 wrote: I have found Libvirt supporting for armv7b in http://libvirt.org/news.html. But armv7l is not found there. Does Libvirt support run KVM/ARM for hardware virtualization on armv7l platform? It might work - AFAIK no one has tested it, but

Re: [libvirt] [PATCHv5 1/4] net-dhcp-leases: Implement the public APIs

2013-12-12 Thread Daniel P. Berrange
On Tue, Nov 26, 2013 at 02:35:58AM +0530, Nehal J Wani wrote: diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in index 5aad75c..20ea40a 100644 --- a/include/libvirt/libvirt.h.in +++ b/include/libvirt/libvirt.h.in + +typedef struct _virNetworkDHCPLeases

[libvirt] [PATCH 1/1] Make virtio as the default net device for PPC64

2013-12-12 Thread Pradipta Kr. Banerjee
From: Pradipta Kr. Banerjee bpra...@in.ibm.com Make virtio as the default net device for PPC64 Signed-off-by: Pradipta Kr. Banerjee bpra...@in.ibm.com --- src/qemu/qemu_domain.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c

Re: [libvirt] [PATCH v4 4/7] Add network events to the remote driver

2013-12-12 Thread John Ferlan
My overnight Coverity run found an issue in the function: 'remoteNetworkBuildEventLifecycle' On 12/11/2013 05:38 AM, Cédric Bosdonnat wrote: --- daemon/libvirtd.h| 1 + daemon/remote.c | 139 +++ src/remote/remote_driver.c

Re: [libvirt] [PATCHv5 2/4] net-dhcp-leases: Implement the remote protocol

2013-12-12 Thread Daniel P. Berrange
On Tue, Nov 26, 2013 at 02:35:59AM +0530, Nehal J Wani wrote: diff --git a/daemon/remote.c b/daemon/remote.c index decaecc..c2f13a8 100644 --- a/daemon/remote.c +++ b/daemon/remote.c @@ -5215,6 +5215,182 @@ cleanup: return rv; } +/* Copy contents of virNetworkDHCPLeasesPtr to

Re: [libvirt] [PATCHv5 3/4] net-dhcp-leases: Private implementation inside network

2013-12-12 Thread Daniel P. Berrange
On Tue, Nov 26, 2013 at 02:36:00AM +0530, Nehal J Wani wrote: diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 83dc931..1aedf86 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -2991,6 +3023,220 @@ cleanup: return ret; }

Re: [libvirt] [PATCHv5 4/4] net-dhcp-leases: Add virsh support

2013-12-12 Thread Daniel P. Berrange
On Tue, Nov 26, 2013 at 02:36:01AM +0530, Nehal J Wani wrote: Use virNetworkGetDHCPLeases and virNetworkGetDHCPLeasesForMAC in virsh. The new feature supports the follwing methods: 1. Retrieve leases info for a given virtual network 2. Retrieve leases info for given network interface

Re: [libvirt] [PATCH 1/1] Make virtio as the default net device for PPC64

2013-12-12 Thread Daniel P. Berrange
On Thu, Dec 12, 2013 at 05:18:13PM +0530, Pradipta Kr. Banerjee wrote: From: Pradipta Kr. Banerjee bpra...@in.ibm.com Make virtio as the default net device for PPC64 Why ? Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org

Re: [libvirt] [PATCH 1/3] cgroups: Redefine what unlimited means wrt memory limits

2013-12-12 Thread Daniel P. Berrange
On Mon, Dec 09, 2013 at 09:22:51AM +0100, Martin Kletzander wrote: Since kernel 3.12 (commit 34ff8dc08956098563989d8599840b130be81252 in linux-stable.git in particular) the value for 'unlimited' in cgroup memory limits changed from LLONG_MAX to ULLONG_MAX. Due to rather unfortunate choice of

Re: [libvirt] [PATCH 2/3] qemu: Report VIR_DOMAIN_MEMORY_PARAM_UNLIMITED properly

2013-12-12 Thread Daniel P. Berrange
On Mon, Dec 09, 2013 at 09:22:52AM +0100, Martin Kletzander wrote: For dead domains that have no memtune limits, we return 0 instead of unlimited, this patch fixes it to return PARAM_UNLIMITED. Signed-off-by: Martin Kletzander mklet...@redhat.com --- src/qemu/qemu_driver.c | 25

Re: [libvirt] [PATCH 3/3] qemu: Fix minor inconsistency in error message

2013-12-12 Thread Daniel P. Berrange
On Mon, Dec 09, 2013 at 09:22:53AM +0100, Martin Kletzander wrote: Signed-off-by: Martin Kletzander mklet...@redhat.com --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 4b93c02..a55c762

Re: [libvirt] [PATCH v3 1/4] conf: introduce generic ISA address

2013-12-12 Thread Daniel P. Berrange
On Mon, Dec 09, 2013 at 05:11:13PM +0800, Hu Tao wrote: --- docs/formatdomain.html.in | 5 docs/schemas/basictypes.rng | 17 docs/schemas/domaincommon.rng | 6 + src/conf/domain_conf.c| 63 ++-

Re: [libvirt] [PATCH v3 2/4] conf: add support for panic device

2013-12-12 Thread Daniel P. Berrange
On Mon, Dec 09, 2013 at 05:11:14PM +0800, Hu Tao wrote: panic device is a device that enables libvirt to receive notification of guest panic event. --- docs/formatdomain.html.in | 28 + docs/schemas/domaincommon.rng | 10 ++ src/conf/domain_conf.c| 72

Re: [libvirt] [PATCH v3 3/4] qemu: add support for -device pvpanic

2013-12-12 Thread Daniel P. Berrange
On Mon, Dec 09, 2013 at 05:11:15PM +0800, Hu Tao wrote: Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- src/qemu/qemu_capabilities.c | 3 +++ src/qemu/qemu_capabilities.h | 2 ++ src/qemu/qemu_command.c | 16

Re: [libvirt] [PATCH v3 4/4] test: add test for panic device

2013-12-12 Thread Daniel P. Berrange
On Mon, Dec 09, 2013 at 05:11:16PM +0800, Hu Tao wrote: --- tests/qemuxml2argvdata/qemuxml2argv-panic.args | 6 + tests/qemuxml2argvdata/qemuxml2argv-panic.xml | 31 ++ tests/qemuxml2argvtest.c | 3 +++ tests/qemuxml2xmltest.c

Re: [libvirt] [PATCH 1/1] Make virtio as the default net device for PPC64

2013-12-12 Thread Pradipta Kumar Banerjee
On 12/12/2013 05:27 PM, Daniel P. Berrange wrote: On Thu, Dec 12, 2013 at 05:18:13PM +0530, Pradipta Kr. Banerjee wrote: From: Pradipta Kr. Banerjee bpra...@in.ibm.com Make virtio as the default net device for PPC64 Why ? Hi Daniel, rtl8139 is not supported and maintained. Either of e1000,

Re: [libvirt] [PATCH 1/1] Make virtio as the default net device for PPC64

2013-12-12 Thread Daniel P. Berrange
On Thu, Dec 12, 2013 at 05:43:27PM +0530, Pradipta Kumar Banerjee wrote: On 12/12/2013 05:27 PM, Daniel P. Berrange wrote: On Thu, Dec 12, 2013 at 05:18:13PM +0530, Pradipta Kr. Banerjee wrote: From: Pradipta Kr. Banerjee bpra...@in.ibm.com Make virtio as the default net device for PPC64

Re: [libvirt] [PATCH 4/8] domain: introduce xml elements for throttle blkio cgroup

2013-12-12 Thread Daniel P. Berrange
On Wed, Dec 11, 2013 at 04:29:49PM +0800, Gao feng wrote: This patch introduces new xml elements under blkiotune, we use these new elements to setup the throttle blkio cgroup for domain. The new blkiotune node looks like this: blkiotune device path/path/to/block/path

Re: [libvirt] [PATCH 5/8] blkio: Setting throttle blkio cgroup for domain

2013-12-12 Thread Daniel P. Berrange
On Wed, Dec 11, 2013 at 04:29:50PM +0800, Gao feng wrote: This patch introduces virCgroupSetBlkioDeviceReadIops, virCgroupSetBlkioDeviceWriteIops, virCgroupSetBlkioDeviceReadBps and virCgroupSetBlkioDeviceWriteBps, we can use these interfaces to set up throttle blkio cgroup for domain.

Re: [libvirt] [PATCH 6/8] virsh: add setting throttle blkio cgroup option to blkiotune

2013-12-12 Thread Daniel P. Berrange
On Wed, Dec 11, 2013 at 04:29:51PM +0800, Gao feng wrote: With this patch, user can setup the throttle blkio cgorup for domain through the virsh cmd, such as: virsh blkiotune domain1 --device-read-bytes-sec /dev/sda1,100,/dev/sda2,200 --device-write-bytes-sec /dev/sda1,100

Re: [libvirt] [PATCH 8/8] lxc: allow to setup throttle blkio cgroup through virsh

2013-12-12 Thread Daniel P. Berrange
On Wed, Dec 11, 2013 at 04:29:53PM +0800, Gao feng wrote: With this patch,user can set throttle blkio cgroup for lxc domain through virsh tool. The functions are copied from qemu_driver. Signed-off-by: Guan Qiang hzguanqi...@corp.netease.com Signed-off-by: Gao feng gaof...@cn.fujitsu.com

Re: [libvirt] [PATCH 7/8] qemu: allow to setup throttle blkio cgroup through virsh

2013-12-12 Thread Daniel P. Berrange
On Wed, Dec 11, 2013 at 04:29:52PM +0800, Gao feng wrote: With this patch, user can setup throttle blkio cgroup through virsh for qemu domain. Signed-off-by: Guan Qiang hzguanqi...@corp.netease.com Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- src/qemu/qemu_driver.c | 425

Re: [libvirt] [PATCHv5 1/4] net-dhcp-leases: Implement the public APIs

2013-12-12 Thread Nehal J Wani
On Thu, Dec 12, 2013 at 5:14 PM, Daniel P. Berrange berra...@redhat.com wrote: On Tue, Nov 26, 2013 at 02:35:58AM +0530, Nehal J Wani wrote: diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in index 5aad75c..20ea40a 100644 --- a/include/libvirt/libvirt.h.in +++

Re: [libvirt] [PATCH v4 1/6] conf: Add a keyboard input device type

2013-12-12 Thread Daniel P. Berrange
On Thu, Dec 12, 2013 at 03:17:40PM +0800, Li Zhang wrote: From: Li Zhang zhlci...@linux.vnet.ibm.com There is no keyboard for non-x86 platforms when graphics are enabled. It's preferred to add one USB keyboard. This patch is to add keyboard input device type. Signed-off-by: Li Zhang

Re: [libvirt] [PATCH 1/1] Make virtio as the default net device for PPC64

2013-12-12 Thread Pradipta Kumar Banerjee
On 12/12/2013 05:48 PM, Daniel P. Berrange wrote: On Thu, Dec 12, 2013 at 05:43:27PM +0530, Pradipta Kumar Banerjee wrote: On 12/12/2013 05:27 PM, Daniel P. Berrange wrote: On Thu, Dec 12, 2013 at 05:18:13PM +0530, Pradipta Kr. Banerjee wrote: From: Pradipta Kr. Banerjee bpra...@in.ibm.com

Re: [libvirt] [PATCHv5 1/4] net-dhcp-leases: Implement the public APIs

2013-12-12 Thread Daniel P. Berrange
On Thu, Dec 12, 2013 at 06:00:17PM +0530, Nehal J Wani wrote: On Thu, Dec 12, 2013 at 5:14 PM, Daniel P. Berrange berra...@redhat.com wrote: On Tue, Nov 26, 2013 at 02:35:58AM +0530, Nehal J Wani wrote: diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in index

[libvirt] [PATCH] Add missing % on %{_libdir} macro in RPM

2013-12-12 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Pushed as build breaker fix Signed-off-by: Daniel P. Berrange berra...@redhat.com --- libvirt.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 9b34f3f..e22c373 100644 ---

Re: [libvirt] [PATCH 0/2] Fix interface state transitions logic

2013-12-12 Thread Michal Privoznik
On 12.12.2013 11:23, Laine Stump wrote: On 12/11/2013 11:16 AM, Michal Privoznik wrote: Right now it's possible to start an interface that is already running, or destroy an interface multiple times. Such state transitions are not allowed and we check for such cases explicitly in other areas

Re: [libvirt] [PATCH v4 4/7] Add network events to the remote driver

2013-12-12 Thread Cedric Bosdonnat
Hi John, On Thu, 2013-12-12 at 06:50 -0500, John Ferlan wrote: 4920 (3) Event returned_null: Function virNetworkEventLifecycleNew(char const *, unsigned char const *, int) returns null (checked 10 out of 11 times). [details] (14) Event var_assigned: Assigning: event = null

Re: [libvirt] [PATCH 0/2] Fix interface state transitions logic

2013-12-12 Thread Daniel P. Berrange
On Thu, Dec 12, 2013 at 12:23:48PM +0200, Laine Stump wrote: On 12/11/2013 11:16 AM, Michal Privoznik wrote: Right now it's possible to start an interface that is already running, or destroy an interface multiple times. Such state transitions are not allowed and we check for such cases

[libvirt] [PATCH] Bump version to 1.2.1 for new dev cycle

2013-12-12 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Pushed per agreement at https://www.redhat.com/archives/libvir-list/2013-December/msg00657.html Signed-off-by: Daniel P. Berrange berra...@redhat.com --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac

Re: [libvirt] [PATCH 0/2] Fix interface state transitions logic

2013-12-12 Thread Eric Blake
On 12/12/2013 07:41 AM, Daniel P. Berrange wrote: The usage you describe here is not within the scope of the virInterfaceCreate() API IMHO. If we want users to have the ability to re start an interface without taking it offline first, then we should add another API that explicitly supports

Re: [libvirt] [PATCH 0/2] Fix interface state transitions logic

2013-12-12 Thread Daniel P. Berrange
On Thu, Dec 12, 2013 at 07:54:34AM -0700, Eric Blake wrote: On 12/12/2013 07:41 AM, Daniel P. Berrange wrote: The usage you describe here is not within the scope of the virInterfaceCreate() API IMHO. If we want users to have the ability to re start an interface without taking it offline

Re: [libvirt] [PATCH 1/6] Move examples/domain-events/event-c to examples/object-events

2013-12-12 Thread Cedric Bosdonnat
On Wed, 2013-12-11 at 15:28 +, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The domain events demo program isn't really tied to domain events anymore, so rename it to object events. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- Makefile.am

Re: [libvirt] [PATCH 5/6] Remove the event namespace concept

2013-12-12 Thread Cedric Bosdonnat
On Wed, 2013-12-11 at 15:28 +, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com ... @@ -633,22 +640,17 @@ virObjectEventStateDispatchFunc(virConnectPtr conn, void *opaque) { virObjectEventStatePtr state = opaque; -

Re: [libvirt] [PATCH 00/34] network events feature v2

2013-12-12 Thread Michal Privoznik
On 11.12.2013 20:28, Eric Blake wrote: On 12/11/2013 12:15 PM, Eric Blake wrote: struct _virObjectEvent { virObject parent; int eventID; virObjectMeta meta; }; Only has alignment specified by virObject (which in turn is unsigned int, int, void*), struct _virObject {

Re: [libvirt] [PATCH 00/34] network events feature v2

2013-12-12 Thread Daniel P. Berrange
On Wed, Dec 11, 2013 at 12:28:32PM -0700, Eric Blake wrote: On 12/11/2013 12:15 PM, Eric Blake wrote: struct _virObjectEvent { virObject parent; int eventID; virObjectMeta meta; }; Only has alignment specified by virObject (which in turn is unsigned int, int,

[libvirt] [PATCH] fix libvirt alignment on arm platforms

2013-12-12 Thread Michele Paolino
With the changes added by the latest commits (e.g. 8a29ffcf9aee45b61a0a12ee45c656cfd52333e8) related to new events feature v2, we are unable to compile libvirt on ARM target (OMAP5). The error is due to alignment: conf/domain_event.c: In function 'virDomainEventDispatchDefaultFunc':

Re: [libvirt] Libvirt support for KVM/ARM on armv7l hardware

2013-12-12 Thread Michele Paolino
Hello, I'm working on it. All the basic features are already there, so it's possible to run a KVM-ARM vm using libvirt. The platform that I'm currently testing is TI OMAP5. Regards, Michele On 12/12/2013 12:33, Daniel P. Berrange wrote: On Mon, Dec 09, 2013 at 08:02:31PM +0800, 林佳緯 wrote:

[libvirt] [resend] fix libvirt alignment on arm platforms

2013-12-12 Thread Michele Paolino
With the changes added by the latest commits (e.g. 8a29ffcf9aee45b61a0a12ee45c656cfd52333e8) related to new events feature v2, we are unable to compile libvirt on ARM target (OMAP5). The error is due to alignment: conf/domain_event.c: In function 'virDomainEventDispatchDefaultFunc':

Re: [libvirt] [PATCH 00/34] network events feature v2

2013-12-12 Thread Michele Paolino
Sorry, I noticed just now that here you are discussing about the problem with the compilation of libvirt on ARM platforms. An alternative solution can be ATTRIBUTE_PACKED. I've sent right now to the ML a patch based on this. Michele On 12/12/2013 17:11, Daniel P. Berrange wrote: On Wed, Dec

Re: [libvirt] [resend] fix libvirt alignment on arm platforms

2013-12-12 Thread Eric Blake
On 12/12/2013 10:05 AM, Michele Paolino wrote: With the changes added by the latest commits (e.g. 8a29ffcf9aee45b61a0a12ee45c656cfd52333e8) related to new events feature v2, we are unable to compile libvirt on ARM target (OMAP5). The error is due to alignment: conf/domain_event.c: In

Re: [libvirt] [PATCH 00/34] network events feature v2

2013-12-12 Thread Eric Blake
On 12/12/2013 09:05 AM, Michal Privoznik wrote: Or maybe even change _virObject to contain a union: struct _virObject { union { long long align; struct { unsigned int magic; int refs; } s; } u; virClassPtr klass; } Yep. I

[libvirt] [PATCH 1/7] Move examples/domain-events/event-c to examples/object-events

2013-12-12 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The domain events demo program isn't really tied to domain events anymore, so rename it to object events. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- Makefile.am | 2 +- configure.ac

[libvirt] [PATCH 0/7 v2] Misc improvements to events code

2013-12-12 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com This is a followup to the recent network events patches to improve a few things I noticed when testing this out for real. In v2: - Changed the way event dispatch works to avoid race with creation of classes Daniel P. Berrange (7): Move

[libvirt] [PATCH 2/7] Update event demo program to support network events too

2013-12-12 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com --- examples/object-events/event-test.c | 45 +++-- 1 file changed, 43 insertions(+), 2 deletions(-) diff --git a/examples/object-events/event-test.c b/examples/object-events/event-test.c index 52aa3d0..6a279cf 100644

[libvirt] [PATCH 3/7] Add 'detail' arg to network lifecycle event internals

2013-12-12 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com While the public API wire protocol included the 'detail' arg for network lifecycle events, the internal event handling code did not process it. This meant that if a future libvirtd server starts sending non-0 'detail' args, the current libvirt client

[libvirt] [PATCH 6/7] Remove the event namespace concept

2013-12-12 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The event namespace concept is mostly redundant information. With the re-written dispatcher, the namespace is only used for equality comparisons between event IDs. This can be solved by just comparing virClassPtr instances instead. Signed-off-by:

[libvirt] [PATCH 4/7] Introduce abstract virNetworkEvent class

2013-12-12 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Inject a virNetworkEvent class between virObjectEvent and virNetworkEventLifecycle to mirror virDomainEvent. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/conf/network_event.c | 29 +++-- 1 file changed, 27

[libvirt] [PATCH 7/7] Add debug output when registering event handlers

2013-12-12 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/conf/object_event.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/conf/object_event.c b/src/conf/object_event.c index aeee6d5..80b85bd 100644 --- a/src/conf/object_event.c

[libvirt] [PATCH 5/7] Associate a dispatch function with the event objects

2013-12-12 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Instead of having the object event code have to know about each type of event and their dispatch functions, associate a dispatch function with the object instance. The dispatch code can thus be significantly simplified. Signed-off-by: Daniel P.

[libvirt] [PATCH python] Rewrite libvirt_charPtrUnwrap to work with Python 3.0-3.2

2013-12-12 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The PyUnicode_AsUTF8 method doesn't exist prior to Python 3.3. It is also somewhat inefficient, so rewrite it to use an intermediate PyBytes object. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- typewrappers.c | 19 +++ 1

Re: [libvirt] [PATCH 4/6] Introduce abstract virNetworkEvent class

2013-12-12 Thread Michal Privoznik
On 11.12.2013 16:28, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Inject a virNetworkEvent class between virObjectEvent and virNetworkEventLifecycle to mirror virDomainEvent. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/conf/network_event.c |

Re: [libvirt] [PATCH 5/6] Remove the event namespace concept

2013-12-12 Thread Michal Privoznik
On 11.12.2013 16:28, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The event namespace concept is redundant since the same information is available by looking at the class hierarchy of the events. Signed-off-by: Daniel P. Berrange berra...@redhat.com ---

Re: [libvirt] [PATCH 2/6] Update event demo program to support network events too

2013-12-12 Thread Michal Privoznik
On 11.12.2013 16:28, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com --- examples/object-events/event-test.c | 45 +++-- 1 file changed, 43 insertions(+), 2 deletions(-) diff --git a/examples/object-events/event-test.c

Re: [libvirt] [PATCH 3/6] Add 'detail' arg to network lifecycle event internals

2013-12-12 Thread Michal Privoznik
On 11.12.2013 16:28, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com While the public API wire protocol included the 'detail' arg for network lifecycle events, the internal event handling code did not process it. This meant that if a future libvirtd server starts

Re: [libvirt] [PATCH 1/6] Move examples/domain-events/event-c to examples/object-events

2013-12-12 Thread Michal Privoznik
On 11.12.2013 16:28, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The domain events demo program isn't really tied to domain events anymore, so rename it to object events. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- Makefile.am

Re: [libvirt] [PATCH 6/6] Add debug output when registering event handlers

2013-12-12 Thread Michal Privoznik
On 11.12.2013 16:28, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/conf/object_event.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/conf/object_event.c b/src/conf/object_event.c index

Re: [libvirt] [PATCH] fix libvirt alignment on arm platforms

2013-12-12 Thread Michal Privoznik
On 01.01.1970 01:03, Michele Paolino wrote: With the changes added by the latest commits (e.g. 8a29ffcf9aee45b61a0a12ee45c656cfd52333e8) related to new events feature v2, we are unable to compile libvirt on ARM target (OMAP5). The error is due to alignment: conf/domain_event.c: In function

Re: [libvirt] [PATCH] fix libvirt alignment on arm platforms

2013-12-12 Thread Eric Blake
On 12/12/2013 11:55 AM, Michal Privoznik wrote: int detail; -}; +} ATTRIBUTE_PACKED; (What an ancient e-mail :-) ) 1970 was how many years before libvirt was even started? I've raised the problem here: https://www.redhat.com/archives/libvir-list/2013-December/msg00635.html

Re: [libvirt] [PATCH python] Add python3 to the automated build and RPM

2013-12-12 Thread Eric Blake
On 12/12/2013 04:19 AM, Daniel P. Berrange wrote: +++ b/autobuild.sh @@ -13,6 +13,12 @@ python setup.py build python setup.py test python setup.py install --root=$AUTOBUILD_INSTALL_ROOT I haven't tested it, but shouldn't these lines ^^, and others similar to them, be changed to python2

Re: [libvirt] [PATCH] qemu: always ask for -enable-fips

2013-12-12 Thread Eric Blake
ping On 12/05/2013 02:54 PM, Eric Blake wrote: On a system that is enforcing FIPS, most libraries honor the current mode by default. Qemu, on the other hand, refused to honor FIPS mode unless you add the '-enable-fips' command line option; worse, this option is not discoverable via QMP, and

Re: [libvirt] [RFC/PATCH python] expose the bindings version to Python

2013-12-12 Thread Eric Blake
On 12/11/2013 08:43 PM, Doug Goldstein wrote: The method getVersion() retrieves the version of the libvirt library that the binaries are linked against but there is no way to retrieve the version of the bindings you are using. In the future if we support new APIs in Python that don't rely on

Re: [libvirt] [PATCH python v2] Add python3 to the automated build and RPM

2013-12-12 Thread Eric Blake
On 12/12/2013 04:26 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com This updates autobuild.sh to test the python3 build process. The RPM specfile is changed to build a libvirt-python3 RPM on Fedora 18 Signed-off-by: Daniel P. Berrange berra...@redhat.com ---

Re: [libvirt] [PATCH python] Rewrite libvirt_charPtrUnwrap to work with Python 3.0-3.2

2013-12-12 Thread Eric Blake
On 12/12/2013 11:16 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The PyUnicode_AsUTF8 method doesn't exist prior to Python 3.3. It is also somewhat inefficient, so rewrite it to use an intermediate PyBytes object. Signed-off-by: Daniel P. Berrange

[libvirt] [PATCH] object: require maximal alignment in base class

2013-12-12 Thread Eric Blake
Recent changes to events (commit 8a29ffcf) resulted in new compile failures on some targets (such as ARM OMAP5): conf/domain_event.c: In function 'virDomainEventDispatchDefaultFunc': conf/domain_event.c:1198:30: error: cast increases required alignment of target type [-Werror=cast-align]

[libvirt] [PATCH V2 RESEND 7/8] qemu: allow to setup throttle blkio cgroup through virsh

2013-12-12 Thread Gao feng
With this patch, user can setup throttle blkio cgroup through virsh for qemu domain. Signed-off-by: Guan Qiang hzguanqi...@corp.netease.com Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- src/qemu/qemu_driver.c | 442 - 1 file changed, 404

[libvirt] [PATCH V2 RESEND 8/8] lxc: allow to setup throttle blkio cgroup through virsh

2013-12-12 Thread Gao feng
With this patch,user can set throttle blkio cgroup for lxc domain through virsh tool. Signed-off-by: Guan Qiang hzguanqi...@corp.netease.com Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- src/lxc/lxc_driver.c | 671 +-- 1 file changed, 646

Re: [libvirt] [PATCH v3 1/4] conf: introduce generic ISA address

2013-12-12 Thread Eric Blake
On 12/12/2013 05:07 AM, Daniel P. Berrange wrote: On Mon, Dec 09, 2013 at 05:11:13PM +0800, Hu Tao wrote: Commit message should mention the new XML. --- docs/formatdomain.html.in | 5 docs/schemas/basictypes.rng | 17 docs/schemas/domaincommon.rng | 6 +

Re: [libvirt] [PATCH v3 2/4] conf: add support for panic device

2013-12-12 Thread Eric Blake
On 12/12/2013 05:08 AM, Daniel P. Berrange wrote: On Mon, Dec 09, 2013 at 05:11:14PM +0800, Hu Tao wrote: panic device is a device that enables libvirt to receive notification of guest panic event. --- docs/formatdomain.html.in | 28 + docs/schemas/domaincommon.rng | 10

Re: [libvirt] [PATCH v3 3/4] qemu: add support for -device pvpanic

2013-12-12 Thread Eric Blake
On 12/09/2013 02:11 AM, Hu Tao wrote: Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- src/qemu/qemu_capabilities.c | 3 +++ src/qemu/qemu_capabilities.h | 2 ++ src/qemu/qemu_command.c | 16

Re: [libvirt] [PATCH v4 0/6] Support keyboard device

2013-12-12 Thread Li Zhang
ping ... On 2013年12月12日 15:17, Li Zhang wrote: From: Li Zhang zhlci...@linux.vnet.ibm.com This patchset is to add keyboard input device. For PPC64, it doesn't support a default keyboard device when the graphic is enabled. Libvirt supports QEMU command line as -device VGA which won't create

Re: [libvirt] [PATCH v3 3/4] qemu: add support for -device pvpanic

2013-12-12 Thread Hu Tao
On Thu, Dec 12, 2013 at 09:20:43PM -0700, Eric Blake wrote: On 12/09/2013 02:11 AM, Hu Tao wrote: Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- src/qemu/qemu_capabilities.c | 3 +++ src/qemu/qemu_capabilities.h | 2 ++ src/qemu/qemu_command.c

Re: [libvirt] [PATCH] fix libvirt alignment on arm platforms

2013-12-12 Thread Michal Privoznik
On 12.12.2013 20:27, Eric Blake wrote: On 12/12/2013 11:55 AM, Michal Privoznik wrote: int detail; -}; +} ATTRIBUTE_PACKED; (What an ancient e-mail :-) ) 1970 was how many years before libvirt was even started? I've raised the problem here: