Re: [libvirt] [PATCH v3] BSD: implement nodeGetMemoryStats

2014-01-06 Thread Roman Bogorodskiy
John Ferlan wrote: > On 01/03/2014 01:35 PM, Roman Bogorodskiy wrote: > > Add a BSD implementation of nodeGetMemoryStats based > > on sysctl(3). > > --- > > src/nodeinfo.c | 82 > > +- > > 1 file changed, 81 insertions(+), 1 deletion(-) >

[libvirt] vm tunable memory and cgroup

2014-01-06 Thread yue
hi,all 1. is there any relationship between cgroup and tunable memory ? if i adjust vm's memory, if cgroup has any responding action? 1048576 524288 2. it seems that the memory.limit_in_bytes of a vm in cgroup is twice over vm's assigned memory? addtional, blkio.sectors does not equal sectors

Re: [libvirt] [PATCH 10/24] maint: improve VIR_ERR_INVALID_CONN usage

2014-01-06 Thread Eric Blake
On 01/02/2014 04:32 PM, John Ferlan wrote: > > > On 12/28/2013 11:11 AM, Eric Blake wrote: >> The datatype.c object checks could result in a message like: >> >> error: invalid connection pointer in no connection >> >> This consolidates all clients of this message to have uniform contents: >> >> e

Re: [libvirt] CVE-2013-6456 Re: [PATCHv2 0/7] lxc: honor mount namespaces

2014-01-06 Thread Eric Blake
On 12/24/2013 06:45 AM, Reco wrote: > On Tue, 24 Dec 2013 06:29:11 -0700 > Eric Blake wrote: > >> diff --git i/src/util/virprocess.c w/src/util/virprocess.c >> index c99b75a..e069483 100644 >> --- i/src/util/virprocess.c >> +++ w/src/util/virprocess.c >> @@ -879,7 +879,7 @@ virProcessRunInMountNa

[libvirt] [PATCH] Fix argument order at qemuMigrationPerformJob().

2014-01-06 Thread Minoru Usui
Hi, everyone. I found a small bug at qemuMigrationPerformJob(). The order of argument, @listenAddress and @cookiein, should be changed place, because these order are mismatched caller and callee. Signed-off-by: Minoru Usui --- src/qemu/qemu_migration.c |2 +- 1 files changed, 1 insertions(+

Re: [libvirt] [PATCH] libxl: Fix initialization of nictype in libxl_device_nic

2014-01-06 Thread Jim Fehlig
Eric Blake wrote: > On 01/06/2014 11:59 AM, Jim Fehlig wrote: > >> As pointed out by the Xen folks [1], HVM nics should always be set >> to type LIBXL_NIC_TYPE_VIF_IOEMU unless the user explicity requests >> LIBXL_NIC_TYPE_VIF via model='netfront'. The current logic in >> libxlMakeNic() only se

[libvirt] [PATCHv2 12/14] event [squash with next]: test per-domain events of offline domain

2014-01-06 Thread Eric Blake
* tests/objecteventtest.c (testDomainCreateXMLMixed): Enhance test. --- tests/objecteventtest.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tests/objecteventtest.c b/tests/objecteventtest.c index cc39dcf..65642a2 100644 --- a/tests/objecteventtest.c +++ b/tests/objecteve

[libvirt] [PATCHv2 13/14] event: don't turn offline domain into global event

2014-01-06 Thread Eric Blake
If a user registers for a domain event filtered to a particular domain, but the persistent domain is offline at the time, then the code silently failed to set up the filter. As a result, the event fires for all domains, rather than being filtered. Network events were immune, since they always pass

[libvirt] [PATCHv2 14/14] event: make network events easier to use without casts

2014-01-06 Thread Eric Blake
While comparing network and domain events, I noticed that the test driver had to do a cast in one place and not the other. For consistency, we should hide the necessary casting as low as possible in the stack, with everything else using saner types. * src/conf/network_event.h (virNetworkEventState

[libvirt] [PATCHv2 06/14] event [squash with next]: test that old-style can't clobber new-style

2014-01-06 Thread Eric Blake
Test the previous patch. * tests/objecteventtest.c (testDomainCreateXMLMixed): New test. Signed-off-by: Eric Blake --- tests/objecteventtest.c | 69 +++-- 1 file changed, 67 insertions(+), 2 deletions(-) diff --git a/tests/objecteventtest.c b/tests/o

[libvirt] [PATCHv2 09/14] event: properly filter count of remaining events

2014-01-06 Thread Eric Blake
On the surface, this sequence of API calls should succeed: id1 = virConnectDomainEventRegisterAny(..., VIR_DOMAIN_EVENT_ID_LIFECYCLE,...); id2 = virConnectDomainEventRegisterAny(..., VIR_DOMAIN_EVENT_ID_RTC_CHANGE,...); virConnectDomainEventDeregisterAny(id1); id1 = virConnectDomainEventRegisterAn

[libvirt] [PATCHv2 10/14] event [squash with next]: test that old-style is distinct from new-style

2014-01-06 Thread Eric Blake
* tests/objecteventtest.c (testDomainCreateXMLMixed): Enhance test. Signed-off-by: Eric Blake --- tests/objecteventtest.c | 37 + 1 file changed, 25 insertions(+), 12 deletions(-) diff --git a/tests/objecteventtest.c b/tests/objecteventtest.c index 649fc25..c

[libvirt] [PATCHv2 08/14] event: tighten scope of object_event

2014-01-06 Thread Eric Blake
Tighten up scope after the previous patch avoided using internals. This will also make it easier to change internal implementation without having to chase down quite as many impacted callers or worrying about two files getting implementations out of sync. * src/conf/object_event_private.h (virObj

[libvirt] [PATCHv2 11/14] event: don't allow mix of old- and new-style registration

2014-01-06 Thread Eric Blake
Consider these two calls, in either order: id1 = virConnectDomainEventRegisterAny(conn, NULL, VIR_DOMAIN_EVENT_ID_LIFECYCLE, VIR_DOMAIN_EVENT_CALLBACK(callback), NULL, NULL); virConnectDomainEventRegister(conn, callback, NULL, NULL); Right now, the second call fails, because under the hood,

[libvirt] [PATCHv2 02/14] event: make deregister return value match docs

2014-01-06 Thread Eric Blake
Ever since their introduction (commit 1509b80 in v0.5.0 for virConnectDomainEventRegister, commit 4445723 in v0.8.0 for virConnectDomainEventDeregisterAny), the event deregistration functions have been documented as returning 0 on success; likewise for older registration (only the newer RegisterAny

[libvirt] [PATCHv2 05/14] event: rename confusing variable in test, remote drivers

2014-01-06 Thread Eric Blake
Since the introduction of network events, any driver that uses a single event state object to track both domain and network events should not include 'domain' in the name of that object. * src/test/test_driver.c (_testConn): s/domainEventState/eventState/, and fix all callers. * src/remote/remote_

[libvirt] [PATCHv2 07/14] event: don't let old-style events clobber per-domain events

2014-01-06 Thread Eric Blake
Right now, the older virConnectDomainEventRegister (takes a function pointer, returns 0 on success) and the newer virConnectDomainEventRegisterID (takes an eventID, returns a callbackID) share the underlying implementation (the older API ends up consuming a callbackID for eventID 0 under the hood).

[libvirt] [PATCHv2 03/14] event [squash with next]: test shared state driver in test:///default

2014-01-06 Thread Eric Blake
The updated testsuite fails without the rest of this patch. Valgrind didn't report any leaks. * tests/objecteventtest.c (testDomainStartStopEvent): Enhance to cover this. (timeout, mymain): Ensure test fails rather than blocks. Signed-off-by: Eric Blake --- tests/objecteventtest.c | 49

[libvirt] [PATCHv2 00/14] event cleanups

2014-01-06 Thread Eric Blake
I'm sitting on quite a few event fixes, prior to being able to reach my goal of adding a new api to libvirt-qemu.so for querying arbitrary monitor events. For testing purposes, I split the tests from the code changes, to make it easier (at least for me) to prove what the bugs are, and how the code

[libvirt] [PATCHv2 04/14] event: share state driver between test:///default connections

2014-01-06 Thread Eric Blake
Prior to this patch, every test:/// URI has its own event manager, which means that registering for an event can only ever receive events from the connection where it issued the API that triggered the event. But the whole idea of events is to be able to learn about something where an API call did

[libvirt] [PATCHv2 01/14] event [squash with next]: add test of old-style events

2014-01-06 Thread Eric Blake
Ensure our testsuite has some coverage of old-style domain event registration. * tests/objecteventtest.c (testDomainCreateXMLOld): New test. (mymain): Run it. (testDomainCreateXML): Check return values. Signed-off-by: Eric Blake --- tests/objecteventtest.c | 73 +

Re: [libvirt] [PATCH] lxcDomainShutdownFlags: Cleanup @flags usage

2014-01-06 Thread Eric Blake
On 01/06/2014 03:18 AM, Michal Privoznik wrote: + +if (initctlRequested || !flags) +useInitctl = true; >>> >>> I'm not sure this logic is right. >> >> Yuck - commit aa4619337 is broken. >> >>> >> >> This is still unfortunately the case in what you pushed. And how come

Re: [libvirt] [PATCH] libxl: Fix initialization of nictype in libxl_device_nic

2014-01-06 Thread Eric Blake
On 01/06/2014 11:59 AM, Jim Fehlig wrote: > As pointed out by the Xen folks [1], HVM nics should always be set > to type LIBXL_NIC_TYPE_VIF_IOEMU unless the user explicity requests > LIBXL_NIC_TYPE_VIF via model='netfront'. The current logic in > libxlMakeNic() only sets the nictype to LIBXL_NIC_T

[libvirt] [PATCH] build: fix bootstrap with older autoconf

2014-01-06 Thread Eric Blake
Pavel Hrdina reported to me off-list that my gnulib update on Jan 1 broke the build on RHEL 6.4 and older: executing aclocal -I glm4 glm4/gl-openssl.m4:11: error: m4_defn: undefined macro: _m4_divert_diversion glm4/gl-openssl.m4:11: the top level autom4te: /usr/bin/m4 failed with e

Re: [libvirt] [Xen-devel] Setting devid for emulated NICs (Xen 4.3.1 / libvirt 1.2.0) using libxl driver

2014-01-06 Thread Jim Fehlig
Jim Fehlig wrote: > Ian Campbell wrote: > >> On Thu, 2013-12-19 at 11:39 -0700, Jim Fehlig wrote: >> >> >>> Stefan Bader wrote: >>> >>> Oh, just while talking about setdefault. Jim, this is one of the odd things when moving from xm to xl stack from libvirt: li

[libvirt] [PATCH] libxl: Fix initialization of nictype in libxl_device_nic

2014-01-06 Thread Jim Fehlig
As pointed out by the Xen folks [1], HVM nics should always be set to type LIBXL_NIC_TYPE_VIF_IOEMU unless the user explicity requests LIBXL_NIC_TYPE_VIF via model='netfront'. The current logic in libxlMakeNic() only sets the nictype to LIBXL_NIC_TYPE_VIF_IOEMU if a model is specified that is not

Re: [libvirt] device removal

2014-01-06 Thread Serge Hallyn
Quoting Michal Privoznik (mpriv...@redhat.com): > On 03.01.2014 05:38, Serge Hallyn wrote: > > Hi, > > > > one of our tests was complaining that after an attach-device > > followed by detach-device, the device was still in the vm's > > apparmor whitelist. It turns out the device actually also > >

Re: [libvirt] [PATCH 2/2] storage: Polling the sysfs for pool with "fc_host" type adapter

2014-01-06 Thread John Ferlan
On 01/06/2014 05:19 AM, Osier Yang wrote: > The SCSI device corresponding to the vHBA might not show up in > sysfs yet when we trying to scan the LUNs. As a result, we will > end up with an empty volume set for the pool after pool-start, > even if there are LUNs. So what causes the "delay" to ge

Re: [libvirt] [PATCH] maint: Fix messy include of libvirt_internal.h

2014-01-06 Thread Eric Blake
On 01/06/2014 09:40 AM, Peter Krempa wrote: > The libvirt_internal.h header was included by the internal.h header. > This made it painful to add new stuff to the header file that would > require some more specific types. Remove inclusion by internal.h and add > it to appropriate places manually. >

Re: [libvirt] [php-libvirt] minimal libvirt requirement

2014-01-06 Thread Michal Novotny
On 01/06/2014 05:56 PM, Remi Collet wrote: > Le 06/01/2014 16:48, Michal Novotny a écrit : >> Hi Remi, >> thanks for catching it, feel free to write a patch for this (and also >> take ownership of of php-libvirt in Fedora if interested - this has been >> sent to your corporate e-mail: rcol...@redh

Re: [libvirt] [PATCH 1/2] storage: Fix autostart of pool with "fc_host" type adapter

2014-01-06 Thread John Ferlan
On 01/06/2014 05:19 AM, Osier Yang wrote: > The "checkPool" is a bit different for pool with "fc_host" > type source adapter, since the vHBA it's based on might be > not created yet (it's created by "startPool", which is > involked after "checkPool" in storageDriverAutostart). So it > should not

Re: [libvirt] [PATCH libvirt-java] spec: Only install unversioned jar file

2014-01-06 Thread Cole Robinson
On 12/18/2013 02:58 AM, Claudio Bley wrote: > At Tue, 17 Dec 2013 16:34:11 -0500, > Cole Robinson wrote: >> >> As intended by Fedora's java packaging guidelines: >> >> https://bugzilla.redhat.com/show_bug.cgi?id=1022139 >> --- >> libvirt-java.spec.in | 3 +-- >> 1 file changed, 1 insertion(+), 2 d

Re: [libvirt] [php-libvirt] minimal libvirt requirement

2014-01-06 Thread Michal Novotny
Hi Remi, thanks for catching it, feel free to write a patch for this (and also take ownership of of php-libvirt in Fedora if interested - this has been sent to your corporate e-mail: rcol...@redhat.com ). Thanks, Michal On 01/06/2014 03:58 PM, Remi Collet wrote: > Hi, > > >From configure: LIBVIRT

Re: [libvirt] [php-libvirt] minimal libvirt requirement

2014-01-06 Thread Remi Collet
Le 06/01/2014 16:48, Michal Novotny a écrit : > Hi Remi, > thanks for catching it, feel free to write a patch for this (and also > take ownership of of php-libvirt in Fedora if interested - this has been > sent to your corporate e-mail: rcol...@redhat.com ). I have already taken ownership of the F

[libvirt] [PATCH 8/8] storage: Improve error message when a storage backend is missing

2014-01-06 Thread Peter Krempa
Include the name of the storage backend in the error message instead of just the number. --- src/storage/storage_backend.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/storage/storage_backend.c b/src/storage/storage_backend.c index b08d646..19fb1f0 100644 --- a/src/sto

[libvirt] [PATCH 5/8] storage: disk: Separate creating of the volume from building

2014-01-06 Thread Peter Krempa
Separate the steps to create libvirt's volume metadata from the actual volume building process. --- src/storage/storage_backend_disk.c | 44 ++ 1 file changed, 30 insertions(+), 14 deletions(-) diff --git a/src/storage/storage_backend_disk.c b/src/storage/stor

[libvirt] [PATCH 1/8] storage: fs: Fix comment for virStorageBackendFileSystemDelete

2014-01-06 Thread Peter Krempa
The comment was talking about creating the pool while the function is deleting it. Fix the mismatch. --- src/storage/storage_backend_fs.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/storage/storage_backend_fs.c b/src/storage/storage_backend_fs.c index 95783be..6eb

[libvirt] [PATCH 7/8] storage: Sheepdog: Separate creating of the volume from building

2014-01-06 Thread Peter Krempa
Separate the steps to create libvirt's volume metadata from the actual volume building process. --- src/storage/storage_backend_sheepdog.c | 29 ++--- 1 file changed, 26 insertions(+), 3 deletions(-) diff --git a/src/storage/storage_backend_sheepdog.c b/src/storage/storag

[libvirt] [PATCH 6/8] storage: RBD: Separate creating of the volume from building

2014-01-06 Thread Peter Krempa
Separate the steps to create libvirt's volume metadata from the actual volume building process. --- src/storage/storage_backend_rbd.c | 41 --- 1 file changed, 34 insertions(+), 7 deletions(-) diff --git a/src/storage/storage_backend_rbd.c b/src/storage/storag

[libvirt] [PATCH 2/8] storage: Support deletion of volumes on gluster pools

2014-01-06 Thread Peter Krempa
Implement the "deleteVol" storage backend function for gluster volumes. --- src/storage/storage_backend_gluster.c | 64 +++ 1 file changed, 64 insertions(+) diff --git a/src/storage/storage_backend_gluster.c b/src/storage/storage_backend_gluster.c index 2ec2424..c

[libvirt] [PATCH 4/8] storage: lvm: Separate creating of the volume from building

2014-01-06 Thread Peter Krempa
Separate the steps to create libvirt's volume metadata from the actual volume building process. This is already done for regular file based pools to allow job support for storage APIs. --- src/storage/storage_backend_logical.c | 60 +-- 1 file changed, 37 insertions

[libvirt] [PATCH 3/8] storage: lvm: Avoid forward decl of virStorageBackendLogicalDeleteVol

2014-01-06 Thread Peter Krempa
Change code ordering to avoid the need for a forward declaration. --- src/storage/storage_backend_logical.c | 67 --- 1 file changed, 31 insertions(+), 36 deletions(-) diff --git a/src/storage/storage_backend_logical.c b/src/storage/storage_backend_logical.c index

[libvirt] [PATCH 0/8] storage: separate storage volume creation from building

2014-01-06 Thread Peter Krempa
This series splits the internal storage volume metadata creation from actual volume building and adds support for deletion of guster volumes. Peter Krempa (8): storage: fs: Fix comment for virStorageBackendFileSystemDelete storage: Support deletion of volumes on gluster pools storage: lvm: A

[libvirt] [PATCH] maint: Fix messy include of libvirt_internal.h

2014-01-06 Thread Peter Krempa
The libvirt_internal.h header was included by the internal.h header. This made it painful to add new stuff to the header file that would require some more specific types. Remove inclusion by internal.h and add it to appropriate places manually. --- src/driver.h | 1 + src/internal.h

[libvirt] [RFC PATCH 0/3] improve virtio-serial port address allocation

2014-01-06 Thread Jonathan Lebon
This series of patches improves the way in which virtio-serial port addresses are handled. See BZ1042505[1] for more background information. In a nutshell, the issue is that libvirt always assigns ports to the same virtio-serial controller (index 0). It does not take into account the maximum number

[libvirt] [RFC PATCH 2/3] check for out-of-range virtio-serial ports

2014-01-06 Thread Jonathan Lebon
Virtio-serial ports that have a number too high are rejected. The maximum port number is retrieved from the ports attribute of the controller if present, otherwise defaulting to 31. --- src/conf/domain_conf.c | 20 1 file changed, 20 insertions(+) diff --git a/src/conf/domain

[libvirt] [RFC PATCH 3/3] assign free controller to virtio-serial port

2014-01-06 Thread Jonathan Lebon
When no element is explicitly given, the virtio-serial port is automatically assigned a controller which is known to have a free port available. --- src/conf/domain_conf.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/

[libvirt] [RFC PATCH 1/3] add new function virDomainGetVirtioMaxPort

2014-01-06 Thread Jonathan Lebon
This function is then used to simplify port assignment. It will also be used in upcoming patches. --- src/conf/domain_conf.c | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index e65f3e3..2bade1b 1

Re: [libvirt] [PATCH V3] AArch64: Porting of armv7l conditons to run qemu for aarch64.

2014-01-06 Thread Cole Robinson
On 01/02/2014 05:42 AM, Pranavkumar Sawargaonkar wrote: > AArch64 qemu has similar behavior as armv7l, like use of mmio etc. > This patch adds similar bypass checks what we have for armv7l to aarch64. > E.g. we are enabling mmio transport for Nicdev. > Making addDefaultUSB and addDefaultMemballoon

Re: [libvirt] [PATCH 2/2] qemu: Don't fail if the SCSI host device is shareable between domains

2014-01-06 Thread John Ferlan
On 01/02/2014 09:45 AM, Osier Yang wrote: > It doesn't make sense to fail if the SCSI host device is specified > as "shareable" explicitly between domains (NB, it works if and only > if the device is specified as "shareable" for *all* domains, > otherwise it fails). > > Also don't try to add the

Re: [libvirt] [PATCH 1/2] util: Add "shareable" field for virSCSIDevice struct

2014-01-06 Thread John Ferlan
On 01/02/2014 09:45 AM, Osier Yang wrote: > Unlike the host devices of other types, SCSI host device XML supports > "shareable" tag. This patch introduces it for the virSCSIDevice struct > for a later patch use (to detect if the SCSI device is shareable when > preparing the SCSI host device in QE

Re: [libvirt] [PATCH 09/24] maint: improve VIR_ERR_OPERATION_DENIED usage

2014-01-06 Thread Eric Blake
On 01/02/2014 04:08 PM, John Ferlan wrote: > > > On 12/28/2013 11:11 AM, Eric Blake wrote: >> Some of our operation denied messages are outright stupid; for >> example, if virIdentitySetAttr fails: >> >> error: operation Identity attribute is already set forbidden for read only >> access >> >> T

Re: [libvirt] [PATCH] storage: Use VIR_DELETE_ELEMENT instead of open coding

2014-01-06 Thread Peter Krempa
On 01/06/14 15:18, Ján Tomko wrote: > On 01/06/2014 03:04 PM, Peter Krempa wrote: >> Replace the open coded array element deletion by our new helper. >> --- >> src/storage/storage_driver.c | 11 +-- >> 1 file changed, 1 insertion(+), 10 deletions(-) >> >> > > ACK Thanks; Pushed. > > J

Re: [libvirt] [PATCH 0/2] qemu: add range check for numa memory placement mode

2014-01-06 Thread Peter Krempa
On 01/06/14 15:56, John Ferlan wrote: > > > On 01/06/2014 08:33 AM, Peter Krempa wrote: >> Peter Krempa (2): >> qemu: Clean up qemuDomainSetNumaParameters >> qemu: range check numa memory placement mode >> >> src/qemu/qemu_driver.c | 38 +++--- >> 1 file chang

[libvirt] [php-libvirt] minimal libvirt requirement

2014-01-06 Thread Remi Collet
Hi, >From configure: LIBVIRT_REQUIRED=0.6.2 But build fails with < 0.9 Tested with 0.8.8 and 0.8.2 (RHEL-5) libvirt-php.c:1080: error: 'VIR_NODE_CPU_STATS_ALL_CPUS' undeclared (first use in this function) Thanks Remi. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/

Re: [libvirt] [PATCH 3/2] event: use newer array management macros

2014-01-06 Thread Eric Blake
On 01/06/2014 07:06 AM, John Ferlan wrote: > > > On 01/03/2014 04:11 PM, Eric Blake wrote: >> We might as well take advantage of viralloc.h instead of open-coding >> array management ourselves. While at it, I simplified several >> places that were doing repetitive pointer chasing to use an >> in

Re: [libvirt] [PATCH 1/2] event: use bool in more places

2014-01-06 Thread Eric Blake
On 01/06/2014 03:35 AM, Osier Yang wrote: > On 04/01/14 03:31, Eric Blake wrote: >> No need to use an int that only ever stores 0 and 1. >> >> * src/conf/object_event_private.h (_virObjectEventCallback): >> Change deleted to bool. >> * src/conf/object_event.c (virObjectEventDispatchMatchCallback):

Re: [libvirt] [PATCH 0/2] qemu: add range check for numa memory placement mode

2014-01-06 Thread John Ferlan
On 01/06/2014 08:33 AM, Peter Krempa wrote: > Peter Krempa (2): > qemu: Clean up qemuDomainSetNumaParameters > qemu: range check numa memory placement mode > > src/qemu/qemu_driver.c | 38 +++--- > 1 file changed, 23 insertions(+), 15 deletions(-) > ACK ser

Re: [libvirt] [PATCH 4/2] event: add test of old-style events

2014-01-06 Thread Eric Blake
On 01/06/2014 07:27 AM, John Ferlan wrote: > I've only been able to apply up thru patch 5/5a... patch 2 didn't apply > as well: > > Applying: event: make deregister return value match docs > error: patch failed: src/lxc/lxc_driver.c:1 > error: src/lxc/lxc_driver.c: patch does not apply > error: p

Re: [libvirt] [PATCH 4/2] event: add test of old-style events

2014-01-06 Thread John Ferlan
On 01/03/2014 05:15 PM, Eric Blake wrote: > Ensure our testsuite has some coverage of old-style domain > event registration. > > * tests/objecteventtest.c (testDomainCreateXMLOld): New test. > (mymain): Run it. > (testDomainCreateXML): Check return values. > > Signed-off-by: Eric Blake > --- >

Re: [libvirt] [PATCH] storage: Use VIR_DELETE_ELEMENT instead of open coding

2014-01-06 Thread Eric Blake
On 01/06/2014 07:04 AM, Peter Krempa wrote: > Replace the open coded array element deletion by our new helper. > --- > src/storage/storage_driver.c | 11 +-- > 1 file changed, 1 insertion(+), 10 deletions(-) ACK. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualizatio

Re: [libvirt] [PATCH] storage: Use VIR_DELETE_ELEMENT instead of open coding

2014-01-06 Thread Ján Tomko
On 01/06/2014 03:04 PM, Peter Krempa wrote: > Replace the open coded array element deletion by our new helper. > --- > src/storage/storage_driver.c | 11 +-- > 1 file changed, 1 insertion(+), 10 deletions(-) > > diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c > in

Re: [libvirt] [PATCH 3/2] event: use newer array management macros

2014-01-06 Thread John Ferlan
On 01/03/2014 04:11 PM, Eric Blake wrote: > We might as well take advantage of viralloc.h instead of open-coding > array management ourselves. While at it, I simplified several > places that were doing repetitive pointer chasing to use an > intermediate variable for legibility (some other places

[libvirt] [PATCH] storage: Use VIR_DELETE_ELEMENT instead of open coding

2014-01-06 Thread Peter Krempa
Replace the open coded array element deletion by our new helper. --- src/storage/storage_driver.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index baba9c9..aaa0f02 100644 --- a/src/storage/storage_driv

Re: [libvirt] [PATCH 2/2] event: make deregister return value match docs

2014-01-06 Thread Eric Blake
On 01/06/2014 04:16 AM, Osier Yang wrote: > On 04/01/14 03:31, Eric Blake wrote: >> Ever since their introduction (commit 1509b80 in v0.5.0 for >> virConnectDomainEventRegister, commit 4445723 in v0.8.0 for >> virConnectDomainEventDeregisterAny), the event deregistration >> functions have been docu

[libvirt] Entering freeze on Wednesday for 1.2.1

2014-01-06 Thread Daniel Veillard
Hello, Happy New Year and best wishes for 2014 ! small reminder after the vacations, based on our earlier decision to make a release mid-january and then the next one at the end of feb, we should enter freeze in the middle of the week to be able to make the release around the 15th,

[libvirt] [PATCH 2/2] qemu: range check numa memory placement mode

2014-01-06 Thread Peter Krempa
https://bugzilla.redhat.com/show_bug.cgi?id=1047234 Add a range check for supported numa memory placement modes provided by the user before setting them in the domain definition. Without the check the user is able to provide a (yet) unknown mode which is then stored in the domain definition. This

[libvirt] [PATCH 1/2] qemu: Clean up qemuDomainSetNumaParameters

2014-01-06 Thread Peter Krempa
Add whitespace to separate logical code blocks, reformat error messages and clean up code flow. This patch changes error handling in some cases where the the loop would be continued to jump to cleanup instead and error out rather than modify the domain any further. --- src/qemu/qemu_driver.c | 30

[libvirt] [PATCH 0/2] qemu: add range check for numa memory placement mode

2014-01-06 Thread Peter Krempa
Peter Krempa (2): qemu: Clean up qemuDomainSetNumaParameters qemu: range check numa memory placement mode src/qemu/qemu_driver.c | 38 +++--- 1 file changed, 23 insertions(+), 15 deletions(-) -- 1.8.5.2 -- libvir-list mailing list libvir-list@redhat.com http

Re: [libvirt] Bug 1047429 – Can't attach virtio disk device with 'internal error: Device alias was not set for PCI controller with index 0 required for device at address 0000:00:1e.0'

2014-01-06 Thread Laine Stump
On 01/06/2014 01:22 PM, Laine Stump wrote: > On 01/06/2014 06:22 AM, hzguanqi...@corp.netease.com wrote: >> Hi experts, >> It seemed there is a bug of PCI controller, details are as: >> https://bugzilla.redhat.com/show_bug.cgi?id=1047429 >> >> Is there any expert focusing on this problem? > > Yes

Re: [libvirt] [PATCH v3] BSD: implement nodeGetMemoryStats

2014-01-06 Thread John Ferlan
On 01/03/2014 01:35 PM, Roman Bogorodskiy wrote: > Add a BSD implementation of nodeGetMemoryStats based > on sysctl(3). > --- > src/nodeinfo.c | 82 > +- > 1 file changed, 81 insertions(+), 1 deletion(-) > ACK John -- libvir-list maili

Re: [libvirt] Bug 1047429 – Can't attach virtio disk device with 'internal error: Device alias was not set for PCI controller with index 0 required for device at address 0000:00:1e.0'

2014-01-06 Thread Laine Stump
On 01/06/2014 06:22 AM, hzguanqi...@corp.netease.com wrote: > Hi experts, > It seemed there is a bug of PCI controller, details are as: > https://bugzilla.redhat.com/show_bug.cgi?id=1047429 > > Is there any expert focusing on this problem? Yes, I understand the problem, and am writing a comment

Re: [libvirt] [PATCH 2/2] event: make deregister return value match docs

2014-01-06 Thread Osier Yang
On 04/01/14 03:31, Eric Blake wrote: Ever since their introduction (commit 1509b80 in v0.5.0 for virConnectDomainEventRegister, commit 4445723 in v0.8.0 for virConnectDomainEventDeregisterAny), the event deregistration functions have been documented as returning 0 on success; likewise for older r

Re: [libvirt] [PATCH 1/2] event: use bool in more places

2014-01-06 Thread Osier Yang
On 04/01/14 03:31, Eric Blake wrote: No need to use an int that only ever stores 0 and 1. * src/conf/object_event_private.h (_virObjectEventCallback): Change deleted to bool. * src/conf/object_event.c (virObjectEventDispatchMatchCallback): Switch return type to bool. (virObjectEventCallbackListM

Re: [libvirt] [PATCH] lxcDomainShutdownFlags: Cleanup @flags usage

2014-01-06 Thread Michal Privoznik
On 27.12.2013 21:35, Eric Blake wrote: > On 12/19/2013 09:15 AM, Daniel P. Berrange wrote: >> On Wed, Dec 18, 2013 at 07:19:31PM +0100, Michal Privoznik wrote: >>> Currently, the @flags usage is a bit unclear at first sight to say the >>> least. There's no need for such unclear code especially when

[libvirt] [PATCH 1/2] storage: Fix autostart of pool with "fc_host" type adapter

2014-01-06 Thread Osier Yang
The "checkPool" is a bit different for pool with "fc_host" type source adapter, since the vHBA it's based on might be not created yet (it's created by "startPool", which is involked after "checkPool" in storageDriverAutostart). So it should not fail, otherwise the "autostart" of the pool will fail

[libvirt] [PATCH 0/2] Storage: Fixes for the "fc_host" type pool

2014-01-06 Thread Osier Yang
*** Enough details in the patch commits *** Osier Yang (2): storage: Fix autostart of pool with "fc_host" type adapter storage: Polling the sysfs for pool with "fc_host" type adapter src/storage/storage_backend_scsi.c | 30 -- 1 file changed, 28 insertions(+), 2 d

[libvirt] [PATCH 2/2] storage: Polling the sysfs for pool with "fc_host" type adapter

2014-01-06 Thread Osier Yang
The SCSI device corresponding to the vHBA might not show up in sysfs yet when we trying to scan the LUNs. As a result, we will end up with an empty volume set for the pool after pool-start, even if there are LUNs. Though the time of the device showing up is rather depended, better than doing nothi

Re: [libvirt] device removal

2014-01-06 Thread Michal Privoznik
On 03.01.2014 05:38, Serge Hallyn wrote: > Hi, > > one of our tests was complaining that after an attach-device > followed by detach-device, the device was still in the vm's > apparmor whitelist. It turns out the device actually also > still in the device's xml. qemuDomainDetachVirtioDiskDevice(

Re: [libvirt] Add GVirConfigDomainDiskDriver

2014-01-06 Thread Christophe Fergeau
Hey, On Mon, Jan 06, 2014 at 10:40:49AM +0100, Michal Privoznik wrote: > It's been a while since the last time I've written something for > libivrt-glib. So just my two cents: I'd say go with new class esp. if > there's a chance for attributes to expand. Although, we still have to > maintain the o

Re: [libvirt] [PATCH] spice: expose the disable file transfer option

2014-01-06 Thread Francesco Romani
Hello, - Original Message - > From: "Eric Blake" > To: "Francesco Romani" , libvir-list@redhat.com > Sent: Saturday, January 4, 2014 3:33:09 PM > Subject: Re: [libvirt] [PATCH] spice: expose the disable file transfer option > > On 01/02/2014 02:59 AM, Francesco Romani wrote: > > spice-s

Re: [libvirt] Add GVirConfigDomainDiskDriver

2014-01-06 Thread Michal Privoznik
On 06.12.2013 12:13, Christophe Fergeau wrote: > Hey, > > I wanted to add support in libvirt-gconfig for the 'discard' attribute of > the disk driver node. If I follow the way the API is currently done, it > would be an additional method to GVirConfigDomainDisk. However, there are > quite a few a

Re: [libvirt] error in compiling event-test.c

2014-01-06 Thread Michal Privoznik
On 06.01.2014 06:03, rash g wrote: > Hello, > I am trying to run event-test.c provided in libvirt package.I > am using ubuntu 13.04. > However,after compiling I am getting an error saying ->undefined > reference to... > I think this is because compiler is not able to find the functions an

Re: [libvirt] [PATCHv2] Fix explicit usage of default video PCI slots

2014-01-06 Thread Ján Tomko
On 01/04/2014 03:27 PM, Eric Blake wrote: > On 01/03/2014 04:06 AM, Ján Tomko wrote: >> Do not leave the PCI address of the primary video card set >> to the legacy default (:00:02.0) if we're doing two-pass >> allocation. >> >> Since QEMU 1.6 (QEMU_CAPS_VIDEO_PRIMARY) we allow the primary >> vi