This is useful in certain circumstances, for example when
libvirtd is being executed by FreeBSD rc script, it cannot find
dmidecode installed from FreeBSD ports because it doesn't have
/usr/local (default prefix for ports) in PATH.
---
configure.ac | 4
src/util/virsysinfo.c | 2 +-
On Wed, Jan 15, 2014 at 03:37:04PM +0100, Igor Mammedov wrote:
> On Wed, 15 Jan 2014 20:24:01 +0800
> Chen Fan wrote:
> > On Tue, 2014-01-14 at 11:40 +0100, Igor Mammedov wrote:
> > > On Tue, 14 Jan 2014 17:27:20 +0800
> > > Chen Fan wrote:
> > >
> > > > the intend of this patch is to register c
ACK
On Fri, Jan 17, 2014 at 04:56:27PM +, Daniel P. Berrange wrote:
> Remove hand crafted configure.ac and Makefile.am rules in
> favour of the standard macros.
>
> Signed-off-by: Daniel P. Berrange
> ---
> configure.ac| 25 +---
> libvirt-gconfig/Makefile.am | 7
---
Pushed under the trivial rule.
docs/formatdomain.html.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 68860ef..80d9495 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -1348,7 +1348,7
Remove hand crafted configure.ac and Makefile.am rules in
favour of the standard macros.
Signed-off-by: Daniel P. Berrange
---
configure.ac| 25 +---
libvirt-gconfig/Makefile.am | 71 -
libvirt-glib/Makefile.am| 51 +
On 01/17/2014 05:34 AM, Laine Stump wrote:
> I noticed this problem when adding systemd support to netcf, because I
> setup the configure.ac to automatically prefer using systemd over
> initscripts when possible - although I had copied the
> install-data-local target from the example of libvirt's
>
This patch series extend the QEMU capabilities XML to report
if the underlying QEMU binary supports, or not, the live
disk snapshotting.
Without this patch series, the only way to know if QEMU
has this support is to actually request a disk snapshot and
to see what happens.
The change is split in
extract and export the code to add the capabilities
for a given QEMU binary in the capabilities cache.
The intended use case is for testing, and make writing
more test easier.
---
src/qemu/qemu_capabilities.c | 31 +--
src/qemu/qemu_capabilities.h | 2 ++
2 files chan
On Fri, Jan 17, 2014 at 15:29:27 +0100, Michal Privoznik wrote:
> On 17.01.2014 11:39, Jiri Denemark wrote:
> > https://bugzilla.redhat.com/show_bug.cgi?id=1046919
> >
> > When a PCI device is not bound to any driver, reattach should just
> > trigger driver probe rather than failing with
> >
> >
On 17.01.2014 16:48, Daniel P. Berrange wrote:
> On Fri, Jan 17, 2014 at 04:42:02PM +0100, Michal Privoznik wrote:
>> Signed-off-by: Michal Privoznik
>> ---
>> templates/lsn2html.xsl | 3 ++-
>> templates/lsn2indexhtml.xsl | 3 ++-
>> 2 files changed, 4 insertions(+), 2 deletions(-)
>>
>> di
On Fri, Jan 17, 2014 at 04:42:02PM +0100, Michal Privoznik wrote:
> Signed-off-by: Michal Privoznik
> ---
> templates/lsn2html.xsl | 3 ++-
> templates/lsn2indexhtml.xsl | 3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/templates/lsn2html.xsl b/templates/lsn2html.
On 17.01.2014 16:34, Jiri Denemark wrote:
> On Fri, Jan 17, 2014 at 15:29:27 +0100, Michal Privoznik wrote:
>> On 17.01.2014 11:39, Jiri Denemark wrote:
>>> https://bugzilla.redhat.com/show_bug.cgi?id=1046919
>>>
>>> When a PCI device is not bound to any driver, reattach should just
>>> trigger dri
Signed-off-by: Michal Privoznik
---
templates/lsn2html.xsl | 3 ++-
templates/lsn2indexhtml.xsl | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/templates/lsn2html.xsl b/templates/lsn2html.xsl
index aaac6e8..46501ab 100644
--- a/templates/lsn2html.xsl
+++ b/templates/l
This patch add an element to QEMU's capability XML, to
show if the underlying QEMU binary supports the live disk
snapshotting or not.
This allow any client to know ahead of time if the feature
is available.
Without this information available, the only way to check
for the snapshot support is to re
make the function public.
the function is useful to XML capabilities unit test.
---
src/qemu/qemu_capabilities.c | 2 +-
src/qemu/qemu_capabilities.h | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 125869b..37c
the test is loosely inspired from qemucapabilitiestest
and qemuxml2xmltest.
Added a new test instead of extending an existing one because
the feature being tested don't really fits nicely in any
existing place.
---
.gitignore | 1 +
tests/Makefile.am
On Fri, Jan 17, 2014 at 02:43:25PM +, Daniel P. Berrange wrote:
> Hi Folks,
>
> After much work I've finally got a formal Libvirt Security Notice (LSN)
> setup worked out.
>
> Every security issue that is reported & confirmed on the libvirt security
> mailing list will have a formal LSN prepa
GVirConfigDomainTimerPit is correctly define as inheriting from
GVirConfigDomainTimer in the G_DEFINE_TYPE macro, but it only
embeds GVirConfigObject/GVirConfigObjectClass structs.
This is an ABI break as this changes the size of the
GVirConfigDomainTimerPit/GVirConfigDomainTimerPitClass structs
H
On Fri, Jan 17, 2014 at 02:33:55PM +, Zeeshan Ali (Khattak) wrote:
> On Fri, Jan 17, 2014 at 2:11 PM, Christophe Fergeau
> wrote:
> > +struct _GVirConfigDomainTimerHpet
> > +{
> > +GVirConfigObject parent;
>
> Shouldn't this be GVirConfigDomainTimer?
Yes, great catch! Fixed.
This file i
Hi Folks,
After much work I've finally got a formal Libvirt Security Notice (LSN)
setup worked out.
Every security issue that is reported & confirmed on the libvirt security
mailing list will have a formal LSN prepared. This is a simple XML document
containing metadata & other information about t
On 17.01.2014 11:39, Jiri Denemark wrote:
> For example:
>
> ...
> 5) testVirPCIDeviceIsAssignable(0005:90:01.0) ... OK
> 6) testVirPCIDeviceIsAssignable(0001:01:00.0) ... OK
>
> Signed-off-by: Jiri Denemark
> ---
> tests/virpcitest.c | 9 -
> 1 file changed, 8 insertions(+
On Fri, Jan 17, 2014 at 2:11 PM, Christophe Fergeau wrote:
> Now that there is a gvir_config_object_get_attribute_boolean(), these
> are trivial to implement.
> ---
ACK
--
Regards,
Zeeshan Ali (Khattak)
FSF member#5124
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/
On 17.01.2014 11:39, Jiri Denemark wrote:
> Signed-off-by: Jiri Denemark
> ---
> src/libvirt_private.syms | 2 ++
> src/util/virpci.c| 71
>
> src/util/virpci.h| 5
> 3 files changed, 49 insertions(+), 29 deletions(-)
>
AC
On 17.01.2014 11:39, Jiri Denemark wrote:
> Such driver can be used to make sure PCI APIs fail properly.
>
> Signed-off-by: Jiri Denemark
> ---
> tests/virpcimock.c | 33 +
> 1 file changed, 21 insertions(+), 12 deletions(-)
>
> diff --git a/tests/virpcimock.c b/
On Fri, Jan 17, 2014 at 2:11 PM, Christophe Fergeau wrote:
> gvir_config_object_set_attribute() converts (TRUE, FALSE) to ("yes", "no"),
> but we don't have the corresponding getter. This commit adds this.
> ---
ACK
--
Regards,
Zeeshan Ali (Khattak)
FSF member#5124
--
libvir-list mailing list
On 17.01.2014 11:39, Jiri Denemark wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1046919
>
> When a PCI device is not bound to any driver, reattach should just
> trigger driver probe rather than failing with
>
> Invalid device :00:19.0 driver file
> /sys/bus/pci/devices/:00
On 17.01.2014 11:39, Jiri Denemark wrote:
> Signed-off-by: Jiri Denemark
> ---
> tests/virpcitest.c | 33 +
> 1 file changed, 33 insertions(+)
>
> diff --git a/tests/virpcitest.c b/tests/virpcitest.c
> index 848014d..6a2291d 100644
> --- a/tests/virpcitest.c
> +++
On 17.01.2014 11:39, Jiri Denemark wrote:
> This file is used by PCI detach and reattach APIs to probe for a driver
> that handles a specific device.
>
> Signed-off-by: Jiri Denemark
> ---
> tests/virpcimock.c | 40 +---
> 1 file changed, 29 insertions(+), 11
On Fri, Jan 17, 2014 at 02:27:02PM +, Zeeshan Ali (Khattak) wrote:
> On Fri, Jan 17, 2014 at 2:15 PM, Christophe Fergeau
> wrote:
> > On Thu, Jan 16, 2014 at 07:48:31PM +, Zeeshan Ali (Khattak) wrote:
> >> On Fri, Dec 6, 2013 at 11:13 AM, Christophe Fergeau
> >> wrote:
> >> > G_BEGIN_D
On Fri, Jan 17, 2014 at 2:11 PM, Christophe Fergeau wrote:
> This will be needed in order to solve
> https://bugzilla.gnome.org/show_bug.cgi?id=722293
> ---
> libvirt-gconfig/Makefile.am| 2 +
> .../libvirt-gconfig-domain-timer-hpet.c| 75
> ++
On 17.01.2014 11:39, Jiri Denemark wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1046919
>
> Since commit v0.9.0-47-g4e8969e (released in 0.9.1) some failures during
> device detach were reported to callers of virPCIDeviceBindToStub as
> success. For example, even though a device seemed to
On 17.01.2014 11:39, Jiri Denemark wrote:
> Especially for devices that are not bound to any driver.
>
> Signed-off-by: Jiri Denemark
> ---
> tests/virpcimock.c | 3 +
> tests/virpcitest.c | 157
> -
> 2 files changed, 159 insertions(+), 1 d
On 17.01.2014 11:39, Jiri Denemark wrote:
> From: Jincheng Miao
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1046919
>
> If none (KVM, VFIO) of the supported PCI passthrough methods is known to
> work on a host, it's better to fail right away with a nice error message
> rather than letting at
On Fri, Jan 17, 2014 at 2:15 PM, Christophe Fergeau wrote:
> On Thu, Jan 16, 2014 at 07:48:31PM +, Zeeshan Ali (Khattak) wrote:
>> On Fri, Dec 6, 2013 at 11:13 AM, Christophe Fergeau
>> wrote:
>> > G_BEGIN_DECLS
>> >
>> > +/* These enum definitions are needed by
>> > libvirt-gconfig-domain
On Fri, Jan 17, 2014 at 2:11 PM, Christophe Fergeau wrote:
> ---
ACK
--
Regards,
Zeeshan Ali (Khattak)
FSF member#5124
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Thu, Jan 16, 2014 at 07:48:31PM +, Zeeshan Ali (Khattak) wrote:
> On Fri, Dec 6, 2013 at 11:13 AM, Christophe Fergeau
> wrote:
> > G_BEGIN_DECLS
> >
> > +/* These enum definitions are needed by
> > libvirt-gconfig-domain-disk-driver.h */
>
> Why not just move these enums to that header
Now that there is a gvir_config_object_get_attribute_boolean(), these
are trivial to implement.
---
.../libvirt-gconfig-domain-graphics-desktop.c | 24 +-
.../libvirt-gconfig-domain-graphics-desktop.h | 4 +++-
.../libvirt-gconfig-domain-graphics-rdp.c | 24
This will be needed in order to solve
https://bugzilla.gnome.org/show_bug.cgi?id=722293
---
libvirt-gconfig/Makefile.am| 2 +
.../libvirt-gconfig-domain-timer-hpet.c| 75 ++
.../libvirt-gconfig-domain-timer-hpet.h| 67 +++
This series allows to generate using
libvirt-gconfig.
This is a prerequisite for fixing this Boxes bug
https://bugzilla.gnome.org/show_bug.cgi?id=722293
Patch 2/4 doesn't anything to do in this series, but this was easy to implement
after 1/4 so I slipped it there.
Christophe
--
libvir-list m
gvir_config_object_set_attribute() converts (TRUE, FALSE) to ("yes", "no"),
but we don't have the corresponding getter. This commit adds this.
---
libvirt-gconfig/libvirt-gconfig-object-private.h | 4
libvirt-gconfig/libvirt-gconfig-object.c | 20
2 files changed
---
libvirt-gconfig/libvirt-gconfig-domain-timer.c | 26 +-
libvirt-gconfig/libvirt-gconfig-domain-timer.h | 4 +++-
libvirt-gconfig/libvirt-gconfig.sym| 3 +++
libvirt-gconfig/tests/test-domain-create.c | 2 ++
4 files changed, 33 insertions(+), 2 deleti
On Thu, Jan 16, 2014 at 07:44:56PM +, Zeeshan Ali (Khattak) wrote:
> > +
> > +void gvir_config_domain_disk_driver_set_name(GVirConfigDomainDiskDriver
> > *driver,
> > + const char *name)
>
> Since libvirt support only specific drivers and they are i
On 01/17/2014 02:06 AM, Osier Yang wrote:
<...snip...>
>
> As a conclusion, I think the only concern from you is about the problem
> on the running domain of an old libvirt (without these 2 patches). Right?
> If so, my thought is to add document somewhere, though I have not
> much idea about wh
On Fri, Jan 17, 2014 at 13:43:40 +0100, Michal Privoznik wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=996543
>
> When starting up a domain, the SELinux labeling is done depending on
> current configuration. If the labeling fails we check for possible
> causes, as not all labeling failures
https://bugzilla.redhat.com/show_bug.cgi?id=996543
When starting up a domain, the SELinux labeling is done depending on
current configuration. If the labeling fails we check for possible
causes, as not all labeling failures are fatal. For example, if the
labeled file is on NFS which lacks SELinux
I noticed this problem when adding systemd support to netcf, because I
setup the configure.ac to automatically prefer using systemd over
initscripts when possible - although I had copied the
install-data-local target from the example of libvirt's
"libvirt-guests" service more or less verbatim, "mak
On Wed, Jan 15, 2014 at 10:42:41PM +0400, Roman Bogorodskiy wrote:
> Implementation obtains CPU usage information using
> kern.cp_time and kern.cp_times sysctl(8)s and reports
> CPU utilization.
> ---
> include/libvirt/libvirt.h.in | 8
> src/nodeinfo.c | 104
> ++
On Thu, Jan 02, 2014 at 12:27:52PM +0400, Roman Bogorodskiy wrote:
> At this point it has a limited functionality and is highly
> experimental. Supported domain operations are:
> * define
> * start
> * destroy
>
> It's only possible to have only one disk device and only one
> network, which
For example:
...
5) testVirPCIDeviceIsAssignable(0005:90:01.0) ... OK
6) testVirPCIDeviceIsAssignable(0001:01:00.0) ... OK
Signed-off-by: Jiri Denemark
---
tests/virpcitest.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/tests/virpcitest.c b/tests/virp
Signed-off-by: Jiri Denemark
---
tests/virpcitest.c | 33 +
1 file changed, 33 insertions(+)
diff --git a/tests/virpcitest.c b/tests/virpcitest.c
index 848014d..6a2291d 100644
--- a/tests/virpcitest.c
+++ b/tests/virpcitest.c
@@ -258,6 +258,37 @@ cleanup:
}
st
Such driver can be used to make sure PCI APIs fail properly.
Signed-off-by: Jiri Denemark
---
tests/virpcimock.c | 33 +
1 file changed, 21 insertions(+), 12 deletions(-)
diff --git a/tests/virpcimock.c b/tests/virpcimock.c
index f8ea9c7..b514619 100644
--- a/tes
Signed-off-by: Jiri Denemark
---
src/libvirt_private.syms | 2 ++
src/util/virpci.c| 71
src/util/virpci.h| 5
3 files changed, 49 insertions(+), 29 deletions(-)
diff --git a/src/libvirt_private.syms b/src/libvirt_private.sy
https://bugzilla.redhat.com/show_bug.cgi?id=1046919
Since commit v0.9.0-47-g4e8969e (released in 0.9.1) some failures during
device detach were reported to callers of virPCIDeviceBindToStub as
success. For example, even though a device seemed to be detached
virsh # nodedev-detach pci__07_
This file is used by PCI detach and reattach APIs to probe for a driver
that handles a specific device.
Signed-off-by: Jiri Denemark
---
tests/virpcimock.c | 40 +---
1 file changed, 29 insertions(+), 11 deletions(-)
diff --git a/tests/virpcimock.c b/tests/vi
https://bugzilla.redhat.com/show_bug.cgi?id=1046919
The first two patches fix bugs in PCI device handling code, the third
patch provides a nice error message when nodedev detach is not supported
and the rest are tests for testing the bugs fixed in the first two
patches.
Jincheng Miao (1):
qemu:
https://bugzilla.redhat.com/show_bug.cgi?id=1046919
When a PCI device is not bound to any driver, reattach should just
trigger driver probe rather than failing with
Invalid device :00:19.0 driver file
/sys/bus/pci/devices/:00:19.0/driver is not a symlink
While virPCIDeviceGetDriv
From: Jincheng Miao
https://bugzilla.redhat.com/show_bug.cgi?id=1046919
If none (KVM, VFIO) of the supported PCI passthrough methods is known to
work on a host, it's better to fail right away with a nice error message
rather than letting attachment fail with a more cryptic message such as
F
Especially for devices that are not bound to any driver.
Signed-off-by: Jiri Denemark
---
tests/virpcimock.c | 3 +
tests/virpcitest.c | 157 -
2 files changed, 159 insertions(+), 1 deletion(-)
diff --git a/tests/virpcimock.c b/tests/virpcim
I have already posted a bug request about this.
https://bugzilla.redhat.com/show_bug.cgi?id=1054657
The issue appears when trying to build with --enable-introspections flag.
I think it would be super if somebody had a solution for this, because
virt-manager is an nice tool to have.
--
libvir-list
59 matches
Mail list logo
