Chunyan Liu wrote:
> Change lxc driver to use hostdev common library instead of APIs in
> lxc_hostdev.[ch]
>
> Signed-off-by: Chunyan Liu
> ---
> po/POTFILES.in|1 -
> src/Makefile.am |1 -
> src/lxc/lxc_conf.h|4 -
> src/lxc/lxc_driver.c | 47 ---
> src/lxc/l
On 02/05/2014 05:12 PM, Eric Blake wrote:
> On 02/05/2014 07:58 AM, John Ferlan wrote:
>>
>>
>> On 02/05/2014 08:19 AM, Jiri Denemark wrote:
>>> If virDomainMemoryStats was run on a domain with virtio balloon driver
>>> running on an old qemu which supports QMP but does not support qom-list
>>> Q
On 02/05/2014 07:32 AM, Michal Privoznik wrote:
> When trying to introduce a test for previous patch, I've
> noticed that the command line is constructed using current
> time. This won't work in our test suite (unless you guys
> wants to set a specific time prior to each test run :) ).
> Therefore
On 02/05/2014 07:32 AM, Michal Privoznik wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1046192
>
> Commit b8bf79a, which adds clock='variable', forgets to check
> localtime basis in qemuBuildClockArgStr(). So that localtime
> basis could not be used.
>
> Reported-by: Jincheng Miao
> Signe
On 02/05/2014 07:58 AM, John Ferlan wrote:
>
>
> On 02/05/2014 08:19 AM, Jiri Denemark wrote:
>> If virDomainMemoryStats was run on a domain with virtio balloon driver
>> running on an old qemu which supports QMP but does not support qom-list
>> QMP command, libvirtd would crash. The reason is we
Daniel P. Berrange wrote:
> > +virCommandAddArg(cmd, "-H"); /* vmexit from guest on hlt */
> > +virCommandAddArg(cmd, "-P"); /* vmexit from guest on pause */
>
> What's the functional effect of having these set, or not ?
Having that set should make bhyve process terminate on these even
On 02/05/2014 07:54 PM, Eric Blake wrote:
> On 02/05/2014 11:47 AM, Ján Tomko wrote:
>> Commit 2ce63c1 added imagelabel generation when relabeling is turned
>> off. But we weren't filling out the sensitivity for type 'none' labels,
>> resulting in an invalid label:
>>
>> $ virsh managedsave domain
On 02/05/2014 11:47 AM, Ján Tomko wrote:
> Commit 2ce63c1 added imagelabel generation when relabeling is turned
> off. But we weren't filling out the sensitivity for type 'none' labels,
> resulting in an invalid label:
>
> $ virsh managedsave domain
> error: unable to set security context 'system_
Commit 2ce63c1 added imagelabel generation when relabeling is turned
off. But we weren't filling out the sensitivity for type 'none' labels,
resulting in an invalid label:
$ virsh managedsave domain
error: unable to set security context 'system_u:object_r:svirt_image_t'
on fd 28: Invalid argument
On 02/05/2014 10:44 AM, Peter Krempa wrote:
> When attempting a blockcommit from the top layer, the base argument
> passed is NULL. This will be dereferenced when attempting a commit with
> an empty image chain. Output the real volume path instead:
>
> virsh blockcommit --verbose --path vda --doma
On 02/05/2014 10:44 AM, Peter Krempa wrote:
> Eric Blake suggested to change this message to be different from the
> glibc's NULL deref protection message in printf to be able to
> differentiate errors.
> ---
> src/internal.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
ACK (although I
While reviving old patches to add job support to the libxl driver,
testing revealed some problems that were difficult to encounter
in the current, more serialized processing approach used in the
driver.
The first patch is a bug fix, plugging leaks of libxlDomainObjPrivate
objects. The second patc
On Wed, Feb 05, 2014 at 09:49:53AM +, Daniel P. Berrange wrote:
> On Tue, Feb 04, 2014 at 03:04:11PM -0700, Eric Blake wrote:
> > On 02/04/2014 02:57 PM, Marcelo Tosatti wrote:
> > >
> > >> So perhaps we do need some "policy" attribute on the
> > >> element to indicate desired behaviour here.
If available, let libxl handle reaping any children it creates by
specifying libxl_sigchld_owner_libxl_always_selective_reap. This
feature was added to improve subprocess handling in libxl when used
in an application that does not install a SIGCHLD handler like
libvirt
http://lists.xen.org/archiv
Eric Blake suggested to change this message to be different from the
glibc's NULL deref protection message in printf to be able to
differentiate errors.
---
src/internal.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/internal.h b/src/internal.h
index 4ba0e41..cef3da0 100
When libxl registers an FD with the libxl driver, the refcnt of the
associated libxlDomainObjPrivate object is incremented. The refcnt
is decremented when libxl deregisters the FD. But some FDs are only
deregistered when their libxl ctx is freed, which unfortunately is
done in the libxlDomainObjPr
Handling the domain shutdown event within the event handler seems
a bit unfair to libxl's event machinery. Domain "shutdown" could
take considerable time. E.g. if the shutdown reason is reboot,
the domain must be reaped and then started again.
Spawn a shutdown handler thread to do this work, all
Due to some misunderstanding of requirements libxl places on timer
handling, I introduced the half-brained idea of maintaining a list
of timeouts that the driver could force to expire before freeing a
libxlDomainObjPrivate (and hence libxl_ctx). But testing all
the latest versions of Xen supported
Peter Krempa (2):
maint: Change the text of the NULLSTR() macro to ""
qemu: blockjob: Print correct file name in error message
src/internal.h | 2 +-
src/qemu/qemu_driver.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
1.8.5.3
--
libvir-list mailing list
libvir-list@r
When attempting a blockcommit from the top layer, the base argument
passed is NULL. This will be dereferenced when attempting a commit with
an empty image chain. Output the real volume path instead:
virsh blockcommit --verbose --path vda --domain DOMNAME --wait
error: invalid argument: top '/path/
Noticed a misuse of 'to' while testing my event regression under
polkit ACLs, and decided to review the entire conf files for
other legibility bugs.
* daemon/libvirtd.conf: Use correct grammar.
* src/qemu/qemu.conf: Likewise.
Signed-off-by: Eric Blake
---
Pushing under the trivial rule.
daemo
On 04.02.2014 10:37, Teto wrote:
Hi,
The following patch was generated with format patch & checked with
syntax-check. It is really short and adds a new function
virDomainFSInsert which is called when Qemu driver is requested t
attach a filesystem device.
Matt
0001-This-commit-allows-to-regist
On 2014-02-05 14:19, Jiri Denemark wrote:
If virDomainMemoryStats was run on a domain with virtio balloon driver
running on an old qemu which supports QMP but does not support
qom-list
QMP command, libvirtd would crash. The reason is we did not check if
qemuMonitorJSONGetObjectListPaths failed
On Wed, Feb 05, 2014 at 03:38:49PM +0100, Christophe Fergeau wrote:
> On Mon, Feb 03, 2014 at 05:41:00PM +0100, Martin Kletzander wrote:
> > signed-off-by: martin kletzander
> > ---
> >
> > notes:
> > this applies on top of "qemu: minor cleanups":
> >
> > https://www.redhat.com/archives/li
On 02/05/2014 06:56 AM, Daniel P. Berrange wrote:
> On Tue, Jan 28, 2014 at 03:48:19PM -0700, Eric Blake wrote:
>> Commit f9f56340 for CVE-2014-0028 almost had the right idea - we
>> need to check the ACL rules to filter which events to send. But
>> it overlooked one thing: the event dispatch queu
On 02/05/2014 08:19 AM, Jiri Denemark wrote:
> If virDomainMemoryStats was run on a domain with virtio balloon driver
> running on an old qemu which supports QMP but does not support qom-list
> QMP command, libvirtd would crash. The reason is we did not check if
> qemuMonitorJSONGetObjectListPath
On Mon, Feb 03, 2014 at 05:41:00PM +0100, Martin Kletzander wrote:
> signed-off-by: martin kletzander
> ---
>
> notes:
> this applies on top of "qemu: minor cleanups":
>
> https://www.redhat.com/archives/libvir-list/2014-january/msg01584.html
>
> docs/formatdomain.html.in
https://bugzilla.redhat.com/show_bug.cgi?id=1046192
Commit b8bf79a, which adds clock='variable', forgets to check
localtime basis in qemuBuildClockArgStr(). So that localtime
basis could not be used.
Reported-by: Jincheng Miao
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_command.c | 18 ++
When trying to introduce a test for previous patch, I've
noticed that the command line is constructed using current
time. This won't work in our test suite (unless you guys
wants to set a specific time prior to each test run :) ).
Therefore we need to mock calls to time(2) to return the
same value
On 24.12.2013 07:31, Jincheng Miao wrote:
commit b8bf79a, which add clock=variable, forgets to check localtime
basis in qemuBuildClockArgStr(). So that localtime basis could not
be used, like this bug:
https://bugzilla.redhat.com/show_bug.cgi?id=1046192
---
src/qemu/qemu_command.c | 14
With a nice test enhancement ...
Michal Privoznik (2):
qemuBuildClockArgStr: Allow localtime clock basis
qemuxml2argvtest: Test localtime clock basis
src/qemu/qemu_command.c| 18 +++
tests/Makefile.am | 7
...muxml2ar
---
docs/drvlxc.html.in | 34 +-
1 file changed, 33 insertions(+), 1 deletion(-)
diff --git a/docs/drvlxc.html.in b/docs/drvlxc.html.in
index 0f3efb0..fc4bc20 100644
--- a/docs/drvlxc.html.in
+++ b/docs/drvlxc.html.in
@@ -555,7 +555,7 @@ and LXC. For further detail
---
src/lxc/lxc_native.c | 47 +-
.../lxcconf2xml-macvlannetwork.config | 13 ++
.../lxcconf2xmldata/lxcconf2xml-macvlannetwork.xml | 26
tests/lxcconf2xmltest.c| 1 +
4 files changed, 77 i
---
src/lxc/lxc_native.c | 68 ++
tests/lxcconf2xmldata/lxcconf2xml-blkiotune.config | 4 ++
tests/lxcconf2xmldata/lxcconf2xml-blkiotune.xml| 4 ++
3 files changed, 65 insertions(+), 11 deletions(-)
diff --git a/src/lxc/lxc_native.c b/src/lx
---
src/lxc/lxc_native.c | 63 ++
tests/lxcconf2xmldata/lxcconf2xml-blkiotune.config | 7 +++
tests/lxcconf2xmldata/lxcconf2xml-blkiotune.xml| 35
tests/lxcconf2xmltest.c| 1 +
4 files changed, 106 ins
To ease LXC configuration conversion, allow blkiotune device XML
fragments to define the device using its major:minor numbers.
---
docs/formatdomain.html.in | 10 +-
src/conf/domain_conf.c | 45 -
src/conf/domain_conf.h
If no network configuration is provided, LXC only provides the loopback
interface. To match this, we need to use the privnet feature. LXC will
also define a 'none' network type in its 1.0.0 version that fits
libvirt LXC driver's default.
---
src/lxc/lxc_native.c | 55
direct interfaces are already brought up when creating them.
---
src/lxc/lxc_process.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_process.c
index ed729f6..6f7ff74 100644
--- a/src/lxc/lxc_process.c
+++ b/src/lxc/lxc_process.c
@@ -245,6 +245,7 @@ ch
---
src/lxc/lxc_native.c| 9 +
tests/lxcconf2xmldata/lxcconf2xml-simple.config | 1 +
tests/lxcconf2xmldata/lxcconf2xml-simple.xml| 2 +-
3 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/src/lxc/lxc_native.c b/src/lxc/lxc_native.c
index 15c03f2
Here is an updated version of the patch set fixing comments from Daniel.
It also adds 3 commits:
* One adding conversion for the newly supported blkio throttle tune
in lxc driver.
* One actually using the state of the veth network device in lxc
driver.
* One adding the ability to give
Tmpfs relative size and default 50% size values aren't supported as
we have no idea of the available memory at the conversion time.
---
src/lxc/lxc_container.c | 2 +-
src/lxc/lxc_container.h | 2 +
src/lxc/lxc_native.c
Some of the LXC configuration properties aren't migrated since they
would only cause problems in libvirt-lxc:
* lxc.network.ipv[46]: LXC driver doesn't setup IP address of guests,
see rhbz#1059624
* lxc.network.name, see rhbz#1059630
---
src/lxc/lxc_native.c | 114 +
---
src/lxc/lxc_native.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/lxc/lxc_native.c b/src/lxc/lxc_native.c
index 1997370..9a16523 100644
--- a/src/lxc/lxc_native.c
+++ b/src/lxc/lxc_native.c
@@ -286,6 +286,10 @@ lxcAddFstabLine(virDomainDefPtr def, lxcFstabPtr fstab)
virConf now honours a VIR_CONF_FLAG_LXC_FORMAT flag to handle LXC
configuration files. The differences are that property names can
contain '.' character and values are all strings without any bounding
quotes.
Provide a new virConfWalk function calling a handler on all non-comment
values. This func
The problem with VLAN is that the user still has to manually create the
vlan interface on the host. Then the generated configuration will use
it as a nerwork hostdev device. So the generated configurations of the
following two fragments are equivalent (see rhbz#1059637).
lxc.network.type = phys
lx
---
src/lxc/lxc_native.c | 34
tests/lxcconf2xmldata/lxcconf2xml-cputune.config | 7 +
tests/lxcconf2xmldata/lxcconf2xml-cputune.xml| 29
tests/lxcconf2xmltest.c | 1 +
4 files changed, 71
---
src/lxc/lxc_native.c | 44
tests/lxcconf2xmldata/lxcconf2xml-simple.xml | 6
2 files changed, 50 insertions(+)
diff --git a/src/lxc/lxc_native.c b/src/lxc/lxc_native.c
index 7997fda..96523c4 100644
--- a/src/lxc/lxc_native.c
+++ b/src
---
src/lxc/lxc_native.c | 40
tests/lxcconf2xmldata/lxcconf2xml-memtune.config | 10 ++
tests/lxcconf2xmldata/lxcconf2xml-memtune.xml| 29 +
tests/lxcconf2xmltest.c | 1 +
4 files changed, 80 in
This function aims at converting LXC configuration into a libvirt
domain XML description to help users migrate from LXC to libvirt.
Here is an example of how the lxc configuration works:
virsh -c lxc:/// domxml-from-native lxc-tools /var/lib/lxc/migrate_test/config
It is possible that some parts
---
src/lxc/lxc_native.c | 44 +++---
.../lxcconf2xmldata/lxcconf2xml-physnetwork.config | 6 +++
tests/lxcconf2xmldata/lxcconf2xml-physnetwork.xml | 26 +
tests/lxcconf2xmltest.c| 1 +
4 files changed, 72 ins
---
src/lxc/lxc_native.c | 30 ++
.../lxcconf2xmldata/lxcconf2xml-cpusettune.config | 6 +
tests/lxcconf2xmldata/lxcconf2xml-cpusettune.xml | 27 +++
tests/lxcconf2xmltest.c| 1 +
4 files changed
---
src/lxc/lxc_native.c | 44 ++
tests/lxcconf2xmldata/lxcconf2xml-idmap.config | 5 +++
tests/lxcconf2xmldata/lxcconf2xml-idmap.xml| 28
tests/lxcconf2xmltest.c| 1 +
4 files changed, 78 insertions(+
LXC rootfs can be either a directory or a block device or an image
file. The first two types have been implemented, but the image file is
still to be done since LXC auto-guesses the file format at mount time
and the LXC driver doesn't support the 'auto' format.
---
src/lxc/lxc_native.c
On Tue, Jan 28, 2014 at 05:14:40PM -0700, Eric Blake wrote:
> Commit f9f56340 for CVE-2014-0028 almost had the right idea - we
> need to check the ACL rules to filter which events to send. But
> it overlooked one thing: the event dispatch queue is running in
> the main loop thread, and therefore d
On Tue, Jan 28, 2014 at 03:48:19PM -0700, Eric Blake wrote:
> Commit f9f56340 for CVE-2014-0028 almost had the right idea - we
> need to check the ACL rules to filter which events to send. But
> it overlooked one thing: the event dispatch queue is running in
> the main loop thread, and therefore d
On 02/05/2014 02:51 AM, Daniel P. Berrange wrote:
> On Tue, Feb 04, 2014 at 03:15:56PM -0700, Eric Blake wrote:
>> On Fedora 20, with wireshark-devel installed, 'make rpm' failed
>> due to installed but unpackaged files related to wireshark. As
>> F20 is already released without wireshark, I chose
On 01/28/2014 03:48 PM, Eric Blake wrote:
> Commit f9f56340 for CVE-2014-0028 almost had the right idea - we
> need to check the ACL rules to filter which events to send. But
> it overlooked one thing: the event dispatch queue is running in
> the main loop thread, and therefore does not normally h
On Tue, Feb 04, 2014 at 02:25:03PM +0100, Martin Kletzander wrote:
> On Tue, Feb 04, 2014 at 01:34:38PM +0100, Christophe Fergeau wrote:
> > Regarding the way it's exposed, you have chosen to go with
> >
> >
> >
> >
> >
> >
> >
> > This exposes the 'org.qemu.console.se
On 01/30/2014 12:29 PM, Michal Privoznik wrote:
> On 30.01.2014 11:26, Laine Stump wrote:
>> On 01/27/2014 06:08 PM, Michal Privoznik wrote:
>>> On 24.01.2014 13:18, Laine Stump wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1057321 pointed out that
we weren't honoring the element in
On Tue, 2014-02-04 at 16:04 +0100, Peter Krempa wrote:
> [adding Vadim as he implemented the qemu/kvm parts]
>
> On 01/22/14 11:35, Daniel P. Berrange wrote:
> > On Tue, Jan 21, 2014 at 06:54:34PM +0100, Peter Krempa wrote:
> >> The hyperv enlightenment features allow to ease guests timekeeping by
If virDomainMemoryStats was run on a domain with virtio balloon driver
running on an old qemu which supports QMP but does not support qom-list
QMP command, libvirtd would crash. The reason is we did not check if
qemuMonitorJSONGetObjectListPaths failed and moreover we even stored its
result in an u
On Tue, Feb 04, 2014 at 11:23:42PM +0100, Jiri Denemark wrote:
> On Tue, Feb 04, 2014 at 17:02:41 +0100, Franky Van Liedekerke wrote:
> > Hi,
> >
> > using libvirt 1.2.0 on a up-to-date Centos6.5 machine leads to
> > occasional segmentation faults (see below).
> > Sometimes it runs for 5 minutes,
If virDomainMemoryStats was run on a domain with virtio balloon driver
running on an old qemu which supports QMP but does not support qom-list
QMP command, libvirtd would crash. The reason is we did not check if
qemuMonitorJSONGetObjectListPaths failed and moreover we even stored its
result in an u
On Wed, Feb 05, 2014 at 07:02:38 -0500, John Ferlan wrote:
>
>
> On 02/04/2014 05:23 PM, Jiri Denemark wrote:
> > On Tue, Feb 04, 2014 at 17:02:41 +0100, Franky Van Liedekerke wrote:
> >> Hi,
> >>
> >> using libvirt 1.2.0 on a up-to-date Centos6.5 machine leads to
> >> occasional segmentation fa
On 02/04/2014 05:23 PM, Jiri Denemark wrote:
> On Tue, Feb 04, 2014 at 17:02:41 +0100, Franky Van Liedekerke wrote:
>> Hi,
>>
>> using libvirt 1.2.0 on a up-to-date Centos6.5 machine leads to
>> occasional segmentation faults (see below).
>> Sometimes it runs for 5 minutes, sometimes for an hour
Add a new for the HyperV reference time counter enlightenment
for Windows guests.
This feature provides a paravirtual approach to track timer events for
the quest (similar to kvmclock).
---
docs/formatdomain.html.in | 7 -
docs/schemas/domaincommon.rng
According to the documentation various timer options are only supported
by certain timer types. Add a post parse check to verify that the user
didn't specify invalid options.
Also fix the qemu command line parsing function to set correct default
values for the kvmclock timer so that it passes the
Version 2 now adds the as a timer mode instead of the hyperv feature as this is
a timer in fact.
Peter Krempa (3):
schema: Fix guest timer specification schema according to the docs
conf: Enforce supported options for certain timers
qemu: hyperv: Add support for reference time couter enlight
According to the documentation describing various tunables for domain
timers not all the fields are supported by all the driver types. Express
these in the RNG:
- rtc, platform: Only these support the "track" attribute.
- tsc: only one to support "frequency" and "mode" attributes
- hpet, pit: tick
On Tue, Feb 04, 2014 at 06:31:26AM -0700, Eric Blake wrote:
> On 02/04/2014 03:21 AM, Daniel P. Berrange wrote:
> > On Mon, Feb 03, 2014 at 02:32:27PM -0700, Eric Blake wrote:
> >> On 01/23/2014 07:25 AM, Daniel P. Berrange wrote:
> >>> Change d40861 removed the 'len' argument from the virStreamSen
Basically, the idea is copied from domain code, where tainting
exists for a while. Currently, only one taint reason exists -
VIR_NETWORK_TAINT_HOOK to mark those networks which caused invoking
of hook script.
Signed-off-by: Michal Privoznik
---
src/conf/network_conf.c | 16
The lack of debug printings might be frustrating in the future.
Moreover, this function doesn't follow the usual pattern we have in the
rest of the code:
int ret = -1;
/* do some work */
ret = 0;
cleanup:
/* some cleanup work */
return ret;
Signed-off-by: Michal Privoznik
---
src/netw
Yet another version, this time with more hooks (after the network is started,
on interface plug and unplug) and tainting.
Michal Privoznik (3):
networkStartNetwork: Be more verbose
network: Introduce start and shutdown hooks
network: Taint networks that are using hook script
docs/hooks.htm
There might be some use cases, where user wants to prepare the host or
its environment prior to starting a network and do some cleanup after
the network has been shut down. Consider all the functionality that
libvirt doesn't currently have as an example what a hook script can
possibly do.
Signed-o
On Tue, Feb 04, 2014 at 03:15:56PM -0700, Eric Blake wrote:
> On Fedora 20, with wireshark-devel installed, 'make rpm' failed
> due to installed but unpackaged files related to wireshark. As
> F20 is already released without wireshark, I chose to add a new
> sub-package that is enabled only for F2
On Tue, Feb 04, 2014 at 03:04:11PM -0700, Eric Blake wrote:
> On 02/04/2014 02:57 PM, Marcelo Tosatti wrote:
> >
> >> So perhaps we do need some "policy" attribute on the
> >> element to indicate desired behaviour here.
> >
> > What about the following new element under ?
> >
> > enforce_hugep
On Tue, Feb 04, 2014 at 11:34:39AM -0700, Eric Blake wrote:
> On 02/04/2014 11:28 AM, Franky Van Liedekerke wrote:
>
> >> Are you in a position to bisect which libvirt patch introduced the
> >> problem? It looks like our first use of qom-list was in 1.1.1, with
> >> commit d76a897.
> >
> > Errr
No news about my patch?
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On 02/04/2014 11:23 PM, Jiri Denemark wrote:
> On Tue, Feb 04, 2014 at 17:02:41 +0100, Franky Van Liedekerke wrote:
>> Hi,
>>
>> using libvirt 1.2.0 on a up-to-date Centos6.5 machine leads to
>> occasional segmentation faults (see below).
>> Sometimes it runs for 5 minutes, sometimes for an hour,
79 matches
Mail list logo
