Re: [libvirt] [Qemu-devel] [uq/master PATCH 7/7 v8] target-i386: CPU model subclasses

2014-02-10 Thread Eduardo Habkost
On Mon, Feb 10, 2014 at 01:23:37AM +0100, Andreas Färber wrote: [...] /** * X86CPUClass: * @parent_realize: The parent class' realize handler. @@ -49,6 +52,16 @@ typedef struct X86CPUClass { CPUClass parent_class; /* public */ +/* CPU model definition + *

Re: [libvirt] [Qemu-devel] [uq/master PATCH 7/7 v8] target-i386: CPU model subclasses

2014-02-10 Thread Eduardo Habkost
On Mon, Feb 10, 2014 at 06:19:58AM -0200, Eduardo Habkost wrote: On Mon, Feb 10, 2014 at 01:23:37AM +0100, Andreas Färber wrote: [...] /** * X86CPUClass: * @parent_realize: The parent class' realize handler. @@ -49,6 +52,16 @@ typedef struct X86CPUClass { CPUClass

Re: [libvirt] [PATCH] RFC: Add blockdev-delete QMP command

2014-02-10 Thread Markus Armbruster
Ian Main im...@redhat.com writes: This is the sister command to blockdev-add. In Fam's example he uses the drive_del HMP command to clean up but when trying to do this via libvirt it doesn't work. This command seems to be needed in order to perform proper cleanup. Signed-off-by: Ian Main

Re: [libvirt] [PATCH v5 1/6] conf: Add a keyboard input device type

2014-02-10 Thread Li Zhang
On 2014年02月03日 23:09, Ján Tomko wrote: On 12/19/2013 08:50 AM, Li Zhang wrote: From: Li Zhang zhlci...@linux.vnet.ibm.com There is no keyboard for non-x86 platforms when graphics are enabled. It's preferred to add one USB keyboard. This patch is to add keyboard input device type.

Re: [libvirt] [PATCH v5 5/6] qemu: parse qemu command line for USB keyboard

2014-02-10 Thread Li Zhang
On 2014年02月03日 23:09, Ján Tomko wrote: On 12/19/2013 08:50 AM, Li Zhang wrote: From: Li Zhang zhlci...@linux.vnet.ibm.com This patch is to format qemu command line and xen driver for USB keyboard and add test cases for it. Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com ---

Re: [libvirt] [PATCH v5 3/6] conf: Remove PS2 mouse device for non-X86 platforms

2014-02-10 Thread Li Zhang
On 2014年02月03日 23:09, Ján Tomko wrote: On 12/19/2013 08:50 AM, Li Zhang wrote: From: Li Zhang zhlci...@linux.vnet.ibm.com PS2 device only works for X86 platform, other platforms may need USB mouse. Athough it doesn't influence the QEMU command line, but It's not right to add one PS2 mouse for

Re: [libvirt] why mac are different between inside and outside of vm

2014-02-10 Thread Laine Stump
On 02/08/2014 05:46 AM, yue wrote: hi, all nwfilter has many rules which depends on mac of vm, but i find the mac address inside vm is different from mac outside of vm. outside mac: vnet0 Link encap:Ethernet HWaddr FE:54:00:71:15:7B , inside mac: eth0 Link encap:Ethernet HWaddr

Re: [libvirt] [Qemu-devel] [uq/master PATCH 7/7 v8] target-i386: CPU model subclasses

2014-02-10 Thread Igor Mammedov
On Mon, 10 Feb 2014 01:23:37 +0100 Andreas Färber afaer...@suse.de wrote: Am 31.01.2014 19:13, schrieb Eduardo Habkost: Register separate QOM classes for each x86 CPU model. This will allow management code to more easily probe what each CPU model provides, by simply creating objects

[libvirt] [qom-cpu PATCH 7/7 v9] target-i386: CPU model subclasses

2014-02-10 Thread Eduardo Habkost
Register separate QOM classes for each x86 CPU model. This will allow management code to more easily probe what each CPU model provides, by simply creating objects using the appropriate class name, without having to restart QEMU. This also allows us to eliminate the

Re: [libvirt] [PATCHv3 1/3] schema: Fix guest timer specification schema according to the docs

2014-02-10 Thread Peter Krempa
On 02/07/14 21:30, Eric Blake wrote: On 02/07/2014 07:21 AM, Peter Krempa wrote: According to the documentation describing various tunables for domain timers not all the fields are supported by all the driver types. Express these in the RNG: - rtc, platform: Only these support the track

Re: [libvirt] [PATCHv3 3/3] qemu: hyperv: Add support for timer enlightenments

2014-02-10 Thread Peter Krempa
On 02/07/14 21:43, Eric Blake wrote: On 02/07/2014 07:21 AM, Peter Krempa wrote: Add a new timer for the HyperV reference time counter enlightenment and the iTSC reference page for Windows guests. This feature provides a paravirtual approach to track timer events for the guest (similar to

Re: [libvirt] [PATCH 10/14] Avoid unsafe use of /proc/$PID/root in LXC disk hotplug

2014-02-10 Thread Daniel P. Berrange
On Fri, Feb 07, 2014 at 11:22:12AM -0700, Eric Blake wrote: On 02/07/2014 08:33 AM, Daniel P. Berrange wrote: My overall thoughts: If we had a way to do _just_ the mknod, then open the file, and pass the fd back to the parent, then do labeling on the fd from the parent context (rather than

Re: [libvirt] [PATCH v5] bhyve: add a basic driver

2014-02-10 Thread Daniel P. Berrange
On Fri, Feb 07, 2014 at 02:44:31PM -0500, David Shane Holden wrote: On 02/07/14 02:51, Roman Bogorodskiy wrote: At this point it has a limited functionality and is highly experimental. Supported domain operations are: * define * start * destroy * dumpxml * dominfo Tested this a bit and it

Re: [libvirt] why mac are different between inside and outside of vm

2014-02-10 Thread Daniel P. Berrange
On Sat, Feb 08, 2014 at 11:46:21AM +0800, yue wrote: hi, all nwfilter has many rules which depends on mac of vm, but i find the mac address inside vm is different from mac outside of vm. outside mac: vnet0 Link encap:Ethernet HWaddr FE:54:00:71:15:7B , inside mac: eth0 Link encap:Ethernet

Re: [libvirt] [PATCH 0/4] qemu: export disk snapshot capability

2014-02-10 Thread Francesco Romani
- Original Message - From: Francesco Romani from...@redhat.com To: libvir-list@redhat.com Cc: Francesco Romani from...@redhat.com Sent: Friday, January 17, 2014 4:31:47 PM Subject: [PATCH 0/4] qemu: export disk snapshot capability This patch series extend the QEMU capabilities XML

[libvirt] [PATCH] tests: Fix the build failure on s390

2014-02-10 Thread Osier Yang
The build works fine on other architectures with commit 0b4f76fc5, but for s390: TEST: virscsitest 1) test1 ... OK 2) test2 ... libvirt: error : SCSI device '1:0:0:0': could not access /builddir/build/BUILD/libvirt-1.1.1/tests/virscsidata/sg8: No such file or directory FAILED It's caused

Re: [libvirt] [PATCH] tests: Fix the build failure on s390

2014-02-10 Thread Jiri Denemark
On Mon, Feb 10, 2014 at 21:35:18 +0800, Osier Yang wrote: The build works fine on other architectures with commit 0b4f76fc5, but for s390: TEST: virscsitest 1) test1 ... OK 2) test2 ... libvirt: error : SCSI device '1:0:0:0': could not access

[libvirt] [PATCH v3 0/4] Introduce spiceport chardev backend

2014-02-10 Thread Martin Kletzander
BLURB/ Martin Kletzander (4): conf: introduce spiceport chardev backend qemu: rework '-serial none' qemu: remove pointless condition qemu: introduce spiceport chardev backend docs/formatdomain.html.in | 18 docs/schemas/domaincommon.rng

[libvirt] [PATCH v3 3/4] qemu: remove pointless condition

2014-02-10 Thread Martin Kletzander
This patch is here just to ease the code review and make related changes look more sensible. Signed-off-by: Martin Kletzander mklet...@redhat.com --- src/qemu/qemu_command.c | 44 +--- 1 file changed, 21 insertions(+), 23 deletions(-) diff --git

[libvirt] [PATCH v3 4/4] qemu: introduce spiceport chardev backend

2014-02-10 Thread Martin Kletzander
Add a new backend for any character device. This backend uses channel in spice connection. This channel is similar to spicevmc, but all-purpose in contrast to spicevmc. Apart from spicevmc, spiceport-backed chardev will not be formatted into the command-line if there is no spice to use (with

[libvirt] [PATCH v3 1/4] conf: introduce spiceport chardev backend

2014-02-10 Thread Martin Kletzander
Add a new character device backend called 'spiceport' that uses spice's channel for communications and apart from spicevmc can be used as a backend for any character device from libvirt's point of view. Signed-off-by: Martin Kletzander mklet...@redhat.com --- docs/formatdomain.html.in | 18

[libvirt] [PATCH v3 2/4] qemu: rework '-serial none'

2014-02-10 Thread Martin Kletzander
Limiting ourselves to qemu without QEMU_CAPS_DEVICE capability, we used '-serial none' only if there was no serial device defined in the domain XML. This means that if we want to have a possibility of the device being defined in XML, but not used in the command-line (e.g. when it's pointless),

[libvirt] [PATCH] build: correctly check for SOICGIFVLAN GET_VLAN_VID_CMD command

2014-02-10 Thread Laine Stump
In order to make a client-only build successful on RHEL4, commit 3ed2e54 modified src/util/virnetdev.c so that the functional version of virNetDevGetVLanID() was only compiled if GET_VLAN_VID_CMD was defined. However, it is *never* defined, but is only an enum value, so the proper version was no

[libvirt] [PATCH] daemon: Enhance documentation for changinging NOFILE limit

2014-02-10 Thread Jiri Denemark
Signed-off-by: Jiri Denemark jdene...@redhat.com --- daemon/libvirtd.sysconf | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/daemon/libvirtd.sysconf b/daemon/libvirtd.sysconf index 3af1f03..06f6a2c 100644 --- a/daemon/libvirtd.sysconf +++ b/daemon/libvirtd.sysconf @@ -20,5

Re: [libvirt] [PATCH] tests: Fix the build failure on s390

2014-02-10 Thread Osier Yang
On 10/02/14 21:48, Jiri Denemark wrote: On Mon, Feb 10, 2014 at 21:35:18 +0800, Osier Yang wrote: The build works fine on other architectures with commit 0b4f76fc5, but for s390: TEST: virscsitest 1) test1 ... OK 2) test2 ... libvirt: error : SCSI device '1:0:0:0': could not access

Re: [libvirt] [PATCH] tests: Fix the build failure on s390

2014-02-10 Thread Osier Yang
On 10/02/14 22:31, Osier Yang wrote: On 10/02/14 21:48, Jiri Denemark wrote: On Mon, Feb 10, 2014 at 21:35:18 +0800, Osier Yang wrote: The build works fine on other architectures with commit 0b4f76fc5, but for s390: TEST: virscsitest 1) test1 ... OK 2) test2 ... libvirt: error : SCSI

Re: [libvirt] [PATCH v2 2/3] network: Introduce start and shutdown hooks

2014-02-10 Thread Michal Privoznik
On 07.02.2014 14:27, Laine Stump wrote: On 02/05/2014 12:11 PM, Michal Privoznik wrote: There might be some use cases, where user wants to prepare the host or its environment prior to starting a network and do some cleanup after the network has been shut down. Consider all the functionality

Re: [libvirt] [PATCH v2 3/3] network: Taint networks that are using hook script

2014-02-10 Thread Michal Privoznik
On 08.02.2014 11:51, Laine Stump wrote: On 02/07/2014 10:52 PM, Antoni Segura Puimedon wrote: - Original Message - From: Laine Stump la...@laine.org To: libvir-list@redhat.com Cc: Michal Privoznik mpriv...@redhat.com Sent: Friday, February 7, 2014 1:17:10 PM Subject: Re: [libvirt]

Re: [libvirt] [PATCH] qemu: Use correct permissions when determining the image chain

2014-02-10 Thread Peter Krempa
On 02/07/14 21:47, Eric Blake wrote: On 02/07/2014 10:53 AM, Peter Krempa wrote: The code took into account only the global permissions. The domains now support per-vm DAC lables and per-image DAC labels. Use the most s/lables/labels/ specific label available. ---

Re: [libvirt] [PATCH v2 3/3] network: Taint networks that are using hook script

2014-02-10 Thread Antoni Segura Puimedon
- Original Message - From: Michal Privoznik mpriv...@redhat.com To: Laine Stump la...@laine.org, libvir-list@redhat.com Cc: Antoni Segura Puimedon asegu...@redhat.com Sent: Monday, February 10, 2014 3:52:50 PM Subject: Re: [libvirt] [PATCH v2 3/3] network: Taint networks that are

Re: [libvirt] [PATCH] tests: Fix the build failure on s390

2014-02-10 Thread Eric Blake
On 02/10/2014 06:35 AM, Osier Yang wrote: The build works fine on other architectures with commit 0b4f76fc5, but for s390: TEST: virscsitest 1) test1 ... OK 2) test2 ... libvirt: error : SCSI device '1:0:0:0': could not access

Re: [libvirt] [PATCH] daemon: Enhance documentation for changinging NOFILE limit

2014-02-10 Thread Eric Blake
On 02/10/2014 07:26 AM, Jiri Denemark wrote: Signed-off-by: Jiri Denemark jdene...@redhat.com --- daemon/libvirtd.sysconf | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/daemon/libvirtd.sysconf b/daemon/libvirtd.sysconf index 3af1f03..06f6a2c 100644 ---

Re: [libvirt] [PATCH v2 3/3] network: Taint networks that are using hook script

2014-02-10 Thread Michal Privoznik
On 10.02.2014 15:52, Michal Privoznik wrote: On 08.02.2014 11:51, Laine Stump wrote: On 02/07/2014 10:52 PM, Antoni Segura Puimedon wrote: - Original Message - From: Laine Stump la...@laine.org To: libvir-list@redhat.com Cc: Michal Privoznik mpriv...@redhat.com Sent: Friday, February

Re: [libvirt] [PATCH] RFC: Add blockdev-delete QMP command

2014-02-10 Thread Eric Blake
On 02/07/2014 04:15 PM, Ian Main wrote: This is the sister command to blockdev-add. In Fam's example he uses the drive_del HMP command to clean up but when trying to do this via libvirt it doesn't work. This command seems to be needed in order to perform proper cleanup. Signed-off-by: Ian

Re: [libvirt] [PATCH v2 3/3] network: Taint networks that are using hook script

2014-02-10 Thread Daniel P. Berrange
On Fri, Feb 07, 2014 at 02:17:10PM +0200, Laine Stump wrote: On 02/05/2014 12:11 PM, Michal Privoznik wrote: Basically, the idea is copied from domain code, where tainting exists for a while. Currently, only one taint reason exists - VIR_NETWORK_TAINT_HOOK to mark those networks which

Re: [libvirt] [PATCH v2 3/3] network: Taint networks that are using hook script

2014-02-10 Thread Daniel P. Berrange
On Mon, Feb 10, 2014 at 03:52:50PM +0100, Michal Privoznik wrote: On 08.02.2014 11:51, Laine Stump wrote: On 02/07/2014 10:52 PM, Antoni Segura Puimedon wrote: - Original Message - From: Laine Stump la...@laine.org To: libvir-list@redhat.com Cc: Michal Privoznik mpriv...@redhat.com

Re: [libvirt] [PATCH] build: correctly check for SOICGIFVLAN GET_VLAN_VID_CMD command

2014-02-10 Thread Eric Blake
On 02/10/2014 07:17 AM, Laine Stump wrote: In order to make a client-only build successful on RHEL4, commit 3ed2e54 modified src/util/virnetdev.c so that the functional version I wonder if that was a typo in the 3ed2e54 commit message - we generally only care about RHEL5, not RHEL4. of

Re: [libvirt] [PATCH] build: correctly check for SOICGIFVLAN GET_VLAN_VID_CMD command

2014-02-10 Thread Daniel P. Berrange
On Mon, Feb 10, 2014 at 10:42:28AM -0700, Eric Blake wrote: On 02/10/2014 07:17 AM, Laine Stump wrote: In order to make a client-only build successful on RHEL4, commit 3ed2e54 modified src/util/virnetdev.c so that the functional version I wonder if that was a typo in the 3ed2e54 commit

[libvirt] [PATCH] virNetworkLoadState: Disallow mangled 'floor' element

2014-02-10 Thread Michal Privoznik
In the network status XML we may have the floor/ element with the 'sum' attribute. The attribute represents sum of all 'floor'-s of computed over each interface connected to the network (this is needed to guarantee certain bandwidth for certain domain). The sum is therefore a number. However, if

Re: [libvirt] [PATCH] virNetworkLoadState: Disallow mangled 'floor' element

2014-02-10 Thread Eric Blake
On 02/10/2014 11:30 AM, Michal Privoznik wrote: In the network status XML we may have the floor/ element with the 'sum' attribute. The attribute represents sum of all 'floor'-s of computed over each interface connected to the network (this is needed to guarantee certain bandwidth for certain

[libvirt] [PATCH v3 2/2] network: Taint networks that are using hook script

2014-02-10 Thread Michal Privoznik
Basically, the idea is copied from domain code, where tainting exists for a while. Currently, only one taint reason exists - VIR_NETWORK_TAINT_HOOK to mark those networks which caused invoking of hook script. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/conf/network_conf.c |

[libvirt] [PATCH v3 0/2] Network hooks

2014-02-10 Thread Michal Privoznik
Version three. The 1/3 from the previous round is already pushed (as it just reworks two functions - no interesting work really). The 1/2 from this patchset - I've moved the calling of the hook in networkStartNetwork() a bit forward, so now it's called before writing the network status file.

[libvirt] [PATCH v3 1/2] network: Introduce network hooks

2014-02-10 Thread Michal Privoznik
There might be some use cases, where user wants to prepare the host or its environment prior to starting a network and do some cleanup after the network has been shut down. Consider all the functionality that libvirt doesn't currently have as an example what a hook script can possibly do.

Re: [libvirt] [PATCH] virNetworkLoadState: Disallow mangled 'floor' element

2014-02-10 Thread Michal Privoznik
On 10.02.2014 19:52, Eric Blake wrote: On 02/10/2014 11:30 AM, Michal Privoznik wrote: In the network status XML we may have the floor/ element with the 'sum' attribute. The attribute represents sum of all 'floor'-s of computed over each interface connected to the network (this is needed to

Re: [libvirt] [PATCH] build: correctly check for SOICGIFVLAN GET_VLAN_VID_CMD command

2014-02-10 Thread Laine Stump
On 02/10/2014 07:42 PM, Eric Blake wrote: On 02/10/2014 07:17 AM, Laine Stump wrote: In order to make a client-only build successful on RHEL4, commit 3ed2e54 modified src/util/virnetdev.c so that the functional version I wonder if that was a typo in the 3ed2e54 commit message - we generally

Re: [libvirt] [PATCH 0/5] fix query-command-line-options

2014-02-10 Thread Luiz Capitulino
On Tue, 28 Jan 2014 11:53:45 +0800 Amos Kong ak...@redhat.com wrote: This patchset fixed some issues of query-command-line-options: * some new options haven't arguments can't be queried. (eg: -enable-fips) * some legcy options have arguments can't be queried. (eg: -vnc display) Markus,

Re: [libvirt] [PATCH] maint: fix line numbers in check-aclrules reports

2014-02-10 Thread Eric Blake
On 02/09/2014 01:10 PM, Roman Bogorodskiy wrote: Reset line numbering on each input file in check-aclrules.pl. Otherwise it reports wrong line numbers in its error messages. Signed-off-by: Yuri Myasoedov ymyasoe...@yandex.ru Generally, we like to preserve git authorship to the original patch

Re: [libvirt] [PATCH] docs: grammar fixes in formatdomain

2014-02-10 Thread Eric Blake
On 02/09/2014 07:37 PM, Chen Hanxiao wrote: From: Chen Hanxiao chenhanx...@cn.fujitsu.com Some grammar fixes. s/namespace,set/namespace, set s/container being allowed/container are allowed s/the codeuid/The codeuid Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com ---

Re: [libvirt] [PATCH] Skip the 'copyright-check' on -maint branches

2014-02-10 Thread Eric Blake
On 02/04/2014 06:51 AM, Daniel P. Berrange wrote: The maint branches will often have out of date copyright headers so we must skip the 'sc_copyright_check' rule there. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- cfg.mk | 11 +++ 1 file changed, 11 insertions(+)

Re: [libvirt] [PATCHv4 3/7] storage: Implement file storage APIs in the default storage driver

2014-02-10 Thread Eric Blake
On 02/03/2014 09:54 AM, Peter Krempa wrote: Implement the APIs added by the previous patch in the default storage driver used by qemu. --- src/check-aclrules.pl | 1 + src/storage/storage_backend.c | 37 ++ src/storage/storage_backend.h | 43 +

[libvirt] [PATCH] qemu driver: sync guest time via qemu-guest-agent when domain is resumed

2014-02-10 Thread Marcelo Tosatti
Since QEMU commit kvmclock: clock should count only if vm is running (http://lists.gnu.org/archive/html/qemu-devel/2013-06/msg01225.html), guests have their realtime clock stopped during pause. To correct the situation, invoke guest agent to sync time from host time. Signed-off-by: Marcelo

[libvirt] [PATCHv2] build: correctly check for SOICGIFVLAN GET_VLAN_VID_CMD command

2014-02-10 Thread Laine Stump
In order to make a client-only build successful on RHEL4, commit 3ed2e54 modified src/util/virnetdev.c so that the functional version of virNetDevGetVLanID() was only compiled if GET_VLAN_VID_CMD was defined. However, it is *never* defined, but is only an enum value, so the proper version was no

Re: [libvirt] [qom-cpu PATCH 7/7 v9] target-i386: CPU model subclasses

2014-02-10 Thread Andreas Färber
Am 10.02.2014 11:21, schrieb Eduardo Habkost: +static const TypeInfo x86_cpu_host_type_info = { +.name = CPU_CLASS_NAME(host), +.parent = TYPE_X86_CPU, +.instance_size = sizeof(X86CPU), +.instance_init = x86_cpu_instance_init_host, +.abstract = false, +.class_size =

Re: [libvirt] [PATCH] qemu driver: sync guest time via qemu-guest-agent when domain is resumed

2014-02-10 Thread Eric Blake
On 02/10/2014 03:10 PM, Marcelo Tosatti wrote: Since QEMU commit kvmclock: clock should count only if vm is running (http://lists.gnu.org/archive/html/qemu-devel/2013-06/msg01225.html), guests have their realtime clock stopped during pause. To correct the situation, invoke guest agent to

Re: [libvirt] [PATCHv2] build: correctly check for SOICGIFVLAN GET_VLAN_VID_CMD command

2014-02-10 Thread Eric Blake
On 02/10/2014 03:38 PM, Laine Stump wrote: In order to make a client-only build successful on RHEL4, commit 3ed2e54 modified src/util/virnetdev.c so that the functional version of virNetDevGetVLanID() was only compiled if GET_VLAN_VID_CMD was defined. However, it is *never* defined, but is

Re: [libvirt] [PATCHv2] build: correctly check for SOICGIFVLAN GET_VLAN_VID_CMD command

2014-02-10 Thread Laine Stump
On 02/11/2014 12:49 AM, Eric Blake wrote: On 02/10/2014 03:38 PM, Laine Stump wrote: In order to make a client-only build successful on RHEL4, commit 3ed2e54 modified src/util/virnetdev.c so that the functional version of virNetDevGetVLanID() was only compiled if GET_VLAN_VID_CMD was defined.

Re: [libvirt] [PATCH] qemu driver: sync guest time via qemu-guest-agent when domain is resumed

2014-02-10 Thread Marcelo Tosatti
On Mon, Feb 10, 2014 at 03:42:45PM -0700, Eric Blake wrote: On 02/10/2014 03:10 PM, Marcelo Tosatti wrote: Since QEMU commit kvmclock: clock should count only if vm is running (http://lists.gnu.org/archive/html/qemu-devel/2013-06/msg01225.html), guests have their realtime clock stopped

Re: [libvirt] [PATCH] tests: Fix the build failure on s390

2014-02-10 Thread Osier Yang
On 11/02/14 00:48, Eric Blake wrote: On 02/10/2014 06:35 AM, Osier Yang wrote: The build works fine on other architectures with commit 0b4f76fc5, but for s390: TEST: virscsitest 1) test1 ... OK 2) test2 ... libvirt: error : SCSI device '1:0:0:0': could not access

Re: [libvirt] [PATCH RFC 2/2] support configuring the format of dumping memory in qemu.conf

2014-02-10 Thread Qiao Nuohan
On 01/29/2014 07:52 PM, Daniel P. Berrange wrote: On Wed, Jan 29, 2014 at 10:15:36AM +0800, Qiao Nuohan wrote: This patch is used to add dump_memory_format to qemu.conf and make the specified format as the default dump format of 'virsh dump --memory-only'. But when --compress is specified

Re: [libvirt] [PATCHv2] build: correctly check for SOICGIFVLAN GET_VLAN_VID_CMD command

2014-02-10 Thread Eric Blake
On 02/10/2014 05:10 PM, Laine Stump wrote: AC_CHECK_DECLS unconditionally defines the variable to either 0 or 1, so checking if it is defined will still fail to compile on older headers that lack the enum; Well, it would have compiled successfully, but compiled the wrong code :-) what

Re: [libvirt] [PATCH] daemon: Enhance documentation for changinging NOFILE limit

2014-02-10 Thread Alex Jia
BTW, I filed a similar bug 1059518 for LXC guide. -- Regards, Alex - Original Message - From: Eric Blake ebl...@redhat.com To: libvir-list@redhat.com Sent: Tuesday, February 11, 2014 12:51:23 AM Subject: Re: [libvirt] [PATCH] daemon: Enhance documentation for changinging NOFILE

Re: [libvirt] [PATCHv6 0/5] Handling of undefine and redefine snapshots with VirtualBox 4.2

2014-02-10 Thread Jean-Baptiste Rouault
Hi, Is there any chance that this serie be reviewed before the next freeze ? The v1 was sent back in June and since then we need to maintain our own custom package with our patches in it because we need this feature. We're a very small team and it's quite time consuming. Regards,