[libvirt] [PATCH v3 1/4] add new virDomainMemoryDump API

2014-02-26 Thread qiaonuohan
--memory-only option is introduced without compression supported. Therefore, this is a freature regression of virsh dump. Now qemu has support dumping memory in kdump-compressed format. This patch is adding new virDomainMemoryDump API, so that the format in which qemu dump domain's memory can be sp

[libvirt] [PATCH v3 3/4] allow "virsh dump --memory-only" specify dump format

2014-02-26 Thread qiaonuohan
This patch is used to add "--compress" and "[--compression-format] " to "virsh dump --memory-only". And "virsh dump --memory-only" is going be implemented by new virDomainMemoryDump API. Signed-off-by: Qiao Nuohan --- tools/virsh-domain.c | 55 ++--

Re: [libvirt] [PATCH 3/4] qemu: export the virQEMUCapsInitGuest function.

2014-02-26 Thread Eric Blake
On 01/17/2014 08:31 AM, Francesco Romani wrote: > make the function public. > the function is useful to XML capabilities unit test. > --- > src/qemu/qemu_capabilities.c | 2 +- > src/qemu/qemu_capabilities.h | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) ACK. > +++ b/src/qemu/qemu_ca

[libvirt] Libvirt Java Bindings - adding domain event support - pull request

2014-02-26 Thread Chris Ellis
Hi all I'm new to this list, I've been making use of the Libvirt Java bindings recently. I wanted to make use of domain events yesterday so my application can be alerted when the state of a domain changes etc. However I quickly discovered that domain events are completely broken in the current J

Re: [libvirt] [PATCH 2/4] qemu: add function to fill capabilities cache

2014-02-26 Thread Eric Blake
On 01/17/2014 08:31 AM, Francesco Romani wrote: > extract and export the code to add the capabilities > for a given QEMU binary in the capabilities cache. > > The intended use case is for testing, and make writing > more test easier. > --- > src/qemu/qemu_capabilities.c | 31 +

Re: [libvirt] [PATCH 0/4] qemu: export disk snapshot capability

2014-02-26 Thread Eric Blake
On 01/17/2014 08:31 AM, Francesco Romani wrote: > This patch series extend the QEMU capabilities XML to report > if the underlying QEMU binary supports, or not, the live > disk snapshotting. > > Without this patch series, the only way to know if QEMU > has this support is to actually request a dis

Re: [libvirt] [PATCH 1/4] qemu: export disk snapshot support in capabilities

2014-02-26 Thread Eric Blake
On 01/17/2014 08:31 AM, Francesco Romani wrote: > This patch add an element to QEMU's capability XML, to s/add/adds/ > show if the underlying QEMU binary supports the live disk > snapshotting or not. > This allow any client to know ahead of time if the feature s/allow/allows/ > is available. >

Re: [libvirt] [PATCH 0/4] qemu: export disk snapshot capability

2014-02-26 Thread Eric Blake
On 02/19/2014 01:09 AM, Francesco Romani wrote: > - Original Message - >>> This patch series extend the QEMU capabilities XML to report >>> if the underlying QEMU binary supports, or not, the live >>> disk snapshotting. >> Could please someone take a look and review this? Any comment would

[libvirt] [PATCH] build: skip virportallocatortest on cygwin

2014-02-26 Thread Eric Blake
Cygwin supports and even has limited LD_PRELOAD capabilities; but because it does not use ELF binaries it cannot support RTLD_NEXT lookups. CC libvirportallocatormock_la-virportallocatortest.lo virportallocatortest.c: In function 'init_syms': virportallocatortest.c:47:24: error: 'RTLD_NEX

[libvirt] [PATCH] build: ignore cygwin toolchain droppings

2014-02-26 Thread Eric Blake
The cygwin compiler automatically creates a '*.exe.manifest' companion file for any .exe file that contains a substring that would otherwise cause newer Windows to pester users about needing admin rights (such as "update", "instal", "setup"...). This means that compilation on cygwin left behind tes

Re: [libvirt] [PATCH] Fix minor typo (unkown)

2014-02-26 Thread Eric Blake
On 02/26/2014 10:06 AM, Yuri Chornoivan wrote: > Hi, > > Sorry for not using git mailing capabilities (my mail service does not > work well with git). > > Thanks for reviewing this patch. ACK and pushed. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http:/

[libvirt] [PATCH] Fix minor typo (unkown)

2014-02-26 Thread Yuri Chornoivan
Hi, Sorry for not using git mailing capabilities (my mail service does not work well with git). Thanks for reviewing this patch. Best regards, Yuri 0001-Fix-typo-unkown-unknown.patch Description: Binary data -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/l

Re: [libvirt] [PATCH] qemu: cleanup tap devices on FreeBSD

2014-02-26 Thread Roman Bogorodskiy
Daniel P. Berrange wrote: > On Wed, Feb 26, 2014 at 09:12:11AM -0700, Eric Blake wrote: > > On 02/26/2014 08:57 AM, Roman Bogorodskiy wrote: > > >> > > >> Conceptually ok, but I fear this impl will result in the logs getting > > >> polluted with "cannot delete tap device" or similar log messages

Re: [libvirt] [lxc-devel] capset fails with userns

2014-02-26 Thread Serge Hallyn
Quoting Stephan Sachse (ste.sac...@gmail.com): > > Look at security/commoncap.c:cap_inode_setxattr() > > > > Whereas file ownership is properly namespaced, and task capabilities > > are properly namespaced, file capabilities are more problematic. To > > support this, I think we'd need a new capabi

[libvirt] [PATCH 2/2] Add a test for virUSBDeviceList functions

2014-02-26 Thread Ján Tomko
Most of them are already tested in a limited way by testing virUSBDeviceFind. --- tests/virusbtest.c | 75 ++ 1 file changed, 75 insertions(+) diff --git a/tests/virusbtest.c b/tests/virusbtest.c index f9104bf..74b9a5e 100644 --- a/tests/virusbt

[libvirt] [PATCH 1/2] Add tests for virUSBDeviceFind functions

2014-02-26 Thread Ján Tomko
Mock the /sys/bus/usb directory and test the finding (and not finding) of some USB devices. --- .gitignore | 1 + cfg.mk | 3 +- tests/Makefile.am | 12 + tests/virusbtest.c

[libvirt] [PATCH 0/2] Add virusbtest

2014-02-26 Thread Ján Tomko
Test src/util/virusb.c. Ján Tomko (2): Add tests for virUSBDeviceFind functions Add a test for virUSBDeviceList functions .gitignore | 1 + cfg.mk | 3 +- tests/Makefile.am

[libvirt] [PATCH] qemu: Enable 'host-passthrough' cpu mode for arm

2014-02-26 Thread Oleg Strikov
This patch allows libvirt user to specify 'host-passthrough' cpu mode while using qemu/kvm backend on arm (arm32). It uses 'host' as a CPU model name instead of some other stub (correct CPU detection is not implemented yet) to allow libvirt user to specify 'host-model' cpu mode as well. Signed-off

Re: [libvirt] [PATCH] qemu: cleanup tap devices on FreeBSD

2014-02-26 Thread Daniel P. Berrange
On Wed, Feb 26, 2014 at 09:12:11AM -0700, Eric Blake wrote: > On 02/26/2014 08:57 AM, Roman Bogorodskiy wrote: > >> > >> Conceptually ok, but I fear this impl will result in the logs getting > >> polluted with "cannot delete tap device" or similar log messages on OS > >> where TAP device deletion i

Re: [libvirt] [PATCH] qemu: cleanup tap devices on FreeBSD

2014-02-26 Thread Eric Blake
On 02/26/2014 08:57 AM, Roman Bogorodskiy wrote: >> >> Conceptually ok, but I fear this impl will result in the logs getting >> polluted with "cannot delete tap device" or similar log messages on OS >> where TAP device deletion is automatic. > > Do you have an idea about better way to do that? Ma

Re: [libvirt] [PATCH] qemu: cleanup tap devices on FreeBSD

2014-02-26 Thread Roman Bogorodskiy
Daniel P. Berrange wrote: > On Mon, Feb 24, 2014 at 11:12:33PM +0400, Roman Bogorodskiy wrote: > > We have to explicitly destroy TAP devices on FreeBSD because > > they're not freed after being closed, otherwise we end up with > > orphaned TAP devices after destroying a domain. > > --- > > src/

Re: [libvirt] [Xen-devel] [PATCH LIBVIRT] libxl: Recognise ARM architectures

2014-02-26 Thread Olaf Hering
On Wed, Feb 26, Ian Campbell wrote: > On Wed, 2014-02-26 at 12:37 +, Daniel P. Berrange wrote: > > On Wed, Feb 26, 2014 at 12:34:17PM +, Ian Campbell wrote: > > > Currently virsh console fails with: > > > Connected to domain libvirt-test > > > Escape character is ^] > > > error: inte

Re: [libvirt] [PATCH LIBVIRT] libxl: Recognise ARM architectures

2014-02-26 Thread Ian Campbell
On Wed, 2014-02-26 at 06:34 -0700, Eric Blake wrote: > On 02/26/2014 05:37 AM, Daniel P. Berrange wrote: > > On Wed, Feb 26, 2014 at 12:34:17PM +, Ian Campbell wrote: > >> Only tested on v7 but the v8 equivalent seems pretty obvious. > >> > >> XEN_CAP_REGEX already accepts more than it should (

Re: [libvirt] LXC: capset fails with userns

2014-02-26 Thread Daniel P. Berrange
On Wed, Feb 26, 2014 at 08:54:02AM -0600, Serge Hallyn wrote: > Quoting Stephan Sachse (ste.sac...@gmail.com): > > for me there is no valid reason why a container is not allowed to set > > file capabilities. > > (For the sake of the libvir-list, I replied to this on the lxc-devel@ > list with a pr

Re: [libvirt] [Xen-devel] [PATCH LIBVIRT] libxl: Recognise ARM architectures

2014-02-26 Thread Ian Campbell
On Wed, 2014-02-26 at 15:00 +0100, Olaf Hering wrote: > On Wed, Feb 26, Ian Campbell wrote: > > > On Wed, 2014-02-26 at 12:37 +, Daniel P. Berrange wrote: > > > On Wed, Feb 26, 2014 at 12:34:17PM +, Ian Campbell wrote: > > > > Currently virsh console fails with: > > > > Connected to doma

Re: [libvirt] [Xen-devel] [PATCH LIBVIRT] libxl: Recognise ARM architectures

2014-02-26 Thread Daniel P. Berrange
On Wed, Feb 26, 2014 at 02:55:13PM +, Ian Campbell wrote: > On Wed, 2014-02-26 at 15:00 +0100, Olaf Hering wrote: > > On Wed, Feb 26, Ian Campbell wrote: > > > > > On Wed, 2014-02-26 at 12:37 +, Daniel P. Berrange wrote: > > > > On Wed, Feb 26, 2014 at 12:34:17PM +, Ian Campbell wrote:

Re: [libvirt] LXC: capset fails with userns

2014-02-26 Thread Serge Hallyn
Quoting Stephan Sachse (ste.sac...@gmail.com): > for me there is no valid reason why a container is not allowed to set > file capabilities. (For the sake of the libvir-list, I replied to this on the lxc-devel@ list with a proposal that should work; but this particular patch is not safe, as nothin

Re: [libvirt] [PATCH v2 1/2] make qemu dump memory in kdump-compressed format

2014-02-26 Thread Daniel P. Berrange
On Wed, Feb 26, 2014 at 04:08:11PM +0800, Qiao Nuohan wrote: > On 02/25/2014 06:56 PM, Jiri Denemark wrote: > >On Tue, Feb 25, 2014 at 17:54:30 +0800, Qiao Nuohan wrote: > >>--memory-only option is introduced without compression supported. Therefore, > >>this is a freature regression of virsh dump.

Re: [libvirt] LXC: capset fails with userns

2014-02-26 Thread Stephan Sachse
for me there is no valid reason why a container is not allowed to set file capabilities. and here is the patch (send to Eric W. Biederman ) works for me -- Software is like sex, it's better when it's free! Subject: [PATCH] capability: allow setxattr within userns a lxc container with user name

Re: [libvirt] [PATCH LIBVIRT] libxl: Recognise ARM architectures

2014-02-26 Thread Eric Blake
On 02/26/2014 05:37 AM, Daniel P. Berrange wrote: > On Wed, Feb 26, 2014 at 12:34:17PM +, Ian Campbell wrote: >> Only tested on v7 but the v8 equivalent seems pretty obvious. >> >> XEN_CAP_REGEX already accepts more than it should (e.g. x86_64p or x86_32be) >> but I have stuck with the existing

Re: [libvirt] [PATCH] spec: Use correct versions of libgfapi in RHEL builds

2014-02-26 Thread Eric Blake
On 02/26/2014 05:35 AM, Martin Kletzander wrote: > On Wed, Feb 26, 2014 at 01:09:48PM +0100, Peter Krempa wrote: >> RHEL still uses the 3.4.0 package of libgfapi and the package is built >> only for x86_64. >> --- >> libvirt.spec.in | 14 +- >> 1 file changed, 13 insertions(+), 1 delet

Re: [libvirt] [PATCH] spec: Fix braces around macros

2014-02-26 Thread Eric Blake
On 02/26/2014 06:21 AM, Peter Krempa wrote: > In commit 72f7658ba24491672e6b81118f892400916e9404 I've added a few > macros with bad bracing. Although they work as expected fix them so that > we use uniform syntax. > --- > libvirt.spec.in | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [libvirt] [PATCH] spec: Fix braces around macros

2014-02-26 Thread Peter Krempa
On 02/26/14 14:29, Eric Blake wrote: > On 02/26/2014 06:21 AM, Peter Krempa wrote: >> In commit 72f7658ba24491672e6b81118f892400916e9404 I've added a few >> macros with bad bracing. Although they work as expected fix them so that >> we use uniform syntax. >> --- >> libvirt.spec.in | 4 ++-- >> 1 f

Re: [libvirt] [PATCH] spec: Fix braces around macros

2014-02-26 Thread Martin Kletzander
On Wed, Feb 26, 2014 at 02:21:11PM +0100, Peter Krempa wrote: > In commit 72f7658ba24491672e6b81118f892400916e9404 I've added a few > macros with bad bracing. Although they work as expected fix them so that > we use uniform syntax. > --- > libvirt.spec.in | 4 ++-- > 1 file changed, 2 insertions(+

[libvirt] [PATCH] spec: Fix braces around macros

2014-02-26 Thread Peter Krempa
In commit 72f7658ba24491672e6b81118f892400916e9404 I've added a few macros with bad bracing. Although they work as expected fix them so that we use uniform syntax. --- libvirt.spec.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index fa

Re: [libvirt] [PATCH v2 1/2] make qemu dump memory in kdump-compressed format

2014-02-26 Thread Eric Blake
On 02/26/2014 01:08 AM, Qiao Nuohan wrote: >>>int virDomainCoreDump (virDomainPtr domain, >>> const char *to, >>> - unsigned int flags); >>> +

Re: [libvirt] [PATCH 1/3] build: fix spelling of configur --with-systemd-daemon

2014-02-26 Thread Eric Blake
On 02/26/2014 03:02 AM, Christophe Fergeau wrote: > Hey, > > There is a missing 'e' in "configure" in the subject line. Thanks; fixed (actually, reworded): build: use --with-systemd-daemon as configure option . On 02/26/2014 02:59 AM, Michal Privoznik wrote: > On 25.02.2014 18:52, Eric Blake wro

Re: [libvirt] [PATCH] virsh: Honour -q in domblklist, vcpupin and emulatorpin

2014-02-26 Thread Martin Kletzander
On Wed, Feb 26, 2014 at 01:25:09PM +0100, Michal Privoznik wrote: > If user wants to grep some info from domain, e.g. disk paths: > > # virsh -q domblklist win7 | awk '{print $2}' > Source > > /var/lib/libvirt/images/windows.qcow2 > /home/zippy/work/tmp/en_windows_7_professional_x64

Re: [libvirt] [PATCH LIBVIRT] libxl: Recognise ARM architectures

2014-02-26 Thread Ian Campbell
On Wed, 2014-02-26 at 12:37 +, Daniel P. Berrange wrote: > On Wed, Feb 26, 2014 at 12:34:17PM +, Ian Campbell wrote: > > Currently virsh console fails with: > > Connected to domain libvirt-test > > Escape character is ^] > > error: internal error: cannot find character device > > >

Re: [libvirt] [PATCH LIBVIRT] libxl: Recognise ARM architectures

2014-02-26 Thread Daniel P. Berrange
On Wed, Feb 26, 2014 at 12:34:17PM +, Ian Campbell wrote: > Only tested on v7 but the v8 equivalent seems pretty obvious. > > XEN_CAP_REGEX already accepts more than it should (e.g. x86_64p or x86_32be) > but I have stuck with the existing pattern. > > With this I can create a guest from: >

Re: [libvirt] [PATCH] spec: Use correct versions of libgfapi in RHEL builds

2014-02-26 Thread Martin Kletzander
On Wed, Feb 26, 2014 at 01:09:48PM +0100, Peter Krempa wrote: > RHEL still uses the 3.4.0 package of libgfapi and the package is built > only for x86_64. > --- > libvirt.spec.in | 14 +- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/libvirt.spec.in b/libvirt.spec.i

[libvirt] [PATCH LIBVIRT] libxl: Recognise ARM architectures

2014-02-26 Thread Ian Campbell
Only tested on v7 but the v8 equivalent seems pretty obvious. XEN_CAP_REGEX already accepts more than it should (e.g. x86_64p or x86_32be) but I have stuck with the existing pattern. With this I can create a guest from: libvirt-test 6343998e-9eda-11e3-98f6-77252a7d02f3 393216 3

Re: [libvirt] [PATCH] spec: Use correct versions of libgfapi in RHEL builds

2014-02-26 Thread Peter Krempa
On 02/26/14 13:15, Jiri Denemark wrote: > On Wed, Feb 26, 2014 at 13:09:48 +0100, Peter Krempa wrote: >> RHEL still uses the 3.4.0 package of libgfapi and the package is built >> only for x86_64. >> --- >> libvirt.spec.in | 14 +- >> 1 file changed, 13 insertions(+), 1 deletion(-) >>

[libvirt] [PATCH] virsh: Honour -q in domblklist, vcpupin and emulatorpin

2014-02-26 Thread Michal Privoznik
If user wants to grep some info from domain, e.g. disk paths: # virsh -q domblklist win7 | awk '{print $2}' Source /var/lib/libvirt/images/windows.qcow2 /home/zippy/work/tmp/en_windows_7_professional_x64_dvd_X15-65805.iso while with my change: # virsh -q domblklist win7 | aw

Re: [libvirt] [PATCH] spec: Use correct versions of libgfapi in RHEL builds

2014-02-26 Thread Jiri Denemark
On Wed, Feb 26, 2014 at 13:09:48 +0100, Peter Krempa wrote: > RHEL still uses the 3.4.0 package of libgfapi and the package is built > only for x86_64. > --- > libvirt.spec.in | 14 +- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/libvirt.spec.in b/libvirt.spec.in

[libvirt] [PATCH] spec: Use correct versions of libgfapi in RHEL builds

2014-02-26 Thread Peter Krempa
RHEL still uses the 3.4.0 package of libgfapi and the package is built only for x86_64. --- libvirt.spec.in | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 3d5a69e..67b5557 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in

Re: [libvirt] [PATCH] Fix memory leak in virDomainSnapshotDiskDefClear()

2014-02-26 Thread Ján Tomko
On 02/22/2014 08:37 PM, Nehal J Wani wrote: > While running domainsnapshotxml2xmltest, it was found that valgrind pointed > out > the following memory leaks: > > ==32176== 42 (32 direct, 10 indirect) bytes in 1 blocks are definitely lost > in loss record 42 of 66 > ==32176==at 0x4A069EE: mal

Re: [libvirt] [PATCHv2 1/10] nwfilter: make ignoring non-zero status easier to follow

2014-02-26 Thread Laine Stump
On 02/26/2014 01:37 AM, Eric Blake wrote: > While auditing all callers of virCommandRun, I noticed that nwfilter > code never paid attention to commands with a non-zero status; they > were merely passing a pointer to avoid spamming the logs with a > message about commands that might indeed fail. B

Re: [libvirt] [PATCH] network: don't even call networkRunHook if there is no network

2014-02-26 Thread Laine Stump
On 02/26/2014 12:42 PM, Michal Privoznik wrote: > On 25.02.2014 16:46, Laine Stump wrote: >> [...] >> This patch refactors that code a slight bit so that networkRunHook() >> doesn't get called if netdef is NULL (i.e. type != network) and to >> place the conditional increment of dev->connections ins

Re: [libvirt] LXC: capset fails with userns

2014-02-26 Thread Stephan Sachse
> The capable() function only suceeds in the primary host namespace. > > The kernel uses ns_capable() in cases where container namespaces > are allowed to use capabilities. > > So this indicates that the kernel guys didn't believe it to be > safe to allow use of the 'trusted' xattr namespace in co

Re: [libvirt] [PATCH] network: unplug bandwidth and call networkRunHook only when appropriate

2014-02-26 Thread Michal Privoznik
On 25.02.2014 16:47, Laine Stump wrote: According to commit b4e0299dm if networkAllocateActualDevice() was The 'm' at the end of has is a typo. s/dm/d,/ successful, it will *always* allocate an iface->data.network.actual, so we can use this during networkReleaseActualDevice() to know if there

Re: [libvirt] LXC: capset fails with userns

2014-02-26 Thread Daniel P. Berrange
On Wed, Feb 26, 2014 at 11:38:08AM +0100, Stephan Sachse wrote: > trusted.* xattrs are only for CAP_SYS_ADMIN > > [host] # setfattr -n trusted.me.md5 -v > d41d8cd98f00b204e9800998ecf8427e xattr-test > [host] # getfattr -m - -d xattr-test > # file: xattr-test > trusted.me.md5="d41d8cd98f00b204e9800

Re: [libvirt] [PATCH] Fix memory leak in virSCSIDeviceListDel()

2014-02-26 Thread Ján Tomko
On 02/22/2014 09:00 PM, Nehal J Wani wrote: > While running virscsitest, it was found that valgrind pointed out the > following > memory leak: > > ==320== 5 bytes in 1 blocks are definitely lost in loss record 4 of 37 > ==320==at 0x4A069EE: malloc (vg_replace_malloc.c:270) > ==320==by 0x3

Re: [libvirt] [PATCH] network: don't even call networkRunHook if there is no network

2014-02-26 Thread Michal Privoznik
On 25.02.2014 16:46, Laine Stump wrote: networkAllocateActualDevice() is called for *all* interfaces, not just those with type='network'. In that case, it will jump down to its validate: label immediately, without allocating anything. After validation is done, two counters are potentially updated

Re: [libvirt] LXC: capset fails with userns

2014-02-26 Thread Stephan Sachse
trusted.* xattrs are only for CAP_SYS_ADMIN [host] # setfattr -n trusted.me.md5 -v d41d8cd98f00b204e9800998ecf8427e xattr-test [host] # getfattr -m - -d xattr-test # file: xattr-test trusted.me.md5="d41d8cd98f00b204e9800998ecf8427e" [lxc] # getfattr -n trusted.me.md5 xattr-test xattr-test: truste

Re: [libvirt] [PATCH 1/3] build: fix spelling of configur --with-systemd-daemon

2014-02-26 Thread Christophe Fergeau
Hey, There is a missing 'e' in "configure" in the subject line. Christophe On Tue, Feb 25, 2014 at 10:52:24AM -0700, Eric Blake wrote: > Commit 68954fb added a configure option --with-systemd_daemon, > which violates the conventions of configure files preferring > dash in all option names. This

Re: [libvirt] [PATCH 0/3] spec file improvements

2014-02-26 Thread Michal Privoznik
On 25.02.2014 18:52, Eric Blake wrote: Our spec file is non-deterministic if you have this in your ~/.rpmmacros: %_without_udev 1 because it then depends on whether you have systemd-devel installed rather than being explicitly stated in the spec file. [At this point, I'm sending the series to ge

[libvirt] [PATCH] virDomainGetCPUStats: fix boundary value problem of start_cpu

2014-02-26 Thread Jincheng Miao
This API has boundary value problem, if start_cpu is equal to the number of cpus, no error infomation will be reported. This is because the confused meaning of variable max_id, so change the comparision and rename the variable max_id to total_num. Signed-off-by: Jincheng Miao --- src/qemu/qemu_

Re: [libvirt] [PATCH v2 1/2] make qemu dump memory in kdump-compressed format

2014-02-26 Thread Qiao Nuohan
On 02/25/2014 06:56 PM, Jiri Denemark wrote: On Tue, Feb 25, 2014 at 17:54:30 +0800, Qiao Nuohan wrote: --memory-only option is introduced without compression supported. Therefore, this is a freature regression of virsh dump. Now qemu has support dumping memory in kdump-compressed format. This p

[libvirt] [question] doubt about cpu model 'qemu64'

2014-02-26 Thread Wangyufei (James)
Hello, Recently I noticed that if I gave no model to qemu, then I would get 'qemu64' as default cpu model. Model 'qemu64' defined in qemu and defined in libvirt both support feature 'svm'. And if I start a VM with 'qemu64' as the qemu default model, I can get no 'svm' feature in the GuestOS