A patch submitted by Steven Malin last week pointed out a problem with
libvirt's DNS SRV record configuration:
https://www.redhat.com/archives/libvir-list/2014-March/msg00536.html
When searching for that message later, I found another series that had
been posted by Guannan Ren back in 2012
On 10.03.2014 12:26, Martin Kletzander wrote:
Introducing keepalive similarly to Guannan around 2 years ago. Since
we want to introduce keepalive for every connection, it makes sense to
wrap the connecting function into new virsh one that can deal
keepalive as well.
Function vshConnect() is
On 10.03.2014 12:26, Martin Kletzander wrote:
Addition of vshConnect() makes virConnectOpen() functions obsolete in
virsh. Thus all virsh-*.[ch] files should be left only with
vshConnect() in the case of need.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
cfg.mk | 8 +++-
1
On Tue, Mar 18, 2014 at 12:07:17AM -0600, Laine Stump wrote:
A patch submitted by Steven Malin last week pointed out a problem with
libvirt's DNS SRV record configuration:
https://www.redhat.com/archives/libvir-list/2014-March/msg00536.html
When searching for that message later, I found
--memory-only option is introduced without compression supported. Now qemu has
support dumping domain's memory in kdump-compressed format. This patch is adding
new virDomainCoreDumpWithFormat API, so that the format in which qemu dumps
domain's memory can be specified.
Signed-off-by: Qiao Nuohan
dumping guest's memory is introduced without compression supported, but now
qemu can dump guest's memory in kdump-compressed format. This patchset is used
to add support in libvirt side to let qemu do the dump in compressed format and
please refer the following address to see implementation of the
This patch adds qemuMonitorGetDumpGuestMemoryCapability, which is used to check
whether the specified dump-guest-memory format is supported by qemu.
Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com
---
src/qemu/qemu_monitor.c | 21 ++
src/qemu/qemu_monitor.h | 3 ++
This patch makes qemu driver support virDomainCoreDumpWithFormat API.
Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com
---
src/qemu/qemu_driver.c | 70 +---
src/qemu/qemu_monitor.c | 6 ++--
src/qemu/qemu_monitor.h | 3 +-
This patch adds [--compression-format] string to virsh dump --memory-only,
which is changed to use the new virDomainCoreDumpWithFormat API. And
--compress is added as an alias for --compression-format zlib.
Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com
---
tools/virsh-domain.c | 45
While running qemuxml2xmltest, it was found that valgrind pointed out
the following memory leak:
==21905== 26 bytes in 1 blocks are definitely lost in loss record 23 of 69
==21905==at 0x4A069EE: malloc (vg_replace_malloc.c:270)
==21905==by 0x3E782A754D: xmlStrndup (in
On Tue, Mar 18, 2014 at 08:05:51AM +0100, Michal Privoznik wrote:
On 10.03.2014 12:26, Martin Kletzander wrote:
Addition of vshConnect() makes virConnectOpen() functions obsolete in
virsh. Thus all virsh-*.[ch] files should be left only with
vshConnect() in the case of need.
On Tue, Mar 18, 2014 at 08:05:54AM +0100, Michal Privoznik wrote:
On 10.03.2014 12:26, Martin Kletzander wrote:
Introducing keepalive similarly to Guannan around 2 years ago. Since
we want to introduce keepalive for every connection, it makes sense to
wrap the connecting function into new
A vm which uses macvtap will not respond ping request, when the vm is being
migrated.
I found that on the destination side the macvtap will send a IPv6 packet at the
begin of migration to update the route table in switch, however VM is still on
the src.
In this case , what can I do to avoid
The @ret value is built in a loop. However, if in one iteration
there's an error, we should free all the fields built so far. For
instance, if there's an error and the previous item was
type of VIR_TYPED_PARAM_STRING we definitely must free it.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
In the setPyVirTypedParameter we try to produce virTypedParameter
array from a pyhthon dictionary. However, when copying field name into
item in returned array, we use strncpy() as the field name is fixed
length array. To determine its size we use sizeof() but mistakenly
dereference it resulting
On 17.03.2014 20:31, Brian Rak wrote:
I've been trying to use domain.setInterfaceParameters, and I'm finding
it's throwing the mysterious error:
libvirt.libvirtError: argument unsupported: parameter '' not supported
Enabling debug mode in libvirt reveals this:
2014-03-17 18:41:33.780+:
On 18.03.2014 02:20, Eric Blake wrote:
On 03/17/2014 05:46 PM, Jim Fehlig wrote:
I received a report about an odd use case of /etc/libvirt/driver/
config files, and would like to hear some opinions about it. The user
preps a host by mounting a remote fs containing VM images and config,
creates
On Tue, Mar 18, 2014 at 01:02:24PM +0530, Nehal J Wani wrote:
While running qemuxml2xmltest, it was found that valgrind pointed out
the following memory leak:
==21905== 26 bytes in 1 blocks are definitely lost in loss record 23 of 69
==21905==at 0x4A069EE: malloc
On Mon, Mar 17, 2014 at 09:25:13AM -0600, Eric Blake wrote:
On 03/17/2014 08:39 AM, Martin Kletzander wrote:
Although not explicitly requested, we are using KR (or Kernel)
indentation for curly braces around functions in HACKING file and most
of the code. The rest is inconsistent and this
On Tue, Mar 18, 2014 at 09:26:08AM +0100, Michal Privoznik wrote:
In the setPyVirTypedParameter we try to produce virTypedParameter
array from a pyhthon dictionary. However, when copying field name into
s/pyhthon/python/
item in returned array, we use strncpy() as the field name is fixed
On Tue, Mar 18, 2014 at 09:26:09AM +0100, Michal Privoznik wrote:
The @ret value is built in a loop. However, if in one iteration
there's an error, we should free all the fields built so far. For
instance, if there's an error and the previous item was
type of VIR_TYPED_PARAM_STRING we
The only supported flag for now is 'autodestroy'. In order to
support 'autodestroy', add support for close callbacks.
---
src/bhyve/bhyve_driver.c | 28 +---
src/bhyve/bhyve_process.c | 29 -
src/bhyve/bhyve_process.h | 7 ++-
On Mon, Mar 17, 2014 at 05:46:04PM -0600, Jim Fehlig wrote:
I received a report about an odd use case of /etc/libvirt/driver/
config files, and would like to hear some opinions about it. The user
preps a host by mounting a remote fs containing VM images and config,
creates links in
We allow translation from no_bandwidth to has_bandwidth for a vnic.
However, going in the opposite direction is not implemented. It's not
limitation of the API rather than internal implementation. The problem
is, we correctly detect that user hasn't specified any outbound (say
he wants to clear
Coverity spotted a use of possibly undefined variable. If a server is
restarting as an result of update, the JSON file that keeps current
value of some variables will not contain the new variables. This is
the case of @max_anonymous_clients too. We are correctly querying if
there's
On 17.3.2014 16:38, Eric Blake wrote:
On 03/17/2014 08:39 AM, Martin Kletzander wrote:
This patch is not trying to fix every switch, just the ones I worked
with last time, because some of these were especially unreadable.
Covers enums virDomainGraphicsType and virDomainChrType (where
On Tue, Mar 18, 2014 at 11:10:58AM +0100, Michal Privoznik wrote:
Coverity spotted a use of possibly undefined variable. If a server is
restarting as an result of update, the JSON file that keeps current
value of some variables will not contain the new variables. This is
the case of
On Mon, Mar 17, 2014 at 09:33:11 -0600, Eric Blake wrote:
On 03/14/2014 12:55 PM, Jiri Denemark wrote:
On Fri, Mar 14, 2014 at 07:54:58 -0600, Eric Blake wrote:
On 03/14/2014 04:43 AM, Jiri Denemark wrote:
Ancient automake (such as from RHEL5) does not provide abs_srcdir and
abs_builddir
On Tue, Mar 18, 2014 at 11:36:51AM +0100, Jiri Denemark wrote:
On Mon, Mar 17, 2014 at 09:33:11 -0600, Eric Blake wrote:
On 03/14/2014 12:55 PM, Jiri Denemark wrote:
On Fri, Mar 14, 2014 at 07:54:58 -0600, Eric Blake wrote:
On 03/14/2014 04:43 AM, Jiri Denemark wrote:
Ancient automake
On Tue, Mar 18, 2014 at 10:42:01 +, Daniel Berrange wrote:
On Tue, Mar 18, 2014 at 11:36:51AM +0100, Jiri Denemark wrote:
On Mon, Mar 17, 2014 at 09:33:11 -0600, Eric Blake wrote:
On 03/14/2014 12:55 PM, Jiri Denemark wrote:
On Fri, Mar 14, 2014 at 07:54:58 -0600, Eric Blake wrote:
Make the 'python setup.py test' able to run unit tests
found under tests/ through the 'nosetests' command
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
setup.py | 5 +
tests/test_conn.py | 16
2 files changed, 21 insertions(+)
create mode 100644
Add a test setting scheduler parameters to validate the
previous bugfix to strncpy of field names.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
tests/test_domain.py | 19 +++
1 file changed, 19 insertions(+)
create mode 100644 tests/test_domain.py
diff --git
The bug fix of Michal's to handling of typed parameters demonstrated
a clear need for a unit test framework for python bindings. By using
the test:///default driver we can easily test a great many python
APIs. Once the test driver has full API coverage, we can in fact unit
test all the python
On Mon, Mar 17, 2014 at 09:16:07AM -0600, Eric Blake wrote:
On 03/17/2014 08:39 AM, Martin Kletzander wrote:
Eliminate all the code re-use which checks for priv-agentError or
priv-agent.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/qemu/qemu_domain.c | 22 +
On Mon, Mar 17, 2014 at 09:19:02AM -0600, Eric Blake wrote:
On 03/17/2014 08:39 AM, Martin Kletzander wrote:
When ran, cil is throwing out some errors and warnings for obsolete
'or' unused variables and wrong module name (it should not contain a
hyphen; hence the rename).
On Mon, Mar 17, 2014 at 09:27:14AM -0600, Eric Blake wrote:
On 03/17/2014 08:39 AM, Martin Kletzander wrote:
If there should be some sort of separator it is better to use comment
with the filename, copyright, description, license information and
authors.
Found by:
git grep -nH
On Mon, Mar 17, 2014 at 09:40:46AM -0600, Eric Blake wrote:
On 03/17/2014 08:39 AM, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/conf/domain_conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
ACK
Pushed, thanks.
Martin
diff
On Tue, Mar 18, 2014 at 11:15:01AM +0100, Pavel Hrdina wrote:
On 17.3.2014 16:38, Eric Blake wrote:
On 03/17/2014 08:39 AM, Martin Kletzander wrote:
This patch is not trying to fix every switch, just the ones I worked
with last time, because some of these were especially unreadable.
On Mon, Mar 17, 2014 at 09:44:45AM -0600, Eric Blake wrote:
On 03/17/2014 08:39 AM, Martin Kletzander wrote:
Commit a1cbe4b5 added a check for spaces around assignments and this
patch extends it to checks for spaces around '=='. One exception is
virAssertCmpInt where comma after '==' is
Reported by Martin Kletzander
---
Pushed as trivial.
cfg.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cfg.mk b/cfg.mk
index a2fed11..e75323e 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -888,7 +888,7 @@ sc_prohibit_wrong_filename_in_comment:
}
On 03/18/2014 05:00 AM, Jiri Denemark wrote:
Why don't we just avoid the whole issue by removing use of abs_srcdir
and abs_builddir. Can this rule:
$(abs_builddir)/cpu/cpu_map.xml:
$(AM_V_GEN)ln -s $(abs_srcdir)/cpu/cpu_map.xml $@
be just changed to
cpu/cpu_map.xml:
Just to align the backslashes with most of the file.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
Notes:
Pushed as 'trivial'.
cfg.mk | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/cfg.mk b/cfg.mk
index e75323e..319210b 100644
--- a/cfg.mk
+++ b/cfg.mk
Many nwfilter methods have an 'int stopOnError' parameter but
with 1 exception, the callers always pass '1'. The parameter
can therefore be removed from all except one method. That method
will be changed to 'bool stopOnError'
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
A lot of methods have a 'bool incoming' parameter but then
do (incoming) ? ... : The round brackets here add nothing
to the code so can be removed.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/nwfilter/nwfilter_ebiptables_driver.c | 92 +++
1
This mini-series performs a few style cleanups on the nwfilter
code. There should be no functional change in any of these
patches.
Daniel P. Berrange (6):
Change 'int incoming' to 'bool incoming' in nwfilter code
Remove pointless brackets around boolean
Remove 'int stopOnError' parameters
The CMD_STOPONERR macro uses its parameter as a boolean, so should
be passed true rather than 1.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/nwfilter/nwfilter_ebiptables_driver.c | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git
The 'int isTempChain' parameter to various nwfilter methods
only takes two values so should be a bool type.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/nwfilter/nwfilter_ebiptables_driver.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff
Many methods in the nwfilter code have an 'int incoming' parameter
that only takes 0 or 1, so should use a bool instead.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/nwfilter/nwfilter_ebiptables_driver.c | 187 +++---
1 file changed, 94 insertions(+), 93
Many nwfilter methods have an int return value but only ever
return 0 and their callers never check the return value either.
These methods can all be void.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/nwfilter/nwfilter_ebiptables_driver.c | 157 --
1
Michal Privoznik wrote:
On 18.03.2014 02:20, Eric Blake wrote:
On 03/17/2014 05:46 PM, Jim Fehlig wrote:
I received a report about an odd use case of /etc/libvirt/driver/
config files, and would like to hear some opinions about it. The user
preps a host by mounting a remote fs containing VM
Hi -
On Tue, Mar 18, 2014 at 05:14:38AM +, yangzy.f...@cn.fujitsu.com wrote:
[...]
(For what it's worth, there are several different ways of executing
systemtap
scripts automatically at startup. There is an initscript.
With the next version, its docs will move into 'man 8
On 03/18/2014 07:36 AM, Daniel P. Berrange wrote:
Many methods in the nwfilter code have an 'int incoming' parameter
that only takes 0 or 1, so should use a bool instead.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/nwfilter/nwfilter_ebiptables_driver.c | 187
On 03/18/2014 07:36 AM, Daniel P. Berrange wrote:
A lot of methods have a 'bool incoming' parameter but then
do (incoming) ? ... : The round brackets here add nothing
to the code so can be removed.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
On 03/18/2014 07:36 AM, Daniel P. Berrange wrote:
The 'int isTempChain' parameter to various nwfilter methods
only takes two values so should be a bool type.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/nwfilter/nwfilter_ebiptables_driver.c | 24
On 03/18/2014 07:36 AM, Daniel P. Berrange wrote:
The CMD_STOPONERR macro uses its parameter as a boolean, so should
be passed true rather than 1.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/nwfilter/nwfilter_ebiptables_driver.c | 30 +++---
1
On Tue, Mar 18, 2014 at 06:27:48 -0600, Eric Blake wrote:
On 03/18/2014 05:00 AM, Jiri Denemark wrote:
Why don't we just avoid the whole issue by removing use of abs_srcdir
and abs_builddir. Can this rule:
$(abs_builddir)/cpu/cpu_map.xml:
$(AM_V_GEN)ln -s
On 03/18/2014 09:25 AM, Eric Blake wrote:
On 03/18/2014 07:36 AM, Daniel P. Berrange wrote:
The CMD_STOPONERR macro uses its parameter as a boolean, so should
be passed true rather than 1.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/nwfilter/nwfilter_ebiptables_driver.c |
On 03/18/2014 07:36 AM, Daniel P. Berrange wrote:
This mini-series performs a few style cleanups on the nwfilter
code. There should be no functional change in any of these
patches.
Daniel P. Berrange (6):
Change 'int incoming' to 'bool incoming' in nwfilter code
Remove pointless
On 03/18/2014 09:32 AM, Jiri Denemark wrote:
On Tue, Mar 18, 2014 at 06:27:48 -0600, Eric Blake wrote:
On 03/18/2014 05:00 AM, Jiri Denemark wrote:
Why don't we just avoid the whole issue by removing use of abs_srcdir
and abs_builddir. Can this rule:
$(abs_builddir)/cpu/cpu_map.xml:
On Tue, Mar 18, 2014 at 09:21:14AM -0600, Eric Blake wrote:
On 03/18/2014 07:36 AM, Daniel P. Berrange wrote:
The 'int isTempChain' parameter to various nwfilter methods
only takes two values so should be a bool type.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
On 03/18/2014 09:47 AM, Daniel P. Berrange wrote:
On Tue, Mar 18, 2014 at 09:21:14AM -0600, Eric Blake wrote:
On 03/18/2014 07:36 AM, Daniel P. Berrange wrote:
The 'int isTempChain' parameter to various nwfilter methods
only takes two values so should be a bool type.
Signed-off-by: Daniel P.
On 03/18/2014 04:01 AM, Michal Privoznik wrote:
We allow translation from no_bandwidth to has_bandwidth for a vnic.
However, going in the opposite direction is not implemented. It's not
limitation of the API rather than internal implementation.
Awkward. How about:
It's not a limitation of
On 03/18/2014 07:36 AM, Daniel P. Berrange wrote:
Many nwfilter methods have an int return value but only ever
return 0 and their callers never check the return value either.
These methods can all be void.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
On 18.03.2014 12:27, Daniel P. Berrange wrote:
The bug fix of Michal's to handling of typed parameters demonstrated
a clear need for a unit test framework for python bindings. By using
the test:///default driver we can easily test a great many python
APIs. Once the test driver has full API
Per the documentation, is_selinux_enabled() returns -1 on error. Account
for this. Previously when -1 was being returned the condition would
still be true. I was noticing this because on my system that has selinux
disabled I was getting this in the libvirt.log every 5 seconds:
error :
To allow for fault injection of the virCommand dry run,
add the ability to register a callback. The callback will
be passed the argv, env and stdin buffer and is expected
to return the exit status and optionally fill stdout and
stderr buffers.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
libxl uses the libxl_vnc_info and libxl_sdl_info fields from the
hvm union in libxl_domain_build_info struct when generating QEMU
args for VNC or SDL. These fields were left unset by the libxl
driver, causing libxl to ignore any user settings. E.g. with
graphics type='vnc' port='5950'/
port
On Tue, Mar 18, 2014 at 12:19:47PM -0600, Jim Fehlig wrote:
libxl uses the libxl_vnc_info and libxl_sdl_info fields from the
hvm union in libxl_domain_build_info struct when generating QEMU
args for VNC or SDL. These fields were left unset by the libxl
driver, causing libxl to ignore any user
Emacs is fairly good about navigating across function and scope
boundaries, provided that the code has balanced {}. The vbox
code, however, violated that premise, by splitting 'if () {'
across several #ifdef branches, but sharing the '} else {...}'
outside of the branches. The extra lines of
Daniel P. Berrange wrote:
On Tue, Mar 18, 2014 at 12:19:47PM -0600, Jim Fehlig wrote:
libxl uses the libxl_vnc_info and libxl_sdl_info fields from the
hvm union in libxl_domain_build_info struct when generating QEMU
args for VNC or SDL. These fields were left unset by the libxl
driver,
Hi,
In order to migrate a VM from an older system with qemu-kvm to a newer
one with qemu, the newer qemu needs to be told to use the same vga
ram size as qemu-kvm used, 8M.
virsh domxml-from-native suggests that the way to specify a
8mb cirrus vga ram size would be to add
qemu:commandline
On 03/18/2014 03:59 PM, Serge Hallyn wrote:
Hi,
In order to migrate a VM from an older system with qemu-kvm to a newer
one with qemu, the newer qemu needs to be told to use the same vga
ram size as qemu-kvm used, 8M.
virsh domxml-from-native suggests that the way to specify a
8mb cirrus
While running qemuhotplugtest, it was found that valgrind pointed out
the following memory leak:
==7906== 5 bytes in 1 blocks are definitely lost in loss record 7 of 121
==7906==at 0x4A069EE: malloc (vg_replace_malloc.c:270)
==7906==by 0x3E782A754D: xmlStrndup (in
From: Stefan Berger stef...@linux.vnet.ibm.com
https://bugzilla.redhat.com/show_bug.cgi?id=1071181
Commit 49b59a15 fixed one problem but masks another one related to pointer
freeing.
Use virAtomicIntGet() to test for 0 rather than trying to test for 'true'
after virAtomicIntDecAndTest().
Following Jim's comments about add pci passthrough to libxl patch:
https://www.redhat.com/archives/libvir-list/2014-March/msg00170.html
Signed-off-by: Chunyan Liu cy...@suse.com
---
src/libxl/libxl_driver.c | 47 +++
1 file changed, 19 insertions(+),
For libxl driver usage, it didn't support hostdev passthrough before,
oldStateDir is NULL when calling virHostdevReAttachDomainHostdevs.
That is allowed. Remove ATTRIBUTE_NONNULL setting to oldStateDir.
Signed-off-by: Chunyan Liu cy...@suse.com
---
src/util/virhostdev.h | 2 +-
1 file changed, 1
Quoting Eric Blake (ebl...@redhat.com):
On 03/18/2014 03:59 PM, Serge Hallyn wrote:
Hi,
In order to migrate a VM from an older system with qemu-kvm to a newer
one with qemu, the newer qemu needs to be told to use the same vga
ram size as qemu-kvm used, 8M.
virsh domxml-from-native
77 matches
Mail list logo
