Hi Eric,
On Fri, 2014-03-28 at 14:07 -0600, Eric Blake wrote:
On 03/28/2014 10:32 AM, Cédric Bosdonnat wrote:
From: Cédric Bosdonnat cedric.bosdon...@free.fr
pm-is-supported is the only thing needed in pm-utils, better get rid of
it since systemd is heavily used for libvirt.
---
On 03/27/14 23:48, Eric Blake wrote:
Another enum moved to util/, this time the fallout from renaming
is not quite as large.
* src/conf/domain_conf.h (virDomainDiskProtocol): Move...
* src/util/virstoragefile.h (virStorageNetProtocol): ...and
rename.
* src/conf/domain_conf.c: Update
On 03/28/14 04:38, Eric Blake wrote:
Encryption keys can be associated with each source file in a
backing chain; as such, this file belongs more in util/ where
it can be used by virstoragefile.h.
* src/conf/storage_encryption_conf.h: Rename...
* src/util/virstorageencryption.h: ...to this.
On 03/28/14 05:35, Eric Blake wrote:
Another struct being moved to util. This one doesn't have
as much use yet, thankfully.
* src/conf/domain_conf.h (virDomainDiskSourcePoolMode)
(virDomainDiskSourcePoolDef): Move...
* src/util/virstoragefile.h (virStorageSourcePoolMode)
On 03/28/14 16:01, Eric Blake wrote:
This one is a relatively easy move. We don't ever convert the
enum to or from strings (it is inferred from other elements in
the xml, rather than directly represented).
* src/conf/domain_conf.h (virDomainDiskSecretType): Move...
*
Signed-off-by: Hongwei Bi hwbi2...@gmail.com
---
src/util/vircgroup.c |1 -
1 file changed, 1 deletion(-)
diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c
index a0904d6..b881c8c 100644
--- a/src/util/vircgroup.c
+++ b/src/util/vircgroup.c
@@ -1148,7 +1148,6 @@
On 03/28/14 23:10, Eric Blake wrote:
With this patch, all information related to a host resource in
a storage file backing chain now lives in util/virstoragefile.h.
The next step will be to consolidate various places that have
been tracking backing chain details to all use a common struct.
On 03/29/14 21:46, Eric Blake wrote:
The code in virstoragefile.c is getting more complex as I
consolidate backing chain handling code. But for the setuid
virt-login-shell, we don't need to crawl backing chains. It's
easier to audit things for setuid security if there are fewer
files
On 03/29/14 21:56, Eric Blake wrote:
The only remaining reason that virt-login-shell was trying to
link against virstoragefile was because of a call to
virStorageFileFormatTypeToString when spawning a qemu-nbd
process - but setuid processes shouldn't be spawning qemu-nbd.
*
On 03/29/14 22:05, Eric Blake wrote:
Move some functions out of domain_conf for use in the next
patch where snapshot starts to directly use structs in
virstoragefile.
* src/conf/domain_conf.c (virDomainDiskDefFree)
(virDomainDiskSourcePoolDefParse): Adjust callers.
On 03/29/14 23:20, Eric Blake wrote:
Now that we have a common struct, it's time to start using it!
Since external snapshots make a longer backing chain, it is
only natural to use the same struct for the file created by
the snapshot as what we use for domain disks.
*
On 03/31/2014 02:42 AM, Cole Robinson wrote:
VolOpen notifies the user of a potentially non-fatal failure by
returning -2 and logging a VIR_WARN or VIR_INFO. Unfortunately most
callers treat -2 as fatal but don't actually report any message with
the error APIs.
Change VolOpen to always
On Fri, Mar 28, 2014 at 09:12:42PM +0100, Guido Günther wrote:
Hi Daniel,
On Fri, Mar 28, 2014 at 02:48:41PM +, Daniel P. Berrange wrote:
On Fri, Mar 28, 2014 at 03:16:37PM +0100, Guido Günther wrote:
On Fri, Mar 28, 2014 at 12:26:26PM +, Daniel P. Berrange wrote:
A bunch of
On Fri, Mar 28, 2014 at 02:07:36PM -0600, Eric Blake wrote:
On 03/28/2014 10:32 AM, Cédric Bosdonnat wrote:
From: Cédric Bosdonnat cedric.bosdon...@free.fr
pm-is-supported is the only thing needed in pm-utils, better get rid of
it since systemd is heavily used for libvirt.
---
On 03/30/14 05:37, Eric Blake wrote:
Some preparatory work before consolidating storage volume
structs with the rest of virstoragefile. Making these
changes allows a volume target to be much closer to the
virStorageSource struct.
While I don't think that the refactor of the target is a good
On 03/30/14 05:37, Eric Blake wrote:
Another step towards unification of structures. While we might
not expose everything in XML via domain disk as we do for
storage volume pointer, both places want to deal with (at least
part of) the backing chain; therefore, moving towards a single
struct
On 03/30/14 05:38, Eric Blake wrote:
A fairly smooth transition. And now that domain disks and
storage volumes share a common struct, it opens the doors for
a future patch to expose more details in the XML for both
objects.
* src/conf/storage_conf.h (_virStorageVolTarget): Delete.
On 03/27/14 23:08, Eric Blake wrote:
A continuation of the migration of disk details to virstoragefile.
This patch moves a single enum, but converting the name has quite
a bit of fallout.
* src/conf/domain_conf.h (virDomainDiskType): Move...
* src/util/virstoragefile.h (virStorageType):
- Move all capabilities functions to separate file
- Add initCPU
---
src/Makefile.am| 2 +
src/bhyve/bhyve_capabilities.c | 105 +
src/bhyve/bhyve_capabilities.h | 30
src/bhyve/bhyve_driver.c | 56
Implement support for connectCompareCPU.
---
src/bhyve/bhyve_driver.c | 31 +++
1 file changed, 31 insertions(+)
diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c
index ef9192a..f6973af 100644
--- a/src/bhyve/bhyve_driver.c
+++
Add following changes:
- support for connectBaselineCPU (required by OpenStack)
- move capabilites functions to separate file + API change
- implement connectCompareCPU
Wojciech Macek (3):
bhyve: support for connectBaselineCPU
bhyve: create capabilities submodule
bhyve: connectCompareCPU
Implement bhyveConnectBaselineCPU to support OpenStack/Nova
---
src/bhyve/bhyve_driver.c | 20
1 file changed, 20 insertions(+)
diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c
index 7a12d69..3321a79 100644
--- a/src/bhyve/bhyve_driver.c
+++
On 30.03.2014 14:53, Roman Bogorodskiy wrote:
On failures, virBhyveProcessStart() does not cleanup network
interfaces that could be created by virBhyveProcessBuildBhyveCmd(),
which results in a leaked tap device.
To fix that, extract network cleanup code to bhyveNetCleanup()
and use it in
On 03/28/14 23:07, Eric Blake wrote:
On 03/28/2014 04:01 PM, Peter Krempa wrote:
The source elements need to be indented from sources elements.
---
src/conf/storage_conf.c | 2 ++
1 file changed, 2 insertions(+)
ACK; safe for 1.2.3
Pushed; Thanks.
Peter
signature.asc
Description:
On 03/28/14 23:08, Eric Blake wrote:
On 03/28/2014 04:01 PM, Peter Krempa wrote:
The libgfapi function glfs_fini doesn't tolerate NULL pointers. Add a
check on the error paths as it's possible to crash libvirtd if the
gluster volume can't be initialized.
---
On 03/28/14 23:09, Eric Blake wrote:
On 03/28/2014 04:01 PM, Peter Krempa wrote:
When virStorageFileGetMetadata is called with NULL path argument, the
invalid pointer boils down through the recursive worker and is caught by
virHashAddEntry which is thankfully resistant to NULL arguments. As it
On 03/28/14 12:38, shyu wrote:
Fix bug https://bugzilla.redhat.com/show_bug.cgi?id=1080859 about
snapshot type in man page. Snapshot type should be no, internal, or
external
---
tools/virsh.pod | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
ACK, I've updated the patch to your full
On 27.03.2014 16:32, Brian Rak wrote:
The number of parameters in new_params is not guaranteed to be the same as the
number of parameters in params. Use the correct count when freeing new_params
to avoid crashes
---
libvirt-override.c | 24
1 files changed, 12
According to our documentation the key value has the following
meaning: Providing an identifier for the volume which identifies a
single volume. The currently used keys for gluster volumes consist of
the gluster volume name and file path. This can't be considered unique
as a different storage
On 03/31/2014 03:06 AM, Ján Tomko wrote:
On 03/31/2014 02:42 AM, Cole Robinson wrote:
VolOpen notifies the user of a potentially non-fatal failure by
returning -2 and logging a VIR_WARN or VIR_INFO. Unfortunately most
callers treat -2 as fatal but don't actually report any message with
the
On 31.03.2014 09:47, Hongwei Bi wrote:
Signed-off-by: Hongwei Bi hwbi2...@gmail.com
---
src/util/vircgroup.c |1 -
1 file changed, 1 deletion(-)
diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c
index a0904d6..b881c8c 100644
--- a/src/util/vircgroup.c
+++ b/src/util/vircgroup.c
@@
Hi All,
I am new to QEMU/libvirt
I was starting to learn the libvirt code,I was browsing the code how
the guest network bandwidth to be set like we mention inbound outbound
tags in the xml,but where in code exactly these values set to the guest
interface.
I browsed the code a lot could not
'virsh help event' included a summary line event - (null)
due to a misnamed info field.
* tools/virsh-domain.c (info_event): Use correct name.
* tools/virsh-network.c (info_network_event): Likewise.
Signed-off-by: Eric Blake ebl...@redhat.com
---
Deserves to be in 1.2.3
tools/virsh-domain.c
Michal Privoznik wrote:
On 30.03.2014 14:53, Roman Bogorodskiy wrote:
On failures, virBhyveProcessStart() does not cleanup network
interfaces that could be created by virBhyveProcessBuildBhyveCmd(),
which results in a leaked tap device.
To fix that, extract network cleanup code to
Eric Blake wrote:
'virsh help event' included a summary line event - (null)
due to a misnamed info field.
* tools/virsh-domain.c (info_event): Use correct name.
* tools/virsh-network.c (info_network_event): Likewise.
Signed-off-by: Eric Blake ebl...@redhat.com
---
Deserves to be in
On Mon, Mar 31, 2014 at 07:06:20 -0600, Eric Blake wrote:
'virsh help event' included a summary line event - (null)
due to a misnamed info field.
* tools/virsh-domain.c (info_event): Use correct name.
* tools/virsh-network.c (info_network_event): Likewise.
Signed-off-by: Eric Blake
On 30.03.2014 21:03, Matthias Bolte wrote:
This implementation uses the https://esx-server/screen?id=id way to get
a screenshot of a running domain. Compared to the CreateScreenshot_Task
way this works since ESX 2.5 while CreateScreenshot_Task was added in
version 4.0.
The newly added libcurl
On 30.03.2014 21:03, Matthias Bolte wrote:
This allows to implement libvirt functions that use streams, such as
virDoaminScreenshot, without the need to store the downloaded data in
a temporary file first. The stream driver directly interacts with
libcurl to send and receive data.
The driver
On Mon, Mar 31, 2014 at 03:46:43PM +0200, Michal Privoznik wrote:
On 30.03.2014 21:03, Matthias Bolte wrote:
This allows to implement libvirt functions that use streams, such as
virDoaminScreenshot, without the need to store the downloaded data in
a temporary file first. The stream driver
On 23.03.2014 10:16, Roman Bogorodskiy wrote:
From: David Shane Holden dpej...@yahoo.com
Signed-off-by: Roman Bogorodskiy bogorods...@gmail.com
---
src/bhyve/bhyve_driver.c | 135 ++-
src/bhyve/bhyve_utils.h | 5 ++
2 files changed, 139
On 30.03.2014 14:46, Pradeep Kiruvale wrote:
Hi All,
I am new to QEMU/libvirt
I was starting to learn the libvirt code,I was browsing the code how
the guest network bandwidth to be set like we mention inbound outbound
tags in the xml,but where in code exactly these values set to the
On 03/28/2014 04:07 PM, Eric Blake wrote:
On 03/28/2014 10:32 AM, Cédric Bosdonnat wrote:
From: Cédric Bosdonnat cedric.bosdon...@free.fr
pm-is-supported is the only thing needed in pm-utils, better get rid of
it since systemd is heavily used for libvirt.
---
src/util/virnodesuspend.c | 34
On 03/31/2014 07:19 AM, Jiri Denemark wrote:
On Mon, Mar 31, 2014 at 07:06:20 -0600, Eric Blake wrote:
'virsh help event' included a summary line event - (null)
due to a misnamed info field.
* tools/virsh-domain.c (info_event): Use correct name.
* tools/virsh-network.c (info_network_event):
On 03/31/2014 06:18 AM, Peter Krempa wrote:
According to our documentation the key value has the following
meaning: Providing an identifier for the volume which identifies a
single volume. The currently used keys for gluster volumes consist of
the gluster volume name and file path. This can't
Hi Michal,
Thanks for the response.
Regards,
Pradeep
On 31 March 2014 16:18, Michal Privoznik mpriv...@redhat.com wrote:
On 30.03.2014 14:46, Pradeep Kiruvale wrote:
Hi All,
I am new to QEMU/libvirt
I was starting to learn the libvirt code,I was browsing the code how
the guest
On 03/31/2014 02:56 AM, Peter Krempa wrote:
On 03/29/14 23:20, Eric Blake wrote:
Now that we have a common struct, it's time to start using it!
Since external snapshots make a longer backing chain, it is
only natural to use the same struct for the file created by
the snapshot as what we use
Hi everybody!
I sent an e-mail to Daniel asking about contributing to the libvirt
community for free.
So, I copied the e-mail to the libvirt mailing list as Daniel suggested me.
If anyone can help me I'd be pleased.
Thanks very much!
*--*
*Julio Cesar Faracco*
*University of São Paulo - Brazil*
On 03/31/2014 03:59 AM, Peter Krempa wrote:
On 03/30/14 05:38, Eric Blake wrote:
A fairly smooth transition. And now that domain disks and
storage volumes share a common struct, it opens the doors for
a future patch to expose more details in the XML for both
objects.
Let's examine how
On Friday, March 28, 2014 11:09:02 AM Mike Latimer wrote:
If ebtables binary is not found in /sbin, use /usr/sbin.
---
scripts/nwfilter/100-ping-still-working.t | 3 ++-
scripts/nwfilter/210-no-mac-spoofing.t| 3 ++-
scripts/nwfilter/220-no-ip-spoofing.t | 3 ++-
Michal Privoznik wrote:
On 23.03.2014 10:16, Roman Bogorodskiy wrote:
From: David Shane Holden dpej...@yahoo.com
Signed-off-by: Roman Bogorodskiy bogorods...@gmail.com
---
src/bhyve/bhyve_driver.c | 135
++-
src/bhyve/bhyve_utils.h
On Friday, March 28, 2014 11:28:19 AM Mike Latimer wrote:
Using a statically defined vnet0 may fail if multiple VMs are running on the
test machine. Switch to mac address, but replace '00' with '0' to match the
output of ebtables.
---
scripts/nwfilter/100-ping-still-working.t | 4 ++--
1
On Friday, March 28, 2014 12:26:31 PM Daniel P. Berrange wrote:
Change tests which need a full OS image over to use the new
virtbuilder images instead of provisioning from a kickstart
file. This should make them much more reliable to run.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
On Mon, Mar 31, 2014 at 10:44:22AM -0600, Mike Latimer wrote:
On Friday, March 28, 2014 12:26:31 PM Daniel P. Berrange wrote:
Change tests which need a full OS image over to use the new
virtbuilder images instead of provisioning from a kickstart
file. This should make them much more
On 03/27/2014 10:55 AM, Stefan Bader wrote:
Here several changes which improve the handling of Xen for me:
Thanks for the improvements Stefan. I'm currently on bereavement leave and will
look at these patches when returning, unless someone beats me to it.
Regards,
Jim
*
On Fri, Mar 28, 2014 at 11:09:02AM -0600, Mike Latimer wrote:
If ebtables binary is not found in /sbin, use /usr/sbin.
---
scripts/nwfilter/100-ping-still-working.t | 3 ++-
scripts/nwfilter/210-no-mac-spoofing.t| 3 ++-
scripts/nwfilter/220-no-ip-spoofing.t | 3 ++-
On Fri, Mar 28, 2014 at 12:26:26PM +, Daniel P. Berrange wrote:
A bunch of tests currently attempt to kickstart a full Fedora
OS image install. Everytime I try to update this kickstart to
a new version of Fedora it causes no end of pain. Switch the
tests over to use Richard Jones'
Now that we have a dedicated type for representing a disk source,
we might as well parse and format directly into that type instead
of piecemeal into pointers to members of the type.
* src/conf/domain_conf.h (virDomainDiskSourceDefFormatInternal)
(virDomainDiskSourceDefParse): Rename...
On 03/31/2014 12:09 PM, Eric Blake wrote:
Now that we have a dedicated type for representing a disk source,
we might as well parse and format directly into that type instead
of piecemeal into pointers to members of the type.
Aargh; hit send too soon. I'm still tracking down why this patch
And drop the original UpdateVolInfo. Makes it a bit easier to follow
the function usage.
And change the int parameter to an explicit bool.
---
src/storage/storage_backend.c | 13 +++--
src/storage/storage_backend.h | 6 ++
src/storage/storage_backend_disk.c| 3
Remove the original VolOpen implementation, which is now only used in
one spot.
---
src/storage/storage_backend.c | 14 +++---
src/storage/storage_backend.h | 8 ++--
src/storage/storage_backend_fs.c | 2 +-
src/storage/storage_backend_logical.c | 4 +++-
4
On 03/31/2014 12:50 PM, Cole Robinson wrote:
And drop the original UpdateVolInfo. Makes it a bit easier to follow
the function usage.
And change the int parameter to an explicit bool.
---
src/storage/storage_backend.c | 13 +++--
src/storage/storage_backend.h | 6
VolOpen notifies the user of a potentially non-fatal failure by
returning -2 and logging a VIR_WARN or VIR_INFO. Unfortunately most
callers treat -2 as fatal but don't actually report any message with
the error APIs.
Change VolOpen to report an error if the VOL_OPEN_ERROR flag is passed.
The ony
On 03/31/2014 12:13 PM, Eric Blake wrote:
On 03/31/2014 12:09 PM, Eric Blake wrote:
Now that we have a dedicated type for representing a disk source,
we might as well parse and format directly into that type instead
of piecemeal into pointers to members of the type.
Aargh; hit send too
---
src/storage/storage_backend.c | 175 ++
src/storage/storage_backend.h | 4 +-
src/storage/storage_backend_disk.c| 2 +-
src/storage/storage_backend_fs.c | 4 +-
src/storage/storage_backend_logical.c | 2 +-
In https://bugzilla.redhat.com/show_bug.cgi?id=1080613 , something is
causing StorageVolGetXML to fail, but it's not raising any error message.
Code inspection found that most users of VolOpen are susceptible to error
reporting issues.
The first 3 patches are some code reorganization and cleanups
On 03/31/2014 05:06 AM, Ján Tomko wrote:
On 03/31/2014 02:42 AM, Cole Robinson wrote:
VolOpen notifies the user of a potentially non-fatal failure by
returning -2 and logging a VIR_WARN or VIR_INFO. Unfortunately most
callers treat -2 as fatal but don't actually report any message with
the
On Mon, Mar 31, 2014 at 02:50:48PM -0400, Cole Robinson wrote:
diff --git a/src/storage/storage_backend_fs.c
b/src/storage/storage_backend_fs.c
index e02d17f..4d44897 100644
--- a/src/storage/storage_backend_fs.c
+++ b/src/storage/storage_backend_fs.c
@@ -904,8 +907,9 @@
On 03/31/2014 12:50 PM, Cole Robinson wrote:
---
Commit message is a bit sparse - it says what but not why. But looking
at the patch, it looks like the goal was to refactor code that copied
and pasted block format lookup after getting volinfo to instead have
volinfo get everything up front.
On 03/31/2014 03:08 PM, Daniel P. Berrange wrote:
On Mon, Mar 31, 2014 at 02:50:48PM -0400, Cole Robinson wrote:
diff --git a/src/storage/storage_backend_fs.c
b/src/storage/storage_backend_fs.c
index e02d17f..4d44897 100644
--- a/src/storage/storage_backend_fs.c
+++
On 03/31/2014 12:50 PM, Cole Robinson wrote:
Remove the original VolOpen implementation, which is now only used in
one spot.
---
src/storage/storage_backend.c | 14 +++---
src/storage/storage_backend.h | 8 ++--
src/storage/storage_backend_fs.c | 2 +-
On 03/31/2014 12:50 PM, Cole Robinson wrote:
VolOpen notifies the user of a potentially non-fatal failure by
returning -2 and logging a VIR_WARN or VIR_INFO. Unfortunately most
callers treat -2 as fatal but don't actually report any message with
the error APIs.
Change VolOpen to report an
On 03/30/2014 03:35 PM, Nehal J Wani wrote:
While running virdbustest, it was found that valgrind pointed out
the following memory leaks:
==9996== 17 (8 direct, 9 indirect) bytes in 1 blocks are definitely lost in
loss record 9 of 36
==9996==at 0x4A069EE: malloc
On 03/31/2014 10:00 AM, Julio Faracco wrote:
Hi everybody!
I sent an e-mail to Daniel asking about contributing to the libvirt
community for free.
So, I copied the e-mail to the libvirt mailing list as Daniel suggested me.
If anyone can help me I'd be pleased.
Welcome to the community.
On Sun, Mar 16, 2014 at 1:28 PM, Nehal J Wani nehaljw.k...@gmail.com wrote:
I followed the following steps to build a clean development version of
libvirt from source. Can't seem to understand what is wrong. (Entire
buildLog has been attached):
➜ /tmp cat /etc/issue
CentOS release 6.5
On 03/31/2014 03:20 PM, Eric Blake wrote:
On 03/31/2014 12:50 PM, Cole Robinson wrote:
Remove the original VolOpen implementation, which is now only used in
one spot.
---
src/storage/storage_backend.c | 14 +++---
src/storage/storage_backend.h | 8 ++--
75 matches
Mail list logo
