Wojciech Macek wrote:
> When domain is not persistent, it should be forgotten upon destroying.
> ---
> src/bhyve/bhyve_driver.c | 10 --
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c
> index 7187202..23e7112 10064
On 04/09/2014 08:50 AM, Jean-Baptiste Rouault wrote:
> Introduced in commit d1e55de3.
> virstoragetest.c: In function ‘testStorageChain’:
> virstoragetest.c:249:10: warning: declaration of ‘abs’ shadows a global
> declaration [-Wshadow]
> ---
> tests/virstoragetest.c | 4 ++--
> 1 file changed, 2
Li Zhang writes:
> From: Li Zhang
>
> PPC64 prefers to set pci-ohci controller as default USB controller.
> Currently, libvirt is using legacy USB controller as default. There
> are problems with VGA which can't work correctly with USB Keyboard and
> USB Mouse.
That requires would require a re
On 2014年04月09日 15:54, Nikunj A Dadhania wrote:
Li Zhang writes:
From: Li Zhang
PPC64 prefers to set pci-ohci controller as default USB controller.
Currently, libvirt is using legacy USB controller as default. There
are problems with VGA which can't work correctly with USB Keyboard and
USB M
From: Li Zhang
PPC64 prefers to set pci-ohci controller as default USB controller.
Currently, libvirt is using legacy USB controller as default. There
are problems with VGA which can't work correctly with USB Keyboard and
USB Mouse.
While providing -nodefaults, ppc64 should be specifying the usb
On Wed, Apr 09, 2014 at 07:52:12AM +0200, Wojciech Macek wrote:
> Implement bhyveDomainCreteXML function.
> ---
> src/bhyve/bhyve_driver.c | 70
>
> 1 file changed, 70 insertions(+)
>
> diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_drive
On 04/09/14 06:35, Eric Blake wrote:
> The previous patch started a separation of error messages
> reported against the user-specified name, vs. tracking the
> canonical path that was actually opened. This patch extends
> that notion, by hoisting directory detection up front, passing
> the canonic
On 09.04.2014 04:03, Li Zhang wrote:
From: Li Zhang
For QEMU2.0 forward version, it supports PCI multiBUS.
Currently, libvirt still disables it which causes an error
"Bus 'pci' not found".
Signed-off-by: Li Zhang
---
src/qemu/qemu_capabilities.c | 3 +++
1 file changed, 3 insertions(+)
di
On 04/09/14 06:35, Eric Blake wrote:
> Right now, we are allocating virStorageFileMetadata near the bottom
> of the callchain, only after we have identified that we are visiting
> a file (and not a network resource). I'm hoping to eventually
> support parsing the backing chain from XML, where the
On 04/09/14 06:35, Eric Blake wrote:
> A later patch will be adding some new fields to
> virStorageFileMetadata; to minimize confusion, renaming the
> test fields now will make it more obvious which fields are
> being tested later.
>
> * tests/virstoragetest.c (_testFileData): Alter names.
> (test
Since commit d69415d4, vmware version is parsed from both stdout and
stderr. This patch makes version parsing work even if there is garbage
(libvirt debug messages for example) in the command output.
Add test data for this case.
---
src/vmware/vmware_conf.c | 10
On 04/08/2014 09:44 PM, Eric Blake wrote:
>
> Yeah, the EnsureAcl has to be in the function matching the public API,
> but the bulk of the work can indeed be in the internal helper function.
>
>> @@ -1634,7 +1657,6 @@ storageVolDelete(virStorageVolPtr obj,
>> return ret;
>> }
>>
>> -
>
Daniel P. Berrange wrote:
> On Wed, Apr 09, 2014 at 07:52:12AM +0200, Wojciech Macek wrote:
> > Implement bhyveDomainCreteXML function.
> > ---
> > src/bhyve/bhyve_driver.c | 70
> >
> > 1 file changed, 70 insertions(+)
> >
> > diff --git a/src
On Wed, Apr 09, 2014 at 03:11:48PM +0400, Roman Bogorodskiy wrote:
> Daniel P. Berrange wrote:
>
> > On Wed, Apr 09, 2014 at 07:52:12AM +0200, Wojciech Macek wrote:
> > > Implement bhyveDomainCreteXML function.
> > > ---
> > > src/bhyve/bhyve_driver.c | 70
> > > +++
On 04/09/14 06:35, Eric Blake wrote:
> The current use of virStorageFileMetadata is awkward; to learn
> some of the information about a child node, you have to read
> fields in the parent node. This does not lend itself well to
> modifying backing chains (whether inserting a new node in the
> chai
On 04/09/14 06:35, Eric Blake wrote:
> The testsuite is absolutely essential to feeling comfortable
> about swapping the backing chain structure over to a new format.
> This patch tests the path settings, and demonstrates that the
> correct short name is being passed to the child.
>
> * tests/virs
On 04/09/14 06:35, Eric Blake wrote:
> Validate that all the new fields are getting set to desired values.
>
> * tests/virstoragetest.c (_testFileData, testStorageChain): Check
> for more fields.
> (mymain): Populate additional fields.
>
> Signed-off-by: Eric Blake
> ---
> tests/virstoragetest.
On 04/09/14 03:40, Eric Blake wrote:
> On 04/08/2014 09:55 AM, Peter Krempa wrote:
>> Refactor the function to avoid multiple wrappers splitting identical
>> fields from the now common metadata struct.
>>
>> The refactor is done by folding in the wrapper used for disk sources
>> which allows us to
The function isn't used in any other file. Convert it to static.
---
Notes:
Pushed as trivial.
src/qemu/qemu_command.c | 2 +-
src/qemu/qemu_command.h | 7 ---
2 files changed, 1 insertion(+), 8 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 3942a23..8
On 04/09/2014 06:11 AM, Peter Krempa wrote:
> On 04/09/14 06:35, Eric Blake wrote:
>> The testsuite is absolutely essential to feeling comfortable
>> about swapping the backing chain structure over to a new format.
>> This patch tests the path settings, and demonstrates that the
>> correct short na
[adding qemu]
On 04/08/2014 11:36 PM, Li Zhang wrote:
> On 2014年04月09日 11:20, Eric Blake wrote:
>> On 04/08/2014 08:03 PM, Li Zhang wrote:
>>> From: Li Zhang
>>>
>>> For QEMU2.0 forward version, it supports PCI multiBUS.
>>> Currently, libvirt still disables it which causes an error
>>> "Bus 'pci
QEMU commit 5e2ac51 added a boolean '-msg timestamp=[on|off]'
option, which can enable timestamps on errors:
$ qemu-system-x86_64 -msg timestamp=on zghhdorf
2014-04-09T13:25:46.779484Z qemu-system-x86_64: -msg timestamp=on: could
not open disk image zghhdorf: Could not open 'zghhdorf': No such file
On 04/08/2014 11:58 AM, Michal Privoznik wrote:
> On 04.04.2014 10:25, Ján Tomko wrote:
>> This series removes qemuDomainGetPercpuStats in favor of
>> virCgroupGetPercpuStats, fixes incorrect startcpu
>> boundaries check and cleans the code up.
>>
>> Ján Tomko (6):
>>Don't require domain obj in
On 04/04/2014 09:18 AM, liyang wrote:
> From: Li Yang
>
> The original comment of vshCmdInfo:
> "name" - command name
>
> Actually it's 'help' and the short description
> of command, not the command name.
>
> Signed-off-by: Li Yang
> ---
> tools/virsh.h |2 +-
> 1 files changed, 1 inserti
On Mon, Mar 17, 2014 at 09:39:54AM +, Daniel P. Berrange wrote:
> On Fri, Mar 14, 2014 at 06:52:19PM -0300, Marcelo Tosatti wrote:
> > On Tue, Feb 04, 2014 at 11:54:22AM -0500, Marcelo Tosatti wrote:
> > > On Tue, Feb 04, 2014 at 04:42:02PM +, Daniel P. Berrange wrote:
> > > > On Tue, Feb 0
My commit 897808e added a parameter to virCgroupGetPercpuStats,
but didn't change the stub for systems where cgroups are not supported.
---
Pushed as a build-breaker fix.
src/util/vircgroup.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/util/vircgroup.c b/src/util/vir
On Tue, Apr 08, 2014 at 03:06:13PM -0300, Marcelo Tosatti wrote:
> On Mon, Mar 17, 2014 at 09:39:54AM +, Daniel P. Berrange wrote:
> > We recently had a bunch more feature requests around huge page support
> > in libvirt, so I think it is preferrable not to merge this currently.
> > We need to
I forgot to 'git add' the test files.
---
.../qemuxml2argv-minimal-msg-timestamp.args| 6
.../qemuxml2argv-minimal-msg-timestamp.xml | 32 ++
2 files changed, 38 insertions(+)
create mode 100644
tests/qemuxml2argvdata/qemuxml2argv-minimal-msg-timestamp.
On Tue, Mar 25, 2014 at 1:53 PM, Nehal J Wani wrote:
> When libvirtd is run from a build directory without being installed, it
> should not depend on files from a libvirt package installed in the
> system. Currently, APIs defined in src/ don't know whether libvirtd
> is being run from the build di
On Tue, Apr 01, 2014 at 09:28:18AM +, yangzy.f...@cn.fujitsu.com wrote:
>
> > -Original Message-
> > From: libvir-list-boun...@redhat.com
> > [mailto:libvir-list-boun...@redhat.com] On Behalf Of Daniel P. Berrange
> > Sent: Saturday, March 22, 2014 12:37 AM
> > To: Yang, Zhiyong/杨 志勇
>
On Tue, Apr 8, 2014 at 8:18 PM, Daniel P. Berrange wrote:
> In debugging a crash on OOM, I thought that the virInsert APIs
> might be at fault, but couldn't isolate them as a cause. While
> the viralloc APIs are used in many test suites, this is as a
> side-effect, they are not directly tested :-)
Commit id '18642d10' caused a virt-test regression for NFS backend
storage error path checks when running the command:
'virsh find-storage-pool-sources-as netfs Unknown '
when the host did not have Gluster installed. Prior to the commit,
the test would fail with the error:
error: intern
The 202-numa-set-parameters.t test sets NUMA_NODESET using AFFECT_LIVE on a
running domain, destroys and starts the domain, then verifies the NUMA_NODESET
setting. As AFFECT_LIVE does not write the setting to the domain xml file,
the new nodeset setting is lost when the domain is destroyed and the
So far, my work has been merely preserving the status quo of
backing file analysis. But this patch starts to tread in the
territory of making the backing chain code more powerful - we
will eventually support network storage containing non-raw
formats. Here, we expose metadata information about a
I'm almost to the point where virStorageSource can track everything
that virStorageFileMetadata was used for, so that we can use one
struct instead of two. But while working on this today, I noticed
that virStorageFileChainLookup() does not have any unit tests, so
I'll be writing those before remo
Deciding if a user string represents a local file instead of a
network path is an operation worth exposing directly, particularly
since the next patch will be removing a redundant variable that
was caching the information.
* src/util/virstoragefile.h (virStorageIsFile): New declaration.
* src/util
A couple pieces of virStorageFileMetadata are used only while
collecting information about the chain, and don't need to
live permanently in the struct. This patch refactors external
callers to collect the information separately, so that the
next patch can remove the fields.
* src/util/virstoragef
Finally starting to prune away some of the old fields that have
been made redundant by the new fields, on my way towards directly
reusing virStorageSource.
* src/util/virstoragefile.h (_virStorageFileMetadata): Drop
field.
* src/util/virstoragefile.c (virStorageFileGetMetadataInternal)
(virStorage
Drop another redundant field from virStorageFileMetadata.
* src/util/virstoragefile.h (_virStorageFileMetadata): Drop
field.
* src/util/virstoragefile.c
(virStorageFileGetMetadataFromFDInternal)
(virStorageFileGetMetadataFromFD)
(virStorageFileGetMetadataRecurse): Adjust callers.
* tests/virstorag
On 04/09/2014 09:41 PM, Eric Blake wrote:
> I'm almost to the point where virStorageSource can track everything
> that virStorageFileMetadata was used for, so that we can use one
> struct instead of two. But while working on this today, I noticed
> that virStorageFileChainLookup() does not have an
On 2014年04月09日 17:25, Michal Privoznik wrote:
On 09.04.2014 04:03, Li Zhang wrote:
From: Li Zhang
For QEMU2.0 forward version, it supports PCI multiBUS.
Currently, libvirt still disables it which causes an error
"Bus 'pci' not found".
Signed-off-by: Li Zhang
---
src/qemu/qemu_capabilities.c
On 10.04.2014 07:26, Li Zhang wrote:
On 2014年04月09日 17:25, Michal Privoznik wrote:
On 09.04.2014 04:03, Li Zhang wrote:
From: Li Zhang
For QEMU2.0 forward version, it supports PCI multiBUS.
Currently, libvirt still disables it which causes an error
"Bus 'pci' not found".
Signed-off-by: Li Zh
42 matches
Mail list logo
