Re: [libvirt] [PATCH 2/2] add default migrate uri in definition file

2014-04-15 Thread chen.fan.f...@cn.fujitsu.com
Hi Daniel, On Tue, 2014-04-15 at 12:04 +0100, Daniel P. Berrange wrote: > On Tue, Apr 15, 2014 at 06:31:09PM +0800, Chen Fan wrote: > > Current virsh migrate command require specfying migration URI with > > command option. > > > > Here is current step. > > 1) If user specifies --migrateuri on vi

Re: [libvirt] libvirt Hyper-v 2012 r2 fix

2014-04-15 Thread vikhyath reddy
Update, I tried adding root\virtualization\*v2 *to the namespace in libvirt source code for hyperv. I ran some tests and it seems to work. I get the same functionality (supported vs non-supported drivers) as hyper-v 2008. Do you guys want me to submit the patch? If yes, what all do I need to upda

[libvirt] libvirt Hyper-v 2012 r2 fix

2014-04-15 Thread vikhyath reddy
Hello everyone, Thanks for libvirt. I did see on the libvirt page that hyper-v 2008 is supported (which it does). So I tried running it on Hyper-v 2012 r2 but virsh fails to connect by an error that says *"error: internal error: SOAP fault during enumeration: code 's:Sender', subcode 'n:CannotPro

[libvirt] [PATCH] Shorten the udevadm settle timeout for refresh/start pool cases

2014-04-15 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=789766 This patch addresses a possible misperception that libvirt is hung during pool startup/refresh as well as virt-manager startup as it needs to start/refresh storage pools found. The problem is that the 'udevadm settle' command will wait for a defa

Re: [libvirt] [PATCH 15/26] Convert ebtables code over to use firewall APIs

2014-04-15 Thread Stefan Berger
On 04/08/2014 11:38 AM, Daniel P. Berrange wrote: Convert the virebtables.{c,h} files to use the new virFirewall APIs for changing ebtables rules. Signed-off-by: Daniel P. Berrange /** * ebtablesContextNew: * @@ -216,12 +89,30 @@ ebtablesContextFree(ebtablesContext *ctx) int ebt

Re: [libvirt] [PATCH 14/26] Add test for converting network XML to iptables rules

2014-04-15 Thread Stefan Berger
On 04/08/2014 11:38 AM, Daniel P. Berrange wrote: Using the virCommand dry run capability, capture iptables rules created by various network XML documents. Signed-off-by: Daniel P. Berrange --- Great. I did not check the individual iptables rules whether they are correct for the XML. ACK -

Re: [libvirt] [PATCH 11/26] Introduce an object for managing firewall rulesets

2014-04-15 Thread Jeff E. Nelson
On Tue, Apr 15, 2014 at 05:15:02PM -0400, Stefan Berger wrote: > On 04/08/2014 11:38 AM, Daniel P. Berrange wrote: > >The network and nwfilter drivers both have a need to update > >firewall rules. The currently share no code for interacting > >with iptables / firewalld. The nwfilter driver is fairl

Re: [libvirt] [PATCH 13/26] Replace virNetworkObjPtr with virNetworkDefPtr in network platform APIs

2014-04-15 Thread Stefan Berger
On 04/08/2014 11:38 AM, Daniel P. Berrange wrote: The networkCheckRouteCollision, networkAddFirewallRules and networkRemoveFirewallRules APIs all take a virNetworkObjPtr instance, but only ever access the 'def' member. It thus simplifies testing if the APIs are changed to just take a virNetworkDe

Re: [libvirt] [PATCH 12/26] Convert bridge driver over to use new firewall APIs

2014-04-15 Thread Stefan Berger
On 04/08/2014 11:38 AM, Daniel P. Berrange wrote: Update the iptables methods so that instead of directly executing iptables commands, they populate rules in an instance of virFirewallPtr. The bridge driver can thus construct the ruleset and then invoke it in one operation having rollback han

Re: [libvirt] [PATCHv2 5/9] conf: split schema into more pieces

2014-04-15 Thread Jiri Denemark
On Mon, Apr 14, 2014 at 16:54:16 -0600, Eric Blake wrote: > Disk snapshots use a subset of sources (no directory or > pool support yet, and while domain disks support a startupPolicy, > it doesn't make sense for snapshots). This patch lets the two > RelaxNG grammars share a bit more code, as well

Re: [libvirt] [PATCH 11/26] Introduce an object for managing firewall rulesets

2014-04-15 Thread Stefan Berger
On 04/08/2014 11:38 AM, Daniel P. Berrange wrote: The network and nwfilter drivers both have a need to update firewall rules. The currently share no code for interacting with iptables / firewalld. The nwfilter driver is fairly tied to the concept of creating shell scripts to execute which makes i

Re: [libvirt] [PATCHv2 4/9] conf: set up for per-grammar overrides in schemas

2014-04-15 Thread Jiri Denemark
On Mon, Apr 14, 2014 at 16:54:15 -0600, Eric Blake wrote: > This patch is my first experience playing with nested grammars, > as documented in http://relaxng.org/tutorial-20011203.html#IDA3PZR. > I plan on doing more overrides in order to make the RelaxNG > grammar mirror the C code refactoring int

Re: [libvirt] beginner project idea: enum scrubbing [was: Fwd: Start contributing with Libvirt (Finding a mentor or helpful tips)]

2014-04-15 Thread Julio Faracco
Eric, I changed the enum structures to typedef structures. Specially the structures from util/ and conf/ dirs that have a big number of enum structures. To keep a stable release, I didn't change the attributes of the structs. Most of them still keep the old type: 'int type; /* enum virName */' I

Re: [libvirt] [PATCH 09/26] Remove two-stage construction of commands in nwfilter

2014-04-15 Thread Stefan Berger
On 04/08/2014 11:38 AM, Daniel P. Berrange wrote: The nwfilter ebiptables driver will build up commands to run in two phases. The first phase contains all of the command, except for the '-A' part. Instead it has a '%c' placeholder, along with a '%s' placeholder for a position arg. The second phas

Re: [libvirt] [PATCH 16/26] Convert nwfilter ebiptablesAllTeardown to virFirewall

2014-04-15 Thread Stefan Berger
On 04/08/2014 11:38 AM, Daniel P. Berrange wrote: Convert the nwfilter ebiptablesAllTeardown method to use the virFirewall object APIs instead of creating shell scripts using virBuffer APIs. This provides a performance improvement through allowing direct use of firewalld dbus APIs and will facili

Re: [libvirt] [PATCH 06/26] Add helper methods for determining what protocol layer is used

2014-04-15 Thread Stefan Berger
On 04/15/2014 10:30 AM, Daniel P. Berrange wrote: On Tue, Apr 15, 2014 at 10:06:22AM -0400, Stefan Berger wrote: On 04/08/2014 11:37 AM, Daniel P. Berrange wrote: +bool virNWFilterRuleIsProtocolEthernet(virNWFilterRuleDefPtr rule) +{ +if (rule->prtclType >= VIR_NWFILTER_RULE_PROTOCOL_NONE &

Re: [libvirt] why doesn't libvirt let qemu autostart live-migrated VMs?

2014-04-15 Thread Daniel P. Berrange
On Tue, Apr 15, 2014 at 09:09:55AM -0600, Chris Friesen wrote: > On 04/15/2014 02:28 AM, Daniel P. Berrange wrote: > >On Mon, Apr 14, 2014 at 05:50:07PM -0600, Chris Friesen wrote: > >>Hi, > >> > >>I've been digging through the libvirt code and something that struck > >>me was that it appears that

Re: [libvirt] [PATCH 00/26] Rewrite firewall code to use formal API

2014-04-15 Thread Stefan Berger
On 04/15/2014 10:06 AM, Daniel P. Berrange wrote: On Tue, Apr 15, 2014 at 10:04:01AM -0400, Stefan Berger wrote: On 04/15/2014 07:42 AM, Daniel P. Berrange wrote: On Tue, Apr 15, 2014 at 07:40:41AM -0400, Stefan Berger wrote: On 04/15/2014 04:29 AM, Daniel P. Berrange wrote: On Mon, Apr 14, 2

Re: [libvirt] [PATCH 3/5] network: read status from old location and move to new

2014-04-15 Thread John Ferlan
On 04/15/2014 10:31 AM, Laine Stump wrote: > On 04/15/2014 03:27 PM, John Ferlan wrote: >> >> On 04/10/2014 09:19 AM, Laine Stump wrote: >>> This eliminates problems with upgrading from older libvirt that stores >>> network status in /var/lib/libvirt/network to newer libvirt that >>> stores it in

Re: [libvirt] why doesn't libvirt let qemu autostart live-migrated VMs?

2014-04-15 Thread Chris Friesen
On 04/15/2014 02:28 AM, Daniel P. Berrange wrote: On Mon, Apr 14, 2014 at 05:50:07PM -0600, Chris Friesen wrote: Hi, I've been digging through the libvirt code and something that struck me was that it appears that when using qemu libvirt will migrate the instance with autostart disabled, then s

Re: [libvirt] [PATCH] nodeinfo: fix detection of physical memory on uclibc/musl libc

2014-04-15 Thread Natanael Copa
On Tue, 15 Apr 2014 12:30:47 +0100 "Daniel P. Berrange" wrote: > On Tue, Apr 15, 2014 at 01:26:27PM +0200, Natanael Copa wrote: > > On Tue, 15 Apr 2014 10:37:40 +0100 > > "Daniel P. Berrange" wrote: > > > > > On Tue, Apr 15, 2014 at 11:31:23AM +0200, Natanael Copa wrote: > > > > The gnulib's ph

Re: [libvirt] [PATCH 3/5] network: read status from old location and move to new

2014-04-15 Thread Daniel P. Berrange
On Tue, Apr 15, 2014 at 05:31:17PM +0300, Laine Stump wrote: > On 04/15/2014 03:27 PM, John Ferlan wrote: > > > > On 04/10/2014 09:19 AM, Laine Stump wrote: > >> This eliminates problems with upgrading from older libvirt that stores > >> network status in /var/lib/libvirt/network to newer libvirt t

Re: [libvirt] [PATCH 3/5] network: read status from old location and move to new

2014-04-15 Thread Laine Stump
On 04/15/2014 03:27 PM, John Ferlan wrote: > > On 04/10/2014 09:19 AM, Laine Stump wrote: >> This eliminates problems with upgrading from older libvirt that stores >> network status in /var/lib/libvirt/network to newer libvirt that >> stores it in /var/run/libvirt/network, by also reading any statu

Re: [libvirt] [PATCH 06/26] Add helper methods for determining what protocol layer is used

2014-04-15 Thread Daniel P. Berrange
On Tue, Apr 15, 2014 at 10:06:22AM -0400, Stefan Berger wrote: > On 04/08/2014 11:37 AM, Daniel P. Berrange wrote: > >+bool virNWFilterRuleIsProtocolEthernet(virNWFilterRuleDefPtr rule) > >+{ > >+if (rule->prtclType >= VIR_NWFILTER_RULE_PROTOCOL_NONE && > >+rule->prtclType <= VIR_NWFILT

Re: [libvirt] [PATCH 00/26] Rewrite firewall code to use formal API

2014-04-15 Thread Daniel P. Berrange
On Tue, Apr 15, 2014 at 10:04:01AM -0400, Stefan Berger wrote: > On 04/15/2014 07:42 AM, Daniel P. Berrange wrote: > >On Tue, Apr 15, 2014 at 07:40:41AM -0400, Stefan Berger wrote: > >>On 04/15/2014 04:29 AM, Daniel P. Berrange wrote: > >>>On Mon, Apr 14, 2014 at 04:47:50PM -0400, Stefan Berger wro

Re: [libvirt] [PATCH 06/26] Add helper methods for determining what protocol layer is used

2014-04-15 Thread Stefan Berger
On 04/08/2014 11:37 AM, Daniel P. Berrange wrote: +bool virNWFilterRuleIsProtocolEthernet(virNWFilterRuleDefPtr rule) +{ +if (rule->prtclType >= VIR_NWFILTER_RULE_PROTOCOL_NONE && +rule->prtclType <= VIR_NWFILTER_RULE_PROTOCOL_IPV6) +return true; +return false; +} I get

Re: [libvirt] [PATCH 00/26] Rewrite firewall code to use formal API

2014-04-15 Thread Stefan Berger
On 04/15/2014 07:42 AM, Daniel P. Berrange wrote: On Tue, Apr 15, 2014 at 07:40:41AM -0400, Stefan Berger wrote: On 04/15/2014 04:29 AM, Daniel P. Berrange wrote: On Mon, Apr 14, 2014 at 04:47:50PM -0400, Stefan Berger wrote: On 04/08/2014 11:37 AM, Daniel P. Berrange wrote: Currently we have

Re: [libvirt] [PATCH 2/5] network: change location of network state xml files

2014-04-15 Thread Laine Stump
On 04/15/2014 03:26 PM, John Ferlan wrote: > > On 04/10/2014 09:19 AM, Laine Stump wrote: >> For some reason these have been stored in /var/lib, although other >> drivers store their state files in /var/run. >> >> It's much nicer to store them in /var/run because they are >> automatically cleared o

[libvirt] [PATCH v2] storage: netfs: Handle backend errors

2014-04-15 Thread John Ferlan
Commit id '18642d10' caused a virt-test regression for NFS backend storage error path checks when running the command: 'virsh find-storage-pool-sources-as netfs Unknown ' when the host did not have Gluster installed. Prior to the commit, the test would fail with the error: error: intern

Re: [libvirt] [PATCH 5/5] network: centralize check for active network during interface attach

2014-04-15 Thread John Ferlan
On 04/10/2014 09:19 AM, Laine Stump wrote: > The check for a network being active during interface attach was being > done individually in several places (by both the lxc driver and the > qemu driver), but those places were too specific, leading to it *not* > being checked when allocating a conne

Re: [libvirt] [PATCH 4/5] network: set macvtap/hostdev networks active if their state file exists

2014-04-15 Thread John Ferlan
On 04/10/2014 09:19 AM, Laine Stump wrote: > libvirt attempts to determine at startup time which networks are > already active, and set their active flags. Previously it has done > this by assuming that all networks are inactive, then setting the flag > if the network has a bridge device associat

Re: [libvirt] [PATCH 3/5] network: read status from old location and move to new

2014-04-15 Thread John Ferlan
On 04/10/2014 09:19 AM, Laine Stump wrote: > This eliminates problems with upgrading from older libvirt that stores > network status in /var/lib/libvirt/network to newer libvirt that > stores it in /var/run/libvirt/network, by also reading any status > files from the old location, saving them to

Re: [libvirt] [PATCH 2/5] network: change location of network state xml files

2014-04-15 Thread John Ferlan
On 04/10/2014 09:19 AM, Laine Stump wrote: > For some reason these have been stored in /var/lib, although other > drivers store their state files in /var/run. > > It's much nicer to store them in /var/run because they are > automatically cleared out when the system reboots. This can be a > usefu

Re: [libvirt] [PATCH 1/5] network: create statedir during driver initialization

2014-04-15 Thread John Ferlan
On 04/10/2014 09:19 AM, Laine Stump wrote: > This directory should be created when the network driver is first > started up, not just when a dhcp daemon is run. This hasn't posed a > problem in the past, because the directory has always been > pre-existing. > --- > src/network/bridge_driver.c |

Re: [libvirt] [PATCHv2 2/9] conf: move storage formats to common RNG file

2014-04-15 Thread Jiri Denemark
On Mon, Apr 14, 2014 at 16:54:13 -0600, Eric Blake wrote: > We had incomplete RelaxNG support for storage formats listed > in virstoragefile.h: commit 027bf2e added 'vdi' but forgot > to update the and xml lists; the > list was also missing 'fat' and 'vhd'. Maintaining two lists > is a recipe f

Re: [libvirt] [PATCHv2 3/9] conf: restrict external snapshots to backing store formats

2014-04-15 Thread Jiri Denemark
On Mon, Apr 14, 2014 at 16:54:14 -0600, Eric Blake wrote: > Domain snapshots should only permit an external snapshot into > a storage format that permits a backing chain, since the new > snapshot file necessarily must be backed by the existing file. > The C code for the qemu driver is a little bit

Re: [libvirt] [PATCHv2 1/9] conf: better interleaving in schema

2014-04-15 Thread Jiri Denemark
On Mon, Apr 14, 2014 at 16:54:12 -0600, Eric Blake wrote: > In general, we try to make virt-xml-validate tolerant of input > elements in any order when possible. However, as written, the > RNG grammar did not permit unless there was an explicit > type= attribute (even though the C code manages ju

Re: [libvirt] [PATCH 00/26] Rewrite firewall code to use formal API

2014-04-15 Thread Daniel P. Berrange
On Tue, Apr 15, 2014 at 07:40:41AM -0400, Stefan Berger wrote: > On 04/15/2014 04:29 AM, Daniel P. Berrange wrote: > >On Mon, Apr 14, 2014 at 04:47:50PM -0400, Stefan Berger wrote: > >>On 04/08/2014 11:37 AM, Daniel P. Berrange wrote: > >>>Currently we have three places which interact with the fire

Re: [libvirt] [PATCH 00/26] Rewrite firewall code to use formal API

2014-04-15 Thread Stefan Berger
On 04/15/2014 04:29 AM, Daniel P. Berrange wrote: On Mon, Apr 14, 2014 at 04:47:50PM -0400, Stefan Berger wrote: On 04/08/2014 11:37 AM, Daniel P. Berrange wrote: Currently we have three places which interact with the firewall - util/virebtables - simple MAC filtering used by QEMU driver

Re: [libvirt] [PATCH] nodeinfo: fix detection of physical memory on uclibc/musl libc

2014-04-15 Thread Daniel P. Berrange
On Tue, Apr 15, 2014 at 01:26:27PM +0200, Natanael Copa wrote: > On Tue, 15 Apr 2014 10:37:40 +0100 > "Daniel P. Berrange" wrote: > > > On Tue, Apr 15, 2014 at 11:31:23AM +0200, Natanael Copa wrote: > > > The gnulib's physmem_total will as a fallback report 64MB as total > > > memory if sysconf(_

Re: [libvirt] [PATCH] nodeinfo: fix detection of physical memory on uclibc/musl libc

2014-04-15 Thread Natanael Copa
On Tue, 15 Apr 2014 10:37:40 +0100 "Daniel P. Berrange" wrote: > On Tue, Apr 15, 2014 at 11:31:23AM +0200, Natanael Copa wrote: > > The gnulib's physmem_total will as a fallback report 64MB as total > > memory if sysconf(_SC_PHYS_PAGES) is unimplemented on linux. This makes > > it impossible to d

Re: [libvirt] RFC: Exposing backing chains in XML

2014-04-15 Thread Daniel P. Berrange
On Sat, Apr 12, 2014 at 08:49:50PM -0600, Eric Blake wrote: > On 03/12/2014 02:21 PM, Eric Blake wrote: > > tl;dr: > > I am working on a series of patches to expose backing chain information > > in XML. Comments are welcome, to make sure my XML design is on > > the right track. > > > > > > > A

Re: [libvirt] [PATCH 2/2] add default migrate uri in definition file

2014-04-15 Thread Daniel P. Berrange
On Tue, Apr 15, 2014 at 06:31:09PM +0800, Chen Fan wrote: > Current virsh migrate command require specfying migration URI with > command option. > > Here is current step. > 1) If user specifies --migrateuri on virsh migrate command, then the command >transfers the data to specified host. > 2)

[libvirt] [PATCH 2/2] add default migrate uri in definition file

2014-04-15 Thread Chen Fan
Current virsh migrate command require specfying migration URI with command option. Here is current step. 1) If user specifies --migrateuri on virsh migrate command, then the command transfers the data to specified host. 2) If --migrateuri is not specified, the command transfers the data to host

[libvirt] [PATCH 1/2] move virConnectGetConfigFile() to virconf.h

2014-04-15 Thread Chen Fan
Currently, function virConnectGetConfigFile() is in src/libvirt.c, but this function is to manipulate configration file, so we move it to virconf.c could make it more generic. Signed-off-by: Chen Fan --- src/libvirt.c| 54 src/libvirt_

[libvirt] [PATCH 0/2] specify migration URI on setting file

2014-04-15 Thread Chen Fan
Hi all, Current virsh migrate command require specfying migration URI with command option. 1) If user specifies --migrateuri on virsh migrate command, then the command transfers the data to specified host. 2) If --migrateuri is not specified, the command transfers the data to host whose name is r

[libvirt] [java] [PATCH 2/2] Edits to getCPUStats bindings

2014-04-15 Thread Pasquale . phate867
From: Pasquale Di Rienzo -fixed some bindings -reworked the CPUStat class introducing a CPUStats class which encaplulates an HashMap and is more user friendly. -added a convenience method Connection.getOverallStats() for retrieving overall stats, instead of passing -1 as cpu number for Connection

[libvirt] [java] [PATCH 1/2] GetNodeCpuStat binding

2014-04-15 Thread Pasquale . phate867
From: Pasquale Di Rienzo -Added the getNodeCpuStat binding to Libvirt class -Added virNodeCPUStats and CPUStat classes to support this binding -Added the method getCPUStats to Connect class --- AUTHORS| 1 + src/main/java/org/libvirt/CPUStat.java

[libvirt] VNC sharePolicy not working as expected

2014-04-15 Thread Kekane, Abhishek
Hi All, Greetings!!! We are using KVM hypervisor driver for running OpenStack IaaS. Couple of months back we have reported one security issue [1] in OS. Basically we want to limit on the number of vnc client connections that can be opened by users for a given VM. >From libvirt 1.0.6 version onw

Re: [libvirt] [PATCH] nodeinfo: fix detection of physical memory on uclibc/musl libc

2014-04-15 Thread Daniel P. Berrange
On Tue, Apr 15, 2014 at 11:31:23AM +0200, Natanael Copa wrote: > The gnulib's physmem_total will as a fallback report 64MB as total > memory if sysconf(_SC_PHYS_PAGES) is unimplemented on linux. This makes > it impossible to detect if physmem_total works or not, so we try first > the linux only sys

[libvirt] [PATCH] nodeinfo: fix detection of physical memory on uclibc/musl libc

2014-04-15 Thread Natanael Copa
The gnulib's physmem_total will as a fallback report 64MB as total memory if sysconf(_SC_PHYS_PAGES) is unimplemented on linux. This makes it impossible to detect if physmem_total works or not, so we try first the linux only sysinfo(2) before falling back to gnulibs physmem_total. This makes the t

Re: [libvirt] [PATCH] nodeinfo: Make sure we always reset errno before calling readdir

2014-04-15 Thread Daniel P. Berrange
On Tue, Apr 15, 2014 at 11:27:12AM +0200, Natanael Copa wrote: > On Thu, 10 Apr 2014 15:53:57 -0600 > Eric Blake wrote: > > > On 04/10/2014 02:52 PM, Natanael Copa wrote: > > > > >>> I suppose we could use helper function to make it more readable: > > >>> > > > > >> int virReaddir(DIR *dirp, st

Re: [libvirt] [PATCH tck] 202-numa-set-parameters.t: use AFFECT_CONFIG when changing nodeset

2014-04-15 Thread Daniel P. Berrange
On Wed, Apr 09, 2014 at 03:12:47PM -0600, Mike Latimer wrote: > The 202-numa-set-parameters.t test sets NUMA_NODESET using AFFECT_LIVE on a > running domain, destroys and starts the domain, then verifies the NUMA_NODESET > setting. As AFFECT_LIVE does not write the setting to the domain xml file, >

Re: [libvirt] [PATCH tck] 220-no-ip-spoofing.t: Don't use a static netmask

2014-04-15 Thread Daniel P. Berrange
On Tue, Apr 01, 2014 at 05:24:33PM -0600, Mike Latimer wrote: > For environments not using a /24 netmask, this test can end up in a hung > state. This patch reads the netmask from the nic and uses it later when > ip addresses are changed and restored. > > --- > scripts/nwfilter/220-no-ip-spoofing

Re: [libvirt] [PATCH tck] 210-no-mac-spoofing.t: Catch network is unreachable error

2014-04-15 Thread Daniel P. Berrange
On Tue, Apr 01, 2014 at 05:24:19PM -0600, Mike Latimer wrote: > Some environments (openSUSE 13.1) can report the network is unreachable during > this test. Trap that condition as well. > > --- > scripts/nwfilter/210-no-mac-spoofing.t | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) AC

Re: [libvirt] [PATCH] nodeinfo: Make sure we always reset errno before calling readdir

2014-04-15 Thread Natanael Copa
On Thu, 10 Apr 2014 15:53:57 -0600 Eric Blake wrote: > On 04/10/2014 02:52 PM, Natanael Copa wrote: > > >>> I suppose we could use helper function to make it more readable: > >>> > > >> int virReaddir(DIR *dirp, struct dirent **ent) > >> { > >> errno = 0; > >> *ent = readdir(dirp); > >>

Re: [libvirt] [PATCHv2 9/9] RFC: conf: introduce as synonym of

2014-04-15 Thread Jiri Denemark
On Mon, Apr 14, 2014 at 16:54:20 -0600, Eric Blake wrote: > Still an RFC, since this claims over 400 tests are impacted: > $ git grep ' > Most uses of are per-disk - they affect the way the hypervisor > exposes storage to the guest, regardless of how many host resources > are involved. But one a

Re: [libvirt] [PATCH tck] 300-vsitype.t: Skip after $tck is defined

2014-04-15 Thread Daniel P. Berrange
On Tue, Apr 01, 2014 at 11:37:39AM -0600, Mike Latimer wrote: > With $tck added to the skip conditional, the entire codeblock has to be > after $tck is defined. Also, $tck->cleanup should be added to the skip > conditions. > > --- > scripts/nwfilter/300-vsitype.t | 18 ++ > 1 file

Re: [libvirt] [PATCH tck] 110-static-relabel-yes.t: Only 5 tests in 110-static-relabel

2014-04-15 Thread Daniel P. Berrange
On Tue, Apr 01, 2014 at 11:43:36AM -0600, Mike Latimer wrote: > Trivial, but there are only 5 tests in 110-static-relabel-yes.t. > > --- > scripts/selinux/110-static-relabel-yes.t | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) ACK Regards, Daniel -- |: http://berrange.com -o-

Re: [libvirt] [java] [PATCH] GetNodeCpuStat binding

2014-04-15 Thread Claudio Bley
At Tue, 15 Apr 2014 10:36:02 +0200, Pasquale Dir wrote: > > Working for the other corrections but I disegree with these ones: > > 1. This is an "unsigned long long" in C, so it must be a long, not > NativeLong here. > 2. flags is an "unsigned int" in C, so it > must be an "int" in Java That is a

Re: [libvirt] [java] [PATCH] GetNodeCpuStat binding

2014-04-15 Thread Pasquale Dir
That is if we would need to read/process these values too instead of just using them. 2014-04-15 10:36 GMT+02:00 Pasquale Dir : > Working for the other corrections but I disegree with these ones: > > 1. This is an "unsigned long long" in C, so it must be a long, not > NativeLong here. > 2. flags

Re: [libvirt] [java] [PATCH] GetNodeCpuStat binding

2014-04-15 Thread Pasquale Dir
Working for the other corrections but I disegree with these ones: 1. This is an "unsigned long long" in C, so it must be a long, not NativeLong here. 2. flags is an "unsigned int" in C, so it must be an "int" in Java As in java types are signed I'd avoid to allocate the exact same memory, on the

Re: [libvirt] [PATCH 00/26] Rewrite firewall code to use formal API

2014-04-15 Thread Daniel P. Berrange
On Mon, Apr 14, 2014 at 04:47:50PM -0400, Stefan Berger wrote: > On 04/08/2014 11:37 AM, Daniel P. Berrange wrote: > >Currently we have three places which interact with the firewall > > > > - util/virebtables - simple MAC filtering used by QEMU driver > > - util/viriptables - used by network dr

Re: [libvirt] why doesn't libvirt let qemu autostart live-migrated VMs?

2014-04-15 Thread Daniel P. Berrange
On Mon, Apr 14, 2014 at 05:50:07PM -0600, Chris Friesen wrote: > Hi, > > I've been digging through the libvirt code and something that struck > me was that it appears that when using qemu libvirt will migrate the > instance with autostart disabled, then sit on the source host > periodically pollin