Re: [libvirt] [PATCH 03/18] util: storage: Don't force path canonicalization when loading metadata

2014-04-23 Thread Peter Krempa
On 04/22/14 22:53, Eric Blake wrote: On 04/22/2014 07:34 AM, Eric Blake wrote: On 04/20/2014 04:13 PM, Peter Krempa wrote: Avoid breaking gluster volumes that don't have local representation. Use the provided name when canonicalization fails. Broken by commit 79f11b35 Fixes: $ virsh

Re: [libvirt] [PATCH 03/18] util: storage: Don't force path canonicalization when loading metadata

2014-04-23 Thread Peter Krempa
On 04/23/14 09:56, Peter Krempa wrote: On 04/22/14 22:53, Eric Blake wrote: On 04/22/2014 07:34 AM, Eric Blake wrote: On 04/20/2014 04:13 PM, Peter Krempa wrote: Avoid breaking gluster volumes that don't have local representation. Use the provided name when canonicalization fails. Broken by

[libvirt] Google Summer of Code and Outreach Program for Women accepted projects

2014-04-23 Thread Stefan Hajnoczi
Dear QEMU, Libvirt, and KVM communities, We are participating in Google Summer of Code 2014 (http://google-melange.com/) and Outreach Program for Women (http://opw.gnome.org/). Both programs fund candidates to work on our open source projects for 12 weeks this summer. Accepted projects have now

[libvirt] [PATCH] bhyve: implement connectGetSysinfo

2014-04-23 Thread Roman Bogorodskiy
--- src/bhyve/bhyve_driver.c | 31 +++ src/bhyve/bhyve_utils.h | 1 + 2 files changed, 32 insertions(+) diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c index 0cafe4c..ec1ba69 100644 --- a/src/bhyve/bhyve_driver.c +++ b/src/bhyve/bhyve_driver.c @@

Re: [libvirt] [PATCH v5 1/5] Introduce virDomainFSFreeze() and virDomainFSThaw() public API

2014-04-23 Thread Daniel P. Berrange
On Tue, Apr 22, 2014 at 06:22:18PM +, Tomoki Sekiyama wrote: Hi Daniel, thanks for your comment. On 4/22/14 11:39 , Daniel P. Berrange berra...@redhat.com wrote: On Thu, Apr 03, 2014 at 11:39:29AM -0400, Tomoki Sekiyama wrote: + +/** + * virDomainFSFreeze: + * @dom: a domain

Re: [libvirt] [PATCH 1/2] Add a new example to illustrate domain migration

2014-04-23 Thread Daniel P. Berrange
On Sun, Apr 13, 2014 at 01:52:47PM +0200, Sahid Orentino Ferdjaoui wrote: This commit adds a new example to illustrate peer to peer domain migration with virDomainMigrateToURI. diff --git a/examples/dommigrate/Makefile.am b/examples/dommigrate/Makefile.am new file mode 100644 index

Re: [libvirt] [PATCH 2/2] Add support for QEMU migration to use SASL authentication

2014-04-23 Thread Daniel P. Berrange
On Sun, Apr 13, 2014 at 01:52:48PM +0200, Sahid Orentino Ferdjaoui wrote: This commit provides the ability to virDomainMigrateToURI to check for SASL credentials when attempts to migrate a domain with the driver QEMU. Signed-off-by: Sahid Orentino Ferdjaoui sahid.ferdja...@cloudwatt.com ---

Re: [libvirt] [PATCH 0/2] Add support of SASL authentication for QEMU migration

2014-04-23 Thread Daniel P. Berrange
On Sun, Apr 13, 2014 at 01:50:32PM +, sahid wrote: This is a first contribution, I have tried to follow the most as possible rules marked in HACKING. I hope this commit will be conform with the specifications. make check OK make syntax-check OK make -C tests

[libvirt] [libvirt PATCH] udev: consider the device a CDROM when ID_CDROM=1

2014-04-23 Thread Giuseppe Scrivano
Some CDROM devices are reported by udev to have an ID_TYPE=generic thus it is necessary to check if ID_CDROM is present. As a side effect, treating ID_TYPE=generic as a missing ID_TYPE will enable checks for ID_DRIVE_FLASH_SD and ID_DRIVE_FLOPPY and the udevKludgeStorageType heuristic.

Re: [libvirt] [PATCH] bhyve: bhyveDomainDefineXML fixes

2014-04-23 Thread Daniel P. Berrange
On Mon, Apr 21, 2014 at 08:22:23PM +0400, Roman Bogorodskiy wrote: - do not loose new definition for an active domain - do not leak oldDef - do not set dom-id if virDomainSaveConfig() fails - do not call virObjectUnlock(vm) if vm is NULL --- src/bhyve/bhyve_driver.c | 14 ++ 1

Re: [libvirt] [PATCHv2 1/1] Set pci-ohci as the USB default controller for PPC64.

2014-04-23 Thread Daniel P. Berrange
On Wed, Apr 09, 2014 at 04:18:08PM +0800, Li Zhang wrote: From: Li Zhang zhlci...@linux.vnet.ibm.com PPC64 prefers to set pci-ohci controller as default USB controller. Currently, libvirt is using legacy USB controller as default. There are problems with VGA which can't work correctly with

Re: [libvirt] [PATCH] bhyve: bhyveDomainDefineXML fixes

2014-04-23 Thread Roman Bogorodskiy
Daniel P. Berrange wrote: On Mon, Apr 21, 2014 at 08:22:23PM +0400, Roman Bogorodskiy wrote: - do not loose new definition for an active domain - do not leak oldDef - do not set dom-id if virDomainSaveConfig() fails - do not call virObjectUnlock(vm) if vm is NULL ---

[libvirt] [PATCH 1/2] Save domain status after cpu hotplug

2014-04-23 Thread Ján Tomko
The live change of vcpus was not reflected in the domain status xml and it got lost during libvirtd restart. https://bugzilla.redhat.com/show_bug.cgi?id=1088703 --- src/qemu/qemu_driver.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index

[libvirt] [PATCH 0/2] Two more setvcpu fixes

2014-04-23 Thread Ján Tomko
Fix fix fix. Ján Tomko (2): Save domain status after cpu hotplug Document behavior of setvcpus during guest boot src/libvirt.c | 6 ++ src/qemu/qemu_driver.c | 3 +++ tools/virsh.pod| 4 +++- 3 files changed, 12 insertions(+), 1 deletion(-) -- 1.8.3.2 -- libvir-list

[libvirt] [PATCH 2/2] Document behavior of setvcpus during guest boot

2014-04-23 Thread Ján Tomko
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1088748 The hotlugged vcpus could fail to show up in the guest if they were added during boot, see: https://bugzilla.redhat.com/show_bug.cgi?id=807508 --- src/libvirt.c | 6 ++ tools/virsh.pod | 4 +++- 2 files changed, 9 insertions(+), 1

Re: [libvirt] [PATCH 03/18] util: storage: Don't force path canonicalization when loading metadata

2014-04-23 Thread Eric Blake
On 04/23/2014 01:59 AM, Peter Krempa wrote: -if (!(canonPath = canonicalize_file_name(path)) -VIR_STRDUP(canonPath, path) 0) { -virReportSystemError(errno, _(unable to resolve '%s'), path); +if (virStorageIsFile(path)) { You are suggesting this same change in patch

Re: [libvirt] [PATCH 2/2] Document behavior of setvcpus during guest boot

2014-04-23 Thread Eric Blake
On 04/23/2014 05:08 AM, Ján Tomko wrote: Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1088748 The hotlugged vcpus could fail to show up in the guest if s/hotlugged/hotplugged/ they were added during boot, see: https://bugzilla.redhat.com/show_bug.cgi?id=807508 --- src/libvirt.c |

Re: [libvirt] [PATCH 1/2] Save domain status after cpu hotplug

2014-04-23 Thread Eric Blake
On 04/23/2014 05:08 AM, Ján Tomko wrote: The live change of vcpus was not reflected in the domain status xml and it got lost during libvirtd restart. https://bugzilla.redhat.com/show_bug.cgi?id=1088703 --- src/qemu/qemu_driver.c | 3 +++ 1 file changed, 3 insertions(+) ACK diff --git

Re: [libvirt] [PATCH 2/2] Document behavior of setvcpus during guest boot

2014-04-23 Thread Ján Tomko
On 04/23/2014 02:14 PM, Eric Blake wrote: On 04/23/2014 05:08 AM, Ján Tomko wrote: Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1088748 The hotlugged vcpus could fail to show up in the guest if s/hotlugged/hotplugged/ they were added during boot, see:

[libvirt] [PATCH] nwfilter: Validate rule after parsing

2014-04-23 Thread Stefan Berger
From: Stefan Berger stef...@linux.vnet.ibm.com An IP or IPv6 rule with port specification but without protocol specification cannot be instantiated by ebtables. The documentation points to 'protocol' being required but implementation does not enforce it to be given. Implement a rule validation

Re: [libvirt] [PATCHv2 6/7] conf: drop redundant parameters during probe

2014-04-23 Thread John Ferlan
On 04/01/2014 11:05 PM, Eric Blake wrote: Now that each virStorageSource can track allocation information, and given that we already have the information without extra syscalls, it's easier to just always populate the information directly into the struct than it is to sometimes pass the

[libvirt] [PATCH] Restore skipping of setting capacity

2014-04-23 Thread John Ferlan
Commit id 'ac9a0963' refactored out the 'withCapacity' for the virStorageBackendUpdateVolInfo() API. See: http://www.redhat.com/archives/libvir-list/2014-April/msg00043.html This resulted in a difference in how 'virsh vol-info --pool poolName volume' or 'virsh vol-list vol-list --pool poolName

[libvirt] [PATCHv2 0.5/4] network: fix virNetworkObjAssignDef and persistence

2014-04-23 Thread Laine Stump
Experimentation showed that if virNetworkCreateXML() was called for a network that was already defined, and then the network was subsequently shutdown, the network would continue to be persistent after the shutdown (expected/desired), but the original config would be lost in favor of the transient

[libvirt] [PATCH 2/4] parallels: don't enable VNC when we define a new domain

2014-04-23 Thread Dmitry Guryanov
I added this code year ago, instead of implementing ability to change VNC configuration, which was not trivial, I added extra call to prlctl, which sets up VNC with auto port, despite VNC configuration given by a user. Let's remove this hack, because, first, it doesn't work on the latest

[libvirt] [PATCH 3/4] parallels: don't add domain to the list twice

2014-04-23 Thread Dmitry Guryanov
There is a problem with function parallelsDomainDefineXML. If we are defining a new domain, then we need to do 2 things: aclually create a VM in PCS and add new domain to the cached list of domains _parallelsConn.domains. This is done in the function parallelsLoadDomains. So call to

[libvirt] [PATCH 4/4] parallels: add a set of trivial functions

2014-04-23 Thread Dmitry Guryanov
Add functions parallelsIsAlive, parallelsIsEncrypted, parallelsIsSecure which are very simple to implement, but may be required by some libvirt users. Almost all other drivers have these functions. Signed-off-by: Dmitry Guryanov dgurya...@parallels.com --- src/parallels/parallels_driver.c | 20

[libvirt] [PATCH 1/4] parallels: fix virDomainDef.features comparison

2014-04-23 Thread Dmitry Guryanov
virDomainDef.features became an array, so now we can't simply compare one features variable to another. We need to compare each each element from the array. Signed-off-by: Dmitry Guryanov dgurya...@parallels.com --- src/parallels/parallels_driver.c | 13 - 1 file changed, 8

[libvirt] [PATCH 0/4] parallels: a set of fixes

2014-04-23 Thread Dmitry Guryanov
Hello, I'd like to continue working on the parallels driver. So here is a set of patches, which resolves some problems. Now Parallels has a definite goal with this driver: we want OpenStack to be working with Parallels Cloud Server (PCS) over libvirt, and we a ready to implement all needed API

Re: [libvirt] [PATCH] nwfilter: Validate rule after parsing

2014-04-23 Thread Stefan Berger
On 04/23/2014 09:08 AM, Stefan Berger wrote: From: Stefan Berger stef...@linux.vnet.ibm.com An IP or IPv6 rule with port specification but without protocol specification cannot be instantiated by ebtables. The documentation points to 'protocol' being required but implementation does not enforce

[libvirt] [PATCH v2] nwfilter: Validate rule after parsing

2014-04-23 Thread Stefan Berger
From: Stefan Berger stef...@linux.vnet.ibm.com An IP or IPv6 rule with port specification but without protocol specification cannot be instantiated by ebtables. The documentation points to 'protocol' being required but implementation does not enforce it to be given. Implement a rule validation

[libvirt] [PATCH] Fix pci bus naming for PPC

2014-04-23 Thread Daniel P. Berrange
Recent discussions around naming of 'pci' vs 'pci.0' for PPC made me go back and look at the PPC emulator in every historical version of QEMU since 1.0. The results were worse than I imagined. This patch adds the logic required to make libvirt work with PPC correctly with naming variations across

[libvirt] [PATCH] bhyve: domain events support

2014-04-23 Thread Roman Bogorodskiy
Tested with a sequance of virsh commands like that: - Redefine already defined domain (bhyve) using 'define' command - 'undefine bhyve' - 'define /path/to/bhyve.xml' - 'start bhyve' - 'destroy bhyve' - 'start --file /path/to/bhyve.xml' - 'destroy bhyve' This procudes list of events from

[libvirt] [PATCH] bhyve: domain events support

2014-04-23 Thread Roman Bogorodskiy
Support events for these functions: - domainDefineXML - domainUndefine - domainCreate{WithFlags,XML} - domainDestroy --- src/bhyve/bhyve_driver.c | 88 +++- src/bhyve/bhyve_utils.h | 3 ++ 2 files changed, 90 insertions(+), 1 deletion(-) diff

Re: [libvirt] [PATCH] Fix pci bus naming for PPC

2014-04-23 Thread Eric Blake
On 04/23/2014 09:38 AM, Daniel P. Berrange wrote: Recent discussions around naming of 'pci' vs 'pci.0' for PPC made me go back and look at the PPC emulator in every historical version of QEMU since 1.0. The results were worse than I imagined. This patch adds the logic required to make libvirt

Re: [libvirt] [PATCH 18/18] util: storage: Invert the way recursive metadata retrieval works

2014-04-23 Thread Eric Blake
On 04/20/2014 04:13 PM, Peter Krempa wrote: To avoid having the root of a backing chain present twice in the list we need to invert the working of virStorageFileGetMetadataRecurse. /* Recursive workhorse for virStorageFileGetMetadata. */ static int

Re: [libvirt] [PATCH] Qemu fails to restore when guest has selinux static context

2014-04-23 Thread Shivaprasad bhat
Thanks Martin. I'll send out the v2 addressing your comments. Thanks and Regards, Shiva On Thu, Apr 17, 2014 at 7:50 PM, Martin Kletzander mklet...@redhat.com wrote: On Tue, Apr 08, 2014 at 09:11:33AM -0400, Shivaprasad G Bhat wrote: The file handle passed from libvirt to qemu is not set to

Re: [libvirt] [PATCH] Restore skipping of setting capacity

2014-04-23 Thread Eric Blake
On 04/23/2014 07:28 AM, John Ferlan wrote: Commit id 'ac9a0963' refactored out the 'withCapacity' for the virStorageBackendUpdateVolInfo() API. See: Fortunately, we haven't released this regression of mine :) http://www.redhat.com/archives/libvir-list/2014-April/msg00043.html This

Re: [libvirt] [PATCHv2 2/4] network: change location of network state xml files

2014-04-23 Thread John Ferlan
On 04/17/2014 07:43 AM, Laine Stump wrote: For some reason these have been stored in /var/lib, although other drivers (e.g. qemu and lxc) store their state files in /var/run. It's much nicer to store state files in /var/run because it is automatically cleared out when the system reboots.

Re: [libvirt] [PATCHv2 3/4] network: set macvtap/hostdev networks active if their state file exists

2014-04-23 Thread John Ferlan
On 04/17/2014 07:43 AM, Laine Stump wrote: libvirt attempts to determine at startup time which networks are already active, and set their active flags. Previously it has done this by assuming that all networks are inactive, then setting the active flag if the network has a bridge device

Re: [libvirt] [PATCHv2 4/4] network: centralize check for active network during interface attach

2014-04-23 Thread John Ferlan
On 04/17/2014 07:43 AM, Laine Stump wrote: The check for a network being active during interface attach was being done individually in several places (by both the lxc driver and the qemu driver), but those places were too specific, leading to it *not* being checked when allocating a

Re: [libvirt] [PATCHv2 1/6] Add utility functions for storing uninstalled location

2014-04-23 Thread Eric Blake
On 03/25/2014 02:23 AM, Nehal J Wani wrote: src/libvirt_private.syms *Add symbols daemon/libvirtd.c *Set uninstallDir when libvirtd is running uninstalled from a build tree src/util/virutil.c *Introduce virSetUninstalledDir *Introduce virGetUninstalledDir ---

Re: [libvirt] [PATCHv2 6/6] Remove obsolete function virFDStreamSetIOHelper()

2014-04-23 Thread Eric Blake
On 03/25/2014 02:23 AM, Nehal J Wani wrote: Now that we have virSetUninstalledDir() and virGetUninstalledDir(), we no longer need virFDStreamSetIOHelper(). --- -static const char *iohelper_path = LIBEXECDIR /libvirt_iohelper; - -void virFDStreamSetIOHelper(const char *path) -{ -if

Re: [libvirt] [PATCH 18/18] util: storage: Invert the way recursive metadata retrieval works

2014-04-23 Thread Peter Krempa
On 04/23/14 18:18, Eric Blake wrote: On 04/20/2014 04:13 PM, Peter Krempa wrote: To avoid having the root of a backing chain present twice in the list we need to invert the working of virStorageFileGetMetadataRecurse. /* Recursive workhorse for virStorageFileGetMetadata. */ static int

Re: [libvirt] [PATCHv2 2/6] Use virGetUninstalledDir() in src/util/virfile.c

2014-04-23 Thread Eric Blake
On 03/25/2014 02:23 AM, Nehal J Wani wrote: src/util/virfile.c *Check if libvirtd is running uninstalled from a build tree and change iohelper_path accordingly --- src/util/virfile.c | 19 +-- 1 files changed, 17 insertions(+), 2 deletions(-) That's a rather

[libvirt] [PATCHv2] util: storage: Invert the way recursive metadata retrieval works

2014-04-23 Thread Peter Krempa
To avoid having the root of a backing chain present twice in the list we need to invert the working of virStorageFileGetMetadataRecurse. Until now the recursive worker created a new backing chain element from the name and other information passed as arguments. This required us to pass the data of

Re: [libvirt] [PATCH v5 1/5] Introduce virDomainFSFreeze() and virDomainFSThaw() public API

2014-04-23 Thread Tomoki Sekiyama
Hi Daniel, On 4/23/14 5:55 , Daniel P. Berrange berra...@redhat.com wrote: On Tue, Apr 22, 2014 at 06:22:18PM +, Tomoki Sekiyama wrote: Hi Daniel, thanks for your comment. On 4/22/14 11:39 , Daniel P. Berrange berra...@redhat.com wrote: On Thu, Apr 03, 2014 at 11:39:29AM -0400, Tomoki