[libvirt] [PATCH] fix build with older gcc

2014-05-02 Thread Ján Tomko
Older gcc (4.1.2-55.el5, 4.2.1 on FreeBSD) reports bogus warnings: ../../src/conf/nwfilter_conf.c:2111: warning: 'protocol' may be used uninitialized in this function ../../src/conf/nwfilter_conf.c:2110: warning: 'dataProtocolID' may be used uninitialized in this function Initialize them to NULL

Re: [libvirt] [Xen-devel] [PATCH V2 2/3] libxl: support PARAVIRT and ACPI shutdown flags

2014-05-02 Thread Ian Campbell
On Thu, 2014-05-01 at 16:14 -0600, Jim Fehlig wrote: Add support for VIR_DOMAIN_SHUTDOWN_PARAVIRT and VIR_DOMAIN_SHUTDOWN_ACPI_POWER_BTN flags in libxlDomainShutdownFlags(). Signed-off-by: Jim Fehlig jfeh...@suse.com For the libxl use: Acked-by: Ian Campbell ian.campb...@citrix.com --

Re: [libvirt] [Xen-devel] [PATCH V2 3/3] libxl: support PARAVIRT and ACPI reboot flags

2014-05-02 Thread Ian Campbell
On Thu, 2014-05-01 at 16:14 -0600, Jim Fehlig wrote: Add support for VIR_DOMAIN_REBOOT_PARAVIRT and VIR_DOMAIN_REBOOT_ACPI_POWER_BTN flags in libxlDomainReboot(). Signed-off-by: Jim Fehlig jfeh...@suse.com libxl side looks correct; Acked-by: Ian Campbell ian.campb...@citrix.com --

[libvirt] [PATCH] tests: don't fail with newer gnutls

2014-05-02 Thread Martin Kletzander
gnutls-3.3.0 and newer leaves 2 FDs open in order to be backwards compatible when it comes to chrooted binaries [1]. Linking commandhelper with gnutls then leaves these two FDs open and commandtest fails thanks to that. This patch does not link commandhelper with libvirt.la, but rather only the

Re: [libvirt] [PATCHv2 0/3] fix virstoragetest failure on 32-bit

2014-05-02 Thread Guido Günther
On Wed, Apr 30, 2014 at 08:27:59PM -0600, Eric Blake wrote: v1 was here, but it got nacked for being ugly: https://www.redhat.com/archives/libvir-list/2014-April/msg01132.html so in this version, I improved virstring first, then used the new clean function. This is a build-breaker fix, so

Re: [libvirt] [PATCH] tests: skip virfirewalltest on non-Linux systems

2014-05-02 Thread Daniel P. Berrange
On Thu, May 01, 2014 at 10:51:02PM +0400, Roman Bogorodskiy wrote: Currently firewalling is supported on Linux only, so skip the virfirewalltest on other platforms. --- tests/virfirewalltest.c | 58 + 1 file changed, 35 insertions(+), 23

Re: [libvirt] [PATCH V2 2/3] libxl: support PARAVIRT and ACPI shutdown flags

2014-05-02 Thread Daniel P. Berrange
On Thu, May 01, 2014 at 04:14:38PM -0600, Jim Fehlig wrote: Add support for VIR_DOMAIN_SHUTDOWN_PARAVIRT and VIR_DOMAIN_SHUTDOWN_ACPI_POWER_BTN flags in libxlDomainShutdownFlags(). Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_driver.c | 34

Re: [libvirt] [PATCH V2 1/3] Introduce a new flag for controlling shutdown/reboot

2014-05-02 Thread Daniel P. Berrange
On Thu, May 01, 2014 at 04:14:37PM -0600, Jim Fehlig wrote: Add a new flag to virDomain{Reboot,Shutdown}FlagValues to allow shutting down and rebooting a domain via the Xen paravirt control interface. Signed-off-by: Jim Fehlig jfeh...@suse.com --- include/libvirt/libvirt.h.in | 2 ++

Re: [libvirt] [PATCH V2 3/3] libxl: support PARAVIRT and ACPI reboot flags

2014-05-02 Thread Daniel P. Berrange
On Thu, May 01, 2014 at 04:14:39PM -0600, Jim Fehlig wrote: Add support for VIR_DOMAIN_REBOOT_PARAVIRT and VIR_DOMAIN_REBOOT_ACPI_POWER_BTN flags in libxlDomainReboot(). Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_driver.c | 30 ++ 1 file

Re: [libvirt] [PATCH v7 1/6] Introduce virDomainFSFreeze() and virDomainFSThaw() public API

2014-05-02 Thread Daniel P. Berrange
On Thu, May 01, 2014 at 08:05:48PM -0400, Tomoki Sekiyama wrote: These will freeze and thaw filesystems within guest specified by @mountpoints parameters. The parameters can be NULL and 0, then the all mounted filesystems are frozen or thawed. @flags parameter, which are currently not used, is

Re: [libvirt] [PATCH] tests: skip virfirewalltest on non-Linux systems

2014-05-02 Thread Peter Krempa
On 05/02/14 11:37, Daniel P. Berrange wrote: On Thu, May 01, 2014 at 10:51:02PM +0400, Roman Bogorodskiy wrote: Currently firewalling is supported on Linux only, so skip the virfirewalltest on other platforms. --- tests/virfirewalltest.c | 58

Re: [libvirt] [PATCH] tests: skip virfirewalltest on non-Linux systems

2014-05-02 Thread Roman Bogorodskiy
Daniel P. Berrange wrote: On Thu, May 01, 2014 at 10:51:02PM +0400, Roman Bogorodskiy wrote: Currently firewalling is supported on Linux only, so skip the virfirewalltest on other platforms. --- tests/virfirewalltest.c | 58 + 1

Re: [libvirt] [PATCH v7 2/6] remote: Implement virDomainFSFreeze and virDomainFSThaw

2014-05-02 Thread Daniel P. Berrange
On Thu, May 01, 2014 at 08:05:54PM -0400, Tomoki Sekiyama wrote: New rules are added in fixup_name in gendispatch.pl to keep the name FSFreeze and FSThaw. This adds a new ACL permission 'fs_freeze', which is also applied to VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE flag. Signed-off-by: Tomoki

Re: [libvirt] [PATCH] tests: skip virfirewalltest on non-Linux systems

2014-05-02 Thread Ján Tomko
On 05/02/2014 11:37 AM, Daniel P. Berrange wrote: On Thu, May 01, 2014 at 10:51:02PM +0400, Roman Bogorodskiy wrote: Currently firewalling is supported on Linux only, so skip the virfirewalltest on other platforms. --- tests/virfirewalltest.c | 58

Re: [libvirt] [PATCH v7 3/6] qemu: track quiesced status in qemuDomainSnapshotFSFreeze

2014-05-02 Thread Daniel P. Berrange
On Thu, May 01, 2014 at 08:06:01PM -0400, Tomoki Sekiyama wrote: Adds 'quiesced' status into qemuDomainObjPrivate that tracks whether FSFreeze is requested in the domain. It modifies error code from qemuDomainSnapshotFSFreeze and qemuDomainSnapshotFSThaw, so that a caller can know whether

Re: [libvirt] [PATCH] tests: skip virfirewalltest on non-Linux systems

2014-05-02 Thread Roman Bogorodskiy
Peter Krempa wrote: On 05/02/14 11:37, Daniel P. Berrange wrote: On Thu, May 01, 2014 at 10:51:02PM +0400, Roman Bogorodskiy wrote: Currently firewalling is supported on Linux only, so skip the virfirewalltest on other platforms. --- tests/virfirewalltest.c | 58

Re: [libvirt] [PATCH v7 4/6] qemu: Implement virDomainFSFreeze and virDomainFSThaw

2014-05-02 Thread Daniel P. Berrange
On Thu, May 01, 2014 at 08:06:07PM -0400, Tomoki Sekiyama wrote: Use qemuDomainSnapshotFSFreeze() and qemuDomainSnapshotFSFThaw() which are already implemented for snapshot quiescing. Signed-off-by: Tomoki Sekiyama tomoki.sekiy...@hds.com --- src/qemu/qemu_driver.c | 98

Re: [libvirt] [PATCH v7 5/6] virsh: Expose new virDomainFSFreeze and virDomainFSThaw API

2014-05-02 Thread Daniel P. Berrange
On Thu, May 01, 2014 at 08:06:13PM -0400, Tomoki Sekiyama wrote: These are exposed under domfsfreeze command and domfsthaw command. Signed-off-by: Tomoki Sekiyama tomoki.sekiy...@hds.com --- tools/virsh-domain.c | 126 ++ tools/virsh.pod

Re: [libvirt] [PATCH v7 6/6] qemu: Support mountpoints option of guest-fsfreeze-freeze

2014-05-02 Thread Daniel P. Berrange
On Thu, May 01, 2014 at 08:06:19PM -0400, Tomoki Sekiyama wrote: With this patch, virDomainFSFreeze will pass the mountpoints argument to qemu guest agent. For example, virDomainFSFreeze(dom, {/mnt/vol1, /mnt/vol2}, 2, 0) will issue qemu guest agent command:

Re: [libvirt] [PATCH] tests: skip virfirewalltest on non-Linux systems

2014-05-02 Thread Daniel P. Berrange
On Fri, May 02, 2014 at 11:52:28AM +0200, Ján Tomko wrote: On 05/02/2014 11:37 AM, Daniel P. Berrange wrote: On Thu, May 01, 2014 at 10:51:02PM +0400, Roman Bogorodskiy wrote: Currently firewalling is supported on Linux only, so skip the virfirewalltest on other platforms. ---

Re: [libvirt] [PATCH] Restore skipping of setting capacity

2014-05-02 Thread John Ferlan
On 05/02/2014 12:18 AM, Eric Blake wrote: I have run out of time to come up with anything more elegant that doesn't feel like it is violating release candidate freeze, so ACK to your patch for 1.2.4. We can then tackle the problem more fully (possibly reverting your patch for a nicer

[libvirt] CPU type/flags when converting a physical machine to run on libvirt

2014-05-02 Thread Richard W.M. Jones
I'm in the process of rewriting virt-p2v which is our program for converting physical machines to become virtual machines, running on top of libvirt + KVM. The physical machine has certain characteristics -- eg: - number of physical cores - amount of RAM - CPU type (eg. AMD Opteron, Intel

[libvirt] qemu: managedsave vs. save

2014-05-02 Thread Richard Weinberger
Hi! My KVM hosts share the same filesystem and I'm facing an issue using managedsave. If I save vmX using managedsave on hostA and restore it later using virsh restore in hostB the qemu process consumes 100% CPU and makes no progress. On the other hand, if I save vmX using save the restore works

Re: [libvirt] [PATCH] tests: skip virfirewalltest on non-Linux systems

2014-05-02 Thread Michal Privoznik
On 01.05.2014 20:51, Roman Bogorodskiy wrote: Currently firewalling is supported on Linux only, so skip the virfirewalltest on other platforms. --- tests/virfirewalltest.c | 58 + 1 file changed, 35 insertions(+), 23 deletions(-) So from the

Re: [libvirt] qemu: managedsave vs. save

2014-05-02 Thread Daniel P. Berrange
On Fri, May 02, 2014 at 02:08:28PM +0200, Richard Weinberger wrote: Hi! My KVM hosts share the same filesystem and I'm facing an issue using managedsave. If I save vmX using managedsave on hostA and restore it later using virsh restore in hostB the qemu process consumes 100% CPU and makes

Re: [libvirt] qemu: managedsave vs. save

2014-05-02 Thread Richard Weinberger
On Fri, May 2, 2014 at 2:16 PM, Daniel P. Berrange berra...@redhat.com wrote: On Fri, May 02, 2014 at 02:08:28PM +0200, Richard Weinberger wrote: Hi! My KVM hosts share the same filesystem and I'm facing an issue using managedsave. If I save vmX using managedsave on hostA and restore it

Re: [libvirt] qemu: managedsave vs. save

2014-05-02 Thread Daniel P. Berrange
On Fri, May 02, 2014 at 02:21:08PM +0200, Richard Weinberger wrote: On Fri, May 2, 2014 at 2:16 PM, Daniel P. Berrange berra...@redhat.com wrote: On Fri, May 02, 2014 at 02:08:28PM +0200, Richard Weinberger wrote: Hi! My KVM hosts share the same filesystem and I'm facing an issue using

Re: [libvirt] qemu: managedsave vs. save

2014-05-02 Thread Richard Weinberger
On Fri, May 2, 2014 at 2:26 PM, Daniel P. Berrange berra...@redhat.com wrote: On Fri, May 02, 2014 at 02:21:08PM +0200, Richard Weinberger wrote: On Fri, May 2, 2014 at 2:16 PM, Daniel P. Berrange berra...@redhat.com wrote: On Fri, May 02, 2014 at 02:08:28PM +0200, Richard Weinberger wrote:

Re: [libvirt] qemu: managedsave vs. save

2014-05-02 Thread Richard Weinberger
On Fri, May 2, 2014 at 2:16 PM, Daniel P. Berrange berra...@redhat.com wrote: On Fri, May 02, 2014 at 02:08:28PM +0200, Richard Weinberger wrote: Hi! My KVM hosts share the same filesystem and I'm facing an issue using managedsave. If I save vmX using managedsave on hostA and restore it

[libvirt] Some odd quriks of libvirt and xen on fedora 20.

2014-05-02 Thread Alvin Starr
I am using xen 4.3 on Fedora 20. For PV systems the vnc console display is on the correct port with the following call do qeum-dm libxl: debug: libxl_dm.c:1213:libxl__spawn_local_dm: -domain-name libxl: debug: libxl_dm.c:1213:libxl__spawn_local_dm: paravirt libxl: debug:

Re: [libvirt] [PATCH] tests: skip virfirewalltest on non-Linux systems

2014-05-02 Thread Roman Bogorodskiy
Michal Privoznik wrote: On 01.05.2014 20:51, Roman Bogorodskiy wrote: Currently firewalling is supported on Linux only, so skip the virfirewalltest on other platforms. --- tests/virfirewalltest.c | 58 + 1 file changed, 35

Re: [libvirt] qemu: managedsave vs. save

2014-05-02 Thread Laine Stump
On 05/02/2014 03:38 PM, Richard Weinberger wrote: On Fri, May 2, 2014 at 2:16 PM, Daniel P. Berrange berra...@redhat.com wrote: On Fri, May 02, 2014 at 02:08:28PM +0200, Richard Weinberger wrote: Hi! My KVM hosts share the same filesystem and I'm facing an issue using managedsave. If I

Re: [libvirt] [Qemu-devel] [RFC 0/5] Allow object-add on X86CPU subclasses, for CPU model probing

2014-05-02 Thread Igor Mammedov
On Wed, 30 Apr 2014 17:29:28 -0300 Eduardo Habkost ehabk...@redhat.com wrote: This series allows management code to use object-add on X86CPU subclasses, so it Is there any reason why device-add couldn't be used? can use it to probe for CPU model information without re-running QEMU. The

Re: [libvirt] qemu: managedsave vs. save

2014-05-02 Thread Richard Weinberger
On Fri, May 2, 2014 at 3:43 PM, Laine Stump la...@laine.org wrote: On 05/02/2014 03:38 PM, Richard Weinberger wrote: On Fri, May 2, 2014 at 2:16 PM, Daniel P. Berrange berra...@redhat.com wrote: On Fri, May 02, 2014 at 02:08:28PM +0200, Richard Weinberger wrote: Hi! My KVM hosts share the

Re: [libvirt] [PATCH V2 3/3] libxl: support PARAVIRT and ACPI reboot flags

2014-05-02 Thread Jim Fehlig
Daniel P. Berrange wrote: On Thu, May 01, 2014 at 04:14:39PM -0600, Jim Fehlig wrote: Add support for VIR_DOMAIN_REBOOT_PARAVIRT and VIR_DOMAIN_REBOOT_ACPI_POWER_BTN flags in libxlDomainReboot(). Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_driver.c | 30

Re: [libvirt] Some odd quriks of libvirt and xen on fedora 20.

2014-05-02 Thread Jim Fehlig
Alvin Starr wrote: I am using xen 4.3 on Fedora 20. What version of libvirt? For PV systems the vnc console display is on the correct port with the following call do qeum-dm libxl: debug: libxl_dm.c:1213:libxl__spawn_local_dm: -domain-name libxl: debug:

Re: [libvirt] [PATCH V2 3/3] libxl: support PARAVIRT and ACPI reboot flags

2014-05-02 Thread Daniel P. Berrange
On Fri, May 02, 2014 at 08:01:00AM -0600, Jim Fehlig wrote: Daniel P. Berrange wrote: On Thu, May 01, 2014 at 04:14:39PM -0600, Jim Fehlig wrote: Add support for VIR_DOMAIN_REBOOT_PARAVIRT and VIR_DOMAIN_REBOOT_ACPI_POWER_BTN flags in libxlDomainReboot(). Signed-off-by: Jim

Re: [libvirt] Some odd quriks of libvirt and xen on fedora 20.

2014-05-02 Thread Daniel P. Berrange
On Fri, May 02, 2014 at 08:41:00AM -0400, Alvin Starr wrote: I am using xen 4.3 on Fedora 20. For PV systems the vnc console display is on the correct port with the following call do qeum-dm libxl: debug: libxl_dm.c:1213:libxl__spawn_local_dm: -domain-name libxl: debug:

Re: [libvirt] qemu: managedsave vs. save

2014-05-02 Thread Laine Stump
On 05/02/2014 04:52 PM, Richard Weinberger wrote: On Fri, May 2, 2014 at 3:43 PM, Laine Stump la...@laine.org wrote: On 05/02/2014 03:38 PM, Richard Weinberger wrote: On Fri, May 2, 2014 at 2:16 PM, Daniel P. Berrange berra...@redhat.com wrote: On Fri, May 02, 2014 at 02:08:28PM +0200,

Re: [libvirt] [Qemu-devel] [RFC 0/5] Allow object-add on X86CPU subclasses, for CPU model probing

2014-05-02 Thread Eduardo Habkost
On Fri, May 02, 2014 at 03:45:03PM +0200, Igor Mammedov wrote: On Wed, 30 Apr 2014 17:29:28 -0300 Eduardo Habkost ehabk...@redhat.com wrote: This series allows management code to use object-add on X86CPU subclasses, so it Is there any reason why device-add couldn't be used? It needs to

Re: [libvirt] [PATCHv2] storageVolCreateXMLFrom: Allow multiple accesses to origvol

2014-05-02 Thread Ján Tomko
On 04/30/2014 11:41 AM, Michal Privoznik wrote: When creating a new volume, it is possible to copy data into it from another already existing volume (referred to as @origvol). Obviously, the read-only access to @origvol is required, which is thread safe (probably not performance-wise though).

Re: [libvirt] [PATCH V2 3/3] libxl: support PARAVIRT and ACPI reboot flags

2014-05-02 Thread Jim Fehlig
Daniel P. Berrange wrote: On Fri, May 02, 2014 at 08:01:00AM -0600, Jim Fehlig wrote: Daniel P. Berrange wrote: Given that Xen has a decent paravirt reboot facility I'd probably just not bother with trying to fake the controlled reboot via ACPI. Ok, that sounds

Re: [libvirt] qemu: managedsave vs. save

2014-05-02 Thread Richard Weinberger
On Fri, May 2, 2014 at 4:36 PM, Laine Stump la...@laine.org wrote: On 05/02/2014 04:52 PM, Richard Weinberger wrote: On Fri, May 2, 2014 at 3:43 PM, Laine Stump la...@laine.org wrote: On 05/02/2014 03:38 PM, Richard Weinberger wrote: On Fri, May 2, 2014 at 2:16 PM, Daniel P. Berrange

[libvirt] Reg : failing to attach iscsi disk from virsh to running VM on xen

2014-05-02 Thread Prapulla Kumar
Hi , For attaching iSCSI disk I have tried like this *iscsi target side :* * 1 created an iqn number* #tgtadm --lld iscsi --op new --mode target --tid 1 -T iqn.2009-06.com.eucalyptus.cluster1:store1 *2. added one lun to it* #tgtadm --lld iscsi --op new

Re: [libvirt] [Qemu-devel] [RFC 0/5] Allow object-add on X86CPU subclasses, for CPU model probing

2014-05-02 Thread Paolo Bonzini
Il 02/05/2014 16:43, Eduardo Habkost ha scritto: The first thing I considered was making icc-bus user-creatable. Then I noticed it wouldn't work because object-add always add objects to /objects, not inside the qdev hierarchy (that's where device_add looks for the bus). So, allowing device_add

Re: [libvirt] [PATCH V2 3/3] libxl: support PARAVIRT and ACPI reboot flags

2014-05-02 Thread Daniel P. Berrange
On Fri, May 02, 2014 at 08:43:57AM -0600, Jim Fehlig wrote: Daniel P. Berrange wrote: On Fri, May 02, 2014 at 08:01:00AM -0600, Jim Fehlig wrote: Daniel P. Berrange wrote: Given that Xen has a decent paravirt reboot facility I'd probably just not bother with trying to fake the

Re: [libvirt] [Qemu-devel] [RFC 0/5] Allow object-add on X86CPU subclasses, for CPU model probing

2014-05-02 Thread Eduardo Habkost
On Fri, May 02, 2014 at 04:54:00PM +0200, Paolo Bonzini wrote: Il 02/05/2014 16:43, Eduardo Habkost ha scritto: The first thing I considered was making icc-bus user-creatable. Then I noticed it wouldn't work because object-add always add objects to /objects, not inside the qdev hierarchy

Re: [libvirt] CPU type/flags when converting a physical machine to run on libvirt

2014-05-02 Thread Eduardo Habkost
CCing Cole, as he had to deal with libvirt and host-cpu before, and may have some comments about the bugs he has found. On Fri, May 02, 2014 at 01:07:05PM +0100, Richard W.M. Jones wrote: I'm in the process of rewriting virt-p2v which is our program for converting physical machines to become

Re: [libvirt] CPU type/flags when converting a physical machine to run on libvirt

2014-05-02 Thread Richard W.M. Jones
On Fri, May 02, 2014 at 03:53:31PM -0300, Eduardo Habkost wrote: On Fri, May 02, 2014 at 01:07:05PM +0100, Richard W.M. Jones wrote: - Should we try to reflect the CPU type of the physical machine in the virtual machine? eg. If it's an Opteron, we generate an Opteron target machine.

Re: [libvirt] CPU type/flags when converting a physical machine to run on libvirt

2014-05-02 Thread Eduardo Habkost
On Fri, May 02, 2014 at 08:10:47PM +0100, Richard W.M. Jones wrote: On Fri, May 02, 2014 at 03:53:31PM -0300, Eduardo Habkost wrote: On Fri, May 02, 2014 at 01:07:05PM +0100, Richard W.M. Jones wrote: - Should we try to reflect the CPU type of the physical machine in the virtual

Re: [libvirt] Some odd quriks of libvirt and xen on fedora 20.

2014-05-02 Thread Alvin Starr
I have seen the problem on 1.0.3 on F19 and 1.1.3 on F20 On 05/02/2014 10:07 AM, Jim Fehlig wrote: Alvin Starr wrote: I am using xen 4.3 on Fedora 20. What version of libvirt? For PV systems the vnc console display is on the correct port with the following call do qeum-dm libxl: debug: