[libvirt] ANNOUNCE: libvirt 1.1.3.5 maintenance release

2014-05-03 Thread Cole Robinson
libvirt 1.1.3.5 maintenance release is now available. This is libvirt 1.1.3 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-1.1.3.5.tar.gz Changes in this version: * qemu: Int

[libvirt] Regression with 79f11b35

2014-05-03 Thread Cole Robinson
I'm seeing a regression with: commit 79f11b35c77b3c286c84312dc9737c2ccbf67ed5 Author: Eric Blake Date: Tue Apr 8 14:26:02 2014 -0600 conf: track user vs. canonical name through full chain lookup Setup info: $ ls -ld /mnt/data lrwxrwxrwx. 1 root root 17 Oct 24 2011 /mnt/data -> terabyte

[libvirt] [PATCH 5/5] virdbus: Show method name in error message

2014-05-03 Thread Cole Robinson
If you trigger bug 1033369, we get the error message: error from service: Invalid argument Which is a bit too generic to pinpoint what is actually failing. This changes it to: error from service: CreateMachine: Invalid argument --- src/util/virdbus.c | 7 --- 1 file changed, 4 insertion

[libvirt] [PATCH 4/5] virdbus: Remove redundant error macro

2014-05-03 Thread Cole Robinson
This is the only callsite. We drop use of localerror.name here, because it's not actually useful to us: rather than the parameter name which received an invalid value (which was assumed), it's actually the the dbus errno equivalent. Just use the string. --- src/util/virdbus.c | 7 --- src/ut

[libvirt] [PATCH 1/5] virerror: Fix an error message typo

2014-05-03 Thread Cole Robinson
--- src/util/virerror.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virerror.h b/src/util/virerror.h index 2de04f4..fe0e15e 100644 --- a/src/util/virerror.h +++ b/src/util/virerror.h @@ -99,7 +99,7 @@ void virReportSystemErrorFull(int domcode,

[libvirt] [PATCH 2/5] virerror: Fix incorrect use of RaiseErrorFull

2014-05-03 Thread Cole Robinson
RaiseErrorFull does not prepend the static error code string (like INVALID_ARG yields "invalid arg: %(msg)s"). We should be using ReportErrorHelper. The generated error objects are slightly different, by not storing the invalid argument name in err->str2. However those fields aren't used anywhere

[libvirt] [PATCH 3/5] virdbus: Make virDBusCall static

2014-05-03 Thread Cole Robinson
--- src/libvirt_private.syms | 1 - src/util/virdbus.c | 19 +-- src/util/virdbus.h | 4 3 files changed, 5 insertions(+), 19 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index cc3ae2c..8a015eb 100644 --- a/src/libvirt_private.sy

[libvirt] [PATCH v3 3/3] bhyve: implement PCI address allocation

2014-05-03 Thread Roman Bogorodskiy
Automatically allocate PCI addresses for devices instead of hardcoding them in the driver code. The current allocation schema is to dedicate an entire slot for each devices. Also, allow having arbitrary number of devices. --- po/POTFILES.in | 1 + src/Makefil

[libvirt] [PATCH v3 1/3] qemu: extract PCI handling structs

2014-05-03 Thread Roman Bogorodskiy
Extract PCI handling related structs that could be shared with other drivers. List of structs moved to virpci.h and new names: qemuDomainPCIAddressBus -> virDomainPCIAddressBus qemuDomainPCIAddressBusPtr -> virDomainPCIAddressBusPtr _qemuDomainPCIAddressSet -> virDomainPCIAddressSet qemuDomai

[libvirt] [PATCH v3 0/3] bhyve: implement PCI address allocation

2014-05-03 Thread Roman Bogorodskiy
The first attempt to share PCI allocation code from qemu driver with bhyve. To this point it went pretty smooth and I didn't have to make any changes to the implementation of the extracted PCI code. The only slight change I made is extracing virDomainPCIAddressSetAlloc() from DomainPCIAddressSetCr

Re: [libvirt] [PATCH] qemuxml2argvtest: Don't use privilged mode upfront

2014-05-03 Thread Guido Günther
On Sat, May 03, 2014 at 07:39:40AM -0600, Eric Blake wrote: > On 05/03/2014 06:16 AM, Guido Günther wrote: > > When building packages in a clean chroot the QEMU_USER and QEMU_GROUP > > don't exist making VirQemuDriverConfigNew fail with privileged=true. > > > > Avoid that by not requiring privilig

Re: [libvirt] [PATCH] Explicitly link virfirewalltest and virsystemdtest against dbus

2014-05-03 Thread Guido Günther
On Sat, May 03, 2014 at 07:39:03AM -0600, Eric Blake wrote: > On 05/03/2014 06:16 AM, Guido Günther wrote: > > This fixes link failures like: > > > > CCLD virfirewalltest > > /usr/bin/ld: virfirewalltest-virfirewalltest.o: undefined reference to > > symbol 'dbus_message_iter_init_append'

Re: [libvirt] [PATCH] qemuxml2argvtest: Don't use privilged mode upfront

2014-05-03 Thread Eric Blake
On 05/03/2014 06:16 AM, Guido Günther wrote: > When building packages in a clean chroot the QEMU_USER and QEMU_GROUP > don't exist making VirQemuDriverConfigNew fail with privileged=true. > > Avoid that by not requiring priviliged mode upfront but setting it later s/priviliged/privileged/ > so w

Re: [libvirt] [PATCH] Explicitly link virfirewalltest and virsystemdtest against dbus

2014-05-03 Thread Eric Blake
On 05/03/2014 06:16 AM, Guido Günther wrote: > This fixes link failures like: > > CCLD virfirewalltest > /usr/bin/ld: virfirewalltest-virfirewalltest.o: undefined reference to > symbol 'dbus_message_iter_init_append' > --- > tests/Makefile.am | 4 ++-- > 1 file changed, 2 insertions(+),

[libvirt] [PATCH] qemuxml2argvtest: Don't use privilged mode upfront

2014-05-03 Thread Guido Günther
When building packages in a clean chroot the QEMU_USER and QEMU_GROUP don't exist making VirQemuDriverConfigNew fail with privileged=true. Avoid that by not requiring priviliged mode upfront but setting it later so we skip the user/group existence check. This solution was suggested by Daniel P. B

[libvirt] [PATCH] Explicitly link virfirewalltest and virsystemdtest against dbus

2014-05-03 Thread Guido Günther
This fixes link failures like: CCLD virfirewalltest /usr/bin/ld: virfirewalltest-virfirewalltest.o: undefined reference to symbol 'dbus_message_iter_init_append' --- tests/Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.am b/tests/Makef

Re: [libvirt] CPU type/flags when converting a physical machine to run on libvirt

2014-05-03 Thread Richard W.M. Jones
On Fri, May 02, 2014 at 05:17:42PM -0300, Eduardo Habkost wrote: > That's interesting. So you have many reasons to be conservative by > default, unless you (or the user) have additional information about the > target machine/cluster where the VM is going to run. > > Is the p2v tool going to accept