Re: [libvirt] [RFC PATCH] Add support for invtsc timer

2014-05-07 Thread Ján Tomko
On 05/06/2014 04:50 PM, Daniel P. Berrange wrote: On Tue, May 06, 2014 at 03:27:20PM +0200, Ján Tomko wrote: The support for this timer is indicated by bit 8 of EDX after calling CPUID with 0x8007. It does not show up in /proc/cpuinfo [1] and since we're calling qemu without 'enforce', it

Re: [libvirt] Configure virtio-scsi options via libvirt

2014-05-07 Thread Stefan Hajnoczi
On Tue, May 06, 2014 at 04:13:50PM -0700, Mike Perez wrote: I would like be able to configure virtio-scsi options num_queues, max_sectors, and cmd_per_lun via libvirt. Are there any plans to have this support? Hi Mike, I'm not sure about the status of libvirt support for virtio-scsi options but

[libvirt] [PATCHv4 1/3] Introduce virDomain{Get,Set}Time APIs

2014-05-07 Thread Michal Privoznik
These APIs allow users to get or set time in a domain, which may come handy if the domain has been resumed just recently and NTP is not configured or hasn't kicked in yet and the guest is running something time critical. In addition, NTP may refuse to re-set the clock if the skew is too big. In

[libvirt] [PATCHv4 0/3] Time setting and getting in qemu guests

2014-05-07 Thread Michal Privoznik
Hopefully the last round. diff to v3: -rebase resend Michal Privoznik (3): Introduce virDomain{Get,Set}Time APIs virsh: Expose virDomain{Get,Set}Time qemu: Implement virDomain{Get,Set}Time daemon/remote.c | 37 include/libvirt/libvirt.h.in | 14 +

[libvirt] [PATCHv4 3/3] qemu: Implement virDomain{Get,Set}Time

2014-05-07 Thread Michal Privoznik
One caveat though, qemu-ga is expecting time and returning time in nanoseconds. With all the buffering and propagation delay, the time is already wrong once it gets to the qemu-ga, but there's nothing we can do about it. Signed-off-by: Michal Privoznik mpriv...@redhat.com ---

[libvirt] [PATCHv4 2/3] virsh: Expose virDomain{Get,Set}Time

2014-05-07 Thread Michal Privoznik
These APIs are exposed under new virsh command 'domtime' which both gets and sets (not at the same time of course :)). Signed-off-by: Michal Privoznik mpriv...@redhat.com --- tools/virsh-domain-monitor.c | 132 +++ tools/virsh.pod | 16 ++

Re: [libvirt] Configure virtio-scsi options via libvirt

2014-05-07 Thread Ján Tomko
On 05/07/2014 01:13 AM, Mike Perez wrote: Hi everyone, I would like be able to configure virtio-scsi options num_queues, max_sectors, and cmd_per_lun via libvirt. Are there any plans to have this support? num_queues is supported for virtio-scsi controllers since libvirt 1.0.5:

[libvirt] LibvirtError: Operation not supported : JSON monitor is required

2014-05-07 Thread xeon_feng
Hi Thanks for chenhanx...@cn.fujitsu.com help , I have resole the problem (libvirt 1.2.4 and virt-manager 0.9.0 are not incompatible)..but when I created VM by virt-manager ,it reported : unable to complete install: 'Opertation not supported: JSON monitor is required.'

Re: [libvirt] [RESEND PATCH] Add support for timestamping QEMU logs

2014-05-07 Thread Ján Tomko
On 05/07/2014 12:27 AM, Eric Blake wrote: On 05/06/2014 07:36 AM, Ján Tomko wrote: QEMU commit 5e2ac51 added a boolean '-msg timestamp=[on|off]' option, which can enable timestamps on errors: $ qemu-system-x86_64 -msg timestamp=on zghhdorf 2014-04-09T13:25:46.779484Z qemu-system-x86_64: -msg

[libvirt] [patch v3 0/2] add support for migrateURI configuration

2014-05-07 Thread Chen Fan
For now, we set the migration URI via command line '--migrate_uri' or construct the URI by looking up the dest host's hostname which could be solved by DNS automatically. But in cases the dest host have two or more NICs to reach, we may need to send the migration data over a specific NIC which is

[libvirt] [patch v3 1/2] Add support for migration URI configuration

2014-05-07 Thread Chen Fan
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com --- src/qemu/qemu.conf| 5 - src/qemu/qemu_conf.c | 2 ++ src/qemu/qemu_conf.h | 2 ++ src/qemu/qemu_migration.c | 5 + 4 files changed, 13 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu.conf

[libvirt] [patch v3 2/2] add inotify handler to qemu driver

2014-05-07 Thread Chen Fan
we don't expect to reload 'migrate_uri' with restarting libvirtd everytime while updating the URI, so adding inotify handler to reload 'migrate_uri' configuration without restarting libvirtd, it will be also helpful for virt-manager to get 'migrate_uri'. Signed-off-by: Chen Fan

Re: [libvirt] [PATCH] qemu: Adjust size for qcow2/qed if not on sector boundary

2014-05-07 Thread John Ferlan
On 04/08/2014 12:26 PM, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1002813 If qemuDomainBlockResize() is passed a size not on a KiB boundary - that is passed a size based in bytes (VIR_DOMAIN_BLOCK_RESIZE_BYTES), then depending on the source format (qcow2 or qed), the

Re: [libvirt] [PATCH 1/2] storage: Need to ensure removal of voldef from driver list

2014-05-07 Thread Ján Tomko
On 05/07/2014 02:08 AM, John Ferlan wrote: If for some reason a volume cannot be built in the pool (eg, the buildVol call fails), then the error code may or may not properly remove the volume from the pool-volumes.objs[] list. Removal from the list is dependent on the 'deleteVol()' being

Re: [libvirt] [PATCH 2/2] storage: Resolve issues in failure path

2014-05-07 Thread Ján Tomko
On 05/07/2014 02:08 AM, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1092882 Refactoring in commit id '0c2305b3' resulted in the wrong storage volume object being passed to the new storageVolDeleteInternal(). It should have passed 'voldef' which is the address found in the

Re: [libvirt] [PATCH 0/4] parallels: a set of fixes

2014-05-07 Thread Dmitry Guryanov
On Wednesday 23 April 2014 18:34:59 Dmitry Guryanov wrote: Hello, I'd like to continue working on the parallels driver. So here is a set of patches, which resolves some problems. Now Parallels has a definite goal with this driver: we want OpenStack to be working with Parallels Cloud

Re: [libvirt] [PATCH 0/4] parallels: a set of fixes

2014-05-07 Thread Daniel P. Berrange
On Wed, May 07, 2014 at 05:29:14PM +0400, Dmitry Guryanov wrote: On Wednesday 23 April 2014 18:34:59 Dmitry Guryanov wrote: Hello, I'd like to continue working on the parallels driver. So here is a set of patches, which resolves some problems. Now Parallels has a definite goal with

Re: [libvirt] [PATCH 1/4] parallels: fix virDomainDef.features comparison

2014-05-07 Thread Daniel P. Berrange
On Wed, Apr 23, 2014 at 06:35:00PM +0400, Dmitry Guryanov wrote: virDomainDef.features became an array, so now we can't simply compare one features variable to another. We need to compare each each element from the array. Signed-off-by: Dmitry Guryanov dgurya...@parallels.com ---

Re: [libvirt] [PATCH 2/4] parallels: don't enable VNC when we define a new domain

2014-05-07 Thread Daniel P. Berrange
On Wed, Apr 23, 2014 at 06:35:01PM +0400, Dmitry Guryanov wrote: I added this code year ago, instead of implementing ability to change VNC configuration, which was not trivial, I added extra call to prlctl, which sets up VNC with auto port, despite VNC configuration given by a user. Let's

Re: [libvirt] [PATCH 3/4] parallels: don't add domain to the list twice

2014-05-07 Thread Daniel P. Berrange
On Wed, Apr 23, 2014 at 06:35:02PM +0400, Dmitry Guryanov wrote: There is a problem with function parallelsDomainDefineXML. If we are defining a new domain, then we need to do 2 things: aclually create a VM in PCS and add new domain to the cached list of domains _parallelsConn.domains. This

Re: [libvirt] [PATCH 4/4] parallels: add a set of trivial functions

2014-05-07 Thread Daniel P. Berrange
On Wed, Apr 23, 2014 at 06:35:03PM +0400, Dmitry Guryanov wrote: Add functions parallelsIsAlive, parallelsIsEncrypted, parallelsIsSecure which are very simple to implement, but may be required by some libvirt users. Almost all other drivers have these functions. Signed-off-by: Dmitry

Re: [libvirt] [PATCH 4/4] parallels: add a set of trivial functions

2014-05-07 Thread Dmitry Guryanov
On Wednesday 07 May 2014 14:55:51 Daniel P. Berrange wrote: On Wed, Apr 23, 2014 at 06:35:03PM +0400, Dmitry Guryanov wrote: Add functions parallelsIsAlive, parallelsIsEncrypted, parallelsIsSecure which are very simple to implement, but may be required by some libvirt users. Almost all

Re: [libvirt] [PATCH 1/2] storage: Need to ensure removal of voldef from driver list

2014-05-07 Thread John Ferlan
On 05/07/2014 08:52 AM, Ján Tomko wrote: On 05/07/2014 02:08 AM, John Ferlan wrote: If for some reason a volume cannot be built in the pool (eg, the buildVol call fails), then the error code may or may not properly remove the volume from the pool-volumes.objs[] list. Removal from the list

Re: [libvirt] [PATCH 0/4] parallels: a set of fixes

2014-05-07 Thread Daniel P. Berrange
On Wed, May 07, 2014 at 02:45:09PM +0100, Daniel P. Berrange wrote: On Wed, May 07, 2014 at 05:29:14PM +0400, Dmitry Guryanov wrote: On Wednesday 23 April 2014 18:34:59 Dmitry Guryanov wrote: Hello, I'd like to continue working on the parallels driver. So here is a set of patches,

Re: [libvirt] [PATCH] qemu: Adjust size for qcow2/qed if not on sector boundary

2014-05-07 Thread Ján Tomko
On 05/07/2014 01:58 PM, John Ferlan wrote: On 04/08/2014 12:26 PM, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1002813 If qemuDomainBlockResize() is passed a size not on a KiB boundary - that is passed a size based in bytes (VIR_DOMAIN_BLOCK_RESIZE_BYTES), then

Re: [libvirt] [PATCH 3/5] virdbus: Make virDBusCall static

2014-05-07 Thread Cole Robinson
On 05/05/2014 02:53 AM, Guido Günther wrote: On Sat, May 03, 2014 at 03:59:40PM -0400, Cole Robinson wrote: --- src/libvirt_private.syms | 1 - src/util/virdbus.c | 19 +-- src/util/virdbus.h | 4 3 files changed, 5 insertions(+), 19 deletions(-) diff

Re: [libvirt] [PATCH 1/5] virerror: Fix an error message typo

2014-05-07 Thread Cole Robinson
On 05/04/2014 03:37 AM, Guido Günther wrote: On Sat, May 03, 2014 at 03:59:38PM -0400, Cole Robinson wrote: --- src/util/virerror.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virerror.h b/src/util/virerror.h index 2de04f4..fe0e15e 100644 ---

Re: [libvirt] [PATCH 0/4] parallels: a set of fixes

2014-05-07 Thread Daniel Veillard
On Wed, May 07, 2014 at 05:29:14PM +0400, Dmitry Guryanov wrote: On Wednesday 23 April 2014 18:34:59 Dmitry Guryanov wrote: Hello, I'd like to continue working on the parallels driver. So here is a set of patches, which resolves some problems. Now Parallels has a definite goal with

[libvirt] [PATCH] qemu: Implement a stub cpuArchDriver.compare() handler for arm and aarch64

2014-05-07 Thread Oleg Strikov
Libvirt calls cpuArchDriver.compare() while doing guest migration. We don't have any logic to distinguish between different arm and aarch64 models that's why this patch allows migration to any host. Signed-off-by: Oleg Strikov oleg.stri...@canonical.com --- src/cpu/cpu_aarch64.c |9 -

Re: [libvirt] [PATCH] LXC: don't doubly link /dev/console

2014-05-07 Thread Dwight Engen
On Tue, 6 May 2014 11:27:47 +0100 Daniel P. Berrange berra...@redhat.com wrote: On Mon, May 05, 2014 at 11:14:18AM -0400, Dwight Engen wrote: When a console is configured, /dev/console and /dev/tty1 are created as symlinks to the same underlying pts. This causes problems since a separate

[libvirt] troubles creating an OVS network with xen, libxl and libvirt.

2014-05-07 Thread Alvin Starr
One more quirk I can create a domain using the lx commands and a slightly modified .conf file. virsh start kvmtest returns a failure. I tracked the information passed to vif-openvswitch and it is being called with type_if=tap and it needs to be type_if=vif. Any help would be greatly

Re: [libvirt] troubles creating an OVS network with xen, libxl and libvirt.

2014-05-07 Thread Jim Fehlig
Alvin Starr wrote: One more quirk I can create a domain using the lx commands and a slightly modified .conf file. virsh start kvmtest returns a failure. I tracked the information passed to vif-openvswitch and it is being called with type_if=tap and it needs to be type_if=vif. Sounds like

[libvirt] [PATCH 0/4] parallels: reimplement hard disks support

2014-05-07 Thread Dmitry Guryanov
This patch series makes working with hard disks more natural to the libvirt API. It removes all links between storage and hypervisor driver, since only disks of type VIR_STORAGE_TYPE_VOLUME should use information from storage driver. Also it removes ability to create a VM where you want, because

[libvirt] [PATCH 2/4] parallels: set file format in virDomainDef

2014-05-07 Thread Dmitry Guryanov
Set file format in virDomainDef structure to produce correct XML in virDomainGetXMLDesc function. Signed-off-by: Dmitry Guryanov dgurya...@parallels.com --- src/parallels/parallels_driver.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/parallels/parallels_driver.c

[libvirt] [PATCH 4/4] parallels: create VMs in the default place

2014-05-07 Thread Dmitry Guryanov
Each VM consists of a set of files in PCS: config, hard disk images, log file, memory dump. All these files are stored in a per-vm directory. When we create a new VM, we can ether specify path to the VM or create the VM in a default path (default path/vm name.pvm). This default path can be

[libvirt] [PATCH 1/4] parallels: add VIR_STORAGE_FILE_PLOOP format

2014-05-07 Thread Dmitry Guryanov
Add VIR_STORAGE_FILE_PLOOP format. This format is used to store disk images for virtual machines in PCS and containers in PCS, OpenVZ and also in Parallels Desktop for Mac. This format is described on OpenVZ site - https://openvz.org/Ploop (together with ploop devices). It consists of XML

[libvirt] [PATCH 3/4] parallels: add disks correctly

2014-05-07 Thread Dmitry Guryanov
Disks support in this driver was implemented with an assumption, that disk images can't be created by hand, without VM. So complex storage driver was implemented with workaround. This is not true, we can create new disks using ploop tool. So the first step to reimplement disks support in

Re: [libvirt] [PATCH] qemu: Adjust size for qcow2/qed if not on sector boundary

2014-05-07 Thread John Ferlan
On 05/07/2014 10:34 AM, Ján Tomko wrote: On 05/07/2014 01:58 PM, John Ferlan wrote: On 04/08/2014 12:26 PM, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1002813 If qemuDomainBlockResize() is passed a size not on a KiB boundary - that is passed a size based in bytes

Re: [libvirt] [RFC PATCH] Add support for invtsc timer

2014-05-07 Thread Marcelo Tosatti
On Tue, May 06, 2014 at 03:27:20PM +0200, Ján Tomko wrote: Not yet merged in upstream QEMU: https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg05024.html Add support for invariant TSC timer running at constant rate in all ACPI P-, C- and T-states. It can be enabled by specifying:

Re: [libvirt] [patch v3 1/2] Add support for migration URI configuration

2014-05-07 Thread Wangrui (K)
I think *cfg* should be unref by virObjectUnref(cfg) . And so does patch 2/2. -Original Message- From: libvir-list-boun...@redhat.com [mailto:libvir-list-boun...@redhat.com] On Behalf Of Chen Fan Sent: Wednesday, May 07, 2014 6:12 PM To: libvir-list@redhat.com Subject: [libvirt]

Re: [libvirt] [patch v3 1/2] Add support for migration URI configuration

2014-05-07 Thread chen.fan.f...@cn.fujitsu.com
On Thu, 2014-05-08 at 02:21 +, Wangrui (K) wrote: I think *cfg* should be unref by virObjectUnref(cfg) . And so does patch 2/2. Thanks for pointing this out! I will fix this and post them soon. Thanks, Chen -Original Message- From: libvir-list-boun...@redhat.com