[libvirt] [PATCH 3/3] Parallels: Include CPU info in the capabilities XML

2014-06-04 Thread Alexander Burluka
From: A.Burluka Openstack uses (or will start to using) CPU info from the capabilities XML. So this section is expanded, added CPU info about arch, type and info about number of cores, sockets and threads. --- src/parallels/parallels_driver.c | 28 ++-- 1 files changed,

[libvirt] [PATCH 0/3] Parallels: patch set

2014-06-04 Thread Alexander Burluka
From: A.Burluka I've fixed my previous patches after Libvirt community reviews (thanks to Eric Blake and Daniel P. Berrange). Parallels team continues working on Libvirt Parallels driver integration with OpenStack. A.Burluka (3): Parallels: add domainGetVcpus(). Parallels: add connectBasel

[libvirt] [PATCH 1/3] Parallels: add domainGetVcpus().

2014-06-04 Thread Alexander Burluka
From: A.Burluka OpenStack Nova requires this function to start VM instance. Cpumask info is obtained via prlctl utility. Unlike KVM, Parallels Cloud Server is unable to set cpu affinity mask for every VCpu. Mask is unique for all VCpu. You can set it using 'prlctl set --cpumask <{n[,n,n1-n2]|all

[libvirt] [PATCH 2/3] Parallels: add connectBaselineCPU().

2014-06-04 Thread Alexander Burluka
From: A.Burluka Openstack Nova (starting at Icehouse release) requires this function to start VM. --- src/parallels/parallels_driver.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/src/parallels/parallels_driver.c b/src/parallels/parallels_driver.c index

Re: [libvirt] [PATCH V8 2/2] libxl: add migration support

2014-06-04 Thread Jim Fehlig
Daniel P. Berrange wrote: > On Wed, Jun 04, 2014 at 02:35:14PM -0600, Jim Fehlig wrote: > >> This patch adds initial migration support to the libxl driver, >> using the VIR_DRV_FEATURE_MIGRATION_PARAMS family of migration >> functions. >> >> Signed-off-by: Jim Fehlig >> --- >> po/POTFILES.in

[libvirt] [PATCH] maint: detect VPATH builds when checking for gnulib update

2014-06-04 Thread Eric Blake
I accidentally typed 'make' in the srcdir of a VPATH build, and was surprised to see this: $ make /bin/sh: s/^[ +-]//;s/ .*//: No such file or directory INFO: gnulib update required; running ./autogen.sh first make: -n: Command not found ./autogen.sh I am going to run ./configure with no arguments

Re: [libvirt] [PATCH V8 2/2] libxl: add migration support

2014-06-04 Thread Daniel P. Berrange
On Wed, Jun 04, 2014 at 02:35:14PM -0600, Jim Fehlig wrote: > This patch adds initial migration support to the libxl driver, > using the VIR_DRV_FEATURE_MIGRATION_PARAMS family of migration > functions. > > Signed-off-by: Jim Fehlig > --- > po/POTFILES.in | 1 + > src/Makefile.am

Re: [libvirt] [PATCH V8 1/2] libxl: introduce libxlDomainDefCheckABIStability

2014-06-04 Thread Daniel P. Berrange
On Wed, Jun 04, 2014 at 02:35:13PM -0600, Jim Fehlig wrote: > Introduce a simple libxlDomainDefCheckABIStability() function that > can be used check ABI stability between two virDomainDef objects. > > Signed-off-by: Jim Fehlig > --- > src/libxl/libxl_domain.c | 23 +++ > src/

Re: [libvirt] [PATCH 2/4] interface_backend_udev: Implement link speed & state

2014-06-04 Thread Daniel P. Berrange
On Tue, Jun 03, 2014 at 02:22:10PM +0200, Michal Privoznik wrote: > In previous commit the interface XML is prepared for exporting > information on NIC link speed and state. This commit implement > actual logic for getting such info and writing it into XML. > > Signed-off-by: Michal Privoznik > -

Re: [libvirt] [PATCH 1/4] virInterface: Expose link state & speed

2014-06-04 Thread Daniel P. Berrange
On Tue, Jun 03, 2014 at 02:22:09PM +0200, Michal Privoznik wrote: > Currently it is not possible to determine the speed of an interface > and whether a link is actually detected from the API. Orchestrating > platforms want to be able to determine when the link has failed and > where multiple speeds

Re: [libvirt] [PATCH V7] libxl: add migration support

2014-06-04 Thread Jim Fehlig
Daniel P. Berrange wrote: > On Thu, May 08, 2014 at 03:56:51PM -0600, Jim Fehlig wrote: > >> This patch adds initial migration support to the libxl driver, >> using the VIR_DRV_FEATURE_MIGRATION_PARAMS family of migration >> functions. >> >> Signed-off-by: Jim Fehlig >> --- >> >> V6 here >> h

[libvirt] [PATCH V8 0/2] libxl: add migration support

2014-06-04 Thread Jim Fehlig
V7 here https://www.redhat.com/archives/libvir-list/2014-May/msg00301.html In V8: - Set freed resources to NULL/0. - Add libxlDomainDefCheckABIStability() function to do simple ABI stability checks of two virDomainDef objects. Jim Fehlig (2): libxl: introduce libxlDomainDefCheckABIStability

[libvirt] [PATCH V8 2/2] libxl: add migration support

2014-06-04 Thread Jim Fehlig
This patch adds initial migration support to the libxl driver, using the VIR_DRV_FEATURE_MIGRATION_PARAMS family of migration functions. Signed-off-by: Jim Fehlig --- po/POTFILES.in | 1 + src/Makefile.am | 3 +- src/libxl/libxl_conf.h | 6 + src/libxl/libxl_d

[libvirt] [PATCH V8 1/2] libxl: introduce libxlDomainDefCheckABIStability

2014-06-04 Thread Jim Fehlig
Introduce a simple libxlDomainDefCheckABIStability() function that can be used check ABI stability between two virDomainDef objects. Signed-off-by: Jim Fehlig --- src/libxl/libxl_domain.c | 23 +++ src/libxl/libxl_domain.h | 5 + 2 files changed, 28 insertions(+) diff -

Re: [libvirt] [PATCH] cfg.mk: Introduce rule for setlocale()

2014-06-04 Thread Eric Blake
On 06/04/2014 10:24 AM, Michal Privoznik wrote: >> +# Require #include in all files that call setlocale() +sc_require_locale_h: +@for i in $$($(VC_LIST_EXCEPT) | grep '\.[chx]$$'); do\ +if test -z "$$(grep setlocale $$i)" ; then continue; fi;\

Re: [libvirt] Parse commandline for -device option

2014-06-04 Thread Daniel P. Berrange
On Wed, Jun 04, 2014 at 10:27:32AM -0600, Eric Blake wrote: > On 06/04/2014 03:07 AM, hong-hua@freescale.com wrote: > > Hi Maintainers, > > > > Currently libvirt could only parse commandline for several legacy devices. > > For example, > > -pcidevice: qemuParseCommandLinePCI() > > -usb

Re: [libvirt] Parse commandline for -device option

2014-06-04 Thread Eric Blake
On 06/04/2014 03:07 AM, hong-hua@freescale.com wrote: > Hi Maintainers, > > Currently libvirt could only parse commandline for several legacy devices. > For example, > -pcidevice: qemuParseCommandLinePCI() > -usbdevice: qemuParseCommandLineUSB() Yes, the domxml-from-native functio

Re: [libvirt] [PATCH] cfg.mk: Introduce rule for setlocale()

2014-06-04 Thread Michal Privoznik
On 04.06.2014 18:21, Eric Blake wrote: On 06/04/2014 03:15 AM, Martin Kletzander wrote: On Wed, Jun 04, 2014 at 10:59:08AM +0200, Michal Privoznik wrote: In the past we had some issues where setlocale() was called without corresponding include of locale.h. While on some systems this may work, o

Re: [libvirt] [PATCH] cfg.mk: Introduce rule for setlocale()

2014-06-04 Thread Eric Blake
On 06/04/2014 03:15 AM, Martin Kletzander wrote: > On Wed, Jun 04, 2014 at 10:59:08AM +0200, Michal Privoznik wrote: >> In the past we had some issues where setlocale() was called without >> corresponding include of locale.h. While on some systems this may >> work, on others the compilation failed.

Re: [libvirt] [PATCH v2] maint: prohibit empty first lines

2014-06-04 Thread Eric Blake
On 06/04/2014 07:01 AM, Martin Kletzander wrote: > Based on discussion with Eric: > > https://www.redhat.com/archives/libvir-list/2014-March/msg01001.html > > Signed-off-by: Martin Kletzander > --- > v2: > - rebase on current master and s/FILENAME:1:/FILENAME ":1:"/ > > cfg.mk | 7 +++ >

Re: [libvirt] [PATCH 2/2] formatcaps: Rework and add stubs to document

2014-06-04 Thread Eric Blake
On 06/04/2014 09:34 AM, Michal Privoznik wrote: > At the moment we are missing even basic documentation on our > capabilities XML. Without demand on completeness, I'm > reorganizing the document structure and adding very basic > documentation to two major components of the capabilities XML. > These

Re: [libvirt] [PATCH v2] maint: prohibit empty first lines

2014-06-04 Thread Michal Privoznik
On 04.06.2014 15:01, Martin Kletzander wrote: Based on discussion with Eric: https://www.redhat.com/archives/libvir-list/2014-March/msg01001.html Signed-off-by: Martin Kletzander --- v2: - rebase on current master and s/FILENAME:1:/FILENAME ":1:"/ cfg.mk | 7 +++ 1 file changed, 7 in

Re: [libvirt] [PATCH RFC] Add support for QEMU vhost-user feature

2014-06-04 Thread Daniel P. Berrange
On Wed, May 28, 2014 at 10:46:27AM +0200, Luke Gorrie wrote: > vhost-user is a networking backend based on unix domain sockets > instead of tap devices and ioctl(). This makes it possible for > userspace networking stacks (vswitches) to provide vhost-networking to > guests. > > Signed-off-by: Luke

Re: [libvirt] [PATCH RFC] Add support for QEMU vhost-user feature

2014-06-04 Thread Daniel P. Berrange
On Wed, May 28, 2014 at 10:46:27AM +0200, Luke Gorrie wrote: > vhost-user is a networking backend based on unix domain sockets > instead of tap devices and ioctl(). This makes it possible for > userspace networking stacks (vswitches) to provide vhost-networking to > guests. > > Signed-off-by: Luke

[libvirt] [PATCH 2/2] formatcaps: Rework and add stubs to document

2014-06-04 Thread Michal Privoznik
At the moment we are missing even basic documentation on our capabilities XML. Without demand on completeness, I'm reorganizing the document structure and adding very basic documentation to two major components of the capabilities XML. These stubs are intended to be enhanced in the future. Signed-

[libvirt] [PATCH 0/2] Couple of virCaps improvements

2014-06-04 Thread Michal Privoznik
Literally couple. As usual, the aim is not completeness, but to prepare environment for future work (if somebody is willing to contribute patches). Michal Privoznik (2): vircapstest: Introduce basic testing formatcaps: Rework and add stubs to document docs/formatcaps.html.in | 1

[libvirt] [PATCH 1/2] vircapstest: Introduce basic testing

2014-06-04 Thread Michal Privoznik
For now only one test is introduced. It's purpose in life is to check we don't break NUMA host distances XML format. Signed-off-by: Michal Privoznik --- tests/vircapsdata/vircaps-basic.xml | 66 +++ tests/vircapstest.c | 77

Re: [libvirt] [PATCH 6/6] qemu: pass numa node binding preferences to qemu

2014-06-04 Thread Daniel P. Berrange
On Wed, Jun 04, 2014 at 04:56:32PM +0200, Martin Kletzander wrote: > diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c > index b1bfb5a..6415a6d 100644 > --- a/src/qemu/qemu_cgroup.c > +++ b/src/qemu/qemu_cgroup.c > @@ -930,8 +932,15 @@ qemuSetupCgroupForVcpu(virDomainObjPtr vm) >

Re: [libvirt] [PATCH 2/6] conf, schema: add support for numatune memnode element

2014-06-04 Thread Martin Kletzander
On Wed, Jun 04, 2014 at 04:07:06PM +0100, Daniel P. Berrange wrote: On Wed, Jun 04, 2014 at 04:56:28PM +0200, Martin Kletzander wrote: @@ -43,9 +43,17 @@ typedef virNumaTuneDef *virNumaTuneDefPtr; struct _virNumaTuneDef { struct { virBitmapPtr nodemask; -int mode; +

Re: [libvirt] Problem connecting to hypervisor.

2014-06-04 Thread Jim Fehlig
Vikas Kokare wrote: > I am trying to establish a connection (using virsh command) to a > couple of hypervisor hosts, both on SLES 11.3 environments. The host > from where i am making both the connections is a SLES 10.4 instance. Hi Vikas, FYI, this list is for discussing upstream libvirt developm

Re: [libvirt] [PATCH 5/6] qemu: memory-ram capability probing

2014-06-04 Thread Daniel P. Berrange
On Wed, Jun 04, 2014 at 04:56:31PM +0200, Martin Kletzander wrote: > The numa patch series in qemu adds "memory-ram" object type by which > we can tell whether we can use such objects. > > Signed-off-by: Martin Kletzander > --- > src/qemu/qemu_capabilities.c | 2 ++ > src/qemu/qemu_capabilities.

Re: [libvirt] [PATCH 4/6] qemu: purely a code movement

2014-06-04 Thread Daniel P. Berrange
On Wed, Jun 04, 2014 at 04:56:30PM +0200, Martin Kletzander wrote: > to ease the review of commits to follow. > > Signed-off-by: Martin Kletzander > --- > src/qemu/qemu_command.c | 25 ++--- > 1 file changed, 14 insertions(+), 11 deletions(-) ACK Regards, Daniel -- |: htt

Re: [libvirt] [PATCH 3/6] conf: add virDomainGetMemsForGuestCpu()

2014-06-04 Thread Daniel P. Berrange
On Wed, Jun 04, 2014 at 04:56:29PM +0200, Martin Kletzander wrote: > Signed-off-by: Martin Kletzander > --- > src/conf/domain_conf.c | 39 +++ > src/conf/domain_conf.h | 4 > src/libvirt_private.syms | 1 + > 3 files changed, 44 insertions(+) ACK

[libvirt] [PATCH RFC] network: Bring netdevs online later

2014-06-04 Thread Matthew Rosato
Defer MAC registration until net devices are actually going to be used by the guest. This patch does so by setting the devices online just before starting guest CPUs. This approach is an alternative to my previously proposed 'network: Defer online of macvtap during qemu migration' Laine/Wangrui,

Re: [libvirt] [PATCH 2/6] conf, schema: add support for numatune memnode element

2014-06-04 Thread Daniel P. Berrange
On Wed, Jun 04, 2014 at 04:56:28PM +0200, Martin Kletzander wrote: > This element specifies similar settings as the memory element, > although memnode can be used per guest NUMA node. > > Signed-off-by: Martin Kletzander > --- > docs/formatdomain.html.in | 15 +++ > docs/schemas/domaincommo

Re: [libvirt] [PATCH 1/6] conf, schema: add 'id' field for cells

2014-06-04 Thread Daniel P. Berrange
On Wed, Jun 04, 2014 at 04:56:27PM +0200, Martin Kletzander wrote: > In XML format, by definition, order of fields should not matter, so > oder of parsing the elements doesn't affect the end result. When > specifying guest NUMA cells, we depend only on the order of the 'cell' > elements. With thi

Re: [libvirt] [PATCH 2/6] conf, schema: add support for numatune memnode element

2014-06-04 Thread Daniel P. Berrange
On Wed, Jun 04, 2014 at 04:56:28PM +0200, Martin Kletzander wrote: > @@ -43,9 +43,17 @@ typedef virNumaTuneDef *virNumaTuneDefPtr; > struct _virNumaTuneDef { > struct { > virBitmapPtr nodemask; > -int mode; > +int mode; /* enum virDomainNumatuneMemMode */ >

[libvirt] [PATCH 5/6] qemu: memory-ram capability probing

2014-06-04 Thread Martin Kletzander
The numa patch series in qemu adds "memory-ram" object type by which we can tell whether we can use such objects. Signed-off-by: Martin Kletzander --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + 2 files changed, 3 insertions(+) diff --git a/src/qemu/qemu_capabilitie

[libvirt] [PATCH 0/6] Support for per-guest-node binding

2014-06-04 Thread Martin Kletzander
Currently we are only able to bind the whole domain to some host nodes using the /domain/numatune/memory element. Numerous requests were made to support host<->guest numa node bindings, so this series tries to pinch an idea on how to do that using /domain/numatune/memnode elements. That is incomp

[libvirt] [PATCH 6/6] qemu: pass numa node binding preferences to qemu

2014-06-04 Thread Martin Kletzander
Currently, we only bind the whole QEMU domain to memory nodes specified in nodemask altogether. That, however, doesn't make much sense when one wants to control from where the memory for particular guest nodes should be allocated. QEMU allows us to do that by specifying 'host-nodes' parameter for

[libvirt] [PATCH 2/6] conf, schema: add support for numatune memnode element

2014-06-04 Thread Martin Kletzander
This element specifies similar settings as the memory element, although memnode can be used per guest NUMA node. Signed-off-by: Martin Kletzander --- docs/formatdomain.html.in | 15 +++ docs/schemas/domaincommon.rng | 17 src/conf/domain_conf.c| 220 +++

[libvirt] [PATCH 3/6] conf: add virDomainGetMemsForGuestCpu()

2014-06-04 Thread Martin Kletzander
Signed-off-by: Martin Kletzander --- src/conf/domain_conf.c | 39 +++ src/conf/domain_conf.h | 4 src/libvirt_private.syms | 1 + 3 files changed, 44 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 352ba92..fef956c 1

[libvirt] [PATCH 4/6] qemu: purely a code movement

2014-06-04 Thread Martin Kletzander
to ease the review of commits to follow. Signed-off-by: Martin Kletzander --- src/qemu/qemu_command.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index e6acced..cc6023d 100644 --- a/src/qemu/qem

[libvirt] [PATCH 1/6] conf, schema: add 'id' field for cells

2014-06-04 Thread Martin Kletzander
In XML format, by definition, order of fields should not matter, so oder of parsing the elements doesn't affect the end result. When specifying guest NUMA cells, we depend only on the order of the 'cell' elements. With this patch all older domain XMLs are parsed as before, but with the 'id' attri

Re: [libvirt] [PATCH] virnuma: Check for numa_bitmask_isbitset presence

2014-06-04 Thread Daniel P. Berrange
On Wed, Jun 04, 2014 at 03:14:11PM +0200, Michal Privoznik wrote: > On some systems, libnuma can be present but it's so ancient that > it misses some symbols that virNumaGetDistances() needs. To be > more precise: numa_bitmask_isbitset() and numa_nodes_ptr are the > symbols in question. Fortunately

[libvirt] [PATCH] virnuma: Check for numa_bitmask_isbitset presence

2014-06-04 Thread Michal Privoznik
On some systems, libnuma can be present but it's so ancient that it misses some symbols that virNumaGetDistances() needs. To be more precise: numa_bitmask_isbitset() and numa_nodes_ptr are the symbols in question. Fortunately, they were both introduced in the same release so it's sufficient for us

[libvirt] [PATCH v2] maint: prohibit empty first lines

2014-06-04 Thread Martin Kletzander
Based on discussion with Eric: https://www.redhat.com/archives/libvir-list/2014-March/msg01001.html Signed-off-by: Martin Kletzander --- v2: - rebase on current master and s/FILENAME:1:/FILENAME ":1:"/ cfg.mk | 7 +++ 1 file changed, 7 insertions(+) diff --git a/cfg.mk b/cfg.mk index 675

Re: [libvirt] [RFC] Atomic Operations

2014-06-04 Thread Martin Kletzander
On Wed, Jun 04, 2014 at 08:16:16AM -0400, Tucker DiNapoli wrote: I'm working on job control which involves a lot of locking and unlocking, often for operations that could be done atomically. I use the existing atomic integer operations in viratomic.h where possible, but there are a lot of paramet

Re: [libvirt] [libvirt-sandbox] virt-sandbox-service: fixed /lib/ into /usr/lib for searching unit files

2014-06-04 Thread Daniel P. Berrange
On Wed, Jun 04, 2014 at 02:22:05PM +0200, Cedric Bosdonnat wrote: > On Wed, 2014-06-04 at 12:51 +0100, Daniel P. Berrange wrote: > > On Wed, Jun 04, 2014 at 01:24:17PM +0200, Cedric Bosdonnat wrote: > > > On Wed, 2014-06-04 at 11:24 +0200, Christophe Fergeau wrote: > > > > On Tue, May 13, 2014 at 1

Re: [libvirt] [RFC] Atomic Operations

2014-06-04 Thread Daniel P. Berrange
On Wed, Jun 04, 2014 at 08:16:16AM -0400, Tucker DiNapoli wrote: > I'm working on job control which involves a lot of locking and unlocking, > often for operations that could be done atomically. I use the existing > atomic integer operations in viratomic.h where possible, but there are a > lot of p

Re: [libvirt] [libvirt-sandbox] virt-sandbox-service: fixed /lib/ into /usr/lib for searching unit files

2014-06-04 Thread Cedric Bosdonnat
On Wed, 2014-06-04 at 12:51 +0100, Daniel P. Berrange wrote: > On Wed, Jun 04, 2014 at 01:24:17PM +0200, Cedric Bosdonnat wrote: > > On Wed, 2014-06-04 at 11:24 +0200, Christophe Fergeau wrote: > > > On Tue, May 13, 2014 at 10:10:36AM +0200, Cédric Bosdonnat wrote: > > > > --- > > > > bin/virt-san

[libvirt] [RFC] Atomic Operations

2014-06-04 Thread Tucker DiNapoli
I'm working on job control which involves a lot of locking and unlocking, often for operations that could be done atomically. I use the existing atomic integer operations in viratomic.h where possible, but there are a lot of parameters involved in jobs (such as time, thread id's, progress informati

Re: [libvirt] [libvirt-sandbox] virt-sandbox-service: fixed /lib/ into /usr/lib for searching unit files

2014-06-04 Thread Daniel P. Berrange
On Wed, Jun 04, 2014 at 01:24:17PM +0200, Cedric Bosdonnat wrote: > On Wed, 2014-06-04 at 11:24 +0200, Christophe Fergeau wrote: > > On Tue, May 13, 2014 at 10:10:36AM +0200, Cédric Bosdonnat wrote: > > > --- > > > bin/virt-sandbox-service | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-

Re: [libvirt] [libvirt-sandbox] virt-sandbox-service: fixed /lib/ into /usr/lib for searching unit files

2014-06-04 Thread Christophe Fergeau
On Wed, Jun 04, 2014 at 01:24:17PM +0200, Cedric Bosdonnat wrote: > On Wed, 2014-06-04 at 11:24 +0200, Christophe Fergeau wrote: > > On Tue, May 13, 2014 at 10:10:36AM +0200, Cédric Bosdonnat wrote: > > > --- > > > bin/virt-sandbox-service | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-

Re: [libvirt] [libvirt-sandbox] virt-sandbox-service: fixed /lib/ into /usr/lib for searching unit files

2014-06-04 Thread Cedric Bosdonnat
On Wed, 2014-06-04 at 11:24 +0200, Christophe Fergeau wrote: > On Tue, May 13, 2014 at 10:10:36AM +0200, Cédric Bosdonnat wrote: > > --- > > bin/virt-sandbox-service | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/bin/virt-sandbox-service b/bin/virt-sandbox-service

Re: [libvirt] storage conf: Add key-value options to storage pools

2014-06-04 Thread Daniel P. Berrange
On Tue, Jun 03, 2014 at 05:33:13PM +0200, Ján Tomko wrote: > On 05/28/2014 11:38 AM, Wido den Hollander wrote: > > This series of patches adds the ability to pass down options to the > > storage pool drivers. > > > > In the case of NFS users can specify mount options and in the case of > > RBD use

Re: [libvirt] storage conf: Add key-value options to storage pools

2014-06-04 Thread Michael Chapman
On Tue, 3 Jun 2014, Ján Tomko wrote: On 05/28/2014 11:38 AM, Wido den Hollander wrote: This series of patches adds the ability to pass down options to the storage pool drivers. In the case of NFS users can specify mount options and in the case of RBD users can specify options for librados to in

[libvirt] [PATCH] virnuma: Implement virNumaGetDistances stub for non-NUMA

2014-06-04 Thread Michal Privoznik
In case the libvirt is built without numactl support, we're missing the virNumaGetDistances() stub so the linking fails: CCLD libvirt_lxc libvirt_lxc-nodeinfo.o: In function `virNodeCapsGetSiblingInfo': /home/zippy/tmp/libvirt.git/src/nodeinfo.c:1763: undefined reference to `virNumaGetDista

[libvirt] [PATCHv4 3/4] virsh: Reject negative numbers in vshCommandOptULongLong

2014-06-04 Thread Peter Krempa
To follow the new semantics of the vshCommandOptToU* functions convert this one to reject negative numbers too. To allow using -1 for "maximum" semantics for the vol-*load two bandwidth functions that use this helper introduce vshCommandOptULongLongWrap. --- tools/virsh-volume.c | 8 too

[libvirt] [PATCHv4 0/4] virsh: Clean unsigned value parsing

2014-06-04 Thread Peter Krempa
Jincheng Miao (1): virsh: forbid negative vcpu argument to vcpupin Peter Krempa (3): virsh: Reject negative numbers in vshCommandOptUInt virsh: Reject negative numbers in vshCommandOptUL virsh: Reject negative numbers in vshCommandOptULongLong tests/vcpupin| 29 ++- tool

[libvirt] [PATCHv4 2/4] virsh: Reject negative numbers in vshCommandOptUL

2014-06-04 Thread Peter Krempa
To follow the new semantics of the vshCommandOptToU* functions convert this one to reject negative numbers too. To allow using -1 for "maximum" semantics for the two bandwidth functions that use this helper introduce vshCommandOptULWrap. Although currently the migrate-setspeed function for the qemu

[libvirt] [PATCHv4 4/4] virsh: forbid negative vcpu argument to vcpupin

2014-06-04 Thread Peter Krempa
From: Jincheng Miao The vcpupin command allowed specifying a negative number for the --vcpu argument. This would the overflow when the underlying virDomainPinVcpu API was called. $ virsh vcpupin r7 -1 0 error: numerical overflow: input too large: 4294967295 Switch the vCPU variable to a unsig

[libvirt] [PATCHv4 1/4] virsh: Reject negative numbers in vshCommandOptUInt

2014-06-04 Thread Peter Krempa
Use virStrToLong_uip instead of virStrToLong_ui to reject negative numbers in the helper. None of the callers expects the wraparound "feature" for negative numbers. Also add a function that allows wrapping of negative numbers as it might be used in the future and be explicit about the new semantic

Re: [libvirt] libvirt, libxl and

2014-06-04 Thread Daniel P. Berrange
On Wed, Jun 04, 2014 at 09:11:59AM +, Dave Scott wrote: > Hi, > > Two of the applications I’d like to use with libvirt (cloudstack > and oVirt) make use of “” in the domain XML, like this: > > > > > > > > I don’t believe these are currently supported by libvirt + libxl > — I’d like to s

[libvirt] libvirt, libxl and

2014-06-04 Thread Dave Scott
Hi, Two of the applications I’d like to use with libvirt (cloudstack and oVirt) make use of “” in the domain XML, like this: I don’t believe these are currently supported by libvirt + libxl — I’d like to see what it would take to hook these up. I chatted with Daniel Berrange at the Xen h

Re: [libvirt] [libvirt-sandbox] virt-sandbox-service: fixed /lib/ into /usr/lib for searching unit files

2014-06-04 Thread Christophe Fergeau
On Tue, May 13, 2014 at 10:10:36AM +0200, Cédric Bosdonnat wrote: > --- > bin/virt-sandbox-service | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/bin/virt-sandbox-service b/bin/virt-sandbox-service > index 2dcbfb8..9ed37e0 100755 > --- a/bin/virt-sandbox-service > +++ b/

Re: [libvirt] [libvirt-glib] spec: Move .vapi files to -devel RPMs

2014-06-04 Thread Christophe Fergeau
On Tue, Jun 03, 2014 at 03:00:17PM +0100, Daniel P. Berrange wrote: > On Tue, Jun 03, 2014 at 03:50:50PM +0200, Christophe Fergeau wrote: > > .vapi files are only needed when building vala programs using > > libvirt-glib, so they belong to the -devel RPMs, not to the non-devel > > RPMs which only h

Re: [libvirt] [PATCH] cfg.mk: Introduce rule for setlocale()

2014-06-04 Thread Martin Kletzander
On Wed, Jun 04, 2014 at 10:59:08AM +0200, Michal Privoznik wrote: In the past we had some issues where setlocale() was called without corresponding include of locale.h. While on some systems this may work, on others the compilation failed. We should have a syntax-check rule for that to prevent th

Re: [libvirt] [libvirt-glib] [PATCH] build: fix race in vapi/ subdirectory

2014-06-04 Thread Christophe Fergeau
On Mon, Jun 02, 2014 at 05:23:00PM -0500, Michael Catanzaro wrote: > On Mon, 2014-06-02 at 16:12 -0600, Eric Blake wrote: > > This hit the list with line-wrapping , making it a bit harder to tell > > what changed. > > Sorry, patch attached to avoid line wrapping. I have pushed this patch Christ

[libvirt] Parse commandline for -device option

2014-06-04 Thread hong-hua....@freescale.com
Hi Maintainers, Currently libvirt could only parse commandline for several legacy devices. For example, -pcidevice: qemuParseCommandLinePCI() -usbdevice: qemuParseCommandLineUSB() It also provides test cases for host device assignment. DO_TEST("hostdev-usb-address"); DO_TE

[libvirt] [PATCH] cfg.mk: Introduce rule for setlocale()

2014-06-04 Thread Michal Privoznik
In the past we had some issues where setlocale() was called without corresponding include of locale.h. While on some systems this may work, on others the compilation failed. We should have a syntax-check rule for that to prevent this from happening again. Signed-off-by: Michal Privoznik --- cfg.

[libvirt] Problem connecting to hypervisor.

2014-06-04 Thread Vikas Kokare
I am trying to establish a connection (using virsh command) to a couple of hypervisor hosts, both on SLES 11.3 environments. The host from where i am making both the connections is a SLES 10.4 instance. *kvmh911351246:~ # virsh -c qemu+ssh://9.113.51.247:22/system

Re: [libvirt] [libvirt-sandbox PATCH] virt-sandbox-service: fixed /lib/ into /usr/lib for searching unit files

2014-06-04 Thread Cedric Bosdonnat
Hi all, Is that patch now burried too far away in the mail stack? Could someone review it? -- Cedric On Tue, 2014-05-13 at 10:10 +0200, Cédric Bosdonnat wrote: > --- > bin/virt-sandbox-service | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/bin/virt-sandbox-service b/b