The kernel's more broken than one would think. Various drivers report
various (usually spurious) values if the interface is down. While on
some we experience -EINVAL when read()-ing the speed sysfs file, with
other drivers we might get anything from 0 to UINT_MAX. If that's the
case it's better to
>>>Jim Fehlig wrote:
> Bamvor Jian Zhang wrote:
>> e.g. for these following disk configuration in libvirt.
>>
>
> For Xen, using (which means qdisk) is only
> supported by the libxl driver. The old xm/xend stack does not support qdisk.
>
>>
>>
>>
>>
>>
On 06/11/2014 05:45 AM, Peter Krempa wrote:
> When the test is failing but the debug output isn't enabled the
> resulting line would look ugly like and would not contain the actual
> difference.
>
> TEST: virstoragetest
> .chain member 1!chain member 1!chain member 1!
>
> St
On 06/12/2014 06:18 AM, Zvi Dubitzky wrote:
> Hi
>
>
> I am looking for libvirt user mailing list (Red Hat ) but could not find
> one .
http://libvirt.org/contact.html mentions libvirt-us...@redhat.com
>
> So I am using this list (or maybe someone can direct me to such a list).
>
> The pro
On 06/12/2014 06:01 AM, Peter Krempa wrote:
> On 06/11/14 18:27, Eric Blake wrote:
>> With this in place, I can (finally!) now do:
>>
>> virsh blockcommit $dom vda --shallow --wait --verbose --pivot
>>
>> -/* FIXME: qemu 2.0 supports active commit, but as a two-stage
>> - * process; qemu 2
On 06/12/2014 05:51 AM, Peter Krempa wrote:
> On 06/11/14 18:27, Eric Blake wrote:
>> A future patch is going to wire up qemu active block commit jobs;
>> but as they have similar events and are canceled/pivoted in the
>> same way as block copy jobs, it is easiest to track all bookkeeping
>> for th
On 06/12/2014 03:21 AM, Peter Krempa wrote:
> On 06/11/14 18:27, Eric Blake wrote:
>> A future patch will add two-phase block commit jobs; as the
>> mechanism for managing them is similar to managing a block copy
>> job, existing errors should be made generic enough to occur
>> for either job type.
[warning - long email ahead. tl;dr: this patch is not ready yet, because
I found a problem in the design]
On 06/12/2014 09:02 AM, Peter Krempa wrote:
> Until now we were changing information about the disk source via
> multiple steps of copying data. Now that we changed to a pointer to
> store the
Bamvor Jian Zhang wrote:
> e.g. for these following disk configuration in libvirt.
>
For Xen, using (which means qdisk) is only
supported by the libxl driver. The old xm/xend stack does not support qdisk.
>
>
>
>
> without this patch, it will be
> "qemu:/var/lib
On 06/12/2014 09:02 AM, Peter Krempa wrote:
> Now that we have pointers to store disk source information and thus can
> easily exchange the structs behind we need a function to copy all the
> data.
> ---
> src/libvirt_private.syms | 1 +
> src/util/virstoragefile.c | 150
>
On 06/12/2014 09:02 AM, Peter Krempa wrote:
> It will also be reused later.
> ---
> src/util/virstoragefile.c | 16
> 1 file changed, 12 insertions(+), 4 deletions(-)
>
> +static void
> +virStoragePermsFree(virStoragePermsPtr def)
> +{
> +if (!def)
> +return;
> +
> +
On 06/12/2014 09:02 AM, Peter Krempa wrote:
> ---
> src/util/virseclabel.c | 22 ++
> src/util/virseclabel.h | 5 -
> 2 files changed, 26 insertions(+), 1 deletion(-)
>
> +++ b/src/util/virseclabel.c
> @@ -80,3 +80,25 @@ virSecurityDeviceLabelDefNew(const char *model)
>
On 06/12/2014 09:02 AM, Peter Krempa wrote:
> ---
> src/util/virstorageencryption.c | 39 +++
> src/util/virstorageencryption.h | 2 ++
> 2 files changed, 41 insertions(+)
I've definitely been wishing for this; as our struct gets more
complicated, piece-wise t
On Thu, Jun 12, 2014 at 02:30:50PM +0100, Daniel P. Berrange wrote:
On Tue, Jun 10, 2014 at 07:21:12PM +0200, Michal Privoznik wrote:
There are two places where you'll find info on huge pages. The first
one is under element, where all supported huge page sizes are
listed. Then the second one is
On 06/12/2014 09:48 AM, Puneet Bakshi wrote:
>
> 1. Whenever a new guest VM is created, take (predefined) RPM packages from
> host to guest VM and install them.
Install them before starting the guest - libguestfs is your friend.
>
> 2. Start a script in guest VM (at certain events).
>
> 3. St
I understand your point, Eric and Daniel. Let me rephrase my problem
statement. Please suggest me how can I address them.
I have a project environment where guest VMs are getting created and
destroyed based on some (irrelevant) parameters (these guest VMs are
instantiated with QEMU guest agent run
On 06/12/2014 02:45 AM, Peter Krempa wrote:
> On 06/11/14 18:27, Eric Blake wrote:
>> Peter's review of my addition of active block commit pointed out
>> some issues that I had copied from block copy. It makes sense to
>> allow the shorter command-line of 'blockcopy $dom $disk --pivot'
>> without
On 06/11/2014 10:27 AM, Eric Blake wrote:
> A future patch is going to wire up qemu active block commit jobs;
> but as they have similar events and are canceled/pivoted in the
> same way as block copy jobs, it is easiest to track all bookkeeping
> for the commit job by reusing the element. This p
diff to v1:
-Matin's review suggestions worked in
-I've found that (testing this on my new HW) that some PCI-Express devices
doesn't have to necessarily export link info. That's why I'm inventing this
virPCIDeviceHasPCIExpressLink() which tells us if that's the case. So for a PCI
Express device
These functions will handle PCIe devices and their link capabilities
to query some info about it.
Signed-off-by: Michal Privoznik
---
src/libvirt_private.syms | 3 ++
src/util/virpci.c| 96 +++-
src/util/virpci.h| 8
3 files chan
This new element is there to represent PCI-Express capabilities
of a PCI devices, like link speed, number of lanes, etc.
Signed-off-by: Michal Privoznik
---
docs/formatnode.html.in| 19 +++
docs/schemas/nodedev.rng | 26
src/conf/node_
On 06/12/2014 09:02 AM, Puneet Bakshi wrote:
[once again, please don't top-post]
> If I add following channel in guest VM's xml file
>
>
>
>
>
>
>
Yes, that's how you set up a guest agent.
>
> Would it be possible to use virtio org.qemu.guest_agent.0 for
Until now we were changing information about the disk source via
multiple steps of copying data. Now that we changed to a pointer to
store the disk source we might use it to change the approach to track
the data.
Additionally this will allow proper tracking of the backing chain.
---
src/qemu/qemu
Now that we have pointers to store disk source information and thus can
easily exchange the structs behind we need a function to copy all the
data.
---
src/libvirt_private.syms | 1 +
src/util/virstoragefile.c | 150 ++
src/util/virstoragefile.h | 2
It will also be reused later.
---
src/util/virstoragefile.c | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
index 0792dd8..67c1471 100644
--- a/src/util/virstoragefile.c
+++ b/src/util/virstoragefile.c
@@ -
---
src/util/virstorageencryption.c | 39 +++
src/util/virstorageencryption.h | 2 ++
2 files changed, 41 insertions(+)
diff --git a/src/util/virstorageencryption.c b/src/util/virstorageencryption.c
index 1306490..f750642 100644
--- a/src/util/virstorageencryp
Now that we track storage source as a pointer we might use this.
Note that this is currently work in progress as I've didn't check all code
paths and whether it's safe to modify the backing chains as I did.
Peter Krempa (5):
storage: encryption: Add deep copy function for storage encryption
---
src/util/virseclabel.c | 22 ++
src/util/virseclabel.h | 5 -
2 files changed, 26 insertions(+), 1 deletion(-)
diff --git a/src/util/virseclabel.c b/src/util/virseclabel.c
index 5a4d78e..93c12cc 100644
--- a/src/util/virseclabel.c
+++ b/src/util/virseclabel.c
@@ -80,3
If I add following channel in guest VM's xml file
Would it be possible to use virtio org.qemu.guest_agent.0 for such
communication between host and guest? If yes, how can we do it?
Regards,
~Puneet
On Thu, Jun 12, 2014 at 8:20 PM, Eric Blake wrote:
> On
On 06/12/2014 08:38 AM, Puneet Bakshi wrote:
> Thanks for responding.
[Please don't top-post on technical lists]
>
> Since I want to work with online guests, unfortunately libguestfs is not an
> option for me. (Otherwise, I might have used virt-copy-in to copy the files
> into guest).
>
> But,
Thanks for responding.
Since I want to work with online guests, unfortunately libguestfs is not an
option for me. (Otherwise, I might have used virt-copy-in to copy the files
into guest).
But, for my understanding, please let me know how such things can be done
in QEMU environment. Basically, how
On Thu, Jun 12, 2014 at 04:15:01PM +0530, Puneet Bakshi wrote:
> Hi,
>
> I want to be able to install RPM packages (available in host system at some
> path) to the guest VM and want this facility to be available as a tool.
>
> I am thinking of having a gemu guest agent (qemu-ga) running inside gu
On 06/12/2014 07:59 AM, Daniel P. Berrange wrote:
> On Thu, Jun 12, 2014 at 04:15:01PM +0530, Puneet Bakshi wrote:
>> Hi,
>>
>> I want to be able to install RPM packages (available in host system at some
>> path) to the guest VM and want this facility to be available as a tool.
Libguestfs can alre
Hi,
I want to be able to install RPM packages (available in host system at some
path) to the guest VM and want this facility to be available as a tool.
I am thinking of having a gemu guest agent (qemu-ga) running inside guest
VM. I did not find any available command ("virsh qemu-agent-command
..
Hi
I am looking for libvirt user mailing list (Red Hat ) but could not find
one .
So I am using this list (or maybe someone can direct me to such a list).
The problem: using libvirt under openstack I encounter a problem when
launching a VM with multiple partitions (2 G image)
While a si
On Tue, Jun 10, 2014 at 07:21:12PM +0200, Michal Privoznik wrote:
> There are two places where you'll find info on huge pages. The first
> one is under element, where all supported huge page sizes are
> listed. Then the second one is under each element which refers
> to concrete NUMA node. At thi
On Tue, Jun 10, 2014 at 07:21:15PM +0200, Michal Privoznik wrote:
> Signed-off-by: Michal Privoznik
> ---
> src/qemu/qemu_driver.c | 43 +++
> 1 file changed, 43 insertions(+)
This should probably live in nodeinfo.c and be shared across QEMU,
lxc and uml
On Tue, Jun 10, 2014 at 07:21:11PM +0200, Michal Privoznik wrote:
> For future work we need two functions that fetches total number of
> huge pages and number of free pages for given numa node and page size
> (virNumaGetHugePageInfo()).
>
> Then we need to learn which huge pages are supported on g
On Tue, Jun 10, 2014 at 07:21:13PM +0200, Michal Privoznik wrote:
> The aim of the API is to get information on number of free huge
> pages on the system. The API behaves similar to the
> virNodeGetCellsFreeMemory(). User passes starting NUMA cell, the
> count of nodes that he's interested in, huge
On Tue, Jun 10, 2014 at 07:21:11PM +0200, Michal Privoznik wrote:
> For future work we need two functions that fetches total number of
> huge pages and number of free pages for given numa node and page size
> (virNumaGetHugePageInfo()).
>
> Then we need to learn which huge pages are supported on g
On Thu, Jun 12, 2014 at 12:08:08PM +0200, Michal Privoznik wrote:
On 12.06.2014 10:56, Martin Kletzander wrote:
On Fri, Jun 06, 2014 at 12:54:17PM +0200, Michal Privoznik wrote:
These functions will handle PCIe devices and their link capabilities
to query some info about it.
Signed-off-by: Mic
On 06/05/2014 06:39 PM, Michal Privoznik wrote:
> +
> +/* Workaround broken kernel API. If the link is unplugged then
> + * depending on the NIC driver, link speed can be reported as -1.
> + * However, the value is printed out as unsigned integer instead of
> + * sig
On 06/12/2014 06:15 AM, Peter Krempa wrote:
> On 06/12/14 14:12, Eric Blake wrote:
>> Commit f586965 accidentally changed the semantics of the
>> virDomainBlockCommit command; where it previously looked for
>> an explicit top argument from the top of the chain, it now
>> starts from the backing fil
On Thu, Jun 12, 2014 at 11:27:31AM +0200, Michal Privoznik wrote:
With one of my recent patches (1c70277) libvirt's capable of
reporting NUMA node locality for PCI devices. The node ID is
stored in pci_dev.numa_node variable. However, since zero is
valid NUMA node ID, the default is -1 as it is i
On 06/12/14 14:12, Eric Blake wrote:
> Commit f586965 accidentally changed the semantics of the
> virDomainBlockCommit command; where it previously looked for
> an explicit top argument from the top of the chain, it now
> starts from the backing file of the top. Of course, until
> we allow active
On 06/12/14 14:05, Ján Tomko wrote:
> On 06/04/2014 11:43 AM, Peter Krempa wrote:
>> Jincheng Miao (1):
>> virsh: forbid negative vcpu argument to vcpupin
>>
>> Peter Krempa (3):
>> virsh: Reject negative numbers in vshCommandOptUInt
>> virsh: Reject negative numbers in vshCommandOptUL
>> v
Commit f586965 accidentally changed the semantics of the
virDomainBlockCommit command; where it previously looked for
an explicit top argument from the top of the chain, it now
starts from the backing file of the top. Of course, until
we allow active commits, the only difference it makes is in
the
On 06/04/2014 11:43 AM, Peter Krempa wrote:
> Jincheng Miao (1):
> virsh: forbid negative vcpu argument to vcpupin
>
> Peter Krempa (3):
> virsh: Reject negative numbers in vshCommandOptUInt
> virsh: Reject negative numbers in vshCommandOptUL
> virsh: Reject negative numbers in vshCommandO
On 06/11/14 18:27, Eric Blake wrote:
> With this in place, I can (finally!) now do:
>
> virsh blockcommit $dom vda --shallow --wait --verbose --pivot
>
> and watch qemu shorten the backing chain by one, followed by
> libvirt automatically updating the dumpxml output, effectively
> undoing the wor
Could someone please review?
Thanks,
Shiva
On Wed, May 28, 2014 at 6:12 PM, Shivaprasad G Bhat
wrote:
> During guest migration, if the domain xml is bigger than 16384 which is
> easily possible for a guest with good number of disks, message encode fails
> for xdr_remote_domain_migrate_perform3_r
On 06/11/14 18:27, Eric Blake wrote:
> A future patch is going to wire up qemu active block commit jobs;
> but as they have similar events and are canceled/pivoted in the
> same way as block copy jobs, it is easiest to track all bookkeeping
> for the commit job by reusing the element. This patch
On 12.06.2014 10:56, Martin Kletzander wrote:
On Fri, Jun 06, 2014 at 12:54:17PM +0200, Michal Privoznik wrote:
These functions will handle PCIe devices and their link capabilities
to query some info about it.
Signed-off-by: Michal Privoznik
---
src/libvirt_private.syms | 3 ++
src/util/virpci
On 06/11/2014 09:38 AM, John Ferlan wrote:
> Resolve the "lower hanging fruit" Coverity issues from recent commits.
> Still left outstanding is rework of virVBoxSnapshotConfAllChildren()
> code and callers.
>
> John Ferlan (3):
> vbox_temp: Resolve Coverity warnings
> vbox_snapshot_conf: Re
With one of my recent patches (1c70277) libvirt's capable of
reporting NUMA node locality for PCI devices. The node ID is
stored in pci_dev.numa_node variable. However, since zero is
valid NUMA node ID, the default is -1 as it is in kernel too.
So, if the PCI device is not tied to any specific NUMA
On Fri, Jun 06, 2014 at 12:54:18PM +0200, Michal Privoznik wrote:
This new element is there to represent PCI-Express capabilities
of a PCI devices, like link speed, number of lanes, etc.
Signed-off-by: Michal Privoznik
---
docs/formatnode.html.in| 19
docs/schem
On 06/11/14 18:27, Eric Blake wrote:
> A future patch will add two-phase block commit jobs; as the
> mechanism for managing them is similar to managing a block copy
> job, existing errors should be made generic enough to occur
> for either job type.
>
> * src/conf/domain_conf.c (virDomainHasDiskMi
On 06/12/14 11:06, Ján Tomko wrote:
> qemuDomainGetImageIds did not check if there was a label
> in the seclabel, thus crashing on
>
> ---
> src/qemu/qemu_domain.c | 3 ++-
> src/qemu/qemu_driver.c | 1 +
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
ACK,
Peter
signature.asc
Descript
On 06/11/14 18:27, Eric Blake wrote:
> Add knobs to virsh to manage a 2-phase active commit of the top
> layer, similar to knobs already present on blockcopy. While this
> code will fail until later patches actually implement the new
> knobs in the qemu driver, doing it now proves that the API is
qemuDomainGetImageIds did not check if there was a label
in the seclabel, thus crashing on
---
src/qemu/qemu_domain.c | 3 ++-
src/qemu/qemu_driver.c | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 962698b..e40c5ec 100644
On Fri, Jun 06, 2014 at 12:54:17PM +0200, Michal Privoznik wrote:
These functions will handle PCIe devices and their link capabilities
to query some info about it.
Signed-off-by: Michal Privoznik
---
src/libvirt_private.syms | 3 ++
src/util/virpci.c| 81
This code depends on new API in libvirt-gconfig to extract the
secmodels handled by the host.
---
Diff to v1:
* Adapted the naming change from libvirt-gconfig
libvirt-sandbox/libvirt-sandbox-builder.c | 68 ---
1 file changed, 45 insertions(+), 23 deletions(-)
dif
---
Diff to v1:
* GVirConfigCapabilitiesSecmodel -> GVirConfigCapabilitiesHostSecModel
* Added gvir_config_capabilities_host_secmodel_get_doi
libvirt-gconfig/Makefile.am| 2 +
.../libvirt-gconfig-capabilities-host-secmodel.c | 62 +++
.../libvirt
On 06/11/14 18:27, Eric Blake wrote:
> Peter's review of my addition of active block commit pointed out
> some issues that I had copied from block copy. It makes sense to
> allow the shorter command-line of 'blockcopy $dom $disk --pivot'
> without having to explicitly specify --wait. And my use o
On 06/11/14 19:26, Eric Blake wrote:
> On 06/11/2014 05:45 AM, Peter Krempa wrote:
>> A network disk might actually be backed by local storage. Also the path
>> iterator actually handles networked disks well now so remove the code
>> that skips the labelling in dac and selinux security driver.
>> -
On 06/11/14 17:13, Ján Tomko wrote:
> On 06/05/2014 01:52 PM, Peter Krempa wrote:
>> Add a helper to do all the lookup steps and remove a ton of duplicated
>> code.
>> ---
>> src/storage/storage_driver.c | 292
>> ++-
>> 1 file changed, 69 insertions(+), 22
On 06/11/14 17:12, Ján Tomko wrote:
> On 06/05/2014 01:52 PM, Peter Krempa wrote:
>> Rework internal pool lookup code to avoid printing the raw UUID buffer
>> in the case a storage pool can't be found:
>>
>> $ virsh pool-name e012ace0-0460-5810-39ef-1bce5fa5a4dd
>> error: failed to get pool 'e012
On Do, 2014-06-12 at 07:22 +, Wangrui (K) wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1076098
>
> Zeng Junliang (3):
> For vga/cirrus/vmvga/qxl device, qemu supports commandline
> parameter "vgamem_mb" to specifie the size of the
> framebuffer portion of the "ram" region. As the
Enhance schema and add description for vgamem attribute.
Signed-off-by: Zeng Junliang
Signed-off-by: Wang Rui
---
docs/formatdomain.html.in | 24 ++--
docs/schemas/domaincommon.rng | 5 +
2 files changed, 23 insertions(+), 6 deletions(-)
diff --git a/docs/formatdom
This patch modify test case related to vgamem attribute.
Signed-off-by: Zeng Junliang
Signed-off-by: Wang Rui
---
tests/domainschemadata/domain-parallels-ct-simple.xml| 2 +-
tests/domainschemadata/domain-parallels-vm-simple.xml| 2 +-
.../qemuhotplug-console-compat-2+co
This patch introduces vgamem attribute for video model, and sets
its default value as qemu used. Parse it in two ways accroding to
qemu startup parameters supported: -device or -vga.
Signed-off-by: Zeng Junliang
Signed-off-by: Wang Rui
---
For KVM, vram attribute seems to be invalid for cirrus/v
https://bugzilla.redhat.com/show_bug.cgi?id=1076098
Zeng Junliang (3):
For vga/cirrus/vmvga/qxl device, qemu supports commandline
parameter "vgamem_mb" to specifie the size of the
framebuffer portion of the "ram" region. As the vram attribute
in libvirt is only valid for qxl device in KVM/
On 06/11/2014 03:38 PM, John Ferlan wrote:
> Clean up some Coverity warnings from commit id '4dc5d8f1'
>
> Signed-off-by: John Ferlan
> ---
> src/vbox/vbox_snapshot_conf.c | 27 ++-
> 1 file changed, 18 insertions(+), 9 deletions(-)
>
> diff --git a/src/vbox/vbox_snapsho
On 06/11/2014 03:38 PM, John Ferlan wrote:
> Clean up code to resolve Coverity RESOURCE_LEAK's from commit id's
> '632b9600' and 'b739f807'.
>
> Signed-off-by: John Ferlan
> ---
> src/vbox/vbox_tmpl.c | 10 +-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
ACK
Jan
signature.as
Added in the section of LXC domains
configuration. This section can contain elements named after the
capabilities like:
, keep CAP_MKNOD capability
drop CAP_SYS_CHROOT capability
Users can restrict or give more capabilities than the default using
this mechanism.
---
docs/schemas/domaincom
Hi all,
I had a request from some users to allow keeping the mknod capability in
containers
even thought that may be a security threat for the container and host. After
discussing it with Dan on IRC, here is a patch series that adds a capabilities
XML
element in the features section of the domai
---
src/lxc/lxc_native.c | 27 ++
tests/lxcconf2xmldata/lxcconf2xml-blkiotune.xml| 39
tests/lxcconf2xmldata/lxcconf2xml-cpusettune.xml | 39
tests/lxcconf2xmldata/lxcconf2xml-cputune.xml | 39 ++
---
docs/drvlxc.html.in | 27 +++
1 file changed, 27 insertions(+)
diff --git a/docs/drvlxc.html.in b/docs/drvlxc.html.in
index fc4bc20..4a634c5 100644
--- a/docs/drvlxc.html.in
+++ b/docs/drvlxc.html.in
@@ -540,6 +540,33 @@ debootstrap, whatever) under /opt/vm-1-root:
77 matches
Mail list logo
