Re: [libvirt] [PATCH v3 0/5] Next round of active commit support

2014-06-21 Thread Kashyap Chamarthy
I just tried to test this series built from Eric's libvirt git repo, and QEMU built from its git. On a live (or offline guest) I see the below: $ virsh blockcommit f20vm1 vda --shallow --wait \ --verbose --pivot --active error: unsupported flags (0x4) in function

[libvirt] [PATCH] domain_addr: Resolve Coverity warning

2014-06-21 Thread John Ferlan
Recent changes in the module : http://www.redhat.com/archives/libvir-list/2014-June/msg00978.html seem to have caused Coverity to take a look... The virDomainCCWAddressAsString() API returns either a NULL or a string and the comparison of the returned value to 0 caused following errors: [1]

Re: [libvirt] [Xen-devel] [PATCH] libxl: prefer qdisk for driver name='file'

2014-06-21 Thread Stefano Stabellini
On Fri, 20 Jun 2014, Jim Fehlig wrote: The libxl driver currently sets the disk backend to LIBXL_DISK_BACKEND_TAP when driver name='file' is specified in the disk config. qdisk should be prefered with this configuration, otherwise existing configuration such as the following, which worked

[libvirt] [PATCH] Fix closedir usage in virNumaGetPages

2014-06-21 Thread Roman Bogorodskiy
virNumaGetPages calls closedir(dir) in cleanup and dir could be NULL if we jump there from the failed opendir() call. While it's not harmful on Linux, FreeBSD libc crashes [1], so make sure that dir is not NULL before calling closedir. 1:

[libvirt] [PATCH 1/1] libvirtd crash when defining scsi storage pool

2014-06-21 Thread Pradipta Kr. Banerjee
libvirtd crashes when there is an existing SCSI pool with adapter type as 'scsi_host' and defining a new SCSI pool with adapter type as 'fc_host' and parent attribute missing. For eg when defining a storage-pool with the following XML will crash libvirtd if there already exists a SCSI pool with

Re: [libvirt] [PATCH] Fix closedir usage in virNumaGetPages

2014-06-21 Thread Nehal J Wani
On Sat, Jun 21, 2014 at 8:59 PM, Roman Bogorodskiy bogorods...@gmail.com wrote: virNumaGetPages calls closedir(dir) in cleanup and dir could be NULL if we jump there from the failed opendir() call. While it's not harmful on Linux, FreeBSD libc crashes [1], so make sure that dir is not NULL