Add 'nocow' to storage volume xml so that user can have an option
to set NOCOW flag to the newly created volume. It's useful on btrfs
file system to enhance performance.
Btrfs has low performance when hosting VM images, even more when the guest
in those VM are also using btrfs as file system. One
There is a missing include of $(top_srcdir)/include to handle
libvirt/libvirt.h header file.
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
tools/wireshark/src/Makefile.am | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tools/wireshark/src/Makefile.am
On 07/08/14 09:31, Pavel Hrdina wrote:
There is a missing include of $(top_srcdir)/include to handle
libvirt/libvirt.h header file.
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
tools/wireshark/src/Makefile.am | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
ACK,
Peter
https://bugzilla.redhat.com/show_bug.cgi?id=994731
---
docs/api.html.in | 4
1 file changed, 4 insertions(+)
diff --git a/docs/api.html.in b/docs/api.html.in
index eae7657..68ffa0b 100644
--- a/docs/api.html.in
+++ b/docs/api.html.in
@@ -159,6 +159,10 @@
/ul
/li
/ul
+
In lxc, we could not use setmem command
with --config options.
This patch will add support for this.
Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com
---
v2: use virDomainSetMemoryFlagsEnsureACL
remove redundant domain running check
src/lxc/lxc_driver.c | 48
On 8.7.2014 09:33, Peter Krempa wrote:
On 07/08/14 09:31, Pavel Hrdina wrote:
There is a missing include of $(top_srcdir)/include to handle
libvirt/libvirt.h header file.
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
tools/wireshark/src/Makefile.am | 6 +-
1 file changed, 5
On 07/07/14 22:57, Eric Blake wrote:
On 07/07/2014 06:16 AM, Peter Krempa wrote:
To allow reusing this function in the qemu driver we need to allow to
specify the storage format. Also separate return of the backing store
s/to specify/specifying/
path now isn't necessary.
---
On 07/08/14 00:44, Eric Blake wrote:
On 07/04/2014 05:22 AM, Peter Krempa wrote:
Now that we are able to select images from the backing chain via indexed
access we should also convert possible network sources to
qemu-compatible strings before passing them to qemu.
---
src/qemu/qemu_driver.c
Hi,
When guest agent command guest-fsfreeze-freeze is invoked on a linux VM,
a hook is provided to do execute any pre-script before actually doing a
freeze.
int64_t qmp_guest_fsfreeze_freeze(Error **errp)
{
:::
execute_fsfreeze_hook(FSFREEZE_HOOK_FREEZE, local_err);
:::
}
Can the
ping
-Original Message-
From: libvir-list-boun...@redhat.com [mailto:libvir-list-boun...@redhat.com]
On Behalf Of Chen Hanxiao
Sent: Friday, July 04, 2014 11:10 AM
To: libvir-list@redhat.com
Subject: [libvirt] [PATCH] LXC: fix an improper comments for
lxcDomainDestroyFlags
We only need ip6tables, which is now a part of the iptables package:
http://pkgs.fedoraproject.org/cgit/iptables.git/commit/?h=1392835
This needlessly pulls in iptables-services:
https://bugzilla.redhat.com/show_bug.cgi?id=1101510
which can conflict with firewalld:
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/qemu/qemu_command.c| 26 ++--
.../qemuxml2argv-cpu-numa-disjoint.args| 6 +
.../qemuxml2argv-cpu-numa-disjoint.xml | 28 ++
to ease the review of commits to follow.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/qemu/qemu_command.c | 26 +++---
1 file changed, 15 insertions(+), 11 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index fb64cda..aed7411
That can be lately achieved with by having .param == NULL in the
virQEMUCapsCommandLineProps struct.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/qemu/qemu_capabilities.c | 10 --
src/qemu/qemu_monitor.c | 6 --
src/qemu/qemu_monitor.h | 3 ++-
The numa patch series in qemu adds memory-backend-ram object type by
which we can tell whether we can use such objects.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/qemu/qemu_capabilities.c | 3 +++
src/qemu/qemu_capabilities.h | 1 +
2 files changed, 4 insertions(+)
diff --git
Currently, we only bind the whole QEMU domain to memory nodes
specified in nodemask altogether. That, however, doesn't make much
sense when one wants to control from where the memory for particular
guest nodes should be allocated. QEMU allows us to do that by
specifying 'host-nodes' parameter
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
docs/formatdomain.html.in | 15 ++
docs/schemas/domaincommon.rng | 17 ++
src/conf/numatune_conf.c | 183 +++--
Currently we are only able to bind the whole domain to some host nodes
using the /domain/numatune/memory element. Numerous requests were
made to support host-guest numa node bindings, so this series tries
to implement that using /domain/numatune/memnode elements.
That is incompatible with
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/conf/numatune_conf.c | 111 ---
src/conf/numatune_conf.h | 14 --
src/libvirt_private.syms | 1 +
src/lxc/lxc_cgroup.c | 3 +-
src/qemu/qemu_cgroup.c | 2 +-
When domain is started with numatune memory mode strict and the
nodeset does not include host NUMA node with DMA and DMA32 zones, KVM
initialization fails. This is because cgroup restrict even kernel
allocations. We are already doing numa_set_membind() which does the
same thing, only it does not
Since there was already public virDomainNumatune*, I changed the
private virNumaTune to match the same, so all the uses are unified and
public API is kept:
s/vir\(Domain\)\?Numa[tT]une/virDomainNumatune/g
then shrunk long lines, and mainly functions, that were created after
that:
sed -i
When qemu switched to using OptsVisitor for -numa parameter, it did
two things in the same patch. One of them is that the numa parameter
is now visible in query-command-line-options, the second one is that
it enabled using disjoint cpu ranges for -numa specification. This
will be used in later
There were numerous places where numatune configuration (and thus
domain config as well) was changed in different ways. On some
places this even resulted in persistent domain definition not to be
stable (it would change with daemon's restart).
In order to uniformly change how numatune config is
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/qemu/qemu_cgroup.c | 29 -
1 file changed, 24 insertions(+), 5 deletions(-)
diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c
index ff268fb..eebe9e9 100644
--- a/src/qemu/qemu_cgroup.c
+++
to ease the review of commits to follow.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/conf/domain_conf.c | 52 +-
1 file changed, 26 insertions(+), 26 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index
There are many places with numatune-related code that should be put
into special numatune_conf and this patch creates a basis for that.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/Makefile.am | 3 ++-
src/conf/domain_conf.h | 2 +-
src/conf/numatune_conf.c
Excerpt from the virCommandAddArgBuffer() description: Correctly
transfers memory errors or contents from buf to cmd.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/qemu/qemu_command.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/src/qemu/qemu_command.c
In XML format, by definition, order of fields should not matter, so
order of parsing the elements doesn't affect the end result. When
specifying guest NUMA cells, we depend only on the order of the 'cell'
elements. With this patch all older domain XMLs are parsed as before,
but with the 'id'
Introduce a new function to read the current scsi_host entry and return
the value found in the 'unique_id' file.
Add a 'scsihosttest' test (similar to the fchosttest, but incorporating some
of the concepts of the mocked pci test library) in order to read the
unique_id file like would be found in
Rather than supplying the path again in the formatting of the sysfs
scsi_host directory.
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/storage/storage_backend_scsi.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/storage/storage_backend_scsi.c
Rather than assume that NOT FC_HOST is SCSI_HOST, let's call them out
specifically. Makes it easier to find SCSI_HOST code/structs and ensures
something isn't missed in the future
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/storage/storage_backend_scsi.c | 21 ++---
1
Introduce a new function to parse the provided scsi_host parent address
and unique_id value in order to find the /sys/class/scsi_host directory
which will allow a stable SCSI host address
Add a test to scsihosttest to lookup the host# name by using the PCI address
and unique_id value
Reposting of a series from last month changing only the span version
in the docs from 1.2.6 to 1.2.7. Previous posting here:
http://www.redhat.com/archives/libvir-list/2014-June/msg00448.html
The concept still remains the same - rather than rely on the hostNN
numbers for the scsi_host to
If a parentaddr was provided in the XML, have getAdapterName lookup
the stable address. This allows virStorageBackendSCSICheckPool() and
virStorageBackendSCSIRefreshPool() to automagically find the scsi_host
by its PCI address and unique_id
Signed-off-by: John Ferlan jfer...@redhat.com
---
From: Osier Yang jy...@redhat.com
Between reboots and kernel reloads, the SCSI host number used for SCSI
storage pools may change requiring modification to the storage pool XML
in order to use a specific SCSI host adapter.
This patch introduces the parentaddr element and unique_id attribute
for
From: Osier Yang jy...@redhat.com
Preparation for future patches by creating a scsi_host union. For now,
just the 'name' will be present.
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/conf/storage_conf.c| 15 ---
src/conf/storage_conf.h| 4 +++-
Add an optional unique_id parameter to nodedev. Allows for easier lookup
and display of the unique_id value in order to document for use with
scsi_host code.
Signed-off-by: John Ferlan jfer...@redhat.com
---
docs/formatnode.html.in| 11 +++
Qemu will fallback to aio=threads when the cache mode doesn't use
O_DIRECT, even if aio=native was explictly set.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1086704
Signed-off-by: Giuseppe Scrivano gscri...@redhat.com
---
src/qemu/qemu_command.c | 7 +++
1 file changed, 7
On 07/08/14 06:03, Eric Blake wrote:
On 07/04/2014 05:29 AM, Peter Krempa wrote:
Cgroups code uses VIR_CGROUP_DEVICE_* flags to specify the mode but in
the end it needs to be converted to a string. Add a helper to do it and
use it in the cgroup code before introducing it into the rest of the
On Tue, Jul 08, 2014 at 02:08:38PM +0200, Giuseppe Scrivano wrote:
Qemu will fallback to aio=threads when the cache mode doesn't use
O_DIRECT, even if aio=native was explictly set.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1086704
Signed-off-by: Giuseppe Scrivano
On 07/08/2014 05:34 AM, Ján Tomko wrote:
We only need ip6tables, which is now a part of the iptables package:
http://pkgs.fedoraproject.org/cgit/iptables.git/commit/?h=1392835
This needlessly pulls in iptables-services:
https://bugzilla.redhat.com/show_bug.cgi?id=1101510
which can conflict
On 07/08/2014 02:28 AM, Ján Tomko wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=994731
---
docs/api.html.in | 4
1 file changed, 4 insertions(+)
diff --git a/docs/api.html.in b/docs/api.html.in
index eae7657..68ffa0b 100644
--- a/docs/api.html.in
+++ b/docs/api.html.in
@@
Daniel P. Berrange berra...@redhat.com writes:
On Tue, Jul 08, 2014 at 02:08:38PM +0200, Giuseppe Scrivano wrote:
Qemu will fallback to aio=threads when the cache mode doesn't use
O_DIRECT, even if aio=native was explictly set.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1086704
On 07/08/14 00:55, Eric Blake wrote:
On 07/04/2014 05:29 AM, Peter Krempa wrote:
Add backends for this frontend function so that we can use it in the
snapshot creation code.
---
src/storage/storage_backend_fs.c | 17 +
src/storage/storage_backend_gluster.c | 28
On 2014/7/7 20:39, Ján Tomko wrote:
On 07/07/2014 01:44 PM, Pavel Hrdina wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1076098
We support vram option for video devices in domain xml, but so far
only for QXL it had some effect. VGA video device in QEMU can also
accept the size of video
On 07/08/2014 02:44 PM, Eric Blake wrote:
On 07/08/2014 05:34 AM, Ján Tomko wrote:
We only need ip6tables, which is now a part of the iptables package:
http://pkgs.fedoraproject.org/cgit/iptables.git/commit/?h=1392835
This needlessly pulls in iptables-services:
See http://honk.sigxcpu.org:8001/job/libvirt-syntax-check/2465/
--
[...truncated 148 lines...]
0.43 prohibit_empty_lines_at_EOF
prohibit_error_without_use
grep: write error
grep: write error
/bin/sed: couldn't write 25 items to stdout: Broken pipe
sed:
Over 66% of my last commit 66e7061 was not indented properly.
---
Pushed as a build breaker fix.
libvirt.spec.in | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index 500955c..e5f9fb8 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
On Tue, Jul 08, 2014 at 03:49:02PM +0200, Jenkins CI wrote:
0.43 prohibit_empty_lines_at_EOF
prohibit_error_without_use
grep: write error
grep: write error
/bin/sed: couldn't write 25 items to stdout: Broken pipe
I've disabled notifications to the list until I'm clear what the
problem is.
On 07/08/2014 04:05 PM, Guido Günther wrote:
On Tue, Jul 08, 2014 at 03:49:02PM +0200, Jenkins CI wrote:
0.43 prohibit_empty_lines_at_EOF
prohibit_error_without_use
grep: write error
grep: write error
/bin/sed: couldn't write 25 items to stdout: Broken pipe
I've disabled notifications to
Qemu will fallback to aio=threads when the cache mode doesn't use
O_DIRECT, even if aio=native was explictly set.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1086704
Signed-off-by: Giuseppe Scrivano gscri...@redhat.com
---
src/qemu/qemu_command.c | 10 ++
1 file changed, 10
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
Notes:
Pushed as trivial
src/conf/domain_conf.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 70f1103..b80e7cf 100644
--- a/src/conf/domain_conf.c
+++
[adding bug-gnulib]
On 07/08/2014 08:05 AM, Guido Günther wrote:
On Tue, Jul 08, 2014 at 03:49:02PM +0200, Jenkins CI wrote:
0.43 prohibit_empty_lines_at_EOF
prohibit_error_without_use
grep: write error
grep: write error
/bin/sed: couldn't write 25 items to stdout: Broken pipe
I've
There was a '%' missing before the last {rhel}.
Tested on RHEL-7 this time.
---
Trivial, but not pushed yet due to my bad commit history today.
libvirt.spec.in | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index e5f9fb8..8d1acfa 100644
On 07/08/2014 08:44 AM, Ján Tomko wrote:
There was a '%' missing before the last {rhel}.
Tested on RHEL-7 this time.
---
Trivial, but not pushed yet due to my bad commit history today.
libvirt.spec.in | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
ACK.
--
Eric Blake eblake
Peter Krempa (3):
conf: Verify metadata type right away
util: XML: Avoid forward function declaration
lib: Check conditions for VIR_DOMAIN_BLOCK_REBASE_RELATIVE right away
src/conf/domain_conf.c | 10 ++
src/libvirt.c | 17 +
src/qemu/qemu_driver.c | 7
Recursive functions apparently don't need them, but I originally thought
they do.
---
src/util/virxml.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/src/util/virxml.c b/src/util/virxml.c
index 34af64a..cc4a85c 100644
--- a/src/util/virxml.c
+++ b/src/util/virxml.c
@@ -935,11 +935,6 @@
VIR_DOMAIN_BLOCK_REBASE_RELATIVE works only when @base is specified.
Check it right in libvirt.c as it's not expected to change across
hypervisors.
---
src/libvirt.c | 7 +++
src/qemu/qemu_driver.c | 7 ---
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git
Verify the desired metadata type in the libvirt.c dispatcher rather than
in the bottom level executor function.
---
src/conf/domain_conf.c | 10 ++
src/libvirt.c | 10 ++
2 files changed, 8 insertions(+), 12 deletions(-)
diff --git a/src/conf/domain_conf.c
Commit 48f44510098cead629ede9a49ea4e840a28ccca introduced a helper
fucntion to convert cgroup device mode to string. The function was only
conditionally compliled on platforms that support cgroup. This broke the
build when attempting to export the symbol:
CCLD libvirt.la
Cannot export
On 07/08/2014 09:29 AM, Peter Krempa wrote:
Verify the desired metadata type in the libvirt.c dispatcher rather than
in the bottom level executor function.
---
src/conf/domain_conf.c | 10 ++
src/libvirt.c | 10 ++
2 files changed, 8 insertions(+), 12 deletions(-)
On 07/08/2014 09:29 AM, Peter Krempa wrote:
Recursive functions apparently don't need them, but I originally thought
they do.
---
src/util/virxml.c | 5 -
1 file changed, 5 deletions(-)
ACK. When it comes to static functions, it's only mutually recursive
function pairs that need a
On 07/08/2014 09:29 AM, Peter Krempa wrote:
VIR_DOMAIN_BLOCK_REBASE_RELATIVE works only when @base is specified.
Check it right in libvirt.c as it's not expected to change across
hypervisors.
---
src/libvirt.c | 7 +++
src/qemu/qemu_driver.c | 7 ---
2 files changed, 7
On 07/08/2014 09:40 AM, Peter Krempa wrote:
Commit 48f44510098cead629ede9a49ea4e840a28ccca introduced a helper
fucntion to convert cgroup device mode to string. The function was only
s/fucntion/function/
conditionally compliled on platforms that support cgroup. This broke the
On Tue, Jul 08, 2014 at 09:50:50AM -0600, Eric Blake wrote:
On 07/08/2014 09:29 AM, Peter Krempa wrote:
+++ b/src/libvirt.c
@@ -10178,8 +10178,9 @@ virDomainSetMetadata(virDomainPtr domain,
virCheckNonNullArgGoto(key, error);
break;
default:
-/* For
Another patch for
https://bugzilla.redhat.com/show_bug.cgi?id=994731
---
src/libvirt.c | 139 +++---
1 file changed, 134 insertions(+), 5 deletions(-)
diff --git a/src/libvirt.c b/src/libvirt.c
index 316fdf0..8684298 100644
--- a/src/libvirt.c
On 07/08/2014 09:53 AM, Eric Blake wrote:
+if (flags VIR_DOMAIN_BLOCK_REBASE_RELATIVE !base) {
+virReportInvalidArg(base, %s,
+_(flag VIR_DOMAIN_BLOCK_REBASE_RELATIVE is
valid
+ only with non-null base));
+goto
ping :)
On Wed, Jul 2, 2014 at 3:20 PM, Michele Paolino
m.paol...@virtualopensystems.com wrote:
This series adds support for the QEMU vhost-user feature to libvirt.
vhost-user enables the communication between a QEMU virtual machine
and other userspace process using the Virtio transport
Also fix the error message if an IPv6 host with no MAC
is not found.
https://bugzilla.redhat.com/show_bug.cgi?id=991290
---
src/conf/network_conf.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c
index
On 07/08/2014 10:00 AM, Ján Tomko wrote:
Another patch for
https://bugzilla.redhat.com/show_bug.cgi?id=994731
---
src/libvirt.c | 139
+++---
1 file changed, 134 insertions(+), 5 deletions(-)
diff --git a/src/libvirt.c b/src/libvirt.c
On Mon, Jul 7, 2014 at 12:09 PM, Christophe Fergeau cferg...@redhat.com wrote:
This is returning a char *
capabilities
host
cpu
modelxxx/model
/cpu
/host
/capabilities
while the next patch exposes the model from the /domain/cpu/model node
as an actual object, why the
When run under an environment that inherits an ignored SIGPIPE
(hello, annoying buildbots), a syntax-check was producing quite
a bit of noise, such as:
prohibit_argmatch_without_use
grep: write error
grep: write error
/bin/sed: couldn't write 25 items to stdout: Broken pipe
sed: couldn't
On 07/08/2014 10:47 AM, Ján Tomko wrote:
Also fix the error message if an IPv6 host with no MAC
is not found.
https://bugzilla.redhat.com/show_bug.cgi?id=991290
---
src/conf/network_conf.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
ACK.
--
Eric Blake
On 07/08/2014 08:08 AM, Giuseppe Scrivano wrote:
Qemu will fallback to aio=threads when the cache mode doesn't use
O_DIRECT, even if aio=native was explictly set.
oops, I meant to do s/explictly/explicitly/, but pushed too soon.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1086704
On 07/03/2014 09:09 PM, Chen Hanxiao wrote:
Currently @flag is not used yet.
Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com
---
src/lxc/lxc_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c
index
See individual patches for details.
Jim Fehlig (4):
libxl: rename goto label
libxl: remove domain when migration prepare fails
libxl: acquire job though begin phase only
libxl: fix crash in migrate confirm for transient domains
src/libxl/libxl_driver.c| 7 ++
In libxlDomainMigrationPrepare(), a new virDomainObj is created
from the incoming domain def and added to the driver's domain
list, but never removed if there are subsequent failures during
the prepare phase.
targethost# virsh list --all
sourcehost# virsh migrate --live dom
In libxlDomainMigrationConfirm(), a transient domain is removed
from the domain list after successful migration. Later in cleanup,
the domain object is unlocked, resulting in a crash
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fb4208ed700 (LWP 12044)]
In libxlDomainMigrationPrepare(), the cleanup label handles error
conditions and should be renamed as such for clarity.
Signed-off-by: Jim Fehlig jfeh...@suse.com
---
src/libxl/libxl_migration.c | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git
On 07/04/2014 05:29 AM, Peter Krempa wrote:
Add functions that will allow to set all the required cgroup stuff on
individual images taking a virStorageSourcePtr. Also convert functions
designed to setup whole backing chain to take advantage of the change.
---
src/qemu/qemu_cgroup.c | 103
During migration, the libxl driver starts a modify job in the
begin phase, ending the job in the confirm phase. This is
essentially VIR_MIGRATE_CHANGE_PROTECTION semantics, but the
driver does not support that flag. Without CHANGE_PROTECTION
support, the job would never be terminated in error
On 07/08/2014 03:52 PM, Jim Fehlig wrote:
In libxlDomainMigrationPrepare(), a new virDomainObj is created
from the incoming domain def and added to the driver's domain
list, but never removed if there are subsequent failures during
the prepare phase.
targethost# virsh list --all
On 07/08/2014 03:52 PM, Jim Fehlig wrote:
In libxlDomainMigrationPrepare(), the cleanup label handles error
conditions and should be renamed as such for clarity.
Signed-off-by: Jim Fehlig jfeh...@suse.com
---
src/libxl/libxl_migration.c | 30 +++---
1 file changed,
On 07/08/2014 03:52 PM, Jim Fehlig wrote:
During migration, the libxl driver starts a modify job in the
begin phase, ending the job in the confirm phase. This is
essentially VIR_MIGRATE_CHANGE_PROTECTION semantics, but the
driver does not support that flag. Without CHANGE_PROTECTION
On 07/08/2014 03:52 PM, Jim Fehlig wrote:
In libxlDomainMigrationConfirm(), a transient domain is removed
from the domain list after successful migration. Later in cleanup,
the domain object is unlocked, resulting in a crash
Program received signal SIGSEGV, Segmentation fault.
[Switching
On 07/04/2014 05:29 AM, Peter Krempa wrote:
Only the top level gets writes, so the rest of the backing chain
requires only read-only access.
---
src/qemu/qemu_cgroup.c | 26 --
1 file changed, 20 insertions(+), 6 deletions(-)
ACK
--
Eric Blake eblake redhat com
On 07/04/2014 05:29 AM, Peter Krempa wrote:
Add helper APIs to manage individual image files rather than disks. To
simplify the addition some parts of the code were refactored in this
patch.
---
src/libvirt_private.syms | 2 ++
src/locking/domain_lock.c | 65
On 07/04/2014 05:29 AM, Peter Krempa wrote:
Add security driver functions to label separate storage images using the
virStorageSource definition. This will help to avoid the need to do ugly
changes to the disk struct and use the source directly.
---
src/libvirt_private.syms| 2 ++
On 07/04/2014 05:29 AM, Peter Krempa wrote:
Refactor the existing code to allow re-using it for the per-image label
restore too.
---
src/security/security_selinux.c | 59
-
1 file changed, 34 insertions(+), 25 deletions(-)
@@ -1144,40 +1146,35 @@
On 07/04/2014 05:29 AM, Peter Krempa wrote:
Refactor the code and reuse it to implement the functionality.
---
src/security/security_selinux.c | 91
-
1 file changed, 53 insertions(+), 38 deletions(-)
static int
On 07/04/2014 05:29 AM, Peter Krempa wrote:
Refactor the code and reuse it to implement the functionality.
---
src/security/security_apparmor.c | 37 ++---
1 file changed, 22 insertions(+), 15 deletions(-)
ACK
--
Eric Blake eblake redhat com
On 07/04/2014 05:29 AM, Peter Krempa wrote:
Refactor the existing code to allow re-using it for the per-image label
restore too.
---
src/security/security_dac.c | 59
-
1 file changed, 31 insertions(+), 28 deletions(-)
-secdef =
Eric Blake wrote:
On 07/08/2014 03:52 PM, Jim Fehlig wrote:
In libxlDomainMigrationConfirm(), a transient domain is removed
from the domain list after successful migration. Later in cleanup,
the domain object is unlocked, resulting in a crash
Program received signal SIGSEGV,
On 07/04/2014 05:29 AM, Peter Krempa wrote:
Refactor the code and reuse it to implement the functionality.
---
src/security/security_dac.c | 52
++---
1 file changed, 25 insertions(+), 27 deletions(-)
ACK
--
Eric Blake eblake redhat com
On 07/04/2014 05:29 AM, Peter Krempa wrote:
Refactor the existing code to allow re-using it for the per-image label
restore too.
---
src/security/security_apparmor.c | 18 ++
1 file changed, 14 insertions(+), 4 deletions(-)
ACK
--
Eric Blake eblake redhat com
On 07/04/2014 05:29 AM, Peter Krempa wrote:
Add a few checks and avoid resolving relative links on networked
storage.
---
src/util/virstoragefile.c | 27 +++
1 file changed, 15 insertions(+), 12 deletions(-)
+
+if (nameIsFile
On 07/04/2014 05:29 AM, Peter Krempa wrote:
Instead of just returning the parent path, return the complete parent
source structure.
---
src/qemu/qemu_driver.c| 16 -
src/util/virstoragefile.c | 17 --
src/util/virstoragefile.h | 2 +-
tests/virstoragetest.c| 86
On 07/04/2014 05:29 AM, Peter Krempa wrote:
Use the source struct and the corresponding function so that we can
avoid using the path separately. Now that
qemuDomainPrepareDiskChainElementPath isn't use anywhere, we can safely
remove it.
Additionally, the removal fixes a misaligned comment
On 07/04/2014 05:29 AM, Peter Krempa wrote:
When pivotting to a new disk source after a block commit (and possibly
s/pivotting/pivoting/ here and in subject
after a soon-to-be-added active block commit) we changed just a few
fields to the new target. In case we'd copy a network disk to a
On 07/04/2014 05:29 AM, Peter Krempa wrote:
Until now we were changing information about the disk source via
multiple steps of copying data. Now that we changed to a pointer to
store the disk source we might use it to change the approach to track
the data.
Additionally this will allow
1 - 100 of 103 matches
Mail list logo
