Re: [libvirt] [PATCH] network: fix crash when starting a network with no pf element

2014-08-15 Thread Laine Stump
On 08/14/2014 05:10 PM, Martin Kletzander wrote: On Thu, Aug 14, 2014 at 12:40:07PM -0400, Laine Stump wrote: src/network/bridge_driver.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index

Re: [libvirt] [PATCH 00/66] vbox: Rewrite vbox domain driver

2014-08-15 Thread Michal Privoznik
On 14.08.2014 17:50, Yohan Belleguic wrote: Le Wednesday 13 August 2014 17:18:44, Michal Privoznik a écrit : [CC-ing Yohan BELLEGUIC and Manuel VIVES] On 12.08.2014 17:31, Michal Privoznik wrote: On 11.08.2014 12:06, Taowei wrote: This series of patches rewrite the vbox's domain driver. The

[libvirt] [PATCH v2 0/2] bhyve: add volumes support

2014-08-15 Thread Roman Bogorodskiy
Changes from v1: - Add volume support for the bhyveload command as well to allow booting from a volume Roman Bogorodskiy (2): conf: make disk source pool translation generic bhyve: add volumes support src/bhyve/bhyve_command.c | 16 ++- src/bhyve/bhyve_command.h | 7 +-

[libvirt] [PATCH v2 1/2] conf: make disk source pool translation generic

2014-08-15 Thread Roman Bogorodskiy
Currently, qemu driver uses qemuTranslateDiskSourcePool() to translate disk volume information. This function is general enough and could be used for other drivers as well, so move it to conf/domain_conf.c along with its helpers. - qemuTranslateDiskSourcePool: move to conf/domain_conf.c and

[libvirt] [PATCH v2 2/2] bhyve: add volumes support

2014-08-15 Thread Roman Bogorodskiy
Update bhyveBuildDiskArgStr to support volumes: - Make virBhyveProcessBuildBhyveCmd and virBhyveProcessBuildLoadCmd take virConnectPtr as the first argument instead of bhyveConnPtr as virConnectPtr is needed for virDomainTranslateDiskSourcePool, - Add virDomainTranslateDiskSourcePool

[libvirt] [PATCH] Error out on missing address in 'server' type interface

2014-08-15 Thread Ján Tomko
It was possible to add the following interface: interface type='server' source port='5558'/ /interface Resulting in: error: internal error Process exited while reading console log output: char device redirected to /dev/pts/4 2014-08-15T05:59:17.348271Z qemu-kvm: -netdev

Re: [libvirt] [PATCH] fix

2014-08-15 Thread Wang Rui
On 2014/8/15 12:16, Sam Bobroff wrote: On 14/08/14 20:14, Ján Tomko wrote: On 08/14/2014 11:52 AM, Michal Privoznik wrote: On 14.08.2014 10:41, Ján Tomko wrote: Also add qemuDomainChangeGraphicsPasswords, qemuProcessVerifyGuestCPU and qemuProcessInitPCIAddresses. Replace tabs by spaces.

[libvirt] [PATCH 3/3] storage: zfs: implement download and upload

2014-08-15 Thread Roman Bogorodskiy
Add an implementation of uploadVol and downloadVol using virStorageBackendVolUploadLocal and virStorageBackendVolDownloadLocal respectively. --- src/storage/storage_backend_zfs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/storage/storage_backend_zfs.c

[libvirt] [PATCH 0/3] storage: zfs: implement download and upload

2014-08-15 Thread Roman Bogorodskiy
Roman Bogorodskiy (3): fdstream: report error if virSetNonBlock fails fdstream: introduce virFDStreamOpenBlockDevice storage: zfs: implement download and upload src/fdstream.c| 30 +++--- src/fdstream.h| 5 +

[libvirt] [PATCH 2/3] fdstream: introduce virFDStreamOpenBlockDevice

2014-08-15 Thread Roman Bogorodskiy
virStorageBackendVolDownloadLocal and virStorageBackendVolUploadLocal use virFDStreamOpenFile function to work with the volume fd. virFDStreamOpenFile calls virFDStreamOpenFileInternal that implements handling of the non-blocking I/O. If a file is not a character device and not a fifo, it uses

[libvirt] [PATCH 1/3] fdstream: report error if virSetNonBlock fails

2014-08-15 Thread Roman Bogorodskiy
virFDStreamOpenInternal terminates if virSetNonBlock fails. As virSetNonBlock uses gnulib's set_nonblocking_flag that sets errno, call virReportSystemError() to let user know the reason of fail. --- src/fdstream.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [libvirt] [PATCH] Error out on missing address in 'server' type interface

2014-08-15 Thread Martin Kletzander
On Fri, Aug 15, 2014 at 10:21:36AM +0200, Ján Tomko wrote: It was possible to add the following interface: interface type='server' source port='5558'/ /interface Resulting in: error: internal error Process exited while reading console log output: char device redirected to /dev/pts/4

Re: [libvirt] Suboptimal default cpu Cgroup

2014-08-15 Thread Daniel P. Berrange
On Thu, Aug 14, 2014 at 01:55:11PM -0400, Andrew Theurer wrote: - Original Message - From: Radim Krčmář rkrc...@redhat.com To: libvir-list@redhat.com Cc: Daniel P. Berrange berra...@redhat.com, Andrew Theurer atheu...@redhat.com Sent: Thursday, August 14, 2014 9:25:05 AM

Re: [libvirt] Suboptimal default cpu Cgroup

2014-08-15 Thread Martin Kletzander
On Thu, Aug 14, 2014 at 04:25:05PM +0200, Radim Krčmář wrote: Hello, by default, libvirt with KVM creates a Cgroup hierarchy in 'cpu,cpuacct' [1], with 'shares' set to 1024 on every level. This raises two points: 1) Every VM is given an equal amount of CPU time. [2]

Re: [libvirt] [PATCH] network: fix crash when starting a network with no pf element

2014-08-15 Thread Martin Kletzander
On Fri, Aug 15, 2014 at 02:50:30AM -0400, Laine Stump wrote: On 08/14/2014 05:10 PM, Martin Kletzander wrote: On Thu, Aug 14, 2014 at 12:40:07PM -0400, Laine Stump wrote: src/network/bridge_driver.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git

Re: [libvirt] [PATCH 2/3] fdstream: introduce virFDStreamOpenBlockDevice

2014-08-15 Thread Daniel P. Berrange
On Fri, Aug 15, 2014 at 12:44:21PM +0400, Roman Bogorodskiy wrote: virStorageBackendVolDownloadLocal and virStorageBackendVolUploadLocal use virFDStreamOpenFile function to work with the volume fd. virFDStreamOpenFile calls virFDStreamOpenFileInternal that implements handling of the

Re: [libvirt] [PATCH 2/3] fdstream: introduce virFDStreamOpenBlockDevice

2014-08-15 Thread Roman Bogorodskiy
Daniel P. Berrange wrote: On Fri, Aug 15, 2014 at 12:44:21PM +0400, Roman Bogorodskiy wrote: virStorageBackendVolDownloadLocal and virStorageBackendVolUploadLocal use virFDStreamOpenFile function to work with the volume fd. virFDStreamOpenFile calls virFDStreamOpenFileInternal that

[libvirt] Virtual box storage and network sub-drivers

2014-08-15 Thread Michal Privoznik
Dear list, Virtualbox driver has its own implementation of storage and network sub-drivers. But as of commit ba5f3c7c8ecc1037e44904916989a1c65777a9d5 (contained in the 1.0.6 release) when the VBox moved from client to daemon, the storage and network sub-drivers are indeed registered but in

Re: [libvirt] [PATCH] Error out on missing address in 'server' type interface

2014-08-15 Thread jiahu
On 08/15/2014 04:21 PM, Ján Tomko wrote: It was possible to add the following interface: interface type='server' source port='5558'/ /interface Resulting in: error: internal error Process exited while reading console log output: char device redirected to /dev/pts/4

Re: [libvirt] [PATCH 2/3] fdstream: introduce virFDStreamOpenBlockDevice

2014-08-15 Thread Daniel P. Berrange
On Fri, Aug 15, 2014 at 12:55:58PM +0400, Roman Bogorodskiy wrote: Daniel P. Berrange wrote: On Fri, Aug 15, 2014 at 12:44:21PM +0400, Roman Bogorodskiy wrote: virStorageBackendVolDownloadLocal and virStorageBackendVolUploadLocal use virFDStreamOpenFile function to work with the

Re: [libvirt] Virtual box storage and network sub-drivers

2014-08-15 Thread Daniel P. Berrange
On Fri, Aug 15, 2014 at 11:06:18AM +0200, Michal Privoznik wrote: Dear list, Virtualbox driver has its own implementation of storage and network sub-drivers. But as of commit ba5f3c7c8ecc1037e44904916989a1c65777a9d5 (contained in the 1.0.6 release) when the VBox moved from client to daemon,

Re: [libvirt] [PATCH 2/3] fdstream: introduce virFDStreamOpenBlockDevice

2014-08-15 Thread Roman Bogorodskiy
Daniel P. Berrange wrote: On Fri, Aug 15, 2014 at 12:55:58PM +0400, Roman Bogorodskiy wrote: Daniel P. Berrange wrote: On Fri, Aug 15, 2014 at 12:44:21PM +0400, Roman Bogorodskiy wrote: virStorageBackendVolDownloadLocal and virStorageBackendVolUploadLocal use

Re: [libvirt] [PATCHv2] qemu: Redundant listen address entry in quest xml

2014-08-15 Thread Wang Rui
On 2014/8/14 20:44, Erik Skultety wrote: When editing guest's XML (on QEMU), it was possible to add multiple listen elements into graphics parent element. However QEMU does not support listening on multiple addresses. Configuration is tested for multiple 'listen address' and if positive, an

Re: [libvirt] [PATCHv2] qemu: Redundant listen address entry in quest xml

2014-08-15 Thread Daniel P. Berrange
On Fri, Aug 15, 2014 at 05:59:38PM +0800, Wang Rui wrote: On 2014/8/14 20:44, Erik Skultety wrote: When editing guest's XML (on QEMU), it was possible to add multiple listen elements into graphics parent element. However QEMU does not support listening on multiple addresses. Configuration

[libvirt] [libvirt-glib] [PATCH 0/4] Add some async versions of synchronous snapshot API

2014-08-15 Thread Timm Bäder
This adds async versions of a few snapshot related functions and a patch that cleans up some doc comments I crewed up in earlier commits. All the sync versions don't seem cancellable to me since we can't just throw the result away like we do when fetching snapshots in case the operation gets

[libvirt] [libvirt-glib] [PATCH 1/4] GVirDomain: Fix some doc comments of the snapshot API

2014-08-15 Thread Timm Bäder
Fixes some warnings from g-ir-scanner. --- libvirt-gobject/libvirt-gobject-domain.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libvirt-gobject/libvirt-gobject-domain.c b/libvirt-gobject/libvirt-gobject-domain.c index feac6f0..aa2a170 100644 ---

[libvirt] [libvirt-glib] [PATCH 2/4] GVirDomainSnapshot: Add async version of _revert_to

2014-08-15 Thread Timm Bäder
--- libvirt-gobject/libvirt-gobject-domain-snapshot.c | 56 +++ libvirt-gobject/libvirt-gobject-domain-snapshot.h | 10 libvirt-gobject/libvirt-gobject.sym | 2 + 3 files changed, 68 insertions(+) diff --git

[libvirt] [libvirt-glib] [PATCH 3/4] GVirDomain: Add async version of _create_snapshot

2014-08-15 Thread Timm Bäder
--- libvirt-gobject/libvirt-gobject-domain.c | 67 libvirt-gobject/libvirt-gobject-domain.h | 11 ++ libvirt-gobject/libvirt-gobject.sym | 2 + 3 files changed, 80 insertions(+) diff --git a/libvirt-gobject/libvirt-gobject-domain.c

[libvirt] [libvirt-glib] [PATCH 4/4] GVirDomainSnapshot: Add async version of _delete

2014-08-15 Thread Timm Bäder
--- libvirt-gobject/libvirt-gobject-domain-snapshot.c | 56 +++ libvirt-gobject/libvirt-gobject-domain-snapshot.h | 9 libvirt-gobject/libvirt-gobject.sym | 2 + 3 files changed, 67 insertions(+) diff --git

[libvirt] [PATCH] daemon: Fix driver registration ordering

2014-08-15 Thread Michal Privoznik
There are some stateless drivers which implement subdrivers (typically vbox and its own network and storage subdrivers). However, as of ba5f3c7c8ecc10 the vbox driver lives in the daemon, not the client library. This means, in order for vbox (or any stateless domain driver) to use its subdrivers,

[libvirt] [PATCHv3] qemu: Redundant listen address entry in quest xml

2014-08-15 Thread Erik Skultety
When editing guest's XML (on QEMU), it was possible to add multiple listen elements into graphics parent element. However QEMU does not support listening on multiple addresses. Configuration is tested for multiple 'listen address' and if positive, an error is raised. --- src/qemu/qemu_process.c |

Re: [libvirt] [PATCH] daemon: Fix driver registration ordering

2014-08-15 Thread Martin Kletzander
On Fri, Aug 15, 2014 at 01:17:37PM +0200, Michal Privoznik wrote: There are some stateless drivers which implement subdrivers (typically vbox and its own network and storage subdrivers). However, as of ba5f3c7c8ecc10 the vbox driver lives in the daemon, not the client library. This means, in

[libvirt] [PATCH] qemu: allow device block I/O tuning in session mode

2014-08-15 Thread Martin Kletzander
In commit 45ad1adb I added a nicer message for tunings that need cgroups when unavailable (unprigileged) ,but I added this check for I/O tuning of block devices, which doesn't need cgroups, because it is done by QEMU, so let's fix that. Signed-off-by: Martin Kletzander mklet...@redhat.com ---

Re: [libvirt] Suboptimal default cpu Cgroup

2014-08-15 Thread Andrew Theurer
On Thu, Aug 14, 2014 at 01:55:11PM -0400, Andrew Theurer wrote: - Original Message - From: Radim Krčmář rkrc...@redhat.com To: libvir-list@redhat.com Cc: Daniel P. Berrange berra...@redhat.com, Andrew Theurer atheu...@redhat.com Sent: Thursday, August 14, 2014

Re: [libvirt] [PATCH 2/2] bhyve: add volumes support

2014-08-15 Thread Martin Kletzander
On Thu, Aug 14, 2014 at 08:22:07PM +0400, Roman Bogorodskiy wrote: Update bhyveBuildDiskArgStr to support volumes: - Make virBhyveProcessBuildBhyveCmd take virConnectPtr as the first argument instead of bhyveConnPtr as virConnectPtr is needed for virDomainTranslateDiskSourcePool, - Add

Re: [libvirt] [PATCH 00/14] qemu: Cdrom media change fixes and support for networked storage

2014-08-15 Thread Peter Krempa
On 08/08/14 16:52, Peter Krempa wrote: Peter Krempa (14): qemu: Explicitly state that hotplugging cdroms and floppies doesn't work conf: Pass virStorageSource into virDomainDiskSourceIsBlockType qemu: hotplug: Untangle cleanup paths in qemuDomainChangeEjectableMedia qemu:

Re: [libvirt] [PATCH 1/2] conf: make disk source pool translation generic

2014-08-15 Thread Martin Kletzander
On Thu, Aug 14, 2014 at 08:22:06PM +0400, Roman Bogorodskiy wrote: Currently, qemu driver uses qemuTranslateDiskSourcePool() to translate disk volume information. This function is general enough and could be used for other drivers as well, so move it to conf/domain_conf.c along with its helpers.

[libvirt] [PATCH v2 1/3] conf: Extend loader/ and introduce nvram/

2014-08-15 Thread Michal Privoznik
Up to now, users can configure BIOS via the loader/ element. With the upcoming implementation of UEFI this is not enough as BIOS and UEFI are conceptually different. For instance, while BIOS is ROM, UEFI is programmable flash (although all writes to code section are denied). Therefore we need new

[libvirt] [PATCH v2 0/3] OVMF exposure

2014-08-15 Thread Michal Privoznik
diff to v1: - adapt to new code - restrict usage to x86_64 qemu guests - Adapted to Laszlo's suggestion for qemu.conf format Michal Privoznik (3): conf: Extend loader/ and introduce nvram/ qemu: Implement extended loader and nvram qemu: Automatically create NVRAM store configure.ac

[libvirt] [PATCH v2 3/3] qemu: Automatically create NVRAM store

2014-08-15 Thread Michal Privoznik
When using split UEFI image, it may come handy if libvirt manages per domain _VARS file automatically. While the _CODE file is RO and can be shared among multiple domains, you certainly don't want to do that on the _VARS file. This latter one needs to be per domain. So at the domain startup

[libvirt] [PATCH v2 2/3] qemu: Implement extended loader and nvram

2014-08-15 Thread Michal Privoznik
QEMU now supports UEFI with the following command line: -drive file=/usr/share/OVMF/OVMF_CODE.fd,if=pflash,format=raw,unit=0,readonly=on \ -drive file=/usr/share/OVMF/OVMF_VARS.fd,if=pflash,format=raw,unit=1 \ where the first line reflects loader and the second one nvram. Moreover, these

Re: [libvirt] Suboptimal default cpu Cgroup

2014-08-15 Thread Daniel P. Berrange
On Fri, Aug 15, 2014 at 09:23:35AM -0400, Andrew Theurer wrote: On Thu, Aug 14, 2014 at 01:55:11PM -0400, Andrew Theurer wrote: - Original Message - From: Radim Krčmář rkrc...@redhat.com To: libvir-list@redhat.com Cc: Daniel P. Berrange berra...@redhat.com,

Re: [libvirt] [PATCH 1/2] conf: make disk source pool translation generic

2014-08-15 Thread Peter Krempa
On 08/15/14 15:35, Martin Kletzander wrote: On Thu, Aug 14, 2014 at 08:22:06PM +0400, Roman Bogorodskiy wrote: Currently, qemu driver uses qemuTranslateDiskSourcePool() to translate disk volume information. This function is general enough and could be used for other drivers as well, so move

Re: [libvirt] Suboptimal default cpu Cgroup

2014-08-15 Thread Radim Krčmář
2014-08-15 10:50+0200, Martin Kletzander: On Thu, Aug 14, 2014 at 04:25:05PM +0200, Radim Krčmář wrote: Hello, by default, libvirt with KVM creates a Cgroup hierarchy in 'cpu,cpuacct' [1], with 'shares' set to 1024 on every level. This raises two points: 1) Every VM is given an equal

Re: [libvirt] Suboptimal default cpu Cgroup

2014-08-15 Thread Radim Krčmář
2014-08-15 14:44+0100, Daniel P. Berrange: On Fri, Aug 15, 2014 at 09:23:35AM -0400, Andrew Theurer wrote: On Thu, Aug 14, 2014 at 01:55:11PM -0400, Andrew Theurer wrote: From: Radim Krčmář rkrc...@redhat.com It does not seem to be possible to tune shares and get a good general

Re: [libvirt] [PATCH v2 1/3] conf: Extend loader/ and introduce nvram/

2014-08-15 Thread Laszlo Ersek
On 08/15/14 15:43, Michal Privoznik wrote: Up to now, users can configure BIOS via the loader/ element. With the upcoming implementation of UEFI this is not enough as BIOS and UEFI are conceptually different. For instance, while BIOS is ROM, UEFI is programmable flash (although all writes to

Re: [libvirt] [PATCH v2 2/3] qemu: Implement extended loader and nvram

2014-08-15 Thread Laszlo Ersek
notes below On 08/15/14 15:43, Michal Privoznik wrote: QEMU now supports UEFI with the following command line: -drive file=/usr/share/OVMF/OVMF_CODE.fd,if=pflash,format=raw,unit=0,readonly=on \ -drive file=/usr/share/OVMF/OVMF_VARS.fd,if=pflash,format=raw,unit=1 \ where the first

Re: [libvirt] Suboptimal default cpu Cgroup

2014-08-15 Thread Daniel P. Berrange
On Fri, Aug 15, 2014 at 04:13:13PM +0200, Radim Krčmář wrote: 2014-08-15 14:44+0100, Daniel P. Berrange: On Fri, Aug 15, 2014 at 09:23:35AM -0400, Andrew Theurer wrote: On Thu, Aug 14, 2014 at 01:55:11PM -0400, Andrew Theurer wrote: From: Radim Krčmář rkrc...@redhat.com It does

Re: [libvirt] Support for kvm=off cpu option

2014-08-15 Thread Cole Robinson
On 08/11/2014 05:54 PM, Alex Williamson wrote: As of QEMU 2.1 we now have a new -cpu option, kvm=on|off which controls whether we expose KVM as the hypervisor via the MSR hypervisor nodes. The default is on. The off state is meant to hide kvm from standard detection routines. This allows us

Re: [libvirt] [PATCH v2 1/3] conf: Extend loader/ and introduce nvram/

2014-08-15 Thread Michal Privoznik
On 15.08.2014 16:13, Laszlo Ersek wrote: On 08/15/14 15:43, Michal Privoznik wrote: Up to now, users can configure BIOS via the loader/ element. With the upcoming implementation of UEFI this is not enough as BIOS and UEFI are conceptually different. For instance, while BIOS is ROM, UEFI is

[libvirt] [PATCH 1/5] qemu: process: Remove unnecessary argument and rename function

2014-08-15 Thread Peter Krempa
We set just one affinity of the emulator and the virConnectPtr isn't needed for that function. --- src/qemu/qemu_process.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 52d9052..fe8fd2a 100644 ---

[libvirt] [PATCH 0/5] Fix vcpu pinning info propagation on vcpu cold-unplug

2014-08-15 Thread Peter Krempa
Remove the vcpupin info on cold cpuunplug. Also refactor a few unpleasant-to-look-at functions found while looking for the problem. Peter Krempa (5): qemu: process: Remove unnecessary argument and rename function conf: cpupin: Remove useless checking of vcpupin element count conf:

[libvirt] [PATCH 2/5] conf: cpupin: Remove useless checking of vcpupin element count

2014-08-15 Thread Peter Krempa
The check doesn't make much sense as right below it the entries are either checked for duplicity or ignored in some cases. Having this check doesn't actually forbid passing invalid values. --- src/conf/domain_conf.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/conf/domain_conf.c

[libvirt] [PATCH 4/5] qemu: cpu: unplug: Remove vcpu pinning on cold cpu unplug

2014-08-15 Thread Peter Krempa
Remove the pinning info when removing to CPU, otherwise when the VM will be started our code will try to pin non-existing vcpus as the definition wasn't updated. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1129372 --- src/qemu/qemu_driver.c | 7 +++ 1 file changed, 7 insertions(+)

[libvirt] [PATCH 5/5] qemu: process: Pin on per-vcpu basis instead of per-vcpupin element

2014-08-15 Thread Peter Krempa
Pin existing vcpus rather than existing vcpu pinning infos. This increases the complexity of the lookup, but avoids pinning cpus that are not enabled actually. --- src/qemu/qemu_process.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_process.c

[libvirt] [PATCH 3/5] conf: Refactor virDomainVcpuPinDefParseXML

2014-08-15 Thread Peter Krempa
Tidy up control flow, change boolean argument to use 'bool', improve error message in case the function is used to parse emulator pinning info and avoid a few temp variables that made no sense. Also when the function is called to parse emulator pinning info, there's no need to check the processor

Re: [libvirt] Support for kvm=off cpu option

2014-08-15 Thread Alex Williamson
On Fri, 2014-08-15 at 10:38 -0400, Cole Robinson wrote: On 08/11/2014 05:54 PM, Alex Williamson wrote: As of QEMU 2.1 we now have a new -cpu option, kvm=on|off which controls whether we expose KVM as the hypervisor via the MSR hypervisor nodes. The default is on. The off state is meant to

[libvirt] [PATCH] man: virsh: Add man page for virsh metadata

2014-08-15 Thread Peter Krempa
Patch adding the command forgot to add the man page entry. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1130379 --- tools/virsh.pod | 30 ++ 1 file changed, 30 insertions(+) diff --git a/tools/virsh.pod b/tools/virsh.pod index f07deec..d072a7f 100644 ---

[libvirt] [PATCH v3 2/2] bhyve: add volumes support

2014-08-15 Thread Roman Bogorodskiy
Update bhyveBuildDiskArgStr to support volumes: - Make virBhyveProcessBuildBhyveCmd and virBhyveProcessBuildLoadCmd take virConnectPtr as the first argument instead of bhyveConnPtr as virConnectPtr is needed for virStorageTranslateDiskSourcePool, - Add virStorageTranslateDiskSourcePool

[libvirt] [PATCH v3 0/2] bhyve: add volumes support

2014-08-15 Thread Roman Bogorodskiy
Changes from v1: - Add volume support for the bhyveload command as well to allow booting from a volume Changes from v2: - Move disk source pool translation to storage/storage_driver.c instead of conf/domain_conf.c, because having that in conf/domain_conf.c requires pulling storage

[libvirt] [PATCH v3 1/2] conf: make disk source pool translation generic

2014-08-15 Thread Roman Bogorodskiy
Currently, qemu driver uses qemuTranslateDiskSourcePool() to translate disk volume information. This function is general enough and could be used for other drivers as well, so move it to conf/domain_conf.c along with its helpers. - qemuTranslateDiskSourcePool: move to storage/storage_driver.c

Re: [libvirt] [PATCH] man: virsh: Add man page for virsh metadata

2014-08-15 Thread Eric Blake
On 08/15/2014 09:12 AM, Peter Krempa wrote: Patch adding the command forgot to add the man page entry. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1130379 --- tools/virsh.pod | 30 ++ 1 file changed, 30 insertions(+) diff --git a/tools/virsh.pod

[libvirt] [PATCH] Add new 'kvm' domain feature and ability to hide KVM signature

2014-08-15 Thread Alex Williamson
QEMU 2.1 added support for the kvm=off option to the -cpu command, allowing the KVM hypervisor signature to be hidden from the guest. This enables disabling of some paravirualization features in the guest as well as allowing certain drivers which test for the hypervisor to load. Domain XML syntax

Re: [libvirt] [PATCH v2 3/3] qemu: Automatically create NVRAM store

2014-08-15 Thread Laszlo Ersek
comments below On 08/15/14 15:43, Michal Privoznik wrote: When using split UEFI image, it may come handy if libvirt manages per domain _VARS file automatically. While the _CODE file is RO and can be shared among multiple domains, you certainly don't want to do that on the _VARS file. This

Re: [libvirt] [PATCH] qemuDomainFSFreeze: report unless the agent supports mountpoints param

2014-08-15 Thread Tomoki Sekiyama
Hi Michal, On 8/14/14, 2:58 , Michal Privoznik mpriv...@redhat.com wrote: On 13.08.2014 17:42, Tomoki Sekiyama wrote: This patch gives users a nicer error message when the QEMU guest agent is not new enough to support 'guest-fsfreeze-freeze-list' command, which is used by qemuDomainFSFreeze()

[libvirt] [PATCH 4/5] src/xenconfig: remove dead code

2014-08-15 Thread Jim Fehlig
Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/xenconfig/xen_xm.c | 5 - 1 file changed, 5 deletions(-) diff --git a/src/xenconfig/xen_xm.c b/src/xenconfig/xen_xm.c index 0402213..83cc8c6 100644 --- a/src/xenconfig/xen_xm.c +++ b/src/xenconfig/xen_xm.c @@ -29,7 +29,6 @@ #include

[libvirt] [PATCH 2/5] src/xenconfig: wrap common parsing code

2014-08-15 Thread Jim Fehlig
From: Kiarie Kahurani davidkiar...@gmail.com Wrap parsing code common to xm and xl in xenParseConfigCommon and export it. Signed-off-by: Kiarie Kahurani davidkiar...@gmail.com Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/xenconfig/xen_xm.c | 72

[libvirt] [PATCH 3/5] src/xenconfig: wrap common formatting code

2014-08-15 Thread Jim Fehlig
From: Kiarie Kahurani davidkiar...@gmail.com Wrap formatting code common to xm and xl in xenFormatConfigCommon and export it. Signed-off-by: Kiarie Kahurani davidkiar...@gmail.com Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/xenconfig/xen_xm.c | 73

[libvirt] [PATCH 1/5] xen: rename xenxs to xenconfig

2014-08-15 Thread Jim Fehlig
src/xenxs contains parsing/formating functions for the various xen config formats, and is better named src/xenconfig. Signed-off-by: Jim Fehlig jfeh...@suse.com --- cfg.mk | 2 +- configure.ac | 2 +-

[libvirt] [PATCH 0/5] rework layout of src/xenxs directory

2014-08-15 Thread Jim Fehlig
This series reworks the layout of src/xenxs directory, changing it to src/xenconfig and moving common XM and XL config parsing/formatting functions to src/xenconfig/xen_common.[ch]. Jim Fehlig (3): xen: rename xenxs to xenconfig src/xenconfig: remove dead code src/xenconfig: move common