Re: [libvirt] [PATCH] qemu: call endjob in RevertToSnapshot

2014-08-27 Thread Jincheng Miao
On 08/27/2014 07:52 PM, Eric Blake wrote: On 08/27/2014 03:20 AM, Jincheng Miao wrote: On 08/27/2014 11:02 AM, Eric Blake wrote: On 08/26/2014 08:10 PM, Jincheng Miao wrote: In qemuDomainRevertToSnapshot(), it will check snap->def->state. But when the state is PMSUSPENDED/NOSTATE/BLOCKED, it

Re: [libvirt] [PATCH] qemu: call endjob in RevertToSnapshot

2014-08-27 Thread Jincheng Miao
On 08/28/2014 10:09 AM, Jincheng Miao wrote: On 08/27/2014 07:52 PM, Eric Blake wrote: On 08/27/2014 03:20 AM, Jincheng Miao wrote: On 08/27/2014 11:02 AM, Eric Blake wrote: On 08/26/2014 08:10 PM, Jincheng Miao wrote: In qemuDomainRevertToSnapshot(), it will check snap->def->state. But whe

Re: [libvirt] [PATCH 06/19] qemu_agent: Resolve Coverity RESOURCE_LEAK

2014-08-27 Thread Wang Rui
On 2014/8/28 4:54, John Ferlan wrote: > Coverity found that on error paths, the 'arg' value wasn't be cleaned > up. Followed the example in qemuAgentSetVCPUs() where upon successful call > to qemuAgentCommand() the 'cpus' is set to NULL; otherwise, when cleanup > occurs the free the memory for 'arg

Re: [libvirt] [PATCH v1 6/6] ivshmem: add start param to server attribute

2014-08-27 Thread Wang Rui
On 2014/8/28 5:20, Maxime Leroy wrote: > On Tue, Aug 26, 2014 at 11:58 AM, Wang Rui wrote: >> On 2014/8/22 18:47, Maxime Leroy wrote: >> >>> +# util/virivshmemserver.h >>> +virStartIvshmemServer; >>> +virStopIvshmemServer; >> >> I think function name virIvshmemStartServer is better. >> So is the s

Re: [libvirt] [PATCHv2] virsh: fix keepalive error msg, man page update

2014-08-27 Thread Erik Skultety
Thank you for review. Sure, you're right, I'll definitely follow your advice next time. Erik On 08/27/2014 05:03 PM, Eric Blake wrote: On 08/27/2014 08:20 AM, Erik Skultety wrote: resolves https://bugzilla.redhat.com/show_bug.cgi?id=1132305 Please include a short summary of the BZ in the com

<    1   2