Re: [libvirt] [python PATCH 1/5] generator: enum: Don't sort enums by names

2014-08-29 Thread Pavel Hrdina
On 08/28/2014 06:38 PM, Eric Blake wrote: On 08/28/2014 10:32 AM, Peter Krempa wrote: Setting OCDs aside, sorting enums breaks if the definition contains links to other enums defined in the libvirt header before. Let the generator generate it in the natural order. --- generator.py | 2 --

Re: [libvirt] [python PATCH 2/5] API: Skip 'virDomainStatsRecordListFree'

2014-08-29 Thread Pavel Hrdina
On 08/28/2014 06:32 PM, Peter Krempa wrote: The new API function doesn't make sense to be exported in python. The bindings will return native types instead of the struct array. --- generator.py | 1 + 1 file changed, 1 insertion(+) diff --git a/generator.py b/generator.py index

[libvirt] [PATCH 01/11] qemu: extract helper to get the current balloon

2014-08-29 Thread Francesco Romani
Refactor the code to extract an helper method to get the current balloon settings. Signed-off-by: Francesco Romani from...@redhat.com --- src/qemu/qemu_driver.c | 98 ++ 1 file changed, 60 insertions(+), 38 deletions(-) diff --git

[libvirt] [PATCH 00/11] bulk stats: QEMU implementation

2014-08-29 Thread Francesco Romani
This patchset enhances the QEMU support for the new bulk stats API. What is added is the equivalent of these APIs: virDomainBlockInfo virDomainGetInfo - for balloon stats virDomainGetCPUStats virDomainBlockStatsFlags virDomainInterfaceStats virDomainGetVcpusFlags virDomainGetVcpus This subset of

[libvirt] [PATCH 02/11] qemu: extract helper to gather vcpu data

2014-08-29 Thread Francesco Romani
Extracts an helper to gether the VCpu information. Signed-off-by: Francesco Romani from...@redhat.com --- src/qemu/qemu_driver.c | 29 + 1 file changed, 25 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index

[libvirt] [PATCH 04/11] qemu: extract helper to get block info

2014-08-29 Thread Francesco Romani
Extract qemuDiskGetBlockInfo helper. This way, the very same code will be used both by existing qemuDomainGetBlockInfo API and by the new bulk stats API. Signed-off-by: Francesco Romani from...@redhat.com --- src/qemu/qemu_driver.c | 54 ++ 1 file

[libvirt] [PATCH 05/11] qemu: bulk stats: pass connection to workers

2014-08-29 Thread Francesco Romani
Future patches which will implement more bulk stats groups for QEMU will need to access the connection object, so enrich the worker prototype. Signed-off-by: Francesco Romani from...@redhat.com --- src/qemu/qemu_driver.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git

[libvirt] [PATCH 03/11] qemu: add helper to get the block stats

2014-08-29 Thread Francesco Romani
Add an helper function to get the block stats of a disk. This helper is meant to be used by the bulk stats API; future patches may want to refactor qemuDomainGetBlock* to make use of this function as well. Signed-off-by: Francesco Romani from...@redhat.com --- src/qemu/qemu_driver.c | 59

[libvirt] [PATCH 08/11] qemu: bulk stats: implement VCPU group

2014-08-29 Thread Francesco Romani
This patch implements the VIR_DOMAIN_STATS_VCPU group of statistics. Signed-off-by: Francesco Romani from...@redhat.com --- include/libvirt/libvirt.h.in | 1 + src/qemu/qemu_driver.c | 72 2 files changed, 73 insertions(+) diff --git

[libvirt] [PATCH 07/11] qemu: bulk stats: implement balloon group

2014-08-29 Thread Francesco Romani
This patch implements the VIR_DOMAIN_STATS_BALLOON group of statistics. Signed-off-by: Francesco Romani from...@redhat.com --- include/libvirt/libvirt.h.in | 1 + src/qemu/qemu_driver.c | 32 2 files changed, 33 insertions(+) diff --git

[libvirt] [PATCH 06/11] qemu: bulk stats: implement CPU stats group

2014-08-29 Thread Francesco Romani
This patch implements the VIR_DOMAIN_STATS_CPU_TOTAL group of statistics. Signed-off-by: Francesco Romani from...@redhat.com --- include/libvirt/libvirt.h.in | 1 + src/qemu/qemu_driver.c | 56 2 files changed, 57 insertions(+) diff --git

[libvirt] [PATCH 10/11] qemu: bulk stats: implement block group

2014-08-29 Thread Francesco Romani
This patch implements the VIR_DOMAIN_STATS_BLOCK group of statistics. Signed-off-by: Francesco Romani from...@redhat.com --- include/libvirt/libvirt.h.in | 1 + src/qemu/qemu_driver.c | 54 2 files changed, 55 insertions(+) diff --git

[libvirt] [PATCH 09/11] qemu: bulk stats: implement interface group

2014-08-29 Thread Francesco Romani
This patch implements the VIR_DOMAIN_STATS_INTERFACE group of statistics. Signed-off-by: Francesco Romani from...@redhat.com --- include/libvirt/libvirt.h.in | 1 + src/qemu/qemu_driver.c | 53 2 files changed, 54 insertions(+) diff --git

[libvirt] [PATCH 11/11] qemu: bulk stats: implement blockinfo group

2014-08-29 Thread Francesco Romani
This patch implements the VIR_DOMAIN_STATS_BLOCK_INFO group of statistics. This is different from the VIR_DOMAIN_STATS_BLOCK group because represents the information about the block device. Most notably, this group export the allocation information which is used by monitoring applications to

[libvirt] [PATCH 0/2] bulk api: implement block group

2014-08-29 Thread Li Wei
This patchset implement the block group for bulk stats, currently only support JSON monitor. Li Wei (2): qemu: implement block group for bulk stats. virsh: add block group for bulk stats. include/libvirt/libvirt.h.in | 1 + src/libvirt.c| 13 src/qemu/qemu_driver.c

[libvirt] [PATCH 2/2] virsh: add block group for bulk stats.

2014-08-29 Thread Li Wei
Add --block option to domstats command for querying block stats. Signed-off-by: Li Wei l...@cn.fujitsu.com --- tools/virsh-domain-monitor.c | 7 +++ tools/virsh.pod | 4 ++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/tools/virsh-domain-monitor.c

[libvirt] [PATCH 1/2] qemu: implement block group for bulk stats.

2014-08-29 Thread Li Wei
This patch add the block group for bulk stats. The following typed parameter used for each block stats: block.count - number of block devices in this domain block.0.name - name of the block device block.0.rd_bytes - number of read bytes block.0.rd_operations - number of read

[libvirt] [PATCH] Fix connection to already running session libvirtd

2014-08-29 Thread Christophe Fergeau
Since 1b807f92, connecting with virsh to an already running session libvirtd fails with: $ virsh list --all error: failed to connect to the hypervisor error: no valid connection error: Failed to connect socket to '/run/user/1000/libvirt/libvirt-sock': Transport endpoint is already connected This

Re: [libvirt] [PATCH] Fix connection to already running session libvirtd

2014-08-29 Thread Martin Kletzander
On Fri, Aug 29, 2014 at 10:37:21AM +0200, Christophe Fergeau wrote: Since 1b807f92, connecting with virsh to an already running session libvirtd fails with: $ virsh list --all error: failed to connect to the hypervisor error: no valid connection error: Failed to connect socket to

Re: [libvirt] Entering freeze for libvirt-1.2.8

2014-08-29 Thread Daniel Veillard
On Wed, Aug 27, 2014 at 08:45:29PM +0200, Richard Weinberger wrote: On Wed, Aug 27, 2014 at 9:18 AM, Daniel Veillard veill...@redhat.com wrote: So I tagged 1.2.8-rc1 in git and made tarball and signed rpms Can you please sign the tarball too? Okay, I went the simplest route of creating

[libvirt] [PATCH] conf: Check migration_host is valid or not during libvirt restarts

2014-08-29 Thread Chen Fan
if user specified an invalid strings as migration hostname, like setting: migration_host = XXX, libvirt should check it and return error during lbivirt restart. Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com --- src/qemu/qemu_conf.c | 40 1 file

Re: [libvirt] [PATCH] Fix connection to already running session libvirtd

2014-08-29 Thread Christophe Fergeau
Hey, On Fri, Aug 29, 2014 at 11:08:53AM +0200, Martin Kletzander wrote: Although my git was a bit confused by the diff included in the commit message. I'd suggest just saying that most of the commit is a whitespace change; people can see that using '-w' themselves. That toggle should even

[libvirt] [PATCH v2] Fix connection to already running session libvirtd

2014-08-29 Thread Christophe Fergeau
Since 1b807f92, connecting with virsh to an already running session libvirtd fails with: $ virsh list --all error: failed to connect to the hypervisor error: no valid connection error: Failed to connect socket to '/run/user/1000/libvirt/libvirt-sock': Transport endpoint is already connected This

[libvirt] [PATCH v2] Fix connection to already running session libvirtd

2014-08-29 Thread Christophe Fergeau
Since 1b807f92, connecting with virsh to an already running session libvirtd fails with: $ virsh list --all error: failed to connect to the hypervisor error: no valid connection error: Failed to connect socket to '/run/user/1000/libvirt/libvirt-sock': Transport endpoint is already connected This

Re: [libvirt] [PATCH] conf: Check migration_host is valid or not during libvirt restarts

2014-08-29 Thread Jiri Denemark
On Fri, Aug 29, 2014 at 19:20:58 +0800, Chen Fan wrote: if user specified an invalid strings as migration hostname, like setting: migration_host = XXX, libvirt should check it and return error during lbivirt restart. Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com ---

[libvirt] Availability of release candidate 2 for libvirt-1.2.8

2014-08-29 Thread Daniel Veillard
Also tagged, with signed tarball and rpms ;-) at the usual place: ftp://libvirt.org/libvirt/ there were quite a lot of small changes since rc1, so please give it some testing, also for portability to other systems/OSes. If everything goes well I will push the final 1.2.8 on Tuesday morning

Re: [libvirt] [Qemu-devel] IO accounting overhaul

2014-08-29 Thread Stefan Hajnoczi
On Thu, Aug 28, 2014 at 04:38:09PM +0200, Benoît Canet wrote: I collected some items of a cloud provider wishlist regarding I/O accouting. In a cloud I/O accouting can have 3 purpose: billing, helping the customers and doing metrology to help the cloud provider seeks hidden costs. I'll

Re: [libvirt] [PATCH] Fix connection to already running session libvirtd

2014-08-29 Thread Eric Blake
On 08/29/2014 06:17 AM, Christophe Fergeau wrote: Hey, On Fri, Aug 29, 2014 at 11:08:53AM +0200, Martin Kletzander wrote: Although my git was a bit confused by the diff included in the commit message. I'd suggest just saying that most of the commit is a whitespace change; people can see

Re: [libvirt] [Qemu-devel] IO accounting overhaul

2014-08-29 Thread Benoît Canet
The Friday 29 Aug 2014 à 17:04:46 (+0100), Stefan Hajnoczi wrote : On Thu, Aug 28, 2014 at 04:38:09PM +0200, Benoît Canet wrote: I collected some items of a cloud provider wishlist regarding I/O accouting. In a cloud I/O accouting can have 3 purpose: billing, helping the customers and

Re: [libvirt] [PATCH 1.2.8] storage: zfs: fix double listing of new volumes

2014-08-29 Thread Roman Bogorodskiy
John Ferlan wrote: On 08/27/2014 05:02 AM, Roman Bogorodskiy wrote: Currently, after calling commands to create a new volumes, virStorageBackendZFSCreateVol calls virStorageBackendZFSFindVols that calls virStorageBackendZFSParseVol. virStorageBackendZFSParseVol checks if a

Re: [libvirt] Cosmetic bug on libvirt.org

2014-08-29 Thread Roman Bogorodskiy
Christophe Fergeau wrote: Hey, I just noticed that clicking on FAQ in the left sidebar on libvirt.org main page highlights the Wiki cell instead of highlighting FAQ. I have no idea how the website works, so I'm just reporting it here. FAQ is not a part of the generated documentation but

Re: [libvirt] [PATCH v3] leaseshelper: improvements to support all events

2014-08-29 Thread Nehal J Wani
On Wed, Aug 20, 2014 at 4:23 PM, Roman Bogorodskiy bogorods...@gmail.com wrote: Nehal J Wani wrote: This patch enables the helper program to detect event(s) triggered when there is a change in lease length or expiry and client-id. This transfers complete control of leases database to