Re: [libvirt] [PATCH v3 12/18] blockcopy: expose new API in virsh

2014-09-06 Thread Eric Blake
On 09/05/2014 03:41 AM, Peter Krempa wrote: On 08/31/14 06:02, Eric Blake wrote: Expose the new power of virDomainBlockCopy through virsh (well, all but the finer-grained bandwidth, as that is its own can of worms for a later patch). Continue to use the older API where possible, for maximum

Re: [libvirt] [PATCH 1/5] qemu: Rename DEFAULT_JOB_MASK to QEMU_DEFAULT_JOB_MASK

2014-09-06 Thread Eric Blake
On 09/03/2014 07:53 AM, Peter Krempa wrote: Be consistend with naming of private defines. Also line up code s/consistend/consistent/ correctly in few places where the macro is used. --- src/qemu/qemu_domain.c| 2 +- src/qemu/qemu_domain.h| 2 +- src/qemu/qemu_driver.c| 8

Re: [libvirt] [PATCH 2/5] qemu: snapshot: Fix job handling when creating snapshots

2014-09-06 Thread Eric Blake
On 09/03/2014 07:53 AM, Peter Krempa wrote: Creating snapshots modifies the domain state. Currently we wouldn't enter the job for certain operations although they would modify the state. Refactor job handling so that everything is covered by an async job. --- src/qemu/qemu_driver.c | 176

Re: [libvirt] [PATCH v2 2/2] parallels: login to parallels SDK

2014-09-06 Thread Dmitry Guryanov
On Thursday 04 September 2014 16:00:48 Michal Privoznik wrote: On 22.08.2014 19:48, Dmitry Guryanov wrote: Add files parallels_sdk.c and parallels_sdk.h for code @@ -999,8 +1022,17 @@ parallelsConnectClose(virConnectPtr conn) virObjectUnref(privconn-caps);

[libvirt] [PATCH v2 2/2] parallels: login to parallels SDK

2014-09-06 Thread Dmitry Guryanov
Add files parallels_sdk.c and parallels_sdk.h for code which works with SDK, so libvirt's code will not mix with dealing with parallels SDK. To use Parallels SDK you must first call PrlApi_InitEx function, and then you will be able to connect to a server with PrlSrv_LoginLocalEx function. When

[libvirt] [PATCH v2 1/2] parallels: build with parallels SDK

2014-09-06 Thread Dmitry Guryanov
Executing prlctl command is not an optimal way to interact with Parallels Cloud Server (PCS), it's better to use parallels SDK, which is a remote API to paralles dispatcher service. We prepared opensource version of this SDK and published it on github, it's distributed under LGPL license. Here is

[libvirt] [PATCH v2 0/2] parallels: use parallels SDK instead of prlctl tool

2014-09-06 Thread Dmitry Guryanov
This patchset begins reworking of parallels driver. We have published Opensource version of parallels SDK (under LGPL license), so libvirt can link with it. Dmitry Guryanov (2): parallels: build with parallels SDK parallels: login to parallels SDK configure.ac | 24 ++--

Re: [libvirt] [PATCH 3/5] qemu: snapshot: Acquire job earlier on snapshot revert/delete

2014-09-06 Thread Eric Blake
On 09/03/2014 07:53 AM, Peter Krempa wrote: From: Jincheng Miao jm...@redhat.com The code would lookup the snapshot object before acquiring the job. This could lead to a crash as one thread could delete the snapshot object, while a second thread already had the reference. Signed-off-by:

Re: [libvirt] [PATCH 4/5] qemu: snapshot: Fix snapshot function header formatting

2014-09-06 Thread Eric Blake
On 09/03/2014 07:53 AM, Peter Krempa wrote: --- src/qemu/qemu_driver.c | 38 +++--- 1 file changed, 23 insertions(+), 15 deletions(-) @@ -13614,8 +13616,9 @@ static int qemuDomainSnapshotListNames(virDomainPtr domain, char **names, return n; }

Re: [libvirt] [PATCH 5/5] qemu: snapshot: Simplify error paths

2014-09-06 Thread Eric Blake
On 09/03/2014 07:53 AM, Peter Krempa wrote: Return failure right away when the domain object can't be looked up instead of jumping to cleanup. This allows to remove the condition before unlocking the domain object. --- src/qemu/qemu_driver.c | 65

[libvirt] [PATCH V1 4/4] tests: Tests for the xen-xl parser

2014-09-06 Thread Kiarie Kahurani
add tests for the xen_xl config parser Signed-off-by: Kiarie Kahurani davidkiar...@gmail.com --- tests/Makefile.am| 9 +- tests/testutilsxen.c | 50 + tests/testutilsxen.h | 9 +-

[libvirt] [PATCH V1 0/4] xen-xl parser

2014-09-06 Thread Kiarie Kahurani
Kiarie Kahurani (4): src/xenconfig: Export helper functions src/xenconfig: Xen-xl parser src/xenconfig: Introduce xen-xl on virsh command line tests: Tests for the xen-xl parser configure.ac | 5 +- src/Makefile.am |

[libvirt] [PATCH V1 1/4] src/xenconfig: Export helper functions

2014-09-06 Thread Kiarie Kahurani
Export helper function for reuse in getting values from a virConfPtr object Signed-off-by: Kiarie Kahurani davidkiar...@gmail.com --- src/xenconfig/xen_common.c | 144 ++--- src/xenconfig/xen_common.h | 24 ++-- 2 files changed, 91 insertions(+), 77

[libvirt] [PATCH V1 3/4] src/xenconfig: Introduce xen-xl on virsh command line

2014-09-06 Thread Kiarie Kahurani
Integrate the xl parser into the xenlight driver Signed-off-by: Kiarie Kahurani davidkiar...@gmail.com --- src/libxl/libxl_driver.c | 46 ++ 1 file changed, 34 insertions(+), 12 deletions(-) diff --git a/src/libxl/libxl_driver.c

[libvirt] [PATCH V1 2/4] src/xenconfig: Xen-xl parser

2014-09-06 Thread Kiarie Kahurani
Introduce a xen xl parser This parser allows for users to convert the new xl disk format and spice graphics config to libvirt xml format and vice versa.Regarding the spice graphics config, the code is pretty much straight forward For the disk {formating, parsing} this parser takes care of the new

[libvirt] [PATCH] openvz: fixed an config file parsing error

2014-09-06 Thread Hongbin Lu
The OpenVZ driver reported an error on parsing some OpenVZ config parameters (e.g. diskspace). This issue is due to the driver made two incorrect assumptions about the value of the parameters: 1. Assume paramaeter is just a number (without unit suffix). 2. Assume the number is an integer.

Re: [libvirt] [PATCH] openvz: fixed an config file parsing error

2014-09-06 Thread Hongbin Lu
Thanks Eric. I modified the fix accordingly. https://www.redhat.com/archives/libvir-list/2014-September/msg00363.html Best regards, Hongbin On Wed, Sep 3, 2014 at 12:19 PM, Eric Blake ebl...@redhat.com wrote: On 09/03/2014 09:55 AM, Hongbin Lu wrote: The OpenVZ driver reported an error on

[libvirt] [PATCH v2] maint: update to latest gnulib

2014-09-06 Thread Eric Blake
The usual portability fixes; and this includes a fix that adds a new syntax check for double semicolons (commit 28de556 fixed some, but gnulib found a better check). * .gnulib: Update to latest. * src/xenconfig/xen_common.c (xenFormatConfigCommon): Fix offender. Signed-off-by: Eric Blake

Re: [libvirt] [PATCH v3 13/18] blockcopy: remote implementation for new API

2014-09-06 Thread Eric Blake
On 09/05/2014 03:42 AM, Peter Krempa wrote: On 08/31/14 06:02, Eric Blake wrote: Fairly straightforward - I got lucky that the generated functions worked out of the box :) * src/remote/remote_protocol.x (remote_domain_block_copy_args): New struct. (REMOTE_PROC_DOMAIN_BLOCK_COPY): New RPC.