Re: [libvirt] [PATCH] virsh: additional scaled output units

2014-09-09 Thread Peter Krempa
On 09/09/14 06:11, Eric Blake wrote: > The parser accepts P and E, so the formatter should too. > > * tools/virsh.c (vshPrettyCapacity): Handle larger units. > > Signed-off-by: Eric Blake > --- > tools/virsh.c | 38 -- > 1 file changed, 28 insertions(+), 10 d

Re: [libvirt] [PATCH 13/26] qemu: Resolve Coverity FORWARD_NULL

2014-09-09 Thread Wang Rui
On 2014/9/5 6:26, John Ferlan wrote: > If the virJSONValueNewObject() fails, then rather than going to error > and getting a Coverity false positive since it doesn't seem to understand > the relationship between nkeywords, keywords, and values and seems to > believe calling qemuFreeKeywords will ca

Re: [libvirt] [PATCH 0/7] Add more options for IOThreads

2014-09-09 Thread Stefan Hajnoczi
On Wed, Sep 3, 2014 at 5:15 PM, John Ferlan wrote: > The following patches will add more support for IOThreads not completed > from the initial patches. These changes support the remaining elements of > bz https://bugzilla.redhat.com/show_bug.cgi?id=1101574 (working through > unsetting the private

[libvirt] [PATCH 0/5] Fix starting of VMs with backing chains containing unknown backing file specification

2014-09-09 Thread Peter Krempa
When a backing chain element specifies a parent in a format not known to libvirt we'd fail to start the VM as the chain would appear broken. To prevent this happening introduce a new disk type to collect unknow format specs and avoid startup failures with such disk type. Peter Krempa (5): util:

[libvirt] [PATCH 3/5] conf: Mark backing chain ending with "raw" volume as broken

2014-09-09 Thread Peter Krempa
Do not output the element in the xml if the backing chain ends with a volume specification unknown by libvirt. --- src/conf/domain_conf.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 189a4e8..2170607 100644 --- a/src

[libvirt] [PATCH 5/5] utils: storage: Fall back to "raw" disk on backing store parse failure

2014-09-09 Thread Peter Krempa
When libvirt can't parse the backing store format for some reasons we should fall back to something safe rather than marking the backing chain as broken. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1134878 --- src/util/virstoragefile.c | 14 -- 1 file changed, 12 insertions(

[libvirt] [PATCH 2/5] conf: Introduce raw disk string passthrough

2014-09-09 Thread Peter Krempa
This patch adds a new disk type "raw" that can be used twofold: 1) To pass arbitrary strings as disk sources to the hypervisor of choice. This allows to use not-yet-supported storage specification formats. 2) To return backing chain element names that libvirt doesn't yet know how to parse. Backin

[libvirt] [PATCH 4/5] tests: Add tests for disk type 'raw'

2014-09-09 Thread Peter Krempa
Test the qemu command generator and the xml parsers and formatters. The tests are added separately due to the size of the test files. Note that tests/qemuxml2argvdata/qemuxml2argv-disk-virtio-raw.args is split into lines in a weird way as "sc_prohibit_long_lines" forced me to. --- .../qemuxml2arg

[libvirt] [PATCH 1/5] util: storage: Convert disk locality check to switch statement

2014-09-09 Thread Peter Krempa
To allow the compiler to track future additions of disk types, convert the function to use a switch statement with the correct type. --- src/util/virstoragefile.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/src/util/virstoragefile.c b/src/util/virstoragefi

Re: [libvirt] [Xen-devel] [libvirt bisection] complete build-armhf-libvirt

2014-09-09 Thread Ian Campbell
Xen's automated testing of libvirt against newer Xen's has found a build issue which it has bisected down to "blockcopy: expose new API in virsh". An instance of the failure can be found in flight 30154: http://lists.xen.org/archives/html/xen-devel/2014-09/msg01063.html links to the logs =

Re: [libvirt] [Xen-devel] [libvirt bisection] complete build-armhf-libvirt

2014-09-09 Thread Daniel P. Berrange
On Tue, Sep 09, 2014 at 09:49:47AM +0100, Ian Campbell wrote: > Xen's automated testing of libvirt against newer Xen's has found a build > issue which it has bisected down to "blockcopy: expose new API in > virsh". > > An instance of the failure can be found in flight 30154: > http://lists.xen.org

Re: [libvirt] [Xen-devel] [libvirt bisection] complete build-armhf-libvirt

2014-09-09 Thread Ján Tomko
On 09/09/2014 10:49 AM, Ian Campbell wrote: > Xen's automated testing of libvirt against newer Xen's has found a build > issue which it has bisected down to "blockcopy: expose new API in > virsh". > > An instance of the failure can be found in flight 30154: > http://lists.xen.org/archives/html/xen

Re: [libvirt] [PATCH 5/5] utils: storage: Fall back to "raw" disk on backing store parse failure

2014-09-09 Thread Daniel P. Berrange
On Tue, Sep 09, 2014 at 10:45:48AM +0200, Peter Krempa wrote: > When libvirt can't parse the backing store format for some reasons we > should fall back to something safe rather than marking the backing chain > as broken. I'm not really convinced that falling back to raw is the "safe" option vs re

Re: [libvirt] [Xen-devel] [libvirt bisection] complete build-armhf-libvirt

2014-09-09 Thread Ian Campbell
On Tue, 2014-09-09 at 09:54 +0100, Daniel P. Berrange wrote: > On Tue, Sep 09, 2014 at 09:49:47AM +0100, Ian Campbell wrote: > > Xen's automated testing of libvirt against newer Xen's has found a build > > issue which it has bisected down to "blockcopy: expose new API in > > virsh". > > > > An ins

Re: [libvirt] [PATCH 5/5] utils: storage: Fall back to "raw" disk on backing store parse failure

2014-09-09 Thread Peter Krempa
On 09/09/14 11:01, Daniel P. Berrange wrote: > On Tue, Sep 09, 2014 at 10:45:48AM +0200, Peter Krempa wrote: >> When libvirt can't parse the backing store format for some reasons we >> should fall back to something safe rather than marking the backing chain >> as broken. > > I'm not really convinc

Re: [libvirt] [PATCH 5/5] utils: storage: Fall back to "raw" disk on backing store parse failure

2014-09-09 Thread Daniel P. Berrange
On Tue, Sep 09, 2014 at 11:04:18AM +0200, Peter Krempa wrote: > On 09/09/14 11:01, Daniel P. Berrange wrote: > > On Tue, Sep 09, 2014 at 10:45:48AM +0200, Peter Krempa wrote: > >> When libvirt can't parse the backing store format for some reasons we > >> should fall back to something safe rather th

Re: [libvirt] [PATCH 4/6] qemu: Transfer migration statistics to destination

2014-09-09 Thread Jiri Denemark
On Fri, Sep 05, 2014 at 14:47:09 -0400, John Ferlan wrote: > > > On 09/01/2014 11:05 AM, Jiri Denemark wrote: > > When migrating a transient domain or with VIR_MIGRATE_UNDEFINE_SOURCE > > flag, the domain may disappear from source host. And so will migration > > statistics associated with the dom

Re: [libvirt] [PATCH 5/6] qemu: Recompute downtime and total time when migration completes

2014-09-09 Thread Jiri Denemark
On Fri, Sep 05, 2014 at 14:47:35 -0400, John Ferlan wrote: > > > On 09/01/2014 11:05 AM, Jiri Denemark wrote: > > Total time of a migration and total downtime transfered from a source to > > a destination host do not count with the transfer time to the > > destination host and with the time elaps

Re: [libvirt] [PATCH] network: check for invalid forward delay time

2014-09-09 Thread Erik Skultety
Thank you John for your review, however, before I send another patch I'd like to know your (or someone else's) opinion on my notes/thoughts I posted below. Erik On 09/08/2014 10:16 PM, John Ferlan wrote: On 09/08/2014 10:49 AM, Erik Skultety wrote: When spanning tree protocol is allowed in

[libvirt] [PATCH v2 2/8] qemu: Avoid incrementing jobs_queued if virTimeMillisNow fails

2014-09-09 Thread Jiri Denemark
Signed-off-by: Jiri Denemark --- Notes: Version 2: - new (unrelated) patch src/qemu/qemu_domain.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 7b54306..8c94e27 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qe

[libvirt] [PATCH v2 5/8] virsh: Add support for completed job stats

2014-09-09 Thread Jiri Denemark
New --completed flag for virsh domjobinfo command. Signed-off-by: Jiri Denemark --- Notes: Version 2: - enhanced virsh man page tools/virsh-domain.c | 27 --- tools/virsh.pod | 7 +-- 2 files changed, 29 insertions(+), 5 deletions(-) diff --git a/tool

[libvirt] [PATCH v2 0/8] Add support for fetching statistics of completed jobs

2014-09-09 Thread Jiri Denemark
Using virDomainGetJobStats, we can monitor running jobs but sometimes it may be useful to get statistics about a job that already finished, for example, to get the final amount of data transferred during migration or to get an idea about total downtime. This is what the following patches are about.

[libvirt] [PATCH v2 4/8] qemu: Silence coverity on optional migration stats

2014-09-09 Thread Jiri Denemark
Signed-off-by: Jiri Denemark --- Notes: Version 2: - new (unrelated) patch src/qemu/qemu_monitor_json.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 0aa34b8..60e6b00 100644 --- a/src/qemu/qem

[libvirt] [PATCH v2 8/8] qemu: Transfer recomputed stats back to source

2014-09-09 Thread Jiri Denemark
After the previous commit, migration statistics on the source and destination hosts are not equal because the destination updated time statistics. Let's send the result back so that the same data can be queried on both sides of the migration. Signed-off-by: Jiri Denemark --- Notes: Version 2

[libvirt] [PATCH v2 7/8] qemu: Recompute downtime and total time when migration completes

2014-09-09 Thread Jiri Denemark
Total time of a migration and total downtime transfered from a source to a destination host do not count with the transfer time to the destination host and with the time elapsed before guest CPUs are resumed. Thus, source libvirtd remembers when migration started and when guest CPUs were paused. Bo

[libvirt] [PATCH v2 6/8] qemu: Transfer migration statistics to destination

2014-09-09 Thread Jiri Denemark
When migrating a transient domain or with VIR_MIGRATE_UNDEFINE_SOURCE flag, the domain may disappear from source host. And so will migration statistics associated with the domain. We need to transfer the statistics at the end of a migration so that they can be queried at the destination host. Sign

[libvirt] [PATCH v2 3/8] Add support for fetching statistics of completed jobs

2014-09-09 Thread Jiri Denemark
virDomainGetJobStats gains new VIR_DOMAIN_JOB_STATS_COMPLETED flag that can be used to fetch statistics of a completed job rather than a currently running job. Signed-off-by: Jiri Denemark --- Notes: Version 2: - no change include/libvirt/libvirt.h.in | 11 +++ src/libvirt.c

[libvirt] [PATCH v2 1/8] Refactor job statistics

2014-09-09 Thread Jiri Denemark
Job statistics data were tracked in several structures and variables. Let's make a new qemuDomainJobInfo structure which can be used as a single source of statistics data as a preparation for storing data about completed a job. Signed-off-by: Jiri Denemark --- Notes: Version 2: - added A

Re: [libvirt] [PATCH] virNetSocketNewConnectUNIX: create socket dir if needed

2014-09-09 Thread Jiri Denemark
On Tue, Sep 09, 2014 at 03:40:48 +, Serge Hallyn wrote: > Since 1b807f92dbb617db5b9d551777d3026d8ff0903f, if ~/.cache > does not exist, 'virsh -c qemu:///session' fails, because > it attempts to bind to ~/.cache/libvirt/libvirt-sock. > > Create the socket's directory if needed. This and sever

Re: [libvirt] [PATCH 13/26] qemu: Resolve Coverity FORWARD_NULL

2014-09-09 Thread John Ferlan
On 09/09/2014 03:36 AM, Wang Rui wrote: > On 2014/9/5 6:26, John Ferlan wrote: >> If the virJSONValueNewObject() fails, then rather than going to error >> and getting a Coverity false positive since it doesn't seem to understand >> the relationship between nkeywords, keywords, and values and seem

Re: [libvirt] [PATCH 0/5] Fix problems caused by FD passing to session daemon

2014-09-09 Thread Richard W.M. Jones
On Mon, Sep 08, 2014 at 07:46:34AM +0200, Martin Kletzander wrote: > There were various problems introduced by the series on FD passing. > The path for the socket was not created, the socket was not removed > before binding it, etc. Let's see if it's any better this time. > > Resolves: https://bu

[libvirt] [PATCH] qemu: Pass file descriptor when using TPM passthrough

2014-09-09 Thread Stefan Berger
From: Stefan Berger Pass the TPM file descriptor to QEMU via command line. Instead of passing /dev/tpm0 we now pass /dev/fdset/10 and the additional parameters -add-fd set=10,fd=20. This addresses the use case when QEMU is started with non-root privileges and QEMU cannot open /dev/tpm0 for examp

Re: [libvirt] [PATCH 0/5] Fix starting of VMs with backing chains containing unknown backing file specification

2014-09-09 Thread Richard W.M. Jones
On Tue, Sep 09, 2014 at 10:45:43AM +0200, Peter Krempa wrote: > When a backing chain element specifies a parent in a format not known to > libvirt > we'd fail to start the VM as the chain would appear broken. > > To prevent this happening introduce a new disk type to collect > unknow format specs

Re: [libvirt] [PATCHv3 5/8] qemu: bulk stats: implement interface group

2014-09-09 Thread Peter Krempa
On 09/08/14 15:05, Francesco Romani wrote: > This patch implements the VIR_DOMAIN_STATS_INTERFACE > group of statistics. > > Signed-off-by: Francesco Romani > --- > include/libvirt/libvirt.h.in | 1 + > src/libvirt.c| 14 +++ > src/qemu/qemu_driver.c | 87 > ++

Re: [libvirt] [PATCH 0/5] Fix starting of VMs with backing chains containing unknown backing file specification

2014-09-09 Thread Richard W.M. Jones
On Tue, Sep 09, 2014 at 12:38:04PM +0100, Richard W.M. Jones wrote: > Unfortunately this reveals another bug, which is that the SSH_* > variables that are required by the ssh driver are not passed through > to libvirtd. Ho hum. Filed as: https://bugzilla.redhat.com/show_bug.cgi?id=1139659 Rich.

Re: [libvirt] [PATCHv3 3/8] qemu: bulk stats: implement balloon group

2014-09-09 Thread Peter Krempa
On 09/08/14 15:05, Francesco Romani wrote: > This patch implements the VIR_DOMAIN_STATS_BALLOON > group of statistics. > > Signed-off-by: Francesco Romani > --- > include/libvirt/libvirt.h.in | 1 + > src/libvirt.c| 6 > src/qemu/qemu_driver.c | 70 > +++

Re: [libvirt] [PATCHv3 2/8] qemu: bulk stats: implement CPU stats group

2014-09-09 Thread Peter Krempa
On 09/08/14 15:05, Francesco Romani wrote: > This patch implements the VIR_DOMAIN_STATS_CPU_TOTAL > group of statistics. > > Signed-off-by: Francesco Romani > --- > include/libvirt/libvirt.h.in | 1 + > src/libvirt.c| 9 > src/qemu/qemu_driver.c | 51 > +

Re: [libvirt] [PATCHv3 2/8] qemu: bulk stats: implement CPU stats group

2014-09-09 Thread Francesco Romani
- Original Message - > From: "Peter Krempa" > To: "Francesco Romani" , libvir-list@redhat.com > Sent: Tuesday, September 9, 2014 1:50:25 PM > Subject: Re: [libvirt] [PATCHv3 2/8] qemu: bulk stats: implement CPU stats > group > > On 09/08/14 15:05, Francesco Romani wrote: > > This patch i

Re: [libvirt] [PATCHv3 4/8] qemu: bulk stats: implement VCPU group

2014-09-09 Thread Peter Krempa
On 09/08/14 15:05, Francesco Romani wrote: > This patch implements the VIR_DOMAIN_STATS_VCPU > group of statistics. > To do so, this patch also extracts a helper to gather the > VCpu information. > > Signed-off-by: Francesco Romani > --- > include/libvirt/libvirt.h.in | 1 + > src/libvirt.c

Re: [libvirt] [PATCHv3 3/8] qemu: bulk stats: implement balloon group

2014-09-09 Thread Francesco Romani
- Original Message - > From: "Peter Krempa" > To: "Francesco Romani" , libvir-list@redhat.com > Sent: Tuesday, September 9, 2014 1:45:57 PM > Subject: Re: [libvirt] [PATCHv3 3/8] qemu: bulk stats: implement balloon > group > > On 09/08/14 15:05, Francesco Romani wrote: > > This patc

Re: [libvirt] [PATCH 8/8] virsh: add options to query bulk stats group

2014-09-09 Thread Peter Krempa
On 09/08/14 15:05, Francesco Romani wrote: > Exports to the domstats commands the new bulk stats groups. > > Signed-off-by: Francesco Romani > --- > tools/virsh-domain-monitor.c | 35 +++ > tools/virsh.pod | 4 +++- > 2 files changed, 38 insertions(+

Re: [libvirt] [PATCH 1/8] qemu: bulk stats: extend internal collection API

2014-09-09 Thread Peter Krempa
On 09/08/14 15:05, Francesco Romani wrote: > Future patches which will implement more > bulk stats groups for QEMU will need to access > the connection object. > > To accomodate that, a few changes are needed: > > * enrich internal prototype to pass connection object. > * add per-group flag to ma

[libvirt] [PATCH] node_device_udev: Try harder to get human readable vendor:product

2014-09-09 Thread Lubomir Rintel
The manufacurer and product from USB device itself are usually not particularly useful -- they tend to be missing, or ugly (all-uppercase, padded with spaces, etc.). Prefer what's in the usb id database and fall back to descriptors only if the device is too now to be in database. --- Before: http:/

Re: [libvirt] [PATCHv3 6/8] qemu: bulk stats: implement block group

2014-09-09 Thread Peter Krempa
On 09/08/14 15:05, Francesco Romani wrote: > This patch implements the VIR_DOMAIN_STATS_BLOCK > group of statistics. > > To do so, an helper function to get the block stats > of all the disks of a domain is added. > > Signed-off-by: Francesco Romani > --- > include/libvirt/libvirt.h.in | 1 +

Re: [libvirt] [PATCHv3 7/8] qemu: bulk stats: add block allocation information

2014-09-09 Thread Peter Krempa
On 09/08/14 15:05, Francesco Romani wrote: > Management software, want to be able to allocate disk space on demand. s/, want/ wants/ > To support this, they need keep track of the space occupation s/,// > of the block device. > This information is reported by qemu as part of block stats. > > T

Re: [libvirt] [PATCH V3 0/3] Some improvements for video model

2014-09-09 Thread Wang Rui
Sorry for pinging again so soon. Defer reviewing is OK. Keep your schedule first. Could someone please spend some time to review these patches or recommend me a *right* maintainer in libvirt? I will be on holiday from this weekend to Oct 8th. If anyone has comments on these patches, just reply as

Re: [libvirt] [PATCH] virNetSocketNewConnectUNIX: create socket dir if needed

2014-09-09 Thread Serge Hallyn
Quoting Jiri Denemark (jdene...@redhat.com): > On Tue, Sep 09, 2014 at 03:40:48 +, Serge Hallyn wrote: > > Since 1b807f92dbb617db5b9d551777d3026d8ff0903f, if ~/.cache > > does not exist, 'virsh -c qemu:///session' fails, because > > it attempts to bind to ~/.cache/libvirt/libvirt-sock. > > > >

Re: [libvirt] [PATCH] virsh: additional scaled output units

2014-09-09 Thread Eric Blake
On 09/09/2014 01:28 AM, Peter Krempa wrote: > On 09/09/14 06:11, Eric Blake wrote: >> The parser accepts P and E, so the formatter should too. >> >> * tools/virsh.c (vshPrettyCapacity): Handle larger units. >> >> Signed-off-by: Eric Blake >> --- >> tools/virsh.c | 38 -

Re: [libvirt] [PATCH v6 3/3] qemu: Automatically create NVRAM store

2014-09-09 Thread Ján Tomko
On 09/01/2014 05:22 PM, Michal Privoznik wrote: > When using split UEFI image, it may come handy if libvirt manages per > domain _VARS file automatically. While the _CODE file is RO and can be > shared among multiple domains, you certainly don't want to do that on > the _VARS file. This latter one

Re: [libvirt] [PATCH v6 1/3] conf: Extend and introduce

2014-09-09 Thread Ján Tomko
On 09/01/2014 05:22 PM, Michal Privoznik wrote: > Up to now, users can configure BIOS via the element. With > the upcoming implementation of UEFI this is not enough as BIOS and > UEFI are conceptually different. For instance, while BIOS is ROM, UEFI > is programmable flash (although all writes to

Re: [libvirt] [PATCH v6 2/3] qemu: Implement extended loader and nvram

2014-09-09 Thread Ján Tomko
On 09/01/2014 05:22 PM, Michal Privoznik wrote: > QEMU now supports UEFI with the following command line: > > -drive > file=/usr/share/OVMF/OVMF_CODE.fd,if=pflash,format=raw,unit=0,readonly=on \ > -drive file=/usr/share/OVMF/OVMF_VARS.fd,if=pflash,format=raw,unit=1 \ > > where the first line

[libvirt] [PATCH 3/4] qemu: dump: Fix formatting of function headers and code inline

2014-09-09 Thread Peter Krempa
Also drop a comment with obvious content. --- src/qemu/qemu_driver.c | 31 --- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index d724eeb..f0e8994 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_

[libvirt] [PATCH 1/4] util: process: Don't report OOM errors in helper

2014-09-09 Thread Peter Krempa
virProcessTranslateStatus is used on error paths that should not spoil the returned error. As the errors are ignored, use the quiet versions of virAsprintf to create the message. --- src/util/virprocess.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/util/virpr

[libvirt] [PATCH 4/4] qemu: dump: Resume CPUs only when the VM is still alive

2014-09-09 Thread Peter Krempa
Check if the VM is alive after we possibly called into monitor to reset the guest. --- src/qemu/qemu_driver.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index f0e8994..9765af5 100644 --- a/src/qemu/qemu_

[libvirt] [PATCH 0/4] Few unrelated fixes in save/dump code

2014-09-09 Thread Peter Krempa
I spent some time in the save/dump code today and found a few nits to fix. Peter Krempa (4): util: process: Don't report OOM errors in helper virsh: domain: Clean up handling of "dom" in "save" command qemu: dump: Fix formatting of function headers and code inline qemu: dump: Resume CPUs o

[libvirt] [PATCH 2/4] virsh: domain: Clean up handling of "dom" in "save" command

2014-09-09 Thread Peter Krempa
--- tools/virsh-domain.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index ed2e3ea..f04dd17 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -3887,7 +3887,8 @@ doSave(void *opaque) out: pthread_sigmask(

Re: [libvirt] [PATCH] storage: zfs: implement pool build and delete

2014-09-09 Thread Ján Tomko
On 09/07/2014 04:15 PM, Roman Bogorodskiy wrote: > Provide an implementation for buildPool and deletePool operations for > the ZFS storage backend. > --- > docs/schemas/storagepool.rng | 1 + > src/storage/storage_backend_zfs.c | 57 > +++ > 2 files chang

Re: [libvirt] [PATCH 1/8] qemu: bulk stats: extend internal collection API

2014-09-09 Thread Francesco Romani
- Original Message - > From: "Peter Krempa" > To: "Francesco Romani" , libvir-list@redhat.com > Sent: Tuesday, September 9, 2014 2:14:23 PM > Subject: Re: [libvirt] [PATCH 1/8] qemu: bulk stats: extend internal > collection API > > On 09/08/14 15:05, Francesco Romani wrote: > > Future

[libvirt] lxc: shutdown $domain broken in libvirt 1.2.3

2014-09-09 Thread Steven Wilson
We recently ran into libvirt lxc shutdown failing because of mount namespaces not being available: # virsh -c lxc:/// start test01 Domain test01 started # virsh -c lxc:/// list IdName State 9336 test01

Re: [libvirt] [PATCH 0/2] [RFC] Use the power of SystemTap to get rid of all* deadlocks forever*

2014-09-09 Thread Martin Kletzander
On Mon, Sep 08, 2014 at 03:59:04PM +0100, Daniel P. Berrange wrote: On Mon, Sep 08, 2014 at 04:17:44PM +0200, Martin Kletzander wrote: Many moons ago, I wanted to make locking more debuggable from logs. An idea appeared that this might be better off with SystemTap. I let it rot for a while and

Re: [libvirt] [PATCH 0/4] Few unrelated fixes in save/dump code

2014-09-09 Thread Martin Kletzander
On Tue, Sep 09, 2014 at 05:25:31PM +0200, Peter Krempa wrote: I spent some time in the save/dump code today and found a few nits to fix. Peter Krempa (4): util: process: Don't report OOM errors in helper virsh: domain: Clean up handling of "dom" in "save" command qemu: dump: Fix formatting of

[libvirt] [PATCH 1/2] for dhclient use g_spawn_sync instead of g_spawn_async

2014-09-09 Thread Gene Czarcinski
For some (unknown) reason, g_spawn_async() is not starting dhclient so that a dhcp NIC can be configured. However, simply using g_spawn_sync() works. This was the only use of g_spawn_async(). Note: There is no problem using sync instead of async since dhclient will disconnect and put itself in t

[libvirt] [PATCH 0/2] bugfix: support dhcp network interfaces

2014-09-09 Thread Gene Czarcinski
Support for a network such as -N dhcp,source=default was not working in that dhclient was not being started. Although I am not sure what the real problem is, the solution is to use g_spawn_sync() instead of g_spawn_async() to start /sbin/dhclient. The second patch addes "-v" to the dhclient argu

[libvirt] [PATCH 2/2] add -v to dhclient parameter arguments

2014-09-09 Thread Gene Czarcinski
This improves the ablityh to diagnose problems. --- libvirt-sandbox/libvirt-sandbox-init-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt-sandbox/libvirt-sandbox-init-common.c b/libvirt-sandbox/libvirt-sandbox-init-common.c index 49baa5c..056cbc2 100644 --- a/l

Re: [libvirt] DHCP and secure containers

2014-09-09 Thread Gene Czarcinski
On 09/07/2014 05:54 PM, Gene Czarcinski wrote: On 09/07/2014 11:03 AM, Gene Czarcinski wrote: On 09/03/2014 09:42 AM, Gene Czarcinski wrote: On 09/02/2014 06:37 AM, Gene Czarcinski wrote: OK, hopefully this mailing list is more active and I can get some response to my questions. --

Re: [libvirt] [PATCH 0/2] bugfix: support dhcp network interfaces

2014-09-09 Thread Eric Blake
On 09/09/2014 12:50 PM, Gene Czarcinski wrote: > > Support for a network such as -N dhcp,source=default was not working > in that dhclient was not being started. Although I am not sure what > the real problem is, the solution is to use g_spawn_sync() instead of > g_spawn_async() to start /sbin/dh

Re: [libvirt] [PATCH V1 2/4] src/xenconfig: Xen-xl parser

2014-09-09 Thread Jim Fehlig
Kiarie Kahurani wrote: > Introduce a xen xl parser > > This parser allows for users to convert the new xl disk format and > spice graphics config to libvirt xml format and vice versa.Regarding > the spice graphics config, the code is pretty much straight forward > For the disk {formating, parsing}

Re: [libvirt] [PATCH v2 0/8] Add support for fetching statistics of completed jobs

2014-09-09 Thread John Ferlan
On 09/09/2014 05:54 AM, Jiri Denemark wrote: > Using virDomainGetJobStats, we can monitor running jobs but sometimes it > may be useful to get statistics about a job that already finished, for > example, to get the final amount of data transferred during migration or > to get an idea about total

[libvirt] [PATCH 0/3] Add "rawio" for hostdev

2014-09-09 Thread John Ferlan
The "rawio" setting for a lun isn't duplicated in the scsi_host hostdev device for a lun. Rather than "requiring" some disk in the disk list to add the rawio, add the "rawio" property to the scsi_host hostdev lun. John Ferlan (3): hostdev: Add "rawio" attribute to _virDomainHostdevSubsysSCSI

[libvirt] [PATCH 2/3] qemu: Process the hostdev "rawio" setting

2014-09-09 Thread John Ferlan
Mimic the "Disk" processing for 'rawio', but for a scsi_host hostdev lun device. Signed-off-by: John Ferlan --- src/qemu/qemu_domain.c | 21 + src/qemu/qemu_domain.h | 4 src/qemu/qemu_driver.c | 1 + src/qemu/qemu_process.c | 20 +++- 4 files change

[libvirt] [PATCH 1/3] hostdev: Add "rawio" attribute to _virDomainHostdevSubsysSCSI

2014-09-09 Thread John Ferlan
Add the 'rawio' attribute to match _virDomainDiskDef Signed-off-by: John Ferlan --- src/conf/domain_conf.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 1107fa8..b1d13ef 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h

[libvirt] [PATCH 3/3] domain_conf: Process the "rawio" for a hostdev device

2014-09-09 Thread John Ferlan
Add a "rawio" to the hostdev XML and process it mimicing the disk XML for a lun which supports/requires rawio Signed-off-by: John Ferlan --- docs/formatdomain.html.in | 12 ++-- docs/schemas/domaincommon.rng | 18 +++ src/conf/domain_conf

[libvirt] [PATCHv2 06/13] vbox: Rewrite vboxConnectListDefinedNetworks

2014-09-09 Thread Taowei
--- src/vbox/vbox_common.c| 57 + src/vbox/vbox_tmpl.c | 45 src/vbox/vbox_uniformed_api.h |1 + 3 files changed, 58 insertions(+), 45 deletions(-) diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox

[libvirt] [PATCHv2 01/13] vbox: Rewrite vboxNetworkOpen

2014-09-09 Thread Taowei
--- src/vbox/vbox_common.c| 26 ++ src/vbox/vbox_tmpl.c | 24 src/vbox/vbox_uniformed_api.h |3 +++ 3 files changed, 29 insertions(+), 24 deletions(-) diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c index b9858

[libvirt] [PATCHv2 02/13] vbox: Rewrite vboxNetworkClose

2014-09-09 Thread Taowei
--- src/vbox/vbox_common.c|7 +++ src/vbox/vbox_tmpl.c |6 -- src/vbox/vbox_uniformed_api.h |1 + 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c index 3716bb4..2b535cd 100644 --- a/src/vbox/vbox_co

[libvirt] [PATCHv2 07/13] vbox: Rewrite vboxNetworkLookupByUUID

2014-09-09 Thread Taowei
--- src/vbox/vbox_common.c| 52 + src/vbox/vbox_tmpl.c | 57 ++--- src/vbox/vbox_uniformed_api.h |8 ++ 3 files changed, 73 insertions(+), 44 deletions(-) diff --git a/src/vbox/vbox_common.c b/src

[libvirt] [PATCHv2 00/13] vbox: Rewrite vbox network driver

2014-09-09 Thread Taowei
This series of patches rewrite the vbox network driver, which is a continuance for my GSoC project "Rewriting the vbox driver". The patches removed all version specified network drivers and left a common driver which using vbox's uniformed network API. Diff from v1: *Remove macro VBOX_OBJECT_HOS

[libvirt] [PATCHv2 12/13] vbox: Rewrite vboxNetworkGetXMLDesc

2014-09-09 Thread Taowei
--- src/vbox/vbox_common.c| 191 + src/vbox/vbox_tmpl.c | 235 + src/vbox/vbox_uniformed_api.h |8 ++ 3 files changed, 248 insertions(+), 186 deletions(-) diff --git a/src/vbox/vbox_common.c b/src/vbox/

[libvirt] [PATCHv2 09/13] vbox: Rewrite vboxNetworkDefineCreateXML

2014-09-09 Thread Taowei
This patch actually contains two public API, virNetworkDefineXML and virNetworkCreateXML. They use the same core function vboxNetworkDefineCreateXML. So I merged it together. --- src/vbox/vbox_common.c| 213 + src/vbox/vbox_common.h|1 + src/vbox/vbox_t

[libvirt] [PATCHv2 10/13] vbox: Rewrite vboxNetworkUndefineDestroy

2014-09-09 Thread Taowei
This patch rewrites two public APIs. They are vboxNetworkUndefine and vboxNetworkDestroy. They use the same core function vboxNetworkUndefineDestroy. I merged it in one patch. --- src/vbox/vbox_common.c| 106 src/vbox/vbox_tmpl.c | 136 ++

[libvirt] [PATCHv2 11/13] vbox: Rewrite vboxNetworkCreate

2014-09-09 Thread Taowei
--- src/vbox/vbox_common.c| 72 + src/vbox/vbox_tmpl.c | 68 -- src/vbox/vbox_uniformed_api.h |1 + 3 files changed, 73 insertions(+), 68 deletions(-) diff --git a/src/vbox/vbox_common.c b/src/vbo

[libvirt] [PATCHv2 05/13] vbox: Rewrite vboxConnectNumOfDefinedNetworks

2014-09-09 Thread Taowei
--- src/vbox/vbox_common.c| 45 + src/vbox/vbox_tmpl.c | 34 --- src/vbox/vbox_uniformed_api.h |1 + 3 files changed, 46 insertions(+), 34 deletions(-) diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_

[libvirt] [PATCHv2 04/13] vbox: Rewrite vboxConnectListNetworks

2014-09-09 Thread Taowei
--- src/vbox/vbox_common.c| 57 + src/vbox/vbox_tmpl.c | 52 + src/vbox/vbox_uniformed_api.h |2 ++ 3 files changed, 66 insertions(+), 45 deletions(-) diff --git a/src/vbox/vbox_common.c b/src/vbo

[libvirt] [PATCHv2 03/13] vbox: Rewrite vboxConnectNumOfNetworks

2014-09-09 Thread Taowei
--- src/vbox/vbox_common.c| 45 src/vbox/vbox_common.h| 15 ++ src/vbox/vbox_tmpl.c | 65 - src/vbox/vbox_uniformed_api.h | 10 +++ 4 files changed, 101 insertions(+), 34 deletions(-)

[libvirt] [PATCHv2 08/13] vbox: Rewrite vboxNetworkLookupByName

2014-09-09 Thread Taowei
--- src/vbox/vbox_common.c| 49 + src/vbox/vbox_tmpl.c | 54 - src/vbox/vbox_uniformed_api.h |4 +++ 3 files changed, 69 insertions(+), 38 deletions(-) diff --git a/src/vbox/vbox_common.c b/src/vb

[libvirt] [PATCHv2 13/13] vbox: Introducing vboxCommonNetworkDriver

2014-09-09 Thread Taowei
--- src/vbox/vbox_common.c| 54 + src/vbox/vbox_driver.c| 23 ++ src/vbox/vbox_tmpl.c | 18 -- src/vbox/vbox_uniformed_api.h | 16 4 files changed, 40 insertions(+), 71 deletions(-) d