The correct attribute name is 'format', not 'type'.
https://bugzilla.redhat.com/show_bug.cgi?id=1139910
---
Pushed as trivial.
docs/formatstorageencryption.html.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/formatstorageencryption.html.in
On Tue, Sep 09, 2014 at 19:36:52 -0400, John Ferlan wrote:
On 09/09/2014 05:54 AM, Jiri Denemark wrote:
Using virDomainGetJobStats, we can monitor running jobs but sometimes it
may be useful to get statistics about a job that already finished, for
example, to get the final amount of
On 09/09/14 18:04, Francesco Romani wrote:
- Original Message -
From: Peter Krempa pkre...@redhat.com
To: Francesco Romani from...@redhat.com, libvir-list@redhat.com
Sent: Tuesday, September 9, 2014 2:14:23 PM
Subject: Re: [libvirt] [PATCH 1/8] qemu: bulk stats: extend internal
On 2014/9/8 21:05, Francesco Romani wrote:
+static bool
+qemuDomainGetStatsNeedMonitor(unsigned int stats)
+{
+size_t i;
+
+for (i = 0; qemuDomainGetStatsWorkers[i].func; i++)
+if (stats qemuDomainGetStatsWorkers[i].stats)
+if
On 09/09/14 19:58, Martin Kletzander wrote:
On Tue, Sep 09, 2014 at 05:25:31PM +0200, Peter Krempa wrote:
I spent some time in the save/dump code today and found a few nits to
fix.
Peter Krempa (4):
util: process: Don't report OOM errors in helper
virsh: domain: Clean up handling of dom
On 09.09.2014 18:25, Steven Wilson wrote:
We recently ran into libvirt lxc shutdown failing because of mount
namespaces not being available:
# virsh -c lxc:/// start test01
Domain test01 started
# virsh -c lxc:/// list
IdName State
Tweak the messages so that they mention title rather than
description when operating in title mode. Also fixes one missing %s
before non-formatted gettext message.
Before:
$ virsh desc --title dom
No description for domain: dom
After:
$ virsh desc --title dom
No title for domain: dom
On 2014/9/8 21:05, Francesco Romani wrote:
This patch implements the VIR_DOMAIN_STATS_CPU_TOTAL
group of statistics.
Signed-off-by: Francesco Romani from...@redhat.com
---
include/libvirt/libvirt.h.in | 1 +
src/libvirt.c| 9
src/qemu/qemu_driver.c | 51
On Tue, Sep 09, 2014 at 07:51:00PM +0200, Martin Kletzander wrote:
On Mon, Sep 08, 2014 at 03:59:04PM +0100, Daniel P. Berrange wrote:
On Mon, Sep 08, 2014 at 04:17:44PM +0200, Martin Kletzander wrote:
Many moons ago, I wanted to make locking more debuggable from logs.
An idea appeared that
On Wed, Sep 10, 2014 at 10:35:04AM +0200, Michal Privoznik wrote:
On 09.09.2014 18:25, Steven Wilson wrote:
We recently ran into libvirt lxc shutdown failing because of mount
namespaces not being available:
# virsh -c lxc:/// start test01
Domain test01 started
# virsh -c lxc:/// list
On 2014/9/9 19:56, Peter Krempa wrote:
+ * VIR_DOMAIN_STATS_VCPU: Return virtual CPU statistics.
+ * Due to VCPU hotplug, the vcpu.num.* array could be sparse.
+ * The actual size of the array correspond to vcpu.current.
+ * The array size will never exceed vcpu.maximum.
+ * The typed
On Tue, Sep 09, 2014 at 12:38:04PM +0100, Richard W.M. Jones wrote:
On Tue, Sep 09, 2014 at 10:45:43AM +0200, Peter Krempa wrote:
When a backing chain element specifies a parent in a format not known to
libvirt
we'd fail to start the VM as the chain would appear broken.
To prevent
On Tue, Sep 09, 2014 at 10:45:44AM +0200, Peter Krempa wrote:
To allow the compiler to track future additions of disk types, convert
the function to use a switch statement with the correct type.
---
src/util/virstoragefile.c | 17 -
1 file changed, 16 insertions(+), 1
On Tue, Sep 09, 2014 at 10:45:45AM +0200, Peter Krempa wrote:
This patch adds a new disk type raw that can be used twofold:
1) To pass arbitrary strings as disk sources to the hypervisor of
choice. This allows to use not-yet-supported storage specification
formats.
2) To return backing
On Tue, Sep 09, 2014 at 10:45:46AM +0200, Peter Krempa wrote:
Do not output the /backingStore element in the xml if the backing
chain ends with a volume specification unknown by libvirt.
---
src/conf/domain_conf.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
NACK, because
On Tue, Sep 09, 2014 at 10:45:47AM +0200, Peter Krempa wrote:
Test the qemu command generator and the xml parsers and formatters. The
tests are added separately due to the size of the test files.
Note that tests/qemuxml2argvdata/qemuxml2argv-disk-virtio-raw.args is
split into lines in a
From time to time weird bugreports occur on the list, e.g [1].
Even though the kernel supports setns syscall, there's an older
glibc in the system that misses a wrapper over the syscall.
Hence, after the configure phase we think there's no setns
support in the system, which is obviously wrong. On
On 2014/9/8 21:05, Francesco Romani wrote:
This patch implements the VIR_DOMAIN_STATS_VCPU
group of statistics.
To do so, this patch also extracts a helper to gather the
VCpu information.
Signed-off-by: Francesco Romani from...@redhat.com
---
include/libvirt/libvirt.h.in | 1 +
+static int
+qemuDomainGetStatsVcpu(virConnectPtr conn ATTRIBUTE_UNUSED,
+ virDomainObjPtr dom,
+ virDomainStatsRecordPtr record,
+ int *maxparams,
+ unsigned int privflags ATTRIBUTE_UNUSED)
+{
On 09/10/14 12:04, Daniel P. Berrange wrote:
On Tue, Sep 09, 2014 at 10:45:44AM +0200, Peter Krempa wrote:
To allow the compiler to track future additions of disk types, convert
the function to use a switch statement with the correct type.
---
src/util/virstoragefile.c | 17 -
This patch addresses problem RHBZ #1133686.
For some (unknown to me) reason, g_spawn_async() is not
starting dhclient so that a dhcp NIC can be configured.
However, simply using g_spawn_sync() works. This was the
only use of g_spawn_async().
Note: There is no problem using sync instead of async
v1.1 adds some documentation changes.
Support for a network such as -N dhcp,source=default was not working
in that dhclient was not being started. Although I am not sure what
the real problem is, the solution is to use g_spawn_sync() instead of
g_spawn_async() to start /sbin/dhclient.
The
This patch improves the ability to understand what is happening
with dchlient and is obviously optional.
---
libvirt-sandbox/libvirt-sandbox-init-common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libvirt-sandbox/libvirt-sandbox-init-common.c
This new event will use typedParameters to expose what has been actually
updated and the reason is that we can in the future extend the cputune.
With typedParameters we don't have to worry about creating some sort of
v2 of cputune event if there will be new features implemented for cputune.
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
examples/object-events/event-test.c | 52 -
1 file changed, 51 insertions(+), 1 deletion(-)
diff --git a/examples/object-events/event-test.c
b/examples/object-events/event-test.c
index d6cfe46..f1b9cda 100644
This patch series introduce new cputune event to inform
management applications about every change of cputune values
for running domains.
The first patch introduces a new string helper virSnprintf
and the second patch cleans up the virDomanDef structure.
There is missing documentation for all
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
src/libvirt_private.syms | 1 +
src/util/virstring.c | 25 +
src/util/virstring.h | 20
3 files changed, 46 insertions(+)
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
src/conf/domain_conf.h | 94 ++
1 file changed, 57 insertions(+), 37 deletions(-)
diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index efae2f5..c82b224 100644
---
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
src/qemu/qemu_cgroup.c | 18 -
src/qemu/qemu_driver.c | 73 ++
2 files changed, 90 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c
index
As of commit 5d29ca0:
qemu: switch PCI address set from hash table to an array
There is no error to be reset.
---
src/qemu/qemu_command.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 5856fe7..665a590 100644
---
On 09/10/2014 04:51 AM, Peter Krempa wrote:
Tweak the messages so that they mention title rather than
description when operating in title mode. Also fixes one missing %s
before non-formatted gettext message.
Before:
$ virsh desc --title dom
No description for domain: dom
After:
$
And register the program, finally. Although, only stub
implementation of the Remember() and Recall() functions
is added. The real implementation will follow.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/locking/lock_daemon.c | 37 ++
I know I've sent several versions like ages ago, so this should
not start with v1, but hey, this is completely new approach, so
I'm gonna start from 1.
Here, the virtlockd is misused to hold the original seclabels
(although only DAC label is implemented so far). Even more, it
does a reference
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/libvirt_private.syms| 2 ++
src/locking/domain_lock.c | 65 +
src/locking/domain_lock.h | 10 +++
src/locking/lock_driver.h | 2 ++
src/locking/lock_driver_lockd.c |
To keep original seclabel for files libvirt is touching we need a
single point where the original seclabels can be stored. Instead
of inventing a new one we can misuse virtlockd which already has
nearly all the infrastructure we need. As nice feature, it keeps
its internal state between virtlockd
The NOP drivers needs implementation, although the function
bodies are empty. This is because the virLockManager APIs check
for driver implementation and returns an error if there's none.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/locking/lock_driver_nop.c | 22
The most interesting part where all the hard work takes place.
For storing triplets of strings a two dimensional table would be
the most intuitive approach. Or, if the triplet is rearranged
into pair of one string and a pair, a hash table can be used. But
hey, we already have those! Excellent. In
We have nice wrappers over internal function that eventually
calls the Internal() function, but for future work it's better to
call those wrappers instead of the internal function directly.
This is due to fact that the wrappers differentiate between
setting or restoring the label while the
This is the client side, so there's nothing more we need to do
than call the RPC. Although, there's one interesting change: new
virLockManagerLockSeclabelConnect() had to be implemented since the
VIR_LOCK_SPACE_PROTOCOL_PROGRAM doesn't have any ConnectOpen()
procedure.
Signed-off-by: Michal
So far no ConnectOpen() is introduced as it's not needed for such
simple use case like this. It's crucial to separate this from
virLockSpace program that already exists. Not only it requires
virDomainObjPtr for its ConnectOpen() (subsequently all security
drivers would need rework as they use
For future work it's crucial to have virLockManagerPluginPtr
stored in virSecurityDriver. Therefore, we must pass it when
creating the security driver.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/Makefile.am | 6 +-
src/lxc/lxc_controller.c | 2 +-
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/Makefile.am | 1 +
src/security/security_dac.c | 103 ++--
2 files changed, 92 insertions(+), 12 deletions(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index 90a51f6..83c8fcb
- Original Message -
From: Peter Krempa pkre...@redhat.com
To: Francesco Romani from...@redhat.com, libvir-list@redhat.com
Sent: Wednesday, September 10, 2014 10:07:33 AM
Subject: Re: [libvirt] [PATCH 1/8] qemu: bulk stats: extend internal
collection API
[...]
Hmm this skips
- Original Message -
From: Wang Rui moon.wang...@huawei.com
To: Francesco Romani from...@redhat.com
Cc: libvir-list@redhat.com, pkre...@redhat.com
Sent: Wednesday, September 10, 2014 10:56:47 AM
Subject: Re: [libvirt] [PATCHv3 2/8] qemu: bulk stats: implement CPU stats
group
On
On 09/10/14 15:46, Francesco Romani wrote:
- Original Message -
From: Wang Rui moon.wang...@huawei.com
To: Francesco Romani from...@redhat.com
Cc: libvir-list@redhat.com, pkre...@redhat.com
Sent: Wednesday, September 10, 2014 10:56:47 AM
Subject: Re: [libvirt] [PATCHv3 2/8] qemu:
On 09/10/14 15:55, Francesco Romani wrote:
- Original Message -
From: Peter Krempa pkre...@redhat.com
To: Francesco Romani from...@redhat.com, libvir-list@redhat.com
Sent: Wednesday, September 10, 2014 10:07:33 AM
Subject: Re: [libvirt] [PATCH 1/8] qemu: bulk stats: extend internal
Convert virAccessDriverPolkitFormatProcess to use typesafe API
for getting process ID attribute.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/access/viraccessdriverpolkit.c | 30 +-
1 file changed, 13 insertions(+), 17 deletions(-)
diff --git
Convert the remote daemon auth check and the access control
code to use the common polkit API for checking auth.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
daemon/remote.c| 235 ++---
src/access/viraccessdriverpolkit.c | 91
Currently DBus dict values must be passed inline
virDBusMessageEncode(a{ss},
3,
key1, val1,
key2, val2,
key3, val3);
virDBusMessageDecode(a{ss},
3,
There are now two places in libvirt which use polkit. Currently
they use pkexec, which is set to be replaced by direct DBus API
calls. Add a common API which they will both be able to use for
this purpose.
No tests are added at this time, since the impl will be gutted
in favour of a DBus API call
Instead of requiring the caller to format to/from strings,
add typesafe APIs todo this work.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/libvirt_private.syms | 18
src/util/viridentity.c | 241 +++
src/util/viridentity.h |
Update virNetServerClientCreateIdentity and virIdentityGetSystem
to use the new typesafe APIs for setting identity attributes
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/rpc/virnetserverclient.c | 115 ++-
src/util/viridentity.c |
On Wed, Aug 20, 2014 at 4:23 PM, Roman Bogorodskiy
bogorods...@gmail.com wrote:
Nehal J Wani wrote:
This patch enables the helper program to detect event(s) triggered when there
is a change in lease length or expiry and client-id. This transfers complete
control of leases database to
Spawning the pkcheck program every time a permission check is
required is hugely expensive on CPU. The pkcheck program is just
a dumb wrapper for the DBus API, so rewrite the code to use the
DBus API directly. This also simplifies error handling a bit.
Signed-off-by: Daniel P. Berrange
This series improves the performance of the polkit driver by
switching from use of the pk-check command, to the DBus APIs.
As a convenient side effect, this means we are no longer
vulnerable to CVE-2013-4311, on any polkit version, since we
no longer need pk-check (which is what had the flaw).
In
On 09/09/2014 02:45 AM, Peter Krempa wrote:
To allow the compiler to track future additions of disk types, convert
the function to use a switch statement with the correct type.
---
src/util/virstoragefile.c | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git
On 09/10/2014 06:37 AM, Ján Tomko wrote:
As of commit 5d29ca0:
qemu: switch PCI address set from hash table to an array
There is no error to be reset.
---
src/qemu/qemu_command.c | 1 -
1 file changed, 1 deletion(-)
ACK
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
On 09/08/2014 01:40 PM, Martin Kletzander wrote:
- BLURB
Martin Kletzander (3):
schemas: finish virTristate{Bool,Switch} transition
docs, conf, schema: add support for shared memory mapping
qemu: add support for shared memory mapping
docs/formatdomain.html.in
On 09/08/2014 01:40 PM, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
docs/formatdomain.html.in | 7 +++-
docs/schemas/domaincommon.rng | 5 +++
src/conf/cpu_conf.c| 25
On Wed, Sep 10, 2014 at 05:36:58PM +0200, Ján Tomko wrote:
On 09/08/2014 01:40 PM, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
docs/formatdomain.html.in | 7 +++-
docs/schemas/domaincommon.rng | 5 +++
Ján Tomko wrote:
On 09/07/2014 04:15 PM, Roman Bogorodskiy wrote:
Provide an implementation for buildPool and deletePool operations for
the ZFS storage backend.
---
docs/schemas/storagepool.rng | 1 +
src/storage/storage_backend_zfs.c | 57
Sometimes libvirt is installed on a host that is already using the
network 192.168.122.0/24. If the libvirt-daemon-config-network package
is installed, this creates a conflict, since that package has been
hard-coded to create a virtual network that also uses
192.168.122.0/24. In the past libvirt
On Wed, Sep 10, 2014 at 01:54:00PM -0400, Laine Stump wrote:
Sometimes libvirt is installed on a host that is already using the
network 192.168.122.0/24. If the libvirt-daemon-config-network package
is installed, this creates a conflict, since that package has been
hard-coded to create a
Jim Fehlig wrote:
Currently, libxl_send_trigger() does not implement the LIBXL_TRIGGER_RESET
option, but domainReset can be implemented in the libxl driver by
forcibly destroying the domain and starting it again.
Any objections to pushing this patch? I have several patches on the
list
Would it be easier if I made batches of 5 patches? or perhaps just
batches of patches of the same error?
Just want to get this off the pile
Tks,
John
On 09/04/2014 06:26 PM, John Ferlan wrote:
Sorry for the large dump, but before I got too involved in other things
I figured I'd go through
On 09/08/2014 01:46 AM, Martin Kletzander wrote:
There were various problems introduced by the series on FD passing.
The path for the socket was not created, the socket was not removed
before binding it, etc. Let's see if it's any better this time.
Resolves:
On 09/08/2014 01:46 AM, Martin Kletzander wrote:
This way it behaves more like the daemon itself does (acquiring a
pidfile, deleting the socket before binding, etc.).
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=927369
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1138604
add tests for the xen_xl config parser
Signed-off-by: Kiarie Kahurani davidkiar...@gmail.com
---
tests/Makefile.am| 9 +-
tests/testutilsxen.c | 50
tests/testutilsxen.h | 9 +-
tests/xlconfigdata/test-new-disk.cfg | 27 +
Kiarie Kahurani (4):
src/xenconfig: Export helper functions
src/xenconfig: Xen-xl parser
src/xenconfig: Introduce xen-xl on virsh command line
tests: Tests for the xen-xl parser
configure.ac | 7 +
src/Makefile.am | 21 +-
Introduce a xen xl parser
This parser allows for users to convert the new xl disk format and
spice graphics config to libvirt xml format and vice versa.Regarding
the spice graphics config, the code is pretty much straight forward
For the disk {formating, parsing} this parser takes care of the new
Export helper function for reuse in getting values
from a virConfPtr object
Signed-off-by: Kiarie Kahurani davidkiar...@gmail.com
---
src/xenconfig/xen_common.c | 144 ++---
src/xenconfig/xen_common.h | 24 ++--
2 files changed, 91 insertions(+), 77
Hello,
I am trying to understand libvirt's logic for checking whether migration
of a VM is safe, and how it determines which disks should be mirrored by
QEMU. My particular use case involves VMs that may have disks backed onto
LVM or onto Ceph RBD, or both.
As far as I can tell, the
Integrate the xl parser into the xenlight driver
Signed-off-by: Kiarie Kahurani davidkiar...@gmail.com
---
src/libxl/libxl_driver.c | 46 ++
1 file changed, 34 insertions(+), 12 deletions(-)
diff --git a/src/libxl/libxl_driver.c
Hi Michael!
On 11 September 2014 14:13, Michael Chapman m...@very.puzzling.org wrote:
Why is RBD is handled specially in this function? The current logic is that
an RBD-backed disk is safe to be migrated even if it's got caching enabled,
but I'm not sure how RBD is different from other
74 matches
Mail list logo
