[libvirt] [libvirt-python PATCH] sanitytest: count with the fact that large enums can be long

2014-10-07 Thread Martin Kletzander
On 32-bit systems, one new flag that has the value of 1 31, namely VIR_CONNECT_GET_ALL_DOMAINS_STATS_ENFORCE_STATS, fails to fit into an 'int' on python and is therefore of type 'long'. Fix sanitytest to count with such fact in order to avoid build failures on 32-bit systems. Signed-off-by:

[libvirt] [libvirt-python PATCH] sanitytest: define long for python version = 3

2014-10-07 Thread Martin Kletzander
Commit c58c7f362aab37e4961407c2efc8a74925ed9c37 fixed 32-bit python build but broke build with python3 due to the lack of 'long' in the newer version of python. This patch aims to fix it with a simple string comparison of sys.version and '3'. Signed-off-by: Martin Kletzander mklet...@redhat.com

Re: [libvirt] [PATCH v3 1/3] migration: add migration_host support for Ipv6 address without brackets

2014-10-07 Thread Ján Tomko
On 10/07/2014 06:07 AM, Chen Fan wrote: if specifying migration_host to an Ipv6 address without brackets, it was resolved to an incorrect address, such as: tcp:2001:0DB8::1428:, but the correct address should be: tcp:[2001:0DB8::1428]: so we should add brackets when parsing

[libvirt] [PATCH v5 3/7] qemu: Add the capability to detect if the qemu binary have the capability to use bps_max and friends

2014-10-07 Thread Matthias Gatto
Add a value in the enum virQEMUCapsFlags for the qemu capability. Set it with virQEMUCapsSet if the binary suport bps_max and they friends. Signed-off-by: Matthias Gatto matthias.ga...@outscale.com --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h

[libvirt] [PATCH v5 7/7] virsh: Add bps_max and friends to virsh

2014-10-07 Thread Matthias Gatto
Add the new throttle options to virsh, and send them to libvirt. Signed-off-by: Matthias Gatto matthias.ga...@outscale.com --- tools/virsh-domain.c | 119 +++ tools/virsh.pod | 10 + 2 files changed, 129 insertions(+) diff --git

[libvirt] [PATCH v5 2/7] qemu: Modify the structure _virDomainBlockIoTuneInfo.

2014-10-07 Thread Matthias Gatto
Modify the structure _virDomainBlockIoTuneInfo to support these the new options. Change the initialization of the variable expectedInfo in qemumonitorjsontest.c to avoid compiling problem. Add documentation about the new xml options Signed-off-by: Matthias Gatto matthias.ga...@outscale.com ---

[libvirt] [PATCH v5 4/7] qemu: Add bps_max and friends qemu driver

2014-10-07 Thread Matthias Gatto
Add support for bps_max and friends in the driver part. In the part checking if a qemu is running, check if the running binary support bps_max, if not print an error message, if yes add it to info variable Signed-off-by: Matthias Gatto matthias.ga...@outscale.com ---

[libvirt] [PATCH v5 6/7] qemu: add bps_max and friends to qemu command generation

2014-10-07 Thread Matthias Gatto
Check the arability of the options with the current qemu binary, add them in the varable opt if yes, print a message if not. Signed-off-by: Matthias Gatto matthias.ga...@outscale.com --- src/qemu/qemu_command.c | 57 - 1 file changed, 56

Re: [libvirt] access for wiki editing

2014-10-07 Thread Daniel P. Berrange
On Mon, Oct 06, 2014 at 01:07:42PM -0700, libvir.for.anomal...@xoxy.net wrote: username anomalyst found a typo in Fedora/RHEL Bridging s/briding/bridging/ I've created this. You should receive the password via email Regards, Daniel -- |: http://berrange.com -o-

Re: [libvirt] [libvirt-python PATCH] sanitytest: define long for python version = 3

2014-10-07 Thread Pavel Hrdina
On 10/07/2014 10:38 AM, Martin Kletzander wrote: Commit c58c7f362aab37e4961407c2efc8a74925ed9c37 fixed 32-bit python build but broke build with python3 due to the lack of 'long' in the newer version of python. This patch aims to fix it with a simple string comparison of sys.version and '3'.

Re: [libvirt] [PATCH v2 2/8] Added public API to start post-copy migration

2014-10-07 Thread Jiri Denemark
On Tue, Sep 30, 2014 at 16:39:23 +0200, Cristian Klein wrote: Signed-off-by: Cristian Klein cristian.kl...@cs.umu.se --- include/libvirt/libvirt.h.in | 3 +++ src/driver.h | 5 + src/libvirt.c| 39 +++

[libvirt] [libvirt-python PATCH] setup.py: fix rpm build to return 1 on error

2014-10-07 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina phrd...@redhat.com --- setup.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/setup.py b/setup.py index 0c34ae1..c6a9ce3 100755 --- a/setup.py +++ b/setup.py @@ -245,8 +245,8 @@ class my_rpm(Command):

[libvirt] [PATCH v5 1/7] qemu: Add define for the news throttle options

2014-10-07 Thread Matthias Gatto
Add defines for the news options total_bytes_sec_max, write_bytes_sec_max, read_bytes_sec_max, total_iops_sec_max, write_iops_sec_max, read_iops_sec_max, size_iops_sec. Signed-off-by: Matthias Gatto matthias.ga...@outscale.com --- include/libvirt/libvirt.h.in | 54

[libvirt] [PATCH v5 5/7] qemu: Add bps_max and friends QMP suport

2014-10-07 Thread Matthias Gatto
Detect if the the qemu binary currently in use suport the bps_max option, If yes add it to the command, if not, just ignore the options. Signed-off-by: Matthias Gatto matthias.ga...@outscale.com --- src/qemu/qemu_monitor_json.c | 57 +++- 1 file changed,

[libvirt] [PATCH v5 0/7] qemu: Introduce support for new the block_set_io_throttle parameters add in the version 1.7 of qemu.

2014-10-07 Thread Matthias Gatto
This series of patches add support for bps_max, bps_rd_max, bps_wr_max, bps_max, bps_rd_max, bps_wr_max, and iops_size in the functions qemuDomainSetBlockIoTune and qemuDomainGetBlockIoTune. The last patch add support for these parameters to the virsh blkdeviotune command. v2: spellfix v3:

Re: [libvirt] [RFC PATCH] include: make it easier to probe enum growth

2014-10-07 Thread Daniel P. Berrange
On Mon, Oct 06, 2014 at 02:06:56PM -0600, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1147639 is an example of a downstream distro's dilemma - when backporting a feature that is implemented in an ABI-compatible manner (no .so bump was required) but where the feature involves

Re: [libvirt] [PATCH v2 3/8] Added low-level API to qemu post-copy migration

2014-10-07 Thread Jiri Denemark
On Tue, Sep 30, 2014 at 16:39:24 +0200, Cristian Klein wrote: Signed-off-by: Cristian Klein cristian.kl...@cs.umu.se --- src/qemu/qemu_monitor.c | 24 ++-- src/qemu/qemu_monitor.h | 4 src/qemu/qemu_monitor_json.c | 23 ++-

Re: [libvirt] [libvirt-python PATCH] sanitytest: define long for python version = 3

2014-10-07 Thread Ján Tomko
On 10/07/2014 11:49 AM, Pavel Hrdina wrote: On 10/07/2014 10:38 AM, Martin Kletzander wrote: Commit c58c7f362aab37e4961407c2efc8a74925ed9c37 fixed 32-bit python build but broke build with python3 due to the lack of 'long' in the newer version of python. This patch aims to fix it with a simple

Re: [libvirt] [libvirt-python PATCH] setup.py: fix rpm build to return 1 on error

2014-10-07 Thread Martin Kletzander
On Tue, Oct 07, 2014 at 11:56:54AM +0200, Pavel Hrdina wrote: Signed-off-by: Pavel Hrdina phrd...@redhat.com --- setup.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/setup.py b/setup.py index 0c34ae1..c6a9ce3 100755 --- a/setup.py +++ b/setup.py @@ -245,8 +245,8 @@

Re: [libvirt] [PATCH v2 4/8] Implemented VIR_MIGRATE_POSTCOPY in qemu driver

2014-10-07 Thread Jiri Denemark
On Tue, Sep 30, 2014 at 16:39:25 +0200, Cristian Klein wrote: Signed-off-by: Cristian Klein cristian.kl...@cs.umu.se --- src/qemu/qemu_migration.c | 60 +++ src/qemu/qemu_migration.h | 3 ++- 2 files changed, 62 insertions(+), 1 deletion(-)

Re: [libvirt] [PATCH v2 5/8] Added job type VIR_DOMAIN_JOB_PHASE1_COMPLETED

2014-10-07 Thread Jiri Denemark
On Tue, Sep 30, 2014 at 16:39:26 +0200, Cristian Klein wrote: Some jobs feature several phases. For example, post-copy migration is composed of a first phase, from migration start to switching to post-copy, and a second phase, to migration completion. This job type allows to flag that the job

[libvirt] [PATCH] Fix build-time pkg-config files in VPATH

2014-10-07 Thread Jiri Denemark
The pkg-config files in src/ make it pretty easy to build language bindings against an uninstalled libvirt, however, they don't work with VPATH builds. The reason is that all *-api.xml files are generated in source rather than build directory. Signed-off-by: Jiri Denemark jdene...@redhat.com ---

Re: [libvirt] [PATCH v2 6/8] Implemented post-copy migration logic in qemu

2014-10-07 Thread Jiri Denemark
On Tue, Sep 30, 2014 at 16:39:27 +0200, Cristian Klein wrote: Perform phase stops once migration switched to post-copy. Confirm phase waits for post-copy to finish before killing the VM. Signed-off-by: Cristian Klein cristian.kl...@cs.umu.se --- src/qemu/qemu_driver.c| 8

Re: [libvirt] [PATCH v2 7/8] Implement virDomainMigrateStartPostCopy in qemu

2014-10-07 Thread Jiri Denemark
On Tue, Sep 30, 2014 at 16:39:28 +0200, Cristian Klein wrote: Signed-off-by: Cristian Klein cristian.kl...@cs.umu.se --- src/qemu/qemu_driver.c | 50 ++ 1 file changed, 50 insertions(+) diff --git a/src/qemu/qemu_driver.c

Re: [libvirt] [PATCH v2 8/8] virsh: add postcopy-after option to migrate command

2014-10-07 Thread Jiri Denemark
On Tue, Sep 30, 2014 at 16:39:29 +0200, Cristian Klein wrote: Signed-off-by: Cristian Klein cristian.kl...@cs.umu.se --- tools/virsh-domain.c | 72 ++-- tools/virsh.pod | 5 2 files changed, 75 insertions(+), 2 deletions(-) diff

[libvirt] [PATCH] security_selinux: Don't relabel /dev/net/tun

2014-10-07 Thread Michal Privoznik
https://bugzilla.redhat.com/show_bug.cgi?id=1147057 The code for relabelling the TAP FD is there due to a race. When libvirt creates a /dev/tapN device it's labeled as 'system_u:object_r:device_t:s0' by default. Later, when udev/systemd reacts to this device, it's relabelled to the expected label

Re: [libvirt] [PATCH] Fix build-time pkg-config files in VPATH

2014-10-07 Thread Eric Blake
On 10/07/2014 07:26 AM, Jiri Denemark wrote: The pkg-config files in src/ make it pretty easy to build language bindings against an uninstalled libvirt, however, they don't work with VPATH builds. The reason is that all *-api.xml files are generated in source rather than build directory.

Re: [libvirt] [PATCH] security_selinux: Don't relabel /dev/net/tun

2014-10-07 Thread Eric Blake
On 10/07/2014 08:53 AM, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1147057 The code for relabelling the TAP FD is there due to a race. When libvirt creates a /dev/tapN device it's labeled as 'system_u:object_r:device_t:s0' by default. Later, when udev/systemd reacts

Re: [libvirt] [RFC PATCH] include: make it easier to probe enum growth

2014-10-07 Thread Eric Blake
On 10/07/2014 03:16 AM, Daniel P. Berrange wrote: On Mon, Oct 06, 2014 at 02:06:56PM -0600, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1147639 is an example of a downstream distro's dilemma - when backporting a feature that is implemented in an ABI-compatible manner (no .so

Re: [libvirt] increase number of libvirt threads by starting tansient guest doamin - is it a bug?

2014-10-07 Thread web2
Hi, i have found the time and tested Xen-4.4.1 with libvirt-1.2.6 and the problem with the threads are disappered. But now i see after every restore of an xen-vm (windows-xp hvm) an openfile-handle (via lsof -p `pgrep libvirtd`) to an file in /var/lib/xen with the name qemu-resume.vm-id and

[libvirt] [PATCH] pclmuldq was introduced with Westmere, not Sandy Bridge. This feature is important to get proper performance for aes-128-gcm in openssl, an important cipher for https communication

2014-10-07 Thread Jan-Frode Myklebust
Signed-off-by: Jan-Frode Myklebust janfr...@tanso.net --- src/cpu/cpu_map.xml |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/cpu/cpu_map.xml b/src/cpu/cpu_map.xml index 18c7b0d..94f1458 100644 --- a/src/cpu/cpu_map.xml +++ b/src/cpu/cpu_map.xml @@ -488,11 +488,11

Re: [libvirt] [PATCH] pclmuldq was introduced with Westmere, not Sandy Bridge. This feature is important to get proper performance for aes-128-gcm in openssl, an important cipher for https communica

2014-10-07 Thread Jan-Frode Myklebust
Just some documentation for the fact that this was introduced with Westmere: https://software.intel.com/sites/default/files/managed/72/cc/clmul-wp-rev-2.02-2014-04-20.pdf Intel® PCLMULQDQ instruction is a new instruction available beginning with the all new 2010 Intel®

Re: [libvirt] [PATCH 1/2] esx: Add libcurl based stream driver

2014-10-07 Thread Matthias Bolte
2014-03-31 15:46 GMT+02:00 Michal Privoznik mpriv...@redhat.com: On 30.03.2014 21:03, Matthias Bolte wrote: This allows to implement libvirt functions that use streams, such as virDoaminScreenshot, without the need to store the downloaded data in a temporary file first. The stream driver

Re: [libvirt] [PATCH 2/2] esx: Implement virDomainScreenshot using libcurl stream driver

2014-10-07 Thread Matthias Bolte
2014-03-31 15:46 GMT+02:00 Michal Privoznik mpriv...@redhat.com: On 30.03.2014 21:03, Matthias Bolte wrote: This implementation uses the https://esx-server/screen?id=id way to get a screenshot of a running domain. Compared to the CreateScreenshot_Task way this works since ESX 2.5 while

Re: [libvirt] [PATCH] security_selinux: Don't relabel /dev/net/tun

2014-10-07 Thread Richard W.M. Jones
On Tue, Oct 07, 2014 at 04:53:24PM +0200, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1147057 The code for relabelling the TAP FD is there due to a race. When libvirt creates a /dev/tapN device it's labeled as 'system_u:object_r:device_t:s0' by default. Later, when

Re: [libvirt] [PATCH v2] hotplug: Fix libvirtd crash on qemu-attached guest

2014-10-07 Thread John Ferlan
ping? Eric/Dan - since you had comments on v1... Tks, John On 09/25/2014 11:00 AM, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1141621 The crash in this case was because the qemu-attach code did not create aliases for qemu cli args. When the detach-interface code was

Re: [libvirt] Notes: Non-shared storage live migration w/ active blockcommit

2014-10-07 Thread Eric Blake
On 09/25/2014 08:26 AM, Kashyap Chamarthy wrote: This notes is based on an IRC conversation with Eric Blake, to have efficient non-shared storage live migration. Thought I'd post my notes here before I forget. Please review and spot if there are any inaccuracies. Procedure - (1)

Re: [libvirt] [PATCH v3 1/3] migration: add migration_host support for Ipv6 address without brackets

2014-10-07 Thread Chen, Fan
On Tue, 2014-10-07 at 11:08 +0200, Ján Tomko wrote: On 10/07/2014 06:07 AM, Chen Fan wrote: if specifying migration_host to an Ipv6 address without brackets, it was resolved to an incorrect address, such as: tcp:2001:0DB8::1428:, but the correct address should be:

Re: [libvirt] [PATCH-RFC-V2] qemu: Add network bandwidth setting for ethernet interfaces

2014-10-07 Thread Anirban Chakraborty
On 10/6/14, 3:43 AM, Michal Privoznik mpriv...@redhat.com wrote: On 18.09.2014 01:33, Anirban Chakraborty wrote: V2: Consolidate calls to virNetDevBandwidthSet Clear bandwidth settings when the interface is detached or domain destroyed V1: Ethernet interfaces in libvirt currently do not