On Tue, Oct 28, 2014 at 04:22:21PM +0800, Chen Fan wrote:
For memnode in numatune element, the range of attribute 'nodeset'
was not validated. on my host maxnodes was 1, but when setting nodeset
to '0-2' or more, guest also started succuss. there probably was qemu's
bug too.
Signed-off-by: Chen
On Tue, Oct 28, 2014 at 04:22:22PM +0800, Chen Fan wrote:
Signed-off-by: Chen Fan
---
src/lxc/lxc_controller.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/lxc/lxc_controller.c b/src/lxc/lxc_controller.c
index 1861dd6..1ee89ab 100644
--- a/src/lxc/lxc_controller.c
+++
On Wed, 2014-10-29 at 08:00 +0100, Martin Kletzander wrote:
> On Tue, Oct 28, 2014 at 04:22:22PM +0800, Chen Fan wrote:
> >Signed-off-by: Chen Fan
> >---
> > src/lxc/lxc_controller.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> >diff --git a/src/lxc/lxc_controller.c b/src/lxc/
On Wed, 2014-10-29 at 07:58 +0100, Martin Kletzander wrote:
> On Tue, Oct 28, 2014 at 04:22:21PM +0800, Chen Fan wrote:
> >For memnode in numatune element, the range of attribute 'nodeset'
> >was not validated. on my host maxnodes was 1, but when setting nodeset
> >to '0-2' or more, guest also sta
On Tue, Oct 28, 2014 at 04:45:21PM -0600, Cedric Bosdonnat wrote:
> Hi Daniel,
>
> On Wed, 2014-10-22 at 11:09 +0100, Daniel P. Berrange wrote:
> > It would be nice if we can share the parsing of this with the parsingdone
> > in the xml block. Since the XML schema is the same, I'd expect
> > we c
On 10/27/14 07:40, Shanzhi Yu wrote:
>
> On 10/25/2014 03:12 AM, Eric Blake wrote:
>> On 10/24/2014 01:01 PM, Shanzhi Yu wrote:
>>> When split uri->scheme into two strings with "+", the second one will be
>> s/split/splitting/
>>
>>> "rdma://server/..", pass it to virStorageNetHostTransportTypeFro
I forgot the backslash here. It didn't report any error on my system, so I
submitted it.
Sorry about that.
2014-10-29 12:14 GMT+08:00 Michal Privoznik :
> As I've pushed 5892944f I haven't noticed one small nitpick.
> There was this backslash missing on the line 1231 in the
> enumeration of lib
Add two test cases to verify that the helpers split and parse the
backing store components properly.
---
tests/virstringtest.c | 3 +++
tests/viruritest.c| 1 +
2 files changed, 4 insertions(+)
diff --git a/tests/virstringtest.c b/tests/virstringtest.c
index 841531f..a0bfd61 100644
--- a/test
The code that parses the schema from the URI touches the "hosts[0]"
member of the storage file source structure in case the URI contains a
schema. The hosts array was not yet allocated at the point in the code
where the transport protocol was parsed and set. This lead to a crash of
libvirtd.
Fix t
See patch 1 for explanation.
Peter Krempa (2):
storage: Fix crash when parsing backing store URI with schema
test: Add test to verify helpers used for backing file name parsing
src/util/virstoragefile.c | 10 +-
tests/virstoragetest.c| 31 +--
tests/vi
Detect if the the qemu binary currently in use support the bps_max option,
If yes add it to the command, if not, just ignore the option.
We don't print error here, because the check for invalide arguments
has alerady been made in qemu_driver.c
Signed-off-by: Matthias Gatto
---
src/qemu/qemu_moni
Add defines for the new options total_bytes_sec_max, write_bytes_sec_max,
read_bytes_sec_max, total_iops_sec_max, write_iops_sec_max, read_iops_sec_max,
size_iops_sec.
Signed-off-by: Matthias Gatto
---
include/libvirt/libvirt-domain.h | 54
1 file changed
Modify the structure _virDomainBlockIoTuneInfo to support these the new
options.
Change the initialization of the variable expectedInfo in qemumonitorjsontest.c
to avoid compiling problem.
Add documentation about the new xml options
Signed-off-by: Matthias Gatto
---
docs/formatdomain.html.in
Add the capability to detect if the qemu binary have the capability
to use bps_max and friends
Add a value in the enum virQEMUCapsFlags for the qemu capability.
Set it with virQEMUCapsSet if the binary suport bps_max and they friends.
Signed-off-by: Matthias Gatto
---
src/qemu/qemu_capabilities.
This series of patches add support for bps_max, bps_rd_max, bps_wr_max,
bps_max, bps_rd_max, bps_wr_max, and iops_size in the functions
qemuDomainSetBlockIoTune
and qemuDomainGetBlockIoTune.
The last patch add support for these parameters to the virsh blkdeviotune
command.
v2: -Spellfix
v3: -M
Add the new throttle options to virsh, and send them to libvirt.
Signed-off-by: Matthias Gatto
---
tools/virsh-domain.c | 119 +++
tools/virsh.pod | 10 +
2 files changed, 129 insertions(+)
diff --git a/tools/virsh-domain.c b/tools/virsh
Add support for bps_max and friends in the driver part.
In the part checking if a qemu is running, check if the running binary
support bps_max, if not print an error message, if yes add it to
"info" variable
Signed-off-by: Matthias Gatto
---
include/libvirt/libvirt-domain.h | 56
s
Check the arability of the options with the current qemu binary,
add them in the varable opt if yes, print a message if not.
Signed-off-by: Matthias Gatto
---
src/qemu/qemu_command.c | 57 -
1 file changed, 56 insertions(+), 1 deletion(-)
diff --g
On 10/06/2014 11:49 PM, John Ferlan wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1146837
>
> Resolve a crash in libvirtd resulting from commit id 'a4bd62ad' (1.0.6)
> which added parentaddr and unique_id to allow unique identification of
> a scsi_host, but assumed that all the pool entries
On Tuesday 28 October 2014 05:32 PM, Daniel P. Berrange wrote:
> On Tue, Oct 28, 2014 at 04:43:59PM +0530, Prerna Saxena wrote:
>> Apologies, I accidentally posted the older version. Pls ignore the
>> previously posted patch 2/3. The updated patch is here :
>>
>> >From a98d6787dc4f1d39ae36d78799ec
On Wed, Oct 29, 2014 at 05:04:22PM +0530, Prerna Saxena wrote:
>
> On Tuesday 28 October 2014 05:32 PM, Daniel P. Berrange wrote:
> > On Tue, Oct 28, 2014 at 04:43:59PM +0530, Prerna Saxena wrote:
> >>
> >> This patch allows libvirt to extend the "fallback" semantics of cpu model
> >> to
> >> des
On Wed, Oct 29, 2014 at 11:48:36AM +0800, Daniel Veillard wrote:
> As planned beginning of this week, I just tagged 1.2.10-rc1 in git
> and pushed signed tarballs and rpms to the usual place:
>
>ftp://libvirt.org/libvirt/
>
> The plan would be to get the rc2 out this friday, and push the
>
Signed-off-by: Chen Fan
---
src/lxc/lxc_controller.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/lxc/lxc_controller.c b/src/lxc/lxc_controller.c
index 1861dd6..a23dff7 100644
--- a/src/lxc/lxc_controller.c
+++ b/src/lxc/lxc_controller.c
@@ -689,6 +689,7 @@ static int
virLXCController
For memnode in numatune element, the range of attribute 'nodeset'
was not validated. on my host maxnodes was 1, but when setting nodeset
to '0-2' or more, guest also started succuss. there probably was qemu's
bug too.
Signed-off-by: Chen Fan
---
src/conf/numatune_conf.c
when setting elements memnode and nodeset in attribute numatune more
than the host nodes in XML file, VM boot should fail. so add check for
that.
Chen Fan (3):
numatune: add check for numatune nodeset range
lxc controller: add check for numatune
virnuma: remove redundant check for numanode
Signed-off-by: Chen Fan
---
src/util/virnuma.c | 15 ---
1 file changed, 15 deletions(-)
diff --git a/src/util/virnuma.c b/src/util/virnuma.c
index fbe8fd1..5a08049 100644
--- a/src/util/virnuma.c
+++ b/src/util/virnuma.c
@@ -95,31 +95,16 @@ virNumaSetupMemoryPolicy(virDomainNumatune
On 10/29/2014 07:31 AM, Ján Tomko wrote:
> On 10/06/2014 11:49 PM, John Ferlan wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1146837
>>
>> Resolve a crash in libvirtd resulting from commit id 'a4bd62ad' (1.0.6)
>> which added parentaddr and unique_id to allow unique identification of
>> a
On Wed, Oct 29, 2014 at 08:33:32PM +0800, Chen Fan wrote:
For memnode in numatune element, the range of attribute 'nodeset'
was not validated. on my host maxnodes was 1, but when setting nodeset
to '0-2' or more, guest also started succuss. there probably was qemu's
bug too.
How about rewordin
On Wed, Oct 29, 2014 at 08:33:34PM +0800, Chen Fan wrote:
Signed-off-by: Chen Fan
---
src/util/virnuma.c | 15 ---
1 file changed, 15 deletions(-)
I think this harmless check may prevent future problems (if
SetupMemoryPolicy is called from some new codepath. Either keep it
here or
Quoting Cédric Bosdonnat (cbosdon...@suse.com):
> Without this patch, kvm and kqemu domains confined with apparmor can't start
> due to virt-aa-helper not finding TEMPLATE.kvm or TEMPLATE.kqemu. This patch
> points all kvm-related drivers to TEMPLATE.qemu.
D'oh, I dropped the ball here. I had a p
On 10/29/2014 01:49 PM, John Ferlan wrote:
>
>
> On 10/29/2014 07:31 AM, Ján Tomko wrote:
>> On 10/06/2014 11:49 PM, John Ferlan wrote:
>>> https://bugzilla.redhat.com/show_bug.cgi?id=1146837
>>>
>>> Resolve a crash in libvirtd resulting from commit id 'a4bd62ad' (1.0.6)
>>> which added parentadd
Ping.
On Sun, Oct 12, 2014 at 02:12:20PM +0200, Martin Kletzander wrote:
This function is used to cleanup a pidfile doing whatever it takes, even
killing the owning process.
Signed-off-by: Martin Kletzander
---
v2:
- Don't use "/proc", but simply just try to acquire the pidfile.
- https://www.
As discussed before, this simple script should help with debugging
deadlocks, although there are still some caveats. RWLocks are not
handled by this and if your deadlock if very racy, it may not lock
up when running with this script due to the slowdown.
Signed-off-by: Martin Kletzander
---
exam
Drvbhyve hardcodes bhyveload(8) as the host bootloader for guests.
bhyveload(8) loader only supports FreeBSD guests.
This patch series adds and handling to
bhyve_command, so libvirt can boot non-FreeBSD guests in Bhyve.
Additionally, support for grub-bhyve(1)'s --cons-dev argument is added so t
This enables booting interactive GRUB menus (e.g. install CDs) with
libvirt-bhyve.
Caveat: A terminal other than the '--console' option to 'virsh start'
(e.g. 'cu -l /dev/nmdm0B -s 115200') must be used to connect to
grub-bhyve because the bhyve loader path is synchronous and must occur
before the
---
.../bhyvexml2argv-acpiapic.ldargs | 1 +
tests/bhyvexml2argvdata/bhyvexml2argv-base.ldargs | 1 +
.../bhyvexml2argvdata/bhyvexml2argv-console.ldargs | 1 +
.../bhyvexml2argv-disk-cdrom.ldargs| 1 +
.../bhyvexml2argv-disk-virtio.ldargs | 1 +
---
.../bhyvexml2argv-serial-grub.args | 4
.../bhyvexml2argv-serial-grub.devmap | 1 +
.../bhyvexml2argv-serial-grub.ldargs | 2 ++
.../bhyvexml2argv-serial-grub.xml | 26 ++
tests/bhyvexml2argvtest.c
We still default to bhyveloader(1) if no explicit bootloader
configuration is supplied in the domain.
If the /domain/bootloader looks like grub-bhyve and the user doesn't
supply /domain/bootloader_args, we make an intelligent guess and try
chainloading the first partition on the disk (or a CD if o
---
.../bhyvexml2argv-bhyveload-explicitargs.args | 3 +++
.../bhyvexml2argv-bhyveload-explicitargs.ldargs| 1 +
.../bhyvexml2argv-bhyveload-explicitargs.xml | 23 +
.../bhyvexml2argv-custom-loader.args | 3 +++
.../bhyvexml2argv-custom-loader.ld
Additionally, make the tag optional (for bhyveload with
custom arguments) (also, matches the actual parser).
---
docs/schemas/domaincommon.rng | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
index
On 10/29/2014 09:33 AM, Ján Tomko wrote:
> On 10/29/2014 01:49 PM, John Ferlan wrote:
<...snip...>
>> I think I'm missing your point. The finding of duplicate sources for
>> storage pools and disallowing them to be defined (or created) has been
>> around since commit id '5a1f27287".
>>
>> I'm no
There was one message used for all parsing errors in the blkio code.
This series fixes it in both qemu and lxc drivers where the code is
used.
Martin Kletzander (2):
qemu: improve error message for invalid blkiotune settings
lxc: improve error message for invalid blkiotune settings
src/lxc/l
Before:
$ virsh blkiotune dummy --device-read-bytes-sec /dev/sda,-1
error: Unable to change blkio parameters
error: invalid argument: unable to parse blkio device
'device_read_bytes_sec' '/dev/sda,-1'
After:
$ virsh blkiotune dummy --device-read-bytes-sec /dev/sda,-1
error: Unable to c
Before:
$ virsh blkiotune dummy --device-read-bytes-sec /dev/sda,-1
error: Unable to change blkio parameters
error: invalid argument: unable to parse blkio device
'device_read_bytes_sec' '/dev/sda,-1'
After:
$ virsh blkiotune dummy --device-read-bytes-sec /dev/sda,-1
error: Unable to c
On 10/29/2014 03:56 PM, John Ferlan wrote:
>
>
> On 10/29/2014 09:33 AM, Ján Tomko wrote:
>> On 10/29/2014 01:49 PM, John Ferlan wrote:
>
> <...snip...>
>>> I think I'm missing your point. The finding of duplicate sources for
>>> storage pools and disallowing them to be defined (or created) has
On 10/29/2014 04:12 AM, Peter Krempa wrote:
> See patch 1 for explanation.
>
> Peter Krempa (2):
> storage: Fix crash when parsing backing store URI with schema
> test: Add test to verify helpers used for backing file name parsing
>
> src/util/virstoragefile.c | 10 +-
> tests/virsto
On 10/28/2014 03:55 PM, Michal Privoznik wrote:
> On 28.10.2014 21:34, Eric Blake wrote:
>> Based on a comment I just made while reviewing Dan's patches,
>> we might as well adopt a consistent style of relying on the
>> C guarantee that static variables are automatically
>> zero-initialized without
Hi all,
The recent commit with SHA1 cc0e8c244d080f56392278e836cc378ba848e7aa,
"util: Functions to update host network device's multicast filter,"
breaks the build on FreeBSD, so please address this before 1.2.10
release.
Here is the output from Clang:
CC util/libvirt_util_la-virnetdev.lo
On 10/29/14 16:50, Eric Blake wrote:
> On 10/29/2014 04:12 AM, Peter Krempa wrote:
>> See patch 1 for explanation.
>>
>> Peter Krempa (2):
>> storage: Fix crash when parsing backing store URI with schema
>> test: Add test to verify helpers used for backing file name parsing
>>
>> src/util/virs
On 10/29/2014 05:26 AM, Michal Privoznik wrote:
On 24.10.2014 11:17, Erik Skultety wrote:
When user calls setmem on a running LXC machine, we do update its cgroup
entry (which is in odds with the original bug report, possibly resolved
by later versions), however we neither update domain's runt
It makes sense for none of the callers to have negative value as an
output and, fortunately, if anyone tried defining domain with negative
memory or any other value parsed by virDomainParseScaledValue(), the
resulting value was 0. That means we can error out during parsing as
it won't break anythi
On 10/29/2014 06:30 AM, Daniel Veillard wrote:
> On Wed, Oct 29, 2014 at 11:48:36AM +0800, Daniel Veillard wrote:
>> As planned beginning of this week, I just tagged 1.2.10-rc1 in git
>> and pushed signed tarballs and rpms to the usual place:
>>
>>ftp://libvirt.org/libvirt/
>>
>> The plan wou
Conrad Meyer wrote:
> Hi all,
>
> The recent commit with SHA1 cc0e8c244d080f56392278e836cc378ba848e7aa,
> "util: Functions to update host network device's multicast filter,"
> breaks the build on FreeBSD, so please address this before 1.2.10
> release.
>
> Here is the output from Clang:
>
>
The virGetSCSIHostNumber function return type is int, however
its stubbed version returns NULL. That results in a build fail
on systems that uses the stubbed version. Fix by using a proper
return type.
---
src/util/virutil.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/u
Currently, build fails on FreeBSD because its struct ifreq does not
have ifr_hwaddr member. In order to fix that, check if this member
is present, otherwise fall back to the stub version of the
virNetDev{Add,Del}Multi functions.
---
configure.ac | 3 ++-
src/util/virnetdev.c | 6 --
2
On 10/29/2014 02:08 PM, Roman Bogorodskiy wrote:
> Conrad Meyer wrote:
>
>> Hi all,
>>
>> The recent commit with SHA1 cc0e8c244d080f56392278e836cc378ba848e7aa,
>> "util: Functions to update host network device's multicast filter,"
>> breaks the build on FreeBSD, so please address this before 1.2.
Laine Stump wrote:
> On 10/29/2014 02:08 PM, Roman Bogorodskiy wrote:
> > Conrad Meyer wrote:
> >
> >> Hi all,
> >>
> >> The recent commit with SHA1 cc0e8c244d080f56392278e836cc378ba848e7aa,
> >> "util: Functions to update host network device's multicast filter,"
> >> breaks the build on FreeB
On 10/29/2014 02:20 PM, Roman Bogorodskiy wrote:
> Currently, build fails on FreeBSD because its struct ifreq does not
> have ifr_hwaddr member. In order to fix that, check if this member
> is present, otherwise fall back to the stub version of the
> virNetDev{Add,Del}Multi functions.
> ---
> co
On 10/28/2014 10:28 PM, Michal Privoznik wrote:
> On 28.10.2014 15:31, Eric Blake wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1140981 reports that
>> the qemu-kvm shipped as part of RHEL 7.0 intentionally cripples
>> block jobs by removing the 'block-stream' QMP command, but that
>> our p
[I realized I only sent this directly Roman - so I'll put it on list too]
On 10/29/2014 02:20 PM, Roman Bogorodskiy wrote:
> The virGetSCSIHostNumber function return type is int, however
> its stubbed version returns NULL. That results in a build fail
> on systems that uses the stubbed version.
On 10/10/2014 01:55 PM, akrow...@linux.vnet.ibm.com wrote:
> From: Tony Krowiak
>
> This patch provides the utility functions to needed to synchronize the
> changes made to a guest domain network device's multicast filter
> with the corresponding macvtap device's filter on the host:
>
> * Get/
Coverity discovered a few issues with recent changes in this module
from commit id 'cc0e8c24'. This patches fixes those.
Signed-off-by: John Ferlan
---
src/util/virnetdev.c | 37 +
1 file changed, 21 insertions(+), 16 deletions(-)
diff --git a/src/util/virne
On 10/29/2014 03:28 PM, John Ferlan wrote:
> Coverity discovered a few issues with recent changes in this module
> from commit id 'cc0e8c24'. This patches fixes those.
Might be nice to summarize what those errors were.
>
> Signed-off-by: John Ferlan
> ---
> src/util/virnetdev.c | 37 +
On 10/29/2014 05:44 PM, Eric Blake wrote:
> On 10/29/2014 03:28 PM, John Ferlan wrote:
>> Coverity discovered a few issues with recent changes in this module
>> from commit id 'cc0e8c24'. This patches fixes those.
>
> Might be nice to summarize what those errors were.
>
>>
>> Signed-off-by: Jo
On 10/29/2014 10:35 AM, Martin Kletzander wrote:
> It makes sense for none of the callers to have negative value as an
> output and, fortunately, if anyone tried defining domain with negative
> memory or any other value parsed by virDomainParseScaledValue(), the
> resulting value was 0. That means
A reposting of a patch into 3 separate patches for each of the Coverity
issues found from commit id 'cc0e8c24'. The changes were already ACK'd,
but I figured I'd repost anyway.
v1:
http://www.redhat.com/archives/libvir-list/2014-October/msg01012.html
John Ferlan (3):
virnetdev: Resolve Coverit
The complaint is that if cleanup is called when virFileReadAll fails,
then mcast->entries is NULL and could be dereferenced in the clear
function. After following the code some - I saw that the caller to
the function (virNetDevGetMulticastTable) will also call
virNetDevMcastListClear if this functi
Coverity complains that because the for loop is from 0 to 5 (max tokens)
and the impending switch/case statements used each of the #define values
that the 'default' wouldn't reachable. This patch will convert the #define's
into enum's and add the obligatory dead_error_begin marker for these type
si
virFileReadAll returns a chunk of memory that needs to be free'd when
done
Signed-off-by: John Ferlan
---
src/util/virnetdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c
index 4fea4cb..0c9c1f9 100644
--- a/src/util/virnetdev.c
+++ b/src/util/v
On 10/29/2014 04:50 PM, John Ferlan wrote:
> A reposting of a patch into 3 separate patches for each of the Coverity
> issues found from commit id 'cc0e8c24'. The changes were already ACK'd,
> but I figured I'd repost anyway.
Thanks; looks better, and good for 1.2.10.
>
> v1:
>
> http://www.red
Ethernet interfaces in libvirt currently do not support bandwidth setting.
For example, following xml file for an interface will not apply these
settings to corresponding qdiscs.
Signed-off-by: Anirban Chakraborty
---
src/con
I have a file with an ceph-based backing store. I run this command:
nova boot vm-clone
where vm-clone is the rbd-backed file. It generates this command:
qemu-img create -f qcow2 -b
rbd:rbdpool/disk/instance-0002.0.disk:conf=/etc/ceph/ceph.conf:id=admin -F
raw /mnt/novadisk/nova/i
> -Original Message-
> From: libvir-list-boun...@redhat.com [mailto:libvir-list-boun...@redhat.com]
> On Behalf Of Martin Kletzander
> Sent: Wednesday, October 29, 2014 11:45 PM
> To: libvir-list@redhat.com
> Subject: [libvirt] [PATCH 2/2] lxc: improve error message for invalid
> blkiotu
On Wed, 2014-10-29 at 14:23 +0100, Martin Kletzander wrote:
> On Wed, Oct 29, 2014 at 08:33:34PM +0800, Chen Fan wrote:
> >Signed-off-by: Chen Fan
> >---
> > src/util/virnuma.c | 15 ---
> > 1 file changed, 15 deletions(-)
> >
>
> I think this harmless check may prevent future problem
On Wed, 2014-10-29 at 14:20 +0100, Martin Kletzander wrote:
> On Wed, Oct 29, 2014 at 08:33:32PM +0800, Chen Fan wrote:
> >For memnode in numatune element, the range of attribute 'nodeset'
> >was not validated. on my host maxnodes was 1, but when setting nodeset
> >to '0-2' or more, guest also sta
After use cidr_format in function virAsprintf and vshPrintExtra, need free
cidr_format.
Fix the following memory leak from valgrind, like:
18 bytes in 1 blocks are definitely lost in loss record 41 of 192
at 0x4C29BBD: malloc (in
/usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
by
when setting elements memnode and nodeset in attribute numatune more
than the host nodes in XML file, VM boot should fail. so add check for
that.
Chen Fan (3):
bitmap: add virBitmapLastSetBit for finding the last bit position of
bitmap
numatune: add check for numatune nodeset range
virnu
Signed-off-by: Chen Fan
---
src/libvirt_private.syms | 1 +
src/util/virbitmap.c | 45 +
src/util/virbitmap.h | 3 +++
tests/virbitmaptest.c| 13 -
4 files changed, 61 insertions(+), 1 deletion(-)
diff --git a/src/libvirt_priv
Signed-off-by: Chen Fan
---
src/util/virnuma.c | 23 ---
1 file changed, 4 insertions(+), 19 deletions(-)
diff --git a/src/util/virnuma.c b/src/util/virnuma.c
index 4188ef5..613a43c 100644
--- a/src/util/virnuma.c
+++ b/src/util/virnuma.c
@@ -95,31 +95,19 @@ virNumaSetupMemor
There was no check for 'nodeset' attribute in numatune-related
elements. This patch adds validation that any nodeset specified does
not exceed maximum host node.
Signed-off-by: Chen Fan
---
src/conf/numatune_conf.c | 28
src/conf/numatune_conf.h
John Ferlan wrote:
> On 10/29/2014 02:20 PM, Roman Bogorodskiy wrote:
> > Currently, build fails on FreeBSD because its struct ifreq does not
> > have ifr_hwaddr member. In order to fix that, check if this member
> > is present, otherwise fall back to the stub version of the
> > virNetDev{Add,De
John Ferlan wrote:
> On 10/29/2014 02:20 PM, Roman Bogorodskiy wrote:
> > The virGetSCSIHostNumber function return type is int, however
> > its stubbed version returns NULL. That results in a build fail
> > on systems that uses the stubbed version. Fix by using a proper
> > return type.
> > ---
In subject: I've added "virsh:" designator to make clear which part of
the code the patch touches.
On 10/30/14 03:35, Luyao Huang wrote:
> After use cidr_format in function virAsprintf and vshPrintExtra, need free
> cidr_format.
And clarified this sentence a bit.
>
> Fix the following memory le
On 10/30/14 03:35, Luyao Huang wrote:
> After use cidr_format in function virAsprintf and vshPrintExtra, need free
> cidr_format.
>
> Fix the following memory leak from valgrind, like:
> 18 bytes in 1 blocks are definitely lost in loss record 41 of 192
> at 0x4C29BBD: malloc (in
> /usr/lib64
Conrad Meyer wrote:
> This enables booting interactive GRUB menus (e.g. install CDs) with
> libvirt-bhyve.
>
> Caveat: A terminal other than the '--console' option to 'virsh start'
> (e.g. 'cu -l /dev/nmdm0B -s 115200') must be used to connect to
> grub-bhyve because the bhyve loader path is sy
On 10/30/2014 02:27 PM, Peter Krempa wrote:
On 10/30/14 03:35, Luyao Huang wrote:
After use cidr_format in function virAsprintf and vshPrintExtra, need free
cidr_format.
Fix the following memory leak from valgrind, like:
18 bytes in 1 blocks are definitely lost in loss record 41 of 192
Particularly in qemuBuildNumaArgStr(), there was a need for the advice
due to memory backing, which needs to know the nodeset it will be pinned
to. With newer qemu this caused the following error when starting
domain:
error: internal error: Advice from numad is needed in case of
automatic num
On Thu, Oct 30, 2014 at 02:23:00AM +, Chen, Fan wrote:
On Wed, 2014-10-29 at 14:20 +0100, Martin Kletzander wrote:
On Wed, Oct 29, 2014 at 08:33:32PM +0800, Chen Fan wrote:
>diff --git a/src/util/virnuma.c b/src/util/virnuma.c
>@@ -373,6 +400,12 @@ virNumaGetNodeCPUs(int node ATTRIBUTE_UNUSE
88 matches
Mail list logo
