From libvirt.org we know this attribute named:
interface_mac MAC address of the network interface, not unique
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/access/viraccessdriverpolkit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On 04.11.2014 18:19, Prerna Saxena wrote:
This patch series is a collection of enhancements for PowerPC CPUs on PowerKVM.
The v5 of this series has been acked. I have just rebased the patches on top of
latest master and added a testcase.
Series Summary:
==
Patch 1/5 : Introduce a new
introduce by commit c63ef0452b, when nodeset is NULL, validation
will pass in virNumaSetupMemoryPolicy, but virBitmapNextSetBit
must ensure bitmap is not Null. there will cause a segmentation
fault. this patch fixed it.
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/util/virnuma.c
On 11/07/2014 09:24 AM, Luyao Huang wrote:
From libvirt.org we know this attribute named:
interface_mac MAC address of the network interface, not unique
Shouldn't we instead be fixing the docs to match the code? Changing the
code now may break existing implementations that have used the name
On 11/06/2014 11:08 PM, Chris Friesen wrote:
The libvirt.org docs say A virtual hardware watchdog device can be
added to the guest via the watchdog elementCurrently libvirt does
not support notification when the watchdog fires. This feature is
planned for a future version of libvirt.
Is
On 06.11.2014 17:38, Martin Kletzander wrote:
There were unnecessary curly braces in few places (and the whole esx
driver), so this series proposes fixing them. As this couldn't be
done automatically, there is no syntax-check. We have to keep trying
to eliminate that ;)
Martin Kletzander
On 11/04/2014 03:15 PM, Cédric Bosdonnat wrote:
If detect_scsi_host_caps reports errors but keeps libvirtd going on
startup, the user is mislead by the error messages. Transforming them
s/mislead/misled/
into warning still shows the problems, but indicates this is not fatal.
---
From virAccessDriverPolkitCheckInterface function, we know this
attribute should named: interface_macaddr
Signed-off-by: Luyao Huang lhu...@redhat.com
---
docs/aclpolkit.html.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/aclpolkit.html.in b/docs/aclpolkit.html.in
On 2014/11/5 16:07, Martin Kletzander wrote:
[...]
diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c
index b5bdb36..8685d6f 100644
--- a/src/qemu/qemu_cgroup.c
+++ b/src/qemu/qemu_cgroup.c
@@ -618,6 +618,11 @@ qemuSetupCpusetMems(virDomainObjPtr vm,
if
On 11/07/2014 05:15 PM, Eric Blake wrote:
On 11/07/2014 09:24 AM, Luyao Huang wrote:
From libvirt.org we know this attribute named:
interface_mac MAC address of the network interface, not unique
Shouldn't we instead be fixing the docs to match the code? Changing the
code now may break
On 11/06/2014 05:38 PM, Martin Kletzander wrote:
There were unnecessary curly braces in few places (and the whole esx
driver), so this series proposes fixing them. As this couldn't be
done automatically, there is no syntax-check. We have to keep trying
to eliminate that ;)
I'm a little bit
On 11/06/2014 05:38 PM, Martin Kletzander wrote:
These were probably left there after some code movement.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/vbox/vbox_common.c | 23 ++-
1 file changed, 6 insertions(+), 17 deletions(-)
ACK to this one,
On 11/07/2014 10:37 AM, lhuang wrote:
On 11/07/2014 05:15 PM, Eric Blake wrote:
On 11/07/2014 09:24 AM, Luyao Huang wrote:
From libvirt.org we know this attribute named:
interface_macMAC address of the network interface, not unique
Shouldn't we instead be fixing the docs to match the
On 11/07/2014 10:35 AM, Luyao Huang wrote:
From virAccessDriverPolkitCheckInterface function, we know this
attribute should named: interface_macaddr
Signed-off-by: Luyao Huang lhu...@redhat.com
---
docs/aclpolkit.html.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
ACK. I
On 11/07/2014 10:47 AM, Eric Blake wrote:
On 11/07/2014 10:35 AM, Luyao Huang wrote:
From virAccessDriverPolkitCheckInterface function, we know this
attribute should named: interface_macaddr
Eww. 'git am' strips an initial commit line beginning with From , if
it doesn't match an email address
On Thu, Nov 06, 2014 at 05:38:25PM +0100, Martin Kletzander wrote:
There were unnecessary curly braces in few places (and the whole esx
driver), so this series proposes fixing them. As this couldn't be
done automatically, there is no syntax-check. We have to keep trying
to eliminate that ;)
Ján Tomko (2):
Use UPDATE_CPU when saving domain status
Ignore missing CPU model for HOST_PASSTHROUGH
src/conf/cpu_conf.c| 4 +-
src/conf/domain_conf.c | 1 +
...argv-cpu-host-passthrough-features-invalid.args | 22 +
On 11/07/2014 05:45 PM, Eric Blake wrote:
On 11/07/2014 10:37 AM, lhuang wrote:
On 11/07/2014 05:15 PM, Eric Blake wrote:
On 11/07/2014 09:24 AM, Luyao Huang wrote:
From libvirt.org we know this attribute named:
interface_macMAC address of the network interface, not unique
Shouldn't we
Accept a list of features for HOST_PASSTHROUGH even without
a model specified, to catch domains started with older libvirtd.
(We already accept the list of features with a model specified,
even though they have no effect for HOST_PASSTHROUGH)
https://bugzilla.redhat.com/show_bug.cgi?id=1030793
We only format cpu model for MODE_CUSTOM in domain status XML,
but we always format features if they are present.
This is a problem if we have a domain using MODE_HOST_PASSTHROUGH
that has been managedsaved, then restored, since it now has
a feature list but no model in /var/run/libvirt/qemu.
On 11/07/2014 05:53 PM, Eric Blake wrote:
On 11/07/2014 10:47 AM, Eric Blake wrote:
On 11/07/2014 10:35 AM, Luyao Huang wrote:
From virAccessDriverPolkitCheckInterface function, we know this
attribute should named: interface_macaddr
Eww. 'git am' strips an initial commit line beginning with
On 11/06/2014 05:38 PM, Martin Kletzander wrote:
As stated in our contributor guidelines, we don't want curly brackets
around oneline code block (with some exceptions).
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
+++ b/src/conf/capabilities.c
@@ -219,9 +219,8 @@
On Fri, Nov 07, 2014 at 11:09:11AM +0100, Eric Blake wrote:
On 11/06/2014 05:38 PM, Martin Kletzander wrote:
As stated in our contributor guidelines, we don't want curly brackets
around oneline code block (with some exceptions).
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
nodeSetMemoryParameters() will call nodeSetMemoryParameterValue()
to set parameters. But it just filter the return code '-2' as
failure. Indeed we should report error when rc is negative.
https://bugzilla.redhat.com/show_bug.cgi?id=1161541
Signed-off-by: Jincheng Miao jm...@redhat.com
---
Reference :
===
v1: http://www.spinics.net/linux/fedora/libvir/msg105516.html
Changes since v1:
===
1) As suggested by Michal, a new function virCPUNumaCellMemoryParseXML has
been introduced for neat computation of NUMA memory.
2) Patches 2 3 of v1 have been merged together into this
On Fri, Nov 07, 2014 at 05:36:43PM +0800, Wang Rui wrote:
On 2014/11/5 16:07, Martin Kletzander wrote:
[...]
diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c
index b5bdb36..8685d6f 100644
--- a/src/qemu/qemu_cgroup.c
+++ b/src/qemu/qemu_cgroup.c
@@ -618,6 +618,11 @@
On Fri, Nov 07, 2014 at 10:43:47AM +0100, Eric Blake wrote:
On 11/06/2014 05:38 PM, Martin Kletzander wrote:
These were probably left there after some code movement.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/vbox/vbox_common.c | 23 ++-
1 file changed, 6
On Wed, Oct 29, 2014 at 1:15 PM, Matthias Gatto
matthias.ga...@outscale.com wrote:
This series of patches add support for bps_max, bps_rd_max, bps_wr_max,
bps_max, bps_rd_max, bps_wr_max, and iops_size in the functions
qemuDomainSetBlockIoTune
and qemuDomainGetBlockIoTune.
The last patch add
Dear Libvirt: How do I get the progress of a long operation (such as
Snapshot take and recover )through libvirt API?
Thankyou.--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On 11/07/2014 02:24 PM, windy wrote:
Dear Libvirt: How do I get the progress of a long operation (such as
Snapshot take and recover )through libvirt API?
virsh exists as a sample of how to do this for several long-running APIs.
Some APIs are (currently) blocking-only; for those, you
On 11/07/2014 03:14 AM, Eric Blake wrote:
On 11/06/2014 11:08 PM, Chris Friesen wrote:
The libvirt.org docs say A virtual hardware watchdog device can be
added to the guest via the watchdog elementCurrently libvirt does
not support notification when the watchdog fires. This feature is
As reviewing patches upstream it occurred to me, that we have two
functions doing nearly the same: virDomainParseMemory which
expects XML in the following format:
memory unit='MiB'1337/memory
The other function being virDomainHugepagesParseXML expecting the
following format:
someElement
On 11/07/2014 05:09 AM, Eric Blake wrote:
On 11/06/2014 05:38 PM, Martin Kletzander wrote:
@@ -138,9 +138,9 @@ virDevicePCIAddressEqual(virDevicePCIAddress *addr1,
if (addr1-domain == addr2-domain
addr1-bus == addr2-bus
addr1-slot == addr2-slot
-
On 07.11.2014 12:17, Prerna Saxena wrote:
Reference :
===
v1: http://www.spinics.net/linux/fedora/libvir/msg105516.html
Changes since v1:
===
1) As suggested by Michal, a new function virCPUNumaCellMemoryParseXML has
been introduced for neat computation of NUMA memory.
2) Patches 2
On Fri, 2014-11-07 at 10:31 +0100, Eric Blake wrote:
On 11/04/2014 03:15 PM, Cédric Bosdonnat wrote:
If detect_scsi_host_caps reports errors but keeps libvirtd going on
startup, the user is mislead by the error messages. Transforming them
s/mislead/misled/
into warning still shows the
On Fri, Nov 07, 2014 at 15:30:10 +0100, Michal Privoznik wrote:
As reviewing patches upstream it occurred to me, that we have two
functions doing nearly the same: virDomainParseMemory which
expects XML in the following format:
memory unit='MiB'1337/memory
The other function being
On 29.10.2014 13:16, Matthias Gatto wrote:
Add support for bps_max and friends in the driver part.
In the part checking if a qemu is running, check if the running binary
support bps_max, if not print an error message, if yes add it to
info variable
Signed-off-by: Matthias Gatto
On 29.10.2014 13:15, Matthias Gatto wrote:
This series of patches add support for bps_max, bps_rd_max, bps_wr_max,
bps_max, bps_rd_max, bps_wr_max, and iops_size in the functions
qemuDomainSetBlockIoTune
and qemuDomainGetBlockIoTune.
The last patch add support for these parameters to the virsh
On 29.10.2014 13:15, Matthias Gatto wrote:
Add defines for the new options total_bytes_sec_max, write_bytes_sec_max,
read_bytes_sec_max, total_iops_sec_max, write_iops_sec_max, read_iops_sec_max,
size_iops_sec.
Signed-off-by: Matthias Gatto matthias.ga...@outscale.com
---
On 29.10.2014 13:16, Matthias Gatto wrote:
Check the arability of the options with the current qemu binary,
add them in the varable opt if yes, print a message if not.
Signed-off-by: Matthias Gatto matthias.ga...@outscale.com
---
src/qemu/qemu_command.c | 57
On Fri, Nov 07, 2014 at 09:58:11AM -0500, Laine Stump wrote:
On 11/07/2014 05:09 AM, Eric Blake wrote:
On 11/06/2014 05:38 PM, Martin Kletzander wrote:
@@ -138,9 +138,9 @@ virDevicePCIAddressEqual(virDevicePCIAddress *addr1,
if (addr1-domain == addr2-domain
addr1-bus ==
On Fri, Nov 07, 2014 at 11:11:27AM +0100, Daniel P. Berrange wrote:
On Fri, Nov 07, 2014 at 11:09:11AM +0100, Eric Blake wrote:
On 11/06/2014 05:38 PM, Martin Kletzander wrote:
As stated in our contributor guidelines, we don't want curly brackets
around oneline code block (with some
On 11/07/2014 03:30 PM, Michal Privoznik wrote:
As reviewing patches upstream it occurred to me, that we have two
functions doing nearly the same: virDomainParseMemory which
expects XML in the following format:
memory unit='MiB'1337/memory
The other function being
Coverity found out that commit cd490086 caused a possible NULL pointer
dereference. This is due to the fact, that phyp_driver might be
NULL (if VIR_ALLOC() fails), but connection_data, which kept the socket
before the mentioned commit, could not be NULL.
Signed-off-by: Martin Kletzander
Don't bother reviewing this series - there's another related bug for
which I need to make some adjustments to 2/2 - so I'll just with that
fix as 3/3.
John
On 11/06/2014 03:57 PM, John Ferlan wrote:
Fix a couple of bugs related to attempting to start an fc_host with
incorrect 'parent'
45 matches
Mail list logo
